bakaphp / canvas-core

Failed Conditions

Pull Request — master (#320)

by Rafael

created 2020-03-11 19:16 UTC

Changes

2 failure conditions met `issues.label("coding-style").exists` File Path Number of issues src/Acl/Manager.php 19 src/Api/Controllers/CustomFiltersController.php 3 src/Api/Controllers/NotificationsController.php 1 src/Auth/App.php 3 Contracts/Notifications/NotificationInterfase.php 3 src/Contracts/Queue/QueueableJobInterfase.php 1 src/Dto/CustomFields.php 8 src/Dto/CustomFilter.php 6 src/Dto/Files.php 3 src/Dto/Notification.php 9 src/Dto/User.php 33 src/Jobs/Job.php 1 src/Models/AccessList.php 8 src/Models/Apps.php 9 src/Models/AppsPlans.php 10 src/Models/AppsPlansSettings.php 5 src/Models/AppsRoles.php 2 src/Models/CompaniesBranches.php 6 src/Models/CompaniesCustomFields.php 5 src/Models/CompaniesSettings.php 4 src/Models/Currencies.php 3 src/Models/CustomFieldsModules.php 4 src/Models/CustomFieldsSettings.php 4 src/Models/CustomFieldsTypes.php 3 src/Models/CustomFieldsTypesSettings.php 4 src/Models/CustomFieldsValues.php 5 src/Models/EmailTemplates.php 6 src/Models/EmailTemplatesVariables.php 7 src/Models/FileSystem.php 10 src/Models/FileSystemEntities.php 8 src/Models/FileSystemSettings.php 4 src/Models/Languages.php 3 src/Models/Locales.php 3 src/Models/Notifications.php 11 src/Models/NotificationType.php 7 src/Models/PaymentFrequencies.php 3 src/Models/Resources.php 4 src/Models/ResourcesAccesses.php 7 src/Models/RolesInherits.php 2 src/Models/UserCompanyApps.php 7 src/Models/UserCompanyAppsActivities.php 7 src/Models/UserConfig.php 3 src/Models/UserLinkedSources.php 6 src/Models/UserRoles.php 7 src/Models/UsersAssociatedApps.php 6 src/Models/UsersAssociatedCompanies.php 5 src/Models/UsersInvite.php 8 src/Models/Webhooks.php 5 src/Providers/FileSystemProvider.php 1 src/Queue/Queue.php 2 src/Traits/FractalTrait.php 2 src/Models/CompaniesAssociations.php 5 src/Models/CompaniesGroups.php 5 src/Dto/CompaniesGroups.php 5 src/Auth/Auth.php 3 src/Contracts/Notifications/NotifiableTrait.php 1 src/Core/functions.php 1 src/CustomFields/CustomFields.php 1 src/Hashing/Password.php 3 src/Jobs/PendingDispatch.php 1 src/Middleware/AclMiddleware.php 1 src/Middleware/NotFoundMiddleware.php 2 src/Notifications/Notification.php 1 src/Notifications/Notify.php 1 src/Providers/EventsManagerProvider.php 1 src/Traits/RequestJwtTrait.php 1 src/Validations/PasswordValidation.php 1 src/Models/Subscription.php 24 src/Middleware/AuthenticationMiddleware.php 1 src/Middleware/SubscriptionMiddleware.php 1 src/Api/Controllers/CustomFieldsController.php 3 src/Models/Companies.php 9 src/Traits/SubscriptionPlanLimitTrait.php 1 src/Models/AppsSettings.php 4 src/Api/Controllers/UsersController.php 2 src/Models/Roles.php 8 src/Models/UserWebhooks.php 7 src/Middleware/TokenBase.php 1 src/Models/SystemModules.php 10 src/Mapper/UserMapper.php 2 src/Models/Users.php 15 Contracts/Controllers/ProcessOutputMapperTrait.php 1 src/Traits/FileSystemModelTrait.php 6 src/Traits/PermissionsTrait.php 9 src/Models/Sources.php 4 more... `issues.severity(>= MAJOR).new.exists` File Path Number of issues src/Acl/Manager.php 19 src/Api/Controllers/CustomFiltersController.php 3 src/Api/Controllers/NotificationsController.php 1 src/Auth/App.php 3 Contracts/Notifications/NotificationInterfase.php 3 src/Contracts/Queue/QueueableJobInterfase.php 1 src/Dto/CustomFields.php 8 src/Dto/CustomFilter.php 6 src/Dto/Files.php 3 src/Dto/Notification.php 9 src/Dto/User.php 33 src/Jobs/Job.php 1 src/Models/AccessList.php 8 src/Models/Apps.php 9 src/Models/AppsPlans.php 10 src/Models/AppsPlansSettings.php 5 src/Models/AppsRoles.php 2 src/Models/CompaniesBranches.php 6 src/Models/CompaniesCustomFields.php 5 src/Models/CompaniesSettings.php 4 src/Models/Currencies.php 3 src/Models/CustomFieldsModules.php 4 src/Models/CustomFieldsSettings.php 4 src/Models/CustomFieldsTypes.php 3 src/Models/CustomFieldsTypesSettings.php 4 src/Models/CustomFieldsValues.php 5 src/Models/EmailTemplates.php 6 src/Models/EmailTemplatesVariables.php 7 src/Models/FileSystem.php 10 src/Models/FileSystemEntities.php 8 src/Models/FileSystemSettings.php 4 src/Models/Languages.php 3 src/Models/Locales.php 3 src/Models/Notifications.php 11 src/Models/NotificationType.php 7 src/Models/PaymentFrequencies.php 3 src/Models/Resources.php 4 src/Models/ResourcesAccesses.php 7 src/Models/RolesInherits.php 2 src/Models/UserCompanyApps.php 7 src/Models/UserCompanyAppsActivities.php 7 src/Models/UserConfig.php 3 src/Models/UserLinkedSources.php 6 src/Models/UserRoles.php 7 src/Models/UsersAssociatedApps.php 6 src/Models/UsersAssociatedCompanies.php 5 src/Models/UsersInvite.php 8 src/Models/Webhooks.php 5 src/Providers/FileSystemProvider.php 1 src/Queue/Queue.php 2 src/Traits/FractalTrait.php 2 src/Models/CompaniesAssociations.php 5 src/Models/CompaniesGroups.php 5 src/Dto/CompaniesGroups.php 5 src/Auth/Auth.php 3 src/Contracts/Notifications/NotifiableTrait.php 1 src/Core/functions.php 1 src/CustomFields/CustomFields.php 1 src/Hashing/Password.php 3 src/Jobs/PendingDispatch.php 1 src/Middleware/AclMiddleware.php 1 src/Middleware/NotFoundMiddleware.php 2 src/Notifications/Notification.php 1 src/Notifications/Notify.php 1 src/Providers/EventsManagerProvider.php 1 src/Traits/RequestJwtTrait.php 1 src/Validations/PasswordValidation.php 1 src/Models/Subscription.php 24 src/Middleware/AuthenticationMiddleware.php 1 src/Middleware/SubscriptionMiddleware.php 1 src/Api/Controllers/CustomFieldsController.php 3 src/Models/Companies.php 9 src/Traits/SubscriptionPlanLimitTrait.php 1 src/Models/AppsSettings.php 4 src/Api/Controllers/UsersController.php 2 src/Models/Roles.php 8 src/Models/UserWebhooks.php 7 src/Middleware/TokenBase.php 1 src/Models/SystemModules.php 10 src/Mapper/UserMapper.php 2 src/Models/Users.php 15 Contracts/Controllers/ProcessOutputMapperTrait.php 1 src/Traits/FileSystemModelTrait.php 6 src/Traits/PermissionsTrait.php 9 src/Models/Sources.php 4 Api/Controllers/UserLinkedSourcesController.php 1 more...
	2 issues (1 major, 1 minor) were introduced.
	2 new patches (Unused Use Statements) are available.
	2 added classes/operations
		A	UserLinkedSourcesController::validateAppleUser() added
		A	Sources::isApple() added
A	↘	B	UserLinkedSourcesController::devices() got worse

9.68

▶ ± 0

Test Coverage

4%

▶ ±0%

Head	Rafael White 2020-03-11 15:16 GMT-0400 Merge 8c569df9d971f749cfa30e1e71c7dd6821823a32 into 1f8f864be59ac1f30dc8a7c18ada4c1b909e7ae1
⋮	5 more commits
Base	Max Castro 2020-03-10 19:01 UTC Merge pull request #319 from bakaphp/add-apple-social