Completed
Pull Request — master (#4)
by
unknown
07:36
created
Controller/HybridEndPointController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -238,6 +238,9 @@
 block discarded – undo
238 238
 		}
239 239
 	}
240 240
 
241
+	/**
242
+	 * @param string $provider_id
243
+	 */
241 244
 	private function returnToCallbackUrl($provider_id) {
242 245
 		// get the stored callback url
243 246
 		$callback_url = $this->hybridAuth->storage()->get( "hauth_session.$provider_id.hauth_return_to" );
Please login to merge, or discard this patch.
Unused Use Statements   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -2,14 +2,10 @@
 block discarded – undo
2 2
 
3 3
 namespace Azine\HybridAuthBundle\Controller;
4 4
 
5
-use Symfony\Component\HttpFoundation\ParameterBag;
6
-
7
-use Symfony\Component\HttpFoundation\RedirectResponse;
8
-
9
-use Symfony\Component\HttpFoundation\Response;
10
-
11
-use Symfony\Component\HttpFoundation\Request;
12
-
5
+use Symfony\Component\HttpFoundation\ParameterBag;
6
+use Symfony\Component\HttpFoundation\RedirectResponse;
7
+use Symfony\Component\HttpFoundation\Response;
8
+use Symfony\Component\HttpFoundation\Request;
13 9
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
14 10
 
15 11
 class HybridEndPointController extends Controller {
Please login to merge, or discard this patch.
Services/AzineGenderGuesser.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -37,6 +37,9 @@
 block discarded – undo
37 37
 	
38 38
 	private $debugMsg = '';
39 39
 	
40
+	/**
41
+	 * @param string[] $matchList
42
+	 */
40 43
 	public function __construct($femaleNames=null, $malesNames=null, $merge = false, $matchList = null){
41 44
 		// Use the double_metaphone module if it's available, or fall back to the
42 45
 		// standard metaphone() PHP call if not
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,8 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Azine\HybridAuthBundle\Services;
3 3
 
4
-use Azine\HybridAuthBundle\Entity\UserContact;
5
-
6 4
 /**
7 5
  * 	https://github.com/petewarden/genderfromname/blob/master/genderfromname.php
8 6
 	
Please login to merge, or discard this patch.
Services/AzineMergedBusinessNetworksProvider.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 namespace Azine\HybridAuthBundle\Services;
3 3
 
4 4
 use Azine\HybridAuthBundle\Entity\UserContact;
5
-
6 5
 use Symfony\Component\HttpFoundation\Session\Session;
7 6
 
8 7
 class AzineMergedBusinessNetworksProvider {
Please login to merge, or discard this patch.
Services/GenderGuesser.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,9 +24,9 @@
 block discarded – undo
24 24
 	/**
25 25
 	 * Guess the gender for a given firstname. The guesser will return an array with
26 26
 	 * 
27
-	 * @param \string $firstName
27
+	 * @param string $firstName
28 28
 	 * @param int $looseness
29
-	 * @return \string sex => m | f
29
+	 * @return string sex => m | f
30 30
 	 */
31 31
 	public function gender($firstName, $looseness=1);	
32 32
 }
33 33
\ No newline at end of file
Please login to merge, or discard this patch.
Unused Use Statements   -8 removed lines patch added patch discarded remove patch
@@ -1,14 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Azine\HybridAuthBundle\Services;
3 3
 
4
-use Azine\HybridAuthBundle\Entity\UserContact;
5
-
6
-use Symfony\Component\HttpFoundation\Session\Session;
7
-
8
-use Azine\HybridAuthBundle\DependencyInjection\AzineHybridAuthExtension;
9
-
10
-use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
11
-
12 4
 interface GenderGuesser {
13 5
 
14 6
 	/**
Please login to merge, or discard this patch.
Tests/Services/AzineGenderGuesserTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Azine\HybridAuthBundle\Services;
3 3
 
4
-use Azine\HybridAuthBundle\Entity\UserContact;
5 4
 use Symfony\Bundle\FrameworkBundle\Tests\TestCase;
6 5
 
7 6
 class AzineGenderGuesserTest extends TestCase {
Please login to merge, or discard this patch.
Entity/UserContact.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@
 block discarded – undo
59 59
      * @param string | null $email
60 60
      * @param string | null $headline
61 61
      * @param array | null $tags array of strings
62
+     * @param string $gender
63
+     * @param string $firstName
64
+     * @param string $lastName
62 65
      */
63 66
     public function __construct($provider,
64 67
 								$gender = null,
Please login to merge, or discard this patch.
Services/AzineHybridAuth.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,13 +2,11 @@
 block discarded – undo
2 2
 namespace Azine\HybridAuthBundle\Services;
3 3
 
4 4
 use Azine\HybridAuthBundle\DependencyInjection\AzineHybridAuthExtension;
5
-
6 5
 use Azine\HybridAuthBundle\Entity\HybridAuthSessionData;
7 6
 use Doctrine\Common\Persistence\ObjectManager;
8 7
 use Symfony\Component\HttpFoundation\Cookie;
9 8
 use Symfony\Component\HttpFoundation\Request;
10 9
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
11
-use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
12 10
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
13 11
 use Symfony\Component\Security\Core\User\UserInterface;
14 12
 
Please login to merge, or discard this patch.
Doc Comments   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -59,12 +59,11 @@  discard block
 block discarded – undo
59 59
 	 *
60 60
 	 * @param UrlGeneratorInterface $router
61 61
 	 * @param UserInterface $user
62
-	 * @param TokenStorageInterface $tokenStorage
63 62
 	 * @param ObjectManager $manager
64 63
 	 * @param array $config
65 64
 	 * @param bool $storeForUser
66
-	 * @param $storeAsCookie
67
-	 * @param $expiresInDays
65
+	 * @param boolean $storeAsCookie
66
+	 * @param integer $expiresInDays
68 67
 	 */
69 68
 	public function __construct(UrlGeneratorInterface $router, UserInterface $user, ObjectManager $manager, $config, $storeForUser, $storeAsCookie, $expiresInDays){
70 69
 		$base_url = $router->generate($config[AzineHybridAuthExtension::ENDPOINT_ROUTE], array(), UrlGeneratorInterface::ABSOLUTE_URL);
@@ -83,7 +82,7 @@  discard block
 block discarded – undo
83 82
 	 * HybridAuthSessions will be restored from DB and/or cookies, according to the bundle configuration.
84 83
 	 *
85 84
 	 * @param $cookieSessionData
86
-	 * @param $provider
85
+	 * @param string $provider
87 86
 	 * @return \Hybrid_Auth
88 87
 	 */
89 88
 	public function getInstance($cookieSessionData, $provider){
@@ -201,7 +200,7 @@  discard block
 block discarded – undo
201 200
 	 * @param $authSessionData
202 201
 	 * @param string $provider_id
203 202
 	 * @param boolean $require_login
204
-	 * @return \Hybrid_Provider_Model
203
+	 * @return \Hybrid_Provider_Adapter
205 204
 	 */
206 205
 	public function getProvider($authSessionData, $provider_id, $require_login = true){
207 206
 		$adapter = $this->getInstance($authSessionData, $provider_id)->getAdapter($provider_id);
@@ -226,7 +225,7 @@  discard block
 block discarded – undo
226 225
 	
227 226
 	/**
228 227
      * Get the Xing Adapter
229
-     * @return \Hybrid_Providers_XING
228
+     * @return \Hybrid_Provider_Adapter
230 229
      */
231 230
 	public function getXing(){
232 231
 		return $this->getProvider(null, "xing");
@@ -235,7 +234,7 @@  discard block
 block discarded – undo
235 234
 	/**
236 235
 	 * Get the Xing api (OAuthClient)
237 236
 	 *
238
-	 * @return \OAuth1Client
237
+	 * @return \stdClass
239 238
 	 */
240 239
 	public function getXingApi(){
241 240
 		return $this->getXing()->api();
@@ -244,7 +243,7 @@  discard block
 block discarded – undo
244 243
 	/**
245 244
 	 * Get the LinkedIn Adapter
246 245
 	 *
247
-	 * @return \Hybrid_Providers_LinkedIn
246
+	 * @return \Hybrid_Provider_Adapter
248 247
 	 */
249 248
 	public function getLinkedIn(){
250 249
 		return $this->getProvider(null, "linkedin");
@@ -253,7 +252,7 @@  discard block
 block discarded – undo
253 252
     /**
254 253
      * Get the LinkedIn api (LinkedIn PHP-client)
255 254
      *
256
-     * @return \LinkedIn
255
+     * @return \stdClass
257 256
      */
258 257
 	public function getLinkedInApi(){
259 258
 		return $this->getLinkedIn()->api();
Please login to merge, or discard this patch.
Controller/AzineHybridAuthJsonController.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -6,11 +6,8 @@
 block discarded – undo
6 6
 use Azine\HybridAuthBundle\Services\AzineHybridAuth;
7 7
 use Azine\HybridAuthBundle\Services\AzineMergedBusinessNetworksProvider;
8 8
 use Symfony\Component\HttpFoundation\RedirectResponse;
9
-
10 9
 use Symfony\Component\HttpFoundation\JsonResponse;
11
-
12 10
 use Symfony\Component\HttpFoundation\Request;
13
-
14 11
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
15 12
 
16 13
 class AzineHybridAuthJsonController extends Controller {
Please login to merge, or discard this patch.