Completed
Pull Request — develop (#720)
by Imants
03:58
created
lib/Controller/Data/Mongo.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -36,6 +36,10 @@
 block discarded – undo
36 36
     public function _get($model,$key){
37 37
         return $model->_table[$this->short_name][$key];
38 38
     }
39
+
40
+    /**
41
+     * @param string $key
42
+     */
39 43
     public function _set($model,$key,$val){
40 44
         $model->_table[$this->short_name][$key]=$val;
41 45
     }
Please login to merge, or discard this patch.
lib/Controller/Validator/Abstract.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -232,6 +232,10 @@
 block discarded – undo
232 232
      * the default hook. This is done to avoid double-validation
233 233
      */
234 234
     public $custom_hook=false;
235
+
236
+    /**
237
+     * @param string $hook
238
+     */
235 239
     function on($hook,$object=null,$default_hook=false)
236 240
     {
237 241
         if(!$object)$object=$this->owner;
Please login to merge, or discard this patch.
lib/DB.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
      * @param string $statement for unsupported db's
241 241
      * @param string $table     for unsupported db's
242 242
      *
243
-     * @return int|mixed
243
+     * @return string
244 244
      */
245 245
     function lastID($statement = null, $table = null)
246 246
     {
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
      * So if you have been working with the database and got unhandled exception
262 262
      * in the middle of your code, everything would be rolled back.
263 263
      *
264
-     * @return mixed Don't rely on any meaningful return
264
+     * @return boolean Don't rely on any meaningful return
265 265
      */
266 266
     public function beginTransaction()
267 267
     {
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
      * issued to the database.
280 280
      *
281 281
      * @see beginTransaction()
282
-     * @return mixed Don't rely on any meaningful return
282
+     * @return boolean Don't rely on any meaningful return
283 283
      */
284 284
     public function commit()
285 285
     {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
      * Rollbacks queries since beginTransaction and resets transaction depth
329 329
      *
330 330
      * @see beginTransaction()
331
-     * @return mixed Don't rely on any meaningful return
331
+     * @return boolean Don't rely on any meaningful return
332 332
      */
333 333
     public function rollBack()
334 334
     {
Please login to merge, or discard this patch.
lib/Form/Field/DateSelector.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -112,6 +112,9 @@
 block discarded – undo
112 112
         $this->required = $is_required === true;
113 113
     }
114 114
 
115
+    /**
116
+     * @param double $to
117
+     */
115 118
     function setYearRange($from=null, $to=null){
116 119
         if(!is_numeric($from))
117 120
             $from = null;
Please login to merge, or discard this patch.
lib/Form/Field/Upload.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -182,6 +182,10 @@  discard block
 block discarded – undo
182 182
             json_encode($data).");</script></head></html>";
183 183
         exit;
184 184
     }
185
+
186
+    /**
187
+     * @param string $message
188
+     */
185 189
     function uploadFailed($message){
186 190
 
187 191
         $d='';
@@ -195,6 +199,9 @@  discard block
 block discarded – undo
195 199
         exit;
196 200
     }
197 201
 
202
+    /**
203
+     * @param string $val
204
+     */
198 205
     function convertToBytes($val){
199 206
         $val = trim($val);
200 207
         $last = strtolower($val[strlen($val) - 1]);
@@ -348,6 +355,10 @@  discard block
 block discarded – undo
348 355
         if(function_exists('mime_content_type'))return mime_content_type($this->getFilePath());
349 356
         return $_FILES[$this->name]['type'];
350 357
     }
358
+
359
+    /**
360
+     * @return string
361
+     */
351 362
     function getFilePath(){
352 363
         return $_FILES[$this->name]['tmp_name'];
353 364
     }
Please login to merge, or discard this patch.
lib/Lister.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@
 block discarded – undo
191 191
     /**
192 192
      * Sets default template
193 193
      *
194
-     * @return array
194
+     * @return string[]
195 195
      */
196 196
     function defaultTemplate()
197 197
     {
Please login to merge, or discard this patch.
lib/System/ProcessIO.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
      * this function  will be waiting.
144 144
      *
145 145
      * @param  string $res optional descriptor (either out or err)
146
-     * @return self
146
+     * @return string
147 147
      */
148 148
     function readLine($res='out'){
149 149
         $str=fgets($this->pipes[$res]);
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
      * Reads all output and returns. Closes stdout when EOF reached.
157 157
      *
158 158
      * @param  string $res optional descriptor (out or err)
159
-     * @return self
159
+     * @return string
160 160
      */
161 161
     function readAll($res='out'){
162 162
         $str='';
Please login to merge, or discard this patch.
lib/TMail/Compat.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -137,12 +137,17 @@  discard block
 block discarded – undo
137 137
      * - text: plain text
138 138
      * - html: HTML only
139 139
      * - both: text and HTML
140
+     * @param string $type
140 141
      */
141 142
     function setBodyType($type){
142 143
         if($type=='html'||$type=='text'||$type='both')$this->body_type=$type;
143 144
         else throw new MailException("Unsupported body type: $type");
144 145
         return $this;
145 146
     }
147
+
148
+    /**
149
+     * @param string $tag
150
+     */
146 151
     function set($tag,$value){
147 152
         /**
148 153
          * Sets the mail attribute
@@ -256,6 +261,10 @@  discard block
 block discarded – undo
256 261
         }
257 262
         return $this->boundary;
258 263
     }
264
+
265
+    /**
266
+     * @return string
267
+     */
259 268
     function get($tag,$plain=true){
260 269
         $value=null;
261 270
         if(isset($this->attrs[$tag]))$value=$this->attrs[$tag];
Please login to merge, or discard this patch.
lib/Controller/Validator/Basic.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -1043,6 +1043,7 @@  discard block
 block discarded – undo
1043 1043
 
1044 1044
     /**
1045 1045
      * Reduce sequential whitespaces to a single space.
1046
+     * @return string
1046 1047
      */
1047 1048
     protected function strip_excess_whitespace($a)
1048 1049
     {
@@ -1051,6 +1052,7 @@  discard block
 block discarded – undo
1051 1052
 
1052 1053
     /**
1053 1054
      * Helper for validating card to and from dates.
1055
+     * @param string $type
1054 1056
      */
1055 1057
     protected function card_date_parser($a, $type)
1056 1058
     {
Please login to merge, or discard this patch.