AL\Common\DAO\NewsDAO::getLatestNews()

Complexity

Conditions	5
Paths	16

Size

Total Lines	75
Code Lines	58

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getLatestNews($limit = 20, $user_id = null, $last_timestamp = null, $words = null) {
        $query = $this->getLatestNewsQuery($user_id, $last_timestamp, $words);
        $bind_string = "";
        $bind_params = array();

        if ($user_id != null) {

It seems like you are loosely comparing $user_id of type integer|null against null; this is ambiguous if the integer can be zero. Consider using a strict comparison !== instead.

            $bind_string .= "i";
            $bind_params[] = $user_id;
        }
        if ($last_timestamp != null) {
            $bind_string .= "i";
            $bind_params[] = $last_timestamp;
        }
        if ($words != null) {
            $bind_string .= "s";
            $bind_params[] = $words;
        }

        $bind_string .= "i";
        $bind_params[] = $limit;

        $stmt = \AL\Db\execute_query(
            "NewsDAO: getLatestNews",
            $this->mysqli,
            $query,
            $bind_string, ...$bind_params
        );

        \AL\Db\bind_result(
            "NewsDAO: getLatestNews",
            $stmt,
            $id,
            $headline,

The variable $headline seems to be never defined.

            $text,

The variable $text seems to be never defined.

            $date,

The variable $date seems to be never defined.

            $userid,

The variable $userid does not exist. Did you maybe mean $user_id?

            $image,

The variable $image seems to be never defined.

            $image_id,

The variable $image_id seems to be never defined.

            $user_id,
            $user_userid,

The variable $user_userid does not exist. Did you maybe mean $user_id?

            $user_email,

The variable $user_email does not exist. Did you maybe mean $user_id?

            $user_join_date,

The variable $user_join_date seems to be never defined.

            $user_karma,

The variable $user_karma seems to be never defined.

            $user_show_email,

The variable $user_show_email seems to be never defined.

            $user_avatar_ext,

The variable $user_avatar_ext seems to be never defined.

            $user_news_count

The variable $user_news_count seems to be never defined.

        );

        $news = [];
        while ($stmt->fetch()) {
            $user = new \AL\Common\Model\User\User(
                $user_id,
                $user_userid,
                $user_email,
                $user_join_date,
                $user_karma,
                $user_show_email,
                $user_avatar_ext,
                $user_news_count
            );

            $news[] = new \AL\Common\Model\News\News(
                $id,
                $headline,
                $text,
                $date,
                $image,
                $image_id,
                $user
            );
        }

        $stmt->close();

        return $news;
    }