AL\Common\DAO\NewsDAO

Complexity

Total Complexity

14

Size/Duplication

Total Lines	253
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getLatestNewsQuery()	0	52	5
A	getNewsCount()	0	19	1
A	__construct()	0	2	1
B	getLatestNews()	0	75	5
B	getNews()	0	77	2

<?php
namespace AL\Common\DAO;

require_once __DIR__."/../../lib/Db.php" ;
require_once __DIR__."/../Model/News/News.php" ;
require_once __DIR__."/../Model/User/User.php" ;

/**
 * DAO for News
 */
class NewsDAO {
    private $mysqli;

    public function __construct($mysqli) {
        $this->mysqli = $mysqli;
    }

    private function getLatestNewsQuery($user_id = null, $last_timestamp = null, $words = null) {
        // DISTINCT is currently needed because there may
        // be multiple matches for a word in news_search_wordlist, one for
        // the word is in the title and one for the word in the content.
        // That result in the same news being returned twice. It would be
        // preferable to fix the DB structure, but we have other priorities
        // for now...
        $query = "SELECT
                DISTINCT(news.news_id),
                news.news_headline,
                news.news_text,
                news.news_date,
                news.user_id,
                CONCAT(news_image.news_image_id, '.', news_image.news_image_ext) as news_image,
                news_image.news_image_id,
                users.user_id,
                users.userid,
                users.email,
                users.join_date,
                users.karma,
                users.show_email,
                users.avatar_ext,
                (SELECT COUNT(*)
                    FROM news
                    WHERE news.user_id = users.user_id) AS user_news_count
            FROM news
            LEFT JOIN news_image ON news.news_image_id = news_image.news_image_id
            LEFT JOIN users ON news.user_id = users.user_id";

        if ($words != null) {
            $query .= " LEFT JOIN news_search_wordmatch
                    ON news_search_wordmatch.news_id = news.news_id
                LEFT JOIN news_search_wordlist
                    ON news_search_wordlist.news_word_id = news_search_wordmatch.news_word_id";
        }

        $constraints = [];
        if ($user_id != null) {
            $constraints[] = "news.user_id = ?";
        }
        if ($last_timestamp != null) {
            $constraints[] = "news.news_date < ?";
        }
        if ($words != null) {
            $constraints[] = "news_search_wordlist.news_word_text = ?";
        }

        $query .= \AL\Db\assemble_constraints($constraints);

        $query .= " ORDER BY news_date DESC LIMIT ?";

        return $query;
    }

    /**
     * Return the latest news, sorted by descending date
     *
     * @param integer $limit How many news to return
     * @param integer $user_id To retrieve the news of a specific user only
     * @param integer $user_id To retrieve only the news before a given timestamp
     * @return \AL\Common\Model\News\News[] An array of news
     */
    public function getLatestNews($limit = 20, $user_id = null, $last_timestamp = null, $words = null) {
        $query = $this->getLatestNewsQuery($user_id, $last_timestamp, $words);
        $bind_string = "";
        $bind_params = array();

        if ($user_id != null) {

It seems like you are loosely comparing $user_id of type integer|null against null; this is ambiguous if the integer can be zero. Consider using a strict comparison !== instead.

            $bind_string .= "i";
            $bind_params[] = $user_id;
        }
        if ($last_timestamp != null) {
            $bind_string .= "i";
            $bind_params[] = $last_timestamp;
        }
        if ($words != null) {
            $bind_string .= "s";
            $bind_params[] = $words;
        }

        $bind_string .= "i";
        $bind_params[] = $limit;

        $stmt = \AL\Db\execute_query(
            "NewsDAO: getLatestNews",
            $this->mysqli,
            $query,
            $bind_string, ...$bind_params
        );

        \AL\Db\bind_result(
            "NewsDAO: getLatestNews",
            $stmt,
            $id,
            $headline,

The variable $headline seems to be never defined.

            $text,

The variable $text seems to be never defined.

            $date,

The variable $date seems to be never defined.

            $userid,

The variable $userid does not exist. Did you maybe mean $user_id?

            $image,

The variable $image seems to be never defined.

            $image_id,

The variable $image_id seems to be never defined.

            $user_id,
            $user_userid,

The variable $user_userid does not exist. Did you maybe mean $user_id?

            $user_email,

The variable $user_email does not exist. Did you maybe mean $user_id?

            $user_join_date,

The variable $user_join_date seems to be never defined.

            $user_karma,

The variable $user_karma seems to be never defined.

            $user_show_email,

The variable $user_show_email seems to be never defined.

            $user_avatar_ext,

The variable $user_avatar_ext seems to be never defined.

            $user_news_count

The variable $user_news_count seems to be never defined.

        );

        $news = [];
        while ($stmt->fetch()) {
            $user = new \AL\Common\Model\User\User(
                $user_id,
                $user_userid,
                $user_email,
                $user_join_date,
                $user_karma,
                $user_show_email,
                $user_avatar_ext,
                $user_news_count
            );

            $news[] = new \AL\Common\Model\News\News(
                $id,
                $headline,
                $text,
                $date,
                $image,
                $image_id,
                $user
            );
        }

        $stmt->close();

        return $news;
    }

    /**
    * Return a specific news article

    * @return \AL\Common\Model\News\News A single news
    */
    public function getNews($news_id) {
        $stmt = \AL\Db\execute_query(
            "NewsDAO: getNews",
            $this->mysqli,
            "SELECT
                news.news_id,
                news.news_headline,
                news.news_text,
                news.news_date,
                news.user_id,
                CONCAT(news_image.news_image_id, '.', news_image.news_image_ext) as news_image,
                news_image.news_image_id,
                users.user_id,
                users.userid,
                users.email,
                users.join_date,
                users.karma,
                users.show_email,
                users.avatar_ext,
                (SELECT COUNT(*)
                    FROM news
                    WHERE news.user_id = users.user_id) AS user_news_count
            FROM news
            LEFT JOIN news_image ON news.news_image_id = news_image.news_image_id
            LEFT JOIN users ON news.user_id = users.user_id
            WHERE news.news_id = ?",
            "i", $news_id
        );

        \AL\Db\bind_result(
            "NewsDAO: getNews",
            $stmt,
            $id,
            $headline,

The variable $headline seems to be never defined.

            $text,

The variable $text seems to be never defined.

            $date,

The variable $date seems to be never defined.

            $userid,

The variable $userid does not exist. Did you maybe mean $user?

            $image,

The variable $image seems to be never defined.

            $image_id,

The variable $image_id seems to be never defined.

            $user_id,

The variable $user_id does not exist. Did you maybe mean $user?

            $user_userid,

The variable $user_userid seems to be never defined.

            $user_email,

The variable $user_email seems to be never defined.

            $user_join_date,

The variable $user_join_date seems to be never defined.

            $user_karma,

The variable $user_karma seems to be never defined.

            $user_show_email,

The variable $user_show_email seems to be never defined.

            $user_avatar_ext,

The variable $user_avatar_ext seems to be never defined.

            $user_news_count

The variable $user_news_count seems to be never defined.

        );

        $news = null;

        if ($stmt->fetch()) {
            $user = new \AL\Common\Model\User\User(
                $user_id,
                $user_userid,
                $user_email,
                $user_join_date,
                $user_karma,
                $user_show_email,
                $user_avatar_ext,
                $user_news_count
            );

            $news = new \AL\Common\Model\News\News(
                $id,
                $headline,
                $text,
                $date,
                $image,
                $image_id,
                $user
            );
        }

        $stmt->close();

        return $news;
    }

    /**
    * Get the total count of news on the website
    * @return number Total number of news
    */
    public function getNewsCount() {
        $stmt = \AL\Db\execute_query(
            "NewsDAO: getNewsCount",
            $this->mysqli,
            "SELECT COUNT(*) FROM news",
            null,
            null
        );

        \AL\Db\bind_result(
            "NewsDAO: getNewsCount",
            $stmt,
            $count
        );

        $stmt->fetch();
        $stmt->close();

        return $count;
    }
}