Completed
Pull Request — master (#79)
by Jacob
02:58
created
src/Metadata/EmbeddedPropMetadata.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
     /**
65 65
      * Sets the embed type: one or many.
66 66
      *
67
-     * @param   string  $relType
67
+     * @param string $embedType
68 68
      * @return  self
69 69
      */
70 70
     public function setEmbedType($embedType)
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     /**
79 79
      * Validates the embed type.
80 80
      *
81
-     * @param   string  $type
81
+     * @param string $embedType
82 82
      * @return  bool
83 83
      * @throws  MetadataException
84 84
      */
Please login to merge, or discard this patch.
src/Metadata/EntityMetadata.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      * Gets the parent entity type.
122 122
      * For entities that are extended.
123 123
      *
124
-     * @return  string|null
124
+     * @return  boolean
125 125
      */
126 126
     public function getParentEntityType()
127 127
     {
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
     /**
335 335
      * Merges attributes with this instance's attributes.
336 336
      *
337
-     * @param   array   $toAdd
337
+     * @param   AttributeMetadata[]   $toAdd
338 338
      * @return  self
339 339
      */
340 340
     private function mergeAttributes(array $toAdd)
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
     /**
349 349
      * Merges embeds with this instance's embeds.
350 350
      *
351
-     * @param   array   $toAdd
351
+     * @param   EmbeddedPropMetadata[]   $toAdd
352 352
      * @return  self
353 353
      */
354 354
     private function mergeEmbeds(array $toAdd)
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
     /**
363 363
      * Merges mixins with this instance's mixins.
364 364
      *
365
-     * @param   array   $toAdd
365
+     * @param   MixinMetadata[]   $toAdd
366 366
      * @return  self
367 367
      */
368 368
     private function mergeMixins(array $toAdd)
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
     /**
379 379
      * Merges relationships with this instance's relationships.
380 380
      *
381
-     * @param   array   $toAdd
381
+     * @param   RelationshipMetadata[]   $toAdd
382 382
      * @return  self
383 383
      */
384 384
     private function mergeRelationships(array $toAdd)
Please login to merge, or discard this patch.
src/Models/AbstractModel.php 3 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -357,7 +357,6 @@  discard block
 block discarded – undo
357 357
      *
358 358
      * @api
359 359
      * @param   string  $key
360
-     * @param   Embed   $model
361 360
      * @return  self
362 361
      */
363 362
     public function pushEmbed($key, Embed $embed)
@@ -380,7 +379,7 @@  discard block
 block discarded – undo
380 379
      *
381 380
      * @api
382 381
      * @param   string  $key    The has-many embed key.
383
-     * @param   Model   $embed  The embed to remove from the collection.
382
+     * @param   Embed   $embed  The embed to remove from the collection.
384 383
      * @return  self
385 384
      */
386 385
     public function removeEmbed($key, Embed $embed)
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -481,12 +481,12 @@
 block discarded – undo
481 481
         return $this;
482 482
     }
483 483
 
484
-     /**
485
-     * Removes properties marked as non-saved.
486
-     *
487
-     * @param   array   $properties
488
-     * @return  array
489
-     */
484
+        /**
485
+         * Removes properties marked as non-saved.
486
+         *
487
+         * @param   array   $properties
488
+         * @return  array
489
+         */
490 490
     protected function filterNotSavedProperties(array $properties)
491 491
     {
492 492
         foreach ($this->getMetadata()->getAttributes() as $fieldKey => $propMeta) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace As3\Modlr\Models;
4 4
 
5 5
 use As3\Modlr\Models\Relationships;
6
-use As3\Modlr\Persister\Record;
7 6
 use As3\Modlr\Store\Store;
8 7
 use As3\Modlr\Metadata\EntityMetadata;
9 8
 
Please login to merge, or discard this patch.
src/Models/Collections/Collection.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace As3\Modlr\Models\Collections;
4 4
 
5
-use As3\Modlr\Models\AbstractModel;
6
-
7 5
 /**
8 6
  * Model collection that contains record representations from a persistence (database) layer.
9 7
  *
Please login to merge, or discard this patch.
src/Models/Model.php 2 patches
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -167,6 +167,7 @@  discard block
 block discarded – undo
167 167
      *
168 168
      * Overloaded to support relationships.
169 169
      *
170
+     * @param string $key
170 171
      */
171 172
     public function get($key)
172 173
     {
@@ -412,6 +413,7 @@  discard block
 block discarded – undo
412 413
      * Sets a model property: an attribute value, a has-one model, or an entire has-many model collection.
413 414
      * Note: To push/remove a single Model into a has-many collection, or clear a collection, use @see push(), remove() and clear().
414 415
      *
416
+     * @param Model|null $value
415 417
      */
416 418
     public function set($key, $value)
417 419
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace As3\Modlr\Models;
4 4
 
5 5
 use As3\Modlr\Models\Relationships;
6
-use As3\Modlr\Persister\Record;
7 6
 use As3\Modlr\Store\Store;
8 7
 use As3\Modlr\Metadata\EntityMetadata;
9 8
 
Please login to merge, or discard this patch.
src/Store/Store.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
      * @todo    Add sorting and pagination (limit/skip).
108 108
      * @todo    Handle find all with identifiers.
109 109
      * @param   string  $typeKey        The model type.
110
-     * @param   array   $idenitifiers   The model identifiers (optional).
110
+     * @param   array   $identifiers   The model identifiers (optional).
111 111
      * @return  Collections\Collection
112 112
      */
113 113
     public function findAll($typeKey, array $identifiers = [])
@@ -374,7 +374,6 @@  discard block
 block discarded – undo
374 374
     /**
375 375
      * Loads a has-many embed collection.
376 376
      *
377
-     * @param   EmbeddedPropMetadata    $relMeta
378 377
      * @param   array|null              $embedDocs
379 378
      * @return  Collections\EmbedCollection
380 379
      */
@@ -625,7 +624,7 @@  discard block
 block discarded – undo
625 624
     /**
626 625
      * Converts the id value to a normalized string.
627 626
      *
628
-     * @param   mixed   $identenfier    The identifier to convert.
627
+     * @param   mixed   $identifier    The identifier to convert.
629 628
      * @return  string
630 629
      */
631 630
     protected function convertId($identifier)
Please login to merge, or discard this patch.
src/Models/Collections/InverseCollection.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
      */
55 55
     public function clear()
56 56
     {
57
-       throw new \BadMethodCallException('You cannot clear inverse collections.');
57
+        throw new \BadMethodCallException('You cannot clear inverse collections.');
58 58
     }
59 59
 
60 60
     /**
Please login to merge, or discard this patch.
src/Models/Embed.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace As3\Modlr\Models;
4 4
 
5 5
 use As3\Modlr\Models\Relationships;
6
-use As3\Modlr\Persister\Record;
7 6
 use As3\Modlr\Store\Store;
8 7
 use As3\Modlr\Metadata\EntityMetadata;
9 8
 
Please login to merge, or discard this patch.