As3\Modlr\Metadata\EmbeddedPropMetadata

Complexity

Total Complexity

6

Size/Duplication

Total Lines	81
Duplicated Lines	9.88 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	isOne()	0	4	1
A	isMany()	0	4	1
A	setEmbedType()	0	7	1
A	validateType()	8	8	2

<?php

namespace As3\Modlr\Metadata;

use As3\Modlr\Exception\MetadataException;

/**
 * Defines metadata for an embedded field.
 * Should be loaded using the MetadataFactory, not instantiated directly.
 *
 * @author Jacob Bare <jacob.bare@gmail.com>
 */
class EmbeddedPropMetadata extends FieldMetadata
{
    /**
     * The embedded metadata for this embedded property.
     *
     * @var string
     */
    public $embedMeta;

    /**
     * The embed type: one or many
     *
     * @var string
     */
    public $embedType;

    /**
     * Constructor.
     *
     * @param   string          $key
     * @param   string          $embedType
     * @param   EmbedMetadata   $embedMeta
     * @param   bool            $mixin
     */
    public function __construct($key, $embedType, EmbedMetadata $embedMeta, $mixin = false)
    {
        $this->embedMeta = $embedMeta;

It seems like $embedMeta of type object<As3\Modlr\Metadata\EmbedMetadata> is incompatible with the declared type string of property $embedMeta.

        $this->setEmbedType($embedType);
        parent::__construct($key, $mixin);
    }

    /**
     * Determines if this is a one (single) embed.
     *
     * @return  bool
     */
    public function isOne()
    {
        return 'one' === $this->embedType;
    }

    /**
     * Determines if this is a many embed.
     *
     * @return bool
     */
    public function isMany()
    {
        return 'many' === $this->embedType;
    }

    /**
     * Sets the embed type: one or many.
     *
     * @param   string  $relType

There is no parameter named $relType. Was it maybe removed?

     * @return  self
     */
    public function setEmbedType($embedType)
    {
        $embedType = strtolower($embedType);
        $this->validateType($embedType);
        $this->embedType = $embedType;
        return $this;
    }

    /**
     * Validates the embed type.
     *
     * @param   string  $type

There is no parameter named $type. Was it maybe removed?

     * @return  bool
     * @throws  MetadataException
     */
    protected function validateType($embedType)

This method seems to be duplicated in your project.

    {
        $valid = ['one', 'many'];
        if (!in_array($embedType, $valid)) {
            throw MetadataException::invalidRelType($embedType, $valid);
        }
        return true;
    }
}