HasPosition::bootHasPosition() - Code Metrics - Inspection of "Fix typo in russian locale" - area17/twill - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 2.x (#586)

by Bekzat

created 2020-03-13 18:05 UTC

HasPosition::bootHasPosition() A

↳ Parent: HasPosition

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	1.125

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
ccs	1
cts	2
cp	0.5
crap	1.125
rs	10
c	0
b	0
f	0

<?php

namespace A17\Twill\Models\Behaviors;

trait HasPosition
{

    protected static function bootHasPosition()
    {
        static::creating(function ($model) {
            $model->setToLastPosition();
        });
    }

    protected function setToLastPosition()
    {
        $this->position = $this->getCurrentLastPosition() + 1;

    }

    protected function getCurrentLastPosition()
    {
        return ((int) static::max('position'));
    }

    public function scopeOrdered($query)
    {
        return $query->orderBy('position');
    }

    public static function setNewOrder($ids, $startOrder = 1)
    {
        if (!is_array($ids)) {
            throw new \Exception('You must pass an array to setNewOrder');
        }

        foreach ($ids as $id) {
            $model = static::find($id);
            $model->position = $startOrder++;
            $model->save();
        }
    }
}


1		<?php
2
3		namespace A17\Twill\Models\Behaviors;
4
5		trait HasPosition
6		{
7
8	1	protected static function bootHasPosition()
9		{
10		static::creating(function ($model) {
11		$model->setToLastPosition();
12	1	});
13	1	}
14
15		protected function setToLastPosition()
16		{
17		$this->position = $this->getCurrentLastPosition() + 1;
		0 ignored issues – show Bug Best Practice introduced 2018-07-17 03:43 UTC by Report Bug Copy Issue Report The property `position` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
18		}
19
20		protected function getCurrentLastPosition()
21		{
22		return ((int) static::max('position'));
23		}
24
25		public function scopeOrdered($query)
26		{
27		return $query->orderBy('position');
28		}
29
30		public static function setNewOrder($ids, $startOrder = 1)
31		{
32		if (!is_array($ids)) {
33		throw new \Exception('You must pass an array to setNewOrder');
34		}
35
36		foreach ($ids as $id) {
37		$model = static::find($id);
38		$model->position = $startOrder++;
39		$model->save();
40		}
41		}
42		}
43

area17 / twill

Pull Request — 2.x (#586)

HasPosition::bootHasPosition() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like