A17\Twill\Models\Behaviors\HasPosition

Complexity

Total Complexity

7

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

16.66%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setToLastPosition()	0	3	1
A	getCurrentLastPosition()	0	3	1
A	setNewOrder()	0	10	3
A	scopeOrdered()	0	3	1
A	bootHasPosition()	0	4	1

<?php

namespace A17\Twill\Models\Behaviors;

trait HasPosition
{

    protected static function bootHasPosition()
    {
        static::creating(function ($model) {
            $model->setToLastPosition();
        });
    }

    protected function setToLastPosition()
    {
        $this->position = $this->getCurrentLastPosition() + 1;

The property position does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    protected function getCurrentLastPosition()
    {
        return ((int) static::max('position'));
    }

    public function scopeOrdered($query)
    {
        return $query->orderBy('position');
    }

    public static function setNewOrder($ids, $startOrder = 1)
    {
        if (!is_array($ids)) {
            throw new \Exception('You must pass an array to setNewOrder');
        }

        foreach ($ids as $id) {
            $model = static::find($id);
            $model->position = $startOrder++;
            $model->save();
        }
    }
}