antonioribeiro / health

src/Listeners/NotifyHealthIssue.php

Doc Comments +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 class NotifyHealthIssue
 {
     /**
-     * @return static
+     * @return \Illuminate\Support\Collection
      */
     private function getNotifiableUsers()
     {

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
     private function getNotifiableUsers()
     {
         return collect(config('health.notifications.users.emails'))->map(
-            function ($item) {
+            function($item) {
                 $model = instantiate(
                     config('health.notifications.users.model')
                 );

src/Commands.php

Doc Comments +4 added lines, -4 removed lines

@@ -120,7 +120,7 @@ 
      * Format input to textual table.
      *
      * @param Command|null $command
-     * @param $columns
+     * @param string[] $columns
      * @param  \Illuminate\Contracts\Support\Arrayable|array $rows
      */
     private function table($command, $columns, $rows)
@@ -134,7 +134,7 @@ 
      * Write a string as information output.
      *
      * @param Command|null $command
-     * @param $string
+     * @param string $string
      */
     private function info($command, $string)
     {
@@ -147,7 +147,7 @@ 
      * Write a string as information output.
      *
      * @param Command|null $command
-     * @param $string
+     * @param string $string
      */
     private function error($command, $string)
     {
@@ -160,7 +160,7 @@ 
      * Write a string as information output.
      *
      * @param Command|null $command
-     * @param $string
+     * @param string $string
      */
     private function warn($command, $string)
     {

Spacing +13 added lines, -13 removed lines

@@ -41,7 +41,7 @@ 
         $columns = ['Resource', 'State', 'Message'];
 
         $rows = $this->healthService->health()
-            ->map(function ($resource) {
+            ->map(function($resource) {
                 return [
                     $resource['name'],
                     $resource['health']['healthy']
@@ -61,7 +61,7 @@ 
 
         $errors = $checker()
             ->where('is_global', false)
-            ->reduce(function ($carry, $item) {
+            ->reduce(function($carry, $item) {
                 return $carry + ($item['health']['healthy'] ? 0 : 1);
             }, 0);
 
@@ -70,10 +70,10 @@ 
         if ($errors) {
             $this->error(
                 $command,
-                "Application needs attention, $errors " .
-                    str_plural('resouce', $errors) .
-                    ' ' .
-                    ($errors > 1 ? 'are' : 'is') .
+                "Application needs attention, $errors ".
+                    str_plural('resouce', $errors).
+                    ' '.
+                    ($errors > 1 ? 'are' : 'is').
                     ' currently failing.'
             );
 
@@ -89,7 +89,7 @@ 
     {
         $yaml = new Yaml();
 
-        collect(config('health.resources'))->each(function (
+        collect(config('health.resources'))->each(function(
             $resource,
             $key
         ) use ($command, $yaml) {
@@ -107,11 +107,11 @@ 
 
             file_put_contents(
                 $file =
-                    $path . DIRECTORY_SEPARATOR . studly_case($key) . '.yml',
+                    $path.DIRECTORY_SEPARATOR.studly_case($key).'.yml',
                 $dump
             );
 
-            $this->info($command, 'Exported ' . $file);
+            $this->info($command, 'Exported '.$file);
         });
     }
 
@@ -121,24 +121,24 @@ 
 
         $yaml
             ->loadFromDirectory(package_resources_dir(), false)
-            ->each(function ($value, $key) use ($command, $yaml) {
+            ->each(function($value, $key) use ($command, $yaml) {
                 if (!file_exists($path = config('health.resources.path'))) {
                     mkdir($path, 0755, true);
                 }
 
                 if (
                     file_exists(
-                        $file = $path . DIRECTORY_SEPARATOR . $key . '.yaml'
+                        $file = $path.DIRECTORY_SEPARATOR.$key.'.yaml'
                     )
                 ) {
-                    $this->warn($command, 'Skipped: ' . $file);
+                    $this->warn($command, 'Skipped: '.$file);
 
                     return;
                 }
 
                 file_put_contents($file, $yaml->dump($value));
 
-                $this->info($command, 'Saved: ' . $file);
+                $this->info($command, 'Saved: '.$file);
             });
     }
 

src/ServiceProvider.php

Doc Comments +2 added lines, -2 removed lines

@@ -142,7 +142,7 @@ 
     /**
      * Get the resource checker closure for instantiation.
      *
-     * @param $resourceLoader
+     * @param ResourceLoader $resourceLoader
      * @param $cache
      * @return \Closure
      */
@@ -354,7 +354,7 @@ 
     /**
      * Get the services provided by the provider.
      *
-     * @return array
+     * @return string[]
      */
     public function provides()
     {

Spacing +16 added lines, -16 removed lines

@@ -81,10 +81,10 @@ 
     {
         $this->publishes(
             [
-                __DIR__ . '/config/health.php' => config_path(
+                __DIR__.'/config/health.php' => config_path(
                     'health/config.php'
                 ),
-                __DIR__ . '/config/resources/' => config_path(
+                __DIR__.'/config/resources/' => config_path(
                     'health/resources/'
                 ),
             ],
@@ -93,7 +93,7 @@ 
 
         $this->publishes(
             [
-                __DIR__ . '/resources/views/' => resource_path(
+                __DIR__.'/resources/views/' => resource_path(
                     'views/vendor/pragmarx/health/'
                 ),
             ],
@@ -102,7 +102,7 @@ 
 
         $this->publishes(
             [
-                __DIR__ . '/database/migrations/' => database_path(
+                __DIR__.'/database/migrations/' => database_path(
                     'migrations'
                 ),
             ],
@@ -116,7 +116,7 @@ 
     private function configureViews()
     {
         $this->loadViewsFrom(
-            realpath(__DIR__ . '/resources/views'),
+            realpath(__DIR__.'/resources/views'),
             'pragmarx/health'
         );
     }
@@ -130,7 +130,7 @@ 
 
         $cache = call_user_func($this->cacheClosure);
 
-        $this->healthServiceClosure = function () use (
+        $this->healthServiceClosure = function() use (
             $resourceChecker,
             $cache
         ) {
@@ -162,7 +162,7 @@ 
      */
     private function getCacheClosure()
     {
-        $cacheClosure = function () {
+        $cacheClosure = function() {
             return new Cache();
         };
 
@@ -188,7 +188,7 @@ 
      */
     private function getResourceCheckerClosure($resourceLoader, $cache)
     {
-        $resourceCheckerInstance = function () use ($resourceLoader, $cache) {
+        $resourceCheckerInstance = function() use ($resourceLoader, $cache) {
             return new ResourceChecker($resourceLoader, $cache);
         };
 
@@ -238,7 +238,7 @@ 
             $this->mergeConfigFrom(config_path('/health/config.php'), 'health');
         }
 
-        $this->mergeConfigFrom(__DIR__ . '/config/health.php', 'health');
+        $this->mergeConfigFrom(__DIR__.'/config/health.php', 'health');
     }
 
     /**
@@ -267,9 +267,9 @@ 
 
     private function registerResourcesRoutes()
     {
-        collect($this->resourceLoader->getResources())->each(function ($item) {
+        collect($this->resourceLoader->getResources())->each(function($item) {
             if (isset($item['routes'])) {
-                collect($item['routes'])->each(function ($route, $key) {
+                collect($item['routes'])->each(function($route, $key) {
                     $this->registerRoute($route, $key);
                 });
             }
@@ -283,19 +283,19 @@ 
     {
         $commands = $this->commands;
 
-        Artisan::command('health:panel', function () use ($commands) {
+        Artisan::command('health:panel', function() use ($commands) {
             $commands->panel($this);
         })->describe('Show all resources and their current health states.');
 
-        Artisan::command('health:check', function () use ($commands) {
+        Artisan::command('health:check', function() use ($commands) {
             $commands->check($this);
         })->describe('Check resources health and send error notifications.');
 
-        Artisan::command('health:export', function () use ($commands) {
+        Artisan::command('health:export', function() use ($commands) {
             $commands->export($this);
         })->describe('Export "array" resources to .yml files');
 
-        Artisan::command('health:publish', function () use ($commands) {
+        Artisan::command('health:publish', function() use ($commands) {
             $commands->publish($this);
         })->describe('Publish all .yml resouces files to config directory.');
     }
@@ -313,7 +313,7 @@ 
      */
     private function registerRoutes()
     {
-        collect($routes = $this->getRoutes())->each(function ($route) {
+        collect($routes = $this->getRoutes())->each(function($route) {
             $this->registerRoute($route);
         });
 

tests/PhpUnit/Service/ServiceTest.php

Doc Comments +3 added lines

@@ -161,6 +161,9 @@
         $this->assertTrue($resource->first()['name'] == 'Database');
     }
 
+    /**
+     * @param Collection $resources
+     */
     public function assertCheckedResources($resources)
     {
         $healthCount = $resources->reduce(function ($carry, $item) {

Spacing +6 added lines, -6 removed lines

@@ -164,13 +164,13 @@ 
 
     public function assertCheckedResources($resources)
     {
-        $healthCount = $resources->reduce(function ($carry, $item) {
+        $healthCount = $resources->reduce(function($carry, $item) {
             return $carry + (isset($item['health']['healthy']) ? 1 : 0);
         }, 0);
 
         $this->assertEquals(count(static::ALL_RESOURCES), $healthCount);
 
-        $failing = $resources->filter(function ($item) {
+        $failing = $resources->filter(function($item) {
             return $item['health']['healthy'];
         });
 
@@ -212,7 +212,7 @@ 
                 ->toArray(),
             $this->getResources()
                 ->keys()
-                ->map(function ($value) {
+                ->map(function($value) {
                     return strtolower($value);
                 })
                 ->sort()
@@ -247,17 +247,17 @@ 
         $string = $controller->string()->getContent();
 
         $this->assertTrue(
-            strpos($string, config('health.string.ok') . '-') !== false
+            strpos($string, config('health.string.ok').'-') !== false
         );
 
         $this->assertTrue(
-            strpos($string, config('health.string.fail') . '-') !== false
+            strpos($string, config('health.string.fail').'-') !== false
         );
 
         $this->assertTrue(
             strpos(
                 $controller->panel()->getContent(),
-                '<title>' . config('health.title') . '</title>'
+                '<title>'.config('health.title').'</title>'
             ) !== false
         );
     }

src/Checkers/Filesystem.php

Doc Comments +3 added lines, -3 removed lines

@@ -25,9 +25,9 @@
     }
 
     /**
-     * @param $name
-     * @param $content
-     * @param null $folder
+     * @param string $name
+     * @param string $content
+     * @param string $folder
      * @return string
      */
     private function temporaryFile($name, $content, $folder = null)

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
 
         file_put_contents($file, $content);
 
-        register_shutdown_function(function () use ($file) {
+        register_shutdown_function(function() use ($file) {
             if (file_exists($file)) {
                 unlink($file);
             }

src/Checkers/NotInDebugMode.php

Doc Comments +2 added lines, -2 removed lines

@@ -139,7 +139,7 @@ 
      * Convert uptime to seconds.
      *
      * @param $date
-     * @return int
+     * @return double
      */
     protected function uptimeInSeconds($date)
     {
@@ -152,7 +152,7 @@ 
      * Make uptime message.
      *
      * @param $current
-     * @param $saved
+     * @param \Illuminate\Support\Collection $saved
      * @return string
      */
     protected function makeMessage($current, $saved = null)

Spacing +2 added lines, -2 removed lines

@@ -68,10 +68,10 @@
     protected function normalizeMatches($matches)
     {
         return collect($matches)
-            ->filter(function ($item, $key) {
+            ->filter(function($item, $key) {
                 return !is_numeric($key);
             })
-            ->map(function ($item, $key) {
+            ->map(function($item, $key) {
                 $return = $item[0];
 
                 if (starts_with($key, 'load')) {

src/Checkers/ServerUptime.php

Doc Comments +2 added lines, -2 removed lines

@@ -139,7 +139,7 @@ 
      * Convert uptime to seconds.
      *
      * @param $date
-     * @return int
+     * @return double
      */
     protected function uptimeInSeconds($date)
     {
@@ -152,7 +152,7 @@ 
      * Make uptime message.
      *
      * @param $current
-     * @param $saved
+     * @param \Illuminate\Support\Collection $saved
      * @return string
      */
     protected function makeMessage($current, $saved = null)

Spacing +2 added lines, -2 removed lines

@@ -68,10 +68,10 @@
     protected function normalizeMatches($matches)
     {
         return collect($matches)
-            ->filter(function ($item, $key) {
+            ->filter(function($item, $key) {
                 return !is_numeric($key);
             })
-            ->map(function ($item, $key) {
+            ->map(function($item, $key) {
                 $return = $item[0];
 
                 if (starts_with($key, 'load')) {

src/Support/helpers.php

Doc Comments +3 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
      * Check if string is absolute path.
      *
      * @param $path
-     * @return string
+     * @return boolean
      */
     function is_absolute_path($path)
     {
@@ -84,6 +84,7 @@ 
     /**
      * Convert bytes to human readable.
      *
+     * @param double $bytes
      * @return string
      */
     function bytes_to_human($bytes)
@@ -102,7 +103,7 @@ 
     /**
      * Convert bytes to human readable.
      *
-     * @return string
+     * @return double
      */
     function human_to_bytes($str)
     {

Spacing +7 added lines, -7 removed lines

@@ -45,10 +45,10 @@ 
     function package_resources_dir()
     {
         return (
-            package_dir() .
-            DIRECTORY_SEPARATOR .
-            'config' .
-            DIRECTORY_SEPARATOR .
+            package_dir().
+            DIRECTORY_SEPARATOR.
+            'config'.
+            DIRECTORY_SEPARATOR.
             'resources'
         );
     }
@@ -66,8 +66,8 @@ 
         // Optional wrapper(s).
         $regExp =
             // Optional root prefix.
-            '%^(?<wrappers>(?:[[:print:]]{2,}://)*)' .
-            '(?<root>(?:[[:alpha:]]:/|/)?)' .
+            '%^(?<wrappers>(?:[[:print:]]{2,}://)*)'.
+            '(?<root>(?:[[:alpha:]]:/|/)?)'.
             // Actual path.
             '(?<path>(?:[[:print:]]*))$%';
 
@@ -97,7 +97,7 @@ 
 
         $f_base = floor($base);
 
-        return round(pow(1024, $base - floor($base)), 1) . $suffix[$f_base];
+        return round(pow(1024, $base - floor($base)), 1).$suffix[$f_base];
     }
 }
 

src/Checkers/Cache.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 
     private function getChecker()
     {
-        return function () {
+        return function() {
             return 'DUMMY DATA';
         };
     }