antonioribeiro / firewall

src/migrations/2014_02_01_311070_create_firewall_table.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     public function up()
     {
-        Schema::create('firewall', function (Blueprint $table) {
+        Schema::create('firewall', function(Blueprint $table) {
             $table->increments('id');
 
             $table->string('ip_address', 39)->unique()->index();

src/Listeners/NotifyAdmins.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     private function getNotifiableUsers()
     {
-        return collect(config('firewall.notifications.users.emails'))->map(function ($item) {
+        return collect(config('firewall.notifications.users.emails'))->map(function($item) {
             if (class_exists($class = config('firewall.notifications.users.model'))) {
                 $model = app($class);
 

src/Notifications/Channels/Slack.php

Indentation +4 added lines, -4 removed lines

@@ -55,21 +55,21 @@
             })
             ->attachment(function ($attachment) use ($item) {
                 $attachment->title($title = config('firewall.notifications.message.uri.title'))
-                           ->content($item['server']['REQUEST_URI']);
+                            ->content($item['server']['REQUEST_URI']);
             })
             ->attachment(function ($attachment) use ($item) {
                 $attachment->title(config('firewall.notifications.message.user_agent.title'))
-                           ->content($item['userAgent']);
+                            ->content($item['userAgent']);
             })
             ->attachment(function ($attachment) use ($item) {
                 $attachment->title(config('firewall.notifications.message.blacklisted.title'))
-                           ->content($item['isBlacklisted'] ? 'YES' : 'NO');
+                            ->content($item['isBlacklisted'] ? 'YES' : 'NO');
             });
 
         if ($item['geoIp']) {
             $message->attachment(function ($attachment) use ($item) {
                 $attachment->title(config('firewall.notifications.message.geolocation.title'))
-                           ->fields($this->makeGeolocation($item));
+                            ->fields($this->makeGeolocation($item));
             });
         }
 

Spacing +5 added lines, -5 removed lines

@@ -42,7 +42,7 @@ 
                 config('firewall.notifications.from.icon_emoji')
             )
             ->content($this->getMessage($item))
-            ->attachment(function ($attachment) use ($item) {
+            ->attachment(function($attachment) use ($item) {
                 $attachment->title(config('firewall.notifications.message.request_count.title'))
                             ->content(
                                 sprintf(
@@ -53,21 +53,21 @@ 
                                 )
                             );
             })
-            ->attachment(function ($attachment) use ($item) {
+            ->attachment(function($attachment) use ($item) {
                 $attachment->title($title = config('firewall.notifications.message.uri.title'))
                            ->content($item['server']['REQUEST_URI']);
             })
-            ->attachment(function ($attachment) use ($item) {
+            ->attachment(function($attachment) use ($item) {
                 $attachment->title(config('firewall.notifications.message.user_agent.title'))
                            ->content($item['userAgent']);
             })
-            ->attachment(function ($attachment) use ($item) {
+            ->attachment(function($attachment) use ($item) {
                 $attachment->title(config('firewall.notifications.message.blacklisted.title'))
                            ->content($item['isBlacklisted'] ? 'YES' : 'NO');
             });
 
         if ($item['geoIp']) {
-            $message->attachment(function ($attachment) use ($item) {
+            $message->attachment(function($attachment) use ($item) {
                 $attachment->title(config('firewall.notifications.message.geolocation.title'))
                            ->fields($this->makeGeolocation($item));
             });

src/Support/AttackBlocker.php

Spacing +6 added lines, -6 removed lines

@@ -122,7 +122,7 @@ 
      */
     protected function checkExpiration()
     {
-        $this->enabledItems->each(function ($index, $type) {
+        $this->enabledItems->each(function($index, $type) {
             if (($this->record[$type]['lastRequestAt']->diffInSeconds(Carbon::now())) <= ($this->getMaxSecondsForType($type))) {
                 return $this->record;
             }
@@ -240,7 +240,7 @@ 
      */
     protected function increment()
     {
-        $this->enabledItems->each(function ($index, $type) {
+        $this->enabledItems->each(function($index, $type) {
             $this->save($type, ['requestCount' => $this->record[$type]['requestCount'] + 1]);
         });
     }
@@ -252,7 +252,7 @@ 
      */
     protected function isAttack()
     {
-        return $this->enabledItems->filter(function ($index, $type) {
+        return $this->enabledItems->filter(function($index, $type) {
             if (!$this->isWhitelisted($type) && $this->record[$type]['requestCount'] > $this->getMaxRequestCountForType($type)) {
                 $this->takeAction($this->record[$type]);
 
@@ -309,7 +309,7 @@ 
      */
     private function loadConfig()
     {
-        $this->enabledItems = collect($this->config()->get('attack_blocker.enabled'))->filter(function ($item) {
+        $this->enabledItems = collect($this->config()->get('attack_blocker.enabled'))->filter(function($item) {
             return $item === true;
         });
     }
@@ -339,7 +339,7 @@ 
      */
     protected function loadRecordItems()
     {
-        $this->enabledItems->each(function ($index, $type) {
+        $this->enabledItems->each(function($index, $type) {
             if (is_null($this->record[$type] = $this->cache()->get($key = $this->makeKeyForType($type, $this->ipAddress)))) {
                 $this->record[$type] = $this->getEmptyRecord($key, $type);
             }
@@ -480,7 +480,7 @@ 
         if (!$record['wasNotified'] && $this->config()->get('notifications.enabled')) {
             $this->save($record['type'], ['wasNotified' => true]);
 
-            collect($this->config()->get('notifications.channels'))->filter(function ($value, $channel) use ($record) {
+            collect($this->config()->get('notifications.channels'))->filter(function($value, $channel) use ($record) {
                 try {
                     event(new AttackDetected($record, $channel));
                 } catch (\Exception $exception) {

Doc Comments +1 added lines, -1 removed lines

@@ -399,7 +399,7 @@
     /**
      * Make the cache key to record countries.
      *
-     * @param $ipAddress
+     * @param string $ipAddress
      *
      * @return string|null
      */

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 use Carbon\Carbon;
 use PragmaRX\Firewall\Events\AttackDetected;
 use PragmaRX\Firewall\Firewall;
-use PragmaRX\Firewall\Repositories\Cache\Cache;
-use PragmaRX\Support\Config;
 
 class AttackBlocker
 {

src/Repositories/IpList.php

Spacing +5 added lines, -7 removed lines

@@ -33,13 +33,13 @@ 
     private function getNonDatabaseIps()
     {
         return array_merge_recursive(
-            array_map(function ($ip) {
+            array_map(function($ip) {
                 $ip['whitelisted'] = true;
 
                 return $ip;
             }, $this->formatIpArray($this->config()->get('whitelist'))),
 
-            array_map(function ($ip) {
+            array_map(function($ip) {
                 $ip['whitelisted'] = false;
 
                 return $ip;
@@ -160,7 +160,7 @@ 
      */
     private function formatIpArray($list)
     {
-        return array_map(function ($ip) {
+        return array_map(function($ip) {
             return ['ip_address' => $ip];
         }, $this->makeArrayOfIps($list));
     }
@@ -429,8 +429,7 @@ 
     public function addToProperList($whitelist, $ip)
     {
         $this->config()->get('use_database') ?
-            $this->addToDatabaseList($whitelist, $ip) :
-            $this->addToArrayList($whitelist, $ip);
+            $this->addToDatabaseList($whitelist, $ip) : $this->addToArrayList($whitelist, $ip);
     }
 
     /**
@@ -443,8 +442,7 @@ 
     public function delete($ipAddress)
     {
         $this->config()->get('use_database') ?
-            $this->removeFromDatabaseList($ipAddress) :
-            $this->removeFromArrayList($ipAddress);
+            $this->removeFromDatabaseList($ipAddress) : $this->removeFromArrayList($ipAddress);
     }
 
     /**

Doc Comments +8 added lines, -8 removed lines

@@ -64,7 +64,7 @@ 
     /**
      * Remove the ip address from an array list.
      *
-     * @param $type
+     * @param string $type
      * @param $ipAddress
      *
      * @return bool
@@ -135,7 +135,7 @@ 
     /**
      * Read a file contents.
      *
-     * @param $file
+     * @param string $file
      *
      * @return array
      */
@@ -244,8 +244,8 @@ 
     /**
      * Merge IP lists.
      *
-     * @param $database_ips
-     * @param $config_ips
+     * @param \Illuminate\Support\Collection $database_ips
+     * @param \Illuminate\Support\Collection $config_ips
      *
      * @return \Illuminate\Support\Collection
      */
@@ -369,7 +369,7 @@ 
      * Add ip or range to array list.
      *
      * @param $whitelist
-     * @param $ip
+     * @param string $ip
      *
      * @return array|mixed
      */
@@ -478,7 +478,7 @@ 
     /**
      * Find ip address in all lists.
      *
-     * @param $ip
+     * @param string $ip
      *
      * @return \Illuminate\Database\Eloquent\Model|null|static
      */
@@ -498,7 +498,7 @@ 
      *
      * @param $ip
      *
-     * @return \Illuminate\Database\Eloquent\Model
+     * @return FirewallModel|null
      */
     private function nonDatabaseFind($ip)
     {
@@ -513,7 +513,7 @@ 
      * Add ip or range to database.
      *
      * @param $whitelist
-     * @param $ip
+     * @param string $ip
      *
      * @return \Illuminate\Database\Eloquent\Model
      */

src/Repositories/DataRepository.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     {
         $country = $this->makeCountryFromString($country);
 
-        return $this->ipList()->all()->filter(function ($item) use ($country) {
+        return $this->ipList()->all()->filter(function($item) use ($country) {
             return $item['ip_address'] == $country ||
                 $this->makeCountryFromString($this->getCountryFromIp($item['ip_address'])) == $country;
         });

src/Repositories/Message.php

Spacing +2 added lines, -2 removed lines

@@ -33,8 +33,8 @@
      */
     public function addMessage($message)
     {
-        collect((array) $message)->each(function ($item) {
-            collect($item)->flatten()->each(function ($flattened) {
+        collect((array) $message)->each(function($item) {
+            collect($item)->flatten()->each(function($flattened) {
                 $this->messageList->push($flattened);
             });
         });

src/Vendor/Laravel/ServiceProvider.php

Spacing +18 added lines, -18 removed lines

@@ -142,7 +142,7 @@ 
      */
     private function registerAttackBlocker()
     {
-        $this->app->singleton('firewall.attackBlocker', function () {
+        $this->app->singleton('firewall.attackBlocker', function() {
             return new AttackBlocker();
         });
     }
@@ -152,7 +152,7 @@ 
      */
     private function registerCountriesRepository()
     {
-        $this->app->singleton('firewall.countries', function () {
+        $this->app->singleton('firewall.countries', function() {
             return new Countries();
         });
     }
@@ -164,7 +164,7 @@ 
      */
     private function registerBlacklistCommand()
     {
-        $this->app->singleton('firewall.blacklist.command', function () {
+        $this->app->singleton('firewall.blacklist.command', function() {
             return new BlacklistCommand();
         });
 
@@ -178,7 +178,7 @@ 
      */
     private function registerCache()
     {
-        $this->app->singleton('firewall.cache', function () {
+        $this->app->singleton('firewall.cache', function() {
             return new Cache(app('cache'));
         });
     }
@@ -190,7 +190,7 @@ 
      */
     private function registerClearCommand()
     {
-        $this->app->singleton('firewall.clear.command', function () {
+        $this->app->singleton('firewall.clear.command', function() {
             return new ClearCommand();
         });
 
@@ -204,7 +204,7 @@ 
      */
     private function registerDataRepository()
     {
-        $this->app->singleton('firewall.datarepository', function () {
+        $this->app->singleton('firewall.datarepository', function() {
             return new DataRepository();
         });
     }
@@ -224,7 +224,7 @@ 
      */
     private function registerFileSystem()
     {
-        $this->app->singleton('firewall.filesystem', function () {
+        $this->app->singleton('firewall.filesystem', function() {
             return new Filesystem();
         });
     }
@@ -237,7 +237,7 @@ 
      */
     private function registerFirewall()
     {
-        $this->app->singleton('firewall', function ($app) {
+        $this->app->singleton('firewall', function($app) {
             $app['firewall.loaded'] = true;
 
             $this->firewall = new Firewall(
@@ -256,7 +256,7 @@ 
 
     private function registerIpAddress()
     {
-        $this->app->singleton('firewall.ipaddress', function () {
+        $this->app->singleton('firewall.ipaddress', function() {
             return new IpAddress();
         });
     }
@@ -267,7 +267,7 @@ 
      */
     private function registerIpList()
     {
-        $this->app->singleton('firewall.iplist', function () {
+        $this->app->singleton('firewall.iplist', function() {
             return new IpList($this->getFirewallModel());
         });
     }
@@ -278,7 +278,7 @@ 
      */
     private function registerMessageRepository()
     {
-        $this->app->singleton('firewall.messages', function () {
+        $this->app->singleton('firewall.messages', function() {
             return new Message();
         });
     }
@@ -290,11 +290,11 @@ 
      */
     private function registerMiddleware()
     {
-        $this->app->singleton('firewall.middleware.blacklist', function () {
+        $this->app->singleton('firewall.middleware.blacklist', function() {
             return new FirewallBlacklist(new Blacklist());
         });
 
-        $this->app->singleton('firewall.middleware.whitelist', function () {
+        $this->app->singleton('firewall.middleware.whitelist', function() {
             return new FirewallWhitelist(new Whitelist());
         });
     }
@@ -306,7 +306,7 @@ 
 
     private function registerGeoIp()
     {
-        $this->app->singleton('firewall.geoip', function () {
+        $this->app->singleton('firewall.geoip', function() {
             return new GeoIp($this->getConfig('geoip_database_path'));
         });
     }
@@ -318,7 +318,7 @@ 
      */
     private function registerRemoveCommand()
     {
-        $this->app->singleton('firewall.remove.command', function () {
+        $this->app->singleton('firewall.remove.command', function() {
             return new RemoveCommand();
         });
 
@@ -332,7 +332,7 @@ 
      */
     private function registerReportCommand()
     {
-        $this->app->singleton('firewall.list.command', function () {
+        $this->app->singleton('firewall.list.command', function() {
             return new ReportCommand();
         });
 
@@ -344,7 +344,7 @@ 
      */
     private function registerUpdateGeoIpCommand()
     {
-        $this->app->singleton('firewall.updategeoip.command', function () {
+        $this->app->singleton('firewall.updategeoip.command', function() {
             return new UpdateGeoIpCommand();
         });
 
@@ -358,7 +358,7 @@ 
      */
     private function registerWhitelistCommand()
     {
-        $this->app->singleton('firewall.whitelist.command', function () {
+        $this->app->singleton('firewall.whitelist.command', function() {
             return new WhitelistCommand();
         });
 

Doc Comments +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
     /**
      * Get the services provided by the provider.
      *
-     * @return array
+     * @return string[]
      */
     public function provides()
     {

src/Firewall.php

Doc Comments +6 added lines, -6 removed lines

@@ -133,7 +133,7 @@ 
     /**
      * Clear firewall table.
      *
-     * @return mixed
+     * @return integer
      */
     public function clear()
     {
@@ -240,7 +240,7 @@ 
     /**
      * Get the list of all IP addresses stored.
      *
-     * @return mixed
+     * @return \Illuminate\Support\Collection
      */
     public function report()
     {
@@ -276,7 +276,7 @@ 
      *
      * @param $ip_address
      *
-     * @return bool|string
+     * @return null|string
      */
     public function whichList($ip_address)
     {
@@ -325,7 +325,7 @@ 
     /**
      * Get a response to the attack.
      *
-     * @return \Illuminate\Http\Response|\Illuminate\Http\RedirectResponse|null
+     * @return null|\Illuminate\Http\Response
      */
     public function responseToAttack()
     {
@@ -337,7 +337,7 @@ 
      *
      * @param $ip_address
      *
-     * @return bool|string
+     * @return string|null
      */
     public function getCountryFromIp($ip_address)
     {
@@ -359,7 +359,7 @@ 
     /**
      * Get the GeoIP instance.
      *
-     * @return object
+     * @return \PragmaRX\Support\GeoIp\GeoIp
      */
     public function getGeoIp()
     {