Inspection of "Minor patches" - ankitjain28may/openchat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3b96a7...361ab6 )

by Ankit

created 2017-01-04 19:26 UTC

Status

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -10,37 +10,37 @@
 block discarded – undo
 $connect = mysqli_connect(
     getenv('DB_HOST'),
     getenv('DB_USER'),
-	getenv('DB_PASSWORD'),
-	getenv('DB_NAME')
+    getenv('DB_PASSWORD'),
+    getenv('DB_NAME')
 );
 
 $userId = Session::get('start');
 $data = '';
 if(isset($_POST['submit']))
 {
-	$data = Profile::getProfile($userId);
-	if($data != NULL):
-		$status = get($_POST['status'], $data['status']);
-		$edu = get($_POST['education'], $data['education']);
-		$gender = get($_POST['gender'], $data['gender']);
-		$query = "UPDATE profile set status = '$status', education = '$edu', gender = '$gender' where login_id = '$userId'";
-		if($result = $connect->query($query))
-		{
-			header('Location:'.getenv('APP_URL').'/account.php');
-		}
-		else
-		{
-			header("Location:".getenv('APP_URL')."/error.php");
-		}
-	endif;
+    $data = Profile::getProfile($userId);
+    if($data != NULL):
+        $status = get($_POST['status'], $data['status']);
+        $edu = get($_POST['education'], $data['education']);
+        $gender = get($_POST['gender'], $data['gender']);
+        $query = "UPDATE profile set status = '$status', education = '$edu', gender = '$gender' where login_id = '$userId'";
+        if($result = $connect->query($query))
+        {
+            header('Location:'.getenv('APP_URL').'/account.php');
+        }
+        else
+        {
+            header("Location:".getenv('APP_URL')."/error.php");
+        }
+    endif;
 }
 else
 {
-	header("Location:".getenv('APP_URL')."/error.php");
+    header("Location:".getenv('APP_URL')."/error.php");
 }
 
 function get($value, $default)
 {
-	$value = trim($value);
-	return (isset($value) ? $value : $default);
+    $value = trim($value);
+    return (isset($value) ? $value : $default);
 }

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php
 
-require_once (__DIR__ . '/vendor/autoload.php');
+require_once (__DIR__.'/vendor/autoload.php');
 use ChatApp\Session;
 use ChatApp\Profile;
 use Dotenv\Dotenv;
@@ -16,15 +16,15 @@  discard block
 block discarded – undo
 
 $userId = Session::get('start');
 $data = '';
-if(isset($_POST['submit']))
+if (isset($_POST['submit']))
 {
 	$data = Profile::getProfile($userId);
-	if($data != NULL):
+	if ($data != NULL):
 		$status = get($_POST['status'], $data['status']);
 		$edu = get($_POST['education'], $data['education']);
 		$gender = get($_POST['gender'], $data['gender']);
 		$query = "UPDATE profile set status = '$status', education = '$edu', gender = '$gender' where login_id = '$userId'";
-		if($result = $connect->query($query))
+		if ($result = $connect->query($query))
 		{
 			header('Location:'.getenv('APP_URL').'/account.php');
 		}

Please login to merge, or discard this patch.

account.php 1 patch

Indentation +36 added lines, -36 removed lines patch added patch discarded remove patch

@@ -14,26 +14,26 @@  discard block
 block discarded – undo
 $userId = Session::get('start');
 if($userId != null && $user == "account.php")
 {
-	$obUser = new User();
-	$row = $obUser->userDetails($userId, True);
+    $obUser = new User();
+    $row = $obUser->userDetails($userId, True);
 
-	if($row != NULL)
-	{
-		$location = getenv('APP_URL') . "/account.php/". $row['username'];
-		header("Location:".$location);
-	}
+    if($row != NULL)
+    {
+        $location = getenv('APP_URL') . "/account.php/". $row['username'];
+        header("Location:".$location);
+    }
 }
 elseif ($user != "account.php")
 {
-	$obUser = new User();
-	$row = $obUser->userDetails($user, False);
-	if($row != NULL):
-		$userId = $row['login_id'];
-		$details = Profile::getProfile($userId);
-		if($details != NULL)
-			$row = array_merge($row, $details);
-		else
-			header("Location:".getenv('APP_URL')."/error.php");
+    $obUser = new User();
+    $row = $obUser->userDetails($user, False);
+    if($row != NULL):
+        $userId = $row['login_id'];
+        $details = Profile::getProfile($userId);
+        if($details != NULL)
+            $row = array_merge($row, $details);
+        else
+            header("Location:".getenv('APP_URL')."/error.php");
 ?>
 
 		<!Doctype html>
@@ -68,18 +68,18 @@  discard block
 block discarded – undo
 						<div class="brief">
 							<h1 id="name">Name: <?php echo $row['name']; ?></h1><br>
 							<?php foreach ($row as $key => $value) {
-								if($key =='username' && $value != null)
-									echo '<p>Username: '.$row["username"] .'</p><br>';
-								if($key == 'email' && $value != null)
-									echo '<p>Email Id: '.$row["email"] .'</p><br>';
-								if($key == 'status' && $value != null)
-									echo '<p>Status: '.$row["status"] .'</p><br>';
-								if($key == 'education' && $value != null)
-									echo '<p>Education: '.$row["education"] .'</p><br>';
-								if($key == 'gender' && $value != null)
-									echo '<p>Gender: 	'.$row["gender"] .'</p><br>';
-							}
-							?>
+                                if($key =='username' && $value != null)
+                                    echo '<p>Username: '.$row["username"] .'</p><br>';
+                                if($key == 'email' && $value != null)
+                                    echo '<p>Email Id: '.$row["email"] .'</p><br>';
+                                if($key == 'status' && $value != null)
+                                    echo '<p>Status: '.$row["status"] .'</p><br>';
+                                if($key == 'education' && $value != null)
+                                    echo '<p>Education: '.$row["education"] .'</p><br>';
+                                if($key == 'gender' && $value != null)
+                                    echo '<p>Gender: 	'.$row["gender"] .'</p><br>';
+                            }
+                            ?>
 						</div>
 						<?php if(Session::get('start') == $row['login_id']): ?>
 							<div class="edit">
@@ -89,8 +89,8 @@  discard block
 block discarded – undo
 					</div>
 
 					<?php
-						if(Session::get('start') == $row['login_id']):
-					?>
+                        if(Session::get('start') == $row['login_id']):
+                    ?>
 
 					<div class="boxx" id="profile">
 						<form method="post" action="../profile_generate.php">
@@ -105,8 +105,8 @@  discard block
 block discarded – undo
 						</form>
 					</div>
 					<?php
-						endif;
-					?>
+                        endif;
+                    ?>
 				</div>
 
 				<div class="footer">
@@ -119,13 +119,13 @@  discard block
 block discarded – undo
 			</body>
 		</html>
 <?php
-	else:
-		header("Location:".getenv('APP_URL')."/error.php");
-	endif;
+    else:
+        header("Location:".getenv('APP_URL')."/error.php");
+    endif;
 }
 else
 {
-	header("Location: ".getenv('APP_URL'));
+    header("Location: ".getenv('APP_URL'));
 }
 ?>
 

Please login to merge, or discard this patch.

		@@ -10,37 +10,37 @@
		block discarded – undo
10	10	$connect = mysqli_connect(
11	11	getenv('DB_HOST'),
12	12	getenv('DB_USER'),
13		- getenv('DB_PASSWORD'),
14		- getenv('DB_NAME')
	13	+ getenv('DB_PASSWORD'),
	14	+ getenv('DB_NAME')
15	15	);
16	16
17	17	$userId = Session::get('start');
18	18	$data = '';
19	19	if(isset($_POST['submit']))
20	20	{
21		- $data = Profile::getProfile($userId);
22		- if($data != NULL):
23		- $status = get($_POST['status'], $data['status']);
24		- $edu = get($_POST['education'], $data['education']);
25		- $gender = get($_POST['gender'], $data['gender']);
26		- $query = "UPDATE profile set status = '$status', education = '$edu', gender = '$gender' where login_id = '$userId'";
27		- if($result = $connect->query($query))
28		- {
29		- header('Location:'.getenv('APP_URL').'/account.php');
30		- }
31		- else
32		- {
33		- header("Location:".getenv('APP_URL')."/error.php");
34		- }
35		- endif;
	21	+ $data = Profile::getProfile($userId);
	22	+ if($data != NULL):
	23	+ $status = get($_POST['status'], $data['status']);
	24	+ $edu = get($_POST['education'], $data['education']);
	25	+ $gender = get($_POST['gender'], $data['gender']);
	26	+ $query = "UPDATE profile set status = '$status', education = '$edu', gender = '$gender' where login_id = '$userId'";
	27	+ if($result = $connect->query($query))
	28	+ {
	29	+ header('Location:'.getenv('APP_URL').'/account.php');
	30	+ }
	31	+ else
	32	+ {
	33	+ header("Location:".getenv('APP_URL')."/error.php");
	34	+ }
	35	+ endif;
36	36	}
37	37	else
38	38	{
39		- header("Location:".getenv('APP_URL')."/error.php");
	39	+ header("Location:".getenv('APP_URL')."/error.php");
40	40	}
41	41
42	42	function get($value, $default)
43	43	{
44		- $value = trim($value);
45		- return (isset($value) ? $value : $default);
	44	+ $value = trim($value);
	45	+ return (isset($value) ? $value : $default);
46	46	}

		@@ -1,6 +1,6 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-require_once (__DIR__ . '/vendor/autoload.php');
	3	+require_once (__DIR__.'/vendor/autoload.php');
4	4	use ChatApp\Session;
5	5	use ChatApp\Profile;
6	6	use Dotenv\Dotenv;
		@@ -16,15 +16,15 @@ discard block
		block discarded – undo
16	16
17	17	$userId = Session::get('start');
18	18	$data = '';
19		-if(isset($_POST['submit']))
	19	+if (isset($_POST['submit']))
20	20	{
21	21	$data = Profile::getProfile($userId);
22		- if($data != NULL):
	22	+ if ($data != NULL):
23	23	$status = get($_POST['status'], $data['status']);
24	24	$edu = get($_POST['education'], $data['education']);
25	25	$gender = get($_POST['gender'], $data['gender']);
26	26	$query = "UPDATE profile set status = '$status', education = '$edu', gender = '$gender' where login_id = '$userId'";
27		- if($result = $connect->query($query))
	27	+ if ($result = $connect->query($query))
28	28	{
29	29	header('Location:'.getenv('APP_URL').'/account.php');
30	30	}

		@@ -14,26 +14,26 @@ discard block
		block discarded – undo
14	14	$userId = Session::get('start');
15	15	if($userId != null && $user == "account.php")
16	16	{
17		- $obUser = new User();
18		- $row = $obUser->userDetails($userId, True);
	17	+ $obUser = new User();
	18	+ $row = $obUser->userDetails($userId, True);
19	19
20		- if($row != NULL)
21		- {
22		- $location = getenv('APP_URL') . "/account.php/". $row['username'];
23		- header("Location:".$location);
24		- }
	20	+ if($row != NULL)
	21	+ {
	22	+ $location = getenv('APP_URL') . "/account.php/". $row['username'];
	23	+ header("Location:".$location);
	24	+ }
25	25	}
26	26	elseif ($user != "account.php")
27	27	{
28		- $obUser = new User();
29		- $row = $obUser->userDetails($user, False);
30		- if($row != NULL):
31		- $userId = $row['login_id'];
32		- $details = Profile::getProfile($userId);
33		- if($details != NULL)
34		- $row = array_merge($row, $details);
35		- else
36		- header("Location:".getenv('APP_URL')."/error.php");
	28	+ $obUser = new User();
	29	+ $row = $obUser->userDetails($user, False);
	30	+ if($row != NULL):
	31	+ $userId = $row['login_id'];
	32	+ $details = Profile::getProfile($userId);
	33	+ if($details != NULL)
	34	+ $row = array_merge($row, $details);
	35	+ else
	36	+ header("Location:".getenv('APP_URL')."/error.php");
37	37	?>
38	38
39	39	<!Doctype html>
		@@ -68,18 +68,18 @@ discard block
		block discarded – undo
68	68	<div class="brief">
69	69	<h1 id="name">Name: <?php echo $row['name']; ?></h1><br>
70	70	<?php foreach ($row as $key => $value) {
71		- if($key =='username' && $value != null)
72		- echo '<p>Username: '.$row["username"] .'</p><br>';
73		- if($key == 'email' && $value != null)
74		- echo '<p>Email Id: '.$row["email"] .'</p><br>';
75		- if($key == 'status' && $value != null)
76		- echo '<p>Status: '.$row["status"] .'</p><br>';
77		- if($key == 'education' && $value != null)
78		- echo '<p>Education: '.$row["education"] .'</p><br>';
79		- if($key == 'gender' && $value != null)
80		- echo '<p>Gender: '.$row["gender"] .'</p><br>';
81		- }
82		- ?>
	71	+ if($key =='username' && $value != null)
	72	+ echo '<p>Username: '.$row["username"] .'</p><br>';
	73	+ if($key == 'email' && $value != null)
	74	+ echo '<p>Email Id: '.$row["email"] .'</p><br>';
	75	+ if($key == 'status' && $value != null)
	76	+ echo '<p>Status: '.$row["status"] .'</p><br>';
	77	+ if($key == 'education' && $value != null)
	78	+ echo '<p>Education: '.$row["education"] .'</p><br>';
	79	+ if($key == 'gender' && $value != null)
	80	+ echo '<p>Gender: '.$row["gender"] .'</p><br>';
	81	+ }
	82	+ ?>
83	83	</div>
84	84	<?php if(Session::get('start') == $row['login_id']): ?>
85	85	<div class="edit">
		@@ -89,8 +89,8 @@ discard block
		block discarded – undo
89	89	</div>
90	90
91	91	<?php
92		- if(Session::get('start') == $row['login_id']):
93		- ?>
	92	+ if(Session::get('start') == $row['login_id']):
	93	+ ?>
94	94
95	95	<div class="boxx" id="profile">
96	96	<form method="post" action="../profile_generate.php">
		@@ -105,8 +105,8 @@ discard block
		block discarded – undo
105	105	</form>
106	106	</div>
107	107	<?php
108		- endif;
109		- ?>
	108	+ endif;
	109	+ ?>
110	110	</div>
111	111
112	112	<div class="footer">
		@@ -119,13 +119,13 @@ discard block
		block discarded – undo
119	119	</body>
120	120	</html>
121	121	<?php
122		- else:
123		- header("Location:".getenv('APP_URL')."/error.php");
124		- endif;
	122	+ else:
	123	+ header("Location:".getenv('APP_URL')."/error.php");
	124	+ endif;
125	125	}
126	126	else
127	127	{
128		- header("Location: ".getenv('APP_URL'));
	128	+ header("Location: ".getenv('APP_URL'));
129	129	}
130	130	?>
131	131

ankitjain28may / openchat

Push — master ( 3b96a7...361ab6 )

Status

Category

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +36 added lines, -36 removed lines patch added patch discarded remove patch