ankitjain28may / openchat

src/Chat.php

Doc Comments +14 added lines

@@ -25,6 +25,9 @@ 
         Online::setOnlineStatus($conn->userId);
     }
 
+    /**
+     * @param ConnectionInterface $conn
+     */
     public function setID($conn)
     {
         session_id($conn->WebSocket->request->getCookies()['PHPSESSID']);
@@ -129,18 +132,29 @@ 
         return $obSidebar->loadSideBar($data);
     }
 
+    /**
+     * @param string $data
+     * @param boolean $para
+     */
     public function onConversation($data, $para, $sessionId)
     {
         $obConversation = new Conversation($sessionId);
         return $obConversation->conversationLoad($data, $para);
     }
 
+    /**
+     * @param string $data
+     * @param boolean $para
+     */
     public function onReceiver($data, $para, $sessionId)
     {
         $obReceiver = new Receiver($sessionId);
         return $obReceiver->receiverLoad($data, $para);
     }
 
+    /**
+     * @param string $data
+     */
     public function onSearch($data, $sessionId)
     {
         $obSearch = new Search($sessionId);

Spacing +9 added lines, -9 removed lines

@@ -36,12 +36,12 @@ 
 
     public function onMessage(ConnectionInterface $from, $msg) {
         $sessionId = $from->WebSocket->request->getCookies()['PHPSESSID'];
-        if($msg == 'OpenChat initiated..!')
+        if ($msg == 'OpenChat initiated..!')
         {
-            $initial = (object) array();
+            $initial = (object)array();
             $initial->initial = json_decode($this->onSidebar($from->userId));
 
-            if($initial->initial != null) {
+            if ($initial->initial != null) {
                 $initial->conversation = json_decode(
                     $this->onConversation(
                         json_encode([
@@ -55,13 +55,13 @@ 
         }
         elseif ($msg == 'Load Sidebar')
         {
-            $sidebar = (object) array();
+            $sidebar = (object)array();
             $sidebar->sidebar = json_decode($this->onSidebar($from->userId));
             $from->send(json_encode($sidebar));
         }
         elseif (@json_decode($msg)->newConversation == 'Initiated')
         {
-            $result = (object) array();
+            $result = (object)array();
             $result->conversation = json_decode($this->onConversation($msg, False, $sessionId));
             $from->send(json_encode($result));
         }
@@ -79,13 +79,13 @@ 
         }
         else
         {
-            $msg = (object) json_decode($msg);
+            $msg = (object)json_decode($msg);
             $msg->userId = $from->userId;
             $getReturn = $this->onReply($msg);
             echo $getReturn;
 
-            $receiveResult = (object) array();
-            $sentResult = (object) array();
+            $receiveResult = (object)array();
+            $sentResult = (object)array();
             foreach ($this->clients as $client)
             {
                 if ($client->userId == $msg->name)
@@ -103,7 +103,7 @@ 
 
                     $client->send(json_encode($receiveResult));
                 }
-                elseif($client == $from)
+                elseif ($client == $from)
                 {
                     $sentResult->sidebar = json_decode($this->onSidebar($client->userId));
 

src/Reply.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace ChatApp;
 require_once (dirname(__DIR__) . '/vendor/autoload.php');
-use ChatApp\Session;
 use Dotenv\Dotenv;
 $dotenv = new Dotenv(dirname(__DIR__));
 $dotenv->load();

Spacing +17 added lines, -17 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 
 namespace ChatApp;
-require_once (dirname(__DIR__) . '/vendor/autoload.php');
+require_once (dirname(__DIR__).'/vendor/autoload.php');
 use ChatApp\Session;
 use Dotenv\Dotenv;
 $dotenv = new Dotenv(dirname(__DIR__));
@@ -27,35 +27,35 @@ 
 
     public function replyTo($msg)
     {
-        if(!empty($msg))  //checks for the value send
+        if (!empty($msg))  //checks for the value send
         {
             $userId = $msg->userId;
             $identifier = $msg->name;
-            $receiverID = $identifier;  //stores id of the person whom message is to be sent
+            $receiverID = $identifier; //stores id of the person whom message is to be sent
 
-            if($identifier > $userId)    // geneate specific unique code to store messages
-                $identifier = $userId . ":" . $identifier;
+            if ($identifier > $userId)    // geneate specific unique code to store messages
+                $identifier = $userId.":".$identifier;
             else
-                $identifier = $identifier . ":" . $userId;
+                $identifier = $identifier.":".$userId;
 
             $reply = addslashes(trim($msg->reply[0])); // stores the message sent by the user.
 
-            $time = date("D d M Y H:i:s", time() + 16200);  // current time
+            $time = date("D d M Y H:i:s", time() + 16200); // current time
             $time_id = date("YmdHis", time() + 16200); //to sort the array on the basis of time
 
             //the sender id must not be equal to current session id
-            if($reply != "" && $receiverID != $userId)
+            if ($reply != "" && $receiverID != $userId)
             {
                 // check whether the receiver is authorized or registered
                 $query = "SELECT * from login where login_id = '$receiverID'";
 
                 $result = $this->connect->query($query);
-                if($result->num_rows > 0)     // if true
+                if ($result->num_rows > 0)     // if true
                 {
                     //check whether he is sending message for thr first time or he has sent messages before
                     $query = "SELECT * from total_message where identifier = '$identifier'";
                     $result = $this->connect->query($query);
-                    if($result->num_rows>0)               // if he has sent messages before
+                    if ($result->num_rows > 0)               // if he has sent messages before
                     {
                         // Update Total_Message Table
                         $query = "UPDATE total_message SET total_messages = total_messages+1, time = '$time', unread = 1, id = '$time_id' WHERE identifier = '$identifier'";
@@ -65,15 +65,15 @@ 
                     else    // if he sends message for the first time
                     {
                         $length = strlen($userId);
-                        if(substr($identifier, 0, $length) == $userId) // generate specific unique code
+                        if (substr($identifier, 0, $length) == $userId) // generate specific unique code
                         {
-                            $user2 = substr($identifier, $length+1);
+                            $user2 = substr($identifier, $length + 1);
                             $user1 = $userId;
                         }
                         else
                         {
                             $user2 = $userId;
-                            $length = strlen($identifier) - $length-1;
+                            $length = strlen($identifier) - $length - 1;
                             $user1 = substr($identifier, 0, $length);
                         }
                         // insert Details in Total_Message Table
@@ -81,7 +81,7 @@ 
                         return $this->updateMessages($query, $identifier, $reply, $userId, $time);
                     }
                 }
-                return "Invalid Authentication";  // if he is unauthorized echo message is failed
+                return "Invalid Authentication"; // if he is unauthorized echo message is failed
             }
         }
         return "Failed";
@@ -89,13 +89,13 @@ 
 
     public function updateMessages($query, $identifier, $reply, $userId, $time)
     {
-        if($result = $this->connect->query($query))
+        if ($result = $this->connect->query($query))
         {
             //insert message in db
             $query = "INSERT into messages values('$identifier', '$reply', '$userId', '$time', null)";
-            if($this->connect->query($query))
+            if ($this->connect->query($query))
             {
-                return "Messages is sent";    // if query is executed return true
+                return "Messages is sent"; // if query is executed return true
             }
             return "Message is failed";
         }

Braces +19 added lines, -11 removed lines

@@ -27,16 +27,20 @@ 
 
     public function replyTo($msg)
     {
-        if(!empty($msg))  //checks for the value send
+        if(!empty($msg)) {
+            //checks for the value send
         {
             $userId = $msg->userId;
+        }
             $identifier = $msg->name;
             $receiverID = $identifier;  //stores id of the person whom message is to be sent
 
-            if($identifier > $userId)    // geneate specific unique code to store messages
+            if($identifier > $userId) {
+                // geneate specific unique code to store messages
                 $identifier = $userId . ":" . $identifier;
-            else
-                $identifier = $identifier . ":" . $userId;
+            } else {
+                            $identifier = $identifier . ":" . $userId;
+            }
 
             $reply = addslashes(trim($msg->reply[0])); // stores the message sent by the user.
 
@@ -50,27 +54,31 @@ 
                 $query = "SELECT * from login where login_id = '$receiverID'";
 
                 $result = $this->connect->query($query);
-                if($result->num_rows > 0)     // if true
+                if($result->num_rows > 0) {
+                    // if true
                 {
                     //check whether he is sending message for thr first time or he has sent messages before
                     $query = "SELECT * from total_message where identifier = '$identifier'";
+                }
                     $result = $this->connect->query($query);
-                    if($result->num_rows>0)               // if he has sent messages before
+                    if($result->num_rows>0) {
+                        // if he has sent messages before
                     {
                         // Update Total_Message Table
                         $query = "UPDATE total_message SET total_messages = total_messages+1, time = '$time', unread = 1, id = '$time_id' WHERE identifier = '$identifier'";
+                    }
                         return $this->updateMessages($query, $identifier, $reply, $userId, $time);
 
-                    }
-                    else    // if he sends message for the first time
+                    } else    // if he sends message for the first time
                     {
                         $length = strlen($userId);
-                        if(substr($identifier, 0, $length) == $userId) // generate specific unique code
+                        if(substr($identifier, 0, $length) == $userId) {
+                            // generate specific unique code
                         {
                             $user2 = substr($identifier, $length+1);
-                            $user1 = $userId;
                         }
-                        else
+                            $user1 = $userId;
+                        } else
                         {
                             $user2 = $userId;
                             $length = strlen($identifier) - $length-1;

tests/TestAll.php

Spacing +3 added lines, -3 removed lines

@@ -180,7 +180,7 @@ 
     */
     public function testReply($userId)
     {
-        $msg =(object) [
+        $msg = (object)[
             "name" => $userId,
             "reply" => [
                 0 => "Hello World"
@@ -207,7 +207,7 @@ 
         $output = $obReply->replyTo([]);
         $this->assertEquals("Failed", $output);
 
-        $output = $obReply->replyTo((object) [
+        $output = $obReply->replyTo((object)[
             "name" => -1,
             "reply" => [
                 0 => "Hello World"
@@ -216,7 +216,7 @@ 
         ]);
         $this->assertEquals("Invalid Authentication", $output);
 
-        $output = $obReply->replyTo((object) [
+        $output = $obReply->replyTo((object)[
             "name" => $userId,
             "reply" => [
                 0 => "Hello"

src/Compose.php

Spacing +5 added lines, -5 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 
 namespace ChatApp;
-require_once (dirname(__DIR__) . '/vendor/autoload.php');
+require_once (dirname(__DIR__).'/vendor/autoload.php');
 use ChatApp\Session;
 use Dotenv\Dotenv;
 $dotenv = new Dotenv(dirname(__DIR__));
@@ -33,14 +33,14 @@ 
         $userId = $msg->userId;
         $suggestion = $msg->value;
         $suggestion = trim($suggestion);
-        if(!empty($userId) && !empty($suggestion))
+        if (!empty($userId) && !empty($suggestion))
         {
             $query = "SELECT * FROM login where login_id != '$userId' and name like '$suggestion%' ORDER BY name DESC";
-            if($result = $this->connect->query($query))
+            if ($result = $this->connect->query($query))
             {
-                if($result->num_rows > 0)
+                if ($result->num_rows > 0)
                 {
-                    while($row = $result->fetch_assoc())
+                    while ($row = $result->fetch_assoc())
                     {
                         $this->array = array_merge($this->array, [$row]);
                     }