angellco\spoon\migrations\m190815_143313_UpdateFieldLayouts::safeUp()

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function safeUp()
    {
        $records = FieldLayoutRecord::findWithTrashed()->where(['type' => 'Spoon_BlockType'])->all();

        foreach ($records as $record) {
            $record->type = BlockType::class;

Accessing type on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            $record->save(false);
        }