angellco\spoon\migrations\m190815_143313_UpdateFieldLayouts

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	safeUp()	0	7	2
A	safeDown()	0	4	1

<?php

namespace angellco\spoon\migrations;

use angellco\spoon\models\BlockType;
use Craft;
use craft\db\Migration;
use craft\records\FieldLayout as FieldLayoutRecord;

/**
 * m190815_143313_UpdateFieldLayouts migration.
 */
class m190815_143313_UpdateFieldLayouts extends Migration
{
    /**
     * @inheritdoc
     */
    public function safeUp()
    {
        $records = FieldLayoutRecord::findWithTrashed()->where(['type' => 'Spoon_BlockType'])->all();

        foreach ($records as $record) {
            $record->type = BlockType::class;

Accessing type on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            $record->save(false);
        }
    }

    /**
     * @inheritdoc
     */
    public function safeDown()
    {
        echo "m190815_143313_UpdateFieldLayouts cannot be reverted.\n";
        return false;
    }
}