andylolz / everypolitician-popolo-php

src/Objects/Event.php

Doc Comments +3 added lines

@@ -57,6 +57,9 @@
         return $this->getRelatedObjectArr('identifiers');
     }
 
+    /**
+     * @param \DateTime $when
+     */
     public function currentAt($when)
     {
         return ($when >= $this->startDate && $when <= $this->endDate);

Indentation +4 added lines, -4 removed lines

@@ -22,12 +22,12 @@ 
 
     protected function getName()
     {
-         return $this->arrGet($this->data, 'name');
+            return $this->arrGet($this->data, 'name');
     }
 
     protected function getClassification()
     {
-         return $this->arrGet($this->data, 'classification');
+            return $this->arrGet($this->data, 'classification');
     }
 
     protected function getStartDate()
@@ -44,12 +44,12 @@ 
 
     protected function getOrganizationId()
     {
-         return $this->arrGet($this->data, 'organization_id');
+            return $this->arrGet($this->data, 'organization_id');
     }
 
     protected function getOrganization()
     {
-         return $this->allPopolo->organizations->lookupFromKey[$this->organizationId];
+            return $this->allPopolo->organizations->lookupFromKey[$this->organizationId];
     }
 
     protected function getIdentifiers()

src/Objects/PopoloObject.php

Doc Comments +20 added lines

@@ -53,6 +53,9 @@ 
         return $this->arrGet($this->data, $popoloArray, []);
     }
 
+    /**
+     * @param string $attr
+     */
     protected function getDate($attr, $default = null)
     {
         $d = $this->arrGet($this->data, $attr);
@@ -62,6 +65,11 @@ 
         return $default;
     }
 
+    /**
+     * @param string $popoloArray
+     * @param string $infoTypeKey
+     * @param string $infoValueKey
+     */
     private function getRelatedValues($popoloArray, $infoTypeKey, $infoType, $infoValueKey)
     {
         /* Get a value from one of the Popolo related objects
@@ -106,6 +114,9 @@ 
         return $this->getRelatedValues('identifiers', 'scheme', $scheme, 'identifier');
     }
 
+    /**
+     * @param string $scheme
+     */
     public function identifierValue($scheme)
     {
         $identifierValues = $this->identifierValues($scheme);
@@ -117,6 +128,9 @@ 
         return $this->getRelatedValues('links', 'note', $note, 'url');
     }
 
+    /**
+     * @param string $note
+     */
     public function linkValue($note)
     {
         $linkValues = $this->linkValues($note);
@@ -128,6 +142,9 @@ 
         return $this->getRelatedValues('contact_details', 'type', $contactType, 'value');
     }
 
+    /**
+     * @param string $contactType
+     */
     public function contactDetailValue($contactType)
     {
         $contactDetailValues = $this->contactDetailValues($contactType);
@@ -142,6 +159,9 @@ 
         throw new \BadMethodCallException;
     }
 
+    /**
+     * @param string $popoloArray
+     */
     public function getRelatedObjectArr($popoloArray)
     {
         return $this->arrGet($this->data, $popoloArray, []);

Indentation +2 added lines, -2 removed lines

@@ -40,12 +40,12 @@
 
     protected function getId()
     {
-         return $this->arrGet($this->data, 'id');
+            return $this->arrGet($this->data, 'id');
     }
 
     protected function getKeyForHash()
     {
-         return $this->getId();
+            return $this->getId();
     }
 
     private function getRelatedObjects($popoloArray)

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     {
         $properties = array_merge($this->baseProperties, $this->properties);
         if (in_array($prop, $properties)) {
-            $getter = 'get' . ucfirst($prop);
+            $getter = 'get'.ucfirst($prop);
             return $this->$getter();
         }
         trigger_error('Undefined property: '.__CLASS__.'::$'.$prop, E_USER_ERROR);

src/Collections/PopoloCollection.php

Spacing +3 added lines, -3 removed lines

@@ -29,7 +29,7 @@ 
     public function __get($prop)
     {
         if (in_array($prop, $this->properties)) {
-            $getter = 'get' . ucfirst($prop);
+            $getter = 'get'.ucfirst($prop);
             return $this->$getter();
         }
         trigger_error('Undefined property: '.__CLASS__.'::$'.$prop, E_USER_ERROR);
@@ -63,10 +63,10 @@ 
         $matches = $this->filter($filters);
         $n = count($matches);
         if ($n == 0) {
-            $msg = "No " . $this->objectClass . " found matching " . json_encode($filters);
+            $msg = "No ".$this->objectClass." found matching ".json_encode($filters);
             throw new Exceptions\ObjectDoesNotExistException($msg);
         } elseif ($n > 1) {
-            $msg = "Multiple " . $this->objectClass . " objects ($n) found matching " . json_encode($filters);
+            $msg = "Multiple ".$this->objectClass." objects ($n) found matching ".json_encode($filters);
             throw new Exceptions\MultipleObjectsReturnedException($msg);
         }
         return $matches[0];

src/Objects/Area.php

Indentation +4 added lines, -4 removed lines

@@ -19,22 +19,22 @@
 
     protected function getName()
     {
-         return $this->arrGet($this->data, 'name');
+            return $this->arrGet($this->data, 'name');
     }
 
     protected function getType()
     {
-         return $this->arrGet($this->data, 'type');
+            return $this->arrGet($this->data, 'type');
     }
 
     protected function getIdentifiers()
     {
-         return $this->getRelatedObjectArr('identifiers');
+            return $this->getRelatedObjectArr('identifiers');
     }
 
     protected function getOtherNames()
     {
-         return $this->getRelatedObjectArr('other_names');
+            return $this->getRelatedObjectArr('other_names');
     }
 
     protected function getWikidata()

src/Objects/Post.php

Indentation +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 
     protected function getLabel()
     {
-         return $this->arrGet($this->data, 'label');
+            return $this->arrGet($this->data, 'label');
     }
 
     protected function getOrganizationId()

src/Objects/Person.php

Indentation +18 added lines, -18 removed lines

@@ -47,52 +47,52 @@ 
 
     protected function getEmail()
     {
-         return $this->arrGet($this->data, 'email');
+            return $this->arrGet($this->data, 'email');
     }
 
     protected function getGender()
     {
-         return $this->arrGet($this->data, 'gender');
+            return $this->arrGet($this->data, 'gender');
     }
 
     protected function getHonorificPrefix()
     {
-         return $this->arrGet($this->data, 'honorific_prefix');
+            return $this->arrGet($this->data, 'honorific_prefix');
     }
 
     protected function getHonorificSuffix()
     {
-         return $this->arrGet($this->data, 'honorific_suffix');
+            return $this->arrGet($this->data, 'honorific_suffix');
     }
 
     protected function getImage()
     {
-         return $this->arrGet($this->data, 'image');
+            return $this->arrGet($this->data, 'image');
     }
 
     protected function getName()
     {
-         return $this->arrGet($this->data, 'name');
+            return $this->arrGet($this->data, 'name');
     }
 
     protected function getSortName()
     {
-         return $this->arrGet($this->data, 'sort_name');
+            return $this->arrGet($this->data, 'sort_name');
     }
 
     protected function getNationalIdentity()
     {
-         return $this->arrGet($this->data, 'national_identity');
+            return $this->arrGet($this->data, 'national_identity');
     }
 
     protected function getSummary()
     {
-         return $this->arrGet($this->data, 'summary');
+            return $this->arrGet($this->data, 'summary');
     }
 
     protected function getBiography()
     {
-         return $this->arrGet($this->data, 'biography');
+            return $this->arrGet($this->data, 'biography');
     }
 
     protected function getBirthDate()
@@ -107,12 +107,12 @@ 
 
     protected function getFamilyName()
     {
-         return $this->arrGet($this->data, 'family_name');
+            return $this->arrGet($this->data, 'family_name');
     }
 
     protected function getGivenName()
     {
-         return $this->arrGet($this->data, 'given_name');
+            return $this->arrGet($this->data, 'given_name');
     }
 
     protected function getWikidata()
@@ -185,32 +185,32 @@ 
 
     protected function getLinks()
     {
-         return $this->getRelatedObjectArr('links');
+            return $this->getRelatedObjectArr('links');
     }
 
     protected function getContactDetails()
     {
-         return $this->getRelatedObjectArr('contact_details');
+            return $this->getRelatedObjectArr('contact_details');
     }
 
     protected function getIdentifiers()
     {
-         return $this->getRelatedObjectArr('identifiers');
+            return $this->getRelatedObjectArr('identifiers');
     }
 
     protected function getImages()
     {
-         return $this->getRelatedObjectArr('images');
+            return $this->getRelatedObjectArr('images');
     }
 
     protected function getOtherNames()
     {
-         return $this->getRelatedObjectArr('other_names');
+            return $this->getRelatedObjectArr('other_names');
     }
 
     protected function getSources()
     {
-         return $this->getRelatedObjectArr('sources');
+            return $this->getRelatedObjectArr('sources');
     }
 
     protected function getMemberships()

Spacing +2 added lines, -2 removed lines

@@ -252,8 +252,8 @@
             return $this->name;
         }
         if (count($namesAtDate) > 1) {
-            $msg = 'Multiple names for ' . (string) $this;
-            $msg .= ' found at date ' . $particularDate->format('Y-m-d');
+            $msg = 'Multiple names for '.(string) $this;
+            $msg .= ' found at date '.$particularDate->format('Y-m-d');
             throw new \Exception($msg);
         }
         return $namesAtDate[0]['name'];