andrewfenn / awshelper

src/AwsHelper/AwsHelper.php

Doc Comments +3 added lines

@@ -81,6 +81,9 @@
         return $opts;
     }
 
+    /**
+     * @param string $iam_url
+     */
     private function getAccessData($iam_role, $iam_url)
     {
         /* grab the access and secret key from the iam role "aws-opsworks-ec2-role" */

Spacing +3 added lines, -3 removed lines

@@ -10,7 +10,7 @@ 
     private $iam_role;
     private $iam_url;
 
-    public function __construct($iam_role, $iam_url='http://169.254.169.254/latest/meta-data/iam/security-credentials/')
+    public function __construct($iam_role, $iam_url = 'http://169.254.169.254/latest/meta-data/iam/security-credentials/')
     {
 
         if (empty($iam_role))
@@ -41,7 +41,7 @@ 
         return $this->json;
     }
 
-    public function getDefaultOptions($aws_key=null, $aws_secret=null)
+    public function getDefaultOptions($aws_key = null, $aws_secret = null)
     {
         $opts = [
             'key'    => $aws_key,
@@ -103,7 +103,7 @@ 
     public function hasAccessExpired($date)
     {
         $date = new \DateTime($date);
-        if ($date->format('U')-date('U') > 0)
+        if ($date->format('U') - date('U') > 0)
             return false;
 
         return true;

Braces +27 added lines, -18 removed lines

@@ -13,25 +13,30 @@ 
     public function __construct($iam_role, $iam_url='http://169.254.169.254/latest/meta-data/iam/security-credentials/')
     {
 
-        if (empty($iam_role))
-            throw new \Exception('iam_role is empty');
+        if (empty($iam_role)) {
+                    throw new \Exception('iam_role is empty');
+        }
 
-        if (empty($iam_url))
-            throw new \Exception('iam_url is empty');
+        if (empty($iam_url)) {
+                    throw new \Exception('iam_url is empty');
+        }
 
         $this->iam_role = $iam_role;
         $this->iam_url  = $iam_url;
 
         $json = $this->getAccessData($iam_role, $iam_url);
 
-        if ($json->Code !== 'Success')
-            throw new \Exception('Unsuccessful in returning iam amazon credentials');
+        if ($json->Code !== 'Success') {
+                    throw new \Exception('Unsuccessful in returning iam amazon credentials');
+        }
 
-        if (empty($json->AccessKeyId))
-            throw new \Exception('AccessKeyId does not exist.');
+        if (empty($json->AccessKeyId)) {
+                    throw new \Exception('AccessKeyId does not exist.');
+        }
 
-        if (empty($json->SecretAccessKey))
-            throw new \Exception('SecretAccessKey does not exist.');
+        if (empty($json->SecretAccessKey)) {
+                    throw new \Exception('SecretAccessKey does not exist.');
+        }
 
         $this->json = $json;
     }
@@ -52,14 +57,17 @@ 
         {
             $json = $this->getJSON();
 
-            if ($json->Code !== 'Success')
-                throw new \Exception('Unsuccessful in returning iam amazon credentials');
+            if ($json->Code !== 'Success') {
+                            throw new \Exception('Unsuccessful in returning iam amazon credentials');
+            }
 
-            if (empty($json->AccessKeyId))
-                throw new \Exception('AccessKeyId does not exist. This is possibly a problem with you aws setup.');
+            if (empty($json->AccessKeyId)) {
+                            throw new \Exception('AccessKeyId does not exist. This is possibly a problem with you aws setup.');
+            }
 
-            if (empty($json->SecretAccessKey))
-                throw new \Exception('SecretAccessKey does not exist. This is possibly a problem with you aws setup.');
+            if (empty($json->SecretAccessKey)) {
+                            throw new \Exception('SecretAccessKey does not exist. This is possibly a problem with you aws setup.');
+            }
 
             if (!empty($json->Token))
             {
@@ -103,8 +111,9 @@ 
     public function hasAccessExpired($date)
     {
         $date = new \DateTime($date);
-        if ($date->format('U')-date('U') > 0)
-            return false;
+        if ($date->format('U')-date('U') > 0) {
+                    return false;
+        }
 
         return true;
     }

src/AwsHelper/S3Helper.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php namespace AwsHelper;
 
 use Aws\S3\S3Client;
-use Aws\S3\Exception\S3Exception;
 
 class S3Helper
 {

Braces +10 added lines, -8 removed lines

@@ -45,8 +45,9 @@ 
     */
     public function saveFile($file_location, $s3_location, $acl = 'private', $params = [])
     {
-        if ($this->s3 == null)
-            return false;
+        if ($this->s3 == null) {
+                    return false;
+        }
 
         $this->getClient();
 
@@ -72,8 +73,9 @@ 
     */
     public function saveFileContent($file_content, $s3_location, $acl = 'private', $params = [])
     {
-        if ($this->s3 == null)
-            return false;
+        if ($this->s3 == null) {
+                    return false;
+        }
 
         $this->getClient();
 
@@ -96,8 +98,9 @@ 
     */
     public function getFile($s3_location)
     {
-        if ($this->s3 == null)
-            return false;
+        if ($this->s3 == null) {
+                    return false;
+        }
 
         $this->getClient();
 
@@ -106,8 +109,7 @@ 
                 'Bucket' => $this->bucket_name,
                 'Key'    => $s3_location,
             ]);
-        }
-        catch (\Exception $e)
+        } catch (\Exception $e)
         {
             return false;
         }

src/AwsHelper/SqsHelper.php

Doc Comments +4 added lines, -1 removed lines

@@ -95,7 +95,7 @@ 
 
     /**
      * Get a list of queue attributes
-     * @param  array $attributes An array of queue attribute names
+     * @param  string[] $attributes An array of queue attribute names
      * @return array             An array of specified queue attributes with keys as attribute names
      */
     public function getQueueAttributes($attributes)
@@ -135,6 +135,9 @@ 
         return $this->data;
     }
 
+    /**
+     * @param string $key
+     */
     public function get($key)
     {
         return $this->data[$key];

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php namespace AwsHelper;
 
 use Aws\Sqs\SqsClient;
-use Aws\S3\Exception\S3Exception;
 
 class SqsHelper
 {