andela-tolotin / Potato-ORM

src/Database/DatabaseHandler.php

Doc Comments +10 added lines, -1 removed lines

@@ -22,6 +22,7 @@ 
 
 	/**
 	 * This is a constructor; a default method  that will be called automatically during class instantiation
+	 * @param string|false $modelClassName
 	 */
 	public function __construct($modelClassName, $dbConn = Null)
 	{
@@ -40,6 +41,7 @@ 
 	/**
 	 * This method create a record and store it in a table row
 	 * @params associative array, string tablename
+	 * @param string|false $tableName
 	 * @return boolean true or false
 	 */
 	public function create($associative1DArray, $tableName, $dbConn = Null)
@@ -81,6 +83,10 @@ 
 	 * @params: $updateParams, $tableName, $associative1DArray
 	 * @return boolean true or false
 	 */
+
+	/**
+	 * @param string|false $tableName
+	 */
 	public function update(array $updateParams, $tableName, $associative1DArray, $dbConn = Null)
 	{
 		$sql = "";
@@ -124,6 +130,7 @@ 
 	/**
 	 * This method retrieves record from a table
 	 * @params int id, string tableName
+	 * @param string|false $tableName
 	 * @return array
 	 */
 	public static function read($id, $tableName, $dbConn = Null)
@@ -161,6 +168,7 @@ 
 	/**
 	 * This method deletes a record  from a table row
 	 * @params int id, string tableName
+	 * @param string|false $tableName
 	 * @return boolean true or false
 	 */
 	public static function delete($id, $tableName, $dbConn = Null)
@@ -201,7 +209,7 @@ 
 
 	/**
 	 * This method returns sql query
-	 * @param $sql
+	 * @param string $sql
 	 * @return string
 	 */
 	private function prepareUpdateQuery($sql)
@@ -254,6 +262,7 @@ 
 	 * This method returns column fields of a particular table
 	 * @param $table
 	 * @param $conn
+	 * @param DatabaseConnection $dbConn
 	 * @return array
 	 */
 	public function getColumnNames($table, $dbConn = Null){

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 namespace Laztopaz\potatoORM;
 
 use PDO;
-use Laztopaz\potatoORM\DatabaseHelper;
 use Laztopaz\potatoORM\TableFieldUndefinedException;
 use Laztopaz\potatoORM\EmptyArrayException;
 

Spacing +20 added lines, -20 removed lines

@@ -44,11 +44,11 @@ 
 	 */
 	public function create($associative1DArray, $tableName, $dbConn = Null)
 	{
-		$unexpectedFields = self::checkIfMagicSetterContainsIsSameAsClassModel($this->getColumnNames($this->model, $this->dbConnection),$associative1DArray);
+		$unexpectedFields = self::checkIfMagicSetterContainsIsSameAsClassModel($this->getColumnNames($this->model, $this->dbConnection), $associative1DArray);
 
 		if (count($unexpectedFields) > 0)
 		{
-			throw TableFieldUndefinedException::fieldsNotDefinedException($unexpectedFields,"needs to be created as table field");
+			throw TableFieldUndefinedException::fieldsNotDefinedException($unexpectedFields, "needs to be created as table field");
 		}
 
 		unset($this->getColumnNames($this->model, $this->dbConnection)[0]);
@@ -59,7 +59,7 @@ 
 
 		$insertQuery = 'INSERT INTO '.$tableName;
 
-		$TableValues = implode(',',array_keys($associative1DArray));
+		$TableValues = implode(',', array_keys($associative1DArray));
 
 		foreach ($associative1DArray as $field => $value) {
 
@@ -67,13 +67,13 @@ 
 		}
 		$splittedTableValues = implode(',', $FormValues);
 
-		$insertQuery.= ' ('.$TableValues.')';
+		$insertQuery .= ' ('.$TableValues.')';
 
-		$insertQuery.= ' VALUES ('.$splittedTableValues.')';
+		$insertQuery .= ' VALUES ('.$splittedTableValues.')';
 
 		$executeQuery = $dbConn->exec($insertQuery);
 
-		return $executeQuery ? : false;
+		return $executeQuery ?: false;
 	}
 
 	/*
@@ -94,15 +94,15 @@ 
 
 		unset($associative1DArray['id']);
 
-		$unexpectedFields = self::checkIfMagicSetterContainsIsSameAsClassModel($this->getColumnNames($this->model, $this->dbConnection),$associative1DArray);
+		$unexpectedFields = self::checkIfMagicSetterContainsIsSameAsClassModel($this->getColumnNames($this->model, $this->dbConnection), $associative1DArray);
 
 		if (count($unexpectedFields) > 0) {
 
-			throw TableFieldUndefinedException::fieldsNotDefinedException($unexpectedFields,"needs to be created as table field");
+			throw TableFieldUndefinedException::fieldsNotDefinedException($unexpectedFields, "needs to be created as table field");
 		}
 
 
-		foreach($associative1DArray as $field => $value)
+		foreach ($associative1DArray as $field => $value)
 		{
 			$sql .= "`$field` = '$value'".",";
 		}
@@ -118,7 +118,7 @@ 
 
 		$boolResponse = $stmt->execute();
 
-		return $boolResponse ?  : false;
+		return $boolResponse ?: false;
 	}
 
 	/**
@@ -136,7 +136,7 @@ 
 
 		}
 
-		$sql = $id  ? 'SELECT * FROM '.$tableName.' WHERE id = '.$id : 'SELECT * FROM '.$tableName;
+		$sql = $id ? 'SELECT * FROM '.$tableName.' WHERE id = '.$id : 'SELECT * FROM '.$tableName;
 
 		try {
 			$stmt = $dbConn->prepare($sql);
@@ -150,7 +150,7 @@ 
 		}
 		$results = $stmt->fetchAll(PDO::FETCH_ASSOC);
 
-		foreach($results as $result) {
+		foreach ($results as $result) {
 
 			array_push($tableData, $result);
 		}
@@ -175,7 +175,7 @@ 
 
 		$boolResponse = $dbConn->exec($sql);
 
-		return $boolResponse ? : false;
+		return $boolResponse ?: false;
 	}
 
 	/**
@@ -190,7 +190,7 @@ 
 
 		foreach ($userSetterArray as $key => $val)
 		{
-			if (!in_array($key,$tableColumn)) {
+			if (!in_array($key, $tableColumn)) {
 
 				$unexpectedFields[] = $key;
 			}
@@ -206,11 +206,11 @@ 
 	 */
 	private function prepareUpdateQuery($sql)
 	{
-		$splittedQuery = explode(",",$sql);
+		$splittedQuery = explode(",", $sql);
 
 		array_pop($splittedQuery);
 
-		$mergeData = implode(",",$splittedQuery);
+		$mergeData = implode(",", $splittedQuery);
 
 		return $mergeData;
 	}
@@ -244,7 +244,7 @@ 
 
 			$returnedRowNumbers = $statement->rowCount();
 
-			return $returnedRowNumbers  ? true : false;
+			return $returnedRowNumbers ? true : false;
 		}
 
 		throw EmptyArrayException::checkEmptyArrayException("Array Expected: parameter passed to this function is not an array");
@@ -256,7 +256,7 @@ 
 	 * @param $conn
 	 * @return array
 	 */
-	public function getColumnNames($table, $dbConn = Null){
+	public function getColumnNames($table, $dbConn = Null) {
 
 		$tableFields = [];
 
@@ -275,7 +275,7 @@ 
 
 			$results = $stmt->fetchAll(PDO::FETCH_ASSOC);
 
-			foreach($results as $result) {
+			foreach ($results as $result) {
 				array_push($tableFields, $result['Field']);
 			}
 
@@ -283,7 +283,7 @@ 
 
 		} catch (PDOException $e) {
 
-			trigger_error('Could not connect to MySQL database. ' . $e->getMessage() , E_USER_ERROR);
+			trigger_error('Could not connect to MySQL database. '.$e->getMessage(), E_USER_ERROR);
 		}
 	}
 

src/Database/DatabaseHelper.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 
 namespace Laztopaz\potatoORM;
 
-use PDO;
 use Laztopaz\potatoORM\TableNotCreatedException;
 
 class DatabaseHelper {

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 			$conn = $this->dbConn;
 		}
 		$sql = 'CREATE TABLE IF NOT EXISTS '.$tableName.'(';
-		$sql.= ' id INT( 11 ) AUTO_INCREMENT PRIMARY KEY, name VARCHAR( 100 ), gender VARCHAR( 10 ), alias VARCHAR( 150 ) NOT NULL, class VARCHAR( 150 ), stack VARCHAR( 50 ) )';
+		$sql .= ' id INT( 11 ) AUTO_INCREMENT PRIMARY KEY, name VARCHAR( 100 ), gender VARCHAR( 10 ), alias VARCHAR( 150 ) NOT NULL, class VARCHAR( 150 ), stack VARCHAR( 50 ) )';
 
 		return $conn->exec($sql);