andela-jkariuki / checkpoint-four-learn-party

app/Http/Controllers/Auth/AuthController.php

Doc Comments +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
      *
      * @codeCoverageIgnore
      *
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function handleProviderCallback($provider)
     {

app/Http/Controllers/CategoryController.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace LearnParty\Http\Controllers;
 
-use Illuminate\Http\Request;
-use LearnParty\Http\Requests;
 use LearnParty\Category;
 
 class CategoryController extends Controller

app/Http/Controllers/DashboardController.php

Doc Comments +2 added lines, -2 removed lines

@@ -28,7 +28,7 @@ 
      * to
      *
      * @param  VideoRequest $request Request
-     * @return Redirect to create page
+     * @return \Illuminate\Http\RedirectResponse to create page
      */
     public function store(VideoRequest $request)
     {
@@ -65,7 +65,7 @@ 
      *
      * @param  VideoRequest $request  Validation request
      * @param  integer       $id      Video Id
-     * @return Redirect               Redirect to episode page
+     * @return \Illuminate\Http\RedirectResponse               Redirect to episode page
      */
     public function update(VideoRequest $request, $id)
     {

Spacing +3 added lines, -3 removed lines

@@ -37,7 +37,7 @@ 
         $newVideo = Auth::user()->videos()->create($request->all());
         $newVideo->categories()->sync($request->input('category_list'));
 
-        return redirect('videos/' . $newVideo->id);
+        return redirect('videos/'.$newVideo->id);
     }
 
     /**
@@ -82,7 +82,7 @@ 
         $request->session()->flash('status', 'success');
         $request->session()->flash('message', 'Video successfully updated.');
 
-        return redirect('dashboard/videos/' . $id . '/edit');
+        return redirect('dashboard/videos/'.$id.'/edit');
     }
 
     /**
@@ -116,7 +116,7 @@ 
         $videos = Video::whereIn('id', Auth::user()->favorites->lists('video_id')->toArray());
         $favorites = [];
 
-        $videos->each(function ($video, $Key) use (&$favorites) {
+        $videos->each(function($video, $Key) use (&$favorites) {
             $favorites[$video->id] = $video->favorites->count();
         });
 

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace LearnParty\Http\Controllers;
 
 use Illuminate\Http\Request;
-use LearnParty\Http\Requests;
 use LearnParty\User;
 use Auth;
 

app/Http/Controllers/FavoritesController.php

Unused Use Statements -2 removed lines

@@ -3,9 +3,7 @@
 namespace LearnParty\Http\Controllers;
 
 use Illuminate\Http\Request;
-use LearnParty\Http\Requests;
 use LearnParty\Favorite;
-use LearnParty\Video;
 use Auth;
 
 class FavoritesController extends Controller

Indentation +2 added lines, -2 removed lines

@@ -21,8 +21,8 @@
     {
         $request['user_id'] = Auth::user()->id;
         $favorite = Favorite::where('user_id', Auth::user()->id)
-                       ->where('video_id', $request->input('video_id'))
-                       ->get();
+                        ->where('video_id', $request->input('video_id'))
+                        ->get();
 
         if ($favorite->count() === 0) {
             return $this->videoRepository->favoriteVideo($request->all());

app/Http/Controllers/HomeController.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace LearnParty\Http\Controllers;
 
-use LearnParty\Http\Requests;
-use Illuminate\Http\Request;
 use LearnParty\Video;
 
 class HomeController extends Controller

app/Http/Controllers/UserController.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
      * upload an avatar to cloudinary and return url.
      *
      * @param  Request $request Request from user
-     * @return Object           redirect to profile page
+     * @return \Illuminate\Http\RedirectResponse           redirect to profile page
      */
     public function updateAvatar(Request $request)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace LearnParty\Http\Controllers;
 
 use Illuminate\Http\Request;
-use LearnParty\Http\Requests;
 use LearnParty\User;
 use Auth;
 

app/Http/Controllers/VideoController.php

Unused Use Statements -4 removed lines

@@ -2,11 +2,7 @@
 
 namespace LearnParty\Http\Controllers;
 
-use Illuminate\Http\Request;
-use LearnParty\Http\Requests;
 use LearnParty\Video;
-use LearnParty\Comment;
-use LearnParty\User;
 
 class VideoController extends Controller
 {

app/Http/Repositories/UserRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     /**
      * upload an avatar to cloudinary and return url
      *
-     * @param  Request $request Request from user
+     * @param  \Illuminate\Http\Request $request Request from user
      * @return string           Cloudinary Url
      */
     public function uploadAvatar($request)

Unused Use Statements -2 removed lines

@@ -2,9 +2,7 @@
 
 namespace LearnParty\Http\Repositories;
 
-use Illuminate\Contracts\Filesystem\Filesystem;
 use LearnParty\User;
-use Storage;
 use Auth;
 use Cloudder;
 

Indentation +3 added lines, -3 removed lines

@@ -21,7 +21,7 @@ 
     public function authenticateUser($user, $provider)
     {
         if (User::where('provider_id', $user->id)->count() === 0) {
-             $userData = [
+                $userData = [
                 'name' => $user->name,
                 'username' => $user->nickname,
                 'email' => $user->email,
@@ -29,9 +29,9 @@ 
                 'provider_id' => $user->id,
                 'provider' => $provider,
                 'about' => $provider === 'twitter' ? $user->user['description'] : '',
-             ];
+                ];
 
-             User::create($userData);
+                User::create($userData);
         }
 
         return User::where('provider_id', $user->id)->first();

app/Http/Repositories/VideoRepository.php

Doc Comments +1 added lines

@@ -13,6 +13,7 @@
     /**
      * Get a single video
      *
+     * @param integer $id
      * @return void
      */
     public function getVideo($id)

Indentation +2 added lines, -2 removed lines

@@ -100,8 +100,8 @@
     public function unfavoriteVideo($request)
     {
         Favorite::where('user_id', Auth::user()->id)
-              ->where('video_id', $request['video_id'])
-              ->delete();
+                ->where('video_id', $request['video_id'])
+                ->delete();
 
         return [
             'status' => 200,

Spacing +4 added lines, -4 removed lines

@@ -40,7 +40,7 @@ 
     public function getAllComments($videoId)
     {
         return Comment::where('video_id', $videoId)->get();
-        $comments = $comments->each(function ($comment, $key) {
+        $comments = $comments->each(function($comment, $key) {
             $comment['user'] = User::find($comment->user_id);
         });
     }
@@ -137,15 +137,15 @@ 
     {
         $topViewed = Video::orderBy('views', 'DESC')->get()->take($number);
 
-        $topFavorited = Video::all()->each(function ($video, $key) {
+        $topFavorited = Video::all()->each(function($video, $key) {
             $video->favorites = $video->favorites->count();
         })->sortByDesc('favorites')->take($number);
 
-        $topCommentedOn = Video::all()->each(function ($video, $key) {
+        $topCommentedOn = Video::all()->each(function($video, $key) {
             $video->comments = $video->comments->count();
         })->sortByDesc('comments')->take($number);
 
-        $topUsers = User::all()->each(function ($user, $key) {
+        $topUsers = User::all()->each(function($user, $key) {
             $user->videos = $user->videos->count();
         })->sortByDesc('videos')->take(5);