ToJdnConverter::set() - Code Metrics - Inspection of "lets bump down phpunit" - andegna/calender - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — develop (09cda0)

by Samson

created 2017-05-08 18:42 UTC

ToJdnConverter::set() A

↳ Parent: ToJdnConverter

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	3

<?php

namespace Andegna\Converter;

use Andegna\Exception\InvalidDateException;
use Andegna\Validator\DateValidator as DateValidator;

/**
 * ToJdnConverter
 *
 * @package Andegna\Converter
 */
class ToJdnConverter extends Converter
{

    /**
     * ToJdnConverter constructor.
     *
     * @param $day
     * @param $month
     * @param $year
     *
     * @throws \Andegna\Exception\InvalidDateException
     */
    public function __construct($day, $month, $year)
    {
        $this->set($day, $month, $year);
    }

    /**
     * @param $day
     * @param $month
     * @param $year
     *
     * @return $this
     * @throws \Andegna\Exception\InvalidDateException
     */
    public function set($day, $month, $year)
    {
        $validator = new DateValidator($day, $month, $year);

        if (!$validator->isValid()) {
            throw new InvalidDateException();
        }

        $this->day = $day;
        $this->month = $month;
        $this->year = $year;

        $this->jdn = static::process($day, $month, $year);
$answer = 42;

$correct = false;

$correct = (bool) $answer;

        return $this;
    }

    protected static function process($day, $month, $year)
    {
        return
            (1723856 + 365) +
            365 * ($year - 1) +
            (int)($year / 4) +
            30 * $month +
            $day - 31;
    }
}


1			<?php
2
3			namespace Andegna\Converter;
4
5			use Andegna\Exception\InvalidDateException;
6			use Andegna\Validator\DateValidator as DateValidator;
7
8			/**
9			* ToJdnConverter
10			*
11			* @package Andegna\Converter
12			*/
13			class ToJdnConverter extends Converter
14			{
15
16			/**
17			* ToJdnConverter constructor.
18			*
19			* @param $day
20			* @param $month
21			* @param $year
22			*
23			* @throws \Andegna\Exception\InvalidDateException
24			*/
25			public function __construct($day, $month, $year)
26			{
27			$this->set($day, $month, $year);
28			}
29
30			/**
31			* @param $day
32			* @param $month
33			* @param $year
34			*
35			* @return $this
36			* @throws \Andegna\Exception\InvalidDateException
37			*/
38			public function set($day, $month, $year)
39			{
40			$validator = new DateValidator($day, $month, $year);
41
42			if (!$validator->isValid()) {
43			throw new InvalidDateException();
44			}
45
46			$this->day = $day;
47			$this->month = $month;
48			$this->year = $year;
49
50			$this->jdn = static::process($day, $month, $year);
			0 ignored issues – show Documentation Bug introduced 2017-02-10 20:33 UTC by Report Bug Copy Issue Report The property `$jdn` was declared of type `integer`, but `static::process($day, $month, $year)` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
51
52			return $this;
53			}
54
55			protected static function process($day, $month, $year)
56			{
57			return
58			(1723856 + 365) +
59			365 * ($year - 1) +
60			(int)($year / 4) +
61			30 * $month +
62			$day - 31;
63			}
64			}
65

andegna / calender

Branch — develop (09cda0)

ToJdnConverter::set() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like