Andegna\Converter\ToJdnConverter

Complexity

Total Complexity

4

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	set()	0	16	2
A	process()	0	9	1

<?php

namespace Andegna\Converter;

use Andegna\Exception\InvalidDateException;
use Andegna\Validator\DateValidator as DateValidator;

/**
 * ToJdnConverter
 *
 * @package Andegna\Converter
 */
class ToJdnConverter extends Converter
{

    /**
     * ToJdnConverter constructor.
     *
     * @param $day
     * @param $month
     * @param $year
     *
     * @throws \Andegna\Exception\InvalidDateException
     */
    public function __construct($day, $month, $year)
    {
        $this->set($day, $month, $year);
    }

    /**
     * @param $day
     * @param $month
     * @param $year
     *
     * @return $this
     * @throws \Andegna\Exception\InvalidDateException
     */
    public function set($day, $month, $year)
    {
        $validator = new DateValidator($day, $month, $year);

        if (!$validator->isValid()) {
            throw new InvalidDateException();
        }

        $this->day = $day;
        $this->month = $month;
        $this->year = $year;

        $this->jdn = static::process($day, $month, $year);

The property $jdn was declared of type integer, but static::process($day, $month, $year) is of type double. Maybe add a type cast?

        return $this;
    }

    protected static function process($day, $month, $year)
    {
        return
            (1723856 + 365) +
            365 * ($year - 1) +
            (int)($year / 4) +
            30 * $month +
            $day - 31;
    }
}