anavel / crud

src/Abstractor/Eloquent/Field.php

Doc Comments +4 added lines, -1 removed lines

@@ -123,7 +123,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getValue()
     {
@@ -162,6 +162,7 @@ 
 
     /**
      *
+     * @param boolean $value
      */
     public function hideValue($value = null)
     {
@@ -174,6 +175,7 @@ 
 
     /**
      *
+     * @param boolean $value
      */
     public function saveIfEmpty($value = null)
     {
@@ -186,6 +188,7 @@ 
 
     /**
      *
+     * @param boolean $value
      */
     public function noValidate($value = null)
     {

Spacing +8 added lines, -8 removed lines

@@ -55,7 +55,7 @@ 
 
     public function presentation()
     {
-        return transcrud($this->presentation) ? : ucfirst(str_replace('_', ' ', transcrud($this->name)));
+        return transcrud($this->presentation) ?: ucfirst(str_replace('_', ' ', transcrud($this->name)));
     }
 
     public function type()
@@ -89,7 +89,7 @@ 
 
     public function setFunctions($functions)
     {
-        if (! is_array($functions)) {
+        if (!is_array($functions)) {
             $functions = array($functions);
         }
 
@@ -99,7 +99,7 @@ 
     public function applyFunctions($value)
     {
         foreach ($this->functions as $function) {
-            if (! function_exists($function)) {
+            if (!function_exists($function)) {
                 throw new \Exception("Function ".$function." does not exist");
             }
 
@@ -117,7 +117,7 @@ 
     {
         $this->value = $value;
 
-        if (! $this->hideValue()) {
+        if (!$this->hideValue()) {
             $this->formField->val($this->value);
         }
     }
@@ -151,7 +151,7 @@ 
 
     public function getFormField()
     {
-        if (! $this->hideValue()) {
+        if (!$this->hideValue()) {
             if (Request::old($this->name)) {
                 $this->formField->val(Request::old($this->name));
             }
@@ -165,7 +165,7 @@ 
      */
     public function hideValue($value = null)
     {
-        if (! is_null($value)) {
+        if (!is_null($value)) {
             $this->hideValue = $value;
         }
 
@@ -177,7 +177,7 @@ 
      */
     public function saveIfEmpty($value = null)
     {
-        if (! is_null($value)) {
+        if (!is_null($value)) {
             $this->saveIfEmpty = $value;
         }
 
@@ -189,7 +189,7 @@ 
      */
     public function noValidate($value = null)
     {
-        if (! is_null($value)) {
+        if (!is_null($value)) {
             $this->noValidate = $value;
         }
 

src/Abstractor/Eloquent/Model.php

Doc Comments +6 added lines

@@ -76,6 +76,9 @@ 
         return transcrud($this->name);
     }
 
+    /**
+     * @return string
+     */
     public function getModel()
     {
         return $this->model;
@@ -91,6 +94,9 @@ 
         return $this->getConfigValue('soft_deletes') ? true : false;
     }
 
+    /**
+     * @param string $action
+     */
     protected function getColumns($action, $withForeignKeys = false)
     {
         $tableColumns = $this->dbal->getTableColumns();

Spacing +19 added lines, -19 removed lines

@@ -114,12 +114,12 @@ 
         }
 
         $customDisplayedColumns = $this->getConfigValue($action, 'display');
-        $customHiddenColumns = $this->getConfigValue($action, 'hide') ? : [];
+        $customHiddenColumns = $this->getConfigValue($action, 'hide') ?: [];
 
         $columns = array();
-        if (! empty($customDisplayedColumns) && is_array($customDisplayedColumns)) {
+        if (!empty($customDisplayedColumns) && is_array($customDisplayedColumns)) {
             foreach ($customDisplayedColumns as $customColumn) {
-                if (! array_key_exists($customColumn, $tableColumns)) {
+                if (!array_key_exists($customColumn, $tableColumns)) {
                     throw new AbstractorException("Column ".$customColumn." does not exist on ".$this->getModel());
                 }
 
@@ -144,11 +144,11 @@ 
 
     public function getRelations()
     {
-        $configRelations =  $this->getConfigValue('relations');
+        $configRelations = $this->getConfigValue('relations');
 
         $relations = [];
 
-        if (! empty($configRelations)) {
+        if (!empty($configRelations)) {
             foreach ($configRelations as $relationName => $configRelation) {
                 if (is_int($relationName)) {
                     $relationName = $configRelation;
@@ -156,7 +156,7 @@ 
 
                 $config = [];
                 if ($configRelation !== $relationName) {
-                    if (! is_array($configRelation)) {
+                    if (!is_array($configRelation)) {
                         $config['type'] = $configRelation;
                     } else {
                         $config = $configRelation;
@@ -176,7 +176,7 @@ 
     {
         $columns = $this->getColumns('list');
 
-        $fieldsPresentation = $this->getConfigValue('fields_presentation') ? : [];
+        $fieldsPresentation = $this->getConfigValue('fields_presentation') ?: [];
 
         $fields = array();
         foreach ($columns as $name => $column) {
@@ -206,7 +206,7 @@ 
     {
         $columns = $this->getColumns('detail');
 
-        $fieldsPresentation = $this->getConfigValue('fields_presentation') ? : [];
+        $fieldsPresentation = $this->getConfigValue('fields_presentation') ?: [];
 
         $fields = array();
         foreach ($columns as $name => $column) {
@@ -236,15 +236,15 @@ 
     {
         $columns = $this->getColumns('edit', $withForeignKeys);
 
-        $fieldsPresentation = $this->getConfigValue('fields_presentation') ? : [];
-        $formTypes = $this->getConfigValue('edit', 'form_types') ? : [];
-        $validationRules = $this->getConfigValue('edit', 'validation') ? : [];
-        $functions = $this->getConfigValue('edit', 'functions') ? : [];
-        $defaults = $this->getConfigValue('edit', 'defaults') ? : [];
+        $fieldsPresentation = $this->getConfigValue('fields_presentation') ?: [];
+        $formTypes = $this->getConfigValue('edit', 'form_types') ?: [];
+        $validationRules = $this->getConfigValue('edit', 'validation') ?: [];
+        $functions = $this->getConfigValue('edit', 'functions') ?: [];
+        $defaults = $this->getConfigValue('edit', 'defaults') ?: [];
 
         $fields = array();
         foreach ($columns as $name => $column) {
-            if (! in_array($name, $this->getReadOnlyColumns())) {
+            if (!in_array($name, $this->getReadOnlyColumns())) {
                 $presentation = null;
                 if (array_key_exists($name, $fieldsPresentation)) {
                     $presentation = $fieldsPresentation[$name];
@@ -279,7 +279,7 @@ 
                     ->setConfig($config)
                     ->get();
 
-                if (! empty($this->instance) && ! empty($this->instance->getAttribute($name))) {
+                if (!empty($this->instance) && !empty($this->instance->getAttribute($name))) {
                     $field->setValue($this->instance->getAttribute($name));
                 }
 
@@ -319,14 +319,14 @@ 
     {
         /** @var \ANavallaSuiza\Laravel\Database\Contracts\Manager\ModelManager $modelManager */
         $modelManager = App::make('ANavallaSuiza\Laravel\Database\Contracts\Manager\ModelManager');
-        if (! empty($this->instance)) {
+        if (!empty($this->instance)) {
             $item = $this->instance;
         } else {
             $item = $modelManager->getModelInstance($this->getModel());
         }
 
         foreach ($this->getEditFields(true) as $field) {
-            if (! $field->saveIfEmpty() && empty($request->input($field->getName()))) {
+            if (!$field->saveIfEmpty() && empty($request->input($field->getName()))) {
                 continue;
             }
 
@@ -346,7 +346,7 @@ 
                 }
             }
 
-            if (! empty($requestValue)) {
+            if (!empty($requestValue)) {
                 $item->setAttribute(
                     $field->getName(),
                     $field->applyFunctions($requestValue)
@@ -358,7 +358,7 @@ 
 
         $this->setInstance($item);
 
-        if (! empty($relations = $this->getRelations())) {
+        if (!empty($relations = $this->getRelations())) {
             foreach ($relations as $relation) {
                 $relation->persist($request);
             }

src/Abstractor/Eloquent/ModelFactory.php

Doc Comments +2 added lines, -2 removed lines

@@ -38,9 +38,9 @@
     }
 
     /**
-     * @param $slug
+     * @param string $slug
      * @param null $id
-     * @return Model|null
+     * @return Model
      * @throws \Exception
      */
     public function getBySlug($slug, $id = null)

src/Abstractor/Eloquent/Relation/MiniCrud.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Anavel\Crud\Abstractor\Eloquent\Relation\Traits\CheckRelationCompatibility;
 use Anavel\Crud\Contracts\Abstractor\Field;
-use App;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Http\Request;
 use Illuminate\Support\Collection;

Spacing +6 added lines, -6 removed lines

@@ -37,7 +37,7 @@ 
         $results = $this->eloquentRelation->getResults();
 
         $results->put('emptyResult', '');
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             $readOnly = [Model::CREATED_AT, Model::UPDATED_AT];
             foreach ($results as $key => $result) {
                 foreach ($columns as $columnName => $column) {
@@ -56,8 +56,8 @@ 
                     }
 
                     $config = [
-                        'name'         => $this->name . '[' . $index . '][' . $columnName . ']',
-                        'presentation' => $this->name . ' ' . ucfirst(transcrud($columnName)) . ' [' . $index . ']',
+                        'name'         => $this->name.'['.$index.']['.$columnName.']',
+                        'presentation' => $this->name.' '.ucfirst(transcrud($columnName)).' ['.$index.']',
                         'form_type'    => $formType,
                         'no_validate'  => true,
                         'validation'   => null,
@@ -91,10 +91,10 @@ 
      */
     public function persist(Request $request)
     {
-        if (! empty($relationArray = $request->input($this->name))) {
+        if (!empty($relationArray = $request->input($this->name))) {
             $currentRelations = $this->eloquentRelation->get()->keyBy($this->eloquentRelation->getParent()->getKeyName());
             foreach ($relationArray as $relation) {
-                if (! empty($relation[$this->eloquentRelation->getParent()->getKeyName()])
+                if (!empty($relation[$this->eloquentRelation->getParent()->getKeyName()])
                     && ($currentRelations->has($relation[$this->eloquentRelation->getParent()->getKeyName()]))
                 ) {
                     $relationModel = $currentRelations->get($relation[$this->eloquentRelation->getParent()->getKeyName()]);
@@ -112,7 +112,7 @@ 
                     $relationModel->setAttribute($fieldKey, $fieldValue);
                 }
 
-                if (! $shouldBeSkipped) {
+                if (!$shouldBeSkipped) {
                     $relationModel->save();
                 }
             }

src/Abstractor/Eloquent/Relation/MiniCrudSingle.php

Unused Use Statements -2 removed lines

@@ -3,10 +3,8 @@
 
 use Anavel\Crud\Abstractor\Eloquent\Relation\Traits\CheckRelationCompatibility;
 use Anavel\Crud\Contracts\Abstractor\Field;
-use App;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Http\Request;
-use Illuminate\Support\Collection;
 
 class MiniCrudSingle extends Relation
 {

Spacing +7 added lines, -7 removed lines

@@ -45,7 +45,7 @@ 
         ];
 
 
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnName => $column) {
                 if (in_array($columnName, $readOnly, true)) {
                     continue;
@@ -54,8 +54,8 @@ 
                 $formType = null;
 
                 $config = [
-                    'name'         => $this->name . '[' . $columnName . ']',
-                    'presentation' => $this->name . ' ' . ucfirst(transcrud($columnName)),
+                    'name'         => $this->name.'['.$columnName.']',
+                    'presentation' => $this->name.' '.ucfirst(transcrud($columnName)),
                     'form_type'    => $formType,
                     'no_validate'  => true,
                     'validation'   => null,
@@ -68,7 +68,7 @@ 
                     ->setConfig($config)
                     ->get();
 
-                if (! empty($result->id)) {
+                if (!empty($result->id)) {
                     $field->setValue($result->getAttribute($columnName));
                 }
 
@@ -88,9 +88,9 @@ 
      */
     public function persist(Request $request)
     {
-        if (! empty($relation = $request->input($this->name))) {
+        if (!empty($relation = $request->input($this->name))) {
             $currentRelation = $this->eloquentRelation->getResults();
-            if (! empty($currentRelation)) {
+            if (!empty($currentRelation)) {
                 $relationModel = $currentRelation;
             } else {
                 $relationModel = $this->eloquentRelation->getRelated()->newInstance();
@@ -106,7 +106,7 @@ 
                 $relationModel->setAttribute($fieldKey, $fieldValue);
             }
 
-            if (! $shouldBeSkipped) {
+            if (!$shouldBeSkipped) {
                 $relationModel->save();
             }
         }

src/Abstractor/Eloquent/Relation/SelectMultiple.php

Unused Use Statements -2 removed lines

@@ -2,9 +2,7 @@
 namespace Anavel\Crud\Abstractor\Eloquent\Relation;
 
 use Anavel\Crud\Abstractor\Eloquent\Relation\Traits\CheckRelationCompatibility;
-use Anavel\Crud\Abstractor\Eloquent\Relation\Traits\CheckRelationConfig;
 use Anavel\Crud\Repository\Criteria\InArrayCriteria;
-use App;
 use Doctrine\DBAL\Schema\Column;
 use Illuminate\Http\Request;
 

Spacing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
      */
     public function persist(Request $request)
     {
-        if (! empty($selectArray = $request->input($this->name))) {
+        if (!empty($selectArray = $request->input($this->name))) {
             /** @var \ANavallaSuiza\Laravel\Database\Contracts\Repository\Repository $repo */
             $repo = $this->modelManager->getRepository(get_class($this->eloquentRelation->getRelated()));
 
@@ -49,7 +49,7 @@ 
                 $result->save();
             }
 
-            if (! $missing->isEmpty()) {
+            if (!$missing->isEmpty()) {
                 foreach ($missing as $result) {
                     $result->$keyName = null;
                     $result->save();
@@ -82,7 +82,7 @@ 
     {
         $results = $this->eloquentRelation->getResults();
 
-        if (! $results->isEmpty()) {
+        if (!$results->isEmpty()) {
             $values = [];
 
             foreach ($results as $result) {

src/Abstractor/Eloquent/Relation/Translation.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Anavel\Crud\Abstractor\Eloquent\Relation\Traits\CheckRelationCompatibility;
 use Anavel\Crud\Contracts\Abstractor\Field;
-use App;
 use Illuminate\Http\Request;
 
 class Translation extends Relation

Spacing +3 added lines, -3 removed lines

@@ -39,7 +39,7 @@ 
         $results = $results->keyBy('locale');
 
         $translationFields = [];
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($this->langs as $key => $lang) {
                 foreach ($columns as $columnName => $column) {
                     if ($columnName === $this->eloquentRelation->getPlainForeignKey()) {
@@ -58,7 +58,7 @@ 
 
                     $config = [
                         'name' => $this->name.'['.$key.']['.$columnName.']',
-                        'presentation' => ucfirst(transcrud($columnName)).' ['.$lang .']',
+                        'presentation' => ucfirst(transcrud($columnName)).' ['.$lang.']',
                         'form_type' => $formType,
                         'no_validate' => true,
                         'validation' => null,
@@ -94,7 +94,7 @@ 
      */
     public function persist(Request $request)
     {
-        if (! empty($translationsArray = $request->input($this->name))) {
+        if (!empty($translationsArray = $request->input($this->name))) {
             $currentTranslations = $this->eloquentRelation->get();
             $currentTranslations = $currentTranslations->keyBy('locale');
 

src/Http/Controllers/ModelController.php

Doc Comments +3 added lines, -3 removed lines

@@ -80,7 +80,7 @@ 
      *
      * @param Request $request
      * @param  string  $model
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function store(Request $request, $model)
     {
@@ -148,7 +148,7 @@ 
      * @param Request $request
      * @param  string  $model
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function update(Request $request, $model, $id)
     {
@@ -177,7 +177,7 @@ 
      * @param Request $request
      * @param  string  $model
      * @param  int  $id
-     * @return Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function destroy(Request $request, $model, $id)
     {

src/Abstractor/ConfigurationReader.php

Spacing +2 added lines, -2 removed lines

@@ -5,7 +5,7 @@ 
 {
     public function getConfigValue()
     {
-        if (! property_exists($this, 'config') || ! is_array($this->config) || empty($this->config)) {
+        if (!property_exists($this, 'config') || !is_array($this->config) || empty($this->config)) {
             return null;
         }
 
@@ -17,7 +17,7 @@ 
 
         if (is_array($params) && count($params) > 0) {
             foreach ($params as $configKey) {
-                if (! array_key_exists($configKey, $nestedConfig)) {
+                if (!array_key_exists($configKey, $nestedConfig)) {
                     $nestedConfig = array();
                     return null;
                 }