Completed
Push — master ( ead358...de8c68 )
by Askupa
01:58
created
Form.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      * Get a component by its name.
138 138
      * 
139 139
      * @param string $name
140
-     * @return UI\AbstractComponent
140
+     * @return AbstractComponent
141 141
      */
142 142
     public function get_component( $name )
143 143
     {
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     /**
148 148
      * Get all components.
149 149
      * 
150
-     * @return array
150
+     * @return AbstractComponent[]
151 151
      */
152 152
     public function get_components()
153 153
     {
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
     /**
182 182
      * Check if the given component is disabled.
183 183
      * 
184
-     * @param UI\AbstractComponent $component
184
+     * @param ValueComponentInterface $component
185 185
      * @return boolean
186 186
      */
187 187
     private function is_disabled( $component )
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     /**
198 198
      * Filter the component's value using its filter function (if applicable)
199 199
      * 
200
-     * @param UI\AbstractComponent $component
200
+     * @param ValueComponentInterface $component
201 201
      */
202 202
     private function filter( $component )
203 203
     {
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
      * If the value is invalid, the old value is used, and an error message is
220 220
      * saved into the errors array as component_name => error_message.
221 221
      * 
222
-     * @param UI\AbstractComponent $component The component to validate.
222
+     * @param ValueComponentInterface $component The component to validate.
223 223
      */
224 224
     private function validate( $component )
225 225
     {
Please login to merge, or discard this patch.
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -59,12 +59,12 @@  discard block
 block discarded – undo
59 59
      * 
60 60
      * @param array $components An array of arrays of component arguments
61 61
      */
62
-    public function __construct( array $components = array() )
62
+    public function __construct(array $components = array())
63 63
     {
64
-        foreach( $components as $args )
64
+        foreach ($components as $args)
65 65
         {
66 66
             $name = $args['name'];
67
-            if(array_key_exists($name, $components))
67
+            if (array_key_exists($name, $components))
68 68
             {
69 69
                 throw new \RuntimeException("A component with the name <b>$name</b> has already been created");
70 70
             }
@@ -89,18 +89,18 @@  discard block
 block discarded – undo
89 89
      * 
90 90
      * @return array The updated values array.
91 91
      */
92
-    public function update( array $new_instance, array $old_instance = array() )
92
+    public function update(array $new_instance, array $old_instance = array())
93 93
     {
94
-        $this->old_instance   = array_merge($this->get_defaults(),$old_instance);
95
-        $this->new_instance   = array_merge($this->old_instance,$new_instance);
94
+        $this->old_instance   = array_merge($this->get_defaults(), $old_instance);
95
+        $this->new_instance   = array_merge($this->old_instance, $new_instance);
96 96
         $this->final_instance = $this->new_instance;
97 97
         
98
-        foreach ( $this->components as $component ) 
98
+        foreach ($this->components as $component) 
99 99
         {
100 100
             // Update individual fields, as well as the composite parent field.
101
-            if ( $component instanceof ValueComponentInterface )
101
+            if ($component instanceof ValueComponentInterface)
102 102
             {
103
-                $this->update_component( $component );
103
+                $this->update_component($component);
104 104
             }
105 105
         }
106 106
         
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function reset()
116 116
     {
117
-        foreach( $this->components as $c )
117
+        foreach ($this->components as $c)
118 118
         {
119 119
             $c->value = $c->default;
120 120
             $this->final_instance[$c->name] = $c->default;
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
      * @param string $name
140 140
      * @return UI\AbstractComponent
141 141
      */
142
-    public function get_component( $name )
142
+    public function get_component($name)
143 143
     {
144 144
         return $this->components[$name];
145 145
     }
@@ -161,21 +161,21 @@  discard block
 block discarded – undo
161 161
      * 
162 162
      * @param ValueComponentInterface $component The component to validate.
163 163
      */
164
-    private function update_component( ValueComponentInterface $component )
164
+    private function update_component(ValueComponentInterface $component)
165 165
     {
166 166
         $component->value = $this->final_instance[$component->name];
167 167
         
168 168
         // Skip if this field is disabled
169
-        if( $this->is_disabled($component) )
169
+        if ($this->is_disabled($component))
170 170
         {
171 171
             return;
172 172
         }
173 173
         
174 174
         // Apply user-defined filter
175
-        $this->filter( $component );
175
+        $this->filter($component);
176 176
         
177 177
         // Validate value
178
-        $this->validate( $component );
178
+        $this->validate($component);
179 179
     }
180 180
     
181 181
     /**
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
      * @param UI\AbstractComponent $component
185 185
      * @return boolean
186 186
      */
187
-    private function is_disabled( $component )
187
+    private function is_disabled($component)
188 188
     {
189 189
         return 
190 190
             $component instanceof DisableableComponentInterface &&
@@ -199,13 +199,13 @@  discard block
 block discarded – undo
199 199
      * 
200 200
      * @param UI\AbstractComponent $component
201 201
      */
202
-    private function filter( $component )
202
+    private function filter($component)
203 203
     {
204
-        if( $component instanceof FilterableComponentInterface )
204
+        if ($component instanceof FilterableComponentInterface)
205 205
         {
206 206
             $filter = $component->filter;
207 207
 
208
-            if( is_callable( $filter ) ) 
208
+            if (is_callable($filter)) 
209 209
             {
210 210
                 $component->value = \call_user_func_array($filter, array($this->final_instance[$component->name]));
211 211
                 $this->final_instance[$component->name] = $component->value;
@@ -221,22 +221,22 @@  discard block
 block discarded – undo
221 221
      * 
222 222
      * @param UI\AbstractComponent $component The component to validate.
223 223
      */
224
-    private function validate( $component )
224
+    private function validate($component)
225 225
     {
226
-        if( !($component instanceof ValidatableComponentInterface) ) return;
226
+        if (!($component instanceof ValidatableComponentInterface)) return;
227 227
         
228 228
         $name     = $component->name;
229 229
         $validate = $component->validation;
230 230
         
231 231
         $component->validity = $component::VALID;
232 232
         
233
-        if(is_callable($validate))
233
+        if (is_callable($validate))
234 234
         {
235 235
             $error = '';
236 236
             $valid = \call_user_func_array($validate, array($this->final_instance[$name], &$error));
237 237
             
238 238
             // Invalid input, use old instance or default value
239
-            if ( true !== $valid ) 
239
+            if (true !== $valid) 
240 240
             {
241 241
                 $this->errors[$name]         = $error;
242 242
                 $component->value            = $this->old_instance[$name];
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         $defaults = array();
257 257
         
258
-        foreach( $this->components as $component )
258
+        foreach ($this->components as $component)
259 259
         {
260 260
             $defaults[$component->name] = $component->default;
261 261
         }
Please login to merge, or discard this patch.
components/textarea/controller.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -8,9 +8,9 @@
 block discarded – undo
8 8
 class Component_textarea
9 9
 extends AbstractComponent
10 10
 implements ValueComponentInterface, 
11
-           DisableableComponentInterface,
12
-           FilterableComponentInterface,
13
-           ValidatableComponentInterface
11
+            DisableableComponentInterface,
12
+            FilterableComponentInterface,
13
+            ValidatableComponentInterface
14 14
 {
15 15
     public function default_model() 
16 16
     {
Please login to merge, or discard this patch.
components/radio/controller.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 class Component_radio
9 9
 extends AbstractComponent
10 10
 implements ValueComponentInterface, 
11
-           DisableableComponentInterface
11
+            DisableableComponentInterface
12 12
 {
13 13
     public function default_model() 
14 14
     {
Please login to merge, or discard this patch.
components/select/controller.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 class Component_select
9 9
 extends AbstractComponent
10 10
 implements ValueComponentInterface, 
11
-           DisableableComponentInterface
11
+            DisableableComponentInterface
12 12
 {
13 13
     public function default_model() 
14 14
     {
Please login to merge, or discard this patch.
components/number/controller.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -8,9 +8,9 @@
 block discarded – undo
8 8
 class Component_number
9 9
 extends AbstractComponent
10 10
 implements ValueComponentInterface, 
11
-           DisableableComponentInterface,
12
-           FilterableComponentInterface,
13
-           ValidatableComponentInterface
11
+            DisableableComponentInterface,
12
+            FilterableComponentInterface,
13
+            ValidatableComponentInterface
14 14
 {
15 15
     public function default_model() 
16 16
     {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
25 25
             'required'      => false,
26 26
             'readonly'      => false,
27 27
             'default'       => null,
28
-            'filter'        => array( $this, 'filter' ),
29
-            'validation'    => array( $this, 'validation' )
28
+            'filter'        => array($this, 'filter'),
29
+            'validation'    => array($this, 'validation')
30 30
         );
31 31
     }
32 32
     
@@ -35,15 +35,15 @@  discard block
 block discarded – undo
35 35
         return floatval($v);
36 36
     }
37 37
     
38
-    public function validation($v,&$e)
38
+    public function validation($v, &$e)
39 39
     {
40
-        if(null !== $this->max && $v > $this->max) 
40
+        if (null !== $this->max && $v > $this->max) 
41 41
         {
42 42
             $e = "must be less than {$this->max}";
43 43
             return false;
44 44
         }
45 45
 
46
-        if(null !== $this->min && $v < $this->min) 
46
+        if (null !== $this->min && $v < $this->min) 
47 47
         {
48 48
             $e = "must be greater than {$this->min}";
49 49
             return false;
Please login to merge, or discard this patch.
components/checkbox/controller.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 class Component_checkbox
9 9
 extends AbstractComponent
10 10
 implements ValueComponentInterface, 
11
-           DisableableComponentInterface
11
+            DisableableComponentInterface
12 12
 {
13 13
     public function default_model() 
14 14
     {
Please login to merge, or discard this patch.
Template.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
25 25
      * @param array $model
26 26
      * @param string $template_path
27 27
      */
28
-    public function __construct( array $model = array(), $template_path = null ) 
28
+    public function __construct(array $model = array(), $template_path = null) 
29 29
     {
30
-        $this->set_model( $model );
30
+        $this->set_model($model);
31 31
         $this->template = $template_path;
32 32
     }
33 33
     
@@ -38,9 +38,9 @@  discard block
 block discarded – undo
38 38
      * 
39 39
      * @return mixed the argument's value.
40 40
      */
41
-    public function __get( $name ) 
41
+    public function __get($name) 
42 42
     {
43
-        if( isset( $this->model[$name] ) )
43
+        if (isset($this->model[$name]))
44 44
         {
45 45
             return $this->model[$name];
46 46
         }
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      * 
55 55
      * @return mixed the settings' argument value.
56 56
      */
57
-    public function __set( $name, $value )
57
+    public function __set($name, $value)
58 58
     {
59 59
         $this->model[$name] = $value;
60 60
     }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      * 
75 75
      * @return array
76 76
      */
77
-    public function set_model( $model )
77
+    public function set_model($model)
78 78
     {
79 79
         $this->model = $model;
80 80
     }
@@ -95,22 +95,22 @@  discard block
 block discarded – undo
95 95
      * @return string The rendered template.
96 96
      * @throws TemplateNotFoundException Thrown if the template file cannot be found.
97 97
      */
98
-    public function render( $echo = false )
98
+    public function render($echo = false)
99 99
     {
100 100
         $rendered_html = '';
101 101
         
102
-        if( file_exists( $this->get_template_path() ) ) 
102
+        if (file_exists($this->get_template_path())) 
103 103
         {
104 104
             ob_start();
105
-            include( $this->get_template_path() );
105
+            include($this->get_template_path());
106 106
             $rendered_html = ob_get_clean();
107 107
         } 
108 108
         else 
109 109
         {
110
-            throw new \RuntimeException( "Error: cannot render HTML, template file not found at " . $this->get_template_path() );
110
+            throw new \RuntimeException("Error: cannot render HTML, template file not found at ".$this->get_template_path());
111 111
         }
112 112
         
113
-        if( !$echo )
113
+        if (!$echo)
114 114
         {
115 115
             return $rendered_html;
116 116
         }
Please login to merge, or discard this patch.