alpixel / AlpixelMenuBundle

Tests/app/AppKernel.php

Spacing +1 added lines, -1 removed lines

@@ -19,6 +19,6 @@
 
     public function registerContainerConfiguration(LoaderInterface $loader)
     {
-        $loader->load(__DIR__.'/../config/config.yml');
+        $loader->load(__DIR__ . '/../config/config.yml');
     }
 }

Tests/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 $_SERVER['env'] = 'test';
 use Doctrine\Common\Annotations\AnnotationRegistry;
-if (!is_file($loaderFile = __DIR__.'/../vendor/autoload.php')) {
+if (!is_file($loaderFile = __DIR__ . '/../vendor/autoload.php')) {
     throw new \LogicException('Could not find autoload.php in vendor/. Did you run "composer install --dev"?');
 }
 $loader = require $loaderFile;

Builder/MenuBuilder.php

Doc Comments +3 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
      * The parameter $locale must be defined in your
      * symfony configuration file under parameters.
      *
-     * @param $locale String
+     * @param string $locale String
      * @return $this
      */
     public function setDefaultLocale($locale)
@@ -78,7 +78,7 @@ 
     /**
      * Check if the machineName is valid
      *
-     * @param $machineName
+     * @param string $machineName
      * @return bool
      */
     public static function isValidMachineName($machineName)
@@ -93,7 +93,7 @@ 
     /**
      * Retrun null or a KnpMenuItem instance
      *
-     * @return null|KnpMenuItem
+     * @return KnpMenuItem
      */
     public function getKnpMenu()
     {

Indentation +4 added lines, -4 removed lines

@@ -146,8 +146,8 @@ 
         $this->setKnpMenu($this->factory->createItem('root'));
 
         $menu = $this->entityManager
-                     ->getRepository('AlpixelMenuBundle:Menu')
-                     ->findOneMenuByMachineNameAndLocale($machineName, $locale);
+                        ->getRepository('AlpixelMenuBundle:Menu')
+                        ->findOneMenuByMachineNameAndLocale($machineName, $locale);
 
         $items = $menu->getItems()->toArray();
 
@@ -176,8 +176,8 @@ 
         if (($uri = $item->getUri()) !== null) {
             if($uri[0] == '/') {
                 $baseUri = $this->request->getBasePath().
-                           $this->request->getBaseURL().
-                           $uri;
+                            $this->request->getBaseURL().
+                            $uri;
                 $uri = $this->request->getSchemeAndHttpHost().$baseUri;
 
                 if ($baseUri === $this->currentUri) {

Spacing +4 added lines, -4 removed lines

@@ -174,11 +174,11 @@
         $menuItem = ($parent === null) ? $knpMenu->addChild($item) : $parent->addChild($item);
 
         if (($uri = $item->getUri()) !== null) {
-            if($uri[0] == '/') {
-                $baseUri = $this->request->getBasePath().
-                           $this->request->getBaseURL().
+            if ($uri[0] == '/') {
+                $baseUri = $this->request->getBasePath() .
+                           $this->request->getBaseURL() .
                            $uri;
-                $uri = $this->request->getSchemeAndHttpHost().$baseUri;
+                $uri = $this->request->getSchemeAndHttpHost() . $baseUri;
 
                 if ($baseUri === $this->currentUri) {
                     $menuItem->setCurrent(true);

Entity/Item.php

Doc Comments +2 added lines, -3 removed lines

@@ -115,7 +115,7 @@ 
     /**
      * Get parent Item
      *
-     * @return null\Item
+     * @return null|ItemInterface
      */
     public function getParent()
     {
@@ -125,7 +125,6 @@ 
     /**
      * Set parent Item
      *
-     * @param ItemInterface $menu
      *
      * @return self
      */
@@ -209,6 +208,7 @@ 
      * Set name displayed in Item
      *
      * @param string
+     * @param string $name
      *
      * @return self
      */
@@ -232,7 +232,6 @@ 
     /**
      * Set URL
      *
-     * @param string $url
      *
      * @return self
      */

Tests/Builder/MenuBuilderTest.php

Spacing +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
     {
         $item = new Item();
         $item->setMenu($menu);
-        $item->setName('Item '.$i);
+        $item->setName('Item ' . $i);
         $item->setPosition($i);
         $item->setUri('http://alpixel.fr');
 

Doc Comments +6 added lines

@@ -74,6 +74,9 @@ 
         $this->assertInstanceOf(MenuItem::class, $knpMenu);
     }
 
+    /**
+     * @param string $locale
+     */
     public function getMenuContext($locale)
     {
         $menuData = $this->getMenuData()[$locale];
@@ -103,6 +106,9 @@ 
         return $menu;
     }
 
+    /**
+     * @param integer $i
+     */
     public function newItem(Menu $menu, $i, Item $parentItem = null)
     {
         $item = new Item();

DependencyInjection/AlpixelMenuExtension.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
         $configuration = new Configuration();
         $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.yml');
 
         $menuBuilder = $container->getDefinition('alpixel_menu.builder');

Entity/Menu.php

Doc Comments +8 added lines, -5 removed lines

@@ -87,6 +87,7 @@ 
      * Set the machineName the key for querying a menu.
      *
      * @param string
+     * @param string $machineName
      *
      * @return self
      */
@@ -100,7 +101,7 @@ 
     /**
      * Get the name the value displayed to the administrator.
      *
-     * @return self
+     * @return string
      */
     public function getName()
     {
@@ -110,6 +111,7 @@ 
     /**
      * Set the name the value displayed to the administrator.
      *
+     * @param string $name
      * @return self
      */
     public function setName($name)
@@ -167,9 +169,9 @@ 
     /**
      * Set items for the menu.
      * @deprecated
-     * @param null\ItemInterface $item
+     * @param ItemInterface $item
      *
-     * @return Item
+     * @return Menu
      */
     public function setItem(ItemInterface $item)
     {
@@ -179,9 +181,9 @@ 
     /**
      * Set items for the menu.
      *
-     * @param null\ItemInterface $item
+     * @param ItemInterface $item
      *
-     * @return Item
+     * @return Menu
      */
     public function addItem(ItemInterface $item)
     {
@@ -204,6 +206,7 @@ 
     /**
      * Set the locale language.
      *
+     * @param string $locale
      * @return self
      */
     public function setLocale($locale)

Controller/Admin/CRUD/MenuAdmin.php

Spacing +2 added lines, -2 removed lines

@@ -12,7 +12,7 @@ 
     public function createQuery($context = 'list')
     {
         $query = parent::createQuery($context);
-        $query->addOrderBy($query->getRootAlias().'.locale', 'ASC');
+        $query->addOrderBy($query->getRootAlias() . '.locale', 'ASC');
 
         return $query;
     }
@@ -20,7 +20,7 @@ 
     protected function configureRoutes(RouteCollection $collection)
     {
         $collection->clearExcept(['list']);
-        $collection->add('item', $this->getRouterIdParameter().'/item');
+        $collection->add('item', $this->getRouterIdParameter() . '/item');
     }
 
     protected function configureFormFields(FormMapper $formMapper)

Controller/Admin/CRUD/ItemAdmin.php

Spacing +3 added lines, -3 removed lines

@@ -25,7 +25,7 @@ 
 
     protected function configureRoutes(RouteCollection $collection)
     {
-        $collection->add('move', $this->getRouterIdParameter().'/move/{position}');
+        $collection->add('move', $this->getRouterIdParameter() . '/move/{position}');
     }
 
     public function getPersistentParameters()
@@ -43,7 +43,7 @@ 
     {
         $id = $this->getRequest()->query->getInt('menu');
         $query = parent::createQuery($context);
-        $query->join($query->getRootAlias().'.menu', 'm')
+        $query->join($query->getRootAlias() . '.menu', 'm')
             ->where('m.id = :id')
             ->setParameters([
                 'id' => $id,
@@ -55,7 +55,7 @@ 
     protected function configureFormFields(FormMapper $formMapper)
     {
         $id = $this->getRequest()->query->getInt('menu');
-        $isNew  = ($this->id($this->getSubject()) === null) ? false : true;
+        $isNew = ($this->id($this->getSubject()) === null) ? false : true;
 
         if ($isNew === false) {
             $formMapper