Completed
Pull Request — master (#7)
by
unknown
03:43
created
src/PulseColumn.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -69,6 +69,9 @@
 block discarded – undo
69 69
         $this->deletedObject = true;
70 70
     }
71 71
 
72
+    /**
73
+     * @param string $field
74
+     */
72 75
     private function editField ($field, $value)
73 76
     {
74 77
         $this->checkInvalid();
Please login to merge, or discard this patch.
src/Utilities/UrlQuery.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -233,7 +233,7 @@
 block discarded – undo
233 233
      *
234 234
      * @throws \allejo\DaPulse\Exceptions\CurlException If cURL is misconfigured or encounters an error
235 235
      *
236
-     * @return mixed
236
+     * @return string
237 237
      */
238 238
     private function executeCurl ()
239 239
     {
Please login to merge, or discard this patch.
tests/utilities/AuthenticatedClient.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
         return (isset($this->apiToken));
26 26
     }
27 27
 
28
-    public function getApiToken()
28
+    public function getApiToken ()
29 29
     {
30 30
         return $this->apiToken;
31 31
     }
Please login to merge, or discard this patch.
src/PulseUpdate.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -337,7 +337,7 @@
 block discarded – undo
337 337
      *
338 338
      * @return PulseUpdate
339 339
      */
340
-    public static function createUpdate ($user, $pulse, $text, $announceToAll = NULL)
340
+    public static function createUpdate ($user, $pulse, $text, $announceToAll = null)
341 341
     {
342 342
         if ($user instanceof PulseUser)
343 343
         {
Please login to merge, or discard this patch.
src/PulseNote.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@
 block discarded – undo
175 175
      *
176 176
      * @param  null|string        $title        The new title of the note
177 177
      * @param  null|string        $content      The new content of the note
178
-     * @param  null|int|PulseUser $userId       The new author of the note
178
+     * @param  string $userId       The new author of the note
179 179
      * @param  null|bool          $createUpdate Whether to create an update or not
180 180
      *
181 181
      * @since  0.1.0
Please login to merge, or discard this patch.
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
      *
186 186
      * @return $this
187 187
      */
188
-    public function editNote ($title = NULL, $content = NULL, $userId = NULL, $createUpdate = NULL)
188
+    public function editNote ($title = null, $content = null, $userId = null, $createUpdate = null)
189 189
     {
190 190
         $this->checkInvalid();
191 191
 
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
      */
254 254
     public function editContent ($content)
255 255
     {
256
-        return $this->editNote(NULL, $content);
256
+        return $this->editNote(null, $content);
257 257
     }
258 258
 
259 259
     /**
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
      */
274 274
     public function editAuthor ($userId)
275 275
     {
276
-        return $this->editNote(NULL, NULL, $userId);
276
+        return $this->editNote(null, null, $userId);
277 277
     }
278 278
 
279 279
     /**
Please login to merge, or discard this patch.
src/Objects/ApiObject.php 1 patch
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
      */
406 406
     final protected static function sendDelete ($url, $getParams = array())
407 407
     {
408
-        return self::sendRequest("DELETE", $url, NULL, $getParams);
408
+        return self::sendRequest("DELETE", $url, null, $getParams);
409 409
     }
410 410
 
411 411
     /**
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
      *
457 457
      * @return string The base URL to call
458 458
      */
459
-    final protected static function apiEndpoint ($apiPrefix = NULL)
459
+    final protected static function apiEndpoint ($apiPrefix = null)
460 460
     {
461 461
         $apiSection = isset($apiPrefix) ? $apiPrefix : static::API_PREFIX;
462 462
 
Please login to merge, or discard this patch.
src/Objects/SubscribableObject.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
      *
59 59
      * @since 0.1.0
60 60
      */
61
-    public function addSubscriber ($userId, $asAdmin = NULL)
61
+    public function addSubscriber ($userId, $asAdmin = null)
62 62
     {
63 63
         if ($userId instanceof PulseUser)
64 64
         {
Please login to merge, or discard this patch.
src/PulseBoard.php 1 patch
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
      *
291 291
      * @return PulseGroup[]
292 292
      */
293
-    public function getGroups ($showArchived = NULL)
293
+    public function getGroups ($showArchived = null)
294 294
     {
295 295
         $url    = sprintf("%s/%d/groups.json", self::apiEndpoint(), $this->getId());
296 296
         $params = array();
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
         return $pulses;
363 363
     }
364 364
 
365
-    public function createPulse ($name, $owner, $groupId = NULL)
365
+    public function createPulse ($name, $owner, $groupId = null)
366 366
     {
367 367
         $url        = sprintf("%s/%d/pulses.json", self::apiEndpoint(), $this->getId());
368 368
         $postParams = array(
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
         $this->deletedObject = true;
403 403
     }
404 404
 
405
-    public static function createBoard ($name, $userId, $description = NULL)
405
+    public static function createBoard ($name, $userId, $description = null)
406 406
     {
407 407
         $url        = sprintf("%s.json", self::apiEndpoint());
408 408
         $postParams = array(
Please login to merge, or discard this patch.
src/Pulse.php 2 patches
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
         $this->deletedObject = true;
255 255
     }
256 256
 
257
-    public function duplicatePulse ($groupId = NULL, $ownerId = NULL)
257
+    public function duplicatePulse ($groupId = null, $ownerId = null)
258 258
     {
259 259
         $url        = sprintf("%s/%s/pulses/%s/duplicate.json", self::apiEndpoint("boards"), $this->getBoardId(), $this->getId());
260 260
         $postParams = array();
@@ -498,7 +498,7 @@  discard block
 block discarded – undo
498 498
      * @since  0.1.0
499 499
      * @return PulseNote
500 500
      */
501
-    public function addNote ($title, $content, $ownersOnly = false, $userId = NULL, $createUpdate = false)
501
+    public function addNote ($title, $content, $ownersOnly = false, $userId = null, $createUpdate = false)
502 502
     {
503 503
         $url        = sprintf($this->urlSyntax, self::apiEndpoint(), $this->id, "notes");
504 504
         $postParams = array(
@@ -564,7 +564,7 @@  discard block
 block discarded – undo
564 564
      *
565 565
      * @since 0.1.0
566 566
      */
567
-    public function createUpdate ($user, $text, $announceToAll = NULL)
567
+    public function createUpdate ($user, $text, $announceToAll = null)
568 568
     {
569 569
         PulseUpdate::createUpdate($user, $this->getId(), $text, $announceToAll);
570 570
     }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
      * @param string $title
245 245
      * @since 0.1.0
246 246
      */
247
-    public function editName($title)
247
+    public function editName ($title)
248 248
     {
249 249
         $editUrl    = sprintf("%s/%d.json", self::apiEndpoint(), $this->getId());
250 250
         $postParams = array(
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
      * @api
264 264
      * @since 0.1.0
265 265
      */
266
-    public function archivePulse()
266
+    public function archivePulse ()
267 267
     {
268 268
         $archiveURL = sprintf("%s/%d.json", self::apiEndpoint(), $this->getId());
269 269
         $getParams  = array(
Please login to merge, or discard this patch.