allejo / PhpPulse

src/PulseColumn.php

Doc Comments +3 added lines

@@ -69,6 +69,9 @@
         $this->deletedObject = true;
     }
 
+    /**
+     * @param string $field
+     */
     private function editField ($field, $value)
     {
         $this->checkInvalid();

src/Utilities/UrlQuery.php

Doc Comments +1 added lines, -1 removed lines

@@ -233,7 +233,7 @@
      *
      * @throws \allejo\DaPulse\Exceptions\CurlException If cURL is misconfigured or encounters an error
      *
-     * @return mixed
+     * @return string
      */
     private function executeCurl ()
     {

Spacing +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
      */
     public function __construct ($url, $urlParams)
     {
-        $this->url  = $url . "?" . self::formatParameters($urlParams);
+        $this->url  = $url."?".self::formatParameters($urlParams);
         $this->cURL = curl_init();
 
         $this->configureCurl();
@@ -89,7 +89,7 @@ 
 
         curl_setopt_array($this->cURL, array(
             CURLOPT_HTTPAUTH => CURLAUTH_BASIC,
-            CURLOPT_USERPWD  => $username . ":" . $password
+            CURLOPT_USERPWD  => $username.":".$password
         ));
     }
 
@@ -309,7 +309,7 @@ 
                 continue;
             }
 
-            $parameters[] = rawurlencode($key) . "=" . rawurlencode($value);
+            $parameters[] = rawurlencode($key)."=".rawurlencode($value);
         }
 
         return implode("&", $parameters);

tests/utilities/AuthenticatedClient.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
         return (isset($this->apiToken));
     }
 
-    public function getApiToken()
+    public function getApiToken ()
     {
         return $this->apiToken;
     }

src/PulseUpdate.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -337,7 +337,7 @@
      *
      * @return PulseUpdate
      */
-    public static function createUpdate ($user, $pulse, $text, $announceToAll = NULL)
+    public static function createUpdate ($user, $pulse, $text, $announceToAll = null)
     {
         if ($user instanceof PulseUser)
         {

Doc Comments +2 added lines, -2 removed lines

@@ -298,7 +298,7 @@ 
      *
      * @since  0.3.0 Previously was available as 'getHasAssets()'
      *
-     * @return bool
+     * @return string
      */
     public function hasAssets ()
     {
@@ -409,7 +409,7 @@ 
      * @api
      *
      * @param  int|PulseUser $user          The author of this post
-     * @param  int|Pulse     $pulse         The Pulse to whom this update will belong to
+     * @param  integer     $pulse         The Pulse to whom this update will belong to
      * @param  string        $text          The content of the update
      * @param  null|bool     $announceToAll Whether or not to announce this update to everyone's wall
      *

src/PulseNote.php

Doc Comments +1 added lines, -1 removed lines

@@ -175,7 +175,7 @@
      *
      * @param  null|string        $title        The new title of the note
      * @param  null|string        $content      The new content of the note
-     * @param  null|int|PulseUser $userId       The new author of the note
+     * @param  string $userId       The new author of the note
      * @param  null|bool          $createUpdate Whether to create an update or not
      *
      * @since  0.1.0

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -185,7 +185,7 @@ 
      *
      * @return $this
      */
-    public function editNote ($title = NULL, $content = NULL, $userId = NULL, $createUpdate = NULL)
+    public function editNote ($title = null, $content = null, $userId = null, $createUpdate = null)
     {
         $this->checkInvalid();
 
@@ -253,7 +253,7 @@ 
      */
     public function editContent ($content)
     {
-        return $this->editNote(NULL, $content);
+        return $this->editNote(null, $content);
     }
 
     /**
@@ -273,7 +273,7 @@ 
      */
     public function editAuthor ($userId)
     {
-        return $this->editNote(NULL, NULL, $userId);
+        return $this->editNote(null, null, $userId);
     }
 
     /**

src/Objects/ApiObject.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -405,7 +405,7 @@ 
      */
     final protected static function sendDelete ($url, $getParams = array())
     {
-        return self::sendRequest("DELETE", $url, NULL, $getParams);
+        return self::sendRequest("DELETE", $url, null, $getParams);
     }
 
     /**
@@ -456,7 +456,7 @@ 
      *
      * @return string The base URL to call
      */
-    final protected static function apiEndpoint ($apiPrefix = NULL)
+    final protected static function apiEndpoint ($apiPrefix = null)
     {
         $apiSection = isset($apiPrefix) ? $apiPrefix : static::API_PREFIX;
 

Spacing +6 added lines, -6 removed lines

@@ -106,7 +106,7 @@ 
 
         if (is_null($idOrArray))
         {
-            throw new \InvalidArgumentException("You may not initialize " . $staticClass . " with null.");
+            throw new \InvalidArgumentException("You may not initialize ".$staticClass." with null.");
         }
 
         if (!is_array($idOrArray))
@@ -116,7 +116,7 @@ 
 
         if ($this->arrayConstructionOnly && !is_array($idOrArray))
         {
-            throw new \InvalidArgumentException("A " . $staticClass . " cannot be fetched from an ID.");
+            throw new \InvalidArgumentException("A ".$staticClass." cannot be fetched from an ID.");
         }
 
         $this->jsonResponse = (is_array($idOrArray)) ? $idOrArray : $this::sendGet($urlEndPoint);
@@ -128,7 +128,7 @@ 
     /**
      * {@inheritdoc}
      */
-    public function jsonSerialize()
+    public function jsonSerialize ()
     {
         return $this->jsonResponse;
     }
@@ -272,7 +272,7 @@ 
     {
         if (self::lazyCastNeeded($target, $objectType))
         {
-            $object = ($objectType[0] == "\\") ? $objectType : self::OBJ_NAMESPACE . $objectType;
+            $object = ($objectType[0] == "\\") ? $objectType : self::OBJ_NAMESPACE.$objectType;
             $target = new $object($target);
         }
     }
@@ -306,7 +306,7 @@ 
      */
     final protected static function lazyCastNeeded ($target, $objectType)
     {
-        $objectDefinition = ($objectType[0] === "\\") ? $objectType : self::OBJ_NAMESPACE . $objectType;
+        $objectDefinition = ($objectType[0] === "\\") ? $objectType : self::OBJ_NAMESPACE.$objectType;
 
         return !($target instanceof $objectDefinition);
     }
@@ -343,7 +343,7 @@ 
      */
     final protected static function castArrayToObjectArray ($className, $objects)
     {
-        $class = self::OBJ_NAMESPACE . $className;
+        $class = self::OBJ_NAMESPACE.$className;
         $array = array();
 
         foreach ($objects as $post)

Braces +3 added lines, -1 removed lines

@@ -289,7 +289,9 @@
      */
     final protected static function lazyCastNeededOnArray ($objectType, $array)
     {
-        if (is_array($array) && count($array) == 0) { return false; }
+        if (is_array($array) && count($array) == 0)
+        {
+return false; }
 
         $firstItem = $array[0];
 

src/Objects/SubscribableObject.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
      *
      * @since 0.1.0
      */
-    public function addSubscriber ($userId, $asAdmin = NULL)
+    public function addSubscriber ($userId, $asAdmin = null)
     {
         if ($userId instanceof PulseUser)
         {

src/Pulse.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -254,7 +254,7 @@ 
         $this->deletedObject = true;
     }
 
-    public function duplicatePulse ($groupId = NULL, $ownerId = NULL)
+    public function duplicatePulse ($groupId = null, $ownerId = null)
     {
         $url        = sprintf("%s/%s/pulses/%s/duplicate.json", self::apiEndpoint("boards"), $this->getBoardId(), $this->getId());
         $postParams = array();
@@ -498,7 +498,7 @@ 
      * @since  0.1.0
      * @return PulseNote
      */
-    public function addNote ($title, $content, $ownersOnly = false, $userId = NULL, $createUpdate = false)
+    public function addNote ($title, $content, $ownersOnly = false, $userId = null, $createUpdate = false)
     {
         $url        = sprintf($this->urlSyntax, self::apiEndpoint(), $this->id, "notes");
         $postParams = array(
@@ -564,7 +564,7 @@ 
      *
      * @since 0.1.0
      */
-    public function createUpdate ($user, $text, $announceToAll = NULL)
+    public function createUpdate ($user, $text, $announceToAll = null)
     {
         PulseUpdate::createUpdate($user, $this->getId(), $text, $announceToAll);
     }

Spacing +2 added lines, -2 removed lines

@@ -244,7 +244,7 @@ 
      * @param string $title
      * @since 0.1.0
      */
-    public function editName($title)
+    public function editName ($title)
     {
         $editUrl    = sprintf("%s/%d.json", self::apiEndpoint(), $this->getId());
         $postParams = array(
@@ -263,7 +263,7 @@ 
      * @api
      * @since 0.1.0
      */
-    public function archivePulse()
+    public function archivePulse ()
     {
         $archiveURL = sprintf("%s/%d.json", self::apiEndpoint(), $this->getId());
         $getParams  = array(

Indentation -1 removed lines

@@ -418,7 +418,6 @@
      * @param  string $columnId The ID of the column to access. This is typically a slugified version of the column name
      *
      * @since  0.1.0
-
      * @throws ColumnNotFoundException The specified column ID does not exist for this Pulse
      * @throws InvalidColumnException  The specified column is not a "text" type column
      * @throws InvalidObjectException  The specified column exists but modification of its value is unsupported either

src/PulseBoard.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -291,7 +291,7 @@ 
      *
      * @return PulseGroup[]
      */
-    public function getGroups ($showArchived = NULL)
+    public function getGroups ($showArchived = null)
     {
         $url    = sprintf("%s/%d/groups.json", self::apiEndpoint(), $this->getId());
         $params = array();
@@ -381,7 +381,7 @@ 
      *
      * @return \allejo\DaPulse\Pulse
      */
-    public function createPulse ($name, $owner, $groupId = NULL, $updateText = NULL, $announceToAll = NULL)
+    public function createPulse ($name, $owner, $groupId = null, $updateText = null, $announceToAll = null)
     {
         if ($owner instanceof PulseUser)
         {
@@ -428,7 +428,7 @@ 
         $this->deletedObject = true;
     }
 
-    public static function createBoard ($name, $userId, $description = NULL)
+    public static function createBoard ($name, $userId, $description = null)
     {
         $url        = sprintf("%s.json", self::apiEndpoint());
         $postParams = array(