RobotsController::indexAction() - Code Metrics - alexander-torosh/yona-cms - Measure and Improve Code Quality continuously with Scrutinizer

RobotsController::indexAction() A
last analyzed 2019-11-25 19:20 UTC

↳ Parent: RobotsController

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	17
Ratio	62.96 %

Importance

Changes

Metric	Value
dl	17
loc	27
rs	9.488
c	0
b	0
f	0
cc	4
nc	4
nop	0

<?php

namespace Seo\Controller;

use Application\Mvc\Controller;
use Seo\Form\RobotsForm;

class RobotsController extends Controller
{

    private $robotsFilePath;

    public function initialize()
    {
        $this->setAdminEnvironment();
        $this->helper->activeMenu()->setActive('seo-robots');
        $this->robotsFilePath = ROOT . '/robots.txt';
        $this->view->languages_disabled = true;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function indexAction()
    {
        $form = new RobotsForm();

        if ($this->request->isPost()) {
            if ($form->isValid()) {
                $robots = $this->request->getPost('robots', 'string');
                $result = file_put_contents($this->robotsFilePath, $robots);
                if ($result) {
                    $this->flash->success('File robots.txt has been saved');
                    $this->redirect($this->url->get() . 'seo/robots');
                } else {
                    $this->flash->error('Error! The robots.txt file is not updated. Check the write permissions to the file.');
                }
            } else {
                $this->flashErrors($form);
            }
        } else {
            $robots = file_get_contents($this->robotsFilePath);
            $form->get('robots')->setDefault($robots);

        }

        $this->helper->title('Editing robots.txt', true);
        $this->view->form = $form;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}


    }

}


1		<?php
2
3		namespace Seo\Controller;
4
5		use Application\Mvc\Controller;
6		use Seo\Form\RobotsForm;
7
8		class RobotsController extends Controller
9		{
10
11		private $robotsFilePath;
12
13	View Code Duplication	public function initialize()
14		{
15		$this->setAdminEnvironment();
16		$this->helper->activeMenu()->setActive('seo-robots');
17		$this->robotsFilePath = ROOT . '/robots.txt';
18		$this->view->languages_disabled = true;
		0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `languages_disabled` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
19		}
20
21		public function indexAction()
22		{
23		$form = new RobotsForm();
24
25	View Code Duplication	if ($this->request->isPost()) {
26		if ($form->isValid()) {
27		$robots = $this->request->getPost('robots', 'string');
28		$result = file_put_contents($this->robotsFilePath, $robots);
29		if ($result) {
30		$this->flash->success('File robots.txt has been saved');
31		$this->redirect($this->url->get() . 'seo/robots');
32		} else {
33		$this->flash->error('Error! The robots.txt file is not updated. Check the write permissions to the file.');
34		}
35		} else {
36		$this->flashErrors($form);
37		}
38		} else {
39		$robots = file_get_contents($this->robotsFilePath);
40		$form->get('robots')->setDefault($robots);
		0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `setDefault` cannot be called on `$form->get('robots')` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
41		}
42
43		$this->helper->title('Editing robots.txt', true);
44		$this->view->form = $form;
		0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `form` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
45
46
47		}
48
49		}
50

alexander-torosh / yona-cms

RobotsController::indexAction() A last analyzed 2019-11-25 19:20 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RobotsController::indexAction() A
last analyzed 2019-11-25 19:20 UTC