Seo\Controller\RobotsController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	42
Duplicated Lines	57.14 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	7	7	1
A	indexAction()	17	27	4

<?php

namespace Seo\Controller;

use Application\Mvc\Controller;
use Seo\Form\RobotsForm;

class RobotsController extends Controller
{

    private $robotsFilePath;

    public function initialize()
    {
        $this->setAdminEnvironment();
        $this->helper->activeMenu()->setActive('seo-robots');
        $this->robotsFilePath = ROOT . '/robots.txt';
        $this->view->languages_disabled = true;

Accessing languages_disabled on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function indexAction()
    {
        $form = new RobotsForm();

        if ($this->request->isPost()) {
            if ($form->isValid()) {
                $robots = $this->request->getPost('robots', 'string');
                $result = file_put_contents($this->robotsFilePath, $robots);
                if ($result) {
                    $this->flash->success('File robots.txt has been saved');
                    $this->redirect($this->url->get() . 'seo/robots');
                } else {
                    $this->flash->error('Error! The robots.txt file is not updated. Check the write permissions to the file.');
                }
            } else {
                $this->flashErrors($form);
            }
        } else {
            $robots = file_get_contents($this->robotsFilePath);
            $form->get('robots')->setDefault($robots);

The method setDefault cannot be called on $form->get('robots') (of type null).

        }

        $this->helper->title('Editing robots.txt', true);
        $this->view->form = $form;

Accessing form on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

}