@@ -461,7 +461,7 @@ |
||
461 | 461 | $fields = ''; |
462 | 462 | foreach ($context['print_custom_fields']['below_signature'] as $field) |
463 | 463 | if (!empty($field['output_html'])) |
464 | - $fields .= ' |
|
464 | + $fields .= ' |
|
465 | 465 | <li>' . $field['output_html'] . '</li>'; |
466 | 466 | |
467 | 467 | if (!empty($fields)) |
@@ -18,23 +18,25 @@ discard block |
||
18 | 18 | global $context; |
19 | 19 | |
20 | 20 | // Prevent Chrome from auto completing fields when viewing/editing other members profiles |
21 | - if (isBrowser('is_chrome') && !$context['user']['is_owner']) |
|
22 | - echo ' |
|
21 | + if (isBrowser('is_chrome') && !$context['user']['is_owner']) { |
|
22 | + echo ' |
|
23 | 23 | <script> |
24 | 24 | disableAutoComplete(); |
25 | 25 | </script>'; |
26 | + } |
|
26 | 27 | |
27 | 28 | // If an error occurred while trying to save previously, give the user a clue! |
28 | 29 | echo ' |
29 | 30 | ', template_error_message(); |
30 | 31 | |
31 | 32 | // If the profile was update successfully, let the user know this. |
32 | - if (!empty($context['profile_updated'])) |
|
33 | - echo ' |
|
33 | + if (!empty($context['profile_updated'])) { |
|
34 | + echo ' |
|
34 | 35 | <div class="infobox"> |
35 | 36 | ', $context['profile_updated'], ' |
36 | 37 | </div>'; |
37 | -} |
|
38 | + } |
|
39 | + } |
|
38 | 40 | |
39 | 41 | /** |
40 | 42 | * Template for any HTML needed below the profile (closing off divs/tables, etc.) |
@@ -99,19 +101,19 @@ discard block |
||
99 | 101 | </div> |
100 | 102 | <div class="alerts_unread">'; |
101 | 103 | |
102 | - if (empty($context['unread_alerts'])) |
|
103 | - template_alerts_all_read(); |
|
104 | - |
|
105 | - else |
|
104 | + if (empty($context['unread_alerts'])) { |
|
105 | + template_alerts_all_read(); |
|
106 | + } else |
|
106 | 107 | { |
107 | - foreach ($context['unread_alerts'] as $id_alert => $details) |
|
108 | - echo ' |
|
108 | + foreach ($context['unread_alerts'] as $id_alert => $details) { |
|
109 | + echo ' |
|
109 | 110 | <div class="unread"> |
110 | 111 | ', !empty($details['sender']) ? $details['sender']['avatar']['image'] : '', ' |
111 | 112 | <div class="details"> |
112 | 113 | ', !empty($details['icon']) ? $details['icon'] : '', '<span>', $details['text'], '</span> - ', $details['time'], ' |
113 | 114 | </div> |
114 | 115 | </div>'; |
116 | + } |
|
115 | 117 | } |
116 | 118 | |
117 | 119 | echo ' |
@@ -158,37 +160,41 @@ discard block |
||
158 | 160 | if (!empty($context['print_custom_fields']['above_member'])) |
159 | 161 | { |
160 | 162 | $fields = ''; |
161 | - foreach ($context['print_custom_fields']['above_member'] as $field) |
|
162 | - if (!empty($field['output_html'])) |
|
163 | + foreach ($context['print_custom_fields']['above_member'] as $field) { |
|
164 | + if (!empty($field['output_html'])) |
|
163 | 165 | $fields .= ' |
164 | 166 | <li>' . $field['output_html'] . '</li>'; |
167 | + } |
|
165 | 168 | |
166 | - if (!empty($fields)) |
|
167 | - echo ' |
|
169 | + if (!empty($fields)) { |
|
170 | + echo ' |
|
168 | 171 | <div class="custom_fields_above_name"> |
169 | 172 | <ul>', $fields, ' |
170 | 173 | </ul> |
171 | 174 | </div>'; |
175 | + } |
|
172 | 176 | } |
173 | 177 | |
174 | 178 | echo ' |
175 | 179 | <div class="username clear"> |
176 | 180 | <h4>'; |
177 | 181 | |
178 | - if (!empty($context['print_custom_fields']['before_member'])) |
|
179 | - foreach ($context['print_custom_fields']['before_member'] as $field) |
|
182 | + if (!empty($context['print_custom_fields']['before_member'])) { |
|
183 | + foreach ($context['print_custom_fields']['before_member'] as $field) |
|
180 | 184 | if (!empty($field['output_html'])) |
181 | 185 | echo ' |
182 | 186 | <span>', $field['output_html'], '</span>'; |
187 | + } |
|
183 | 188 | |
184 | 189 | echo ' |
185 | 190 | ', $context['member']['name']; |
186 | 191 | |
187 | - if (!empty($context['print_custom_fields']['after_member'])) |
|
188 | - foreach ($context['print_custom_fields']['after_member'] as $field) |
|
192 | + if (!empty($context['print_custom_fields']['after_member'])) { |
|
193 | + foreach ($context['print_custom_fields']['after_member'] as $field) |
|
189 | 194 | if (!empty($field['output_html'])) |
190 | 195 | echo ' |
191 | 196 | <span>', $field['output_html'], '</span>'; |
197 | + } |
|
192 | 198 | |
193 | 199 | |
194 | 200 | echo ' |
@@ -201,39 +207,44 @@ discard block |
||
201 | 207 | if (!empty($context['print_custom_fields']['below_avatar'])) |
202 | 208 | { |
203 | 209 | $fields = ''; |
204 | - foreach ($context['print_custom_fields']['below_avatar'] as $field) |
|
205 | - if (!empty($field['output_html'])) |
|
210 | + foreach ($context['print_custom_fields']['below_avatar'] as $field) { |
|
211 | + if (!empty($field['output_html'])) |
|
206 | 212 | $fields .= ' |
207 | 213 | <li>' . $field['output_html'] . '</li>'; |
214 | + } |
|
208 | 215 | |
209 | - if (!empty($fields)) |
|
210 | - echo ' |
|
216 | + if (!empty($fields)) { |
|
217 | + echo ' |
|
211 | 218 | <div class="custom_fields_below_avatar"> |
212 | 219 | <ul>', $fields, ' |
213 | 220 | </ul> |
214 | 221 | </div>'; |
222 | + } |
|
215 | 223 | } |
216 | 224 | |
217 | 225 | echo ' |
218 | 226 | <ul class="icon_fields clear">'; |
219 | 227 | |
220 | 228 | // Email is only visible if it's your profile or you have the moderate_forum permission |
221 | - if ($context['member']['show_email']) |
|
222 | - echo ' |
|
229 | + if ($context['member']['show_email']) { |
|
230 | + echo ' |
|
223 | 231 | <li><a href="mailto:', $context['member']['email'], '" title="', $context['member']['email'], '" rel="nofollow"><span class="generic_icons mail" title="' . $txt['email'] . '"></span></a></li>'; |
232 | + } |
|
224 | 233 | |
225 | 234 | // Don't show an icon if they haven't specified a website. |
226 | - if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) |
|
227 | - echo ' |
|
235 | + if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) { |
|
236 | + echo ' |
|
228 | 237 | <li><a href="', $context['member']['website']['url'], '" title="' . $context['member']['website']['title'] . '" target="_blank" rel="noopener">', ($settings['use_image_buttons'] ? '<span class="generic_icons www" title="' . $context['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>'; |
238 | + } |
|
229 | 239 | |
230 | 240 | // Are there any custom profile fields as icons? |
231 | 241 | if (!empty($context['print_custom_fields']['icons'])) |
232 | 242 | { |
233 | - foreach ($context['print_custom_fields']['icons'] as $field) |
|
234 | - if (!empty($field['output_html'])) |
|
243 | + foreach ($context['print_custom_fields']['icons'] as $field) { |
|
244 | + if (!empty($field['output_html'])) |
|
235 | 245 | echo ' |
236 | 246 | <li class="custom_field">', $field['output_html'], '</li>'; |
247 | + } |
|
237 | 248 | } |
238 | 249 | |
239 | 250 | echo ' |
@@ -242,24 +253,27 @@ discard block |
||
242 | 253 | ', $context['can_send_pm'] ? '<a href="' . $context['member']['online']['href'] . '" title="' . $context['member']['online']['text'] . '" rel="nofollow">' : '', $settings['use_image_buttons'] ? '<span class="' . ($context['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $context['member']['online']['text'] . '"></span>' : $context['member']['online']['label'], $context['can_send_pm'] ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $context['member']['online']['label'] . '</span>' : ''; |
243 | 254 | |
244 | 255 | // Can they add this member as a buddy? |
245 | - if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) |
|
246 | - echo ' |
|
256 | + if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) { |
|
257 | + echo ' |
|
247 | 258 | <br> |
248 | 259 | <a href="', $scripturl, '?action=buddy;u=', $context['id_member'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['buddy_' . ($context['member']['is_buddy'] ? 'remove' : 'add')], '</a>'; |
260 | + } |
|
249 | 261 | |
250 | 262 | echo ' |
251 | 263 | </span>'; |
252 | 264 | |
253 | - if (!$context['user']['is_owner'] && $context['can_send_pm']) |
|
254 | - echo ' |
|
265 | + if (!$context['user']['is_owner'] && $context['can_send_pm']) { |
|
266 | + echo ' |
|
255 | 267 | <a href="', $scripturl, '?action=pm;sa=send;u=', $context['id_member'], '" class="infolinks">', $txt['profile_sendpm_short'], '</a>'; |
268 | + } |
|
256 | 269 | |
257 | 270 | echo ' |
258 | 271 | <a href="', $scripturl, '?action=profile;area=showposts;u=', $context['id_member'], '" class="infolinks">', $txt['showPosts'], '</a>'; |
259 | 272 | |
260 | - if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) |
|
261 | - echo ' |
|
273 | + if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) { |
|
274 | + echo ' |
|
262 | 275 | <a href="', $scripturl, '?action=profile;area=showdrafts;u=', $context['id_member'], '" class="infolinks">', $txt['drafts_show'], '</a>'; |
276 | + } |
|
263 | 277 | |
264 | 278 | echo ' |
265 | 279 | <a href="', $scripturl, '?action=profile;area=statistics;u=', $context['id_member'], '" class="infolinks">', $txt['statPanel'], '</a>'; |
@@ -268,17 +282,19 @@ discard block |
||
268 | 282 | if (!empty($context['print_custom_fields']['bottom_poster'])) |
269 | 283 | { |
270 | 284 | $fields = ''; |
271 | - foreach ($context['print_custom_fields']['bottom_poster'] as $field) |
|
272 | - if (!empty($field['output_html'])) |
|
285 | + foreach ($context['print_custom_fields']['bottom_poster'] as $field) { |
|
286 | + if (!empty($field['output_html'])) |
|
273 | 287 | $fields .= ' |
274 | 288 | <li>' . $field['output_html'] . '</li>'; |
289 | + } |
|
275 | 290 | |
276 | - if (!empty($fields)) |
|
277 | - echo ' |
|
291 | + if (!empty($fields)) { |
|
292 | + echo ' |
|
278 | 293 | <div class="custom_fields_bottom"> |
279 | 294 | <ul class="nolist">', $fields, ' |
280 | 295 | </ul> |
281 | 296 | </div>'; |
297 | + } |
|
282 | 298 | } |
283 | 299 | |
284 | 300 | echo ' |
@@ -287,30 +303,35 @@ discard block |
||
287 | 303 | <div id="detailedinfo"> |
288 | 304 | <dl class="settings">'; |
289 | 305 | |
290 | - if ($context['user']['is_owner'] || $context['user']['is_admin']) |
|
291 | - echo ' |
|
306 | + if ($context['user']['is_owner'] || $context['user']['is_admin']) { |
|
307 | + echo ' |
|
292 | 308 | <dt>', $txt['username'], ': </dt> |
293 | 309 | <dd>', $context['member']['username'], '</dd>'; |
310 | + } |
|
294 | 311 | |
295 | - if (!isset($context['disabled_fields']['posts'])) |
|
296 | - echo ' |
|
312 | + if (!isset($context['disabled_fields']['posts'])) { |
|
313 | + echo ' |
|
297 | 314 | <dt>', $txt['profile_posts'], ': </dt> |
298 | 315 | <dd>', $context['member']['posts'], ' (', $context['member']['posts_per_day'], ' ', $txt['posts_per_day'], ')</dd>'; |
316 | + } |
|
299 | 317 | |
300 | - if ($context['member']['show_email']) |
|
301 | - echo ' |
|
318 | + if ($context['member']['show_email']) { |
|
319 | + echo ' |
|
302 | 320 | <dt>', $txt['email'], ': </dt> |
303 | 321 | <dd><a href="mailto:', $context['member']['email'], '">', $context['member']['email'], '</a></dd>'; |
322 | + } |
|
304 | 323 | |
305 | - if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) |
|
306 | - echo ' |
|
324 | + if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) { |
|
325 | + echo ' |
|
307 | 326 | <dt>', $txt['custom_title'], ': </dt> |
308 | 327 | <dd>', $context['member']['title'], '</dd>'; |
328 | + } |
|
309 | 329 | |
310 | - if (!empty($context['member']['blurb'])) |
|
311 | - echo ' |
|
330 | + if (!empty($context['member']['blurb'])) { |
|
331 | + echo ' |
|
312 | 332 | <dt>', $txt['personal_text'], ': </dt> |
313 | 333 | <dd>', $context['member']['blurb'], '</dd>'; |
334 | + } |
|
314 | 335 | |
315 | 336 | echo ' |
316 | 337 | <dt>', $txt['age'], ':</dt> |
@@ -324,19 +345,21 @@ discard block |
||
324 | 345 | { |
325 | 346 | $fields = array(); |
326 | 347 | |
327 | - foreach ($context['print_custom_fields']['standard'] as $field) |
|
328 | - if (!empty($field['output_html'])) |
|
348 | + foreach ($context['print_custom_fields']['standard'] as $field) { |
|
349 | + if (!empty($field['output_html'])) |
|
329 | 350 | $fields[] = $field; |
351 | + } |
|
330 | 352 | |
331 | 353 | if (count($fields) > 0) |
332 | 354 | { |
333 | 355 | echo ' |
334 | 356 | <dl class="settings">'; |
335 | 357 | |
336 | - foreach ($fields as $field) |
|
337 | - echo ' |
|
358 | + foreach ($fields as $field) { |
|
359 | + echo ' |
|
338 | 360 | <dt>', $field['name'], ':</dt> |
339 | 361 | <dd>', $field['output_html'], '</dd>'; |
362 | + } |
|
340 | 363 | |
341 | 364 | echo ' |
342 | 365 | </dl>'; |
@@ -355,9 +378,10 @@ discard block |
||
355 | 378 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=', ($context['can_issue_warning'] && !$context['user']['is_owner'] ? 'issuewarning' : 'viewwarning'), '">', $context['member']['warning'], '%</a>'; |
356 | 379 | |
357 | 380 | // Can we provide information on what this means? |
358 | - if (!empty($context['warning_status'])) |
|
359 | - echo ' |
|
381 | + if (!empty($context['warning_status'])) { |
|
382 | + echo ' |
|
360 | 383 | <span class="smalltext">(', $context['warning_status'], ')</span>'; |
384 | + } |
|
361 | 385 | |
362 | 386 | echo ' |
363 | 387 | </dd>'; |
@@ -367,11 +391,12 @@ discard block |
||
367 | 391 | if (!empty($context['activate_message']) || !empty($context['member']['bans'])) |
368 | 392 | { |
369 | 393 | // If the person looking at the summary has permission, and the account isn't activated, give the viewer the ability to do it themselves. |
370 | - if (!empty($context['activate_message'])) |
|
371 | - echo ' |
|
394 | + if (!empty($context['activate_message'])) { |
|
395 | + echo ' |
|
372 | 396 | <dt class="clear"> |
373 | 397 | <span class="alert">', $context['activate_message'], '</span> (<a href="', $context['activate_link'], '"', ($context['activate_type'] == 4 ? ' class="you_sure" data-confirm="' . $txt['profileConfirm'] . '"' : ''), '>', $context['activate_link_text'], '</a>) |
374 | 398 | </dt>'; |
399 | + } |
|
375 | 400 | |
376 | 401 | // If the current member is banned, show a message and possibly a link to the ban. |
377 | 402 | if (!empty($context['member']['bans'])) |
@@ -383,10 +408,11 @@ discard block |
||
383 | 408 | <dt class="clear" id="ban_info" style="display: none;"> |
384 | 409 | <strong>', $txt['user_banned_by_following'], ':</strong>'; |
385 | 410 | |
386 | - foreach ($context['member']['bans'] as $ban) |
|
387 | - echo ' |
|
411 | + foreach ($context['member']['bans'] as $ban) { |
|
412 | + echo ' |
|
388 | 413 | <br> |
389 | 414 | <span class="smalltext">', $ban['explanation'], '</span>'; |
415 | + } |
|
390 | 416 | |
391 | 417 | echo ' |
392 | 418 | </dt>'; |
@@ -400,30 +426,34 @@ discard block |
||
400 | 426 | // If the person looking is allowed, they can check the members IP address and hostname. |
401 | 427 | if ($context['can_see_ip']) |
402 | 428 | { |
403 | - if (!empty($context['member']['ip'])) |
|
404 | - echo ' |
|
429 | + if (!empty($context['member']['ip'])) { |
|
430 | + echo ' |
|
405 | 431 | <dt>', $txt['ip'], ': </dt> |
406 | 432 | <dd><a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['member']['ip'], ';u=', $context['member']['id'], '">', $context['member']['ip'], '</a></dd>'; |
433 | + } |
|
407 | 434 | |
408 | - if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) |
|
409 | - echo ' |
|
435 | + if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) { |
|
436 | + echo ' |
|
410 | 437 | <dt>', $txt['hostname'], ': </dt> |
411 | 438 | <dd>', $context['member']['hostname'], '</dd>'; |
439 | + } |
|
412 | 440 | } |
413 | 441 | |
414 | 442 | echo ' |
415 | 443 | <dt>', $txt['local_time'], ':</dt> |
416 | 444 | <dd>', $context['member']['local_time'], '</dd>'; |
417 | 445 | |
418 | - if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) |
|
419 | - echo ' |
|
446 | + if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) { |
|
447 | + echo ' |
|
420 | 448 | <dt>', $txt['language'], ':</dt> |
421 | 449 | <dd>', $context['member']['language'], '</dd>'; |
450 | + } |
|
422 | 451 | |
423 | - if ($context['member']['show_last_login']) |
|
424 | - echo ' |
|
452 | + if ($context['member']['show_last_login']) { |
|
453 | + echo ' |
|
425 | 454 | <dt>', $txt['lastLoggedIn'], ': </dt> |
426 | 455 | <dd>', $context['member']['last_login'], (!empty($context['member']['is_hidden']) ? ' (' . $txt['hidden'] . ')' : ''), '</dd>'; |
456 | + } |
|
427 | 457 | |
428 | 458 | echo ' |
429 | 459 | </dl>'; |
@@ -432,42 +462,47 @@ discard block |
||
432 | 462 | if (!empty($context['print_custom_fields']['above_signature'])) |
433 | 463 | { |
434 | 464 | $fields = ''; |
435 | - foreach ($context['print_custom_fields']['above_signature'] as $field) |
|
436 | - if (!empty($field['output_html'])) |
|
465 | + foreach ($context['print_custom_fields']['above_signature'] as $field) { |
|
466 | + if (!empty($field['output_html'])) |
|
437 | 467 | $fields .= ' |
438 | 468 | <li>' . $field['output_html'] . '</li>'; |
469 | + } |
|
439 | 470 | |
440 | - if (!empty($fields)) |
|
441 | - echo ' |
|
471 | + if (!empty($fields)) { |
|
472 | + echo ' |
|
442 | 473 | <div class="custom_fields_above_signature"> |
443 | 474 | <ul class="nolist">', $fields, ' |
444 | 475 | </ul> |
445 | 476 | </div>'; |
477 | + } |
|
446 | 478 | } |
447 | 479 | |
448 | 480 | // Show the users signature. |
449 | - if ($context['signature_enabled'] && !empty($context['member']['signature'])) |
|
450 | - echo ' |
|
481 | + if ($context['signature_enabled'] && !empty($context['member']['signature'])) { |
|
482 | + echo ' |
|
451 | 483 | <div class="signature"> |
452 | 484 | <h5>', $txt['signature'], ':</h5> |
453 | 485 | ', $context['member']['signature'], ' |
454 | 486 | </div>'; |
487 | + } |
|
455 | 488 | |
456 | 489 | // Are there any custom profile fields for below the signature? |
457 | 490 | if (!empty($context['print_custom_fields']['below_signature'])) |
458 | 491 | { |
459 | 492 | $fields = ''; |
460 | - foreach ($context['print_custom_fields']['below_signature'] as $field) |
|
461 | - if (!empty($field['output_html'])) |
|
493 | + foreach ($context['print_custom_fields']['below_signature'] as $field) { |
|
494 | + if (!empty($field['output_html'])) |
|
462 | 495 | $fields .= ' |
463 | 496 | <li>' . $field['output_html'] . '</li>'; |
497 | + } |
|
464 | 498 | |
465 | - if (!empty($fields)) |
|
466 | - echo ' |
|
499 | + if (!empty($fields)) { |
|
500 | + echo ' |
|
467 | 501 | <div class="custom_fields_below_signature"> |
468 | 502 | <ul class="nolist">', $fields, ' |
469 | 503 | </ul> |
470 | 504 | </div>'; |
505 | + } |
|
471 | 506 | } |
472 | 507 | |
473 | 508 | echo ' |
@@ -509,62 +544,70 @@ discard block |
||
509 | 544 | </div> |
510 | 545 | <div class="list_posts">'; |
511 | 546 | |
512 | - if (!$post['approved']) |
|
513 | - echo ' |
|
547 | + if (!$post['approved']) { |
|
548 | + echo ' |
|
514 | 549 | <div class="approve_post"> |
515 | 550 | <em>', $txt['post_awaiting_approval'], '</em> |
516 | 551 | </div>'; |
552 | + } |
|
517 | 553 | |
518 | 554 | echo ' |
519 | 555 | ', $post['body'], ' |
520 | 556 | </div>'; |
521 | 557 | |
522 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
523 | - echo ' |
|
558 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
559 | + echo ' |
|
524 | 560 | <div class="floatright"> |
525 | 561 | <ul class="quickbuttons">'; |
562 | + } |
|
526 | 563 | |
527 | 564 | // If they *can* reply? |
528 | - if ($post['can_reply']) |
|
529 | - echo ' |
|
565 | + if ($post['can_reply']) { |
|
566 | + echo ' |
|
530 | 567 | <li><a href="', $scripturl, '?action=post;topic=', $post['topic'], '.', $post['start'], '"><span class="generic_icons reply_button"></span>', $txt['reply'], '</a></li>'; |
568 | + } |
|
531 | 569 | |
532 | 570 | // If they *can* quote? |
533 | - if ($post['can_quote']) |
|
534 | - echo ' |
|
571 | + if ($post['can_quote']) { |
|
572 | + echo ' |
|
535 | 573 | <li><a href="', $scripturl . '?action=post;topic=', $post['topic'], '.', $post['start'], ';quote=', $post['id'], '"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>'; |
574 | + } |
|
536 | 575 | |
537 | 576 | // How about... even... remove it entirely?! |
538 | - if ($post['can_delete']) |
|
539 | - echo ' |
|
577 | + if ($post['can_delete']) { |
|
578 | + echo ' |
|
540 | 579 | <li><a href="', $scripturl, '?action=deletemsg;msg=', $post['id'], ';topic=', $post['topic'], ';profile;u=', $context['member']['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>'; |
580 | + } |
|
541 | 581 | |
542 | - if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) |
|
543 | - echo ' |
|
582 | + if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) { |
|
583 | + echo ' |
|
544 | 584 | </ul> |
545 | 585 | </div><!-- .floatright -->'; |
586 | + } |
|
546 | 587 | |
547 | 588 | echo ' |
548 | 589 | </div><!-- $post[css_class] -->'; |
549 | 590 | } |
591 | + } else { |
|
592 | + template_show_list('attachments'); |
|
550 | 593 | } |
551 | - else |
|
552 | - template_show_list('attachments'); |
|
553 | 594 | |
554 | 595 | // No posts? Just end with a informative message. |
555 | - if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) |
|
556 | - echo ' |
|
596 | + if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) { |
|
597 | + echo ' |
|
557 | 598 | <div class="windowbg2"> |
558 | 599 | ', isset($context['attachments']) ? $txt['show_attachments_none'] : ($context['is_topics'] ? $txt['show_topics_none'] : $txt['show_posts_none']), ' |
559 | 600 | </div>'; |
601 | + } |
|
560 | 602 | |
561 | 603 | // Show more page numbers. |
562 | - if (!empty($context['page_index'])) |
|
563 | - echo ' |
|
604 | + if (!empty($context['page_index'])) { |
|
605 | + echo ' |
|
564 | 606 | <div class="pagesection"> |
565 | 607 | <div class="pagelinks">', $context['page_index'], '</div> |
566 | 608 | </div>'; |
567 | -} |
|
609 | + } |
|
610 | + } |
|
568 | 611 | |
569 | 612 | /** |
570 | 613 | * Template for showing alerts within the alerts popup |
@@ -574,11 +617,12 @@ discard block |
||
574 | 617 | global $context, $txt, $scripturl; |
575 | 618 | |
576 | 619 | // Do we have an update message? |
577 | - if (!empty($context['update_message'])) |
|
578 | - echo ' |
|
620 | + if (!empty($context['update_message'])) { |
|
621 | + echo ' |
|
579 | 622 | <div class="infobox"> |
580 | 623 | ', $context['update_message'], ' |
581 | 624 | </div>'; |
625 | + } |
|
582 | 626 | |
583 | 627 | echo ' |
584 | 628 | <div class="cat_bar"> |
@@ -587,18 +631,18 @@ discard block |
||
587 | 631 | </h3> |
588 | 632 | </div>'; |
589 | 633 | |
590 | - if (empty($context['alerts'])) |
|
591 | - echo ' |
|
634 | + if (empty($context['alerts'])) { |
|
635 | + echo ' |
|
592 | 636 | <div class="information"> |
593 | 637 | ', $txt['alerts_none'], ' |
594 | 638 | </div>'; |
595 | - |
|
596 | - else |
|
639 | + } else |
|
597 | 640 | { |
598 | 641 | // Start the form if checkboxes are in use |
599 | - if ($context['showCheckboxes']) |
|
600 | - echo ' |
|
642 | + if ($context['showCheckboxes']) { |
|
643 | + echo ' |
|
601 | 644 | <form action="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=showalerts;save" method="post" accept-charset="', $context['character_set'], '" id="mark_all">'; |
645 | + } |
|
602 | 646 | |
603 | 647 | echo ' |
604 | 648 | <table id="alerts" class="table_grid">'; |
@@ -614,9 +658,10 @@ discard block |
||
614 | 658 | <li><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=showalerts;do=remove;aid=', $id, ';', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['delete'], '</a></li> |
615 | 659 | <li><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=showalerts;do=', ($alert['is_read'] != 0 ? 'unread' : 'read'), ';aid=', $id, ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons ', $alert['is_read'] != 0 ? 'unread_button' : 'read_button', '"></span>', ($alert['is_read'] != 0 ? $txt['mark_unread'] : $txt['mark_read_short']), '</a></li>'; |
616 | 660 | |
617 | - if ($context['showCheckboxes']) |
|
618 | - echo ' |
|
661 | + if ($context['showCheckboxes']) { |
|
662 | + echo ' |
|
619 | 663 | <li><input type="checkbox" name="mark[', $id, ']" value="', $id, '"></li>'; |
664 | + } |
|
620 | 665 | |
621 | 666 | echo ' |
622 | 667 | </ul> |
@@ -631,8 +676,8 @@ discard block |
||
631 | 676 | ', $context['pagination'], ' |
632 | 677 | </div>'; |
633 | 678 | |
634 | - if ($context['showCheckboxes']) |
|
635 | - echo ' |
|
679 | + if ($context['showCheckboxes']) { |
|
680 | + echo ' |
|
636 | 681 | <div class="floatright"> |
637 | 682 | ', $txt['check_all'], ': <input type="checkbox" name="select_all" id="select_all"> |
638 | 683 | <select name="mark_as"> |
@@ -643,14 +688,16 @@ discard block |
||
643 | 688 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
644 | 689 | <input type="submit" name="req" value="', $txt['quick_mod_go'], '" class="button you_sure"> |
645 | 690 | </div>'; |
691 | + } |
|
646 | 692 | |
647 | 693 | echo ' |
648 | 694 | </div>'; |
649 | 695 | |
650 | - if ($context['showCheckboxes']) |
|
651 | - echo ' |
|
696 | + if ($context['showCheckboxes']) { |
|
697 | + echo ' |
|
652 | 698 | </form>'; |
653 | 699 | } |
700 | + } |
|
654 | 701 | } |
655 | 702 | |
656 | 703 | /** |
@@ -671,12 +718,12 @@ discard block |
||
671 | 718 | </div>' : ''; |
672 | 719 | |
673 | 720 | // No drafts? Just show an informative message. |
674 | - if (empty($context['drafts'])) |
|
675 | - echo ' |
|
721 | + if (empty($context['drafts'])) { |
|
722 | + echo ' |
|
676 | 723 | <div class="windowbg2 centertext"> |
677 | 724 | ', $txt['draft_none'], ' |
678 | 725 | </div>'; |
679 | - else |
|
726 | + } else |
|
680 | 727 | { |
681 | 728 | // For every draft to be displayed, give it its own div, and show the important details of the draft. |
682 | 729 | foreach ($context['drafts'] as $draft) |
@@ -688,13 +735,15 @@ discard block |
||
688 | 735 | <h5> |
689 | 736 | <strong><a href="', $scripturl, '?board=', $draft['board']['id'], '.0">', $draft['board']['name'], '</a> / ', $draft['topic']['link'], '</strong> '; |
690 | 737 | |
691 | - if (!empty($draft['sticky'])) |
|
692 | - echo ' |
|
738 | + if (!empty($draft['sticky'])) { |
|
739 | + echo ' |
|
693 | 740 | <span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>'; |
741 | + } |
|
694 | 742 | |
695 | - if (!empty($draft['locked'])) |
|
696 | - echo ' |
|
743 | + if (!empty($draft['locked'])) { |
|
744 | + echo ' |
|
697 | 745 | <span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>'; |
746 | + } |
|
698 | 747 | |
699 | 748 | echo ' |
700 | 749 | </h5> |
@@ -727,13 +776,13 @@ discard block |
||
727 | 776 | { |
728 | 777 | global $context, $scripturl, $txt; |
729 | 778 | |
730 | - if (!empty($context['saved_successful'])) |
|
731 | - echo ' |
|
779 | + if (!empty($context['saved_successful'])) { |
|
780 | + echo ' |
|
732 | 781 | <div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>'; |
733 | - |
|
734 | - elseif (!empty($context['saved_failed'])) |
|
735 | - echo ' |
|
782 | + } elseif (!empty($context['saved_failed'])) { |
|
783 | + echo ' |
|
736 | 784 | <div class="errorbox">', $context['saved_failed'], '</div>'; |
785 | + } |
|
737 | 786 | |
738 | 787 | echo ' |
739 | 788 | <div id="edit_buddies"> |
@@ -748,14 +797,16 @@ discard block |
||
748 | 797 | <th scope="col" class="quarter_table">', $txt['name'], '</th> |
749 | 798 | <th scope="col">', $txt['status'], '</th>'; |
750 | 799 | |
751 | - if (allowedTo('moderate_forum')) |
|
752 | - echo ' |
|
800 | + if (allowedTo('moderate_forum')) { |
|
801 | + echo ' |
|
753 | 802 | <th scope="col">', $txt['email'], '</th>'; |
803 | + } |
|
754 | 804 | |
755 | - if (!empty($context['custom_pf'])) |
|
756 | - foreach ($context['custom_pf'] as $column) |
|
805 | + if (!empty($context['custom_pf'])) { |
|
806 | + foreach ($context['custom_pf'] as $column) |
|
757 | 807 | echo ' |
758 | 808 | <th scope="col">', $column['label'], '</th>'; |
809 | + } |
|
759 | 810 | |
760 | 811 | echo ' |
761 | 812 | <th scope="col">', $txt['remove'], '</th> |
@@ -764,13 +815,14 @@ discard block |
||
764 | 815 | <tbody>'; |
765 | 816 | |
766 | 817 | // If they don't have any buddies don't list them! |
767 | - if (empty($context['buddies'])) |
|
768 | - echo ' |
|
818 | + if (empty($context['buddies'])) { |
|
819 | + echo ' |
|
769 | 820 | <tr class="windowbg"> |
770 | 821 | <td colspan="', allowedTo('moderate_forum') ? '10' : '9', '"> |
771 | 822 | <strong>', $txt['no_buddies'], '</strong> |
772 | 823 | </td> |
773 | 824 | </tr>'; |
825 | + } |
|
774 | 826 | |
775 | 827 | // Now loop through each buddy showing info on each. |
776 | 828 | else |
@@ -784,17 +836,19 @@ discard block |
||
784 | 836 | <a href="', $buddy['online']['href'], '"><span class="' . ($buddy['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $buddy['online']['text'] . '"></span></a> |
785 | 837 | </td>'; |
786 | 838 | |
787 | - if ($buddy['show_email']) |
|
788 | - echo ' |
|
839 | + if ($buddy['show_email']) { |
|
840 | + echo ' |
|
789 | 841 | <td> |
790 | 842 | <a href="mailto:' . $buddy['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $buddy['name'] . '"></span></a> |
791 | 843 | </td>'; |
844 | + } |
|
792 | 845 | |
793 | 846 | // Show the custom profile fields for this user. |
794 | - if (!empty($context['custom_pf'])) |
|
795 | - foreach ($context['custom_pf'] as $key => $column) |
|
847 | + if (!empty($context['custom_pf'])) { |
|
848 | + foreach ($context['custom_pf'] as $key => $column) |
|
796 | 849 | echo ' |
797 | 850 | <td class="lefttext">', $buddy['options'][$key], '</td>'; |
851 | + } |
|
798 | 852 | |
799 | 853 | echo ' |
800 | 854 | <td> |
@@ -827,9 +881,10 @@ discard block |
||
827 | 881 | </dl> |
828 | 882 | </div>'; |
829 | 883 | |
830 | - if (!empty($context['token_check'])) |
|
831 | - echo ' |
|
884 | + if (!empty($context['token_check'])) { |
|
885 | + echo ' |
|
832 | 886 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
887 | + } |
|
833 | 888 | |
834 | 889 | echo ' |
835 | 890 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -855,13 +910,13 @@ discard block |
||
855 | 910 | { |
856 | 911 | global $context, $scripturl, $txt; |
857 | 912 | |
858 | - if (!empty($context['saved_successful'])) |
|
859 | - echo ' |
|
913 | + if (!empty($context['saved_successful'])) { |
|
914 | + echo ' |
|
860 | 915 | <div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>'; |
861 | - |
|
862 | - elseif (!empty($context['saved_failed'])) |
|
863 | - echo ' |
|
916 | + } elseif (!empty($context['saved_failed'])) { |
|
917 | + echo ' |
|
864 | 918 | <div class="errorbox">', $context['saved_failed'], '</div>'; |
919 | + } |
|
865 | 920 | |
866 | 921 | echo ' |
867 | 922 | <div id="edit_buddies"> |
@@ -876,9 +931,10 @@ discard block |
||
876 | 931 | <th scope="col" class="quarter_table">', $txt['name'], '</th> |
877 | 932 | <th scope="col">', $txt['status'], '</th>'; |
878 | 933 | |
879 | - if (allowedTo('moderate_forum')) |
|
880 | - echo ' |
|
934 | + if (allowedTo('moderate_forum')) { |
|
935 | + echo ' |
|
881 | 936 | <th scope="col">', $txt['email'], '</th>'; |
937 | + } |
|
882 | 938 | |
883 | 939 | echo ' |
884 | 940 | <th scope="col">', $txt['ignore_remove'], '</th> |
@@ -887,13 +943,14 @@ discard block |
||
887 | 943 | <tbody>'; |
888 | 944 | |
889 | 945 | // If they don't have anyone on their ignore list, don't list it! |
890 | - if (empty($context['ignore_list'])) |
|
891 | - echo ' |
|
946 | + if (empty($context['ignore_list'])) { |
|
947 | + echo ' |
|
892 | 948 | <tr class="windowbg"> |
893 | 949 | <td colspan="', allowedTo('moderate_forum') ? '4' : '3', '"> |
894 | 950 | <strong>', $txt['no_ignore'], '</strong> |
895 | 951 | </td> |
896 | 952 | </tr>'; |
953 | + } |
|
897 | 954 | |
898 | 955 | // Now loop through each buddy showing info on each. |
899 | 956 | foreach ($context['ignore_list'] as $member) |
@@ -905,11 +962,12 @@ discard block |
||
905 | 962 | <a href="', $member['online']['href'], '"><span class="' . ($member['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $member['online']['text'] . '"></span></a> |
906 | 963 | </td>'; |
907 | 964 | |
908 | - if ($member['show_email']) |
|
909 | - echo ' |
|
965 | + if ($member['show_email']) { |
|
966 | + echo ' |
|
910 | 967 | <td> |
911 | 968 | <a href="mailto:' . $member['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $member['name'] . '"></span></a> |
912 | 969 | </td>'; |
970 | + } |
|
913 | 971 | echo ' |
914 | 972 | <td> |
915 | 973 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=lists;sa=ignore;remove=', $member['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['ignore_remove'], '"></span></a> |
@@ -939,9 +997,10 @@ discard block |
||
939 | 997 | </dl> |
940 | 998 | </div>'; |
941 | 999 | |
942 | - if (!empty($context['token_check'])) |
|
943 | - echo ' |
|
1000 | + if (!empty($context['token_check'])) { |
|
1001 | + echo ' |
|
944 | 1002 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
1003 | + } |
|
945 | 1004 | |
946 | 1005 | echo ' |
947 | 1006 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -987,9 +1046,10 @@ discard block |
||
987 | 1046 | <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip'], ';u=', $context['member']['id'], '">', $context['last_ip'], '</a>'; |
988 | 1047 | |
989 | 1048 | // Second address detected? |
990 | - if (!empty($context['last_ip2'])) |
|
991 | - echo ' |
|
1049 | + if (!empty($context['last_ip2'])) { |
|
1050 | + echo ' |
|
992 | 1051 | , <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip2'], ';u=', $context['member']['id'], '">', $context['last_ip2'], '</a>'; |
1052 | + } |
|
993 | 1053 | |
994 | 1054 | echo ' |
995 | 1055 | </dd>'; |
@@ -1055,9 +1115,10 @@ discard block |
||
1055 | 1115 | </div> |
1056 | 1116 | <div class="windowbg2 noup">'; |
1057 | 1117 | |
1058 | - foreach ($context['whois_servers'] as $server) |
|
1059 | - echo ' |
|
1118 | + foreach ($context['whois_servers'] as $server) { |
|
1119 | + echo ' |
|
1060 | 1120 | <a href="', $server['url'], '" target="_blank" rel="noopener"', '>', $server['name'], '</a><br>'; |
1121 | + } |
|
1061 | 1122 | echo ' |
1062 | 1123 | </div> |
1063 | 1124 | <br>'; |
@@ -1069,13 +1130,12 @@ discard block |
||
1069 | 1130 | <h3 class="catbg">', $txt['members_from_ip'], ' ', $context['ip'], '</h3> |
1070 | 1131 | </div>'; |
1071 | 1132 | |
1072 | - if (empty($context['ips'])) |
|
1073 | - echo ' |
|
1133 | + if (empty($context['ips'])) { |
|
1134 | + echo ' |
|
1074 | 1135 | <p class="windowbg2 description"> |
1075 | 1136 | <em>', $txt['no_members_from_ip'], '</em> |
1076 | 1137 | </p>'; |
1077 | - |
|
1078 | - else |
|
1138 | + } else |
|
1079 | 1139 | { |
1080 | 1140 | echo ' |
1081 | 1141 | <table class="table_grid"> |
@@ -1088,12 +1148,13 @@ discard block |
||
1088 | 1148 | <tbody>'; |
1089 | 1149 | |
1090 | 1150 | // Loop through each of the members and display them. |
1091 | - foreach ($context['ips'] as $ip => $memberlist) |
|
1092 | - echo ' |
|
1151 | + foreach ($context['ips'] as $ip => $memberlist) { |
|
1152 | + echo ' |
|
1093 | 1153 | <tr class="windowbg"> |
1094 | 1154 | <td><a href="', $context['base_url'], ';searchip=', $ip, '">', $ip, '</a></td> |
1095 | 1155 | <td>', implode(', ', $memberlist), '</td> |
1096 | 1156 | </tr>'; |
1157 | + } |
|
1097 | 1158 | |
1098 | 1159 | echo ' |
1099 | 1160 | </tbody> |
@@ -1135,11 +1196,10 @@ discard block |
||
1135 | 1196 | </h3> |
1136 | 1197 | </div>'; |
1137 | 1198 | |
1138 | - if ($context['member']['has_all_permissions']) |
|
1139 | - echo ' |
|
1199 | + if ($context['member']['has_all_permissions']) { |
|
1200 | + echo ' |
|
1140 | 1201 | <div class="information">', $txt['showPermissions_all'], '</div>'; |
1141 | - |
|
1142 | - else |
|
1202 | + } else |
|
1143 | 1203 | { |
1144 | 1204 | echo ' |
1145 | 1205 | <div class="information">',$txt['showPermissions_help'], '</div> |
@@ -1154,9 +1214,10 @@ discard block |
||
1154 | 1214 | <div class="windowbg smalltext"> |
1155 | 1215 | ', $txt['showPermissions_restricted_boards_desc'], ':<br>'; |
1156 | 1216 | |
1157 | - foreach ($context['no_access_boards'] as $no_access_board) |
|
1158 | - echo ' |
|
1217 | + foreach ($context['no_access_boards'] as $no_access_board) { |
|
1218 | + echo ' |
|
1159 | 1219 | <a href="', $scripturl, '?board=', $no_access_board['id'], '.0">', $no_access_board['name'], '</a>', $no_access_board['is_last'] ? '' : ', '; |
1220 | + } |
|
1160 | 1221 | echo ' |
1161 | 1222 | </div>'; |
1162 | 1223 | } |
@@ -1188,12 +1249,13 @@ discard block |
||
1188 | 1249 | </td> |
1189 | 1250 | <td class="smalltext">'; |
1190 | 1251 | |
1191 | - if ($permission['is_denied']) |
|
1192 | - echo ' |
|
1252 | + if ($permission['is_denied']) { |
|
1253 | + echo ' |
|
1193 | 1254 | <span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>'; |
1194 | - else |
|
1195 | - echo ' |
|
1255 | + } else { |
|
1256 | + echo ' |
|
1196 | 1257 | ', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']); |
1258 | + } |
|
1197 | 1259 | |
1198 | 1260 | echo ' |
1199 | 1261 | </td> |
@@ -1204,10 +1266,10 @@ discard block |
||
1204 | 1266 | </table> |
1205 | 1267 | </div><!-- .tborder --> |
1206 | 1268 | <br>'; |
1207 | - } |
|
1208 | - else |
|
1209 | - echo ' |
|
1269 | + } else { |
|
1270 | + echo ' |
|
1210 | 1271 | <p class="windowbg2">', $txt['showPermissions_none_general'], '</p>'; |
1272 | + } |
|
1211 | 1273 | |
1212 | 1274 | // Board permission section. |
1213 | 1275 | echo ' |
@@ -1218,14 +1280,16 @@ discard block |
||
1218 | 1280 | <select name="board" onchange="if (this.options[this.selectedIndex].value) this.form.submit();"> |
1219 | 1281 | <option value="0"', $context['board'] == 0 ? ' selected' : '', '>', $txt['showPermissions_global'], '</option>'; |
1220 | 1282 | |
1221 | - if (!empty($context['boards'])) |
|
1222 | - echo ' |
|
1283 | + if (!empty($context['boards'])) { |
|
1284 | + echo ' |
|
1223 | 1285 | <option value="" disabled>---------------------------</option>'; |
1286 | + } |
|
1224 | 1287 | |
1225 | 1288 | // Fill the box with any local permission boards. |
1226 | - foreach ($context['boards'] as $board) |
|
1227 | - echo ' |
|
1289 | + foreach ($context['boards'] as $board) { |
|
1290 | + echo ' |
|
1228 | 1291 | <option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['name'], ' (', $board['profile_name'], ')</option>'; |
1292 | + } |
|
1229 | 1293 | |
1230 | 1294 | echo ' |
1231 | 1295 | </select> |
@@ -1254,13 +1318,13 @@ discard block |
||
1254 | 1318 | </td> |
1255 | 1319 | <td class="smalltext">'; |
1256 | 1320 | |
1257 | - if ($permission['is_denied']) |
|
1258 | - echo ' |
|
1321 | + if ($permission['is_denied']) { |
|
1322 | + echo ' |
|
1259 | 1323 | <span class="alert">', $txt['showPermissions_denied'], ': ', implode(', ', $permission['groups']['denied']), '</span>'; |
1260 | - |
|
1261 | - else |
|
1262 | - echo ' |
|
1324 | + } else { |
|
1325 | + echo ' |
|
1263 | 1326 | ', $txt['showPermissions_given'], ': ', implode(', ', $permission['groups']['allowed']); |
1327 | + } |
|
1264 | 1328 | |
1265 | 1329 | echo ' |
1266 | 1330 | </td> |
@@ -1269,10 +1333,10 @@ discard block |
||
1269 | 1333 | echo ' |
1270 | 1334 | </tbody> |
1271 | 1335 | </table>'; |
1272 | - } |
|
1273 | - else |
|
1274 | - echo ' |
|
1336 | + } else { |
|
1337 | + echo ' |
|
1275 | 1338 | <p class="windowbg2">', $txt['showPermissions_none_board'], '</p>'; |
1339 | + } |
|
1276 | 1340 | echo ' |
1277 | 1341 | </div><!-- #permissions -->'; |
1278 | 1342 | } |
@@ -1313,9 +1377,10 @@ discard block |
||
1313 | 1377 | </div>'; |
1314 | 1378 | |
1315 | 1379 | // If they haven't post at all, don't draw the graph. |
1316 | - if (empty($context['posts_by_time'])) |
|
1317 | - echo ' |
|
1380 | + if (empty($context['posts_by_time'])) { |
|
1381 | + echo ' |
|
1318 | 1382 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1383 | + } |
|
1319 | 1384 | |
1320 | 1385 | // Otherwise do! |
1321 | 1386 | else |
@@ -1324,8 +1389,8 @@ discard block |
||
1324 | 1389 | <ul class="activity_stats flow_hidden">'; |
1325 | 1390 | |
1326 | 1391 | // The labels. |
1327 | - foreach ($context['posts_by_time'] as $time_of_day) |
|
1328 | - echo ' |
|
1392 | + foreach ($context['posts_by_time'] as $time_of_day) { |
|
1393 | + echo ' |
|
1329 | 1394 | <li', $time_of_day['is_last'] ? ' class="last"' : '', '> |
1330 | 1395 | <div class="generic_bar vertical"> |
1331 | 1396 | <div class="bar" style="height: ', (int) $time_of_day['relative_percent'], '%;"> |
@@ -1334,6 +1399,7 @@ discard block |
||
1334 | 1399 | </div> |
1335 | 1400 | <span class="stats_hour">', $time_of_day['hour_format'], '</span> |
1336 | 1401 | </li>'; |
1402 | + } |
|
1337 | 1403 | |
1338 | 1404 | echo ' |
1339 | 1405 | </ul>'; |
@@ -1352,11 +1418,10 @@ discard block |
||
1352 | 1418 | </h3> |
1353 | 1419 | </div>'; |
1354 | 1420 | |
1355 | - if (empty($context['popular_boards'])) |
|
1356 | - echo ' |
|
1421 | + if (empty($context['popular_boards'])) { |
|
1422 | + echo ' |
|
1357 | 1423 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1358 | - |
|
1359 | - else |
|
1424 | + } else |
|
1360 | 1425 | { |
1361 | 1426 | echo ' |
1362 | 1427 | <dl class="stats">'; |
@@ -1386,10 +1451,10 @@ discard block |
||
1386 | 1451 | </h3> |
1387 | 1452 | </div>'; |
1388 | 1453 | |
1389 | - if (empty($context['board_activity'])) |
|
1390 | - echo ' |
|
1454 | + if (empty($context['board_activity'])) { |
|
1455 | + echo ' |
|
1391 | 1456 | <p class="centertext padding">', $txt['statPanel_noPosts'], '</p>'; |
1392 | - else |
|
1457 | + } else |
|
1393 | 1458 | { |
1394 | 1459 | echo ' |
1395 | 1460 | <dl class="stats">'; |
@@ -1440,90 +1505,97 @@ discard block |
||
1440 | 1505 | <h3 class="catbg profile_hd">'; |
1441 | 1506 | |
1442 | 1507 | // Don't say "Profile" if this isn't the profile... |
1443 | - if (!empty($context['profile_header_text'])) |
|
1444 | - echo ' |
|
1508 | + if (!empty($context['profile_header_text'])) { |
|
1509 | + echo ' |
|
1445 | 1510 | ', $context['profile_header_text']; |
1446 | - else |
|
1447 | - echo ' |
|
1511 | + } else { |
|
1512 | + echo ' |
|
1448 | 1513 | ', $txt['profile']; |
1514 | + } |
|
1449 | 1515 | |
1450 | 1516 | echo ' |
1451 | 1517 | </h3> |
1452 | 1518 | </div>'; |
1453 | 1519 | |
1454 | 1520 | // Have we some description? |
1455 | - if ($context['page_desc']) |
|
1456 | - echo ' |
|
1521 | + if ($context['page_desc']) { |
|
1522 | + echo ' |
|
1457 | 1523 | <p class="information">', $context['page_desc'], '</p>'; |
1524 | + } |
|
1458 | 1525 | |
1459 | 1526 | echo ' |
1460 | 1527 | <div class="roundframe">'; |
1461 | 1528 | |
1462 | 1529 | // Any bits at the start? |
1463 | - if (!empty($context['profile_prehtml'])) |
|
1464 | - echo ' |
|
1530 | + if (!empty($context['profile_prehtml'])) { |
|
1531 | + echo ' |
|
1465 | 1532 | <div>', $context['profile_prehtml'], '</div>'; |
1533 | + } |
|
1466 | 1534 | |
1467 | - if (!empty($context['profile_fields'])) |
|
1468 | - echo ' |
|
1535 | + if (!empty($context['profile_fields'])) { |
|
1536 | + echo ' |
|
1469 | 1537 | <dl class="settings">'; |
1538 | + } |
|
1470 | 1539 | |
1471 | 1540 | // Start the big old loop 'of love. |
1472 | 1541 | $lastItem = 'hr'; |
1473 | 1542 | foreach ($context['profile_fields'] as $key => $field) |
1474 | 1543 | { |
1475 | 1544 | // We add a little hack to be sure we never get more than one hr in a row! |
1476 | - if ($lastItem == 'hr' && $field['type'] == 'hr') |
|
1477 | - continue; |
|
1545 | + if ($lastItem == 'hr' && $field['type'] == 'hr') { |
|
1546 | + continue; |
|
1547 | + } |
|
1478 | 1548 | |
1479 | 1549 | $lastItem = $field['type']; |
1480 | - if ($field['type'] == 'hr') |
|
1481 | - echo ' |
|
1550 | + if ($field['type'] == 'hr') { |
|
1551 | + echo ' |
|
1482 | 1552 | </dl> |
1483 | 1553 | <hr> |
1484 | 1554 | <dl class="settings">'; |
1485 | - |
|
1486 | - elseif ($field['type'] == 'callback') |
|
1555 | + } elseif ($field['type'] == 'callback') |
|
1487 | 1556 | { |
1488 | 1557 | if (isset($field['callback_func']) && function_exists('template_profile_' . $field['callback_func'])) |
1489 | 1558 | { |
1490 | 1559 | $callback_func = 'template_profile_' . $field['callback_func']; |
1491 | 1560 | $callback_func(); |
1492 | 1561 | } |
1493 | - } |
|
1494 | - else |
|
1562 | + } else |
|
1495 | 1563 | { |
1496 | 1564 | echo ' |
1497 | 1565 | <dt> |
1498 | 1566 | <strong', !empty($field['is_error']) ? ' class="error"' : '', '>', $field['type'] !== 'label' ? '<label for="' . $key . '">' : '', $field['label'], $field['type'] !== 'label' ? '</label>' : '', '</strong>'; |
1499 | 1567 | |
1500 | 1568 | // Does it have any subtext to show? |
1501 | - if (!empty($field['subtext'])) |
|
1502 | - echo ' |
|
1569 | + if (!empty($field['subtext'])) { |
|
1570 | + echo ' |
|
1503 | 1571 | <br> |
1504 | 1572 | <span class="smalltext">', $field['subtext'], '</span>'; |
1573 | + } |
|
1505 | 1574 | |
1506 | 1575 | echo ' |
1507 | 1576 | </dt> |
1508 | 1577 | <dd>'; |
1509 | 1578 | |
1510 | 1579 | // Want to put something infront of the box? |
1511 | - if (!empty($field['preinput'])) |
|
1512 | - echo ' |
|
1580 | + if (!empty($field['preinput'])) { |
|
1581 | + echo ' |
|
1513 | 1582 | ', $field['preinput']; |
1583 | + } |
|
1514 | 1584 | |
1515 | 1585 | // What type of data are we showing? |
1516 | - if ($field['type'] == 'label') |
|
1517 | - echo ' |
|
1586 | + if ($field['type'] == 'label') { |
|
1587 | + echo ' |
|
1518 | 1588 | ', $field['value']; |
1589 | + } |
|
1519 | 1590 | |
1520 | 1591 | // Maybe it's a text box - very likely! |
1521 | 1592 | elseif (in_array($field['type'], array('int', 'float', 'text', 'password', 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'number', 'time', 'url'))) |
1522 | 1593 | { |
1523 | - if ($field['type'] == 'int' || $field['type'] == 'float') |
|
1524 | - $type = 'number'; |
|
1525 | - else |
|
1526 | - $type = $field['type']; |
|
1594 | + if ($field['type'] == 'int' || $field['type'] == 'float') { |
|
1595 | + $type = 'number'; |
|
1596 | + } else { |
|
1597 | + $type = $field['type']; |
|
1598 | + } |
|
1527 | 1599 | $step = $field['type'] == 'float' ? ' step="0.1"' : ''; |
1528 | 1600 | |
1529 | 1601 | |
@@ -1531,10 +1603,11 @@ discard block |
||
1531 | 1603 | <input type="', $type, '" name="', $key, '" id="', $key, '" size="', empty($field['size']) ? 30 : $field['size'], '" value="', $field['value'], '" ', $field['input_attr'], ' ', $step, '>'; |
1532 | 1604 | } |
1533 | 1605 | // You "checking" me out? ;) |
1534 | - elseif ($field['type'] == 'check') |
|
1535 | - echo ' |
|
1606 | + elseif ($field['type'] == 'check') { |
|
1607 | + echo ' |
|
1536 | 1608 | <input type="hidden" name="', $key, '" value="0"> |
1537 | 1609 | <input type="checkbox" name="', $key, '" id="', $key, '"', !empty($field['value']) ? ' checked' : '', ' value="1" ', $field['input_attr'], '>'; |
1610 | + } |
|
1538 | 1611 | |
1539 | 1612 | // Always fun - select boxes! |
1540 | 1613 | elseif ($field['type'] == 'select') |
@@ -1545,14 +1618,16 @@ discard block |
||
1545 | 1618 | if (isset($field['options'])) |
1546 | 1619 | { |
1547 | 1620 | // Is this some code to generate the options? |
1548 | - if (!is_array($field['options'])) |
|
1549 | - $field['options'] = $field['options'](); |
|
1621 | + if (!is_array($field['options'])) { |
|
1622 | + $field['options'] = $field['options'](); |
|
1623 | + } |
|
1550 | 1624 | |
1551 | 1625 | // Assuming we now have some! |
1552 | - if (is_array($field['options'])) |
|
1553 | - foreach ($field['options'] as $value => $name) |
|
1626 | + if (is_array($field['options'])) { |
|
1627 | + foreach ($field['options'] as $value => $name) |
|
1554 | 1628 | echo ' |
1555 | 1629 | <option', is_numeric($value) ? ' value="" disabled' : ' value="' . $value . '"', $value === $field['value'] ? ' selected' : '', '>', $name, '</option>'; |
1630 | + } |
|
1556 | 1631 | } |
1557 | 1632 | |
1558 | 1633 | echo ' |
@@ -1560,31 +1635,34 @@ discard block |
||
1560 | 1635 | } |
1561 | 1636 | |
1562 | 1637 | // Something to end with? |
1563 | - if (!empty($field['postinput'])) |
|
1564 | - echo ' |
|
1638 | + if (!empty($field['postinput'])) { |
|
1639 | + echo ' |
|
1565 | 1640 | ', $field['postinput']; |
1641 | + } |
|
1566 | 1642 | |
1567 | 1643 | echo ' |
1568 | 1644 | </dd>'; |
1569 | 1645 | } |
1570 | 1646 | } |
1571 | 1647 | |
1572 | - if (!empty($context['profile_fields'])) |
|
1573 | - echo ' |
|
1648 | + if (!empty($context['profile_fields'])) { |
|
1649 | + echo ' |
|
1574 | 1650 | </dl>'; |
1651 | + } |
|
1575 | 1652 | |
1576 | 1653 | // Are there any custom profile fields - if so print them! |
1577 | 1654 | if (!empty($context['custom_fields'])) |
1578 | 1655 | { |
1579 | - if ($lastItem != 'hr') |
|
1580 | - echo ' |
|
1656 | + if ($lastItem != 'hr') { |
|
1657 | + echo ' |
|
1581 | 1658 | <hr>'; |
1659 | + } |
|
1582 | 1660 | |
1583 | 1661 | echo ' |
1584 | 1662 | <dl class="settings">'; |
1585 | 1663 | |
1586 | - foreach ($context['custom_fields'] as $field) |
|
1587 | - echo ' |
|
1664 | + foreach ($context['custom_fields'] as $field) { |
|
1665 | + echo ' |
|
1588 | 1666 | <dt> |
1589 | 1667 | <strong>', $field['name'], ': </strong><br> |
1590 | 1668 | <span class="smalltext">', $field['desc'], '</span> |
@@ -1592,19 +1670,21 @@ discard block |
||
1592 | 1670 | <dd> |
1593 | 1671 | ', $field['input_html'], ' |
1594 | 1672 | </dd>'; |
1673 | + } |
|
1595 | 1674 | |
1596 | 1675 | echo ' |
1597 | 1676 | </dl>'; |
1598 | 1677 | } |
1599 | 1678 | |
1600 | 1679 | // Any closing HTML? |
1601 | - if (!empty($context['profile_posthtml'])) |
|
1602 | - echo ' |
|
1680 | + if (!empty($context['profile_posthtml'])) { |
|
1681 | + echo ' |
|
1603 | 1682 | <div>', $context['profile_posthtml'], '</div>'; |
1683 | + } |
|
1604 | 1684 | |
1605 | 1685 | // Only show the password box if it's actually needed. |
1606 | - if ($context['require_password']) |
|
1607 | - echo ' |
|
1686 | + if ($context['require_password']) { |
|
1687 | + echo ' |
|
1608 | 1688 | <dl class="settings"> |
1609 | 1689 | <dt> |
1610 | 1690 | <strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '><label for="oldpasswrd">', $txt['current_password'], ': </label></strong><br> |
@@ -1614,18 +1694,21 @@ discard block |
||
1614 | 1694 | <input type="password" name="oldpasswrd" id="oldpasswrd" size="20"> |
1615 | 1695 | </dd> |
1616 | 1696 | </dl>'; |
1697 | + } |
|
1617 | 1698 | |
1618 | 1699 | // The button shouldn't say "Change profile" unless we're changing the profile... |
1619 | - if (!empty($context['submit_button_text'])) |
|
1620 | - echo ' |
|
1700 | + if (!empty($context['submit_button_text'])) { |
|
1701 | + echo ' |
|
1621 | 1702 | <input type="submit" name="save" value="', $context['submit_button_text'], '" class="button floatright">'; |
1622 | - else |
|
1623 | - echo ' |
|
1703 | + } else { |
|
1704 | + echo ' |
|
1624 | 1705 | <input type="submit" name="save" value="', $txt['change_profile'], '" class="button floatright">'; |
1706 | + } |
|
1625 | 1707 | |
1626 | - if (!empty($context['token_check'])) |
|
1627 | - echo ' |
|
1708 | + if (!empty($context['token_check'])) { |
|
1709 | + echo ' |
|
1628 | 1710 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
1711 | + } |
|
1629 | 1712 | |
1630 | 1713 | echo ' |
1631 | 1714 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -1635,10 +1718,11 @@ discard block |
||
1635 | 1718 | </form>'; |
1636 | 1719 | |
1637 | 1720 | // Any final spellchecking stuff? |
1638 | - if (!empty($context['show_spellchecking'])) |
|
1639 | - echo ' |
|
1721 | + if (!empty($context['show_spellchecking'])) { |
|
1722 | + echo ' |
|
1640 | 1723 | <form name="spell_form" id="spell_form" method="post" accept-charset="', $context['character_set'], '" target="spellWindow" action="', $scripturl, '?action=spellcheck"><input type="hidden" name="spellstring" value=""></form>'; |
1641 | -} |
|
1724 | + } |
|
1725 | + } |
|
1642 | 1726 | |
1643 | 1727 | /** |
1644 | 1728 | * Personal Message settings. |
@@ -1675,10 +1759,11 @@ discard block |
||
1675 | 1759 | <select name="pm_receive_from" id="pm_receive_from"> |
1676 | 1760 | <option value="0"', empty($context['receive_from']) || (empty($modSettings['enable_buddylist']) && $context['receive_from'] < 3) ? ' selected' : '', '>', $txt['pm_receive_from_everyone'], '</option>'; |
1677 | 1761 | |
1678 | - if (!empty($modSettings['enable_buddylist'])) |
|
1679 | - echo ' |
|
1762 | + if (!empty($modSettings['enable_buddylist'])) { |
|
1763 | + echo ' |
|
1680 | 1764 | <option value="1"', !empty($context['receive_from']) && $context['receive_from'] == 1 ? ' selected' : '', '>', $txt['pm_receive_from_ignore'], '</option> |
1681 | 1765 | <option value="2"', !empty($context['receive_from']) && $context['receive_from'] == 2 ? ' selected' : '', '>', $txt['pm_receive_from_buddies'], '</option>'; |
1766 | + } |
|
1682 | 1767 | |
1683 | 1768 | echo ' |
1684 | 1769 | <option value="3"', !empty($context['receive_from']) && $context['receive_from'] > 2 ? ' selected' : '', '>', $txt['pm_receive_from_admins'], '</option> |
@@ -1721,11 +1806,12 @@ discard block |
||
1721 | 1806 | if (empty($setting) || !is_array($setting)) |
1722 | 1807 | { |
1723 | 1808 | // Insert a separator (unless this is the first item in the list) |
1724 | - if ($i !== $first_option_key) |
|
1725 | - echo ' |
|
1809 | + if ($i !== $first_option_key) { |
|
1810 | + echo ' |
|
1726 | 1811 | </dl> |
1727 | 1812 | <hr> |
1728 | 1813 | <dl class="settings">'; |
1814 | + } |
|
1729 | 1815 | |
1730 | 1816 | // Should we give a name to this section? |
1731 | 1817 | if (is_string($setting) && !empty($setting)) |
@@ -1734,69 +1820,67 @@ discard block |
||
1734 | 1820 | echo ' |
1735 | 1821 | <dt><strong>' . $setting . '</strong></dt> |
1736 | 1822 | <dd></dd>'; |
1823 | + } else { |
|
1824 | + $titled_section = false; |
|
1737 | 1825 | } |
1738 | - else |
|
1739 | - $titled_section = false; |
|
1740 | 1826 | |
1741 | 1827 | continue; |
1742 | 1828 | } |
1743 | 1829 | |
1744 | 1830 | // Is this disabled? |
1745 | - if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) |
|
1746 | - continue; |
|
1747 | - |
|
1748 | - elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) |
|
1749 | - continue; |
|
1750 | - |
|
1751 | - elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) |
|
1752 | - continue; |
|
1753 | - |
|
1754 | - elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) |
|
1755 | - continue; |
|
1756 | - |
|
1757 | - elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) |
|
1758 | - continue; |
|
1759 | - |
|
1760 | - elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) |
|
1761 | - continue; |
|
1762 | - |
|
1763 | - elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) |
|
1764 | - continue; |
|
1831 | + if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) { |
|
1832 | + continue; |
|
1833 | + } elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) { |
|
1834 | + continue; |
|
1835 | + } elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) { |
|
1836 | + continue; |
|
1837 | + } elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) { |
|
1838 | + continue; |
|
1839 | + } elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) { |
|
1840 | + continue; |
|
1841 | + } elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) { |
|
1842 | + continue; |
|
1843 | + } elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) { |
|
1844 | + continue; |
|
1845 | + } |
|
1765 | 1846 | |
1766 | 1847 | // Some of these may not be set... Set to defaults here |
1767 | 1848 | $opts = array('topics_per_page', 'messages_per_page', 'display_quick_mod'); |
1768 | - if (in_array($setting['id'], $opts) && !isset($context['member']['options'][$setting['id']])) |
|
1769 | - $context['member']['options'][$setting['id']] = 0; |
|
1770 | - |
|
1771 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
1772 | - $setting['type'] = 'checkbox'; |
|
1773 | - |
|
1774 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
1775 | - $setting['type'] = 'number'; |
|
1849 | + if (in_array($setting['id'], $opts) && !isset($context['member']['options'][$setting['id']])) { |
|
1850 | + $context['member']['options'][$setting['id']] = 0; |
|
1851 | + } |
|
1776 | 1852 | |
1777 | - elseif ($setting['type'] == 'string') |
|
1778 | - $setting['type'] = 'text'; |
|
1853 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
1854 | + $setting['type'] = 'checkbox'; |
|
1855 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
1856 | + $setting['type'] = 'number'; |
|
1857 | + } elseif ($setting['type'] == 'string') { |
|
1858 | + $setting['type'] = 'text'; |
|
1859 | + } |
|
1779 | 1860 | |
1780 | - if (isset($setting['options'])) |
|
1781 | - $setting['type'] = 'list'; |
|
1861 | + if (isset($setting['options'])) { |
|
1862 | + $setting['type'] = 'list'; |
|
1863 | + } |
|
1782 | 1864 | |
1783 | 1865 | echo ' |
1784 | 1866 | <dt> |
1785 | 1867 | <label for="', $setting['id'], '">', !$titled_section ? '<strong>' : '', $setting['label'], !$titled_section ? '</strong>' : '', '</label>'; |
1786 | 1868 | |
1787 | - if (isset($setting['description'])) |
|
1788 | - echo ' |
|
1869 | + if (isset($setting['description'])) { |
|
1870 | + echo ' |
|
1789 | 1871 | <br> |
1790 | 1872 | <span class="smalltext">', $setting['description'], '</span>'; |
1873 | + } |
|
1791 | 1874 | echo ' |
1792 | 1875 | </dt> |
1793 | 1876 | <dd>'; |
1794 | 1877 | |
1795 | 1878 | // Display checkbox options |
1796 | - if ($setting['type'] == 'checkbox') |
|
1797 | - echo ' |
|
1879 | + if ($setting['type'] == 'checkbox') { |
|
1880 | + echo ' |
|
1798 | 1881 | <input type="hidden" name="default_options[' . $setting['id'] . ']" value="0"> |
1799 | 1882 | <input type="checkbox" name="default_options[', $setting['id'], ']" id="', $setting['id'], '"', !empty($context['member']['options'][$setting['id']]) ? ' checked' : '', ' value="1">'; |
1883 | + } |
|
1800 | 1884 | |
1801 | 1885 | // How about selection lists, we all love them |
1802 | 1886 | elseif ($setting['type'] == 'list') |
@@ -1804,9 +1888,10 @@ discard block |
||
1804 | 1888 | echo ' |
1805 | 1889 | <select name="default_options[', $setting['id'], ']" id="', $setting['id'], '"', '>'; |
1806 | 1890 | |
1807 | - foreach ($setting['options'] as $value => $label) |
|
1808 | - echo ' |
|
1891 | + foreach ($setting['options'] as $value => $label) { |
|
1892 | + echo ' |
|
1809 | 1893 | <option value="', $value, '"', $value == $context['member']['options'][$setting['id']] ? ' selected' : '', '>', $label, '</option>'; |
1894 | + } |
|
1810 | 1895 | |
1811 | 1896 | echo ' |
1812 | 1897 | </select>'; |
@@ -1822,14 +1907,13 @@ discard block |
||
1822 | 1907 | |
1823 | 1908 | echo ' |
1824 | 1909 | <input type="number"', $min . $max . $step; |
1825 | - } |
|
1826 | - elseif (isset($setting['type']) && $setting['type'] == 'url') |
|
1827 | - echo' |
|
1910 | + } elseif (isset($setting['type']) && $setting['type'] == 'url') { |
|
1911 | + echo' |
|
1828 | 1912 | <input type="url"'; |
1829 | - |
|
1830 | - else |
|
1831 | - echo ' |
|
1913 | + } else { |
|
1914 | + echo ' |
|
1832 | 1915 | <input type="text"'; |
1916 | + } |
|
1833 | 1917 | |
1834 | 1918 | echo ' name="default_options[', $setting['id'], ']" id="', $setting['id'], '" value="', isset($context['member']['options'][$setting['id']]) ? $context['member']['options'][$setting['id']] : $setting['value'], '"', $setting['type'] == 'number' ? ' size="5"' : '', '>'; |
1835 | 1919 | } |
@@ -1866,8 +1950,8 @@ discard block |
||
1866 | 1950 | <dl class="settings">'; |
1867 | 1951 | |
1868 | 1952 | // Allow notification on announcements to be disabled? |
1869 | - if (!empty($modSettings['allow_disableAnnounce'])) |
|
1870 | - echo ' |
|
1953 | + if (!empty($modSettings['allow_disableAnnounce'])) { |
|
1954 | + echo ' |
|
1871 | 1955 | <dt> |
1872 | 1956 | <label for="notify_announcements">', $txt['notify_important_email'], '</label> |
1873 | 1957 | </dt> |
@@ -1875,15 +1959,17 @@ discard block |
||
1875 | 1959 | <input type="hidden" name="notify_announcements" value="0"> |
1876 | 1960 | <input type="checkbox" id="notify_announcements" name="notify_announcements" value="1"', !empty($context['member']['notify_announcements']) ? ' checked' : '', '> |
1877 | 1961 | </dd>'; |
1962 | + } |
|
1878 | 1963 | |
1879 | - if (!empty($modSettings['enable_ajax_alerts'])) |
|
1880 | - echo ' |
|
1964 | + if (!empty($modSettings['enable_ajax_alerts'])) { |
|
1965 | + echo ' |
|
1881 | 1966 | <dt> |
1882 | 1967 | <label for="notify_send_body">', $txt['notify_alert_timeout'], '</label> |
1883 | 1968 | </dt> |
1884 | 1969 | <dd> |
1885 | 1970 | <input type="number" size="4" id="notify_alert_timeout" name="opt_alert_timeout" min="0" value="', $context['member']['alert_timeout'], '"> |
1886 | 1971 | </dd>'; |
1972 | + } |
|
1887 | 1973 | |
1888 | 1974 | echo ' |
1889 | 1975 | </dl> |
@@ -1915,9 +2001,10 @@ discard block |
||
1915 | 2001 | |
1916 | 2002 | $label = $txt['alert_opt_' . $opts[1]]; |
1917 | 2003 | $label_pos = isset($opts['label']) ? $opts['label'] : ''; |
1918 | - if ($label_pos == 'before') |
|
1919 | - echo ' |
|
2004 | + if ($label_pos == 'before') { |
|
2005 | + echo ' |
|
1920 | 2006 | <label for="opt_', $opts[1], '">', $label, '</label>'; |
2007 | + } |
|
1921 | 2008 | |
1922 | 2009 | $this_value = isset($context['alert_prefs'][$opts[1]]) ? $context['alert_prefs'][$opts[1]] : 0; |
1923 | 2010 | switch ($opts[0]) |
@@ -1931,17 +2018,19 @@ discard block |
||
1931 | 2018 | echo ' |
1932 | 2019 | <select name="opt_', $opts[1], '" id="opt_', $opts[1], '">'; |
1933 | 2020 | |
1934 | - foreach ($opts['opts'] as $k => $v) |
|
1935 | - echo ' |
|
2021 | + foreach ($opts['opts'] as $k => $v) { |
|
2022 | + echo ' |
|
1936 | 2023 | <option value="', $k, '"', $this_value == $k ? ' selected' : '', '>', $v, '</option>'; |
2024 | + } |
|
1937 | 2025 | echo ' |
1938 | 2026 | </select>'; |
1939 | 2027 | break; |
1940 | 2028 | } |
1941 | 2029 | |
1942 | - if ($label_pos == 'after') |
|
1943 | - echo ' |
|
2030 | + if ($label_pos == 'after') { |
|
2031 | + echo ' |
|
1944 | 2032 | <label for="opt_', $opts[1], '">', $label, '</label>'; |
2033 | + } |
|
1945 | 2034 | |
1946 | 2035 | echo ' |
1947 | 2036 | </td> |
@@ -2058,11 +2147,12 @@ discard block |
||
2058 | 2147 | <p class="information">', $txt['groupMembership_info'], '</p>'; |
2059 | 2148 | |
2060 | 2149 | // Do we have an update message? |
2061 | - if (!empty($context['update_message'])) |
|
2062 | - echo ' |
|
2150 | + if (!empty($context['update_message'])) { |
|
2151 | + echo ' |
|
2063 | 2152 | <div class="infobox"> |
2064 | 2153 | ', $context['update_message'], '. |
2065 | 2154 | </div>'; |
2155 | + } |
|
2066 | 2156 | |
2067 | 2157 | echo ' |
2068 | 2158 | <div id="groups">'; |
@@ -2084,8 +2174,7 @@ discard block |
||
2084 | 2174 | </div> |
2085 | 2175 | </div> |
2086 | 2176 | </div><!-- .groupmembership -->'; |
2087 | - } |
|
2088 | - else |
|
2177 | + } else |
|
2089 | 2178 | { |
2090 | 2179 | echo ' |
2091 | 2180 | <div class="title_bar"> |
@@ -2097,27 +2186,30 @@ discard block |
||
2097 | 2186 | echo ' |
2098 | 2187 | <div class="windowbg" id="primdiv_', $group['id'], '">'; |
2099 | 2188 | |
2100 | - if ($context['can_edit_primary']) |
|
2101 | - echo ' |
|
2189 | + if ($context['can_edit_primary']) { |
|
2190 | + echo ' |
|
2102 | 2191 | <input type="radio" name="primary" id="primary_', $group['id'], '" value="', $group['id'], '"', $group['is_primary'] ? ' checked' : '', ' onclick="highlightSelected(\'primdiv_' . $group['id'] . '\');"', $group['can_be_primary'] ? '' : ' disabled', '>'; |
2192 | + } |
|
2103 | 2193 | |
2104 | 2194 | echo ' |
2105 | 2195 | <label for="primary_', $group['id'], '"><strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '</label>'; |
2106 | 2196 | |
2107 | 2197 | // Can they leave their group? |
2108 | - if ($group['can_leave']) |
|
2109 | - echo ' |
|
2198 | + if ($group['can_leave']) { |
|
2199 | + echo ' |
|
2110 | 2200 | <a href="' . $scripturl . '?action=profile;save;u=' . $context['id_member'] . ';area=groupmembership;' . $context['session_var'] . '=' . $context['session_id'] . ';gid=' . $group['id'] . ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '">' . $txt['leave_group'] . '</a>'; |
2201 | + } |
|
2111 | 2202 | |
2112 | 2203 | echo ' |
2113 | 2204 | </div><!-- .windowbg -->'; |
2114 | 2205 | } |
2115 | 2206 | |
2116 | - if ($context['can_edit_primary']) |
|
2117 | - echo ' |
|
2207 | + if ($context['can_edit_primary']) { |
|
2208 | + echo ' |
|
2118 | 2209 | <div class="padding righttext"> |
2119 | 2210 | <input type="submit" value="', $txt['make_primary'], '" class="button"> |
2120 | 2211 | </div>'; |
2212 | + } |
|
2121 | 2213 | |
2122 | 2214 | // Any groups they can join? |
2123 | 2215 | if (!empty($context['groups']['available'])) |
@@ -2133,17 +2225,16 @@ discard block |
||
2133 | 2225 | <div class="windowbg"> |
2134 | 2226 | <strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), ''; |
2135 | 2227 | |
2136 | - if ($group['type'] == 3) |
|
2137 | - echo ' |
|
2228 | + if ($group['type'] == 3) { |
|
2229 | + echo ' |
|
2138 | 2230 | <a href="', $scripturl, '?action=profile;save;u=', $context['id_member'], ';area=groupmembership;', $context['session_var'], '=', $context['session_id'], ';gid=', $group['id'], ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '" class="button floatright">', $txt['join_group'], '</a>'; |
2139 | - |
|
2140 | - elseif ($group['type'] == 2 && $group['pending']) |
|
2141 | - echo ' |
|
2231 | + } elseif ($group['type'] == 2 && $group['pending']) { |
|
2232 | + echo ' |
|
2142 | 2233 | <span class="floatright">', $txt['approval_pending'], '</span>'; |
2143 | - |
|
2144 | - elseif ($group['type'] == 2) |
|
2145 | - echo ' |
|
2234 | + } elseif ($group['type'] == 2) { |
|
2235 | + echo ' |
|
2146 | 2236 | <a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=groupmembership;request=', $group['id'], '" class="button floatright">', $txt['request_group'], '</a>'; |
2237 | + } |
|
2147 | 2238 | |
2148 | 2239 | echo ' |
2149 | 2240 | </div><!-- .windowbg -->'; |
@@ -2166,9 +2257,10 @@ discard block |
||
2166 | 2257 | |
2167 | 2258 | prevDiv.className = "windowbg"; |
2168 | 2259 | }'; |
2169 | - if (isset($context['groups']['member'][$context['primary_group']])) |
|
2170 | - echo ' |
|
2260 | + if (isset($context['groups']['member'][$context['primary_group']])) { |
|
2261 | + echo ' |
|
2171 | 2262 | highlightSelected("primdiv_' . $context['primary_group'] . '");'; |
2263 | + } |
|
2172 | 2264 | |
2173 | 2265 | echo ' |
2174 | 2266 | </script>'; |
@@ -2177,9 +2269,10 @@ discard block |
||
2177 | 2269 | echo ' |
2178 | 2270 | </div><!-- #groups -->'; |
2179 | 2271 | |
2180 | - if (!empty($context['token_check'])) |
|
2181 | - echo ' |
|
2272 | + if (!empty($context['token_check'])) { |
|
2273 | + echo ' |
|
2182 | 2274 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2275 | + } |
|
2183 | 2276 | |
2184 | 2277 | echo ' |
2185 | 2278 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2227,14 +2320,15 @@ discard block |
||
2227 | 2320 | |
2228 | 2321 | foreach ($category['boards'] as $board) |
2229 | 2322 | { |
2230 | - if ($i == $limit) |
|
2231 | - echo ' |
|
2323 | + if ($i == $limit) { |
|
2324 | + echo ' |
|
2232 | 2325 | </ul> |
2233 | 2326 | </li> |
2234 | 2327 | </ul> |
2235 | 2328 | <ul class="ignoreboards floatright"> |
2236 | 2329 | <li class="category"> |
2237 | 2330 | <ul>'; |
2331 | + } |
|
2238 | 2332 | |
2239 | 2333 | echo ' |
2240 | 2334 | <li class="board" style="margin-', $context['right_to_left'] ? 'right' : 'left', ': ', $board['child_level'], 'em;"> |
@@ -2279,10 +2373,11 @@ discard block |
||
2279 | 2373 | |
2280 | 2374 | // Work out the starting warning. |
2281 | 2375 | $context['current_warning_mode'] = $context['warning_mode'][0]; |
2282 | - foreach ($context['warning_mode'] as $limit => $warning) |
|
2283 | - if ($context['member']['warning'] >= $limit) |
|
2376 | + foreach ($context['warning_mode'] as $limit => $warning) { |
|
2377 | + if ($context['member']['warning'] >= $limit) |
|
2284 | 2378 | $context['current_warning_mode'] = $warning; |
2285 | -} |
|
2379 | + } |
|
2380 | + } |
|
2286 | 2381 | |
2287 | 2382 | // Show all warnings of a user? |
2288 | 2383 | function template_viewWarning() |
@@ -2317,14 +2412,15 @@ discard block |
||
2317 | 2412 | </dd>'; |
2318 | 2413 | |
2319 | 2414 | // There's some impact of this? |
2320 | - if (!empty($context['level_effects'][$context['current_level']])) |
|
2321 | - echo ' |
|
2415 | + if (!empty($context['level_effects'][$context['current_level']])) { |
|
2416 | + echo ' |
|
2322 | 2417 | <dt> |
2323 | 2418 | <strong>', $txt['profile_viewwarning_impact'], ':</strong> |
2324 | 2419 | </dt> |
2325 | 2420 | <dd> |
2326 | 2421 | ', $context['level_effects'][$context['current_level']], ' |
2327 | 2422 | </dd>'; |
2423 | + } |
|
2328 | 2424 | |
2329 | 2425 | echo ' |
2330 | 2426 | </dl> |
@@ -2362,10 +2458,11 @@ discard block |
||
2362 | 2458 | |
2363 | 2459 | // Otherwise see what we can do...'; |
2364 | 2460 | |
2365 | - foreach ($context['notification_templates'] as $k => $type) |
|
2366 | - echo ' |
|
2461 | + foreach ($context['notification_templates'] as $k => $type) { |
|
2462 | + echo ' |
|
2367 | 2463 | if (index == ', $k, ') |
2368 | 2464 | document.getElementById(\'warn_body\').value = "', strtr($type['body'], array('"' => "'", "\n" => '\\n', "\r" => '')), '";'; |
2465 | + } |
|
2369 | 2466 | |
2370 | 2467 | echo ' |
2371 | 2468 | } |
@@ -2375,10 +2472,11 @@ discard block |
||
2375 | 2472 | // Also set the right effect. |
2376 | 2473 | effectText = "";'; |
2377 | 2474 | |
2378 | - foreach ($context['level_effects'] as $limit => $text) |
|
2379 | - echo ' |
|
2475 | + foreach ($context['level_effects'] as $limit => $text) { |
|
2476 | + echo ' |
|
2380 | 2477 | if (slideAmount >= ', $limit, ') |
2381 | 2478 | effectText = "', $text, '";'; |
2479 | + } |
|
2382 | 2480 | |
2383 | 2481 | echo ' |
2384 | 2482 | setInnerHTML(document.getElementById(\'cur_level_div\'), slideAmount + \'% (\' + effectText + \')\'); |
@@ -2393,32 +2491,35 @@ discard block |
||
2393 | 2491 | </h3> |
2394 | 2492 | </div>'; |
2395 | 2493 | |
2396 | - if (!$context['user']['is_owner']) |
|
2397 | - echo ' |
|
2494 | + if (!$context['user']['is_owner']) { |
|
2495 | + echo ' |
|
2398 | 2496 | <p class="information">', $txt['profile_warning_desc'], '</p>'; |
2497 | + } |
|
2399 | 2498 | |
2400 | 2499 | echo ' |
2401 | 2500 | <div class="windowbg"> |
2402 | 2501 | <dl class="settings">'; |
2403 | 2502 | |
2404 | - if (!$context['user']['is_owner']) |
|
2405 | - echo ' |
|
2503 | + if (!$context['user']['is_owner']) { |
|
2504 | + echo ' |
|
2406 | 2505 | <dt> |
2407 | 2506 | <strong>', $txt['profile_warning_name'], ':</strong> |
2408 | 2507 | </dt> |
2409 | 2508 | <dd> |
2410 | 2509 | <strong>', $context['member']['name'], '</strong> |
2411 | 2510 | </dd>'; |
2511 | + } |
|
2412 | 2512 | |
2413 | 2513 | echo ' |
2414 | 2514 | <dt> |
2415 | 2515 | <strong>', $txt['profile_warning_level'], ':</strong>'; |
2416 | 2516 | |
2417 | 2517 | // Is there only so much they can apply? |
2418 | - if ($context['warning_limit']) |
|
2419 | - echo ' |
|
2518 | + if ($context['warning_limit']) { |
|
2519 | + echo ' |
|
2420 | 2520 | <br> |
2421 | 2521 | <span class="smalltext">', sprintf($txt['profile_warning_limit_attribute'], $context['warning_limit']), '</span>'; |
2522 | + } |
|
2422 | 2523 | |
2423 | 2524 | echo ' |
2424 | 2525 | </dt> |
@@ -2473,9 +2574,10 @@ discard block |
||
2473 | 2574 | <option value="-1">', $txt['profile_warning_notify_template'], '</option> |
2474 | 2575 | <option value="-1" disabled>------------------------------</option>'; |
2475 | 2576 | |
2476 | - foreach ($context['notification_templates'] as $id_template => $template) |
|
2477 | - echo ' |
|
2577 | + foreach ($context['notification_templates'] as $id_template => $template) { |
|
2578 | + echo ' |
|
2478 | 2579 | <option value="', $id_template, '">', $template['title'], '</option>'; |
2580 | + } |
|
2479 | 2581 | |
2480 | 2582 | echo ' |
2481 | 2583 | </select> |
@@ -2488,9 +2590,10 @@ discard block |
||
2488 | 2590 | </dl> |
2489 | 2591 | <div class="righttext">'; |
2490 | 2592 | |
2491 | - if (!empty($context['token_check'])) |
|
2492 | - echo ' |
|
2593 | + if (!empty($context['token_check'])) { |
|
2594 | + echo ' |
|
2493 | 2595 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2596 | + } |
|
2494 | 2597 | |
2495 | 2598 | echo ' |
2496 | 2599 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2506,8 +2609,8 @@ discard block |
||
2506 | 2609 | echo ' |
2507 | 2610 | <script>'; |
2508 | 2611 | |
2509 | - if (!$context['user']['is_owner']) |
|
2510 | - echo ' |
|
2612 | + if (!$context['user']['is_owner']) { |
|
2613 | + echo ' |
|
2511 | 2614 | modifyWarnNotify(); |
2512 | 2615 | $(document).ready(function() { |
2513 | 2616 | $("#preview_button").click(function() { |
@@ -2546,6 +2649,7 @@ discard block |
||
2546 | 2649 | }); |
2547 | 2650 | return false; |
2548 | 2651 | }'; |
2652 | + } |
|
2549 | 2653 | |
2550 | 2654 | echo ' |
2551 | 2655 | </script>'; |
@@ -2568,17 +2672,19 @@ discard block |
||
2568 | 2672 | </div>'; |
2569 | 2673 | |
2570 | 2674 | // If deleting another account give them a lovely info box. |
2571 | - if (!$context['user']['is_owner']) |
|
2572 | - echo ' |
|
2675 | + if (!$context['user']['is_owner']) { |
|
2676 | + echo ' |
|
2573 | 2677 | <p class="information">', $txt['deleteAccount_desc'], '</p>'; |
2678 | + } |
|
2574 | 2679 | |
2575 | 2680 | echo ' |
2576 | 2681 | <div class="windowbg2">'; |
2577 | 2682 | |
2578 | 2683 | // If they are deleting their account AND the admin needs to approve it - give them another piece of info ;) |
2579 | - if ($context['needs_approval']) |
|
2580 | - echo ' |
|
2684 | + if ($context['needs_approval']) { |
|
2685 | + echo ' |
|
2581 | 2686 | <div class="errorbox">', $txt['deleteAccount_approval'], '</div>'; |
2687 | + } |
|
2582 | 2688 | |
2583 | 2689 | // If the user is deleting their own account warn them first - and require a password! |
2584 | 2690 | if ($context['user']['is_owner']) |
@@ -2590,9 +2696,10 @@ discard block |
||
2590 | 2696 | <input type="password" name="oldpasswrd" size="20"> |
2591 | 2697 | <input type="submit" value="', $txt['yes'], '" class="button">'; |
2592 | 2698 | |
2593 | - if (!empty($context['token_check'])) |
|
2594 | - echo ' |
|
2699 | + if (!empty($context['token_check'])) { |
|
2700 | + echo ' |
|
2595 | 2701 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2702 | + } |
|
2596 | 2703 | |
2597 | 2704 | echo ' |
2598 | 2705 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2622,10 +2729,11 @@ discard block |
||
2622 | 2729 | <option value="topics">', $txt['deleteAccount_topics'], '</option> |
2623 | 2730 | </select>'; |
2624 | 2731 | |
2625 | - if ($context['show_perma_delete']) |
|
2626 | - echo ' |
|
2732 | + if ($context['show_perma_delete']) { |
|
2733 | + echo ' |
|
2627 | 2734 | <br> |
2628 | 2735 | <label for="perma_delete"><input type="checkbox" name="perma_delete" id="perma_delete" value="1">', $txt['deleteAccount_permanent'], ':</label>'; |
2736 | + } |
|
2629 | 2737 | |
2630 | 2738 | echo ' |
2631 | 2739 | </div>'; |
@@ -2638,9 +2746,10 @@ discard block |
||
2638 | 2746 | <div> |
2639 | 2747 | <input type="submit" value="', $txt['delete'], '" class="button">'; |
2640 | 2748 | |
2641 | - if (!empty($context['token_check'])) |
|
2642 | - echo ' |
|
2749 | + if (!empty($context['token_check'])) { |
|
2750 | + echo ' |
|
2643 | 2751 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2752 | + } |
|
2644 | 2753 | |
2645 | 2754 | echo ' |
2646 | 2755 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -2666,8 +2775,8 @@ discard block |
||
2666 | 2775 | <hr>'; |
2667 | 2776 | |
2668 | 2777 | // Only show the password box if it's actually needed. |
2669 | - if ($context['require_password']) |
|
2670 | - echo ' |
|
2778 | + if ($context['require_password']) { |
|
2779 | + echo ' |
|
2671 | 2780 | <dl class="settings"> |
2672 | 2781 | <dt> |
2673 | 2782 | <strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '>', $txt['current_password'], ': </strong><br> |
@@ -2677,13 +2786,15 @@ discard block |
||
2677 | 2786 | <input type="password" name="oldpasswrd" size="20"> |
2678 | 2787 | </dd> |
2679 | 2788 | </dl>'; |
2789 | + } |
|
2680 | 2790 | |
2681 | 2791 | echo ' |
2682 | 2792 | <div class="righttext">'; |
2683 | 2793 | |
2684 | - if (!empty($context['token_check'])) |
|
2685 | - echo ' |
|
2794 | + if (!empty($context['token_check'])) { |
|
2795 | + echo ' |
|
2686 | 2796 | <input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">'; |
2797 | + } |
|
2687 | 2798 | |
2688 | 2799 | echo ' |
2689 | 2800 | <input type="submit" value="', $txt['change_profile'], '" class="button"> |
@@ -2710,9 +2821,10 @@ discard block |
||
2710 | 2821 | <ul id="list_errors">'; |
2711 | 2822 | |
2712 | 2823 | // Cycle through each error and display an error message. |
2713 | - foreach ($context['post_errors'] as $error) |
|
2714 | - echo ' |
|
2824 | + foreach ($context['post_errors'] as $error) { |
|
2825 | + echo ' |
|
2715 | 2826 | <li>', isset($txt['profile_error_' . $error]) ? $txt['profile_error_' . $error] : $error, '</li>'; |
2827 | + } |
|
2716 | 2828 | |
2717 | 2829 | echo ' |
2718 | 2830 | </ul>'; |
@@ -2738,12 +2850,13 @@ discard block |
||
2738 | 2850 | <select name="id_group" ', ($context['user']['is_owner'] && $context['member']['group_id'] == 1 ? 'onchange="if (this.value != 1 && !confirm(\'' . $txt['deadmin_confirm'] . '\')) this.value = 1;"' : ''), '>'; |
2739 | 2851 | |
2740 | 2852 | // Fill the select box with all primary member groups that can be assigned to a member. |
2741 | - foreach ($context['member_groups'] as $member_group) |
|
2742 | - if (!empty($member_group['can_be_primary'])) |
|
2853 | + foreach ($context['member_groups'] as $member_group) { |
|
2854 | + if (!empty($member_group['can_be_primary'])) |
|
2743 | 2855 | echo ' |
2744 | 2856 | <option value="', $member_group['id'], '"', $member_group['is_primary'] ? ' selected' : '', '> |
2745 | 2857 | ', $member_group['name'], ' |
2746 | 2858 | </option>'; |
2859 | + } |
|
2747 | 2860 | |
2748 | 2861 | echo ' |
2749 | 2862 | </select> |
@@ -2756,10 +2869,11 @@ discard block |
||
2756 | 2869 | <input type="hidden" name="additional_groups[]" value="0">'; |
2757 | 2870 | |
2758 | 2871 | // For each membergroup show a checkbox so members can be assigned to more than one group. |
2759 | - foreach ($context['member_groups'] as $member_group) |
|
2760 | - if ($member_group['can_be_additional']) |
|
2872 | + foreach ($context['member_groups'] as $member_group) { |
|
2873 | + if ($member_group['can_be_additional']) |
|
2761 | 2874 | echo ' |
2762 | 2875 | <label for="additional_groups-', $member_group['id'], '"><input type="checkbox" name="additional_groups[]" value="', $member_group['id'], '" id="additional_groups-', $member_group['id'], '"', $member_group['is_additional'] ? ' checked' : '', '> ', $member_group['name'], '</label><br>'; |
2876 | + } |
|
2763 | 2877 | |
2764 | 2878 | echo ' |
2765 | 2879 | </span> |
@@ -2819,9 +2933,10 @@ discard block |
||
2819 | 2933 | <span class="smalltext">', $txt['sig_info'], '</span><br> |
2820 | 2934 | <br>'; |
2821 | 2935 | |
2822 | - if ($context['show_spellchecking']) |
|
2823 | - echo ' |
|
2936 | + if ($context['show_spellchecking']) { |
|
2937 | + echo ' |
|
2824 | 2938 | <input type="button" value="', $txt['spell_check'], '" onclick="spellCheck(\'creator\', \'signature\');" class="button">'; |
2939 | + } |
|
2825 | 2940 | |
2826 | 2941 | echo ' |
2827 | 2942 | </dt> |
@@ -2829,17 +2944,20 @@ discard block |
||
2829 | 2944 | <textarea class="editor" onkeyup="calcCharLeft();" id="signature" name="signature" rows="5" cols="50">', $context['member']['signature'], '</textarea><br>'; |
2830 | 2945 | |
2831 | 2946 | // If there is a limit at all! |
2832 | - if (!empty($context['signature_limits']['max_length'])) |
|
2833 | - echo ' |
|
2947 | + if (!empty($context['signature_limits']['max_length'])) { |
|
2948 | + echo ' |
|
2834 | 2949 | <span class="smalltext">', sprintf($txt['max_sig_characters'], $context['signature_limits']['max_length']), ' <span id="signatureLeft">', $context['signature_limits']['max_length'], '</span></span><br>'; |
2950 | + } |
|
2835 | 2951 | |
2836 | - if (!empty($context['show_preview_button'])) |
|
2837 | - echo ' |
|
2952 | + if (!empty($context['show_preview_button'])) { |
|
2953 | + echo ' |
|
2838 | 2954 | <input type="button" name="preview_signature" id="preview_button" value="', $txt['preview_signature'], '" class="button floatright">'; |
2955 | + } |
|
2839 | 2956 | |
2840 | - if ($context['signature_warning']) |
|
2841 | - echo ' |
|
2957 | + if ($context['signature_warning']) { |
|
2958 | + echo ' |
|
2842 | 2959 | <span class="smalltext">', $context['signature_warning'], '</span>'; |
2960 | + } |
|
2843 | 2961 | |
2844 | 2962 | // Some javascript used to count how many characters have been used so far in the signature. |
2845 | 2963 | echo ' |
@@ -2870,38 +2988,43 @@ discard block |
||
2870 | 2988 | <label for="avatar_upload_box">', $txt['personal_picture'], '</label> |
2871 | 2989 | </strong>'; |
2872 | 2990 | |
2873 | - if (empty($modSettings['gravatarOverride'])) |
|
2874 | - echo ' |
|
2991 | + if (empty($modSettings['gravatarOverride'])) { |
|
2992 | + echo ' |
|
2875 | 2993 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_none" value="none"' . ($context['member']['avatar']['choice'] == 'none' ? ' checked="checked"' : '') . '> |
2876 | 2994 | <label for="avatar_choice_none"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '> |
2877 | 2995 | ' . $txt['no_avatar'] . ' |
2878 | 2996 | </label><br>'; |
2997 | + } |
|
2879 | 2998 | |
2880 | - if (!empty($context['member']['avatar']['allow_server_stored'])) |
|
2881 | - echo ' |
|
2999 | + if (!empty($context['member']['avatar']['allow_server_stored'])) { |
|
3000 | + echo ' |
|
2882 | 3001 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_server_stored" value="server_stored"' . ($context['member']['avatar']['choice'] == 'server_stored' ? ' checked="checked"' : '') . '> |
2883 | 3002 | <label for="avatar_choice_server_stored"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '> |
2884 | 3003 | ', $txt['choose_avatar_gallery'], ' |
2885 | 3004 | </label><br>'; |
3005 | + } |
|
2886 | 3006 | |
2887 | - if (!empty($context['member']['avatar']['allow_external'])) |
|
2888 | - echo ' |
|
3007 | + if (!empty($context['member']['avatar']['allow_external'])) { |
|
3008 | + echo ' |
|
2889 | 3009 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_external" value="external"' . ($context['member']['avatar']['choice'] == 'external' ? ' checked="checked"' : '') . '> |
2890 | 3010 | <label for="avatar_choice_external"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '> |
2891 | 3011 | ', $txt['my_own_pic'], ' |
2892 | 3012 | </label><br>'; |
3013 | + } |
|
2893 | 3014 | |
2894 | - if (!empty($context['member']['avatar']['allow_upload'])) |
|
2895 | - echo ' |
|
3015 | + if (!empty($context['member']['avatar']['allow_upload'])) { |
|
3016 | + echo ' |
|
2896 | 3017 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_upload" value="upload"' . ($context['member']['avatar']['choice'] == 'upload' ? ' checked="checked"' : '') . '> |
2897 | 3018 | <label for="avatar_choice_upload"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '> |
2898 | 3019 | ', $txt['avatar_will_upload'], ' |
2899 | 3020 | </label><br>'; |
3021 | + } |
|
2900 | 3022 | |
2901 | - if (!empty($context['member']['avatar']['allow_gravatar'])) |
|
2902 | - echo ' |
|
3023 | + if (!empty($context['member']['avatar']['allow_gravatar'])) { |
|
3024 | + echo ' |
|
2903 | 3025 | <input type="radio" onclick="swap_avatar(this); return true;" name="avatar_choice" id="avatar_choice_gravatar" value="gravatar"' . ($context['member']['avatar']['choice'] == 'gravatar' ? ' checked="checked"' : '') . '> |
2904 | 3026 | <label for="avatar_choice_gravatar"' . (isset($context['modify_error']['bad_avatar']) ? ' class="error"' : '') . '>' . $txt['use_gravatar'] . '</label>'; |
3027 | + } |
|
2905 | 3028 | |
2906 | 3029 | echo ' |
2907 | 3030 | </dt> |
@@ -2916,9 +3039,10 @@ discard block |
||
2916 | 3039 | <select name="cat" id="cat" size="10" onchange="changeSel(\'\');" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'server_stored\');">'; |
2917 | 3040 | |
2918 | 3041 | // This lists all the file categories. |
2919 | - foreach ($context['avatars'] as $avatar) |
|
2920 | - echo ' |
|
3042 | + foreach ($context['avatars'] as $avatar) { |
|
3043 | + echo ' |
|
2921 | 3044 | <option value="', $avatar['filename'] . ($avatar['is_dir'] ? '/' : ''), '"', ($avatar['checked'] ? ' selected' : ''), '>', $avatar['name'], '</option>'; |
3045 | + } |
|
2922 | 3046 | |
2923 | 3047 | echo ' |
2924 | 3048 | </select> |
@@ -2950,20 +3074,22 @@ discard block |
||
2950 | 3074 | } |
2951 | 3075 | |
2952 | 3076 | // If the user can link to an off server avatar, show them a box to input the address. |
2953 | - if (!empty($context['member']['avatar']['allow_external'])) |
|
2954 | - echo ' |
|
3077 | + if (!empty($context['member']['avatar']['allow_external'])) { |
|
3078 | + echo ' |
|
2955 | 3079 | <div id="avatar_external"> |
2956 | 3080 | <div class="smalltext">', $txt['avatar_by_url'], '</div>', !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_download_and_resize' ? template_max_size('external') : '', ' |
2957 | 3081 | <input type="text" name="userpicpersonal" size="45" value="', ((stristr($context['member']['avatar']['external'], 'http://') || stristr($context['member']['avatar']['external'], 'https://')) ? $context['member']['avatar']['external'] : 'http://'), '" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'external\');" onchange="if (typeof(previewExternalAvatar) != \'undefined\') previewExternalAvatar(this.value);"> |
2958 | 3082 | </div>'; |
3083 | + } |
|
2959 | 3084 | |
2960 | 3085 | // If the user is able to upload avatars to the server show them an upload box. |
2961 | - if (!empty($context['member']['avatar']['allow_upload'])) |
|
2962 | - echo ' |
|
3086 | + if (!empty($context['member']['avatar']['allow_upload'])) { |
|
3087 | + echo ' |
|
2963 | 3088 | <div id="avatar_upload"> |
2964 | 3089 | <input type="file" size="44" name="attachment" id="avatar_upload_box" value="" onchange="readfromUpload(this)" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'upload\');" accept="image/gif, image/jpeg, image/jpg, image/png">', template_max_size('upload'), ' |
2965 | 3090 | ', (!empty($context['member']['avatar']['id_attach']) ? '<br><img src="' . $context['member']['avatar']['href'] . (strpos($context['member']['avatar']['href'], '?') === false ? '?' : '&') . 'time=' . time() . '" alt="" id="attached_image"><input type="hidden" name="id_attach" value="' . $context['member']['avatar']['id_attach'] . '">' : ''), ' |
2966 | 3091 | </div>'; |
3092 | + } |
|
2967 | 3093 | |
2968 | 3094 | // if the user is able to use Gravatar avatars show then the image preview |
2969 | 3095 | if (!empty($context['member']['avatar']['allow_gravatar'])) |
@@ -2972,16 +3098,17 @@ discard block |
||
2972 | 3098 | <div id="avatar_gravatar"> |
2973 | 3099 | <img src="' . $context['member']['avatar']['href'] . '" alt="">'; |
2974 | 3100 | |
2975 | - if (empty($modSettings['gravatarAllowExtraEmail'])) |
|
2976 | - echo ' |
|
3101 | + if (empty($modSettings['gravatarAllowExtraEmail'])) { |
|
3102 | + echo ' |
|
2977 | 3103 | <div class="smalltext">', $txt['gravatar_noAlternateEmail'], '</div>'; |
2978 | - else |
|
3104 | + } else |
|
2979 | 3105 | { |
2980 | 3106 | // Depending on other stuff, the stored value here might have some odd things in it from other areas. |
2981 | - if ($context['member']['avatar']['external'] == $context['member']['email']) |
|
2982 | - $textbox_value = ''; |
|
2983 | - else |
|
2984 | - $textbox_value = $context['member']['avatar']['external']; |
|
3107 | + if ($context['member']['avatar']['external'] == $context['member']['email']) { |
|
3108 | + $textbox_value = ''; |
|
3109 | + } else { |
|
3110 | + $textbox_value = $context['member']['avatar']['external']; |
|
3111 | + } |
|
2985 | 3112 | |
2986 | 3113 | echo ' |
2987 | 3114 | <div class="smalltext">', $txt['gravatar_alternateEmail'], '</div> |
@@ -3053,8 +3180,9 @@ discard block |
||
3053 | 3180 | $h = !empty($modSettings['avatar_max_height_' . $type]) ? comma_format($modSettings['avatar_max_height_' . $type]) : 0; |
3054 | 3181 | |
3055 | 3182 | $suffix = (!empty($w) ? 'w' : '') . (!empty($h) ? 'h' : ''); |
3056 | - if (empty($suffix)) |
|
3057 | - return; |
|
3183 | + if (empty($suffix)) { |
|
3184 | + return; |
|
3185 | + } |
|
3058 | 3186 | |
3059 | 3187 | echo ' |
3060 | 3188 | <div class="smalltext">', sprintf($txt['avatar_max_size_' . $suffix], $w, $h), '</div>'; |
@@ -3079,9 +3207,10 @@ discard block |
||
3079 | 3207 | <select name="easyformat" id="easyformat" onchange="document.forms.creator.time_format.value = this.options[this.selectedIndex].value;">'; |
3080 | 3208 | |
3081 | 3209 | // Help the user by showing a list of common time formats. |
3082 | - foreach ($context['easy_timeformats'] as $time_format) |
|
3083 | - echo ' |
|
3210 | + foreach ($context['easy_timeformats'] as $time_format) { |
|
3211 | + echo ' |
|
3084 | 3212 | <option value="', $time_format['format'], '"', $time_format['format'] == $context['member']['time_format'] ? ' selected' : '', '>', $time_format['title'], '</option>'; |
3213 | + } |
|
3085 | 3214 | |
3086 | 3215 | echo ' |
3087 | 3216 | </select> |
@@ -3119,9 +3248,10 @@ discard block |
||
3119 | 3248 | <dd> |
3120 | 3249 | <select name="smiley_set" id="smiley_set" onchange="document.getElementById(\'smileypr\').src = this.selectedIndex == 0 ? \'', $settings['images_url'], '/blank.png\' : \'', $modSettings['smileys_url'], '/\' + (this.selectedIndex != 1 ? this.options[this.selectedIndex].value : \'', !empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'], '\') + \'/smiley.png\';">'; |
3121 | 3250 | |
3122 | - foreach ($context['smiley_sets'] as $set) |
|
3123 | - echo ' |
|
3251 | + foreach ($context['smiley_sets'] as $set) { |
|
3252 | + echo ' |
|
3124 | 3253 | <option value="', $set['id'], '"', $set['selected'] ? ' selected' : '', '>', $set['name'], '</option>'; |
3254 | + } |
|
3125 | 3255 | |
3126 | 3256 | echo ' |
3127 | 3257 | </select> |
@@ -3143,17 +3273,17 @@ discard block |
||
3143 | 3273 | <div class="roundframe"> |
3144 | 3274 | <div>'; |
3145 | 3275 | |
3146 | - if (!empty($context['tfa_backup'])) |
|
3147 | - echo ' |
|
3276 | + if (!empty($context['tfa_backup'])) { |
|
3277 | + echo ' |
|
3148 | 3278 | <div class="smalltext error"> |
3149 | 3279 | ', $txt['tfa_backup_used_desc'], ' |
3150 | 3280 | </div>'; |
3151 | - |
|
3152 | - elseif ($modSettings['tfa_mode'] == 2) |
|
3153 | - echo ' |
|
3281 | + } elseif ($modSettings['tfa_mode'] == 2) { |
|
3282 | + echo ' |
|
3154 | 3283 | <div class="smalltext"> |
3155 | 3284 | <strong>', $txt['tfa_forced_desc'], '</strong> |
3156 | 3285 | </div>'; |
3286 | + } |
|
3157 | 3287 | |
3158 | 3288 | echo ' |
3159 | 3289 | <div class="smalltext"> |
@@ -3164,11 +3294,12 @@ discard block |
||
3164 | 3294 | <div class="title_top"> |
3165 | 3295 | <strong>', $txt['tfa_step1'], '</strong><br>'; |
3166 | 3296 | |
3167 | - if (!empty($context['tfa_pass_error'])) |
|
3168 | - echo ' |
|
3297 | + if (!empty($context['tfa_pass_error'])) { |
|
3298 | + echo ' |
|
3169 | 3299 | <div class="error smalltext"> |
3170 | 3300 | ', $txt['tfa_pass_invalid'], ' |
3171 | 3301 | </div>'; |
3302 | + } |
|
3172 | 3303 | |
3173 | 3304 | echo ' |
3174 | 3305 | <input type="password" name="passwd" size="25"', !empty($context['tfa_pass_error']) ? ' class="error"' : '', !empty($context['tfa_pass_value']) ? ' value="' . $context['tfa_pass_value'] . '"' : '', '> |
@@ -3181,11 +3312,12 @@ discard block |
||
3181 | 3312 | <div class="title_top"> |
3182 | 3313 | <strong>', $txt['tfa_step3'], '</strong><br>'; |
3183 | 3314 | |
3184 | - if (!empty($context['tfa_error'])) |
|
3185 | - echo ' |
|
3315 | + if (!empty($context['tfa_error'])) { |
|
3316 | + echo ' |
|
3186 | 3317 | <div class="error smalltext"> |
3187 | 3318 | ', $txt['tfa_code_invalid'], ' |
3188 | 3319 | </div>'; |
3320 | + } |
|
3189 | 3321 | |
3190 | 3322 | echo ' |
3191 | 3323 | <input type="text" name="tfa_code" size="25"', !empty($context['tfa_error']) ? ' class="error"' : '', !empty($context['tfa_value']) ? ' value="' . $context['tfa_value'] . '"' : '', '> |
@@ -3199,10 +3331,11 @@ discard block |
||
3199 | 3331 | <img src="', $context['tfa_qr_url'], '" alt=""> |
3200 | 3332 | </div>'; |
3201 | 3333 | |
3202 | - if (!empty($context['from_ajax'])) |
|
3203 | - echo ' |
|
3334 | + if (!empty($context['from_ajax'])) { |
|
3335 | + echo ' |
|
3204 | 3336 | <br> |
3205 | 3337 | <a href="javascript:self.close();"></a>'; |
3338 | + } |
|
3206 | 3339 | |
3207 | 3340 | echo ' |
3208 | 3341 | </div> |
@@ -3242,17 +3375,16 @@ discard block |
||
3242 | 3375 | </dt> |
3243 | 3376 | <dd>'; |
3244 | 3377 | |
3245 | - if (!$context['tfa_enabled'] && $context['user']['is_owner']) |
|
3246 | - echo ' |
|
3378 | + if (!$context['tfa_enabled'] && $context['user']['is_owner']) { |
|
3379 | + echo ' |
|
3247 | 3380 | <a href="', !empty($modSettings['force_ssl']) ? strtr($scripturl, array('http://' => 'https://')) : $scripturl, '?action=profile;area=tfasetup" id="enable_tfa">', $txt['tfa_profile_enable'], '</a>'; |
3248 | - |
|
3249 | - elseif (!$context['tfa_enabled']) |
|
3250 | - echo ' |
|
3381 | + } elseif (!$context['tfa_enabled']) { |
|
3382 | + echo ' |
|
3251 | 3383 | ', $txt['tfa_profile_disabled']; |
3252 | - |
|
3253 | - else |
|
3254 | - echo ' |
|
3384 | + } else { |
|
3385 | + echo ' |
|
3255 | 3386 | ', sprintf($txt['tfa_profile_enabled'], $scripturl . '?action=profile;u=' . $context['id_member'] . ';area=tfasetup;disable'); |
3387 | + } |
|
3256 | 3388 | |
3257 | 3389 | echo ' |
3258 | 3390 | </dd>'; |
@@ -85,7 +85,7 @@ |
||
85 | 85 | foreach ($board['children'] as $child) |
86 | 86 | { |
87 | 87 | if (!$child['is_redirect']) |
88 | - $child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
88 | + $child['link'] = '' . ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
89 | 89 | else |
90 | 90 | $child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . '">' . $child['name'] . '</a>'; |
91 | 91 |
@@ -18,11 +18,12 @@ discard block |
||
18 | 18 | global $context, $settings, $options, $scripturl, $modSettings, $txt; |
19 | 19 | |
20 | 20 | // Let them know why their message became unapproved. |
21 | - if ($context['becomesUnapproved']) |
|
22 | - echo ' |
|
21 | + if ($context['becomesUnapproved']) { |
|
22 | + echo ' |
|
23 | 23 | <div class="noticebox"> |
24 | 24 | ', $txt['post_becomesUnapproved'], ' |
25 | 25 | </div>'; |
26 | + } |
|
26 | 27 | |
27 | 28 | if (!empty($context['boards']) && (!empty($options['show_children']) || $context['start'] == 0)) |
28 | 29 | { |
@@ -46,17 +47,19 @@ discard block |
||
46 | 47 | </a>'; |
47 | 48 | |
48 | 49 | // Has it outstanding posts for approval? |
49 | - if ($board['can_approve_posts'] && ($board['unapproved_posts'] || $board['unapproved_topics'])) |
|
50 | - echo ' |
|
50 | + if ($board['can_approve_posts'] && ($board['unapproved_posts'] || $board['unapproved_topics'])) { |
|
51 | + echo ' |
|
51 | 52 | <a href="', $scripturl, '?action=moderate;area=postmod;sa=', ($board['unapproved_topics'] > 0 ? 'topics' : 'posts'), ';brd=', $board['id'], ';', $context['session_var'], '=', $context['session_id'], '" title="', sprintf($txt['unapproved_posts'], $board['unapproved_topics'], $board['unapproved_posts']), '" class="moderation_link">(!)</a>'; |
53 | + } |
|
52 | 54 | |
53 | 55 | echo ' |
54 | 56 | <p class="board_description">', $board['description'], '</p>'; |
55 | 57 | |
56 | 58 | // Show the "Moderators: ". Each has name, href, link, and id. (but we're gonna use link_moderators.) |
57 | - if (!empty($board['moderators']) || !empty($board['moderator_groups'])) |
|
58 | - echo ' |
|
59 | + if (!empty($board['moderators']) || !empty($board['moderator_groups'])) { |
|
60 | + echo ' |
|
59 | 61 | <p class="moderators">', count($board['link_moderators']) === 1 ? $txt['moderator'] : $txt['moderators'], ': ', implode(', ', $board['link_moderators']), '</p>'; |
62 | + } |
|
60 | 63 | |
61 | 64 | // Show some basic information about the number of posts, etc. |
62 | 65 | echo ' |
@@ -68,9 +71,10 @@ discard block |
||
68 | 71 | </div> |
69 | 72 | <div class="lastpost lpr_border">'; |
70 | 73 | |
71 | - if (!empty($board['last_post']['id'])) |
|
72 | - echo ' |
|
74 | + if (!empty($board['last_post']['id'])) { |
|
75 | + echo ' |
|
73 | 76 | <p>', $board['last_post']['last_post_message'], '</p>'; |
77 | + } |
|
74 | 78 | |
75 | 79 | echo ' |
76 | 80 | </div>'; |
@@ -84,14 +88,16 @@ discard block |
||
84 | 88 | id, name, description, new (is it new?), topics (#), posts (#), href, link, and last_post. */ |
85 | 89 | foreach ($board['children'] as $child) |
86 | 90 | { |
87 | - if (!$child['is_redirect']) |
|
88 | - $child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
89 | - else |
|
90 | - $child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . '">' . $child['name'] . '</a>'; |
|
91 | + if (!$child['is_redirect']) { |
|
92 | + $child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
93 | + } else { |
|
94 | + $child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . '">' . $child['name'] . '</a>'; |
|
95 | + } |
|
91 | 96 | |
92 | 97 | // Has it posts awaiting approval? |
93 | - if ($child['can_approve_posts'] && ($child['unapproved_posts'] | $child['unapproved_topics'])) |
|
94 | - $child['link'] .= ' <a href="' . $scripturl . '?action=moderate;area=postmod;sa=' . ($child['unapproved_topics'] > 0 ? 'topics' : 'posts') . ';brd=' . $child['id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" title="' . sprintf($txt['unapproved_posts'], $child['unapproved_topics'], $child['unapproved_posts']) . '" class="moderation_link">(!)</a>'; |
|
98 | + if ($child['can_approve_posts'] && ($child['unapproved_posts'] | $child['unapproved_topics'])) { |
|
99 | + $child['link'] .= ' <a href="' . $scripturl . '?action=moderate;area=postmod;sa=' . ($child['unapproved_topics'] > 0 ? 'topics' : 'posts') . ';brd=' . $child['id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" title="' . sprintf($txt['unapproved_posts'], $child['unapproved_topics'], $child['unapproved_posts']) . '" class="moderation_link">(!)</a>'; |
|
100 | + } |
|
95 | 101 | |
96 | 102 | $children[] = $child['new'] ? '<span class="strong">' . $child['link'] . '</span>' : '<span>' . $child['link'] . '</span>'; |
97 | 103 | } |
@@ -113,11 +119,12 @@ discard block |
||
113 | 119 | if (!$context['no_topic_listing']) |
114 | 120 | { |
115 | 121 | // Mobile action buttons (top) |
116 | - if (!empty($context['normal_buttons'])) |
|
117 | - echo ' |
|
122 | + if (!empty($context['normal_buttons'])) { |
|
123 | + echo ' |
|
118 | 124 | <div class="mobile_buttons floatright"> |
119 | 125 | <a class="button mobile_act">', $txt['mobile_action'], '</a> |
120 | 126 | </div>'; |
127 | + } |
|
121 | 128 | |
122 | 129 | echo ' |
123 | 130 | <div class="pagesection"> |
@@ -136,13 +143,15 @@ discard block |
||
136 | 143 | <h3>', $context['name'], '</h3> |
137 | 144 | <p>'; |
138 | 145 | |
139 | - if ($context['description'] != '') |
|
140 | - echo ' |
|
146 | + if ($context['description'] != '') { |
|
147 | + echo ' |
|
141 | 148 | ', $context['description']; |
149 | + } |
|
142 | 150 | |
143 | - if (!empty($context['moderators'])) |
|
144 | - echo ' |
|
151 | + if (!empty($context['moderators'])) { |
|
152 | + echo ' |
|
145 | 153 | ', count($context['moderators']) === 1 ? $txt['moderator'] : $txt['moderators'], ': ', implode(', ', $context['link_moderators']), '.'; |
154 | + } |
|
146 | 155 | |
147 | 156 | echo ' |
148 | 157 | </p> |
@@ -150,9 +159,10 @@ discard block |
||
150 | 159 | } |
151 | 160 | |
152 | 161 | // If Quick Moderation is enabled start the form. |
153 | - if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] > 0 && !empty($context['topics'])) |
|
154 | - echo ' |
|
162 | + if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] > 0 && !empty($context['topics'])) { |
|
163 | + echo ' |
|
155 | 164 | <form action="', $scripturl, '?action=quickmod;board=', $context['current_board'], '.', $context['start'], '" method="post" accept-charset="', $context['character_set'], '" class="clear" name="quickModForm" id="quickModForm">'; |
165 | + } |
|
156 | 166 | |
157 | 167 | echo ' |
158 | 168 | <div id="messageindex">'; |
@@ -162,11 +172,11 @@ discard block |
||
162 | 172 | echo ' |
163 | 173 | <div class="information">'; |
164 | 174 | |
165 | - if ($settings['display_who_viewing'] == 1) |
|
166 | - echo count($context['view_members']), ' ', count($context['view_members']) === 1 ? $txt['who_member'] : $txt['members']; |
|
167 | - |
|
168 | - else |
|
169 | - echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . (empty($context['view_num_hidden']) || $context['can_moderate_forum'] ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')'); |
|
175 | + if ($settings['display_who_viewing'] == 1) { |
|
176 | + echo count($context['view_members']), ' ', count($context['view_members']) === 1 ? $txt['who_member'] : $txt['members']; |
|
177 | + } else { |
|
178 | + echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . (empty($context['view_num_hidden']) || $context['can_moderate_forum'] ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')'); |
|
179 | + } |
|
170 | 180 | echo $txt['who_and'], $context['view_num_guests'], ' ', $context['view_num_guests'] == 1 ? $txt['guest'] : $txt['guests'], $txt['who_viewing_board']; |
171 | 181 | |
172 | 182 | echo ' |
@@ -186,32 +196,36 @@ discard block |
||
186 | 196 | <div class="lastpost">', $context['topics_headers']['last_post'], '</div>'; |
187 | 197 | |
188 | 198 | // Show a "select all" box for quick moderation? |
189 | - if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] == 1) |
|
190 | - echo ' |
|
199 | + if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] == 1) { |
|
200 | + echo ' |
|
191 | 201 | <div class="moderation"> |
192 | 202 | <input type="checkbox" onclick="invertAll(this, this.form, \'topics[]\');"> |
193 | 203 | </div>'; |
204 | + } |
|
194 | 205 | |
195 | 206 | // If it's on in "image" mode, don't show anything but the column. |
196 | - elseif (!empty($context['can_quick_mod'])) |
|
197 | - echo ' |
|
207 | + elseif (!empty($context['can_quick_mod'])) { |
|
208 | + echo ' |
|
198 | 209 | <div class="moderation"></div>'; |
210 | + } |
|
199 | 211 | } |
200 | 212 | |
201 | 213 | // No topics... just say, "sorry bub". |
202 | - else |
|
203 | - echo ' |
|
214 | + else { |
|
215 | + echo ' |
|
204 | 216 | <h3 class="titlebg">', $txt['topic_alert_none'], '</h3>'; |
217 | + } |
|
205 | 218 | |
206 | 219 | echo ' |
207 | 220 | </div><!-- #topic_header -->'; |
208 | 221 | |
209 | 222 | // If this person can approve items and we have some awaiting approval tell them. |
210 | - if (!empty($context['unapproved_posts_message'])) |
|
211 | - echo ' |
|
223 | + if (!empty($context['unapproved_posts_message'])) { |
|
224 | + echo ' |
|
212 | 225 | <div class="information"> |
213 | 226 | <span class="alert">!</span> ', $context['unapproved_posts_message'], ' |
214 | 227 | </div>'; |
228 | + } |
|
215 | 229 | |
216 | 230 | // Contain the topic list |
217 | 231 | echo ' |
@@ -232,25 +246,30 @@ discard block |
||
232 | 246 | echo ' |
233 | 247 | <div class="icons floatright">'; |
234 | 248 | |
235 | - if ($topic['is_watched']) |
|
236 | - echo ' |
|
249 | + if ($topic['is_watched']) { |
|
250 | + echo ' |
|
237 | 251 | <span class="generic_icons watch" title="', $txt['watching_this_topic'], '"></span>'; |
252 | + } |
|
238 | 253 | |
239 | - if ($topic['is_locked']) |
|
240 | - echo ' |
|
254 | + if ($topic['is_locked']) { |
|
255 | + echo ' |
|
241 | 256 | <span class="generic_icons lock"></span>'; |
257 | + } |
|
242 | 258 | |
243 | - if ($topic['is_sticky']) |
|
244 | - echo ' |
|
259 | + if ($topic['is_sticky']) { |
|
260 | + echo ' |
|
245 | 261 | <span class="generic_icons sticky"></span>'; |
262 | + } |
|
246 | 263 | |
247 | - if ($topic['is_redirect']) |
|
248 | - echo ' |
|
264 | + if ($topic['is_redirect']) { |
|
265 | + echo ' |
|
249 | 266 | <span class="generic_icons move"></span>'; |
267 | + } |
|
250 | 268 | |
251 | - if ($topic['is_poll']) |
|
252 | - echo ' |
|
269 | + if ($topic['is_poll']) { |
|
270 | + echo ' |
|
253 | 271 | <span class="generic_icons poll"></span>'; |
272 | + } |
|
254 | 273 | |
255 | 274 | echo ' |
256 | 275 | </div>'; |
@@ -282,26 +301,31 @@ discard block |
||
282 | 301 | echo ' |
283 | 302 | <div class="moderation">'; |
284 | 303 | |
285 | - if ($options['display_quick_mod'] == 1) |
|
286 | - echo ' |
|
304 | + if ($options['display_quick_mod'] == 1) { |
|
305 | + echo ' |
|
287 | 306 | <input type="checkbox" name="topics[]" value="', $topic['id'], '">'; |
288 | - else |
|
307 | + } else |
|
289 | 308 | { |
290 | 309 | // Check permissions on each and show only the ones they are allowed to use. |
291 | - if ($topic['quick_mod']['remove']) |
|
292 | - echo '<a href="', $scripturl, '?action=quickmod;board=', $context['current_board'], '.', $context['start'], ';actions%5B', $topic['id'], '%5D=remove;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons delete" title="', $txt['remove_topic'], '"></span></a>'; |
|
310 | + if ($topic['quick_mod']['remove']) { |
|
311 | + echo '<a href="', $scripturl, '?action=quickmod;board=', $context['current_board'], '.', $context['start'], ';actions%5B', $topic['id'], '%5D=remove;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons delete" title="', $txt['remove_topic'], '"></span></a>'; |
|
312 | + } |
|
293 | 313 | |
294 | - if ($topic['quick_mod']['lock']) |
|
295 | - echo '<a href="', $scripturl, '?action=quickmod;board=', $context['current_board'], '.', $context['start'], ';actions%5B', $topic['id'], '%5D=lock;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons lock" title="', $topic['is_locked'] ? $txt['set_unlock'] : $txt['set_lock'], '"></span></a>'; |
|
314 | + if ($topic['quick_mod']['lock']) { |
|
315 | + echo '<a href="', $scripturl, '?action=quickmod;board=', $context['current_board'], '.', $context['start'], ';actions%5B', $topic['id'], '%5D=lock;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons lock" title="', $topic['is_locked'] ? $txt['set_unlock'] : $txt['set_lock'], '"></span></a>'; |
|
316 | + } |
|
296 | 317 | |
297 | - if ($topic['quick_mod']['lock'] || $topic['quick_mod']['remove']) |
|
298 | - echo '<br>'; |
|
318 | + if ($topic['quick_mod']['lock'] || $topic['quick_mod']['remove']) { |
|
319 | + echo '<br>'; |
|
320 | + } |
|
299 | 321 | |
300 | - if ($topic['quick_mod']['sticky']) |
|
301 | - echo '<a href="', $scripturl, '?action=quickmod;board=', $context['current_board'], '.', $context['start'], ';actions%5B', $topic['id'], '%5D=sticky;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons sticky" title="', $topic['is_sticky'] ? $txt['set_nonsticky'] : $txt['set_sticky'], '"></span></a>'; |
|
322 | + if ($topic['quick_mod']['sticky']) { |
|
323 | + echo '<a href="', $scripturl, '?action=quickmod;board=', $context['current_board'], '.', $context['start'], ';actions%5B', $topic['id'], '%5D=sticky;', $context['session_var'], '=', $context['session_id'], '" class="you_sure"><span class="generic_icons sticky" title="', $topic['is_sticky'] ? $txt['set_nonsticky'] : $txt['set_sticky'], '"></span></a>'; |
|
324 | + } |
|
302 | 325 | |
303 | - if ($topic['quick_mod']['move']) |
|
304 | - echo '<a href="', $scripturl, '?action=movetopic;current_board=', $context['current_board'], ';board=', $context['current_board'], '.', $context['start'], ';topic=', $topic['id'], '.0"><span class="generic_icons move" title="', $txt['move_topic'], '"></span></a>'; |
|
326 | + if ($topic['quick_mod']['move']) { |
|
327 | + echo '<a href="', $scripturl, '?action=movetopic;current_board=', $context['current_board'], ';board=', $context['current_board'], '.', $context['start'], ';topic=', $topic['id'], '.0"><span class="generic_icons move" title="', $txt['move_topic'], '"></span></a>'; |
|
328 | + } |
|
305 | 329 | } |
306 | 330 | echo ' |
307 | 331 | </div><!-- .moderation -->'; |
@@ -319,18 +343,20 @@ discard block |
||
319 | 343 | <select class="qaction" name="qaction"', $context['can_move'] ? ' onchange="this.form.move_to.disabled = (this.options[this.selectedIndex].value != \'move\');"' : '', '> |
320 | 344 | <option value="">--------</option>'; |
321 | 345 | |
322 | - foreach ($context['qmod_actions'] as $qmod_action) |
|
323 | - if ($context['can_' . $qmod_action]) |
|
346 | + foreach ($context['qmod_actions'] as $qmod_action) { |
|
347 | + if ($context['can_' . $qmod_action]) |
|
324 | 348 | echo ' |
325 | 349 | <option value="' . $qmod_action . '">' . $txt['quick_mod_' . $qmod_action] . '</option>'; |
350 | + } |
|
326 | 351 | |
327 | 352 | echo ' |
328 | 353 | </select>'; |
329 | 354 | |
330 | 355 | // Show a list of boards they can move the topic to. |
331 | - if ($context['can_move']) |
|
332 | - echo ' |
|
356 | + if ($context['can_move']) { |
|
357 | + echo ' |
|
333 | 358 | <span id="quick_mod_jump_to"></span>'; |
359 | + } |
|
334 | 360 | |
335 | 361 | echo ' |
336 | 362 | <input type="submit" value="', $txt['quick_mod_go'], '" onclick="return document.forms.quickModForm.qaction.value != \'\' && confirm(\'', $txt['quickmod_confirm'], '\');" class="button qaction"> |
@@ -341,17 +367,19 @@ discard block |
||
341 | 367 | </div><!-- #messageindex -->'; |
342 | 368 | |
343 | 369 | // Finish off the form - again. |
344 | - if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] > 0 && !empty($context['topics'])) |
|
345 | - echo ' |
|
370 | + if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] > 0 && !empty($context['topics'])) { |
|
371 | + echo ' |
|
346 | 372 | <input type="hidden" name="' . $context['session_var'] . '" value="' . $context['session_id'] . '"> |
347 | 373 | </form>'; |
374 | + } |
|
348 | 375 | |
349 | 376 | // Mobile action buttons (bottom) |
350 | - if (!empty($context['normal_buttons'])) |
|
351 | - echo ' |
|
377 | + if (!empty($context['normal_buttons'])) { |
|
378 | + echo ' |
|
352 | 379 | <div class="mobile_buttons floatright"> |
353 | 380 | <a class="button mobile_act">', $txt['mobile_action'], '</a> |
354 | 381 | </div>'; |
382 | + } |
|
355 | 383 | |
356 | 384 | echo ' |
357 | 385 | <div class="pagesection"> |
@@ -367,8 +395,8 @@ discard block |
||
367 | 395 | // Show breadcrumbs at the bottom too. |
368 | 396 | theme_linktree(); |
369 | 397 | |
370 | - if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics']) && $context['can_move']) |
|
371 | - echo ' |
|
398 | + if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] == 1 && !empty($context['topics']) && $context['can_move']) { |
|
399 | + echo ' |
|
372 | 400 | <script> |
373 | 401 | if (typeof(window.XMLHttpRequest) != "undefined") |
374 | 402 | aJumpTo[aJumpTo.length] = new JumpTo({ |
@@ -387,6 +415,7 @@ discard block |
||
387 | 415 | sCustomName: "move_to" |
388 | 416 | }); |
389 | 417 | </script>'; |
418 | + } |
|
390 | 419 | |
391 | 420 | // Javascript for inline editing. |
392 | 421 | echo ' |
@@ -423,8 +452,8 @@ discard block |
||
423 | 452 | <div class="information"> |
424 | 453 | <p class="floatright" id="message_index_jump_to"></p>'; |
425 | 454 | |
426 | - if (empty($context['no_topic_listing'])) |
|
427 | - echo ' |
|
455 | + if (empty($context['no_topic_listing'])) { |
|
456 | + echo ' |
|
428 | 457 | <p class="floatleft">', !empty($modSettings['enableParticipation']) && $context['user']['is_logged'] ? ' |
429 | 458 | <img src="' . $settings['images_url'] . '/icons/profile_sm.png" alt="" class="centericon"> ' . $txt['participation_caption'] . '<br>' : '', ' |
430 | 459 | '. ($modSettings['pollMode'] == '1' ? '<span class="generic_icons poll centericon"></span> ' . $txt['poll'] : '') . '<br> |
@@ -434,9 +463,10 @@ discard block |
||
434 | 463 | <span class="generic_icons lock centericon"></span> ' . $txt['locked_topic'] . '<br> |
435 | 464 | <span class="generic_icons sticky centericon"></span> ' . $txt['sticky_topic'] . '<br> |
436 | 465 | </p>'; |
466 | + } |
|
437 | 467 | |
438 | - if (!empty($context['jump_to'])) |
|
439 | - echo ' |
|
468 | + if (!empty($context['jump_to'])) { |
|
469 | + echo ' |
|
440 | 470 | <script> |
441 | 471 | if (typeof(window.XMLHttpRequest) != "undefined") |
442 | 472 | aJumpTo[aJumpTo.length] = new JumpTo({ |
@@ -452,6 +482,7 @@ discard block |
||
452 | 482 | sGoButtonLabel: "', $txt['quick_mod_go'], '" |
453 | 483 | }); |
454 | 484 | </script>'; |
485 | + } |
|
455 | 486 | |
456 | 487 | echo ' |
457 | 488 | <br class="clear"> |
@@ -44,10 +44,11 @@ discard block |
||
44 | 44 | <dt>', $txt['users_online_today'], ':</dt> |
45 | 45 | <dd>', $context['online_today'], '</dd>'; |
46 | 46 | |
47 | - if (!empty($modSettings['hitStats'])) |
|
48 | - echo ' |
|
47 | + if (!empty($modSettings['hitStats'])) { |
|
48 | + echo ' |
|
49 | 49 | <dt>', $txt['num_hits'], ':</dt> |
50 | 50 | <dd>', $context['num_hits'], '</dd>'; |
51 | + } |
|
51 | 52 | |
52 | 53 | echo ' |
53 | 54 | </dl> |
@@ -71,17 +72,19 @@ discard block |
||
71 | 72 | <dt>', $txt['gender_stats'], ':</dt> |
72 | 73 | <dd>'; |
73 | 74 | |
74 | - foreach ($context['gender'] as $g => $n) |
|
75 | - echo $g, ': ', $n, '<br>'; |
|
75 | + foreach ($context['gender'] as $g => $n) { |
|
76 | + echo $g, ': ', $n, '<br>'; |
|
77 | + } |
|
76 | 78 | |
77 | 79 | echo ' |
78 | 80 | </dd>'; |
79 | 81 | } |
80 | 82 | |
81 | - if (!empty($modSettings['hitStats'])) |
|
82 | - echo ' |
|
83 | + if (!empty($modSettings['hitStats'])) { |
|
84 | + echo ' |
|
83 | 85 | <dt>', $txt['average_hits'], ':</dt> |
84 | 86 | <dd>', $context['average_hits'], '</dd>'; |
87 | + } |
|
85 | 88 | |
86 | 89 | echo ' |
87 | 90 | </dl>'; |
@@ -105,12 +108,13 @@ discard block |
||
105 | 108 | </dt> |
106 | 109 | <dd class="statsbar generic_bar righttext">'; |
107 | 110 | |
108 | - if (!empty($item['percent'])) |
|
109 | - echo ' |
|
111 | + if (!empty($item['percent'])) { |
|
112 | + echo ' |
|
110 | 113 | <div class="bar" style="width: ', $item['percent'], '%;"></div>'; |
111 | - else |
|
112 | - echo ' |
|
113 | - <div class="bar empty"></div>'; |
|
114 | + } else { |
|
115 | + echo ' |
|
116 | + <div class="bar empty"></div>'; |
|
117 | + } |
|
114 | 118 | |
115 | 119 | echo ' |
116 | 120 | <span>', $item['num'], '</span> |
@@ -143,9 +147,10 @@ discard block |
||
143 | 147 | <th>', $txt['stats_new_members'], '</th> |
144 | 148 | <th>', $txt['most_online'], '</th>'; |
145 | 149 | |
146 | - if (!empty($modSettings['hitStats'])) |
|
147 | - echo ' |
|
150 | + if (!empty($modSettings['hitStats'])) { |
|
151 | + echo ' |
|
148 | 152 | <th>', $txt['page_views'], '</th>'; |
153 | + } |
|
149 | 154 | |
150 | 155 | echo ' |
151 | 156 | </tr> |
@@ -164,9 +169,10 @@ discard block |
||
164 | 169 | <th>', $year['new_members'], '</th> |
165 | 170 | <th>', $year['most_members_online'], '</th>'; |
166 | 171 | |
167 | - if (!empty($modSettings['hitStats'])) |
|
168 | - echo ' |
|
172 | + if (!empty($modSettings['hitStats'])) { |
|
173 | + echo ' |
|
169 | 174 | <th>', $year['hits'], '</th>'; |
175 | + } |
|
170 | 176 | |
171 | 177 | echo ' |
172 | 178 | </tr>'; |
@@ -183,9 +189,10 @@ discard block |
||
183 | 189 | <th>', $month['new_members'], '</th> |
184 | 190 | <th>', $month['most_members_online'], '</th>'; |
185 | 191 | |
186 | - if (!empty($modSettings['hitStats'])) |
|
187 | - echo ' |
|
192 | + if (!empty($modSettings['hitStats'])) { |
|
193 | + echo ' |
|
188 | 194 | <th>', $month['hits'], '</th>'; |
195 | + } |
|
189 | 196 | |
190 | 197 | echo ' |
191 | 198 | </tr>'; |
@@ -202,9 +209,10 @@ discard block |
||
202 | 209 | <td>', $day['new_members'], '</td> |
203 | 210 | <td>', $day['most_members_online'], '</td>'; |
204 | 211 | |
205 | - if (!empty($modSettings['hitStats'])) |
|
206 | - echo ' |
|
212 | + if (!empty($modSettings['hitStats'])) { |
|
213 | + echo ' |
|
207 | 214 | <td>', $day['hits'], '</td>'; |
215 | + } |
|
208 | 216 | |
209 | 217 | echo ' |
210 | 218 | </tr>'; |
@@ -419,8 +419,8 @@ discard block |
||
419 | 419 | <div class="bar"></div> |
420 | 420 | </div> |
421 | 421 | <div class="attach-ui"> |
422 | - <a data-dz-remove class="button cancel">', $txt['modify_cancel'] ,'</a> |
|
423 | - <a class="button upload">', $txt['upload'] ,'</a> |
|
422 | + <a data-dz-remove class="button cancel">', $txt['modify_cancel'], '</a> |
|
423 | + <a class="button upload">', $txt['upload'], '</a> |
|
424 | 424 | </div> |
425 | 425 | </div><!-- .attach-info --> |
426 | 426 | </div><!-- #au-template --> |
@@ -437,10 +437,10 @@ discard block |
||
437 | 437 | </dt> |
438 | 438 | <dd class="smalltext fallback"> |
439 | 439 | <div id="attachUpload" class="descbox"> |
440 | - <h5>', $txt['attach_drop_zone'] ,'</h5> |
|
441 | - <a class="button" id="attach-cancelAll">', $txt['attached_cancelAll'] ,'</a> |
|
442 | - <a class="button" id="attach-uploadAll">', $txt['attached_uploadAll'] ,'</a> |
|
443 | - <a class="button fileinput-button">', $txt['attach_add'] ,'</a> |
|
440 | + <h5>', $txt['attach_drop_zone'], '</h5> |
|
441 | + <a class="button" id="attach-cancelAll">', $txt['attached_cancelAll'], '</a> |
|
442 | + <a class="button" id="attach-uploadAll">', $txt['attached_uploadAll'], '</a> |
|
443 | + <a class="button fileinput-button">', $txt['attach_add'], '</a> |
|
444 | 444 | <div id="total-progress" class="progress_bar" role="progressBar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0"> |
445 | 445 | <div class="bar"></div> |
446 | 446 | </div> |
@@ -550,7 +550,7 @@ discard block |
||
550 | 550 | // Option to delete an event if user is editing one. |
551 | 551 | if ($context['make_event'] && !$context['event']['new']) |
552 | 552 | echo ' |
553 | - <input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'] ,'" class="button you_sure">'; |
|
553 | + <input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'], '" class="button you_sure">'; |
|
554 | 554 | |
555 | 555 | echo ' |
556 | 556 | </span> |
@@ -804,7 +804,7 @@ discard block |
||
804 | 804 | });'; |
805 | 805 | |
806 | 806 | echo ' |
807 | - var oEditorID = "', $context['post_box_name'] ,'"; |
|
807 | + var oEditorID = "', $context['post_box_name'], '"; |
|
808 | 808 | var oEditorObject = oEditorHandle_', $context['post_box_name'], '; |
809 | 809 | </script>'; |
810 | 810 | |
@@ -836,7 +836,7 @@ discard block |
||
836 | 836 | if ($context['can_quote']) |
837 | 837 | echo ' |
838 | 838 | <ul class="quickbuttons" id="msg_', $post['id'], '_quote"> |
839 | - <li style="display:none;" id="quoteSelected_', $post['id'], '" data-msgid="', $post['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'] ,'</a></li> |
|
839 | + <li style="display:none;" id="quoteSelected_', $post['id'], '" data-msgid="', $post['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'], '</a></li> |
|
840 | 840 | <li id="post_modify"><a href="#postmodify" onclick="return insertQuoteFast(', $post['id'], ');"><span class="generic_icons quote"></span>', $txt['quote'], '</a></li> |
841 | 841 | </ul>'; |
842 | 842 | |
@@ -920,7 +920,7 @@ discard block |
||
920 | 920 | <head> |
921 | 921 | <meta charset="', $context['character_set'], '"> |
922 | 922 | <title>', $txt['spell_check'], '</title> |
923 | - <link rel="stylesheet" href="', $settings['theme_url'], '/css/index', $context['theme_variant'], '.css', $modSettings['browser_cache'] ,'"> |
|
923 | + <link rel="stylesheet" href="', $settings['theme_url'], '/css/index', $context['theme_variant'], '.css', $modSettings['browser_cache'], '"> |
|
924 | 924 | <style> |
925 | 925 | body, td { |
926 | 926 | font-size: small; |
@@ -950,8 +950,8 @@ discard block |
||
950 | 950 | var spell_formname = window.opener.spell_formname; |
951 | 951 | var spell_fieldname = window.opener.spell_fieldname; |
952 | 952 | </script> |
953 | - <script src="', $settings['default_theme_url'], '/scripts/spellcheck.js', $modSettings['browser_cache'] ,'"></script> |
|
954 | - <script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'] ,'"></script> |
|
953 | + <script src="', $settings['default_theme_url'], '/scripts/spellcheck.js', $modSettings['browser_cache'], '"></script> |
|
954 | + <script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'], '"></script> |
|
955 | 955 | <script> |
956 | 956 | ', $context['spell_js'], ' |
957 | 957 | </script> |
@@ -995,7 +995,7 @@ discard block |
||
995 | 995 | <head> |
996 | 996 | <meta charset="', $context['character_set'], '"> |
997 | 997 | <title>', $txt['retrieving_quote'], '</title> |
998 | - <script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'] ,'"></script> |
|
998 | + <script src="', $settings['default_theme_url'], '/scripts/script.js', $modSettings['browser_cache'], '"></script> |
|
999 | 999 | </head> |
1000 | 1000 | <body> |
1001 | 1001 | ', $txt['retrieving_quote'], ' |
@@ -22,24 +22,26 @@ discard block |
||
22 | 22 | <script>'; |
23 | 23 | |
24 | 24 | // When using Go Back due to fatal_error, allow the form to be re-submitted with changes. |
25 | - if (isBrowser('is_firefox')) |
|
26 | - echo ' |
|
25 | + if (isBrowser('is_firefox')) { |
|
26 | + echo ' |
|
27 | 27 | window.addEventListener("pageshow", reActivate, false);'; |
28 | + } |
|
28 | 29 | |
29 | 30 | // Start with message icons - and any missing from this theme. |
30 | 31 | echo ' |
31 | 32 | var icon_urls = {'; |
32 | 33 | |
33 | - foreach ($context['icons'] as $icon) |
|
34 | - echo ' |
|
34 | + foreach ($context['icons'] as $icon) { |
|
35 | + echo ' |
|
35 | 36 | \'', $icon['value'], '\': \'', $icon['url'], '\'', $icon['is_last'] ? '' : ','; |
37 | + } |
|
36 | 38 | |
37 | 39 | echo ' |
38 | 40 | };'; |
39 | 41 | |
40 | 42 | // If this is a poll - use some javascript to ensure the user doesn't create a poll with illegal option combinations. |
41 | - if ($context['make_poll']) |
|
42 | - echo ' |
|
43 | + if ($context['make_poll']) { |
|
44 | + echo ' |
|
43 | 45 | var pollOptionNum = 0, pollTabIndex; |
44 | 46 | var pollOptionId = ', $context['last_choice_id'], '; |
45 | 47 | function addPollOption() |
@@ -58,11 +60,13 @@ discard block |
||
58 | 60 | |
59 | 61 | setOuterHTML(document.getElementById(\'pollMoreOptions\'), ', JavaScriptEscape('<dt><label for="options-'), ' + pollOptionId + ', JavaScriptEscape('">' . $txt['option'] . ' '), ' + pollOptionNum + ', JavaScriptEscape('</label>:</dt><dd><input type="text" name="options['), ' + pollOptionId + ', JavaScriptEscape(']" id="options-'), ' + pollOptionId + ', JavaScriptEscape('" value="" size="80" maxlength="255" tabindex="'), ' + pollTabIndex + ', JavaScriptEscape('"></dd><p id="pollMoreOptions"></p>'), '); |
60 | 62 | }'; |
63 | + } |
|
61 | 64 | |
62 | 65 | // If we are making a calendar event we want to ensure we show the current days in a month etc... this is done here. |
63 | - if ($context['make_event']) |
|
64 | - echo ' |
|
66 | + if ($context['make_event']) { |
|
67 | + echo ' |
|
65 | 68 | var monthLength = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31];'; |
69 | + } |
|
66 | 70 | |
67 | 71 | // End of the javascript, start the form and display the link tree. |
68 | 72 | echo ' |
@@ -83,9 +87,10 @@ discard block |
||
83 | 87 | </div> |
84 | 88 | <br>'; |
85 | 89 | |
86 | - if ($context['make_event'] && (!$context['event']['new'] || !empty($context['current_board']))) |
|
87 | - echo ' |
|
90 | + if ($context['make_event'] && (!$context['event']['new'] || !empty($context['current_board']))) { |
|
91 | + echo ' |
|
88 | 92 | <input type="hidden" name="eventid" value="', $context['event']['id'], '">'; |
93 | + } |
|
89 | 94 | |
90 | 95 | // Start the main table. |
91 | 96 | echo ' |
@@ -110,26 +115,29 @@ discard block |
||
110 | 115 | </div>'; |
111 | 116 | |
112 | 117 | // If this won't be approved let them know! |
113 | - if (!$context['becomes_approved']) |
|
114 | - echo ' |
|
118 | + if (!$context['becomes_approved']) { |
|
119 | + echo ' |
|
115 | 120 | <div class="noticebox"> |
116 | 121 | <em>', $txt['wait_for_approval'], '</em> |
117 | 122 | <input type="hidden" name="not_approved" value="1"> |
118 | 123 | </div>'; |
124 | + } |
|
119 | 125 | |
120 | 126 | // If it's locked, show a message to warn the replier. |
121 | - if (!empty($context['locked'])) |
|
122 | - echo ' |
|
127 | + if (!empty($context['locked'])) { |
|
128 | + echo ' |
|
123 | 129 | <div class="errorbox"> |
124 | 130 | ', $txt['topic_locked_no_reply'], ' |
125 | 131 | </div>'; |
132 | + } |
|
126 | 133 | |
127 | - if (!empty($modSettings['drafts_post_enabled'])) |
|
128 | - echo ' |
|
134 | + if (!empty($modSettings['drafts_post_enabled'])) { |
|
135 | + echo ' |
|
129 | 136 | <div id="draft_section" class="infobox"', isset($context['draft_saved']) ? '' : ' style="display: none;"', '>', |
130 | 137 | sprintf($txt['draft_saved'], $scripturl . '?action=profile;u=' . $context['user']['id'] . ';area=showdrafts'), ' |
131 | 138 | ', (!empty($modSettings['drafts_keep_days']) ? ' <strong>' . sprintf($txt['draft_save_warning'], $modSettings['drafts_keep_days']) . '</strong>' : ''), ' |
132 | 139 | </div>'; |
140 | + } |
|
133 | 141 | |
134 | 142 | // The post header... important stuff |
135 | 143 | echo ' |
@@ -139,14 +147,15 @@ discard block |
||
139 | 147 | // Mod & theme authors can use the 'integrate_post_end' hook to modify or add to these (see Post.php) |
140 | 148 | if (!empty($context['posting_fields']) && is_array($context['posting_fields'])) |
141 | 149 | { |
142 | - foreach ($context['posting_fields'] as $pfid => $pf) |
|
143 | - echo ' |
|
150 | + foreach ($context['posting_fields'] as $pfid => $pf) { |
|
151 | + echo ' |
|
144 | 152 | <dt class="clear', !is_numeric($pfid) ? ' pf_' . $pfid : '', '"> |
145 | 153 | ', $pf['dt'], ' |
146 | 154 | </dt> |
147 | 155 | <dd', !is_numeric($pfid) ? ' class="pf_' . $pfid . '"' : '', '> |
148 | 156 | ', preg_replace('~<(input|select|textarea|button|area|a|object)\b~', '<$1 tabindex="' . $context['tabindex']++ . '"', $pf['dd']), ' |
149 | 157 | </dd>'; |
158 | + } |
|
150 | 159 | } |
151 | 160 | |
152 | 161 | echo ' |
@@ -180,9 +189,10 @@ discard block |
||
180 | 189 | echo ' |
181 | 190 | <optgroup label="', $category['name'], '">'; |
182 | 191 | |
183 | - foreach ($category['boards'] as $board) |
|
184 | - echo ' |
|
192 | + foreach ($category['boards'] as $board) { |
|
193 | + echo ' |
|
185 | 194 | <option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level'] - 1) . '=>' : '', ' ', $board['name'], '</option>'; |
195 | + } |
|
186 | 196 | echo ' |
187 | 197 | </optgroup>'; |
188 | 198 | } |
@@ -218,9 +228,10 @@ discard block |
||
218 | 228 | <span class="label">', $txt['calendar_timezone'], '</span> |
219 | 229 | <select name="tz" id="tz"', !empty($context['event']['allday']) ? ' disabled' : '', '>'; |
220 | 230 | |
221 | - foreach ($context['all_timezones'] as $tz => $tzname) |
|
222 | - echo ' |
|
231 | + foreach ($context['all_timezones'] as $tz => $tzname) { |
|
232 | + echo ' |
|
223 | 233 | <option', is_numeric($tz) ? ' value="" disabled' : ' value="' . $tz . '"', $tz === $context['event']['tz'] ? ' selected' : '', '>', $tzname, '</option>'; |
234 | + } |
|
224 | 235 | |
225 | 236 | echo ' |
226 | 237 | </select> |
@@ -249,14 +260,15 @@ discard block |
||
249 | 260 | </dd>'; |
250 | 261 | |
251 | 262 | // Loop through all the choices and print them out. |
252 | - foreach ($context['choices'] as $choice) |
|
253 | - echo ' |
|
263 | + foreach ($context['choices'] as $choice) { |
|
264 | + echo ' |
|
254 | 265 | <dt> |
255 | 266 | <label for="options-', $choice['id'], '">', $txt['option'], ' ', $choice['number'], '</label>: |
256 | 267 | </dt> |
257 | 268 | <dd> |
258 | 269 | <input type="text" name="options[', $choice['id'], ']" id="options-', $choice['id'], '" value="', $choice['label'], '" tabindex="', $context['tabindex']++, '" size="80" maxlength="255"> |
259 | 270 | </dd>'; |
271 | + } |
|
260 | 272 | |
261 | 273 | echo ' |
262 | 274 | <p id="pollMoreOptions"></p> |
@@ -286,14 +298,15 @@ discard block |
||
286 | 298 | <input type="checkbox" id="poll_change_vote" name="poll_change_vote"', !empty($context['poll']['change_vote']) ? ' checked' : '', '> |
287 | 299 | </dd>'; |
288 | 300 | |
289 | - if ($context['poll_options']['guest_vote_enabled']) |
|
290 | - echo ' |
|
301 | + if ($context['poll_options']['guest_vote_enabled']) { |
|
302 | + echo ' |
|
291 | 303 | <dt> |
292 | 304 | <label for="poll_guest_vote">', $txt['poll_guest_vote'], ':</label> |
293 | 305 | </dt> |
294 | 306 | <dd> |
295 | 307 | <input type="checkbox" id="poll_guest_vote" name="poll_guest_vote"', !empty($context['poll_options']['guest_vote']) ? ' checked' : '', '> |
296 | 308 | </dd>'; |
309 | + } |
|
297 | 310 | |
298 | 311 | echo ' |
299 | 312 | <dt> |
@@ -314,8 +327,8 @@ discard block |
||
314 | 327 | ', template_control_richedit($context['post_box_name'], 'smileyBox_message', 'bbcBox_message'); |
315 | 328 | |
316 | 329 | // If we're editing and displaying edit details, show a box where they can say why |
317 | - if (isset($context['editing']) && $modSettings['show_modify']) |
|
318 | - echo ' |
|
330 | + if (isset($context['editing']) && $modSettings['show_modify']) { |
|
331 | + echo ' |
|
319 | 332 | <dl> |
320 | 333 | <dt class="clear"> |
321 | 334 | <span id="caption_edit_reason">', $txt['reason_for_edit'], ':</span> |
@@ -324,20 +337,23 @@ discard block |
||
324 | 337 | <input type="text" name="modify_reason"', isset($context['last_modified_reason']) ? ' value="' . $context['last_modified_reason'] . '"' : '', ' tabindex="', $context['tabindex']++, '" size="80" maxlength="80"> |
325 | 338 | </dd> |
326 | 339 | </dl>'; |
340 | + } |
|
327 | 341 | |
328 | 342 | // If this message has been edited in the past - display when it was. |
329 | - if (isset($context['last_modified'])) |
|
330 | - echo ' |
|
343 | + if (isset($context['last_modified'])) { |
|
344 | + echo ' |
|
331 | 345 | <div class="padding smalltext"> |
332 | 346 | ', $context['last_modified_text'], ' |
333 | 347 | </div>'; |
348 | + } |
|
334 | 349 | |
335 | 350 | // If the admin has enabled the hiding of the additional options - show a link and image for it. |
336 | - if (!empty($modSettings['additional_options_collapsable'])) |
|
337 | - echo ' |
|
351 | + if (!empty($modSettings['additional_options_collapsable'])) { |
|
352 | + echo ' |
|
338 | 353 | <div id="postAdditionalOptionsHeader"> |
339 | 354 | <strong><a href="#" id="postMoreExpandLink"> ', $context['can_post_attachment'] ? $txt['post_additionalopt_attach'] : $txt['post_additionalopt'], '</a></strong> |
340 | 355 | </div>'; |
356 | + } |
|
341 | 357 | |
342 | 358 | echo ' |
343 | 359 | <div id="postAdditionalOptions">'; |
@@ -370,19 +386,21 @@ discard block |
||
370 | 386 | ', $txt['uncheck_unwatchd_attach'], ': |
371 | 387 | </dd>'; |
372 | 388 | |
373 | - foreach ($context['current_attachments'] as $attachment) |
|
374 | - echo ' |
|
389 | + foreach ($context['current_attachments'] as $attachment) { |
|
390 | + echo ' |
|
375 | 391 | <dd class="smalltext"> |
376 | 392 | <label for="attachment_', $attachment['attachID'], '"><input type="checkbox" id="attachment_', $attachment['attachID'], '" name="attach_del[]" value="', $attachment['attachID'], '"', empty($attachment['unchecked']) ? ' checked' : '', '> ', $attachment['name'], (empty($attachment['approved']) ? ' (' . $txt['awaiting_approval'] . ')' : ''), |
377 | 393 | !empty($modSettings['attachmentPostLimit']) || !empty($modSettings['attachmentSizeLimit']) ? sprintf($txt['attach_kb'], comma_format(round(max($attachment['size'], 1024) / 1024), 0)) : '', '</label> |
378 | 394 | </dd>'; |
395 | + } |
|
379 | 396 | |
380 | 397 | echo ' |
381 | 398 | </dl>'; |
382 | 399 | |
383 | - if (!empty($context['files_in_session_warning'])) |
|
384 | - echo ' |
|
400 | + if (!empty($context['files_in_session_warning'])) { |
|
401 | + echo ' |
|
385 | 402 | <div class="smalltext">', $context['files_in_session_warning'], '</div>'; |
403 | + } |
|
386 | 404 | } |
387 | 405 | |
388 | 406 | // Is the user allowed to post any additional ones? If so give them the boxes to do it! |
@@ -447,13 +465,14 @@ discard block |
||
447 | 465 | <div class="fallback"> |
448 | 466 | <input type="file" multiple="multiple" name="attachment[]" id="attachment1" class="fallback"> (<a href="javascript:void(0);" onclick="cleanFileInput(\'attachment1\');">', $txt['clean_attach'], '</a>)'; |
449 | 467 | |
450 | - if (!empty($modSettings['attachmentSizeLimit'])) |
|
451 | - echo ' |
|
468 | + if (!empty($modSettings['attachmentSizeLimit'])) { |
|
469 | + echo ' |
|
452 | 470 | <input type="hidden" name="MAX_FILE_SIZE" value="' . $modSettings['attachmentSizeLimit'] * 1024 . '">'; |
471 | + } |
|
453 | 472 | |
454 | 473 | // Show more boxes if they aren't approaching that limit. |
455 | - if ($context['num_allowed_attachments'] > 1) |
|
456 | - echo ' |
|
474 | + if ($context['num_allowed_attachments'] > 1) { |
|
475 | + echo ' |
|
457 | 476 | <script> |
458 | 477 | var allowed_attachments = ', $context['num_allowed_attachments'], '; |
459 | 478 | var current_attachment = 1; |
@@ -473,6 +492,7 @@ discard block |
||
473 | 492 | <a href="#" onclick="addAttachment(); return false;">(', $txt['more_attachments'], ')</a> |
474 | 493 | </div><!-- .fallback --> |
475 | 494 | </div><!-- #attachUpload -->'; |
495 | + } |
|
476 | 496 | |
477 | 497 | echo ' |
478 | 498 | </dd>'; |
@@ -484,21 +504,25 @@ discard block |
||
484 | 504 | <dd class="smalltext">'; |
485 | 505 | |
486 | 506 | // Show some useful information such as allowed extensions, maximum size and amount of attachments allowed. |
487 | - if (!empty($modSettings['attachmentCheckExtensions'])) |
|
488 | - echo ' |
|
507 | + if (!empty($modSettings['attachmentCheckExtensions'])) { |
|
508 | + echo ' |
|
489 | 509 | ', $txt['allowed_types'], ': ', $context['allowed_extensions'], '<br>'; |
510 | + } |
|
490 | 511 | |
491 | - if (!empty($context['attachment_restrictions'])) |
|
492 | - echo ' |
|
512 | + if (!empty($context['attachment_restrictions'])) { |
|
513 | + echo ' |
|
493 | 514 | ', $txt['attach_restrictions'], ' ', implode(', ', $context['attachment_restrictions']), '<br>'; |
515 | + } |
|
494 | 516 | |
495 | - if ($context['num_allowed_attachments'] == 0) |
|
496 | - echo ' |
|
517 | + if ($context['num_allowed_attachments'] == 0) { |
|
518 | + echo ' |
|
497 | 519 | ', $txt['attach_limit_nag'], '<br>'; |
520 | + } |
|
498 | 521 | |
499 | - if (!$context['can_post_attachment_unapproved']) |
|
500 | - echo ' |
|
522 | + if (!$context['can_post_attachment_unapproved']) { |
|
523 | + echo ' |
|
501 | 524 | <span class="alert">', $txt['attachment_requires_approval'], '</span>', '<br>'; |
525 | + } |
|
502 | 526 | |
503 | 527 | echo ' |
504 | 528 | </dd> |
@@ -522,24 +546,26 @@ discard block |
||
522 | 546 | <dt><strong>', $txt['subject'], '</strong></dt> |
523 | 547 | <dd><strong>', $txt['draft_saved_on'], '</strong></dd>'; |
524 | 548 | |
525 | - foreach ($context['drafts'] as $draft) |
|
526 | - echo ' |
|
549 | + foreach ($context['drafts'] as $draft) { |
|
550 | + echo ' |
|
527 | 551 | <dt>', $draft['link'], '</dt> |
528 | 552 | <dd>', $draft['poster_time'], '</dd>'; |
553 | + } |
|
529 | 554 | echo ' |
530 | 555 | </dl> |
531 | 556 | </div>'; |
532 | 557 | } |
533 | 558 | |
534 | 559 | // Is visual verification enabled? |
535 | - if ($context['require_verification']) |
|
536 | - echo ' |
|
560 | + if ($context['require_verification']) { |
|
561 | + echo ' |
|
537 | 562 | <div class="post_verification"> |
538 | 563 | <span', !empty($context['post_error']['need_qr_verification']) ? ' class="error"' : '', '> |
539 | 564 | <strong>', $txt['verification'], ':</strong> |
540 | 565 | </span> |
541 | 566 | ', template_control_verification($context['visual_verification_id'], 'all'), ' |
542 | 567 | </div>'; |
568 | + } |
|
543 | 569 | |
544 | 570 | // Finally, the submit buttons. |
545 | 571 | echo ' |
@@ -548,9 +574,10 @@ discard block |
||
548 | 574 | ', template_control_richedit_buttons($context['post_box_name']); |
549 | 575 | |
550 | 576 | // Option to delete an event if user is editing one. |
551 | - if ($context['make_event'] && !$context['event']['new']) |
|
552 | - echo ' |
|
577 | + if ($context['make_event'] && !$context['event']['new']) { |
|
578 | + echo ' |
|
553 | 579 | <input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['event_delete_confirm'] ,'" class="button you_sure">'; |
580 | + } |
|
554 | 581 | |
555 | 582 | echo ' |
556 | 583 | </span> |
@@ -559,9 +586,10 @@ discard block |
||
559 | 586 | <br class="clear">'; |
560 | 587 | |
561 | 588 | // Assuming this isn't a new topic pass across the last message id. |
562 | - if (isset($context['topic_last_message'])) |
|
563 | - echo ' |
|
589 | + if (isset($context['topic_last_message'])) { |
|
590 | + echo ' |
|
564 | 591 | <input type="hidden" name="last_msg" value="', $context['topic_last_message'], '">'; |
592 | + } |
|
565 | 593 | |
566 | 594 | echo ' |
567 | 595 | <input type="hidden" name="additional_options" id="additional_options" value="', $context['show_additional_options'] ? '1' : '0', '"> |
@@ -704,9 +732,10 @@ discard block |
||
704 | 732 | |
705 | 733 | newPostsHTML += \'<div class="windowbg\' + (++reply_counter % 2 == 0 ? \'2\' : \'\') + \'"><div id="msg\' + newPosts[i].getAttribute("id") + \'"><div class="floatleft"><h5>', $txt['posted_by'], ': \' + newPosts[i].getElementsByTagName("poster")[0].firstChild.nodeValue + \'</h5><span class="smalltext">« <strong>', $txt['on'], ':</strong> \' + newPosts[i].getElementsByTagName("time")[0].firstChild.nodeValue + \' »</span> <span class="new_posts" id="image_new_\' + newPosts[i].getAttribute("id") + \'">', $txt['new'], '</span></div>\';'; |
706 | 734 | |
707 | - if ($context['can_quote']) |
|
708 | - echo ' |
|
735 | + if ($context['can_quote']) { |
|
736 | + echo ' |
|
709 | 737 | newPostsHTML += \'<ul class="quickbuttons" id="msg_\' + newPosts[i].getAttribute("id") + \'_quote"><li><a href="#postmodify" onclick="return insertQuoteFast(\\\'\' + newPosts[i].getAttribute("id") + \'\\\');" class="quote_button"><span>', $txt['quote'], '</span><\' + \'/a></li></ul>\';'; |
738 | + } |
|
710 | 739 | |
711 | 740 | echo ' |
712 | 741 | newPostsHTML += \'<br class="clear">\'; |
@@ -749,8 +778,8 @@ discard block |
||
749 | 778 | }'; |
750 | 779 | |
751 | 780 | // Code for showing and hiding additional options. |
752 | - if (!empty($modSettings['additional_options_collapsable'])) |
|
753 | - echo ' |
|
781 | + if (!empty($modSettings['additional_options_collapsable'])) { |
|
782 | + echo ' |
|
754 | 783 | var oSwapAdditionalOptions = new smc_Toggle({ |
755 | 784 | bToggleEnabled: true, |
756 | 785 | bCurrentlyCollapsed: ', $context['show_additional_options'] ? 'false' : 'true', ', |
@@ -778,10 +807,11 @@ discard block |
||
778 | 807 | } |
779 | 808 | ] |
780 | 809 | });'; |
810 | + } |
|
781 | 811 | |
782 | 812 | // Code for showing and hiding drafts |
783 | - if (!empty($context['drafts'])) |
|
784 | - echo ' |
|
813 | + if (!empty($context['drafts'])) { |
|
814 | + echo ' |
|
785 | 815 | var oSwapDraftOptions = new smc_Toggle({ |
786 | 816 | bToggleEnabled: true, |
787 | 817 | bCurrentlyCollapsed: true, |
@@ -803,6 +833,7 @@ discard block |
||
803 | 833 | } |
804 | 834 | ] |
805 | 835 | });'; |
836 | + } |
|
806 | 837 | |
807 | 838 | echo ' |
808 | 839 | var oEditorID = "', $context['post_box_name'] ,'"; |
@@ -823,8 +854,9 @@ discard block |
||
823 | 854 | foreach ($context['previous_posts'] as $post) |
824 | 855 | { |
825 | 856 | $ignoring = false; |
826 | - if (!empty($post['is_ignored'])) |
|
827 | - $ignored_posts[] = $ignoring = $post['id']; |
|
857 | + if (!empty($post['is_ignored'])) { |
|
858 | + $ignored_posts[] = $ignoring = $post['id']; |
|
859 | + } |
|
828 | 860 | |
829 | 861 | echo ' |
830 | 862 | <div class="windowbg"> |
@@ -834,22 +866,24 @@ discard block |
||
834 | 866 | </h5> |
835 | 867 | - ', $post['time']; |
836 | 868 | |
837 | - if ($context['can_quote']) |
|
838 | - echo ' |
|
869 | + if ($context['can_quote']) { |
|
870 | + echo ' |
|
839 | 871 | <ul class="quickbuttons" id="msg_', $post['id'], '_quote"> |
840 | 872 | <li style="display:none;" id="quoteSelected_', $post['id'], '" data-msgid="', $post['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'] ,'</a></li> |
841 | 873 | <li id="post_modify"><a href="#postmodify" onclick="return insertQuoteFast(', $post['id'], ');"><span class="generic_icons quote"></span>', $txt['quote'], '</a></li> |
842 | 874 | </ul>'; |
875 | + } |
|
843 | 876 | |
844 | 877 | echo ' |
845 | 878 | <br class="clear">'; |
846 | 879 | |
847 | - if ($ignoring) |
|
848 | - echo ' |
|
880 | + if ($ignoring) { |
|
881 | + echo ' |
|
849 | 882 | <div id="msg_', $post['id'], '_ignored_prompt" class="smalltext"> |
850 | 883 | ', $txt['ignoring_user'], ' |
851 | 884 | <a href="#" id="msg_', $post['id'], '_ignored_link" style="display: none;">', $txt['show_ignore_user_post'], '</a> |
852 | 885 | </div>'; |
886 | + } |
|
853 | 887 | |
854 | 888 | echo ' |
855 | 889 | <div class="list_posts smalltext" id="msg_', $post['id'], '_body" data-msgid="', $post['id'], '">', $post['message'], '</div> |
@@ -1004,10 +1038,10 @@ discard block |
||
1004 | 1038 | <div id="temporary_posting_area" style="display: none;"></div> |
1005 | 1039 | <script>'; |
1006 | 1040 | |
1007 | - if ($context['close_window']) |
|
1008 | - echo ' |
|
1041 | + if ($context['close_window']) { |
|
1042 | + echo ' |
|
1009 | 1043 | window.close();'; |
1010 | - else |
|
1044 | + } else |
|
1011 | 1045 | { |
1012 | 1046 | // Lucky for us, Internet Explorer has an "innerText" feature which basically converts entities <--> text. Use it if possible ;) |
1013 | 1047 | echo ' |
@@ -1061,11 +1095,12 @@ discard block |
||
1061 | 1095 | </p> |
1062 | 1096 | <ul>'; |
1063 | 1097 | |
1064 | - foreach ($context['groups'] as $group) |
|
1065 | - echo ' |
|
1098 | + foreach ($context['groups'] as $group) { |
|
1099 | + echo ' |
|
1066 | 1100 | <li> |
1067 | 1101 | <label for="who_', $group['id'], '"><input type="checkbox" name="who[', $group['id'], ']" id="who_', $group['id'], '" value="', $group['id'], '" checked> ', $group['name'], '</label> <em>(', $group['member_count'], ')</em> |
1068 | 1102 | </li>'; |
1103 | + } |
|
1069 | 1104 | |
1070 | 1105 | echo ' |
1071 | 1106 | <li> |
@@ -70,7 +70,7 @@ discard block |
||
70 | 70 | |
71 | 71 | echo ' |
72 | 72 | <div class="main_container"> |
73 | - <div class="cat_bar ', $category['is_collapsed'] ? 'collapsed' : '','" id="category_', $category['id'], '"> |
|
73 | + <div class="cat_bar ', $category['is_collapsed'] ? 'collapsed' : '', '" id="category_', $category['id'], '"> |
|
74 | 74 | <h3 class="catbg">'; |
75 | 75 | |
76 | 76 | // If this category even can collapse, show a link to collapse it. |
@@ -249,7 +249,7 @@ discard block |
||
249 | 249 | foreach ($board['children'] as $child) |
250 | 250 | { |
251 | 251 | if (!$child['is_redirect']) |
252 | - $child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
252 | + $child['link'] = '' . ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
253 | 253 | else |
254 | 254 | $child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . ' - ' . $child['short_description'] . '">' . $child['name'] . '</a>'; |
255 | 255 |
@@ -31,9 +31,10 @@ discard block |
||
31 | 31 | echo ' |
32 | 32 | <ul id="smf_slider" class="roundframe">'; |
33 | 33 | |
34 | - foreach ($context['news_lines'] as $news) |
|
35 | - echo ' |
|
34 | + foreach ($context['news_lines'] as $news) { |
|
35 | + echo ' |
|
36 | 36 | <li>', $news, '</li>'; |
37 | + } |
|
37 | 38 | |
38 | 39 | echo ' |
39 | 40 | </ul> |
@@ -65,8 +66,9 @@ discard block |
||
65 | 66 | foreach ($context['categories'] as $category) |
66 | 67 | { |
67 | 68 | // If theres no parent boards we can see, avoid showing an empty category (unless its collapsed) |
68 | - if (empty($category['boards']) && !$category['is_collapsed']) |
|
69 | - continue; |
|
69 | + if (empty($category['boards']) && !$category['is_collapsed']) { |
|
70 | + continue; |
|
71 | + } |
|
70 | 72 | |
71 | 73 | echo ' |
72 | 74 | <div class="main_container"> |
@@ -74,9 +76,10 @@ discard block |
||
74 | 76 | <h3 class="catbg">'; |
75 | 77 | |
76 | 78 | // If this category even can collapse, show a link to collapse it. |
77 | - if ($category['can_collapse']) |
|
78 | - echo ' |
|
79 | + if ($category['can_collapse']) { |
|
80 | + echo ' |
|
79 | 81 | <span id="category_', $category['id'], '_upshrink" class="', $category['is_collapsed'] ? 'toggle_down' : 'toggle_up', ' floatright" data-collapsed="', (int) $category['is_collapsed'], '" title="', !$category['is_collapsed'] ? $txt['hide_category'] : $txt['show_category'], '" style="display: none;"></span>'; |
82 | + } |
|
80 | 83 | |
81 | 84 | echo ' |
82 | 85 | ', $category['link'], ' |
@@ -106,10 +109,11 @@ discard block |
||
106 | 109 | </div>'; |
107 | 110 | |
108 | 111 | // Won't somebody think of the children! |
109 | - if (function_exists('template_bi_' . $board['type'] . '_children')) |
|
110 | - call_user_func('template_bi_' . $board['type'] . '_children', $board); |
|
111 | - else |
|
112 | - template_bi_board_children($board); |
|
112 | + if (function_exists('template_bi_' . $board['type'] . '_children')) { |
|
113 | + call_user_func('template_bi_' . $board['type'] . '_children', $board); |
|
114 | + } else { |
|
115 | + template_bi_board_children($board); |
|
116 | + } |
|
113 | 117 | |
114 | 118 | echo ' |
115 | 119 | </div><!-- #board_[id] -->'; |
@@ -124,12 +128,13 @@ discard block |
||
124 | 128 | </div><!-- #boardindex_table -->'; |
125 | 129 | |
126 | 130 | // Show the mark all as read button? |
127 | - if ($context['user']['is_logged'] && !empty($context['categories'])) |
|
128 | - echo ' |
|
131 | + if ($context['user']['is_logged'] && !empty($context['categories'])) { |
|
132 | + echo ' |
|
129 | 133 | <div class="mark_read"> |
130 | 134 | ', template_button_strip($context['mark_read_button'], 'right'), ' |
131 | 135 | </div>'; |
132 | -} |
|
136 | + } |
|
137 | + } |
|
133 | 138 | |
134 | 139 | /** |
135 | 140 | * Outputs the board icon for a standard board. |
@@ -173,18 +178,20 @@ discard block |
||
173 | 178 | </a>'; |
174 | 179 | |
175 | 180 | // Has it outstanding posts for approval? |
176 | - if ($board['can_approve_posts'] && ($board['unapproved_posts'] || $board['unapproved_topics'])) |
|
177 | - echo ' |
|
181 | + if ($board['can_approve_posts'] && ($board['unapproved_posts'] || $board['unapproved_topics'])) { |
|
182 | + echo ' |
|
178 | 183 | <a href="', $scripturl, '?action=moderate;area=postmod;sa=', ($board['unapproved_topics'] > 0 ? 'topics' : 'posts'), ';brd=', $board['id'], ';', $context['session_var'], '=', $context['session_id'], '" title="', sprintf($txt['unapproved_posts'], $board['unapproved_topics'], $board['unapproved_posts']), '" class="moderation_link">(!)</a>'; |
184 | + } |
|
179 | 185 | |
180 | 186 | echo ' |
181 | 187 | <p class="board_description">', $board['description'], '</p>'; |
182 | 188 | |
183 | 189 | // Show the "Moderators: ". Each has name, href, link, and id. (but we're gonna use link_moderators.) |
184 | - if (!empty($board['link_moderators'])) |
|
185 | - echo ' |
|
190 | + if (!empty($board['link_moderators'])) { |
|
191 | + echo ' |
|
186 | 192 | <p class="moderators">', count($board['link_moderators']) == 1 ? $txt['moderator'] : $txt['moderators'], ': ', implode(', ', $board['link_moderators']), '</p>'; |
187 | -} |
|
193 | + } |
|
194 | + } |
|
188 | 195 | |
189 | 196 | /** |
190 | 197 | * Outputs the board stats for a standard board. |
@@ -225,10 +232,11 @@ discard block |
||
225 | 232 | */ |
226 | 233 | function template_bi_board_lastpost($board) |
227 | 234 | { |
228 | - if (!empty($board['last_post']['id'])) |
|
229 | - echo ' |
|
235 | + if (!empty($board['last_post']['id'])) { |
|
236 | + echo ' |
|
230 | 237 | <p>', $board['last_post']['last_post_message'], '</p>'; |
231 | -} |
|
238 | + } |
|
239 | + } |
|
232 | 240 | |
233 | 241 | /** |
234 | 242 | * Outputs the board children for a standard board. |
@@ -248,14 +256,16 @@ discard block |
||
248 | 256 | id, name, description, new (is it new?), topics (#), posts (#), href, link, and last_post. */ |
249 | 257 | foreach ($board['children'] as $child) |
250 | 258 | { |
251 | - if (!$child['is_redirect']) |
|
252 | - $child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
253 | - else |
|
254 | - $child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . ' - ' . $child['short_description'] . '">' . $child['name'] . '</a>'; |
|
259 | + if (!$child['is_redirect']) { |
|
260 | + $child['link'] = ''. ($child['new'] ? '<a href="' . $scripturl . '?action=unread;board=' . $child['id'] . '" title="' . $txt['new_posts'] . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')" class="new_posts">' . $txt['new'] . '</a>' : '') . '<a href="' . $child['href'] . '" ' . ($child['new'] ? 'class="board_new_posts" ' : '') . 'title="' . ($child['new'] ? $txt['new_posts'] : $txt['old_posts']) . ' (' . $txt['board_topics'] . ': ' . comma_format($child['topics']) . ', ' . $txt['posts'] . ': ' . comma_format($child['posts']) . ')">' . $child['name'] . '</a>'; |
|
261 | + } else { |
|
262 | + $child['link'] = '<a href="' . $child['href'] . '" title="' . comma_format($child['posts']) . ' ' . $txt['redirects'] . ' - ' . $child['short_description'] . '">' . $child['name'] . '</a>'; |
|
263 | + } |
|
255 | 264 | |
256 | 265 | // Has it posts awaiting approval? |
257 | - if ($child['can_approve_posts'] && ($child['unapproved_posts'] || $child['unapproved_topics'])) |
|
258 | - $child['link'] .= ' <a href="' . $scripturl . '?action=moderate;area=postmod;sa=' . ($child['unapproved_topics'] > 0 ? 'topics' : 'posts') . ';brd=' . $child['id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" title="' . sprintf($txt['unapproved_posts'], $child['unapproved_topics'], $child['unapproved_posts']) . '" class="moderation_link">(!)</a>'; |
|
266 | + if ($child['can_approve_posts'] && ($child['unapproved_posts'] || $child['unapproved_topics'])) { |
|
267 | + $child['link'] .= ' <a href="' . $scripturl . '?action=moderate;area=postmod;sa=' . ($child['unapproved_topics'] > 0 ? 'topics' : 'posts') . ';brd=' . $child['id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" title="' . sprintf($txt['unapproved_posts'], $child['unapproved_topics'], $child['unapproved_posts']) . '" class="moderation_link">(!)</a>'; |
|
268 | + } |
|
259 | 269 | |
260 | 270 | $children[] = $child['new'] ? '<span class="strong">' . $child['link'] . '</span>' : '<span>' . $child['link'] . '</span>'; |
261 | 271 | } |
@@ -282,8 +292,9 @@ discard block |
||
282 | 292 | { |
283 | 293 | global $context, $options, $txt; |
284 | 294 | |
285 | - if (empty($context['info_center'])) |
|
286 | - return; |
|
295 | + if (empty($context['info_center'])) { |
|
296 | + return; |
|
297 | + } |
|
287 | 298 | |
288 | 299 | // Here's where the "Info Center" starts... |
289 | 300 | echo ' |
@@ -383,14 +394,15 @@ discard block |
||
383 | 394 | /* Each post in latest_posts has: |
384 | 395 | board (with an id, name, and link.), topic (the topic's id.), poster (with id, name, and link.), |
385 | 396 | subject, short_subject (shortened with...), time, link, and href. */ |
386 | - foreach ($context['latest_posts'] as $post) |
|
387 | - echo ' |
|
397 | + foreach ($context['latest_posts'] as $post) { |
|
398 | + echo ' |
|
388 | 399 | <tr class="windowbg"> |
389 | 400 | <td class="recentpost"><strong>', $post['link'], '</strong></td> |
390 | 401 | <td class="recentposter">', $post['poster']['link'], '</td> |
391 | 402 | <td class="recentboard">', $post['board']['link'], '</td> |
392 | 403 | <td class="recenttime">', $post['time'], '</td> |
393 | 404 | </tr>'; |
405 | + } |
|
394 | 406 | echo ' |
395 | 407 | </table>'; |
396 | 408 | } |
@@ -414,11 +426,12 @@ discard block |
||
414 | 426 | </div>'; |
415 | 427 | |
416 | 428 | // Holidays like "Christmas", "Chanukah", and "We Love [Unknown] Day" :P |
417 | - if (!empty($context['calendar_holidays'])) |
|
418 | - echo ' |
|
429 | + if (!empty($context['calendar_holidays'])) { |
|
430 | + echo ' |
|
419 | 431 | <p class="inline holiday"> |
420 | 432 | <span>', $txt['calendar_prompt'], '</span> ', implode(', ', $context['calendar_holidays']), ' |
421 | 433 | </p>'; |
434 | + } |
|
422 | 435 | |
423 | 436 | // People's birthdays. Like mine. And yours, I guess. Kidding. |
424 | 437 | if (!empty($context['calendar_birthdays'])) |
@@ -428,9 +441,10 @@ discard block |
||
428 | 441 | <span class="birthday">', $context['calendar_only_today'] ? $txt['birthdays'] : $txt['birthdays_upcoming'], '</span>'; |
429 | 442 | |
430 | 443 | // Each member in calendar_birthdays has: id, name (person), age (if they have one set?), is_last. (last in list?), and is_today (birthday is today?) |
431 | - foreach ($context['calendar_birthdays'] as $member) |
|
432 | - echo ' |
|
444 | + foreach ($context['calendar_birthdays'] as $member) { |
|
445 | + echo ' |
|
433 | 446 | <a href="', $scripturl, '?action=profile;u=', $member['id'], '">', $member['is_today'] ? '<strong class="fix_rtl_names">' : '', $member['name'], $member['is_today'] ? '</strong>' : '', isset($member['age']) ? ' (' . $member['age'] . ')' : '', '</a>', $member['is_last'] ? '' : ', '; |
447 | + } |
|
434 | 448 | |
435 | 449 | echo ' |
436 | 450 | </p>'; |
@@ -445,9 +459,10 @@ discard block |
||
445 | 459 | |
446 | 460 | // Each event in calendar_events should have: |
447 | 461 | // title, href, is_last, can_edit (are they allowed?), modify_href, and is_today. |
448 | - foreach ($context['calendar_events'] as $event) |
|
449 | - echo ' |
|
462 | + foreach ($context['calendar_events'] as $event) { |
|
463 | + echo ' |
|
450 | 464 | ', $event['can_edit'] ? '<a href="' . $event['modify_href'] . '" title="' . $txt['calendar_edit'] . '"><span class="generic_icons calendar_modify"></span></a> ' : '', $event['href'] == '' ? '' : '<a href="' . $event['href'] . '">', $event['is_today'] ? '<strong>' . $event['title'] . '</strong>' : $event['title'], $event['href'] == '' ? '' : '</a>', $event['is_last'] ? '<br>' : ', '; |
465 | + } |
|
451 | 466 | echo ' |
452 | 467 | </p>'; |
453 | 468 | } |
@@ -493,17 +508,21 @@ discard block |
||
493 | 508 | // Handle hidden users and buddies. |
494 | 509 | $bracketList = array(); |
495 | 510 | |
496 | - if ($context['show_buddies']) |
|
497 | - $bracketList[] = comma_format($context['num_buddies']) . ' ' . ($context['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']); |
|
511 | + if ($context['show_buddies']) { |
|
512 | + $bracketList[] = comma_format($context['num_buddies']) . ' ' . ($context['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']); |
|
513 | + } |
|
498 | 514 | |
499 | - if (!empty($context['num_spiders'])) |
|
500 | - $bracketList[] = comma_format($context['num_spiders']) . ' ' . ($context['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']); |
|
515 | + if (!empty($context['num_spiders'])) { |
|
516 | + $bracketList[] = comma_format($context['num_spiders']) . ' ' . ($context['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']); |
|
517 | + } |
|
501 | 518 | |
502 | - if (!empty($context['num_users_hidden'])) |
|
503 | - $bracketList[] = comma_format($context['num_users_hidden']) . ' ' . ($context['num_spiders'] == 1 ? $txt['hidden'] : $txt['hidden_s']); |
|
519 | + if (!empty($context['num_users_hidden'])) { |
|
520 | + $bracketList[] = comma_format($context['num_users_hidden']) . ' ' . ($context['num_spiders'] == 1 ? $txt['hidden'] : $txt['hidden_s']); |
|
521 | + } |
|
504 | 522 | |
505 | - if (!empty($bracketList)) |
|
506 | - echo ' (' . implode(', ', $bracketList) . ')'; |
|
523 | + if (!empty($bracketList)) { |
|
524 | + echo ' (' . implode(', ', $bracketList) . ')'; |
|
525 | + } |
|
507 | 526 | |
508 | 527 | echo $context['show_who'] ? '</a>' : '', ' |
509 | 528 | |
@@ -517,9 +536,10 @@ discard block |
||
517 | 536 | ', sprintf($txt['users_active'], $modSettings['lastActive']), ': ', implode(', ', $context['list_users_online']); |
518 | 537 | |
519 | 538 | // Showing membergroups? |
520 | - if (!empty($settings['show_group_key']) && !empty($context['membergroups'])) |
|
521 | - echo ' |
|
539 | + if (!empty($settings['show_group_key']) && !empty($context['membergroups'])) { |
|
540 | + echo ' |
|
522 | 541 | <span class="membergroups">' . implode(', ', $context['membergroups']) . '</span>'; |
542 | + } |
|
523 | 543 | } |
524 | 544 | |
525 | 545 | echo ' |
@@ -12,8 +12,9 @@ discard block |
||
12 | 12 | */ |
13 | 13 | |
14 | 14 | // Don't do anything if SMF is already loaded. |
15 | -if (defined('SMF')) |
|
15 | +if (defined('SMF')) { |
|
16 | 16 | return true; |
17 | +} |
|
17 | 18 | |
18 | 19 | define('SMF', 'SSI'); |
19 | 20 | |
@@ -28,16 +29,18 @@ discard block |
||
28 | 29 | $time_start = microtime(true); |
29 | 30 | |
30 | 31 | // Just being safe... |
31 | -foreach (array('db_character_set', 'cachedir') as $variable) |
|
32 | +foreach (array('db_character_set', 'cachedir') as $variable) { |
|
32 | 33 | if (isset($GLOBALS[$variable])) |
33 | 34 | unset($GLOBALS[$variable]); |
35 | +} |
|
34 | 36 | |
35 | 37 | // Get the forum's settings for database and file paths. |
36 | 38 | require_once(dirname(__FILE__) . '/Settings.php'); |
37 | 39 | |
38 | 40 | // Make absolutely sure the cache directory is defined. |
39 | -if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) |
|
41 | +if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) { |
|
40 | 42 | $cachedir = $boarddir . '/cache'; |
43 | +} |
|
41 | 44 | |
42 | 45 | $ssi_error_reporting = error_reporting(E_ALL); |
43 | 46 | /* Set this to one of three values depending on what you want to happen in the case of a fatal error. |
@@ -48,12 +51,14 @@ discard block |
||
48 | 51 | $ssi_on_error_method = false; |
49 | 52 | |
50 | 53 | // Don't do john didley if the forum's been shut down completely. |
51 | -if ($maintenance == 2 && (!isset($ssi_maintenance_off) || $ssi_maintenance_off !== true)) |
|
54 | +if ($maintenance == 2 && (!isset($ssi_maintenance_off) || $ssi_maintenance_off !== true)) { |
|
52 | 55 | die($mmessage); |
56 | +} |
|
53 | 57 | |
54 | 58 | // Fix for using the current directory as a path. |
55 | -if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.') |
|
59 | +if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.') { |
|
56 | 60 | $sourcedir = dirname(__FILE__) . substr($sourcedir, 1); |
61 | +} |
|
57 | 62 | |
58 | 63 | // Load the important includes. |
59 | 64 | require_once($sourcedir . '/QueryString.php'); |
@@ -78,26 +83,30 @@ discard block |
||
78 | 83 | cleanRequest(); |
79 | 84 | |
80 | 85 | // Seed the random generator? |
81 | -if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69) |
|
86 | +if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69) { |
|
82 | 87 | smf_seed_generator(); |
88 | +} |
|
83 | 89 | |
84 | 90 | // Check on any hacking attempts. |
85 | -if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS'])) |
|
91 | +if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS'])) { |
|
86 | 92 | die('No direct access...'); |
87 | -elseif (isset($_REQUEST['ssi_theme']) && (int) $_REQUEST['ssi_theme'] == (int) $ssi_theme) |
|
93 | +} elseif (isset($_REQUEST['ssi_theme']) && (int) $_REQUEST['ssi_theme'] == (int) $ssi_theme) { |
|
88 | 94 | die('No direct access...'); |
89 | -elseif (isset($_COOKIE['ssi_theme']) && (int) $_COOKIE['ssi_theme'] == (int) $ssi_theme) |
|
95 | +} elseif (isset($_COOKIE['ssi_theme']) && (int) $_COOKIE['ssi_theme'] == (int) $ssi_theme) { |
|
90 | 96 | die('No direct access...'); |
91 | -elseif (isset($_REQUEST['ssi_layers'], $ssi_layers) && (@get_magic_quotes_gpc() ? stripslashes($_REQUEST['ssi_layers']) : $_REQUEST['ssi_layers']) == $ssi_layers) |
|
97 | +} elseif (isset($_REQUEST['ssi_layers'], $ssi_layers) && (@get_magic_quotes_gpc() ? stripslashes($_REQUEST['ssi_layers']) : $_REQUEST['ssi_layers']) == $ssi_layers) { |
|
92 | 98 | die('No direct access...'); |
93 | -if (isset($_REQUEST['context'])) |
|
99 | +} |
|
100 | +if (isset($_REQUEST['context'])) { |
|
94 | 101 | die('No direct access...'); |
102 | +} |
|
95 | 103 | |
96 | 104 | // Gzip output? (because it must be boolean and true, this can't be hacked.) |
97 | -if (isset($ssi_gzip) && $ssi_gzip === true && ini_get('zlib.output_compression') != '1' && ini_get('output_handler') != 'ob_gzhandler' && version_compare(PHP_VERSION, '4.2.0', '>=')) |
|
105 | +if (isset($ssi_gzip) && $ssi_gzip === true && ini_get('zlib.output_compression') != '1' && ini_get('output_handler') != 'ob_gzhandler' && version_compare(PHP_VERSION, '4.2.0', '>=')) { |
|
98 | 106 | ob_start('ob_gzhandler'); |
99 | -else |
|
107 | +} else { |
|
100 | 108 | $modSettings['enableCompressedOutput'] = '0'; |
109 | +} |
|
101 | 110 | |
102 | 111 | /** |
103 | 112 | * An autoloader for certain classes. |
@@ -146,9 +155,9 @@ discard block |
||
146 | 155 | ob_start('ob_sessrewrite'); |
147 | 156 | |
148 | 157 | // Start the session... known to scramble SSI includes in cases... |
149 | -if (!headers_sent()) |
|
158 | +if (!headers_sent()) { |
|
150 | 159 | loadSession(); |
151 | -else |
|
160 | +} else |
|
152 | 161 | { |
153 | 162 | if (isset($_COOKIE[session_name()]) || isset($_REQUEST[session_name()])) |
154 | 163 | { |
@@ -182,12 +191,14 @@ discard block |
||
182 | 191 | loadTheme(isset($ssi_theme) ? (int) $ssi_theme : 0); |
183 | 192 | |
184 | 193 | // @todo: probably not the best place, but somewhere it should be set... |
185 | -if (!headers_sent()) |
|
194 | +if (!headers_sent()) { |
|
186 | 195 | header('content-type: text/html; charset=' . (empty($modSettings['global_character_set']) ? (empty($txt['lang_character_set']) ? 'ISO-8859-1' : $txt['lang_character_set']) : $modSettings['global_character_set'])); |
196 | +} |
|
187 | 197 | |
188 | 198 | // Take care of any banning that needs to be done. |
189 | -if (isset($_REQUEST['ssi_ban']) || (isset($ssi_ban) && $ssi_ban === true)) |
|
199 | +if (isset($_REQUEST['ssi_ban']) || (isset($ssi_ban) && $ssi_ban === true)) { |
|
190 | 200 | is_not_banned(); |
201 | +} |
|
191 | 202 | |
192 | 203 | // Do we allow guests in here? |
193 | 204 | if (empty($ssi_guest_access) && empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && basename($_SERVER['PHP_SELF']) != 'SSI.php') |
@@ -202,17 +213,19 @@ discard block |
||
202 | 213 | { |
203 | 214 | $context['template_layers'] = $ssi_layers; |
204 | 215 | template_header(); |
205 | -} |
|
206 | -else |
|
216 | +} else { |
|
207 | 217 | setupThemeContext(); |
218 | +} |
|
208 | 219 | |
209 | 220 | // Make sure they didn't muss around with the settings... but only if it's not cli. |
210 | -if (isset($_SERVER['REMOTE_ADDR']) && !isset($_SERVER['is_cli']) && session_id() == '') |
|
221 | +if (isset($_SERVER['REMOTE_ADDR']) && !isset($_SERVER['is_cli']) && session_id() == '') { |
|
211 | 222 | trigger_error($txt['ssi_session_broken'], E_USER_NOTICE); |
223 | +} |
|
212 | 224 | |
213 | 225 | // Without visiting the forum this session variable might not be set on submit. |
214 | -if (!isset($_SESSION['USER_AGENT']) && (!isset($_GET['ssi_function']) || $_GET['ssi_function'] !== 'pollVote')) |
|
226 | +if (!isset($_SESSION['USER_AGENT']) && (!isset($_GET['ssi_function']) || $_GET['ssi_function'] !== 'pollVote')) { |
|
215 | 227 | $_SESSION['USER_AGENT'] = $_SERVER['HTTP_USER_AGENT']; |
228 | +} |
|
216 | 229 | |
217 | 230 | // Have the ability to easily add functions to SSI. |
218 | 231 | call_integration_hook('integrate_SSI'); |
@@ -221,11 +234,13 @@ discard block |
||
221 | 234 | if (basename($_SERVER['PHP_SELF']) == 'SSI.php') |
222 | 235 | { |
223 | 236 | // You shouldn't just access SSI.php directly by URL!! |
224 | - if (!isset($_GET['ssi_function'])) |
|
225 | - die(sprintf($txt['ssi_not_direct'], $user_info['is_admin'] ? '\'' . addslashes(__FILE__) . '\'' : '\'SSI.php\'')); |
|
237 | + if (!isset($_GET['ssi_function'])) { |
|
238 | + die(sprintf($txt['ssi_not_direct'], $user_info['is_admin'] ? '\'' . addslashes(__FILE__) . '\'' : '\'SSI.php\'')); |
|
239 | + } |
|
226 | 240 | // Call a function passed by GET. |
227 | - if (function_exists('ssi_' . $_GET['ssi_function']) && (!empty($modSettings['allow_guestAccess']) || !$user_info['is_guest'])) |
|
228 | - call_user_func('ssi_' . $_GET['ssi_function']); |
|
241 | + if (function_exists('ssi_' . $_GET['ssi_function']) && (!empty($modSettings['allow_guestAccess']) || !$user_info['is_guest'])) { |
|
242 | + call_user_func('ssi_' . $_GET['ssi_function']); |
|
243 | + } |
|
229 | 244 | exit; |
230 | 245 | } |
231 | 246 | |
@@ -242,9 +257,10 @@ discard block |
||
242 | 257 | */ |
243 | 258 | function ssi_shutdown() |
244 | 259 | { |
245 | - if (!isset($_GET['ssi_function']) || $_GET['ssi_function'] != 'shutdown') |
|
246 | - template_footer(); |
|
247 | -} |
|
260 | + if (!isset($_GET['ssi_function']) || $_GET['ssi_function'] != 'shutdown') { |
|
261 | + template_footer(); |
|
262 | + } |
|
263 | + } |
|
248 | 264 | |
249 | 265 | /** |
250 | 266 | * Display a welcome message, like: Hey, User, you have 0 messages, 0 are new. |
@@ -257,15 +273,17 @@ discard block |
||
257 | 273 | |
258 | 274 | if ($output_method == 'echo') |
259 | 275 | { |
260 | - if ($context['user']['is_guest']) |
|
261 | - echo sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'); |
|
262 | - else |
|
263 | - echo $txt['hello_member'], ' <strong>', $context['user']['name'], '</strong>', allowedTo('pm_read') ? ', ' . (empty($context['user']['messages']) ? $txt['msg_alert_no_messages'] : (($context['user']['messages'] == 1 ? sprintf($txt['msg_alert_one_message'], $scripturl . '?action=pm') : sprintf($txt['msg_alert_many_message'], $scripturl . '?action=pm', $context['user']['messages'])) . ', ' . ($context['user']['unread_messages'] == 1 ? $txt['msg_alert_one_new'] : sprintf($txt['msg_alert_many_new'], $context['user']['unread_messages'])))) : ''; |
|
276 | + if ($context['user']['is_guest']) { |
|
277 | + echo sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'); |
|
278 | + } else { |
|
279 | + echo $txt['hello_member'], ' <strong>', $context['user']['name'], '</strong>', allowedTo('pm_read') ? ', ' . (empty($context['user']['messages']) ? $txt['msg_alert_no_messages'] : (($context['user']['messages'] == 1 ? sprintf($txt['msg_alert_one_message'], $scripturl . '?action=pm') : sprintf($txt['msg_alert_many_message'], $scripturl . '?action=pm', $context['user']['messages'])) . ', ' . ($context['user']['unread_messages'] == 1 ? $txt['msg_alert_one_new'] : sprintf($txt['msg_alert_many_new'], $context['user']['unread_messages'])))) : ''; |
|
280 | + } |
|
264 | 281 | } |
265 | 282 | // Don't echo... then do what?! |
266 | - else |
|
267 | - return $context['user']; |
|
268 | -} |
|
283 | + else { |
|
284 | + return $context['user']; |
|
285 | + } |
|
286 | + } |
|
269 | 287 | |
270 | 288 | /** |
271 | 289 | * Display a menu bar, like is displayed at the top of the forum. |
@@ -276,12 +294,14 @@ discard block |
||
276 | 294 | { |
277 | 295 | global $context; |
278 | 296 | |
279 | - if ($output_method == 'echo') |
|
280 | - template_menu(); |
|
297 | + if ($output_method == 'echo') { |
|
298 | + template_menu(); |
|
299 | + } |
|
281 | 300 | // What else could this do? |
282 | - else |
|
283 | - return $context['menu_buttons']; |
|
284 | -} |
|
301 | + else { |
|
302 | + return $context['menu_buttons']; |
|
303 | + } |
|
304 | + } |
|
285 | 305 | |
286 | 306 | /** |
287 | 307 | * Show a logout link. |
@@ -293,20 +313,23 @@ discard block |
||
293 | 313 | { |
294 | 314 | global $context, $txt, $scripturl; |
295 | 315 | |
296 | - if ($redirect_to != '') |
|
297 | - $_SESSION['logout_url'] = $redirect_to; |
|
316 | + if ($redirect_to != '') { |
|
317 | + $_SESSION['logout_url'] = $redirect_to; |
|
318 | + } |
|
298 | 319 | |
299 | 320 | // Guests can't log out. |
300 | - if ($context['user']['is_guest']) |
|
301 | - return false; |
|
321 | + if ($context['user']['is_guest']) { |
|
322 | + return false; |
|
323 | + } |
|
302 | 324 | |
303 | 325 | $link = '<a href="' . $scripturl . '?action=logout;' . $context['session_var'] . '=' . $context['session_id'] . '">' . $txt['logout'] . '</a>'; |
304 | 326 | |
305 | - if ($output_method == 'echo') |
|
306 | - echo $link; |
|
307 | - else |
|
308 | - return $link; |
|
309 | -} |
|
327 | + if ($output_method == 'echo') { |
|
328 | + echo $link; |
|
329 | + } else { |
|
330 | + return $link; |
|
331 | + } |
|
332 | + } |
|
310 | 333 | |
311 | 334 | /** |
312 | 335 | * Recent post list: [board] Subject by Poster Date |
@@ -322,17 +345,17 @@ discard block |
||
322 | 345 | global $modSettings, $context; |
323 | 346 | |
324 | 347 | // Excluding certain boards... |
325 | - if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) |
|
326 | - $exclude_boards = array($modSettings['recycle_board']); |
|
327 | - else |
|
328 | - $exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards)); |
|
348 | + if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) { |
|
349 | + $exclude_boards = array($modSettings['recycle_board']); |
|
350 | + } else { |
|
351 | + $exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards)); |
|
352 | + } |
|
329 | 353 | |
330 | 354 | // What about including certain boards - note we do some protection here as pre-2.0 didn't have this parameter. |
331 | 355 | if (is_array($include_boards) || (int) $include_boards === $include_boards) |
332 | 356 | { |
333 | 357 | $include_boards = is_array($include_boards) ? $include_boards : array($include_boards); |
334 | - } |
|
335 | - elseif ($include_boards != null) |
|
358 | + } elseif ($include_boards != null) |
|
336 | 359 | { |
337 | 360 | $include_boards = array(); |
338 | 361 | } |
@@ -369,8 +392,9 @@ discard block |
||
369 | 392 | { |
370 | 393 | global $modSettings; |
371 | 394 | |
372 | - if (empty($post_ids)) |
|
373 | - return; |
|
395 | + if (empty($post_ids)) { |
|
396 | + return; |
|
397 | + } |
|
374 | 398 | |
375 | 399 | // Allow the user to request more than one - why not? |
376 | 400 | $post_ids = is_array($post_ids) ? $post_ids : array($post_ids); |
@@ -405,8 +429,9 @@ discard block |
||
405 | 429 | global $scripturl, $txt, $user_info; |
406 | 430 | global $modSettings, $smcFunc, $context; |
407 | 431 | |
408 | - if (!empty($modSettings['enable_likes'])) |
|
409 | - $context['can_like'] = allowedTo('likes_like'); |
|
432 | + if (!empty($modSettings['enable_likes'])) { |
|
433 | + $context['can_like'] = allowedTo('likes_like'); |
|
434 | + } |
|
410 | 435 | |
411 | 436 | // Find all the posts. Newer ones will have higher IDs. |
412 | 437 | $request = $smcFunc['db_query']('substring', ' |
@@ -472,12 +497,13 @@ discard block |
||
472 | 497 | ); |
473 | 498 | |
474 | 499 | // Get the likes for each message. |
475 | - if (!empty($modSettings['enable_likes'])) |
|
476 | - $posts[$row['id_msg']]['likes'] = array( |
|
500 | + if (!empty($modSettings['enable_likes'])) { |
|
501 | + $posts[$row['id_msg']]['likes'] = array( |
|
477 | 502 | 'count' => $row['likes'], |
478 | 503 | 'you' => in_array($row['id_msg'], prepareLikesContext($row['id_topic'])), |
479 | 504 | 'can_like' => !$context['user']['is_guest'] && $row['id_member'] != $context['user']['id'] && !empty($context['can_like']), |
480 | 505 | ); |
506 | + } |
|
481 | 507 | } |
482 | 508 | $smcFunc['db_free_result']($request); |
483 | 509 | |
@@ -485,13 +511,14 @@ discard block |
||
485 | 511 | call_integration_hook('integrate_ssi_queryPosts', array(&$posts)); |
486 | 512 | |
487 | 513 | // Just return it. |
488 | - if ($output_method != 'echo' || empty($posts)) |
|
489 | - return $posts; |
|
514 | + if ($output_method != 'echo' || empty($posts)) { |
|
515 | + return $posts; |
|
516 | + } |
|
490 | 517 | |
491 | 518 | echo ' |
492 | 519 | <table style="border: none" class="ssi_table">'; |
493 | - foreach ($posts as $post) |
|
494 | - echo ' |
|
520 | + foreach ($posts as $post) { |
|
521 | + echo ' |
|
495 | 522 | <tr> |
496 | 523 | <td style="text-align: right; vertical-align: top; white-space: nowrap"> |
497 | 524 | [', $post['board']['link'], '] |
@@ -505,6 +532,7 @@ discard block |
||
505 | 532 | ', $post['time'], ' |
506 | 533 | </td> |
507 | 534 | </tr>'; |
535 | + } |
|
508 | 536 | echo ' |
509 | 537 | </table>'; |
510 | 538 | } |
@@ -522,25 +550,26 @@ discard block |
||
522 | 550 | global $settings, $scripturl, $txt, $user_info; |
523 | 551 | global $modSettings, $smcFunc, $context; |
524 | 552 | |
525 | - if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) |
|
526 | - $exclude_boards = array($modSettings['recycle_board']); |
|
527 | - else |
|
528 | - $exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards)); |
|
553 | + if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) { |
|
554 | + $exclude_boards = array($modSettings['recycle_board']); |
|
555 | + } else { |
|
556 | + $exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards)); |
|
557 | + } |
|
529 | 558 | |
530 | 559 | // Only some boards?. |
531 | 560 | if (is_array($include_boards) || (int) $include_boards === $include_boards) |
532 | 561 | { |
533 | 562 | $include_boards = is_array($include_boards) ? $include_boards : array($include_boards); |
534 | - } |
|
535 | - elseif ($include_boards != null) |
|
563 | + } elseif ($include_boards != null) |
|
536 | 564 | { |
537 | 565 | $output_method = $include_boards; |
538 | 566 | $include_boards = array(); |
539 | 567 | } |
540 | 568 | |
541 | 569 | $icon_sources = array(); |
542 | - foreach ($context['stable_icons'] as $icon) |
|
543 | - $icon_sources[$icon] = 'images_url'; |
|
570 | + foreach ($context['stable_icons'] as $icon) { |
|
571 | + $icon_sources[$icon] = 'images_url'; |
|
572 | + } |
|
544 | 573 | |
545 | 574 | // Find all the posts in distinct topics. Newer ones will have higher IDs. |
546 | 575 | $request = $smcFunc['db_query']('substring', ' |
@@ -565,13 +594,15 @@ discard block |
||
565 | 594 | ) |
566 | 595 | ); |
567 | 596 | $topics = array(); |
568 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
569 | - $topics[$row['id_topic']] = $row; |
|
597 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
598 | + $topics[$row['id_topic']] = $row; |
|
599 | + } |
|
570 | 600 | $smcFunc['db_free_result']($request); |
571 | 601 | |
572 | 602 | // Did we find anything? If not, bail. |
573 | - if (empty($topics)) |
|
574 | - return array(); |
|
603 | + if (empty($topics)) { |
|
604 | + return array(); |
|
605 | + } |
|
575 | 606 | |
576 | 607 | $recycle_board = !empty($modSettings['recycle_enable']) && !empty($modSettings['recycle_board']) ? (int) $modSettings['recycle_board'] : 0; |
577 | 608 | |
@@ -599,19 +630,22 @@ discard block |
||
599 | 630 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
600 | 631 | { |
601 | 632 | $row['body'] = strip_tags(strtr(parse_bbc($row['body'], $row['smileys_enabled'], $row['id_msg']), array('<br>' => ' '))); |
602 | - if ($smcFunc['strlen']($row['body']) > 128) |
|
603 | - $row['body'] = $smcFunc['substr']($row['body'], 0, 128) . '...'; |
|
633 | + if ($smcFunc['strlen']($row['body']) > 128) { |
|
634 | + $row['body'] = $smcFunc['substr']($row['body'], 0, 128) . '...'; |
|
635 | + } |
|
604 | 636 | |
605 | 637 | // Censor the subject. |
606 | 638 | censorText($row['subject']); |
607 | 639 | censorText($row['body']); |
608 | 640 | |
609 | 641 | // Recycled icon |
610 | - if (!empty($recycle_board) && $topics[$row['id_topic']]['id_board']) |
|
611 | - $row['icon'] = 'recycled'; |
|
642 | + if (!empty($recycle_board) && $topics[$row['id_topic']]['id_board']) { |
|
643 | + $row['icon'] = 'recycled'; |
|
644 | + } |
|
612 | 645 | |
613 | - if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) |
|
614 | - $icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
646 | + if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) { |
|
647 | + $icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
648 | + } |
|
615 | 649 | |
616 | 650 | // Build the array. |
617 | 651 | $posts[] = array( |
@@ -650,13 +684,14 @@ discard block |
||
650 | 684 | call_integration_hook('integrate_ssi_recentTopics', array(&$posts)); |
651 | 685 | |
652 | 686 | // Just return it. |
653 | - if ($output_method != 'echo' || empty($posts)) |
|
654 | - return $posts; |
|
687 | + if ($output_method != 'echo' || empty($posts)) { |
|
688 | + return $posts; |
|
689 | + } |
|
655 | 690 | |
656 | 691 | echo ' |
657 | 692 | <table style="border: none" class="ssi_table">'; |
658 | - foreach ($posts as $post) |
|
659 | - echo ' |
|
693 | + foreach ($posts as $post) { |
|
694 | + echo ' |
|
660 | 695 | <tr> |
661 | 696 | <td style="text-align: right; vertical-align: top; white-space: nowrap"> |
662 | 697 | [', $post['board']['link'], '] |
@@ -670,6 +705,7 @@ discard block |
||
670 | 705 | ', $post['time'], ' |
671 | 706 | </td> |
672 | 707 | </tr>'; |
708 | + } |
|
673 | 709 | echo ' |
674 | 710 | </table>'; |
675 | 711 | } |
@@ -694,27 +730,30 @@ discard block |
||
694 | 730 | ) |
695 | 731 | ); |
696 | 732 | $return = array(); |
697 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
698 | - $return[] = array( |
|
733 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
734 | + $return[] = array( |
|
699 | 735 | 'id' => $row['id_member'], |
700 | 736 | 'name' => $row['real_name'], |
701 | 737 | 'href' => $scripturl . '?action=profile;u=' . $row['id_member'], |
702 | 738 | 'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>', |
703 | 739 | 'posts' => $row['posts'] |
704 | 740 | ); |
741 | + } |
|
705 | 742 | $smcFunc['db_free_result']($request); |
706 | 743 | |
707 | 744 | // If mods want to do somthing with this list of members, let them do that now. |
708 | 745 | call_integration_hook('integrate_ssi_topPoster', array(&$return)); |
709 | 746 | |
710 | 747 | // Just return all the top posters. |
711 | - if ($output_method != 'echo') |
|
712 | - return $return; |
|
748 | + if ($output_method != 'echo') { |
|
749 | + return $return; |
|
750 | + } |
|
713 | 751 | |
714 | 752 | // Make a quick array to list the links in. |
715 | 753 | $temp_array = array(); |
716 | - foreach ($return as $member) |
|
717 | - $temp_array[] = $member['link']; |
|
754 | + foreach ($return as $member) { |
|
755 | + $temp_array[] = $member['link']; |
|
756 | + } |
|
718 | 757 | |
719 | 758 | echo implode(', ', $temp_array); |
720 | 759 | } |
@@ -746,8 +785,8 @@ discard block |
||
746 | 785 | ) |
747 | 786 | ); |
748 | 787 | $boards = array(); |
749 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
750 | - $boards[] = array( |
|
788 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
789 | + $boards[] = array( |
|
751 | 790 | 'id' => $row['id_board'], |
752 | 791 | 'num_posts' => $row['num_posts'], |
753 | 792 | 'num_topics' => $row['num_topics'], |
@@ -756,14 +795,16 @@ discard block |
||
756 | 795 | 'href' => $scripturl . '?board=' . $row['id_board'] . '.0', |
757 | 796 | 'link' => '<a href="' . $scripturl . '?board=' . $row['id_board'] . '.0">' . $row['name'] . '</a>' |
758 | 797 | ); |
798 | + } |
|
759 | 799 | $smcFunc['db_free_result']($request); |
760 | 800 | |
761 | 801 | // If mods want to do somthing with this list of boards, let them do that now. |
762 | 802 | call_integration_hook('integrate_ssi_topBoards', array(&$boards)); |
763 | 803 | |
764 | 804 | // If we shouldn't output or have nothing to output, just jump out. |
765 | - if ($output_method != 'echo' || empty($boards)) |
|
766 | - return $boards; |
|
805 | + if ($output_method != 'echo' || empty($boards)) { |
|
806 | + return $boards; |
|
807 | + } |
|
767 | 808 | |
768 | 809 | echo ' |
769 | 810 | <table class="ssi_table"> |
@@ -772,13 +813,14 @@ discard block |
||
772 | 813 | <th style="text-align: left">', $txt['board_topics'], '</th> |
773 | 814 | <th style="text-align: left">', $txt['posts'], '</th> |
774 | 815 | </tr>'; |
775 | - foreach ($boards as $sBoard) |
|
776 | - echo ' |
|
816 | + foreach ($boards as $sBoard) { |
|
817 | + echo ' |
|
777 | 818 | <tr> |
778 | 819 | <td>', $sBoard['link'], $sBoard['new'] ? ' <a href="' . $sBoard['href'] . '" class="new_posts">' . $txt['new'] . '</a>' : '', '</td> |
779 | 820 | <td style="text-align: right">', comma_format($sBoard['num_topics']), '</td> |
780 | 821 | <td style="text-align: right">', comma_format($sBoard['num_posts']), '</td> |
781 | 822 | </tr>'; |
823 | + } |
|
782 | 824 | echo ' |
783 | 825 | </table>'; |
784 | 826 | } |
@@ -811,12 +853,13 @@ discard block |
||
811 | 853 | ) |
812 | 854 | ); |
813 | 855 | $topic_ids = array(); |
814 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
815 | - $topic_ids[] = $row['id_topic']; |
|
856 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
857 | + $topic_ids[] = $row['id_topic']; |
|
858 | + } |
|
816 | 859 | $smcFunc['db_free_result']($request); |
860 | + } else { |
|
861 | + $topic_ids = array(); |
|
817 | 862 | } |
818 | - else |
|
819 | - $topic_ids = array(); |
|
820 | 863 | |
821 | 864 | $request = $smcFunc['db_query']('', ' |
822 | 865 | SELECT m.subject, m.id_topic, t.num_views, t.num_replies |
@@ -855,8 +898,9 @@ discard block |
||
855 | 898 | // If mods want to do somthing with this list of topics, let them do that now. |
856 | 899 | call_integration_hook('integrate_ssi_topTopics', array(&$topics, $type)); |
857 | 900 | |
858 | - if ($output_method != 'echo' || empty($topics)) |
|
859 | - return $topics; |
|
901 | + if ($output_method != 'echo' || empty($topics)) { |
|
902 | + return $topics; |
|
903 | + } |
|
860 | 904 | |
861 | 905 | echo ' |
862 | 906 | <table class="ssi_table"> |
@@ -865,8 +909,8 @@ discard block |
||
865 | 909 | <th style="text-align: left">', $txt['views'], '</th> |
866 | 910 | <th style="text-align: left">', $txt['replies'], '</th> |
867 | 911 | </tr>'; |
868 | - foreach ($topics as $sTopic) |
|
869 | - echo ' |
|
912 | + foreach ($topics as $sTopic) { |
|
913 | + echo ' |
|
870 | 914 | <tr> |
871 | 915 | <td style="text-align: left"> |
872 | 916 | ', $sTopic['link'], ' |
@@ -874,6 +918,7 @@ discard block |
||
874 | 918 | <td style="text-align: right">', comma_format($sTopic['num_views']), '</td> |
875 | 919 | <td style="text-align: right">', comma_format($sTopic['num_replies']), '</td> |
876 | 920 | </tr>'; |
921 | + } |
|
877 | 922 | echo ' |
878 | 923 | </table>'; |
879 | 924 | } |
@@ -909,12 +954,13 @@ discard block |
||
909 | 954 | { |
910 | 955 | global $txt, $context; |
911 | 956 | |
912 | - if ($output_method == 'echo') |
|
913 | - echo ' |
|
957 | + if ($output_method == 'echo') { |
|
958 | + echo ' |
|
914 | 959 | ', sprintf($txt['welcome_newest_member'], $context['common_stats']['latest_member']['link']), '<br>'; |
915 | - else |
|
916 | - return $context['common_stats']['latest_member']; |
|
917 | -} |
|
960 | + } else { |
|
961 | + return $context['common_stats']['latest_member']; |
|
962 | + } |
|
963 | + } |
|
918 | 964 | |
919 | 965 | /** |
920 | 966 | * Fetches a random member. |
@@ -963,8 +1009,9 @@ discard block |
||
963 | 1009 | } |
964 | 1010 | |
965 | 1011 | // Just to be sure put the random generator back to something... random. |
966 | - if ($random_type != '') |
|
967 | - mt_srand(time()); |
|
1012 | + if ($random_type != '') { |
|
1013 | + mt_srand(time()); |
|
1014 | + } |
|
968 | 1015 | |
969 | 1016 | return $result; |
970 | 1017 | } |
@@ -977,8 +1024,9 @@ discard block |
||
977 | 1024 | */ |
978 | 1025 | function ssi_fetchMember($member_ids = array(), $output_method = 'echo') |
979 | 1026 | { |
980 | - if (empty($member_ids)) |
|
981 | - return; |
|
1027 | + if (empty($member_ids)) { |
|
1028 | + return; |
|
1029 | + } |
|
982 | 1030 | |
983 | 1031 | // Can have more than one member if you really want... |
984 | 1032 | $member_ids = is_array($member_ids) ? $member_ids : array($member_ids); |
@@ -1003,8 +1051,9 @@ discard block |
||
1003 | 1051 | */ |
1004 | 1052 | function ssi_fetchGroupMembers($group_id = null, $output_method = 'echo') |
1005 | 1053 | { |
1006 | - if ($group_id === null) |
|
1007 | - return; |
|
1054 | + if ($group_id === null) { |
|
1055 | + return; |
|
1056 | + } |
|
1008 | 1057 | |
1009 | 1058 | $query_where = ' |
1010 | 1059 | id_group = {int:id_group} |
@@ -1031,8 +1080,9 @@ discard block |
||
1031 | 1080 | { |
1032 | 1081 | global $smcFunc, $memberContext; |
1033 | 1082 | |
1034 | - if ($query_where === null) |
|
1035 | - return; |
|
1083 | + if ($query_where === null) { |
|
1084 | + return; |
|
1085 | + } |
|
1036 | 1086 | |
1037 | 1087 | // Fetch the members in question. |
1038 | 1088 | $request = $smcFunc['db_query']('', ' |
@@ -1045,12 +1095,14 @@ discard block |
||
1045 | 1095 | )) |
1046 | 1096 | ); |
1047 | 1097 | $members = array(); |
1048 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1049 | - $members[] = $row['id_member']; |
|
1098 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1099 | + $members[] = $row['id_member']; |
|
1100 | + } |
|
1050 | 1101 | $smcFunc['db_free_result']($request); |
1051 | 1102 | |
1052 | - if (empty($members)) |
|
1053 | - return array(); |
|
1103 | + if (empty($members)) { |
|
1104 | + return array(); |
|
1105 | + } |
|
1054 | 1106 | |
1055 | 1107 | // If mods want to do somthing with this list of members, let them do that now. |
1056 | 1108 | call_integration_hook('integrate_ssi_queryMembers', array(&$members)); |
@@ -1059,23 +1111,25 @@ discard block |
||
1059 | 1111 | loadMemberData($members); |
1060 | 1112 | |
1061 | 1113 | // Draw the table! |
1062 | - if ($output_method == 'echo') |
|
1063 | - echo ' |
|
1114 | + if ($output_method == 'echo') { |
|
1115 | + echo ' |
|
1064 | 1116 | <table style="border: none" class="ssi_table">'; |
1117 | + } |
|
1065 | 1118 | |
1066 | 1119 | $query_members = array(); |
1067 | 1120 | foreach ($members as $member) |
1068 | 1121 | { |
1069 | 1122 | // Load their context data. |
1070 | - if (!loadMemberContext($member)) |
|
1071 | - continue; |
|
1123 | + if (!loadMemberContext($member)) { |
|
1124 | + continue; |
|
1125 | + } |
|
1072 | 1126 | |
1073 | 1127 | // Store this member's information. |
1074 | 1128 | $query_members[$member] = $memberContext[$member]; |
1075 | 1129 | |
1076 | 1130 | // Only do something if we're echo'ing. |
1077 | - if ($output_method == 'echo') |
|
1078 | - echo ' |
|
1131 | + if ($output_method == 'echo') { |
|
1132 | + echo ' |
|
1079 | 1133 | <tr> |
1080 | 1134 | <td style="text-align: right; vertical-align: top; white-space: nowrap"> |
1081 | 1135 | ', $query_members[$member]['link'], ' |
@@ -1083,12 +1137,14 @@ discard block |
||
1083 | 1137 | <br>', $query_members[$member]['avatar']['image'], ' |
1084 | 1138 | </td> |
1085 | 1139 | </tr>'; |
1140 | + } |
|
1086 | 1141 | } |
1087 | 1142 | |
1088 | 1143 | // End the table if appropriate. |
1089 | - if ($output_method == 'echo') |
|
1090 | - echo ' |
|
1144 | + if ($output_method == 'echo') { |
|
1145 | + echo ' |
|
1091 | 1146 | </table>'; |
1147 | + } |
|
1092 | 1148 | |
1093 | 1149 | // Send back the data. |
1094 | 1150 | return $query_members; |
@@ -1103,8 +1159,9 @@ discard block |
||
1103 | 1159 | { |
1104 | 1160 | global $txt, $scripturl, $modSettings, $smcFunc; |
1105 | 1161 | |
1106 | - if (!allowedTo('view_stats')) |
|
1107 | - return; |
|
1162 | + if (!allowedTo('view_stats')) { |
|
1163 | + return; |
|
1164 | + } |
|
1108 | 1165 | |
1109 | 1166 | $totals = array( |
1110 | 1167 | 'members' => $modSettings['totalMembers'], |
@@ -1133,8 +1190,9 @@ discard block |
||
1133 | 1190 | // If mods want to do somthing with the board stats, let them do that now. |
1134 | 1191 | call_integration_hook('integrate_ssi_boardStats', array(&$totals)); |
1135 | 1192 | |
1136 | - if ($output_method != 'echo') |
|
1137 | - return $totals; |
|
1193 | + if ($output_method != 'echo') { |
|
1194 | + return $totals; |
|
1195 | + } |
|
1138 | 1196 | |
1139 | 1197 | echo ' |
1140 | 1198 | ', $txt['total_members'], ': <a href="', $scripturl . '?action=mlist">', comma_format($totals['members']), '</a><br> |
@@ -1163,8 +1221,8 @@ discard block |
||
1163 | 1221 | call_integration_hook('integrate_ssi_whosOnline', array(&$return)); |
1164 | 1222 | |
1165 | 1223 | // Add some redundancy for backwards compatibility reasons. |
1166 | - if ($output_method != 'echo') |
|
1167 | - return $return + array( |
|
1224 | + if ($output_method != 'echo') { |
|
1225 | + return $return + array( |
|
1168 | 1226 | 'users' => $return['users_online'], |
1169 | 1227 | 'guests' => $return['num_guests'], |
1170 | 1228 | 'hidden' => $return['num_users_hidden'], |
@@ -1172,29 +1230,35 @@ discard block |
||
1172 | 1230 | 'num_users' => $return['num_users_online'], |
1173 | 1231 | 'total_users' => $return['num_users_online'] + $return['num_guests'], |
1174 | 1232 | ); |
1233 | + } |
|
1175 | 1234 | |
1176 | 1235 | echo ' |
1177 | 1236 | ', comma_format($return['num_guests']), ' ', $return['num_guests'] == 1 ? $txt['guest'] : $txt['guests'], ', ', comma_format($return['num_users_online']), ' ', $return['num_users_online'] == 1 ? $txt['user'] : $txt['users']; |
1178 | 1237 | |
1179 | 1238 | $bracketList = array(); |
1180 | - if (!empty($user_info['buddies'])) |
|
1181 | - $bracketList[] = comma_format($return['num_buddies']) . ' ' . ($return['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']); |
|
1182 | - if (!empty($return['num_spiders'])) |
|
1183 | - $bracketList[] = comma_format($return['num_spiders']) . ' ' . ($return['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']); |
|
1184 | - if (!empty($return['num_users_hidden'])) |
|
1185 | - $bracketList[] = comma_format($return['num_users_hidden']) . ' ' . $txt['hidden']; |
|
1239 | + if (!empty($user_info['buddies'])) { |
|
1240 | + $bracketList[] = comma_format($return['num_buddies']) . ' ' . ($return['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']); |
|
1241 | + } |
|
1242 | + if (!empty($return['num_spiders'])) { |
|
1243 | + $bracketList[] = comma_format($return['num_spiders']) . ' ' . ($return['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']); |
|
1244 | + } |
|
1245 | + if (!empty($return['num_users_hidden'])) { |
|
1246 | + $bracketList[] = comma_format($return['num_users_hidden']) . ' ' . $txt['hidden']; |
|
1247 | + } |
|
1186 | 1248 | |
1187 | - if (!empty($bracketList)) |
|
1188 | - echo ' (' . implode(', ', $bracketList) . ')'; |
|
1249 | + if (!empty($bracketList)) { |
|
1250 | + echo ' (' . implode(', ', $bracketList) . ')'; |
|
1251 | + } |
|
1189 | 1252 | |
1190 | 1253 | echo '<br> |
1191 | 1254 | ', implode(', ', $return['list_users_online']); |
1192 | 1255 | |
1193 | 1256 | // Showing membergroups? |
1194 | - if (!empty($settings['show_group_key']) && !empty($return['membergroups'])) |
|
1195 | - echo '<br> |
|
1257 | + if (!empty($settings['show_group_key']) && !empty($return['membergroups'])) { |
|
1258 | + echo '<br> |
|
1196 | 1259 | [' . implode('] [', $return['membergroups']) . ']'; |
1197 | -} |
|
1260 | + } |
|
1261 | + } |
|
1198 | 1262 | |
1199 | 1263 | /** |
1200 | 1264 | * Just like whosOnline except it also logs the online presence. |
@@ -1205,11 +1269,12 @@ discard block |
||
1205 | 1269 | { |
1206 | 1270 | writeLog(); |
1207 | 1271 | |
1208 | - if ($output_method != 'echo') |
|
1209 | - return ssi_whosOnline($output_method); |
|
1210 | - else |
|
1211 | - ssi_whosOnline($output_method); |
|
1212 | -} |
|
1272 | + if ($output_method != 'echo') { |
|
1273 | + return ssi_whosOnline($output_method); |
|
1274 | + } else { |
|
1275 | + ssi_whosOnline($output_method); |
|
1276 | + } |
|
1277 | + } |
|
1213 | 1278 | |
1214 | 1279 | // Shows a login box. |
1215 | 1280 | /** |
@@ -1222,11 +1287,13 @@ discard block |
||
1222 | 1287 | { |
1223 | 1288 | global $scripturl, $txt, $user_info, $context; |
1224 | 1289 | |
1225 | - if ($redirect_to != '') |
|
1226 | - $_SESSION['login_url'] = $redirect_to; |
|
1290 | + if ($redirect_to != '') { |
|
1291 | + $_SESSION['login_url'] = $redirect_to; |
|
1292 | + } |
|
1227 | 1293 | |
1228 | - if ($output_method != 'echo' || !$user_info['is_guest']) |
|
1229 | - return $user_info['is_guest']; |
|
1294 | + if ($output_method != 'echo' || !$user_info['is_guest']) { |
|
1295 | + return $user_info['is_guest']; |
|
1296 | + } |
|
1230 | 1297 | |
1231 | 1298 | // Create a login token |
1232 | 1299 | createToken('login'); |
@@ -1278,8 +1345,9 @@ discard block |
||
1278 | 1345 | |
1279 | 1346 | $boardsAllowed = array_intersect(boardsAllowedTo('poll_view'), boardsAllowedTo('poll_vote')); |
1280 | 1347 | |
1281 | - if (empty($boardsAllowed)) |
|
1282 | - return array(); |
|
1348 | + if (empty($boardsAllowed)) { |
|
1349 | + return array(); |
|
1350 | + } |
|
1283 | 1351 | |
1284 | 1352 | $request = $smcFunc['db_query']('', ' |
1285 | 1353 | SELECT p.id_poll, p.question, t.id_topic, p.max_votes, p.guest_vote, p.hide_results, p.expire_time |
@@ -1312,12 +1380,14 @@ discard block |
||
1312 | 1380 | $smcFunc['db_free_result']($request); |
1313 | 1381 | |
1314 | 1382 | // This user has voted on all the polls. |
1315 | - if (empty($row) || !is_array($row)) |
|
1316 | - return array(); |
|
1383 | + if (empty($row) || !is_array($row)) { |
|
1384 | + return array(); |
|
1385 | + } |
|
1317 | 1386 | |
1318 | 1387 | // If this is a guest who's voted we'll through ourselves to show poll to show the results. |
1319 | - if ($user_info['is_guest'] && (!$row['guest_vote'] || (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))))) |
|
1320 | - return ssi_showPoll($row['id_topic'], $output_method); |
|
1388 | + if ($user_info['is_guest'] && (!$row['guest_vote'] || (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))))) { |
|
1389 | + return ssi_showPoll($row['id_topic'], $output_method); |
|
1390 | + } |
|
1321 | 1391 | |
1322 | 1392 | $request = $smcFunc['db_query']('', ' |
1323 | 1393 | SELECT COUNT(DISTINCT id_member) |
@@ -1381,8 +1451,9 @@ discard block |
||
1381 | 1451 | // If mods want to do somthing with this list of polls, let them do that now. |
1382 | 1452 | call_integration_hook('integrate_ssi_recentPoll', array(&$return, $topPollInstead)); |
1383 | 1453 | |
1384 | - if ($output_method != 'echo') |
|
1385 | - return $return; |
|
1454 | + if ($output_method != 'echo') { |
|
1455 | + return $return; |
|
1456 | + } |
|
1386 | 1457 | |
1387 | 1458 | if ($allow_view_results) |
1388 | 1459 | { |
@@ -1391,19 +1462,20 @@ discard block |
||
1391 | 1462 | <strong>', $return['question'], '</strong><br> |
1392 | 1463 | ', !empty($return['allowed_warning']) ? $return['allowed_warning'] . '<br>' : ''; |
1393 | 1464 | |
1394 | - foreach ($return['options'] as $option) |
|
1395 | - echo ' |
|
1465 | + foreach ($return['options'] as $option) { |
|
1466 | + echo ' |
|
1396 | 1467 | <label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>'; |
1468 | + } |
|
1397 | 1469 | |
1398 | 1470 | echo ' |
1399 | 1471 | <input type="submit" value="', $txt['poll_vote'], '" class="button"> |
1400 | 1472 | <input type="hidden" name="poll" value="', $return['id'], '"> |
1401 | 1473 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
1402 | 1474 | </form>'; |
1475 | + } else { |
|
1476 | + echo $txt['poll_cannot_see']; |
|
1477 | + } |
|
1403 | 1478 | } |
1404 | - else |
|
1405 | - echo $txt['poll_cannot_see']; |
|
1406 | -} |
|
1407 | 1479 | |
1408 | 1480 | /** |
1409 | 1481 | * Shows the poll from the specified topic |
@@ -1417,13 +1489,15 @@ discard block |
||
1417 | 1489 | |
1418 | 1490 | $boardsAllowed = boardsAllowedTo('poll_view'); |
1419 | 1491 | |
1420 | - if (empty($boardsAllowed)) |
|
1421 | - return array(); |
|
1492 | + if (empty($boardsAllowed)) { |
|
1493 | + return array(); |
|
1494 | + } |
|
1422 | 1495 | |
1423 | - if ($topic === null && isset($_REQUEST['ssi_topic'])) |
|
1424 | - $topic = (int) $_REQUEST['ssi_topic']; |
|
1425 | - else |
|
1426 | - $topic = (int) $topic; |
|
1496 | + if ($topic === null && isset($_REQUEST['ssi_topic'])) { |
|
1497 | + $topic = (int) $_REQUEST['ssi_topic']; |
|
1498 | + } else { |
|
1499 | + $topic = (int) $topic; |
|
1500 | + } |
|
1427 | 1501 | |
1428 | 1502 | $request = $smcFunc['db_query']('', ' |
1429 | 1503 | SELECT |
@@ -1444,17 +1518,18 @@ discard block |
||
1444 | 1518 | ); |
1445 | 1519 | |
1446 | 1520 | // Either this topic has no poll, or the user cannot view it. |
1447 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
1448 | - return array(); |
|
1521 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
1522 | + return array(); |
|
1523 | + } |
|
1449 | 1524 | |
1450 | 1525 | $row = $smcFunc['db_fetch_assoc']($request); |
1451 | 1526 | $smcFunc['db_free_result']($request); |
1452 | 1527 | |
1453 | 1528 | // Check if they can vote. |
1454 | 1529 | $already_voted = false; |
1455 | - if (!empty($row['expire_time']) && $row['expire_time'] < time()) |
|
1456 | - $allow_vote = false; |
|
1457 | - elseif ($user_info['is_guest']) |
|
1530 | + if (!empty($row['expire_time']) && $row['expire_time'] < time()) { |
|
1531 | + $allow_vote = false; |
|
1532 | + } elseif ($user_info['is_guest']) |
|
1458 | 1533 | { |
1459 | 1534 | // There's a difference between "allowed to vote" and "already voted"... |
1460 | 1535 | $allow_vote = $row['guest_vote']; |
@@ -1464,10 +1539,9 @@ discard block |
||
1464 | 1539 | { |
1465 | 1540 | $already_voted = true; |
1466 | 1541 | } |
1467 | - } |
|
1468 | - elseif (!empty($row['voting_locked']) || !allowedTo('poll_vote', $row['id_board'])) |
|
1469 | - $allow_vote = false; |
|
1470 | - else |
|
1542 | + } elseif (!empty($row['voting_locked']) || !allowedTo('poll_vote', $row['id_board'])) { |
|
1543 | + $allow_vote = false; |
|
1544 | + } else |
|
1471 | 1545 | { |
1472 | 1546 | $request = $smcFunc['db_query']('', ' |
1473 | 1547 | SELECT id_member |
@@ -1549,8 +1623,9 @@ discard block |
||
1549 | 1623 | // If mods want to do somthing with this poll, let them do that now. |
1550 | 1624 | call_integration_hook('integrate_ssi_showPoll', array(&$return)); |
1551 | 1625 | |
1552 | - if ($output_method != 'echo') |
|
1553 | - return $return; |
|
1626 | + if ($output_method != 'echo') { |
|
1627 | + return $return; |
|
1628 | + } |
|
1554 | 1629 | |
1555 | 1630 | if ($return['allow_vote']) |
1556 | 1631 | { |
@@ -1559,17 +1634,17 @@ discard block |
||
1559 | 1634 | <strong>', $return['question'], '</strong><br> |
1560 | 1635 | ', !empty($return['allowed_warning']) ? $return['allowed_warning'] . '<br>' : ''; |
1561 | 1636 | |
1562 | - foreach ($return['options'] as $option) |
|
1563 | - echo ' |
|
1637 | + foreach ($return['options'] as $option) { |
|
1638 | + echo ' |
|
1564 | 1639 | <label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>'; |
1640 | + } |
|
1565 | 1641 | |
1566 | 1642 | echo ' |
1567 | 1643 | <input type="submit" value="', $txt['poll_vote'], '" class="button"> |
1568 | 1644 | <input type="hidden" name="poll" value="', $return['id'], '"> |
1569 | 1645 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
1570 | 1646 | </form>'; |
1571 | - } |
|
1572 | - else |
|
1647 | + } else |
|
1573 | 1648 | { |
1574 | 1649 | echo ' |
1575 | 1650 | <div class="ssi_poll"> |
@@ -1649,27 +1724,32 @@ discard block |
||
1649 | 1724 | 'is_approved' => 1, |
1650 | 1725 | ) |
1651 | 1726 | ); |
1652 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
1653 | - die; |
|
1727 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
1728 | + die; |
|
1729 | + } |
|
1654 | 1730 | $row = $smcFunc['db_fetch_assoc']($request); |
1655 | 1731 | $smcFunc['db_free_result']($request); |
1656 | 1732 | |
1657 | - if (!empty($row['voting_locked']) || ($row['selected'] != -1 && !$user_info['is_guest']) || (!empty($row['expire_time']) && time() > $row['expire_time'])) |
|
1658 | - redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1733 | + if (!empty($row['voting_locked']) || ($row['selected'] != -1 && !$user_info['is_guest']) || (!empty($row['expire_time']) && time() > $row['expire_time'])) { |
|
1734 | + redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1735 | + } |
|
1659 | 1736 | |
1660 | 1737 | // Too many options checked? |
1661 | - if (count($_REQUEST['options']) > $row['max_votes']) |
|
1662 | - redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1738 | + if (count($_REQUEST['options']) > $row['max_votes']) { |
|
1739 | + redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1740 | + } |
|
1663 | 1741 | |
1664 | 1742 | // It's a guest who has already voted? |
1665 | 1743 | if ($user_info['is_guest']) |
1666 | 1744 | { |
1667 | 1745 | // Guest voting disabled? |
1668 | - if (!$row['guest_vote']) |
|
1669 | - redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1746 | + if (!$row['guest_vote']) { |
|
1747 | + redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1748 | + } |
|
1670 | 1749 | // Already voted? |
1671 | - elseif (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))) |
|
1672 | - redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1750 | + elseif (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))) { |
|
1751 | + redirectexit('topic=' . $row['id_topic'] . '.0'); |
|
1752 | + } |
|
1673 | 1753 | } |
1674 | 1754 | |
1675 | 1755 | $sOptions = array(); |
@@ -1723,11 +1803,13 @@ discard block |
||
1723 | 1803 | { |
1724 | 1804 | global $scripturl, $txt, $context; |
1725 | 1805 | |
1726 | - if (!allowedTo('search_posts')) |
|
1727 | - return; |
|
1806 | + if (!allowedTo('search_posts')) { |
|
1807 | + return; |
|
1808 | + } |
|
1728 | 1809 | |
1729 | - if ($output_method != 'echo') |
|
1730 | - return $scripturl . '?action=search'; |
|
1810 | + if ($output_method != 'echo') { |
|
1811 | + return $scripturl . '?action=search'; |
|
1812 | + } |
|
1731 | 1813 | |
1732 | 1814 | echo ' |
1733 | 1815 | <form action="', $scripturl, '?action=search2" method="post" accept-charset="', $context['character_set'], '"> |
@@ -1749,8 +1831,9 @@ discard block |
||
1749 | 1831 | // If mods want to do somthing with the news, let them do that now. Don't need to pass the news line itself, since it is already in $context. |
1750 | 1832 | call_integration_hook('integrate_ssi_news'); |
1751 | 1833 | |
1752 | - if ($output_method != 'echo') |
|
1753 | - return $context['random_news_line']; |
|
1834 | + if ($output_method != 'echo') { |
|
1835 | + return $context['random_news_line']; |
|
1836 | + } |
|
1754 | 1837 | |
1755 | 1838 | echo $context['random_news_line']; |
1756 | 1839 | } |
@@ -1764,8 +1847,9 @@ discard block |
||
1764 | 1847 | { |
1765 | 1848 | global $scripturl, $modSettings, $user_info; |
1766 | 1849 | |
1767 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view') || !allowedTo('profile_view')) |
|
1768 | - return; |
|
1850 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view') || !allowedTo('profile_view')) { |
|
1851 | + return; |
|
1852 | + } |
|
1769 | 1853 | |
1770 | 1854 | $eventOptions = array( |
1771 | 1855 | 'include_birthdays' => true, |
@@ -1776,13 +1860,15 @@ discard block |
||
1776 | 1860 | // The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary |
1777 | 1861 | call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions)); |
1778 | 1862 | |
1779 | - if ($output_method != 'echo') |
|
1780 | - return $return['calendar_birthdays']; |
|
1863 | + if ($output_method != 'echo') { |
|
1864 | + return $return['calendar_birthdays']; |
|
1865 | + } |
|
1781 | 1866 | |
1782 | - foreach ($return['calendar_birthdays'] as $member) |
|
1783 | - echo ' |
|
1867 | + foreach ($return['calendar_birthdays'] as $member) { |
|
1868 | + echo ' |
|
1784 | 1869 | <a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">' . $member['name'] . '</span>' . (isset($member['age']) ? ' (' . $member['age'] . ')' : '') . '</a>' . (!$member['is_last'] ? ', ' : ''); |
1785 | -} |
|
1870 | + } |
|
1871 | + } |
|
1786 | 1872 | |
1787 | 1873 | /** |
1788 | 1874 | * Shows today's holidays. |
@@ -1793,8 +1879,9 @@ discard block |
||
1793 | 1879 | { |
1794 | 1880 | global $modSettings, $user_info; |
1795 | 1881 | |
1796 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) |
|
1797 | - return; |
|
1882 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) { |
|
1883 | + return; |
|
1884 | + } |
|
1798 | 1885 | |
1799 | 1886 | $eventOptions = array( |
1800 | 1887 | 'include_holidays' => true, |
@@ -1805,8 +1892,9 @@ discard block |
||
1805 | 1892 | // The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary |
1806 | 1893 | call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions)); |
1807 | 1894 | |
1808 | - if ($output_method != 'echo') |
|
1809 | - return $return['calendar_holidays']; |
|
1895 | + if ($output_method != 'echo') { |
|
1896 | + return $return['calendar_holidays']; |
|
1897 | + } |
|
1810 | 1898 | |
1811 | 1899 | echo ' |
1812 | 1900 | ', implode(', ', $return['calendar_holidays']); |
@@ -1820,8 +1908,9 @@ discard block |
||
1820 | 1908 | { |
1821 | 1909 | global $modSettings, $user_info; |
1822 | 1910 | |
1823 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) |
|
1824 | - return; |
|
1911 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) { |
|
1912 | + return; |
|
1913 | + } |
|
1825 | 1914 | |
1826 | 1915 | $eventOptions = array( |
1827 | 1916 | 'include_events' => true, |
@@ -1832,14 +1921,16 @@ discard block |
||
1832 | 1921 | // The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary |
1833 | 1922 | call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions)); |
1834 | 1923 | |
1835 | - if ($output_method != 'echo') |
|
1836 | - return $return['calendar_events']; |
|
1924 | + if ($output_method != 'echo') { |
|
1925 | + return $return['calendar_events']; |
|
1926 | + } |
|
1837 | 1927 | |
1838 | 1928 | foreach ($return['calendar_events'] as $event) |
1839 | 1929 | { |
1840 | - if ($event['can_edit']) |
|
1841 | - echo ' |
|
1930 | + if ($event['can_edit']) { |
|
1931 | + echo ' |
|
1842 | 1932 | <a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> '; |
1933 | + } |
|
1843 | 1934 | echo ' |
1844 | 1935 | ' . $event['link'] . (!$event['is_last'] ? ', ' : ''); |
1845 | 1936 | } |
@@ -1854,8 +1945,9 @@ discard block |
||
1854 | 1945 | { |
1855 | 1946 | global $modSettings, $txt, $scripturl, $user_info; |
1856 | 1947 | |
1857 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) |
|
1858 | - return; |
|
1948 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) { |
|
1949 | + return; |
|
1950 | + } |
|
1859 | 1951 | |
1860 | 1952 | $eventOptions = array( |
1861 | 1953 | 'include_birthdays' => allowedTo('profile_view'), |
@@ -1868,19 +1960,22 @@ discard block |
||
1868 | 1960 | // The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary |
1869 | 1961 | call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions)); |
1870 | 1962 | |
1871 | - if ($output_method != 'echo') |
|
1872 | - return $return; |
|
1963 | + if ($output_method != 'echo') { |
|
1964 | + return $return; |
|
1965 | + } |
|
1873 | 1966 | |
1874 | - if (!empty($return['calendar_holidays'])) |
|
1875 | - echo ' |
|
1967 | + if (!empty($return['calendar_holidays'])) { |
|
1968 | + echo ' |
|
1876 | 1969 | <span class="holiday">' . $txt['calendar_prompt'] . ' ' . implode(', ', $return['calendar_holidays']) . '<br></span>'; |
1970 | + } |
|
1877 | 1971 | if (!empty($return['calendar_birthdays'])) |
1878 | 1972 | { |
1879 | 1973 | echo ' |
1880 | 1974 | <span class="birthday">' . $txt['birthdays_upcoming'] . '</span> '; |
1881 | - foreach ($return['calendar_birthdays'] as $member) |
|
1882 | - echo ' |
|
1975 | + foreach ($return['calendar_birthdays'] as $member) { |
|
1976 | + echo ' |
|
1883 | 1977 | <a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">', $member['name'], '</span>', isset($member['age']) ? ' (' . $member['age'] . ')' : '', '</a>', !$member['is_last'] ? ', ' : ''; |
1978 | + } |
|
1884 | 1979 | echo ' |
1885 | 1980 | <br>'; |
1886 | 1981 | } |
@@ -1890,9 +1985,10 @@ discard block |
||
1890 | 1985 | <span class="event">' . $txt['events_upcoming'] . '</span> '; |
1891 | 1986 | foreach ($return['calendar_events'] as $event) |
1892 | 1987 | { |
1893 | - if ($event['can_edit']) |
|
1894 | - echo ' |
|
1988 | + if ($event['can_edit']) { |
|
1989 | + echo ' |
|
1895 | 1990 | <a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> '; |
1991 | + } |
|
1896 | 1992 | echo ' |
1897 | 1993 | ' . $event['link'] . (!$event['is_last'] ? ', ' : ''); |
1898 | 1994 | } |
@@ -1916,25 +2012,29 @@ discard block |
||
1916 | 2012 | loadLanguage('Stats'); |
1917 | 2013 | |
1918 | 2014 | // Must be integers.... |
1919 | - if ($limit === null) |
|
1920 | - $limit = isset($_GET['limit']) ? (int) $_GET['limit'] : 5; |
|
1921 | - else |
|
1922 | - $limit = (int) $limit; |
|
1923 | - |
|
1924 | - if ($start === null) |
|
1925 | - $start = isset($_GET['start']) ? (int) $_GET['start'] : 0; |
|
1926 | - else |
|
1927 | - $start = (int) $start; |
|
1928 | - |
|
1929 | - if ($board !== null) |
|
1930 | - $board = (int) $board; |
|
1931 | - elseif (isset($_GET['board'])) |
|
1932 | - $board = (int) $_GET['board']; |
|
1933 | - |
|
1934 | - if ($length === null) |
|
1935 | - $length = isset($_GET['length']) ? (int) $_GET['length'] : 0; |
|
1936 | - else |
|
1937 | - $length = (int) $length; |
|
2015 | + if ($limit === null) { |
|
2016 | + $limit = isset($_GET['limit']) ? (int) $_GET['limit'] : 5; |
|
2017 | + } else { |
|
2018 | + $limit = (int) $limit; |
|
2019 | + } |
|
2020 | + |
|
2021 | + if ($start === null) { |
|
2022 | + $start = isset($_GET['start']) ? (int) $_GET['start'] : 0; |
|
2023 | + } else { |
|
2024 | + $start = (int) $start; |
|
2025 | + } |
|
2026 | + |
|
2027 | + if ($board !== null) { |
|
2028 | + $board = (int) $board; |
|
2029 | + } elseif (isset($_GET['board'])) { |
|
2030 | + $board = (int) $_GET['board']; |
|
2031 | + } |
|
2032 | + |
|
2033 | + if ($length === null) { |
|
2034 | + $length = isset($_GET['length']) ? (int) $_GET['length'] : 0; |
|
2035 | + } else { |
|
2036 | + $length = (int) $length; |
|
2037 | + } |
|
1938 | 2038 | |
1939 | 2039 | $limit = max(0, $limit); |
1940 | 2040 | $start = max(0, $start); |
@@ -1952,17 +2052,19 @@ discard block |
||
1952 | 2052 | ); |
1953 | 2053 | if ($smcFunc['db_num_rows']($request) == 0) |
1954 | 2054 | { |
1955 | - if ($output_method == 'echo') |
|
1956 | - die($txt['ssi_no_guests']); |
|
1957 | - else |
|
1958 | - return array(); |
|
2055 | + if ($output_method == 'echo') { |
|
2056 | + die($txt['ssi_no_guests']); |
|
2057 | + } else { |
|
2058 | + return array(); |
|
2059 | + } |
|
1959 | 2060 | } |
1960 | 2061 | list ($board) = $smcFunc['db_fetch_row']($request); |
1961 | 2062 | $smcFunc['db_free_result']($request); |
1962 | 2063 | |
1963 | 2064 | $icon_sources = array(); |
1964 | - foreach ($context['stable_icons'] as $icon) |
|
1965 | - $icon_sources[$icon] = 'images_url'; |
|
2065 | + foreach ($context['stable_icons'] as $icon) { |
|
2066 | + $icon_sources[$icon] = 'images_url'; |
|
2067 | + } |
|
1966 | 2068 | |
1967 | 2069 | if (!empty($modSettings['enable_likes'])) |
1968 | 2070 | { |
@@ -1985,12 +2087,14 @@ discard block |
||
1985 | 2087 | ) |
1986 | 2088 | ); |
1987 | 2089 | $posts = array(); |
1988 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1989 | - $posts[] = $row['id_first_msg']; |
|
2090 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2091 | + $posts[] = $row['id_first_msg']; |
|
2092 | + } |
|
1990 | 2093 | $smcFunc['db_free_result']($request); |
1991 | 2094 | |
1992 | - if (empty($posts)) |
|
1993 | - return array(); |
|
2095 | + if (empty($posts)) { |
|
2096 | + return array(); |
|
2097 | + } |
|
1994 | 2098 | |
1995 | 2099 | // Find the posts. |
1996 | 2100 | $request = $smcFunc['db_query']('', ' |
@@ -2020,24 +2124,28 @@ discard block |
||
2020 | 2124 | $last_space = strrpos($row['body'], ' '); |
2021 | 2125 | $last_open = strrpos($row['body'], '<'); |
2022 | 2126 | $last_close = strrpos($row['body'], '>'); |
2023 | - if (empty($last_space) || ($last_space == $last_open + 3 && (empty($last_close) || (!empty($last_close) && $last_close < $last_open))) || $last_space < $last_open || $last_open == $length - 6) |
|
2024 | - $cutoff = $last_open; |
|
2025 | - elseif (empty($last_close) || $last_close < $last_open) |
|
2026 | - $cutoff = $last_space; |
|
2127 | + if (empty($last_space) || ($last_space == $last_open + 3 && (empty($last_close) || (!empty($last_close) && $last_close < $last_open))) || $last_space < $last_open || $last_open == $length - 6) { |
|
2128 | + $cutoff = $last_open; |
|
2129 | + } elseif (empty($last_close) || $last_close < $last_open) { |
|
2130 | + $cutoff = $last_space; |
|
2131 | + } |
|
2027 | 2132 | |
2028 | - if ($cutoff !== false) |
|
2029 | - $row['body'] = $smcFunc['substr']($row['body'], 0, $cutoff); |
|
2133 | + if ($cutoff !== false) { |
|
2134 | + $row['body'] = $smcFunc['substr']($row['body'], 0, $cutoff); |
|
2135 | + } |
|
2030 | 2136 | $row['body'] .= '...'; |
2031 | 2137 | } |
2032 | 2138 | |
2033 | 2139 | $row['body'] = parse_bbc($row['body'], $row['smileys_enabled'], $row['id_msg']); |
2034 | 2140 | |
2035 | - if (!empty($recycle_board) && $row['id_board'] == $recycle_board) |
|
2036 | - $row['icon'] = 'recycled'; |
|
2141 | + if (!empty($recycle_board) && $row['id_board'] == $recycle_board) { |
|
2142 | + $row['icon'] = 'recycled'; |
|
2143 | + } |
|
2037 | 2144 | |
2038 | 2145 | // Check that this message icon is there... |
2039 | - if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) |
|
2040 | - $icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
2146 | + if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) { |
|
2147 | + $icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
2148 | + } |
|
2041 | 2149 | |
2042 | 2150 | censorText($row['subject']); |
2043 | 2151 | censorText($row['body']); |
@@ -2074,16 +2182,18 @@ discard block |
||
2074 | 2182 | } |
2075 | 2183 | $smcFunc['db_free_result']($request); |
2076 | 2184 | |
2077 | - if (empty($return)) |
|
2078 | - return $return; |
|
2185 | + if (empty($return)) { |
|
2186 | + return $return; |
|
2187 | + } |
|
2079 | 2188 | |
2080 | 2189 | $return[count($return) - 1]['is_last'] = true; |
2081 | 2190 | |
2082 | 2191 | // If mods want to do somthing with this list of posts, let them do that now. |
2083 | 2192 | call_integration_hook('integrate_ssi_boardNews', array(&$return)); |
2084 | 2193 | |
2085 | - if ($output_method != 'echo') |
|
2086 | - return $return; |
|
2194 | + if ($output_method != 'echo') { |
|
2195 | + return $return; |
|
2196 | + } |
|
2087 | 2197 | |
2088 | 2198 | foreach ($return as $news) |
2089 | 2199 | { |
@@ -2135,9 +2245,10 @@ discard block |
||
2135 | 2245 | echo ' |
2136 | 2246 | </div>'; |
2137 | 2247 | |
2138 | - if (!$news['is_last']) |
|
2139 | - echo ' |
|
2248 | + if (!$news['is_last']) { |
|
2249 | + echo ' |
|
2140 | 2250 | <hr>'; |
2251 | + } |
|
2141 | 2252 | } |
2142 | 2253 | } |
2143 | 2254 | |
@@ -2151,8 +2262,9 @@ discard block |
||
2151 | 2262 | { |
2152 | 2263 | global $user_info, $scripturl, $modSettings, $txt, $context, $smcFunc; |
2153 | 2264 | |
2154 | - if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) |
|
2155 | - return; |
|
2265 | + if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) { |
|
2266 | + return; |
|
2267 | + } |
|
2156 | 2268 | |
2157 | 2269 | // Find all events which are happening in the near future that the member can see. |
2158 | 2270 | $request = $smcFunc['db_query']('', ' |
@@ -2178,20 +2290,23 @@ discard block |
||
2178 | 2290 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2179 | 2291 | { |
2180 | 2292 | // Check if we've already come by an event linked to this same topic with the same title... and don't display it if we have. |
2181 | - if (!empty($duplicates[$row['title'] . $row['id_topic']])) |
|
2182 | - continue; |
|
2293 | + if (!empty($duplicates[$row['title'] . $row['id_topic']])) { |
|
2294 | + continue; |
|
2295 | + } |
|
2183 | 2296 | |
2184 | 2297 | // Censor the title. |
2185 | 2298 | censorText($row['title']); |
2186 | 2299 | |
2187 | - if ($row['start_date'] < strftime('%Y-%m-%d', forum_time(false))) |
|
2188 | - $date = strftime('%Y-%m-%d', forum_time(false)); |
|
2189 | - else |
|
2190 | - $date = $row['start_date']; |
|
2300 | + if ($row['start_date'] < strftime('%Y-%m-%d', forum_time(false))) { |
|
2301 | + $date = strftime('%Y-%m-%d', forum_time(false)); |
|
2302 | + } else { |
|
2303 | + $date = $row['start_date']; |
|
2304 | + } |
|
2191 | 2305 | |
2192 | 2306 | // If the topic it is attached to is not approved then don't link it. |
2193 | - if (!empty($row['id_first_msg']) && !$row['approved']) |
|
2194 | - $row['id_board'] = $row['id_topic'] = $row['id_first_msg'] = 0; |
|
2307 | + if (!empty($row['id_first_msg']) && !$row['approved']) { |
|
2308 | + $row['id_board'] = $row['id_topic'] = $row['id_first_msg'] = 0; |
|
2309 | + } |
|
2195 | 2310 | |
2196 | 2311 | $allday = (empty($row['start_time']) || empty($row['end_time']) || empty($row['timezone']) || !in_array($row['timezone'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) ? true : false; |
2197 | 2312 | |
@@ -2217,24 +2332,27 @@ discard block |
||
2217 | 2332 | } |
2218 | 2333 | $smcFunc['db_free_result']($request); |
2219 | 2334 | |
2220 | - foreach ($return as $mday => $array) |
|
2221 | - $return[$mday][count($array) - 1]['is_last'] = true; |
|
2335 | + foreach ($return as $mday => $array) { |
|
2336 | + $return[$mday][count($array) - 1]['is_last'] = true; |
|
2337 | + } |
|
2222 | 2338 | |
2223 | 2339 | // If mods want to do somthing with this list of events, let them do that now. |
2224 | 2340 | call_integration_hook('integrate_ssi_recentEvents', array(&$return)); |
2225 | 2341 | |
2226 | - if ($output_method != 'echo' || empty($return)) |
|
2227 | - return $return; |
|
2342 | + if ($output_method != 'echo' || empty($return)) { |
|
2343 | + return $return; |
|
2344 | + } |
|
2228 | 2345 | |
2229 | 2346 | // Well the output method is echo. |
2230 | 2347 | echo ' |
2231 | 2348 | <span class="event">' . $txt['events'] . '</span> '; |
2232 | - foreach ($return as $mday => $array) |
|
2233 | - foreach ($array as $event) |
|
2349 | + foreach ($return as $mday => $array) { |
|
2350 | + foreach ($array as $event) |
|
2234 | 2351 | { |
2235 | 2352 | if ($event['can_edit']) |
2236 | 2353 | echo ' |
2237 | 2354 | <a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> '; |
2355 | + } |
|
2238 | 2356 | |
2239 | 2357 | echo ' |
2240 | 2358 | ' . $event['link'] . (!$event['is_last'] ? ', ' : ''); |
@@ -2253,8 +2371,9 @@ discard block |
||
2253 | 2371 | global $smcFunc; |
2254 | 2372 | |
2255 | 2373 | // If $id is null, this was most likely called from a query string and should do nothing. |
2256 | - if ($id === null) |
|
2257 | - return; |
|
2374 | + if ($id === null) { |
|
2375 | + return; |
|
2376 | + } |
|
2258 | 2377 | |
2259 | 2378 | $request = $smcFunc['db_query']('', ' |
2260 | 2379 | SELECT passwd, member_name, is_activated |
@@ -2286,8 +2405,9 @@ discard block |
||
2286 | 2405 | $attachments_boards = boardsAllowedTo('view_attachments'); |
2287 | 2406 | |
2288 | 2407 | // No boards? Adios amigo. |
2289 | - if (empty($attachments_boards)) |
|
2290 | - return array(); |
|
2408 | + if (empty($attachments_boards)) { |
|
2409 | + return array(); |
|
2410 | + } |
|
2291 | 2411 | |
2292 | 2412 | // Is it an array? |
2293 | 2413 | $attachment_ext = (array) $attachment_ext; |
@@ -2371,8 +2491,9 @@ discard block |
||
2371 | 2491 | call_integration_hook('integrate_ssi_recentAttachments', array(&$attachments)); |
2372 | 2492 | |
2373 | 2493 | // So you just want an array? Here you can have it. |
2374 | - if ($output_method == 'array' || empty($attachments)) |
|
2375 | - return $attachments; |
|
2494 | + if ($output_method == 'array' || empty($attachments)) { |
|
2495 | + return $attachments; |
|
2496 | + } |
|
2376 | 2497 | |
2377 | 2498 | // Give them the default. |
2378 | 2499 | echo ' |
@@ -2383,14 +2504,15 @@ discard block |
||
2383 | 2504 | <th style="text-align: left; padding: 2">', $txt['downloads'], '</th> |
2384 | 2505 | <th style="text-align: left; padding: 2">', $txt['filesize'], '</th> |
2385 | 2506 | </tr>'; |
2386 | - foreach ($attachments as $attach) |
|
2387 | - echo ' |
|
2507 | + foreach ($attachments as $attach) { |
|
2508 | + echo ' |
|
2388 | 2509 | <tr> |
2389 | 2510 | <td>', $attach['file']['link'], '</td> |
2390 | 2511 | <td>', $attach['member']['link'], '</td> |
2391 | 2512 | <td style="text-align: center">', $attach['file']['downloads'], '</td> |
2392 | 2513 | <td>', $attach['file']['filesize'], '</td> |
2393 | 2514 | </tr>'; |
2515 | + } |
|
2394 | 2516 | echo ' |
2395 | 2517 | </table>'; |
2396 | 2518 | } |
@@ -15,8 +15,9 @@ discard block |
||
15 | 15 | * @version 2.1 Beta 4 |
16 | 16 | */ |
17 | 17 | |
18 | -if (!defined('SMF')) |
|
18 | +if (!defined('SMF')) { |
|
19 | 19 | die('No direct access...'); |
20 | +} |
|
20 | 21 | |
21 | 22 | /** |
22 | 23 | * This defines every profile field known to man. |
@@ -29,8 +30,9 @@ discard block |
||
29 | 30 | global $sourcedir, $profile_vars; |
30 | 31 | |
31 | 32 | // Don't load this twice! |
32 | - if (!empty($profile_fields) && !$force_reload) |
|
33 | - return; |
|
33 | + if (!empty($profile_fields) && !$force_reload) { |
|
34 | + return; |
|
35 | + } |
|
34 | 36 | |
35 | 37 | /* This horrific array defines all the profile fields in the whole world! |
36 | 38 | In general each "field" has one array - the key of which is the database column name associated with said field. Each item |
@@ -103,13 +105,14 @@ discard block |
||
103 | 105 | if (isset($_POST['bday2'], $_POST['bday3']) && $value > 0 && $_POST['bday2'] > 0) |
104 | 106 | { |
105 | 107 | // Set to blank? |
106 | - if ((int) $_POST['bday3'] == 1 && (int) $_POST['bday2'] == 1 && (int) $value == 1) |
|
107 | - $value = '1004-01-01'; |
|
108 | - else |
|
109 | - $value = checkdate($value, $_POST['bday2'], $_POST['bday3'] < 1004 ? 1004 : $_POST['bday3']) ? sprintf('%04d-%02d-%02d', $_POST['bday3'] < 1004 ? 1004 : $_POST['bday3'], $_POST['bday1'], $_POST['bday2']) : '1004-01-01'; |
|
108 | + if ((int) $_POST['bday3'] == 1 && (int) $_POST['bday2'] == 1 && (int) $value == 1) { |
|
109 | + $value = '1004-01-01'; |
|
110 | + } else { |
|
111 | + $value = checkdate($value, $_POST['bday2'], $_POST['bday3'] < 1004 ? 1004 : $_POST['bday3']) ? sprintf('%04d-%02d-%02d', $_POST['bday3'] < 1004 ? 1004 : $_POST['bday3'], $_POST['bday1'], $_POST['bday2']) : '1004-01-01'; |
|
112 | + } |
|
113 | + } else { |
|
114 | + $value = '1004-01-01'; |
|
110 | 115 | } |
111 | - else |
|
112 | - $value = '1004-01-01'; |
|
113 | 116 | |
114 | 117 | $profile_vars['birthdate'] = $value; |
115 | 118 | $cur_profile['birthdate'] = $value; |
@@ -127,8 +130,7 @@ discard block |
||
127 | 130 | { |
128 | 131 | $value = checkdate($dates[2], $dates[3], $dates[1] < 4 ? 4 : $dates[1]) ? sprintf('%04d-%02d-%02d', $dates[1] < 4 ? 4 : $dates[1], $dates[2], $dates[3]) : '1004-01-01'; |
129 | 132 | return true; |
130 | - } |
|
131 | - else |
|
133 | + } else |
|
132 | 134 | { |
133 | 135 | $value = empty($cur_profile['birthdate']) ? '1004-01-01' : $cur_profile['birthdate']; |
134 | 136 | return false; |
@@ -150,10 +152,11 @@ discard block |
||
150 | 152 | return $txt['invalid_registration'] . ' ' . strftime('%d %b %Y ' . (strpos($user_info['time_format'], '%H') !== false ? '%I:%M:%S %p' : '%H:%M:%S'), forum_time(false)); |
151 | 153 | } |
152 | 154 | // As long as it doesn't equal "N/A"... |
153 | - elseif ($value != $txt['not_applicable'] && $value != strtotime(strftime('%Y-%m-%d', $cur_profile['date_registered'] + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600))) |
|
154 | - $value = $value - ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
155 | - else |
|
156 | - $value = $cur_profile['date_registered']; |
|
155 | + elseif ($value != $txt['not_applicable'] && $value != strtotime(strftime('%Y-%m-%d', $cur_profile['date_registered'] + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600))) { |
|
156 | + $value = $value - ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
157 | + } else { |
|
158 | + $value = $cur_profile['date_registered']; |
|
159 | + } |
|
157 | 160 | |
158 | 161 | return true; |
159 | 162 | }, |
@@ -177,8 +180,9 @@ discard block |
||
177 | 180 | { |
178 | 181 | global $context, $old_profile, $profile_vars, $sourcedir, $modSettings; |
179 | 182 | |
180 | - if (strtolower($value) == strtolower($old_profile['email_address'])) |
|
181 | - return false; |
|
183 | + if (strtolower($value) == strtolower($old_profile['email_address'])) { |
|
184 | + return false; |
|
185 | + } |
|
182 | 186 | |
183 | 187 | $isValid = profileValidateEmail($value, $context['id_member']); |
184 | 188 | |
@@ -254,11 +258,11 @@ discard block |
||
254 | 258 | |
255 | 259 | if (isset($context['profile_languages'][$value])) |
256 | 260 | { |
257 | - if ($context['user']['is_owner'] && empty($context['password_auth_failed'])) |
|
258 | - $_SESSION['language'] = $value; |
|
261 | + if ($context['user']['is_owner'] && empty($context['password_auth_failed'])) { |
|
262 | + $_SESSION['language'] = $value; |
|
263 | + } |
|
259 | 264 | return true; |
260 | - } |
|
261 | - else |
|
265 | + } else |
|
262 | 266 | { |
263 | 267 | $value = $cur_profile['lngfile']; |
264 | 268 | return false; |
@@ -282,13 +286,14 @@ discard block |
||
282 | 286 | |
283 | 287 | // Maybe they are trying to change their password as well? |
284 | 288 | $resetPassword = true; |
285 | - if (isset($_POST['passwrd1']) && $_POST['passwrd1'] != '' && isset($_POST['passwrd2']) && $_POST['passwrd1'] == $_POST['passwrd2'] && validatePassword($_POST['passwrd1'], $value, array($cur_profile['real_name'], $user_info['username'], $user_info['name'], $user_info['email'])) == null) |
|
286 | - $resetPassword = false; |
|
289 | + if (isset($_POST['passwrd1']) && $_POST['passwrd1'] != '' && isset($_POST['passwrd2']) && $_POST['passwrd1'] == $_POST['passwrd2'] && validatePassword($_POST['passwrd1'], $value, array($cur_profile['real_name'], $user_info['username'], $user_info['name'], $user_info['email'])) == null) { |
|
290 | + $resetPassword = false; |
|
291 | + } |
|
287 | 292 | |
288 | 293 | // Do the reset... this will send them an email too. |
289 | - if ($resetPassword) |
|
290 | - resetPassword($context['id_member'], $value); |
|
291 | - elseif ($value !== null) |
|
294 | + if ($resetPassword) { |
|
295 | + resetPassword($context['id_member'], $value); |
|
296 | + } elseif ($value !== null) |
|
292 | 297 | { |
293 | 298 | validateUsername($context['id_member'], trim(preg_replace('~[\t\n\r \x0B\0' . ($context['utf8'] ? '\x{A0}\x{AD}\x{2000}-\x{200F}\x{201F}\x{202F}\x{3000}\x{FEFF}' : '\x00-\x08\x0B\x0C\x0E-\x19\xA0') . ']+~' . ($context['utf8'] ? 'u' : ''), ' ', $value))); |
294 | 299 | updateMemberData($context['id_member'], array('member_name' => $value)); |
@@ -312,20 +317,23 @@ discard block |
||
312 | 317 | 'input_validate' => function(&$value) use ($sourcedir, $user_info, $smcFunc, $cur_profile) |
313 | 318 | { |
314 | 319 | // If we didn't try it then ignore it! |
315 | - if ($value == '') |
|
316 | - return false; |
|
320 | + if ($value == '') { |
|
321 | + return false; |
|
322 | + } |
|
317 | 323 | |
318 | 324 | // Do the two entries for the password even match? |
319 | - if (!isset($_POST['passwrd2']) || $value != $_POST['passwrd2']) |
|
320 | - return 'bad_new_password'; |
|
325 | + if (!isset($_POST['passwrd2']) || $value != $_POST['passwrd2']) { |
|
326 | + return 'bad_new_password'; |
|
327 | + } |
|
321 | 328 | |
322 | 329 | // Let's get the validation function into play... |
323 | 330 | require_once($sourcedir . '/Subs-Auth.php'); |
324 | 331 | $passwordErrors = validatePassword($value, $cur_profile['member_name'], array($cur_profile['real_name'], $user_info['username'], $user_info['name'], $user_info['email'])); |
325 | 332 | |
326 | 333 | // Were there errors? |
327 | - if ($passwordErrors != null) |
|
328 | - return 'password_' . $passwordErrors; |
|
334 | + if ($passwordErrors != null) { |
|
335 | + return 'password_' . $passwordErrors; |
|
336 | + } |
|
329 | 337 | |
330 | 338 | // Set up the new password variable... ready for storage. |
331 | 339 | $value = hash_password($cur_profile['member_name'], un_htmlspecialchars($value)); |
@@ -350,8 +358,9 @@ discard block |
||
350 | 358 | 'permission' => 'profile_blurb', |
351 | 359 | 'input_validate' => function(&$value) use ($smcFunc) |
352 | 360 | { |
353 | - if ($smcFunc['strlen']($value) > 50) |
|
354 | - return 'personal_text_too_long'; |
|
361 | + if ($smcFunc['strlen']($value) > 50) { |
|
362 | + return 'personal_text_too_long'; |
|
363 | + } |
|
355 | 364 | |
356 | 365 | return true; |
357 | 366 | }, |
@@ -386,10 +395,11 @@ discard block |
||
386 | 395 | 'permission' => 'moderate_forum', |
387 | 396 | 'input_validate' => function(&$value) |
388 | 397 | { |
389 | - if (!is_numeric($value)) |
|
390 | - return 'digits_only'; |
|
391 | - else |
|
392 | - $value = $value != '' ? strtr($value, array(',' => '', '.' => '', ' ' => '')) : 0; |
|
398 | + if (!is_numeric($value)) { |
|
399 | + return 'digits_only'; |
|
400 | + } else { |
|
401 | + $value = $value != '' ? strtr($value, array(',' => '', '.' => '', ' ' => '')) : 0; |
|
402 | + } |
|
393 | 403 | return true; |
394 | 404 | }, |
395 | 405 | ), |
@@ -405,15 +415,16 @@ discard block |
||
405 | 415 | { |
406 | 416 | $value = trim(preg_replace('~[\t\n\r \x0B\0' . ($context['utf8'] ? '\x{A0}\x{AD}\x{2000}-\x{200F}\x{201F}\x{202F}\x{3000}\x{FEFF}' : '\x00-\x08\x0B\x0C\x0E-\x19\xA0') . ']+~' . ($context['utf8'] ? 'u' : ''), ' ', $value)); |
407 | 417 | |
408 | - if (trim($value) == '') |
|
409 | - return 'no_name'; |
|
410 | - elseif ($smcFunc['strlen']($value) > 60) |
|
411 | - return 'name_too_long'; |
|
412 | - elseif ($cur_profile['real_name'] != $value) |
|
418 | + if (trim($value) == '') { |
|
419 | + return 'no_name'; |
|
420 | + } elseif ($smcFunc['strlen']($value) > 60) { |
|
421 | + return 'name_too_long'; |
|
422 | + } elseif ($cur_profile['real_name'] != $value) |
|
413 | 423 | { |
414 | 424 | require_once($sourcedir . '/Subs-Members.php'); |
415 | - if (isReservedName($value, $context['id_member'])) |
|
416 | - return 'name_taken'; |
|
425 | + if (isReservedName($value, $context['id_member'])) { |
|
426 | + return 'name_taken'; |
|
427 | + } |
|
417 | 428 | } |
418 | 429 | return true; |
419 | 430 | }, |
@@ -471,8 +482,9 @@ discard block |
||
471 | 482 | 'selected' => $set == $context['member']['smiley_set']['id'] |
472 | 483 | ); |
473 | 484 | |
474 | - if ($context['smiley_sets'][$i]['selected']) |
|
475 | - $context['member']['smiley_set']['name'] = $set_names[$i]; |
|
485 | + if ($context['smiley_sets'][$i]['selected']) { |
|
486 | + $context['member']['smiley_set']['name'] = $set_names[$i]; |
|
487 | + } |
|
476 | 488 | } |
477 | 489 | return true; |
478 | 490 | }, |
@@ -481,8 +493,9 @@ discard block |
||
481 | 493 | global $modSettings; |
482 | 494 | |
483 | 495 | $smiley_sets = explode(',', $modSettings['smiley_sets_known']); |
484 | - if (!in_array($value, $smiley_sets) && $value != 'none') |
|
485 | - $value = ''; |
|
496 | + if (!in_array($value, $smiley_sets) && $value != 'none') { |
|
497 | + $value = ''; |
|
498 | + } |
|
486 | 499 | return true; |
487 | 500 | }, |
488 | 501 | ), |
@@ -497,8 +510,9 @@ discard block |
||
497 | 510 | loadLanguage('Settings'); |
498 | 511 | |
499 | 512 | $context['allow_no_censored'] = false; |
500 | - if ($user_info['is_admin'] || $context['user']['is_owner']) |
|
501 | - $context['allow_no_censored'] = !empty($modSettings['allow_no_censored']); |
|
513 | + if ($user_info['is_admin'] || $context['user']['is_owner']) { |
|
514 | + $context['allow_no_censored'] = !empty($modSettings['allow_no_censored']); |
|
515 | + } |
|
502 | 516 | |
503 | 517 | return true; |
504 | 518 | }, |
@@ -545,8 +559,9 @@ discard block |
||
545 | 559 | 'input_validate' => function($value) |
546 | 560 | { |
547 | 561 | $tz = smf_list_timezones(); |
548 | - if (!isset($tz[$value])) |
|
549 | - return 'bad_timezone'; |
|
562 | + if (!isset($tz[$value])) { |
|
563 | + return 'bad_timezone'; |
|
564 | + } |
|
550 | 565 | |
551 | 566 | return true; |
552 | 567 | }, |
@@ -561,8 +576,9 @@ discard block |
||
561 | 576 | 'enabled' => !empty($modSettings['titlesEnable']), |
562 | 577 | 'input_validate' => function(&$value) use ($smcFunc) |
563 | 578 | { |
564 | - if ($smcFunc['strlen']($value) > 50) |
|
565 | - return 'user_title_too_long'; |
|
579 | + if ($smcFunc['strlen']($value) > 50) { |
|
580 | + return 'user_title_too_long'; |
|
581 | + } |
|
566 | 582 | |
567 | 583 | return true; |
568 | 584 | }, |
@@ -584,10 +600,12 @@ discard block |
||
584 | 600 | // Fix the URL... |
585 | 601 | 'input_validate' => function(&$value) |
586 | 602 | { |
587 | - if (strlen(trim($value)) > 0 && strpos($value, '://') === false) |
|
588 | - $value = 'http://' . $value; |
|
589 | - if (strlen($value) < 8 || (substr($value, 0, 7) !== 'http://' && substr($value, 0, 8) !== 'https://')) |
|
590 | - $value = ''; |
|
603 | + if (strlen(trim($value)) > 0 && strpos($value, '://') === false) { |
|
604 | + $value = 'http://' . $value; |
|
605 | + } |
|
606 | + if (strlen($value) < 8 || (substr($value, 0, 7) !== 'http://' && substr($value, 0, 8) !== 'https://')) { |
|
607 | + $value = ''; |
|
608 | + } |
|
591 | 609 | $value = (string) validate_iri(sanitize_iri($value)); |
592 | 610 | return true; |
593 | 611 | }, |
@@ -602,16 +620,19 @@ discard block |
||
602 | 620 | foreach ($profile_fields as $key => $field) |
603 | 621 | { |
604 | 622 | // Do we have permission to do this? |
605 | - if (isset($field['permission']) && !allowedTo(($context['user']['is_owner'] ? array($field['permission'] . '_own', $field['permission'] . '_any') : $field['permission'] . '_any')) && !allowedTo($field['permission'])) |
|
606 | - unset($profile_fields[$key]); |
|
623 | + if (isset($field['permission']) && !allowedTo(($context['user']['is_owner'] ? array($field['permission'] . '_own', $field['permission'] . '_any') : $field['permission'] . '_any')) && !allowedTo($field['permission'])) { |
|
624 | + unset($profile_fields[$key]); |
|
625 | + } |
|
607 | 626 | |
608 | 627 | // Is it enabled? |
609 | - if (isset($field['enabled']) && !$field['enabled']) |
|
610 | - unset($profile_fields[$key]); |
|
628 | + if (isset($field['enabled']) && !$field['enabled']) { |
|
629 | + unset($profile_fields[$key]); |
|
630 | + } |
|
611 | 631 | |
612 | 632 | // Is it specifically disabled? |
613 | - if (in_array($key, $disabled_fields) || (isset($field['link_with']) && in_array($field['link_with'], $disabled_fields))) |
|
614 | - unset($profile_fields[$key]); |
|
633 | + if (in_array($key, $disabled_fields) || (isset($field['link_with']) && in_array($field['link_with'], $disabled_fields))) { |
|
634 | + unset($profile_fields[$key]); |
|
635 | + } |
|
615 | 636 | } |
616 | 637 | } |
617 | 638 | |
@@ -636,9 +657,10 @@ discard block |
||
636 | 657 | loadProfileFields(true); |
637 | 658 | |
638 | 659 | // First check for any linked sets. |
639 | - foreach ($profile_fields as $key => $field) |
|
640 | - if (isset($field['link_with']) && in_array($field['link_with'], $fields)) |
|
660 | + foreach ($profile_fields as $key => $field) { |
|
661 | + if (isset($field['link_with']) && in_array($field['link_with'], $fields)) |
|
641 | 662 | $fields[] = $key; |
663 | + } |
|
642 | 664 | |
643 | 665 | $i = 0; |
644 | 666 | $last_type = ''; |
@@ -650,38 +672,46 @@ discard block |
||
650 | 672 | $cur_field = &$profile_fields[$field]; |
651 | 673 | |
652 | 674 | // Does it have a preload and does that preload succeed? |
653 | - if (isset($cur_field['preload']) && !$cur_field['preload']()) |
|
654 | - continue; |
|
675 | + if (isset($cur_field['preload']) && !$cur_field['preload']()) { |
|
676 | + continue; |
|
677 | + } |
|
655 | 678 | |
656 | 679 | // If this is anything but complex we need to do more cleaning! |
657 | 680 | if ($cur_field['type'] != 'callback' && $cur_field['type'] != 'hidden') |
658 | 681 | { |
659 | - if (!isset($cur_field['label'])) |
|
660 | - $cur_field['label'] = isset($txt[$field]) ? $txt[$field] : $field; |
|
682 | + if (!isset($cur_field['label'])) { |
|
683 | + $cur_field['label'] = isset($txt[$field]) ? $txt[$field] : $field; |
|
684 | + } |
|
661 | 685 | |
662 | 686 | // Everything has a value! |
663 | - if (!isset($cur_field['value'])) |
|
664 | - $cur_field['value'] = isset($cur_profile[$field]) ? $cur_profile[$field] : ''; |
|
687 | + if (!isset($cur_field['value'])) { |
|
688 | + $cur_field['value'] = isset($cur_profile[$field]) ? $cur_profile[$field] : ''; |
|
689 | + } |
|
665 | 690 | |
666 | 691 | // Any input attributes? |
667 | 692 | $cur_field['input_attr'] = !empty($cur_field['input_attr']) ? implode(',', $cur_field['input_attr']) : ''; |
668 | 693 | } |
669 | 694 | |
670 | 695 | // Was there an error with this field on posting? |
671 | - if (isset($context['profile_errors'][$field])) |
|
672 | - $cur_field['is_error'] = true; |
|
696 | + if (isset($context['profile_errors'][$field])) { |
|
697 | + $cur_field['is_error'] = true; |
|
698 | + } |
|
673 | 699 | |
674 | 700 | // Any javascript stuff? |
675 | - if (!empty($cur_field['js_submit'])) |
|
676 | - $context['profile_onsubmit_javascript'] .= $cur_field['js_submit']; |
|
677 | - if (!empty($cur_field['js'])) |
|
678 | - $context['profile_javascript'] .= $cur_field['js']; |
|
701 | + if (!empty($cur_field['js_submit'])) { |
|
702 | + $context['profile_onsubmit_javascript'] .= $cur_field['js_submit']; |
|
703 | + } |
|
704 | + if (!empty($cur_field['js'])) { |
|
705 | + $context['profile_javascript'] .= $cur_field['js']; |
|
706 | + } |
|
679 | 707 | |
680 | 708 | // Any template stuff? |
681 | - if (!empty($cur_field['prehtml'])) |
|
682 | - $context['profile_prehtml'] .= $cur_field['prehtml']; |
|
683 | - if (!empty($cur_field['posthtml'])) |
|
684 | - $context['profile_posthtml'] .= $cur_field['posthtml']; |
|
709 | + if (!empty($cur_field['prehtml'])) { |
|
710 | + $context['profile_prehtml'] .= $cur_field['prehtml']; |
|
711 | + } |
|
712 | + if (!empty($cur_field['posthtml'])) { |
|
713 | + $context['profile_posthtml'] .= $cur_field['posthtml']; |
|
714 | + } |
|
685 | 715 | |
686 | 716 | // Finally put it into context? |
687 | 717 | if ($cur_field['type'] != 'hidden') |
@@ -714,12 +744,14 @@ discard block |
||
714 | 744 | }, false);' : ''), true); |
715 | 745 | |
716 | 746 | // Any onsubmit javascript? |
717 | - if (!empty($context['profile_onsubmit_javascript'])) |
|
718 | - addInlineJavaScript($context['profile_onsubmit_javascript'], true); |
|
747 | + if (!empty($context['profile_onsubmit_javascript'])) { |
|
748 | + addInlineJavaScript($context['profile_onsubmit_javascript'], true); |
|
749 | + } |
|
719 | 750 | |
720 | 751 | // Any totally custom stuff? |
721 | - if (!empty($context['profile_javascript'])) |
|
722 | - addInlineJavaScript($context['profile_javascript'], true); |
|
752 | + if (!empty($context['profile_javascript'])) { |
|
753 | + addInlineJavaScript($context['profile_javascript'], true); |
|
754 | + } |
|
723 | 755 | |
724 | 756 | // Free up some memory. |
725 | 757 | unset($profile_fields); |
@@ -740,8 +772,9 @@ discard block |
||
740 | 772 | |
741 | 773 | // This allows variables to call activities when they save - by default just to reload their settings |
742 | 774 | $context['profile_execute_on_save'] = array(); |
743 | - if ($context['user']['is_owner']) |
|
744 | - $context['profile_execute_on_save']['reload_user'] = 'profileReloadUser'; |
|
775 | + if ($context['user']['is_owner']) { |
|
776 | + $context['profile_execute_on_save']['reload_user'] = 'profileReloadUser'; |
|
777 | + } |
|
745 | 778 | |
746 | 779 | // Assume we log nothing. |
747 | 780 | $context['log_changes'] = array(); |
@@ -749,8 +782,9 @@ discard block |
||
749 | 782 | // Cycle through the profile fields working out what to do! |
750 | 783 | foreach ($profile_fields as $key => $field) |
751 | 784 | { |
752 | - if (!isset($_POST[$key]) || !empty($field['is_dummy']) || (isset($_POST['preview_signature']) && $key == 'signature')) |
|
753 | - continue; |
|
785 | + if (!isset($_POST[$key]) || !empty($field['is_dummy']) || (isset($_POST['preview_signature']) && $key == 'signature')) { |
|
786 | + continue; |
|
787 | + } |
|
754 | 788 | |
755 | 789 | // What gets updated? |
756 | 790 | $db_key = isset($field['save_key']) ? $field['save_key'] : $key; |
@@ -778,12 +812,13 @@ discard block |
||
778 | 812 | $field['cast_type'] = empty($field['cast_type']) ? $field['type'] : $field['cast_type']; |
779 | 813 | |
780 | 814 | // Finally, clean up certain types. |
781 | - if ($field['cast_type'] == 'int') |
|
782 | - $_POST[$key] = (int) $_POST[$key]; |
|
783 | - elseif ($field['cast_type'] == 'float') |
|
784 | - $_POST[$key] = (float) $_POST[$key]; |
|
785 | - elseif ($field['cast_type'] == 'check') |
|
786 | - $_POST[$key] = !empty($_POST[$key]) ? 1 : 0; |
|
815 | + if ($field['cast_type'] == 'int') { |
|
816 | + $_POST[$key] = (int) $_POST[$key]; |
|
817 | + } elseif ($field['cast_type'] == 'float') { |
|
818 | + $_POST[$key] = (float) $_POST[$key]; |
|
819 | + } elseif ($field['cast_type'] == 'check') { |
|
820 | + $_POST[$key] = !empty($_POST[$key]) ? 1 : 0; |
|
821 | + } |
|
787 | 822 | |
788 | 823 | // If we got here we're doing OK. |
789 | 824 | if ($field['type'] != 'hidden' && (!isset($old_profile[$key]) || $_POST[$key] != $old_profile[$key])) |
@@ -794,11 +829,12 @@ discard block |
||
794 | 829 | $cur_profile[$key] = $_POST[$key]; |
795 | 830 | |
796 | 831 | // Are we logging it? |
797 | - if (!empty($field['log_change']) && isset($old_profile[$key])) |
|
798 | - $context['log_changes'][$key] = array( |
|
832 | + if (!empty($field['log_change']) && isset($old_profile[$key])) { |
|
833 | + $context['log_changes'][$key] = array( |
|
799 | 834 | 'previous' => $old_profile[$key], |
800 | 835 | 'new' => $_POST[$key], |
801 | 836 | ); |
837 | + } |
|
802 | 838 | } |
803 | 839 | |
804 | 840 | // Logging group changes are a bit different... |
@@ -831,10 +867,11 @@ discard block |
||
831 | 867 | { |
832 | 868 | foreach ($groups as $id => $group) |
833 | 869 | { |
834 | - if (isset($context['member_groups'][$group])) |
|
835 | - $additional_groups[$type][$id] = $context['member_groups'][$group]['name']; |
|
836 | - else |
|
837 | - unset($additional_groups[$type][$id]); |
|
870 | + if (isset($context['member_groups'][$group])) { |
|
871 | + $additional_groups[$type][$id] = $context['member_groups'][$group]['name']; |
|
872 | + } else { |
|
873 | + unset($additional_groups[$type][$id]); |
|
874 | + } |
|
838 | 875 | } |
839 | 876 | $additional_groups[$type] = implode(', ', $additional_groups[$type]); |
840 | 877 | } |
@@ -845,10 +882,11 @@ discard block |
||
845 | 882 | } |
846 | 883 | |
847 | 884 | // @todo Temporary |
848 | - if ($context['user']['is_owner']) |
|
849 | - $changeOther = allowedTo(array('profile_extra_any', 'profile_extra_own')); |
|
850 | - else |
|
851 | - $changeOther = allowedTo('profile_extra_any'); |
|
885 | + if ($context['user']['is_owner']) { |
|
886 | + $changeOther = allowedTo(array('profile_extra_any', 'profile_extra_own')); |
|
887 | + } else { |
|
888 | + $changeOther = allowedTo('profile_extra_any'); |
|
889 | + } |
|
852 | 890 | if ($changeOther && empty($post_errors)) |
853 | 891 | { |
854 | 892 | makeThemeChanges($context['id_member'], isset($_POST['id_theme']) ? (int) $_POST['id_theme'] : $old_profile['id_theme']); |
@@ -856,8 +894,9 @@ discard block |
||
856 | 894 | { |
857 | 895 | $custom_fields_errors = makeCustomFieldChanges($context['id_member'], $_REQUEST['sa'], false, true); |
858 | 896 | |
859 | - if (!empty($custom_fields_errors)) |
|
860 | - $post_errors = array_merge($post_errors, $custom_fields_errors); |
|
897 | + if (!empty($custom_fields_errors)) { |
|
898 | + $post_errors = array_merge($post_errors, $custom_fields_errors); |
|
899 | + } |
|
861 | 900 | } |
862 | 901 | } |
863 | 902 | |
@@ -883,9 +922,9 @@ discard block |
||
883 | 922 | if ($context['user']['is_owner']) |
884 | 923 | { |
885 | 924 | $changeOther = allowedTo(array('profile_extra_any', 'profile_extra_own', 'profile_website_any', 'profile_website_own', 'profile_signature_any', 'profile_signature_own')); |
925 | + } else { |
|
926 | + $changeOther = allowedTo(array('profile_extra_any', 'profile_website_any', 'profile_signature_any')); |
|
886 | 927 | } |
887 | - else |
|
888 | - $changeOther = allowedTo(array('profile_extra_any', 'profile_website_any', 'profile_signature_any')); |
|
889 | 928 | |
890 | 929 | // Arrays of all the changes - makes things easier. |
891 | 930 | $profile_bools = array(); |
@@ -896,22 +935,25 @@ discard block |
||
896 | 935 | 'ignore_boards', |
897 | 936 | ); |
898 | 937 | |
899 | - if (isset($_POST['sa']) && $_POST['sa'] == 'ignoreboards' && empty($_POST['ignore_brd'])) |
|
900 | - $_POST['ignore_brd'] = array(); |
|
938 | + if (isset($_POST['sa']) && $_POST['sa'] == 'ignoreboards' && empty($_POST['ignore_brd'])) { |
|
939 | + $_POST['ignore_brd'] = array(); |
|
940 | + } |
|
901 | 941 | |
902 | 942 | unset($_POST['ignore_boards']); // Whatever it is set to is a dirty filthy thing. Kinda like our minds. |
903 | 943 | if (isset($_POST['ignore_brd'])) |
904 | 944 | { |
905 | - if (!is_array($_POST['ignore_brd'])) |
|
906 | - $_POST['ignore_brd'] = array($_POST['ignore_brd']); |
|
945 | + if (!is_array($_POST['ignore_brd'])) { |
|
946 | + $_POST['ignore_brd'] = array($_POST['ignore_brd']); |
|
947 | + } |
|
907 | 948 | |
908 | 949 | foreach ($_POST['ignore_brd'] as $k => $d) |
909 | 950 | { |
910 | 951 | $d = (int) $d; |
911 | - if ($d != 0) |
|
912 | - $_POST['ignore_brd'][$k] = $d; |
|
913 | - else |
|
914 | - unset($_POST['ignore_brd'][$k]); |
|
952 | + if ($d != 0) { |
|
953 | + $_POST['ignore_brd'][$k] = $d; |
|
954 | + } else { |
|
955 | + unset($_POST['ignore_brd'][$k]); |
|
956 | + } |
|
915 | 957 | } |
916 | 958 | $_POST['ignore_boards'] = implode(',', $_POST['ignore_brd']); |
917 | 959 | unset($_POST['ignore_brd']); |
@@ -923,21 +965,26 @@ discard block |
||
923 | 965 | makeThemeChanges($memID, isset($_POST['id_theme']) ? (int) $_POST['id_theme'] : $old_profile['id_theme']); |
924 | 966 | //makeAvatarChanges($memID, $post_errors); |
925 | 967 | |
926 | - if (!empty($_REQUEST['sa'])) |
|
927 | - makeCustomFieldChanges($memID, $_REQUEST['sa'], false); |
|
968 | + if (!empty($_REQUEST['sa'])) { |
|
969 | + makeCustomFieldChanges($memID, $_REQUEST['sa'], false); |
|
970 | + } |
|
928 | 971 | |
929 | - foreach ($profile_bools as $var) |
|
930 | - if (isset($_POST[$var])) |
|
972 | + foreach ($profile_bools as $var) { |
|
973 | + if (isset($_POST[$var])) |
|
931 | 974 | $profile_vars[$var] = empty($_POST[$var]) ? '0' : '1'; |
932 | - foreach ($profile_ints as $var) |
|
933 | - if (isset($_POST[$var])) |
|
975 | + } |
|
976 | + foreach ($profile_ints as $var) { |
|
977 | + if (isset($_POST[$var])) |
|
934 | 978 | $profile_vars[$var] = $_POST[$var] != '' ? (int) $_POST[$var] : ''; |
935 | - foreach ($profile_floats as $var) |
|
936 | - if (isset($_POST[$var])) |
|
979 | + } |
|
980 | + foreach ($profile_floats as $var) { |
|
981 | + if (isset($_POST[$var])) |
|
937 | 982 | $profile_vars[$var] = (float) $_POST[$var]; |
938 | - foreach ($profile_strings as $var) |
|
939 | - if (isset($_POST[$var])) |
|
983 | + } |
|
984 | + foreach ($profile_strings as $var) { |
|
985 | + if (isset($_POST[$var])) |
|
940 | 986 | $profile_vars[$var] = $_POST[$var]; |
987 | + } |
|
941 | 988 | } |
942 | 989 | } |
943 | 990 | |
@@ -971,8 +1018,9 @@ discard block |
||
971 | 1018 | ); |
972 | 1019 | |
973 | 1020 | // Can't change reserved vars. |
974 | - if ((isset($_POST['options']) && count(array_intersect(array_keys($_POST['options']), $reservedVars)) != 0) || (isset($_POST['default_options']) && count(array_intersect(array_keys($_POST['default_options']), $reservedVars)) != 0)) |
|
975 | - fatal_lang_error('no_access', false); |
|
1021 | + if ((isset($_POST['options']) && count(array_intersect(array_keys($_POST['options']), $reservedVars)) != 0) || (isset($_POST['default_options']) && count(array_intersect(array_keys($_POST['default_options']), $reservedVars)) != 0)) { |
|
1022 | + fatal_lang_error('no_access', false); |
|
1023 | + } |
|
976 | 1024 | |
977 | 1025 | // Don't allow any overriding of custom fields with default or non-default options. |
978 | 1026 | $request = $smcFunc['db_query']('', ' |
@@ -984,8 +1032,9 @@ discard block |
||
984 | 1032 | ) |
985 | 1033 | ); |
986 | 1034 | $custom_fields = array(); |
987 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
988 | - $custom_fields[] = $row['col_name']; |
|
1035 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1036 | + $custom_fields[] = $row['col_name']; |
|
1037 | + } |
|
989 | 1038 | $smcFunc['db_free_result']($request); |
990 | 1039 | |
991 | 1040 | // These are the theme changes... |
@@ -994,33 +1043,39 @@ discard block |
||
994 | 1043 | { |
995 | 1044 | foreach ($_POST['options'] as $opt => $val) |
996 | 1045 | { |
997 | - if (in_array($opt, $custom_fields)) |
|
998 | - continue; |
|
1046 | + if (in_array($opt, $custom_fields)) { |
|
1047 | + continue; |
|
1048 | + } |
|
999 | 1049 | |
1000 | 1050 | // These need to be controlled. |
1001 | - if ($opt == 'topics_per_page' || $opt == 'messages_per_page') |
|
1002 | - $val = max(0, min($val, 50)); |
|
1051 | + if ($opt == 'topics_per_page' || $opt == 'messages_per_page') { |
|
1052 | + $val = max(0, min($val, 50)); |
|
1053 | + } |
|
1003 | 1054 | // We don't set this per theme anymore. |
1004 | - elseif ($opt == 'allow_no_censored') |
|
1005 | - continue; |
|
1055 | + elseif ($opt == 'allow_no_censored') { |
|
1056 | + continue; |
|
1057 | + } |
|
1006 | 1058 | |
1007 | 1059 | $themeSetArray[] = array($memID, $id_theme, $opt, is_array($val) ? implode(',', $val) : $val); |
1008 | 1060 | } |
1009 | 1061 | } |
1010 | 1062 | |
1011 | 1063 | $erase_options = array(); |
1012 | - if (isset($_POST['default_options']) && is_array($_POST['default_options'])) |
|
1013 | - foreach ($_POST['default_options'] as $opt => $val) |
|
1064 | + if (isset($_POST['default_options']) && is_array($_POST['default_options'])) { |
|
1065 | + foreach ($_POST['default_options'] as $opt => $val) |
|
1014 | 1066 | { |
1015 | 1067 | if (in_array($opt, $custom_fields)) |
1016 | 1068 | continue; |
1069 | + } |
|
1017 | 1070 | |
1018 | 1071 | // These need to be controlled. |
1019 | - if ($opt == 'topics_per_page' || $opt == 'messages_per_page') |
|
1020 | - $val = max(0, min($val, 50)); |
|
1072 | + if ($opt == 'topics_per_page' || $opt == 'messages_per_page') { |
|
1073 | + $val = max(0, min($val, 50)); |
|
1074 | + } |
|
1021 | 1075 | // Only let admins and owners change the censor. |
1022 | - elseif ($opt == 'allow_no_censored' && !$user_info['is_admin'] && !$context['user']['is_owner']) |
|
1023 | - continue; |
|
1076 | + elseif ($opt == 'allow_no_censored' && !$user_info['is_admin'] && !$context['user']['is_owner']) { |
|
1077 | + continue; |
|
1078 | + } |
|
1024 | 1079 | |
1025 | 1080 | $themeSetArray[] = array($memID, 1, $opt, is_array($val) ? implode(',', $val) : $val); |
1026 | 1081 | $erase_options[] = $opt; |
@@ -1056,8 +1111,9 @@ discard block |
||
1056 | 1111 | |
1057 | 1112 | // Admins can choose any theme, even if it's not enabled... |
1058 | 1113 | $themes = allowedTo('admin_forum') ? explode(',', $modSettings['knownThemes']) : explode(',', $modSettings['enableThemes']); |
1059 | - foreach ($themes as $t) |
|
1060 | - cache_put_data('theme_settings-' . $t . ':' . $memID, null, 60); |
|
1114 | + foreach ($themes as $t) { |
|
1115 | + cache_put_data('theme_settings-' . $t . ':' . $memID, null, 60); |
|
1116 | + } |
|
1061 | 1117 | } |
1062 | 1118 | } |
1063 | 1119 | |
@@ -1076,8 +1132,9 @@ discard block |
||
1076 | 1132 | if (isset($_POST['edit_notify_boards']) && !empty($_POST['notify_boards'])) |
1077 | 1133 | { |
1078 | 1134 | // Make sure only integers are deleted. |
1079 | - foreach ($_POST['notify_boards'] as $index => $id) |
|
1080 | - $_POST['notify_boards'][$index] = (int) $id; |
|
1135 | + foreach ($_POST['notify_boards'] as $index => $id) { |
|
1136 | + $_POST['notify_boards'][$index] = (int) $id; |
|
1137 | + } |
|
1081 | 1138 | |
1082 | 1139 | // id_board = 0 is reserved for topic notifications. |
1083 | 1140 | $_POST['notify_boards'] = array_diff($_POST['notify_boards'], array(0)); |
@@ -1096,8 +1153,9 @@ discard block |
||
1096 | 1153 | // We are editing topic notifications...... |
1097 | 1154 | elseif (isset($_POST['edit_notify_topics']) && !empty($_POST['notify_topics'])) |
1098 | 1155 | { |
1099 | - foreach ($_POST['notify_topics'] as $index => $id) |
|
1100 | - $_POST['notify_topics'][$index] = (int) $id; |
|
1156 | + foreach ($_POST['notify_topics'] as $index => $id) { |
|
1157 | + $_POST['notify_topics'][$index] = (int) $id; |
|
1158 | + } |
|
1101 | 1159 | |
1102 | 1160 | // Make sure there are no zeros left. |
1103 | 1161 | $_POST['notify_topics'] = array_diff($_POST['notify_topics'], array(0)); |
@@ -1111,16 +1169,18 @@ discard block |
||
1111 | 1169 | 'selected_member' => $memID, |
1112 | 1170 | ) |
1113 | 1171 | ); |
1114 | - foreach ($_POST['notify_topics'] as $topic) |
|
1115 | - setNotifyPrefs($memID, array('topic_notify_' . $topic => 0)); |
|
1172 | + foreach ($_POST['notify_topics'] as $topic) { |
|
1173 | + setNotifyPrefs($memID, array('topic_notify_' . $topic => 0)); |
|
1174 | + } |
|
1116 | 1175 | } |
1117 | 1176 | |
1118 | 1177 | // We are removing topic preferences |
1119 | 1178 | elseif (isset($_POST['remove_notify_topics']) && !empty($_POST['notify_topics'])) |
1120 | 1179 | { |
1121 | 1180 | $prefs = array(); |
1122 | - foreach ($_POST['notify_topics'] as $topic) |
|
1123 | - $prefs[] = 'topic_notify_' . $topic; |
|
1181 | + foreach ($_POST['notify_topics'] as $topic) { |
|
1182 | + $prefs[] = 'topic_notify_' . $topic; |
|
1183 | + } |
|
1124 | 1184 | deleteNotifyPrefs($memID, $prefs); |
1125 | 1185 | } |
1126 | 1186 | |
@@ -1128,8 +1188,9 @@ discard block |
||
1128 | 1188 | elseif (isset($_POST['remove_notify_board']) && !empty($_POST['notify_boards'])) |
1129 | 1189 | { |
1130 | 1190 | $prefs = array(); |
1131 | - foreach ($_POST['notify_boards'] as $board) |
|
1132 | - $prefs[] = 'board_notify_' . $board; |
|
1191 | + foreach ($_POST['notify_boards'] as $board) { |
|
1192 | + $prefs[] = 'board_notify_' . $board; |
|
1193 | + } |
|
1133 | 1194 | deleteNotifyPrefs($memID, $prefs); |
1134 | 1195 | } |
1135 | 1196 | } |
@@ -1150,8 +1211,9 @@ discard block |
||
1150 | 1211 | |
1151 | 1212 | $errors = array(); |
1152 | 1213 | |
1153 | - if ($sanitize && isset($_POST['customfield'])) |
|
1154 | - $_POST['customfield'] = htmlspecialchars__recursive($_POST['customfield']); |
|
1214 | + if ($sanitize && isset($_POST['customfield'])) { |
|
1215 | + $_POST['customfield'] = htmlspecialchars__recursive($_POST['customfield']); |
|
1216 | + } |
|
1155 | 1217 | |
1156 | 1218 | $where = $area == 'register' ? 'show_reg != 0' : 'show_profile = {string:area}'; |
1157 | 1219 | |
@@ -1177,26 +1239,29 @@ discard block |
||
1177 | 1239 | - The data is not invisible to users but editable by the owner (or if it is the user is not the owner) |
1178 | 1240 | - The area isn't registration, and if it is that the field is not supposed to be shown there. |
1179 | 1241 | */ |
1180 | - if ($row['private'] != 0 && !allowedTo('admin_forum') && ($memID != $user_info['id'] || $row['private'] != 2) && ($area != 'register' || $row['show_reg'] == 0)) |
|
1181 | - continue; |
|
1242 | + if ($row['private'] != 0 && !allowedTo('admin_forum') && ($memID != $user_info['id'] || $row['private'] != 2) && ($area != 'register' || $row['show_reg'] == 0)) { |
|
1243 | + continue; |
|
1244 | + } |
|
1182 | 1245 | |
1183 | 1246 | // Validate the user data. |
1184 | - if ($row['field_type'] == 'check') |
|
1185 | - $value = isset($_POST['customfield'][$row['col_name']]) ? 1 : 0; |
|
1186 | - elseif ($row['field_type'] == 'select' || $row['field_type'] == 'radio') |
|
1247 | + if ($row['field_type'] == 'check') { |
|
1248 | + $value = isset($_POST['customfield'][$row['col_name']]) ? 1 : 0; |
|
1249 | + } elseif ($row['field_type'] == 'select' || $row['field_type'] == 'radio') |
|
1187 | 1250 | { |
1188 | 1251 | $value = $row['default_value']; |
1189 | - foreach (explode(',', $row['field_options']) as $k => $v) |
|
1190 | - if (isset($_POST['customfield'][$row['col_name']]) && $_POST['customfield'][$row['col_name']] == $k) |
|
1252 | + foreach (explode(',', $row['field_options']) as $k => $v) { |
|
1253 | + if (isset($_POST['customfield'][$row['col_name']]) && $_POST['customfield'][$row['col_name']] == $k) |
|
1191 | 1254 | $value = $v; |
1255 | + } |
|
1192 | 1256 | } |
1193 | 1257 | // Otherwise some form of text! |
1194 | 1258 | else |
1195 | 1259 | { |
1196 | 1260 | $value = isset($_POST['customfield'][$row['col_name']]) ? $_POST['customfield'][$row['col_name']] : ''; |
1197 | 1261 | |
1198 | - if ($row['field_length']) |
|
1199 | - $value = $smcFunc['substr']($value, 0, $row['field_length']); |
|
1262 | + if ($row['field_length']) { |
|
1263 | + $value = $smcFunc['substr']($value, 0, $row['field_length']); |
|
1264 | + } |
|
1200 | 1265 | |
1201 | 1266 | // Any masks? |
1202 | 1267 | if ($row['field_type'] == 'text' && !empty($row['mask']) && $row['mask'] != 'none') |
@@ -1205,36 +1270,34 @@ discard block |
||
1205 | 1270 | $valueReference = un_htmlspecialchars($value); |
1206 | 1271 | |
1207 | 1272 | // Try and avoid some checks. '0' could be a valid non-empty value. |
1208 | - if (empty($value) && !is_numeric($value)) |
|
1209 | - $value = ''; |
|
1273 | + if (empty($value) && !is_numeric($value)) { |
|
1274 | + $value = ''; |
|
1275 | + } |
|
1210 | 1276 | |
1211 | 1277 | if ($row['mask'] == 'nohtml' && ($valueReference != strip_tags($valueReference) || $value != filter_var($value, FILTER_SANITIZE_STRING) || preg_match('/<(.+?)[\s]*\/?[\s]*>/si', $valueReference))) |
1212 | 1278 | { |
1213 | - if ($returnErrors) |
|
1214 | - $errors[] = 'custom_field_nohtml_fail'; |
|
1215 | - |
|
1216 | - else |
|
1217 | - $value = ''; |
|
1218 | - } |
|
1219 | - elseif ($row['mask'] == 'email' && (!filter_var($value, FILTER_VALIDATE_EMAIL) || strlen($value) > 255)) |
|
1279 | + if ($returnErrors) { |
|
1280 | + $errors[] = 'custom_field_nohtml_fail'; |
|
1281 | + } else { |
|
1282 | + $value = ''; |
|
1283 | + } |
|
1284 | + } elseif ($row['mask'] == 'email' && (!filter_var($value, FILTER_VALIDATE_EMAIL) || strlen($value) > 255)) |
|
1220 | 1285 | { |
1221 | - if ($returnErrors) |
|
1222 | - $errors[] = 'custom_field_mail_fail'; |
|
1223 | - |
|
1224 | - else |
|
1225 | - $value = ''; |
|
1226 | - } |
|
1227 | - elseif ($row['mask'] == 'number') |
|
1286 | + if ($returnErrors) { |
|
1287 | + $errors[] = 'custom_field_mail_fail'; |
|
1288 | + } else { |
|
1289 | + $value = ''; |
|
1290 | + } |
|
1291 | + } elseif ($row['mask'] == 'number') |
|
1228 | 1292 | { |
1229 | 1293 | $value = (int) $value; |
1230 | - } |
|
1231 | - elseif (substr($row['mask'], 0, 5) == 'regex' && trim($value) != '' && preg_match(substr($row['mask'], 5), $value) === 0) |
|
1294 | + } elseif (substr($row['mask'], 0, 5) == 'regex' && trim($value) != '' && preg_match(substr($row['mask'], 5), $value) === 0) |
|
1232 | 1295 | { |
1233 | - if ($returnErrors) |
|
1234 | - $errors[] = 'custom_field_regex_fail'; |
|
1235 | - |
|
1236 | - else |
|
1237 | - $value = ''; |
|
1296 | + if ($returnErrors) { |
|
1297 | + $errors[] = 'custom_field_regex_fail'; |
|
1298 | + } else { |
|
1299 | + $value = ''; |
|
1300 | + } |
|
1238 | 1301 | } |
1239 | 1302 | |
1240 | 1303 | unset($valueReference); |
@@ -1258,8 +1321,7 @@ discard block |
||
1258 | 1321 | { |
1259 | 1322 | $deletes = array('id_theme' => 1 , 'variable' => $row['col_name'], 'id_member' => $memID); |
1260 | 1323 | unset($user_profile[$memID]['options'][$row['col_name']]); |
1261 | - } |
|
1262 | - else |
|
1324 | + } else |
|
1263 | 1325 | { |
1264 | 1326 | $changes[] = array(1, $row['col_name'], $value, $memID); |
1265 | 1327 | $user_profile[$memID]['options'][$row['col_name']] = $value; |
@@ -1270,27 +1332,30 @@ discard block |
||
1270 | 1332 | |
1271 | 1333 | $hook_errors = call_integration_hook('integrate_save_custom_profile_fields', array(&$changes, &$log_changes, &$errors, $returnErrors, $memID, $area, $sanitize, &$deletes)); |
1272 | 1334 | |
1273 | - if (!empty($hook_errors) && is_array($hook_errors)) |
|
1274 | - $errors = array_merge($errors, $hook_errors); |
|
1335 | + if (!empty($hook_errors) && is_array($hook_errors)) { |
|
1336 | + $errors = array_merge($errors, $hook_errors); |
|
1337 | + } |
|
1275 | 1338 | |
1276 | 1339 | // Make those changes! |
1277 | 1340 | if ((!empty($changes) || !empty($deletes)) && empty($context['password_auth_failed']) && empty($errors)) |
1278 | 1341 | { |
1279 | - if (!empty($changes)) |
|
1280 | - $smcFunc['db_insert']('replace', |
|
1342 | + if (!empty($changes)) { |
|
1343 | + $smcFunc['db_insert']('replace', |
|
1281 | 1344 | '{db_prefix}themes', |
1282 | 1345 | array('id_theme' => 'int', 'variable' => 'string-255', 'value' => 'string-65534', 'id_member' => 'int'), |
1283 | 1346 | $changes, |
1284 | 1347 | array('id_theme', 'variable', 'id_member') |
1285 | 1348 | ); |
1286 | - if (!empty($deletes)) |
|
1287 | - $smcFunc['db_query']('',' |
|
1349 | + } |
|
1350 | + if (!empty($deletes)) { |
|
1351 | + $smcFunc['db_query']('',' |
|
1288 | 1352 | DELETE FROM {db_prefix}themes |
1289 | 1353 | WHERE id_theme = {int:id_theme} AND |
1290 | 1354 | variable = {string:variable} AND |
1291 | 1355 | id_member = {int:id_member}', |
1292 | 1356 | $deletes |
1293 | 1357 | ); |
1358 | + } |
|
1294 | 1359 | if (!empty($log_changes) && !empty($modSettings['modlog_enabled'])) |
1295 | 1360 | { |
1296 | 1361 | require_once($sourcedir . '/Logging.php'); |
@@ -1298,9 +1363,10 @@ discard block |
||
1298 | 1363 | } |
1299 | 1364 | } |
1300 | 1365 | |
1301 | - if ($returnErrors) |
|
1302 | - return $errors; |
|
1303 | -} |
|
1366 | + if ($returnErrors) { |
|
1367 | + return $errors; |
|
1368 | + } |
|
1369 | + } |
|
1304 | 1370 | |
1305 | 1371 | /** |
1306 | 1372 | * Show all the users buddies, as well as a add/delete interface. |
@@ -1312,8 +1378,9 @@ discard block |
||
1312 | 1378 | global $context, $txt, $modSettings; |
1313 | 1379 | |
1314 | 1380 | // Do a quick check to ensure people aren't getting here illegally! |
1315 | - if (!$context['user']['is_owner'] || empty($modSettings['enable_buddylist'])) |
|
1316 | - fatal_lang_error('no_access', false); |
|
1381 | + if (!$context['user']['is_owner'] || empty($modSettings['enable_buddylist'])) { |
|
1382 | + fatal_lang_error('no_access', false); |
|
1383 | + } |
|
1317 | 1384 | |
1318 | 1385 | // Can we email the user direct? |
1319 | 1386 | $context['can_moderate_forum'] = allowedTo('moderate_forum'); |
@@ -1343,9 +1410,10 @@ discard block |
||
1343 | 1410 | $context['sub_template'] = $subActions[$context['list_area']][0]; |
1344 | 1411 | $call = call_helper($subActions[$context['list_area']][0], true); |
1345 | 1412 | |
1346 | - if (!empty($call)) |
|
1347 | - call_user_func($call, $memID); |
|
1348 | -} |
|
1413 | + if (!empty($call)) { |
|
1414 | + call_user_func($call, $memID); |
|
1415 | + } |
|
1416 | + } |
|
1349 | 1417 | |
1350 | 1418 | /** |
1351 | 1419 | * Show all the users buddies, as well as a add/delete interface. |
@@ -1359,9 +1427,10 @@ discard block |
||
1359 | 1427 | |
1360 | 1428 | // For making changes! |
1361 | 1429 | $buddiesArray = explode(',', $user_profile[$memID]['buddy_list']); |
1362 | - foreach ($buddiesArray as $k => $dummy) |
|
1363 | - if ($dummy == '') |
|
1430 | + foreach ($buddiesArray as $k => $dummy) { |
|
1431 | + if ($dummy == '') |
|
1364 | 1432 | unset($buddiesArray[$k]); |
1433 | + } |
|
1365 | 1434 | |
1366 | 1435 | // Removing a buddy? |
1367 | 1436 | if (isset($_GET['remove'])) |
@@ -1373,10 +1442,11 @@ discard block |
||
1373 | 1442 | $_SESSION['prf-save'] = $txt['could_not_remove_person']; |
1374 | 1443 | |
1375 | 1444 | // Heh, I'm lazy, do it the easy way... |
1376 | - foreach ($buddiesArray as $key => $buddy) |
|
1377 | - if ($buddy == (int) $_GET['remove']) |
|
1445 | + foreach ($buddiesArray as $key => $buddy) { |
|
1446 | + if ($buddy == (int) $_GET['remove']) |
|
1378 | 1447 | { |
1379 | 1448 | unset($buddiesArray[$key]); |
1449 | + } |
|
1380 | 1450 | $_SESSION['prf-save'] = true; |
1381 | 1451 | } |
1382 | 1452 | |
@@ -1386,8 +1456,7 @@ discard block |
||
1386 | 1456 | |
1387 | 1457 | // Redirect off the page because we don't like all this ugly query stuff to stick in the history. |
1388 | 1458 | redirectexit('action=profile;area=lists;sa=buddies;u=' . $memID); |
1389 | - } |
|
1390 | - elseif (isset($_POST['new_buddy'])) |
|
1459 | + } elseif (isset($_POST['new_buddy'])) |
|
1391 | 1460 | { |
1392 | 1461 | checkSession(); |
1393 | 1462 | |
@@ -1400,8 +1469,9 @@ discard block |
||
1400 | 1469 | { |
1401 | 1470 | $new_buddies[$k] = strtr(trim($new_buddies[$k]), array('\'' => ''')); |
1402 | 1471 | |
1403 | - if (strlen($new_buddies[$k]) == 0 || in_array($new_buddies[$k], array($user_profile[$memID]['member_name'], $user_profile[$memID]['real_name']))) |
|
1404 | - unset($new_buddies[$k]); |
|
1472 | + if (strlen($new_buddies[$k]) == 0 || in_array($new_buddies[$k], array($user_profile[$memID]['member_name'], $user_profile[$memID]['real_name']))) { |
|
1473 | + unset($new_buddies[$k]); |
|
1474 | + } |
|
1405 | 1475 | } |
1406 | 1476 | |
1407 | 1477 | call_integration_hook('integrate_add_buddies', array($memID, &$new_buddies)); |
@@ -1421,16 +1491,18 @@ discard block |
||
1421 | 1491 | ) |
1422 | 1492 | ); |
1423 | 1493 | |
1424 | - if ($smcFunc['db_num_rows']($request) != 0) |
|
1425 | - $_SESSION['prf-save'] = true; |
|
1494 | + if ($smcFunc['db_num_rows']($request) != 0) { |
|
1495 | + $_SESSION['prf-save'] = true; |
|
1496 | + } |
|
1426 | 1497 | |
1427 | 1498 | // Add the new member to the buddies array. |
1428 | 1499 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1429 | 1500 | { |
1430 | - if (in_array($row['id_member'], $buddiesArray)) |
|
1431 | - continue; |
|
1432 | - else |
|
1433 | - $buddiesArray[] = (int) $row['id_member']; |
|
1501 | + if (in_array($row['id_member'], $buddiesArray)) { |
|
1502 | + continue; |
|
1503 | + } else { |
|
1504 | + $buddiesArray[] = (int) $row['id_member']; |
|
1505 | + } |
|
1434 | 1506 | } |
1435 | 1507 | $smcFunc['db_free_result']($request); |
1436 | 1508 | |
@@ -1460,18 +1532,20 @@ discard block |
||
1460 | 1532 | |
1461 | 1533 | $context['custom_pf'] = array(); |
1462 | 1534 | $disabled_fields = isset($modSettings['disabled_profile_fields']) ? array_flip(explode(',', $modSettings['disabled_profile_fields'])) : array(); |
1463 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1464 | - if (!isset($disabled_fields[$row['col_name']])) |
|
1535 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1536 | + if (!isset($disabled_fields[$row['col_name']])) |
|
1465 | 1537 | $context['custom_pf'][$row['col_name']] = array( |
1466 | 1538 | 'label' => $row['field_name'], |
1467 | 1539 | 'type' => $row['field_type'], |
1468 | 1540 | 'bbc' => !empty($row['bbc']), |
1469 | 1541 | 'enclose' => $row['enclose'], |
1470 | 1542 | ); |
1543 | + } |
|
1471 | 1544 | |
1472 | 1545 | // Gotta disable the gender option. |
1473 | - if (isset($context['custom_pf']['cust_gender']) && $context['custom_pf']['cust_gender'] == 'None') |
|
1474 | - unset($context['custom_pf']['cust_gender']); |
|
1546 | + if (isset($context['custom_pf']['cust_gender']) && $context['custom_pf']['cust_gender'] == 'None') { |
|
1547 | + unset($context['custom_pf']['cust_gender']); |
|
1548 | + } |
|
1475 | 1549 | |
1476 | 1550 | $smcFunc['db_free_result']($request); |
1477 | 1551 | |
@@ -1488,8 +1562,9 @@ discard block |
||
1488 | 1562 | 'buddy_list_count' => substr_count($user_profile[$memID]['buddy_list'], ',') + 1, |
1489 | 1563 | ) |
1490 | 1564 | ); |
1491 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
1492 | - $buddies[] = $row['id_member']; |
|
1565 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
1566 | + $buddies[] = $row['id_member']; |
|
1567 | + } |
|
1493 | 1568 | $smcFunc['db_free_result']($result); |
1494 | 1569 | } |
1495 | 1570 | |
@@ -1517,30 +1592,32 @@ discard block |
||
1517 | 1592 | continue; |
1518 | 1593 | } |
1519 | 1594 | |
1520 | - if ($column['bbc'] && !empty($context['buddies'][$buddy]['options'][$key])) |
|
1521 | - $context['buddies'][$buddy]['options'][$key] = strip_tags(parse_bbc($context['buddies'][$buddy]['options'][$key])); |
|
1522 | - |
|
1523 | - elseif ($column['type'] == 'check') |
|
1524 | - $context['buddies'][$buddy]['options'][$key] = $context['buddies'][$buddy]['options'][$key] == 0 ? $txt['no'] : $txt['yes']; |
|
1595 | + if ($column['bbc'] && !empty($context['buddies'][$buddy]['options'][$key])) { |
|
1596 | + $context['buddies'][$buddy]['options'][$key] = strip_tags(parse_bbc($context['buddies'][$buddy]['options'][$key])); |
|
1597 | + } elseif ($column['type'] == 'check') { |
|
1598 | + $context['buddies'][$buddy]['options'][$key] = $context['buddies'][$buddy]['options'][$key] == 0 ? $txt['no'] : $txt['yes']; |
|
1599 | + } |
|
1525 | 1600 | |
1526 | 1601 | // Enclosing the user input within some other text? |
1527 | - if (!empty($column['enclose']) && !empty($context['buddies'][$buddy]['options'][$key])) |
|
1528 | - $context['buddies'][$buddy]['options'][$key] = strtr($column['enclose'], array( |
|
1602 | + if (!empty($column['enclose']) && !empty($context['buddies'][$buddy]['options'][$key])) { |
|
1603 | + $context['buddies'][$buddy]['options'][$key] = strtr($column['enclose'], array( |
|
1529 | 1604 | '{SCRIPTURL}' => $scripturl, |
1530 | 1605 | '{IMAGES_URL}' => $settings['images_url'], |
1531 | 1606 | '{DEFAULT_IMAGES_URL}' => $settings['default_images_url'], |
1532 | 1607 | '{INPUT}' => $context['buddies'][$buddy]['options'][$key], |
1533 | 1608 | )); |
1609 | + } |
|
1534 | 1610 | } |
1535 | 1611 | } |
1536 | 1612 | } |
1537 | 1613 | |
1538 | 1614 | if (isset($_SESSION['prf-save'])) |
1539 | 1615 | { |
1540 | - if ($_SESSION['prf-save'] === true) |
|
1541 | - $context['saved_successful'] = true; |
|
1542 | - else |
|
1543 | - $context['saved_failed'] = $_SESSION['prf-save']; |
|
1616 | + if ($_SESSION['prf-save'] === true) { |
|
1617 | + $context['saved_successful'] = true; |
|
1618 | + } else { |
|
1619 | + $context['saved_failed'] = $_SESSION['prf-save']; |
|
1620 | + } |
|
1544 | 1621 | |
1545 | 1622 | unset($_SESSION['prf-save']); |
1546 | 1623 | } |
@@ -1560,9 +1637,10 @@ discard block |
||
1560 | 1637 | |
1561 | 1638 | // For making changes! |
1562 | 1639 | $ignoreArray = explode(',', $user_profile[$memID]['pm_ignore_list']); |
1563 | - foreach ($ignoreArray as $k => $dummy) |
|
1564 | - if ($dummy == '') |
|
1640 | + foreach ($ignoreArray as $k => $dummy) { |
|
1641 | + if ($dummy == '') |
|
1565 | 1642 | unset($ignoreArray[$k]); |
1643 | + } |
|
1566 | 1644 | |
1567 | 1645 | // Removing a member from the ignore list? |
1568 | 1646 | if (isset($_GET['remove'])) |
@@ -1572,10 +1650,11 @@ discard block |
||
1572 | 1650 | $_SESSION['prf-save'] = $txt['could_not_remove_person']; |
1573 | 1651 | |
1574 | 1652 | // Heh, I'm lazy, do it the easy way... |
1575 | - foreach ($ignoreArray as $key => $id_remove) |
|
1576 | - if ($id_remove == (int) $_GET['remove']) |
|
1653 | + foreach ($ignoreArray as $key => $id_remove) { |
|
1654 | + if ($id_remove == (int) $_GET['remove']) |
|
1577 | 1655 | { |
1578 | 1656 | unset($ignoreArray[$key]); |
1657 | + } |
|
1579 | 1658 | $_SESSION['prf-save'] = true; |
1580 | 1659 | } |
1581 | 1660 | |
@@ -1585,8 +1664,7 @@ discard block |
||
1585 | 1664 | |
1586 | 1665 | // Redirect off the page because we don't like all this ugly query stuff to stick in the history. |
1587 | 1666 | redirectexit('action=profile;area=lists;sa=ignore;u=' . $memID); |
1588 | - } |
|
1589 | - elseif (isset($_POST['new_ignore'])) |
|
1667 | + } elseif (isset($_POST['new_ignore'])) |
|
1590 | 1668 | { |
1591 | 1669 | checkSession(); |
1592 | 1670 | // Prepare the string for extraction... |
@@ -1598,8 +1676,9 @@ discard block |
||
1598 | 1676 | { |
1599 | 1677 | $new_entries[$k] = strtr(trim($new_entries[$k]), array('\'' => ''')); |
1600 | 1678 | |
1601 | - if (strlen($new_entries[$k]) == 0 || in_array($new_entries[$k], array($user_profile[$memID]['member_name'], $user_profile[$memID]['real_name']))) |
|
1602 | - unset($new_entries[$k]); |
|
1679 | + if (strlen($new_entries[$k]) == 0 || in_array($new_entries[$k], array($user_profile[$memID]['member_name'], $user_profile[$memID]['real_name']))) { |
|
1680 | + unset($new_entries[$k]); |
|
1681 | + } |
|
1603 | 1682 | } |
1604 | 1683 | |
1605 | 1684 | $_SESSION['prf-save'] = $txt['could_not_add_person']; |
@@ -1617,16 +1696,18 @@ discard block |
||
1617 | 1696 | ) |
1618 | 1697 | ); |
1619 | 1698 | |
1620 | - if ($smcFunc['db_num_rows']($request) != 0) |
|
1621 | - $_SESSION['prf-save'] = true; |
|
1699 | + if ($smcFunc['db_num_rows']($request) != 0) { |
|
1700 | + $_SESSION['prf-save'] = true; |
|
1701 | + } |
|
1622 | 1702 | |
1623 | 1703 | // Add the new member to the buddies array. |
1624 | 1704 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1625 | 1705 | { |
1626 | - if (in_array($row['id_member'], $ignoreArray)) |
|
1627 | - continue; |
|
1628 | - else |
|
1629 | - $ignoreArray[] = (int) $row['id_member']; |
|
1706 | + if (in_array($row['id_member'], $ignoreArray)) { |
|
1707 | + continue; |
|
1708 | + } else { |
|
1709 | + $ignoreArray[] = (int) $row['id_member']; |
|
1710 | + } |
|
1630 | 1711 | } |
1631 | 1712 | $smcFunc['db_free_result']($request); |
1632 | 1713 | |
@@ -1655,8 +1736,9 @@ discard block |
||
1655 | 1736 | 'ignore_list_count' => substr_count($user_profile[$memID]['pm_ignore_list'], ',') + 1, |
1656 | 1737 | ) |
1657 | 1738 | ); |
1658 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
1659 | - $ignored[] = $row['id_member']; |
|
1739 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
1740 | + $ignored[] = $row['id_member']; |
|
1741 | + } |
|
1660 | 1742 | $smcFunc['db_free_result']($result); |
1661 | 1743 | } |
1662 | 1744 | |
@@ -1675,10 +1757,11 @@ discard block |
||
1675 | 1757 | |
1676 | 1758 | if (isset($_SESSION['prf-save'])) |
1677 | 1759 | { |
1678 | - if ($_SESSION['prf-save'] === true) |
|
1679 | - $context['saved_successful'] = true; |
|
1680 | - else |
|
1681 | - $context['saved_failed'] = $_SESSION['prf-save']; |
|
1760 | + if ($_SESSION['prf-save'] === true) { |
|
1761 | + $context['saved_successful'] = true; |
|
1762 | + } else { |
|
1763 | + $context['saved_failed'] = $_SESSION['prf-save']; |
|
1764 | + } |
|
1682 | 1765 | |
1683 | 1766 | unset($_SESSION['prf-save']); |
1684 | 1767 | } |
@@ -1694,8 +1777,9 @@ discard block |
||
1694 | 1777 | global $context, $txt; |
1695 | 1778 | |
1696 | 1779 | loadThemeOptions($memID); |
1697 | - if (allowedTo(array('profile_identity_own', 'profile_identity_any', 'profile_password_own', 'profile_password_any'))) |
|
1698 | - loadCustomFields($memID, 'account'); |
|
1780 | + if (allowedTo(array('profile_identity_own', 'profile_identity_any', 'profile_password_own', 'profile_password_any'))) { |
|
1781 | + loadCustomFields($memID, 'account'); |
|
1782 | + } |
|
1699 | 1783 | |
1700 | 1784 | $context['sub_template'] = 'edit_options'; |
1701 | 1785 | $context['page_desc'] = $txt['account_info']; |
@@ -1722,8 +1806,9 @@ discard block |
||
1722 | 1806 | global $context, $txt; |
1723 | 1807 | |
1724 | 1808 | loadThemeOptions($memID); |
1725 | - if (allowedTo(array('profile_forum_own', 'profile_forum_any'))) |
|
1726 | - loadCustomFields($memID, 'forumprofile'); |
|
1809 | + if (allowedTo(array('profile_forum_own', 'profile_forum_any'))) { |
|
1810 | + loadCustomFields($memID, 'forumprofile'); |
|
1811 | + } |
|
1727 | 1812 | |
1728 | 1813 | $context['sub_template'] = 'edit_options'; |
1729 | 1814 | $context['page_desc'] = $txt['forumProfile_info']; |
@@ -1756,18 +1841,21 @@ discard block |
||
1756 | 1841 | $dirs = array(); |
1757 | 1842 | $files = array(); |
1758 | 1843 | |
1759 | - if (!$dir) |
|
1760 | - return array(); |
|
1844 | + if (!$dir) { |
|
1845 | + return array(); |
|
1846 | + } |
|
1761 | 1847 | |
1762 | 1848 | while ($line = $dir->read()) |
1763 | 1849 | { |
1764 | - if (in_array($line, array('.', '..', 'blank.png', 'index.php'))) |
|
1765 | - continue; |
|
1850 | + if (in_array($line, array('.', '..', 'blank.png', 'index.php'))) { |
|
1851 | + continue; |
|
1852 | + } |
|
1766 | 1853 | |
1767 | - if (is_dir($modSettings['avatar_directory'] . '/' . $directory . (!empty($directory) ? '/' : '') . $line)) |
|
1768 | - $dirs[] = $line; |
|
1769 | - else |
|
1770 | - $files[] = $line; |
|
1854 | + if (is_dir($modSettings['avatar_directory'] . '/' . $directory . (!empty($directory) ? '/' : '') . $line)) { |
|
1855 | + $dirs[] = $line; |
|
1856 | + } else { |
|
1857 | + $files[] = $line; |
|
1858 | + } |
|
1771 | 1859 | } |
1772 | 1860 | $dir->close(); |
1773 | 1861 | |
@@ -1788,14 +1876,15 @@ discard block |
||
1788 | 1876 | foreach ($dirs as $line) |
1789 | 1877 | { |
1790 | 1878 | $tmp = getAvatars($directory . (!empty($directory) ? '/' : '') . $line, $level + 1); |
1791 | - if (!empty($tmp)) |
|
1792 | - $result[] = array( |
|
1879 | + if (!empty($tmp)) { |
|
1880 | + $result[] = array( |
|
1793 | 1881 | 'filename' => $smcFunc['htmlspecialchars']($line), |
1794 | 1882 | 'checked' => strpos($context['member']['avatar']['server_pic'], $line . '/') !== false, |
1795 | 1883 | 'name' => '[' . $smcFunc['htmlspecialchars'](str_replace('_', ' ', $line)) . ']', |
1796 | 1884 | 'is_dir' => true, |
1797 | 1885 | 'files' => $tmp |
1798 | 1886 | ); |
1887 | + } |
|
1799 | 1888 | unset($tmp); |
1800 | 1889 | } |
1801 | 1890 | |
@@ -1805,8 +1894,9 @@ discard block |
||
1805 | 1894 | $extension = substr(strrchr($line, '.'), 1); |
1806 | 1895 | |
1807 | 1896 | // Make sure it is an image. |
1808 | - if (strcasecmp($extension, 'gif') != 0 && strcasecmp($extension, 'jpg') != 0 && strcasecmp($extension, 'jpeg') != 0 && strcasecmp($extension, 'png') != 0 && strcasecmp($extension, 'bmp') != 0) |
|
1809 | - continue; |
|
1897 | + if (strcasecmp($extension, 'gif') != 0 && strcasecmp($extension, 'jpg') != 0 && strcasecmp($extension, 'jpeg') != 0 && strcasecmp($extension, 'png') != 0 && strcasecmp($extension, 'bmp') != 0) { |
|
1898 | + continue; |
|
1899 | + } |
|
1810 | 1900 | |
1811 | 1901 | $result[] = array( |
1812 | 1902 | 'filename' => $smcFunc['htmlspecialchars']($line), |
@@ -1814,8 +1904,9 @@ discard block |
||
1814 | 1904 | 'name' => $smcFunc['htmlspecialchars'](str_replace('_', ' ', $filename)), |
1815 | 1905 | 'is_dir' => false |
1816 | 1906 | ); |
1817 | - if ($level == 1) |
|
1818 | - $context['avatar_list'][] = $directory . '/' . $line; |
|
1907 | + if ($level == 1) { |
|
1908 | + $context['avatar_list'][] = $directory . '/' . $line; |
|
1909 | + } |
|
1819 | 1910 | } |
1820 | 1911 | |
1821 | 1912 | return $result; |
@@ -1837,8 +1928,9 @@ discard block |
||
1837 | 1928 | call_integration_hook('integrate_theme_options'); |
1838 | 1929 | |
1839 | 1930 | loadThemeOptions($memID); |
1840 | - if (allowedTo(array('profile_extra_own', 'profile_extra_any'))) |
|
1841 | - loadCustomFields($memID, 'theme'); |
|
1931 | + if (allowedTo(array('profile_extra_own', 'profile_extra_any'))) { |
|
1932 | + loadCustomFields($memID, 'theme'); |
|
1933 | + } |
|
1842 | 1934 | |
1843 | 1935 | $context['sub_template'] = 'edit_options'; |
1844 | 1936 | $context['page_desc'] = $txt['theme_info']; |
@@ -1892,16 +1984,19 @@ discard block |
||
1892 | 1984 | { |
1893 | 1985 | global $txt, $context, $modSettings, $smcFunc, $sourcedir; |
1894 | 1986 | |
1895 | - if (!isset($context['token_check'])) |
|
1896 | - $context['token_check'] = 'profile-nt' . $memID; |
|
1987 | + if (!isset($context['token_check'])) { |
|
1988 | + $context['token_check'] = 'profile-nt' . $memID; |
|
1989 | + } |
|
1897 | 1990 | |
1898 | 1991 | is_not_guest(); |
1899 | - if (!$context['user']['is_owner']) |
|
1900 | - isAllowedTo('profile_extra_any'); |
|
1992 | + if (!$context['user']['is_owner']) { |
|
1993 | + isAllowedTo('profile_extra_any'); |
|
1994 | + } |
|
1901 | 1995 | |
1902 | 1996 | // Set the post action if we're coming from the profile... |
1903 | - if (!isset($context['action'])) |
|
1904 | - $context['action'] = 'action=profile;area=notification;sa=alerts;u=' . $memID; |
|
1997 | + if (!isset($context['action'])) { |
|
1998 | + $context['action'] = 'action=profile;area=notification;sa=alerts;u=' . $memID; |
|
1999 | + } |
|
1905 | 2000 | |
1906 | 2001 | // What options are set |
1907 | 2002 | loadThemeOptions($memID); |
@@ -1988,28 +2083,34 @@ discard block |
||
1988 | 2083 | ); |
1989 | 2084 | |
1990 | 2085 | // There are certain things that are disabled at the group level. |
1991 | - if (empty($modSettings['cal_enabled'])) |
|
1992 | - unset($alert_types['calendar']); |
|
2086 | + if (empty($modSettings['cal_enabled'])) { |
|
2087 | + unset($alert_types['calendar']); |
|
2088 | + } |
|
1993 | 2089 | |
1994 | 2090 | // Disable paid subscriptions at group level if they're disabled |
1995 | - if (empty($modSettings['paid_enabled'])) |
|
1996 | - unset($alert_types['paidsubs']); |
|
2091 | + if (empty($modSettings['paid_enabled'])) { |
|
2092 | + unset($alert_types['paidsubs']); |
|
2093 | + } |
|
1997 | 2094 | |
1998 | 2095 | // Disable membergroup requests at group level if they're disabled |
1999 | - if (empty($modSettings['show_group_membership'])) |
|
2000 | - unset($alert_types['groupr'], $alert_types['members']['request_group']); |
|
2096 | + if (empty($modSettings['show_group_membership'])) { |
|
2097 | + unset($alert_types['groupr'], $alert_types['members']['request_group']); |
|
2098 | + } |
|
2001 | 2099 | |
2002 | 2100 | // Disable mentions if they're disabled |
2003 | - if (empty($modSettings['enable_mentions'])) |
|
2004 | - unset($alert_types['msg']['msg_mention']); |
|
2101 | + if (empty($modSettings['enable_mentions'])) { |
|
2102 | + unset($alert_types['msg']['msg_mention']); |
|
2103 | + } |
|
2005 | 2104 | |
2006 | 2105 | // Disable likes if they're disabled |
2007 | - if (empty($modSettings['enable_likes'])) |
|
2008 | - unset($alert_types['msg']['msg_like']); |
|
2106 | + if (empty($modSettings['enable_likes'])) { |
|
2107 | + unset($alert_types['msg']['msg_like']); |
|
2108 | + } |
|
2009 | 2109 | |
2010 | 2110 | // Disable buddy requests if they're disabled |
2011 | - if (empty($modSettings['enable_buddylist'])) |
|
2012 | - unset($alert_types['members']['buddy_request']); |
|
2111 | + if (empty($modSettings['enable_buddylist'])) { |
|
2112 | + unset($alert_types['members']['buddy_request']); |
|
2113 | + } |
|
2013 | 2114 | |
2014 | 2115 | // Now, now, we could pass this through global but we should really get into the habit of |
2015 | 2116 | // passing content to hooks, not expecting hooks to splatter everything everywhere. |
@@ -2037,15 +2138,17 @@ discard block |
||
2037 | 2138 | $perms_cache['manage_membergroups'] = in_array($memID, $members); |
2038 | 2139 | } |
2039 | 2140 | |
2040 | - if (!($perms_cache['manage_membergroups'] || $can_mod != 0)) |
|
2041 | - unset($alert_types['members']['request_group']); |
|
2141 | + if (!($perms_cache['manage_membergroups'] || $can_mod != 0)) { |
|
2142 | + unset($alert_types['members']['request_group']); |
|
2143 | + } |
|
2042 | 2144 | |
2043 | 2145 | foreach ($alert_types as $group => $items) |
2044 | 2146 | { |
2045 | 2147 | foreach ($items as $alert_key => $alert_value) |
2046 | 2148 | { |
2047 | - if (!isset($alert_value['permission'])) |
|
2048 | - continue; |
|
2149 | + if (!isset($alert_value['permission'])) { |
|
2150 | + continue; |
|
2151 | + } |
|
2049 | 2152 | if (!isset($perms_cache[$alert_value['permission']['name']])) |
2050 | 2153 | { |
2051 | 2154 | $in_board = !empty($alert_value['permission']['is_board']) ? 0 : null; |
@@ -2053,12 +2156,14 @@ discard block |
||
2053 | 2156 | $perms_cache[$alert_value['permission']['name']] = in_array($memID, $members); |
2054 | 2157 | } |
2055 | 2158 | |
2056 | - if (!$perms_cache[$alert_value['permission']['name']]) |
|
2057 | - unset ($alert_types[$group][$alert_key]); |
|
2159 | + if (!$perms_cache[$alert_value['permission']['name']]) { |
|
2160 | + unset ($alert_types[$group][$alert_key]); |
|
2161 | + } |
|
2058 | 2162 | } |
2059 | 2163 | |
2060 | - if (empty($alert_types[$group])) |
|
2061 | - unset ($alert_types[$group]); |
|
2164 | + if (empty($alert_types[$group])) { |
|
2165 | + unset ($alert_types[$group]); |
|
2166 | + } |
|
2062 | 2167 | } |
2063 | 2168 | } |
2064 | 2169 | |
@@ -2090,9 +2195,9 @@ discard block |
||
2090 | 2195 | $update_prefs[$this_option[1]] = !empty($_POST['opt_' . $this_option[1]]) ? 1 : 0; |
2091 | 2196 | break; |
2092 | 2197 | case 'select': |
2093 | - if (isset($_POST['opt_' . $this_option[1]], $this_option['opts'][$_POST['opt_' . $this_option[1]]])) |
|
2094 | - $update_prefs[$this_option[1]] = $_POST['opt_' . $this_option[1]]; |
|
2095 | - else |
|
2198 | + if (isset($_POST['opt_' . $this_option[1]], $this_option['opts'][$_POST['opt_' . $this_option[1]]])) { |
|
2199 | + $update_prefs[$this_option[1]] = $_POST['opt_' . $this_option[1]]; |
|
2200 | + } else |
|
2096 | 2201 | { |
2097 | 2202 | // We didn't have a sane value. Let's grab the first item from the possibles. |
2098 | 2203 | $keys = array_keys($this_option['opts']); |
@@ -2112,23 +2217,28 @@ discard block |
||
2112 | 2217 | $this_value = 0; |
2113 | 2218 | foreach ($context['alert_bits'] as $type => $bitvalue) |
2114 | 2219 | { |
2115 | - if ($this_options[$type] == 'yes' && !empty($_POST[$type . '_' . $item_key]) || $this_options[$type] == 'always') |
|
2116 | - $this_value |= $bitvalue; |
|
2220 | + if ($this_options[$type] == 'yes' && !empty($_POST[$type . '_' . $item_key]) || $this_options[$type] == 'always') { |
|
2221 | + $this_value |= $bitvalue; |
|
2222 | + } |
|
2223 | + } |
|
2224 | + if (!isset($context['alert_prefs'][$item_key]) || $context['alert_prefs'][$item_key] != $this_value) { |
|
2225 | + $update_prefs[$item_key] = $this_value; |
|
2117 | 2226 | } |
2118 | - if (!isset($context['alert_prefs'][$item_key]) || $context['alert_prefs'][$item_key] != $this_value) |
|
2119 | - $update_prefs[$item_key] = $this_value; |
|
2120 | 2227 | } |
2121 | 2228 | } |
2122 | 2229 | |
2123 | - if (!empty($_POST['opt_alert_timeout'])) |
|
2124 | - $update_prefs['alert_timeout'] = $context['member']['alert_timeout'] = (int) $_POST['opt_alert_timeout']; |
|
2230 | + if (!empty($_POST['opt_alert_timeout'])) { |
|
2231 | + $update_prefs['alert_timeout'] = $context['member']['alert_timeout'] = (int) $_POST['opt_alert_timeout']; |
|
2232 | + } |
|
2125 | 2233 | |
2126 | - if (!empty($_POST['notify_announcements'])) |
|
2127 | - $update_prefs['announcements'] = $context['member']['notify_announcements'] = (int) $_POST['notify_announcements']; |
|
2234 | + if (!empty($_POST['notify_announcements'])) { |
|
2235 | + $update_prefs['announcements'] = $context['member']['notify_announcements'] = (int) $_POST['notify_announcements']; |
|
2236 | + } |
|
2128 | 2237 | |
2129 | 2238 | setNotifyPrefs((int) $memID, $update_prefs); |
2130 | - foreach ($update_prefs as $pref => $value) |
|
2131 | - $context['alert_prefs'][$pref] = $value; |
|
2239 | + foreach ($update_prefs as $pref => $value) { |
|
2240 | + $context['alert_prefs'][$pref] = $value; |
|
2241 | + } |
|
2132 | 2242 | |
2133 | 2243 | makeNotificationChanges($memID); |
2134 | 2244 | |
@@ -2158,8 +2268,9 @@ discard block |
||
2158 | 2268 | |
2159 | 2269 | // Now we're all set up. |
2160 | 2270 | is_not_guest(); |
2161 | - if (!$context['user']['is_owner']) |
|
2162 | - fatal_error('no_access'); |
|
2271 | + if (!$context['user']['is_owner']) { |
|
2272 | + fatal_error('no_access'); |
|
2273 | + } |
|
2163 | 2274 | |
2164 | 2275 | checkSession('get'); |
2165 | 2276 | |
@@ -2191,8 +2302,9 @@ discard block |
||
2191 | 2302 | { |
2192 | 2303 | global $smcFunc; |
2193 | 2304 | |
2194 | - if (empty($toMark) || empty($memID)) |
|
2195 | - return false; |
|
2305 | + if (empty($toMark) || empty($memID)) { |
|
2306 | + return false; |
|
2307 | + } |
|
2196 | 2308 | |
2197 | 2309 | $toMark = (array) $toMark; |
2198 | 2310 | |
@@ -2226,8 +2338,9 @@ discard block |
||
2226 | 2338 | { |
2227 | 2339 | global $smcFunc; |
2228 | 2340 | |
2229 | - if (empty($toDelete)) |
|
2230 | - return false; |
|
2341 | + if (empty($toDelete)) { |
|
2342 | + return false; |
|
2343 | + } |
|
2231 | 2344 | |
2232 | 2345 | $toDelete = (array) $toDelete; |
2233 | 2346 | |
@@ -2262,8 +2375,9 @@ discard block |
||
2262 | 2375 | { |
2263 | 2376 | global $smcFunc; |
2264 | 2377 | |
2265 | - if (empty($memID)) |
|
2266 | - return false; |
|
2378 | + if (empty($memID)) { |
|
2379 | + return false; |
|
2380 | + } |
|
2267 | 2381 | |
2268 | 2382 | $request = $smcFunc['db_query']('', ' |
2269 | 2383 | SELECT id_alert |
@@ -2340,8 +2454,9 @@ discard block |
||
2340 | 2454 | { |
2341 | 2455 | $link = $topic['link']; |
2342 | 2456 | |
2343 | - if ($topic['new']) |
|
2344 | - $link .= ' <a href="' . $topic['new_href'] . '" class="new_posts">' . $txt['new'] . '</a>'; |
|
2457 | + if ($topic['new']) { |
|
2458 | + $link .= ' <a href="' . $topic['new_href'] . '" class="new_posts">' . $txt['new'] . '</a>'; |
|
2459 | + } |
|
2345 | 2460 | |
2346 | 2461 | $link .= '<br><span class="smalltext"><em>' . $txt['in'] . ' ' . $topic['board_link'] . '</em></span>'; |
2347 | 2462 | |
@@ -2492,8 +2607,9 @@ discard block |
||
2492 | 2607 | { |
2493 | 2608 | $link = $board['link']; |
2494 | 2609 | |
2495 | - if ($board['new']) |
|
2496 | - $link .= ' <a href="' . $board['href'] . '" class="new_posts">' . $txt['new'] . '</a>'; |
|
2610 | + if ($board['new']) { |
|
2611 | + $link .= ' <a href="' . $board['href'] . '" class="new_posts">' . $txt['new'] . '</a>'; |
|
2612 | + } |
|
2497 | 2613 | |
2498 | 2614 | return $link; |
2499 | 2615 | }, |
@@ -2693,8 +2809,8 @@ discard block |
||
2693 | 2809 | ) |
2694 | 2810 | ); |
2695 | 2811 | $notification_boards = array(); |
2696 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2697 | - $notification_boards[] = array( |
|
2812 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2813 | + $notification_boards[] = array( |
|
2698 | 2814 | 'id' => $row['id_board'], |
2699 | 2815 | 'name' => $row['name'], |
2700 | 2816 | 'href' => $scripturl . '?board=' . $row['id_board'] . '.0', |
@@ -2702,6 +2818,7 @@ discard block |
||
2702 | 2818 | 'new' => $row['board_read'] < $row['id_msg_updated'], |
2703 | 2819 | 'notify_pref' => isset($prefs['board_notify_' . $row['id_board']]) ? $prefs['board_notify_' . $row['id_board']] : (!empty($prefs['board_notify']) ? $prefs['board_notify'] : 0), |
2704 | 2820 | ); |
2821 | + } |
|
2705 | 2822 | $smcFunc['db_free_result']($request); |
2706 | 2823 | |
2707 | 2824 | return $notification_boards; |
@@ -2716,17 +2833,18 @@ discard block |
||
2716 | 2833 | { |
2717 | 2834 | global $context, $options, $cur_profile, $smcFunc; |
2718 | 2835 | |
2719 | - if (isset($_POST['default_options'])) |
|
2720 | - $_POST['options'] = isset($_POST['options']) ? $_POST['options'] + $_POST['default_options'] : $_POST['default_options']; |
|
2836 | + if (isset($_POST['default_options'])) { |
|
2837 | + $_POST['options'] = isset($_POST['options']) ? $_POST['options'] + $_POST['default_options'] : $_POST['default_options']; |
|
2838 | + } |
|
2721 | 2839 | |
2722 | 2840 | if ($context['user']['is_owner']) |
2723 | 2841 | { |
2724 | 2842 | $context['member']['options'] = $options; |
2725 | - if (isset($_POST['options']) && is_array($_POST['options'])) |
|
2726 | - foreach ($_POST['options'] as $k => $v) |
|
2843 | + if (isset($_POST['options']) && is_array($_POST['options'])) { |
|
2844 | + foreach ($_POST['options'] as $k => $v) |
|
2727 | 2845 | $context['member']['options'][$k] = $v; |
2728 | - } |
|
2729 | - else |
|
2846 | + } |
|
2847 | + } else |
|
2730 | 2848 | { |
2731 | 2849 | $request = $smcFunc['db_query']('', ' |
2732 | 2850 | SELECT id_member, variable, value |
@@ -2747,8 +2865,9 @@ discard block |
||
2747 | 2865 | continue; |
2748 | 2866 | } |
2749 | 2867 | |
2750 | - if (isset($_POST['options'][$row['variable']])) |
|
2751 | - $row['value'] = $_POST['options'][$row['variable']]; |
|
2868 | + if (isset($_POST['options'][$row['variable']])) { |
|
2869 | + $row['value'] = $_POST['options'][$row['variable']]; |
|
2870 | + } |
|
2752 | 2871 | $context['member']['options'][$row['variable']] = $row['value']; |
2753 | 2872 | } |
2754 | 2873 | $smcFunc['db_free_result']($request); |
@@ -2756,8 +2875,9 @@ discard block |
||
2756 | 2875 | // Load up the default theme options for any missing. |
2757 | 2876 | foreach ($temp as $k => $v) |
2758 | 2877 | { |
2759 | - if (!isset($context['member']['options'][$k])) |
|
2760 | - $context['member']['options'][$k] = $v; |
|
2878 | + if (!isset($context['member']['options'][$k])) { |
|
2879 | + $context['member']['options'][$k] = $v; |
|
2880 | + } |
|
2761 | 2881 | } |
2762 | 2882 | } |
2763 | 2883 | } |
@@ -2772,8 +2892,9 @@ discard block |
||
2772 | 2892 | global $context, $modSettings, $smcFunc, $cur_profile, $sourcedir; |
2773 | 2893 | |
2774 | 2894 | // Have the admins enabled this option? |
2775 | - if (empty($modSettings['allow_ignore_boards'])) |
|
2776 | - fatal_lang_error('ignoreboards_disallowed', 'user'); |
|
2895 | + if (empty($modSettings['allow_ignore_boards'])) { |
|
2896 | + fatal_lang_error('ignoreboards_disallowed', 'user'); |
|
2897 | + } |
|
2777 | 2898 | |
2778 | 2899 | // Find all the boards this user is allowed to see. |
2779 | 2900 | $request = $smcFunc['db_query']('order_by_board_order', ' |
@@ -2793,12 +2914,13 @@ discard block |
||
2793 | 2914 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2794 | 2915 | { |
2795 | 2916 | // This category hasn't been set up yet.. |
2796 | - if (!isset($context['categories'][$row['id_cat']])) |
|
2797 | - $context['categories'][$row['id_cat']] = array( |
|
2917 | + if (!isset($context['categories'][$row['id_cat']])) { |
|
2918 | + $context['categories'][$row['id_cat']] = array( |
|
2798 | 2919 | 'id' => $row['id_cat'], |
2799 | 2920 | 'name' => $row['cat_name'], |
2800 | 2921 | 'boards' => array() |
2801 | 2922 | ); |
2923 | + } |
|
2802 | 2924 | |
2803 | 2925 | // Set this board up, and let the template know when it's a child. (indent them..) |
2804 | 2926 | $context['categories'][$row['id_cat']]['boards'][$row['id_board']] = array( |
@@ -2828,18 +2950,20 @@ discard block |
||
2828 | 2950 | } |
2829 | 2951 | |
2830 | 2952 | $max_boards = ceil(count($temp_boards) / 2); |
2831 | - if ($max_boards == 1) |
|
2832 | - $max_boards = 2; |
|
2953 | + if ($max_boards == 1) { |
|
2954 | + $max_boards = 2; |
|
2955 | + } |
|
2833 | 2956 | |
2834 | 2957 | // Now, alternate them so they can be shown left and right ;). |
2835 | 2958 | $context['board_columns'] = array(); |
2836 | 2959 | for ($i = 0; $i < $max_boards; $i++) |
2837 | 2960 | { |
2838 | 2961 | $context['board_columns'][] = $temp_boards[$i]; |
2839 | - if (isset($temp_boards[$i + $max_boards])) |
|
2840 | - $context['board_columns'][] = $temp_boards[$i + $max_boards]; |
|
2841 | - else |
|
2842 | - $context['board_columns'][] = array(); |
|
2962 | + if (isset($temp_boards[$i + $max_boards])) { |
|
2963 | + $context['board_columns'][] = $temp_boards[$i + $max_boards]; |
|
2964 | + } else { |
|
2965 | + $context['board_columns'][] = array(); |
|
2966 | + } |
|
2843 | 2967 | } |
2844 | 2968 | |
2845 | 2969 | loadThemeOptions($memID); |
@@ -2908,8 +3032,9 @@ discard block |
||
2908 | 3032 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
2909 | 3033 | { |
2910 | 3034 | // We should skip the administrator group if they don't have the admin_forum permission! |
2911 | - if ($row['id_group'] == 1 && !allowedTo('admin_forum')) |
|
2912 | - continue; |
|
3035 | + if ($row['id_group'] == 1 && !allowedTo('admin_forum')) { |
|
3036 | + continue; |
|
3037 | + } |
|
2913 | 3038 | |
2914 | 3039 | $context['member_groups'][$row['id_group']] = array( |
2915 | 3040 | 'id' => $row['id_group'], |
@@ -2955,16 +3080,17 @@ discard block |
||
2955 | 3080 | $context['max_signature_length'] = $context['signature_limits']['max_length']; |
2956 | 3081 | // Warning message for signature image limits? |
2957 | 3082 | $context['signature_warning'] = ''; |
2958 | - if ($context['signature_limits']['max_image_width'] && $context['signature_limits']['max_image_height']) |
|
2959 | - $context['signature_warning'] = sprintf($txt['profile_error_signature_max_image_size'], $context['signature_limits']['max_image_width'], $context['signature_limits']['max_image_height']); |
|
2960 | - elseif ($context['signature_limits']['max_image_width'] || $context['signature_limits']['max_image_height']) |
|
2961 | - $context['signature_warning'] = sprintf($txt['profile_error_signature_max_image_' . ($context['signature_limits']['max_image_width'] ? 'width' : 'height')], $context['signature_limits'][$context['signature_limits']['max_image_width'] ? 'max_image_width' : 'max_image_height']); |
|
3083 | + if ($context['signature_limits']['max_image_width'] && $context['signature_limits']['max_image_height']) { |
|
3084 | + $context['signature_warning'] = sprintf($txt['profile_error_signature_max_image_size'], $context['signature_limits']['max_image_width'], $context['signature_limits']['max_image_height']); |
|
3085 | + } elseif ($context['signature_limits']['max_image_width'] || $context['signature_limits']['max_image_height']) { |
|
3086 | + $context['signature_warning'] = sprintf($txt['profile_error_signature_max_image_' . ($context['signature_limits']['max_image_width'] ? 'width' : 'height')], $context['signature_limits'][$context['signature_limits']['max_image_width'] ? 'max_image_width' : 'max_image_height']); |
|
3087 | + } |
|
2962 | 3088 | |
2963 | 3089 | $context['show_spellchecking'] = !empty($modSettings['enableSpellChecking']) && (function_exists('pspell_new') || (function_exists('enchant_broker_init') && ($txt['lang_charset'] == 'UTF-8' || function_exists('iconv')))); |
2964 | 3090 | |
2965 | - if (empty($context['do_preview'])) |
|
2966 | - $context['member']['signature'] = empty($cur_profile['signature']) ? '' : str_replace(array('<br>', '<', '>', '"', '\''), array("\n", '<', '>', '"', '''), $cur_profile['signature']); |
|
2967 | - else |
|
3091 | + if (empty($context['do_preview'])) { |
|
3092 | + $context['member']['signature'] = empty($cur_profile['signature']) ? '' : str_replace(array('<br>', '<', '>', '"', '\''), array("\n", '<', '>', '"', '''), $cur_profile['signature']); |
|
3093 | + } else |
|
2968 | 3094 | { |
2969 | 3095 | $signature = !empty($_POST['signature']) ? $_POST['signature'] : ''; |
2970 | 3096 | $validation = profileValidateSignature($signature); |
@@ -2974,8 +3100,9 @@ discard block |
||
2974 | 3100 | $context['post_errors'] = array(); |
2975 | 3101 | } |
2976 | 3102 | $context['post_errors'][] = 'signature_not_yet_saved'; |
2977 | - if ($validation !== true && $validation !== false) |
|
2978 | - $context['post_errors'][] = $validation; |
|
3103 | + if ($validation !== true && $validation !== false) { |
|
3104 | + $context['post_errors'][] = $validation; |
|
3105 | + } |
|
2979 | 3106 | |
2980 | 3107 | censorText($context['member']['signature']); |
2981 | 3108 | $context['member']['current_signature'] = $context['member']['signature']; |
@@ -2985,8 +3112,9 @@ discard block |
||
2985 | 3112 | } |
2986 | 3113 | |
2987 | 3114 | // Load the spell checker? |
2988 | - if ($context['show_spellchecking']) |
|
2989 | - loadJavaScriptFile('spellcheck.js', array('defer' => false, 'minimize' => true), 'smf_spellcheck'); |
|
3115 | + if ($context['show_spellchecking']) { |
|
3116 | + loadJavaScriptFile('spellcheck.js', array('defer' => false, 'minimize' => true), 'smf_spellcheck'); |
|
3117 | + } |
|
2990 | 3118 | |
2991 | 3119 | return true; |
2992 | 3120 | } |
@@ -3020,8 +3148,7 @@ discard block |
||
3020 | 3148 | 'external' => $cur_profile['avatar'] == 'gravatar://' || empty($modSettings['gravatarAllowExtraEmail']) || !empty($modSettings['gravatarOverride']) ? $cur_profile['email_address'] : substr($cur_profile['avatar'], 11) |
3021 | 3149 | ); |
3022 | 3150 | $context['member']['avatar']['href'] = get_gravatar_url($context['member']['avatar']['external']); |
3023 | - } |
|
3024 | - elseif ($cur_profile['avatar'] == '' && $cur_profile['id_attach'] > 0 && $context['member']['avatar']['allow_upload']) |
|
3151 | + } elseif ($cur_profile['avatar'] == '' && $cur_profile['id_attach'] > 0 && $context['member']['avatar']['allow_upload']) |
|
3025 | 3152 | { |
3026 | 3153 | $context['member']['avatar'] += array( |
3027 | 3154 | 'choice' => 'upload', |
@@ -3031,33 +3158,34 @@ discard block |
||
3031 | 3158 | $context['member']['avatar']['href'] = empty($cur_profile['attachment_type']) ? $scripturl . '?action=dlattach;attach=' . $cur_profile['id_attach'] . ';type=avatar' : $modSettings['custom_avatar_url'] . '/' . $cur_profile['filename']; |
3032 | 3159 | } |
3033 | 3160 | // Use "avatar_original" here so we show what the user entered even if the image proxy is enabled |
3034 | - elseif ((stristr($cur_profile['avatar'], 'http://') || stristr($cur_profile['avatar'], 'https://')) && $context['member']['avatar']['allow_external']) |
|
3035 | - $context['member']['avatar'] += array( |
|
3161 | + elseif ((stristr($cur_profile['avatar'], 'http://') || stristr($cur_profile['avatar'], 'https://')) && $context['member']['avatar']['allow_external']) { |
|
3162 | + $context['member']['avatar'] += array( |
|
3036 | 3163 | 'choice' => 'external', |
3037 | 3164 | 'server_pic' => 'blank.png', |
3038 | 3165 | 'external' => $cur_profile['avatar_original'] |
3039 | 3166 | ); |
3040 | - elseif ($cur_profile['avatar'] != '' && file_exists($modSettings['avatar_directory'] . '/' . $cur_profile['avatar']) && $context['member']['avatar']['allow_server_stored']) |
|
3041 | - $context['member']['avatar'] += array( |
|
3167 | + } elseif ($cur_profile['avatar'] != '' && file_exists($modSettings['avatar_directory'] . '/' . $cur_profile['avatar']) && $context['member']['avatar']['allow_server_stored']) { |
|
3168 | + $context['member']['avatar'] += array( |
|
3042 | 3169 | 'choice' => 'server_stored', |
3043 | 3170 | 'server_pic' => $cur_profile['avatar'] == '' ? 'blank.png' : $cur_profile['avatar'], |
3044 | 3171 | 'external' => 'http://' |
3045 | 3172 | ); |
3046 | - else |
|
3047 | - $context['member']['avatar'] += array( |
|
3173 | + } else { |
|
3174 | + $context['member']['avatar'] += array( |
|
3048 | 3175 | 'choice' => 'none', |
3049 | 3176 | 'server_pic' => 'blank.png', |
3050 | 3177 | 'external' => 'http://' |
3051 | 3178 | ); |
3179 | + } |
|
3052 | 3180 | |
3053 | 3181 | // Get a list of all the avatars. |
3054 | 3182 | if ($context['member']['avatar']['allow_server_stored']) |
3055 | 3183 | { |
3056 | 3184 | $context['avatar_list'] = array(); |
3057 | 3185 | $context['avatars'] = is_dir($modSettings['avatar_directory']) ? getAvatars('', 0) : array(); |
3186 | + } else { |
|
3187 | + $context['avatars'] = array(); |
|
3058 | 3188 | } |
3059 | - else |
|
3060 | - $context['avatars'] = array(); |
|
3061 | 3189 | |
3062 | 3190 | // Second level selected avatar... |
3063 | 3191 | $context['avatar_selected'] = substr(strrchr($context['member']['avatar']['server_pic'], '/'), 1); |
@@ -3086,19 +3214,22 @@ discard block |
||
3086 | 3214 | ) |
3087 | 3215 | ); |
3088 | 3216 | $protected_groups = array(1); |
3089 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
3090 | - $protected_groups[] = $row['id_group']; |
|
3217 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
3218 | + $protected_groups[] = $row['id_group']; |
|
3219 | + } |
|
3091 | 3220 | $smcFunc['db_free_result']($request); |
3092 | 3221 | |
3093 | 3222 | $protected_groups = array_unique($protected_groups); |
3094 | 3223 | } |
3095 | 3224 | |
3096 | 3225 | // The account page allows the change of your id_group - but not to a protected group! |
3097 | - if (empty($protected_groups) || count(array_intersect(array((int) $value, $old_profile['id_group']), $protected_groups)) == 0) |
|
3098 | - $value = (int) $value; |
|
3226 | + if (empty($protected_groups) || count(array_intersect(array((int) $value, $old_profile['id_group']), $protected_groups)) == 0) { |
|
3227 | + $value = (int) $value; |
|
3228 | + } |
|
3099 | 3229 | // ... otherwise it's the old group sir. |
3100 | - else |
|
3101 | - $value = $old_profile['id_group']; |
|
3230 | + else { |
|
3231 | + $value = $old_profile['id_group']; |
|
3232 | + } |
|
3102 | 3233 | |
3103 | 3234 | // Find the additional membergroups (if any) |
3104 | 3235 | if (isset($_POST['additional_groups']) && is_array($_POST['additional_groups'])) |
@@ -3107,16 +3238,18 @@ discard block |
||
3107 | 3238 | foreach ($_POST['additional_groups'] as $group_id) |
3108 | 3239 | { |
3109 | 3240 | $group_id = (int) $group_id; |
3110 | - if (!empty($group_id) && (empty($protected_groups) || !in_array($group_id, $protected_groups))) |
|
3111 | - $additional_groups[] = $group_id; |
|
3241 | + if (!empty($group_id) && (empty($protected_groups) || !in_array($group_id, $protected_groups))) { |
|
3242 | + $additional_groups[] = $group_id; |
|
3243 | + } |
|
3112 | 3244 | } |
3113 | 3245 | |
3114 | 3246 | // Put the protected groups back in there if you don't have permission to take them away. |
3115 | 3247 | $old_additional_groups = explode(',', $old_profile['additional_groups']); |
3116 | 3248 | foreach ($old_additional_groups as $group_id) |
3117 | 3249 | { |
3118 | - if (!empty($protected_groups) && in_array($group_id, $protected_groups)) |
|
3119 | - $additional_groups[] = $group_id; |
|
3250 | + if (!empty($protected_groups) && in_array($group_id, $protected_groups)) { |
|
3251 | + $additional_groups[] = $group_id; |
|
3252 | + } |
|
3120 | 3253 | } |
3121 | 3254 | |
3122 | 3255 | if (implode(',', $additional_groups) !== $old_profile['additional_groups']) |
@@ -3148,18 +3281,20 @@ discard block |
||
3148 | 3281 | list ($another) = $smcFunc['db_fetch_row']($request); |
3149 | 3282 | $smcFunc['db_free_result']($request); |
3150 | 3283 | |
3151 | - if (empty($another)) |
|
3152 | - fatal_lang_error('at_least_one_admin', 'critical'); |
|
3284 | + if (empty($another)) { |
|
3285 | + fatal_lang_error('at_least_one_admin', 'critical'); |
|
3286 | + } |
|
3153 | 3287 | } |
3154 | 3288 | } |
3155 | 3289 | |
3156 | 3290 | // If we are changing group status, update permission cache as necessary. |
3157 | 3291 | if ($value != $old_profile['id_group'] || isset($profile_vars['additional_groups'])) |
3158 | 3292 | { |
3159 | - if ($context['user']['is_owner']) |
|
3160 | - $_SESSION['mc']['time'] = 0; |
|
3161 | - else |
|
3162 | - updateSettings(array('settings_updated' => time())); |
|
3293 | + if ($context['user']['is_owner']) { |
|
3294 | + $_SESSION['mc']['time'] = 0; |
|
3295 | + } else { |
|
3296 | + updateSettings(array('settings_updated' => time())); |
|
3297 | + } |
|
3163 | 3298 | } |
3164 | 3299 | |
3165 | 3300 | // Announce to any hooks that we have changed groups, but don't allow them to change it. |
@@ -3180,8 +3315,9 @@ discard block |
||
3180 | 3315 | global $modSettings, $sourcedir, $smcFunc, $profile_vars, $cur_profile, $context; |
3181 | 3316 | |
3182 | 3317 | $memID = $context['id_member']; |
3183 | - if (empty($memID) && !empty($context['password_auth_failed'])) |
|
3184 | - return false; |
|
3318 | + if (empty($memID) && !empty($context['password_auth_failed'])) { |
|
3319 | + return false; |
|
3320 | + } |
|
3185 | 3321 | |
3186 | 3322 | require_once($sourcedir . '/ManageAttachments.php'); |
3187 | 3323 | |
@@ -3192,8 +3328,9 @@ discard block |
||
3192 | 3328 | $downloadedExternalAvatar = false; |
3193 | 3329 | if ($value == 'external' && allowedTo('profile_remote_avatar') && (stripos($_POST['userpicpersonal'], 'http://') === 0 || stripos($_POST['userpicpersonal'], 'https://') === 0) && strlen($_POST['userpicpersonal']) > 7 && !empty($modSettings['avatar_download_external'])) |
3194 | 3330 | { |
3195 | - if (!is_writable($uploadDir)) |
|
3196 | - fatal_lang_error('attachments_no_write', 'critical'); |
|
3331 | + if (!is_writable($uploadDir)) { |
|
3332 | + fatal_lang_error('attachments_no_write', 'critical'); |
|
3333 | + } |
|
3197 | 3334 | |
3198 | 3335 | $url = parse_url($_POST['userpicpersonal']); |
3199 | 3336 | $contents = fetch_web_data($url['scheme'] . '://' . $url['host'] . (empty($url['port']) ? '' : ':' . $url['port']) . str_replace(' ', '%20', trim($url['path']))); |
@@ -3235,19 +3372,18 @@ discard block |
||
3235 | 3372 | |
3236 | 3373 | // Get rid of their old avatar. (if uploaded.) |
3237 | 3374 | removeAttachments(array('id_member' => $memID)); |
3238 | - } |
|
3239 | - elseif ($value == 'gravatar' && !empty($modSettings['gravatarEnabled'])) |
|
3375 | + } elseif ($value == 'gravatar' && !empty($modSettings['gravatarEnabled'])) |
|
3240 | 3376 | { |
3241 | 3377 | // One wasn't specified, or it's not allowed to use extra email addresses, or it's not a valid one, reset to default Gravatar. |
3242 | - if (empty($_POST['gravatarEmail']) || empty($modSettings['gravatarAllowExtraEmail']) || !filter_var($_POST['gravatarEmail'], FILTER_VALIDATE_EMAIL)) |
|
3243 | - $profile_vars['avatar'] = 'gravatar://'; |
|
3244 | - else |
|
3245 | - $profile_vars['avatar'] = 'gravatar://' . ($_POST['gravatarEmail'] != $cur_profile['email_address'] ? $_POST['gravatarEmail'] : ''); |
|
3378 | + if (empty($_POST['gravatarEmail']) || empty($modSettings['gravatarAllowExtraEmail']) || !filter_var($_POST['gravatarEmail'], FILTER_VALIDATE_EMAIL)) { |
|
3379 | + $profile_vars['avatar'] = 'gravatar://'; |
|
3380 | + } else { |
|
3381 | + $profile_vars['avatar'] = 'gravatar://' . ($_POST['gravatarEmail'] != $cur_profile['email_address'] ? $_POST['gravatarEmail'] : ''); |
|
3382 | + } |
|
3246 | 3383 | |
3247 | 3384 | // Get rid of their old avatar. (if uploaded.) |
3248 | 3385 | removeAttachments(array('id_member' => $memID)); |
3249 | - } |
|
3250 | - elseif ($value == 'external' && allowedTo('profile_remote_avatar') && (stripos($_POST['userpicpersonal'], 'http://') === 0 || stripos($_POST['userpicpersonal'], 'https://') === 0) && empty($modSettings['avatar_download_external'])) |
|
3386 | + } elseif ($value == 'external' && allowedTo('profile_remote_avatar') && (stripos($_POST['userpicpersonal'], 'http://') === 0 || stripos($_POST['userpicpersonal'], 'https://') === 0) && empty($modSettings['avatar_download_external'])) |
|
3251 | 3387 | { |
3252 | 3388 | // We need these clean... |
3253 | 3389 | $cur_profile['id_attach'] = 0; |
@@ -3259,11 +3395,13 @@ discard block |
||
3259 | 3395 | |
3260 | 3396 | $profile_vars['avatar'] = str_replace(' ', '%20', preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $_POST['userpicpersonal'])); |
3261 | 3397 | |
3262 | - if ($profile_vars['avatar'] == 'http://' || $profile_vars['avatar'] == 'http:///') |
|
3263 | - $profile_vars['avatar'] = ''; |
|
3398 | + if ($profile_vars['avatar'] == 'http://' || $profile_vars['avatar'] == 'http:///') { |
|
3399 | + $profile_vars['avatar'] = ''; |
|
3400 | + } |
|
3264 | 3401 | // Trying to make us do something we'll regret? |
3265 | - elseif (substr($profile_vars['avatar'], 0, 7) != 'http://' && substr($profile_vars['avatar'], 0, 8) != 'https://') |
|
3266 | - return 'bad_avatar_invalid_url'; |
|
3402 | + elseif (substr($profile_vars['avatar'], 0, 7) != 'http://' && substr($profile_vars['avatar'], 0, 8) != 'https://') { |
|
3403 | + return 'bad_avatar_invalid_url'; |
|
3404 | + } |
|
3267 | 3405 | // Should we check dimensions? |
3268 | 3406 | elseif (!empty($modSettings['avatar_max_height_external']) || !empty($modSettings['avatar_max_width_external'])) |
3269 | 3407 | { |
@@ -3273,9 +3411,9 @@ discard block |
||
3273 | 3411 | if (is_array($sizes) && (($sizes[0] > $modSettings['avatar_max_width_external'] && !empty($modSettings['avatar_max_width_external'])) || ($sizes[1] > $modSettings['avatar_max_height_external'] && !empty($modSettings['avatar_max_height_external'])))) |
3274 | 3412 | { |
3275 | 3413 | // Houston, we have a problem. The avatar is too large!! |
3276 | - if ($modSettings['avatar_action_too_large'] == 'option_refuse') |
|
3277 | - return 'bad_avatar_too_large'; |
|
3278 | - elseif ($modSettings['avatar_action_too_large'] == 'option_download_and_resize') |
|
3414 | + if ($modSettings['avatar_action_too_large'] == 'option_refuse') { |
|
3415 | + return 'bad_avatar_too_large'; |
|
3416 | + } elseif ($modSettings['avatar_action_too_large'] == 'option_download_and_resize') |
|
3279 | 3417 | { |
3280 | 3418 | // @todo remove this if appropriate |
3281 | 3419 | require_once($sourcedir . '/Subs-Graphics.php'); |
@@ -3285,26 +3423,27 @@ discard block |
||
3285 | 3423 | $cur_profile['id_attach'] = $modSettings['new_avatar_data']['id']; |
3286 | 3424 | $cur_profile['filename'] = $modSettings['new_avatar_data']['filename']; |
3287 | 3425 | $cur_profile['attachment_type'] = $modSettings['new_avatar_data']['type']; |
3426 | + } else { |
|
3427 | + return 'bad_avatar'; |
|
3288 | 3428 | } |
3289 | - else |
|
3290 | - return 'bad_avatar'; |
|
3291 | 3429 | } |
3292 | 3430 | } |
3293 | 3431 | } |
3294 | - } |
|
3295 | - elseif (($value == 'upload' && allowedTo('profile_upload_avatar')) || $downloadedExternalAvatar) |
|
3432 | + } elseif (($value == 'upload' && allowedTo('profile_upload_avatar')) || $downloadedExternalAvatar) |
|
3296 | 3433 | { |
3297 | 3434 | if ((isset($_FILES['attachment']['name']) && $_FILES['attachment']['name'] != '') || $downloadedExternalAvatar) |
3298 | 3435 | { |
3299 | 3436 | // Get the dimensions of the image. |
3300 | 3437 | if (!$downloadedExternalAvatar) |
3301 | 3438 | { |
3302 | - if (!is_writable($uploadDir)) |
|
3303 | - fatal_lang_error('attachments_no_write', 'critical'); |
|
3439 | + if (!is_writable($uploadDir)) { |
|
3440 | + fatal_lang_error('attachments_no_write', 'critical'); |
|
3441 | + } |
|
3304 | 3442 | |
3305 | 3443 | $new_filename = $uploadDir . '/' . getAttachmentFilename('avatar_tmp_' . $memID, false, null, true); |
3306 | - if (!move_uploaded_file($_FILES['attachment']['tmp_name'], $new_filename)) |
|
3307 | - fatal_lang_error('attach_timeout', 'critical'); |
|
3444 | + if (!move_uploaded_file($_FILES['attachment']['tmp_name'], $new_filename)) { |
|
3445 | + fatal_lang_error('attach_timeout', 'critical'); |
|
3446 | + } |
|
3308 | 3447 | |
3309 | 3448 | $_FILES['attachment']['tmp_name'] = $new_filename; |
3310 | 3449 | } |
@@ -3417,17 +3556,19 @@ discard block |
||
3417 | 3556 | $profile_vars['avatar'] = ''; |
3418 | 3557 | |
3419 | 3558 | // Delete any temporary file. |
3420 | - if (file_exists($_FILES['attachment']['tmp_name'])) |
|
3421 | - @unlink($_FILES['attachment']['tmp_name']); |
|
3559 | + if (file_exists($_FILES['attachment']['tmp_name'])) { |
|
3560 | + @unlink($_FILES['attachment']['tmp_name']); |
|
3561 | + } |
|
3422 | 3562 | } |
3423 | 3563 | // Selected the upload avatar option and had one already uploaded before or didn't upload one. |
3424 | - else |
|
3564 | + else { |
|
3565 | + $profile_vars['avatar'] = ''; |
|
3566 | + } |
|
3567 | + } elseif ($value == 'gravatar' && allowedTo('profile_gravatar_avatar')) { |
|
3568 | + $profile_vars['avatar'] = 'gravatar://www.gravatar.com/avatar/' . md5(strtolower(trim($cur_profile['email_address']))); |
|
3569 | + } else { |
|
3425 | 3570 | $profile_vars['avatar'] = ''; |
3426 | 3571 | } |
3427 | - elseif ($value == 'gravatar' && allowedTo('profile_gravatar_avatar')) |
|
3428 | - $profile_vars['avatar'] = 'gravatar://www.gravatar.com/avatar/' . md5(strtolower(trim($cur_profile['email_address']))); |
|
3429 | - else |
|
3430 | - $profile_vars['avatar'] = ''; |
|
3431 | 3572 | |
3432 | 3573 | // Setup the profile variables so it shows things right on display! |
3433 | 3574 | $cur_profile['avatar'] = $profile_vars['avatar']; |
@@ -3475,9 +3616,9 @@ discard block |
||
3475 | 3616 | $smiley_parsed = $unparsed_signature; |
3476 | 3617 | parsesmileys($smiley_parsed); |
3477 | 3618 | $smiley_count = substr_count(strtolower($smiley_parsed), '<img') - substr_count(strtolower($unparsed_signature), '<img'); |
3478 | - if (!empty($sig_limits[4]) && $sig_limits[4] == -1 && $smiley_count > 0) |
|
3479 | - return 'signature_allow_smileys'; |
|
3480 | - elseif (!empty($sig_limits[4]) && $sig_limits[4] > 0 && $smiley_count > $sig_limits[4]) |
|
3619 | + if (!empty($sig_limits[4]) && $sig_limits[4] == -1 && $smiley_count > 0) { |
|
3620 | + return 'signature_allow_smileys'; |
|
3621 | + } elseif (!empty($sig_limits[4]) && $sig_limits[4] > 0 && $smiley_count > $sig_limits[4]) |
|
3481 | 3622 | { |
3482 | 3623 | $txt['profile_error_signature_max_smileys'] = sprintf($txt['profile_error_signature_max_smileys'], $sig_limits[4]); |
3483 | 3624 | return 'signature_max_smileys'; |
@@ -3490,14 +3631,15 @@ discard block |
||
3490 | 3631 | { |
3491 | 3632 | $limit_broke = 0; |
3492 | 3633 | // Attempt to allow all sizes of abuse, so to speak. |
3493 | - if ($matches[2][$ind] == 'px' && $size > $sig_limits[7]) |
|
3494 | - $limit_broke = $sig_limits[7] . 'px'; |
|
3495 | - elseif ($matches[2][$ind] == 'pt' && $size > ($sig_limits[7] * 0.75)) |
|
3496 | - $limit_broke = ((int) $sig_limits[7] * 0.75) . 'pt'; |
|
3497 | - elseif ($matches[2][$ind] == 'em' && $size > ((float) $sig_limits[7] / 16)) |
|
3498 | - $limit_broke = ((float) $sig_limits[7] / 16) . 'em'; |
|
3499 | - elseif ($matches[2][$ind] != 'px' && $matches[2][$ind] != 'pt' && $matches[2][$ind] != 'em' && $sig_limits[7] < 18) |
|
3500 | - $limit_broke = 'large'; |
|
3634 | + if ($matches[2][$ind] == 'px' && $size > $sig_limits[7]) { |
|
3635 | + $limit_broke = $sig_limits[7] . 'px'; |
|
3636 | + } elseif ($matches[2][$ind] == 'pt' && $size > ($sig_limits[7] * 0.75)) { |
|
3637 | + $limit_broke = ((int) $sig_limits[7] * 0.75) . 'pt'; |
|
3638 | + } elseif ($matches[2][$ind] == 'em' && $size > ((float) $sig_limits[7] / 16)) { |
|
3639 | + $limit_broke = ((float) $sig_limits[7] / 16) . 'em'; |
|
3640 | + } elseif ($matches[2][$ind] != 'px' && $matches[2][$ind] != 'pt' && $matches[2][$ind] != 'em' && $sig_limits[7] < 18) { |
|
3641 | + $limit_broke = 'large'; |
|
3642 | + } |
|
3501 | 3643 | |
3502 | 3644 | if ($limit_broke) |
3503 | 3645 | { |
@@ -3539,24 +3681,26 @@ discard block |
||
3539 | 3681 | $width = -1; $height = -1; |
3540 | 3682 | |
3541 | 3683 | // Does it have predefined restraints? Width first. |
3542 | - if ($matches[6][$key]) |
|
3543 | - $matches[2][$key] = $matches[6][$key]; |
|
3684 | + if ($matches[6][$key]) { |
|
3685 | + $matches[2][$key] = $matches[6][$key]; |
|
3686 | + } |
|
3544 | 3687 | if ($matches[2][$key] && $sig_limits[5] && $matches[2][$key] > $sig_limits[5]) |
3545 | 3688 | { |
3546 | 3689 | $width = $sig_limits[5]; |
3547 | 3690 | $matches[4][$key] = $matches[4][$key] * ($width / $matches[2][$key]); |
3691 | + } elseif ($matches[2][$key]) { |
|
3692 | + $width = $matches[2][$key]; |
|
3548 | 3693 | } |
3549 | - elseif ($matches[2][$key]) |
|
3550 | - $width = $matches[2][$key]; |
|
3551 | 3694 | // ... and height. |
3552 | 3695 | if ($matches[4][$key] && $sig_limits[6] && $matches[4][$key] > $sig_limits[6]) |
3553 | 3696 | { |
3554 | 3697 | $height = $sig_limits[6]; |
3555 | - if ($width != -1) |
|
3556 | - $width = $width * ($height / $matches[4][$key]); |
|
3698 | + if ($width != -1) { |
|
3699 | + $width = $width * ($height / $matches[4][$key]); |
|
3700 | + } |
|
3701 | + } elseif ($matches[4][$key]) { |
|
3702 | + $height = $matches[4][$key]; |
|
3557 | 3703 | } |
3558 | - elseif ($matches[4][$key]) |
|
3559 | - $height = $matches[4][$key]; |
|
3560 | 3704 | |
3561 | 3705 | // If the dimensions are still not fixed - we need to check the actual image. |
3562 | 3706 | if (($width == -1 && $sig_limits[5]) || ($height == -1 && $sig_limits[6])) |
@@ -3574,21 +3718,24 @@ discard block |
||
3574 | 3718 | if ($sizes[1] > $sig_limits[6] && $sig_limits[6]) |
3575 | 3719 | { |
3576 | 3720 | $height = $sig_limits[6]; |
3577 | - if ($width == -1) |
|
3578 | - $width = $sizes[0]; |
|
3721 | + if ($width == -1) { |
|
3722 | + $width = $sizes[0]; |
|
3723 | + } |
|
3579 | 3724 | $width = $width * ($height / $sizes[1]); |
3725 | + } elseif ($width != -1) { |
|
3726 | + $height = $sizes[1]; |
|
3580 | 3727 | } |
3581 | - elseif ($width != -1) |
|
3582 | - $height = $sizes[1]; |
|
3583 | 3728 | } |
3584 | 3729 | } |
3585 | 3730 | |
3586 | 3731 | // Did we come up with some changes? If so remake the string. |
3587 | - if ($width != -1 || $height != -1) |
|
3588 | - $replaces[$image] = '[img' . ($width != -1 ? ' width=' . round($width) : '') . ($height != -1 ? ' height=' . round($height) : '') . ']' . $matches[7][$key] . '[/img]'; |
|
3732 | + if ($width != -1 || $height != -1) { |
|
3733 | + $replaces[$image] = '[img' . ($width != -1 ? ' width=' . round($width) : '') . ($height != -1 ? ' height=' . round($height) : '') . ']' . $matches[7][$key] . '[/img]'; |
|
3734 | + } |
|
3735 | + } |
|
3736 | + if (!empty($replaces)) { |
|
3737 | + $value = str_replace(array_keys($replaces), array_values($replaces), $value); |
|
3589 | 3738 | } |
3590 | - if (!empty($replaces)) |
|
3591 | - $value = str_replace(array_keys($replaces), array_values($replaces), $value); |
|
3592 | 3739 | } |
3593 | 3740 | } |
3594 | 3741 | |
@@ -3632,10 +3779,12 @@ discard block |
||
3632 | 3779 | $email = strtr($email, array(''' => '\'')); |
3633 | 3780 | |
3634 | 3781 | // Check the name and email for validity. |
3635 | - if (trim($email) == '') |
|
3636 | - return 'no_email'; |
|
3637 | - if (!filter_var($email, FILTER_VALIDATE_EMAIL)) |
|
3638 | - return 'bad_email'; |
|
3782 | + if (trim($email) == '') { |
|
3783 | + return 'no_email'; |
|
3784 | + } |
|
3785 | + if (!filter_var($email, FILTER_VALIDATE_EMAIL)) { |
|
3786 | + return 'bad_email'; |
|
3787 | + } |
|
3639 | 3788 | |
3640 | 3789 | // Email addresses should be and stay unique. |
3641 | 3790 | $request = $smcFunc['db_query']('', ' |
@@ -3650,8 +3799,9 @@ discard block |
||
3650 | 3799 | ) |
3651 | 3800 | ); |
3652 | 3801 | |
3653 | - if ($smcFunc['db_num_rows']($request) > 0) |
|
3654 | - return 'email_taken'; |
|
3802 | + if ($smcFunc['db_num_rows']($request) > 0) { |
|
3803 | + return 'email_taken'; |
|
3804 | + } |
|
3655 | 3805 | $smcFunc['db_free_result']($request); |
3656 | 3806 | |
3657 | 3807 | return true; |
@@ -3664,8 +3814,9 @@ discard block |
||
3664 | 3814 | { |
3665 | 3815 | global $modSettings, $context, $cur_profile; |
3666 | 3816 | |
3667 | - if (isset($_POST['passwrd2']) && $_POST['passwrd2'] != '') |
|
3668 | - setLoginCookie(60 * $modSettings['cookieTime'], $context['id_member'], hash_salt($_POST['passwrd1'], $cur_profile['password_salt'])); |
|
3817 | + if (isset($_POST['passwrd2']) && $_POST['passwrd2'] != '') { |
|
3818 | + setLoginCookie(60 * $modSettings['cookieTime'], $context['id_member'], hash_salt($_POST['passwrd1'], $cur_profile['password_salt'])); |
|
3819 | + } |
|
3669 | 3820 | |
3670 | 3821 | loadUserSettings(); |
3671 | 3822 | writeLog(); |
@@ -3681,8 +3832,9 @@ discard block |
||
3681 | 3832 | require_once($sourcedir . '/Subs-Post.php'); |
3682 | 3833 | |
3683 | 3834 | // Shouldn't happen but just in case. |
3684 | - if (empty($profile_vars['email_address'])) |
|
3685 | - return; |
|
3835 | + if (empty($profile_vars['email_address'])) { |
|
3836 | + return; |
|
3837 | + } |
|
3686 | 3838 | |
3687 | 3839 | $replacements = array( |
3688 | 3840 | 'ACTIVATIONLINK' => $scripturl . '?action=activate;u=' . $context['id_member'] . ';code=' . $profile_vars['validation_code'], |
@@ -3705,8 +3857,9 @@ discard block |
||
3705 | 3857 | $_SESSION['log_time'] = 0; |
3706 | 3858 | $_SESSION['login_' . $cookiename] = $smcFunc['json_encode'](array(0, '', 0)); |
3707 | 3859 | |
3708 | - if (isset($_COOKIE[$cookiename])) |
|
3709 | - $_COOKIE[$cookiename] = ''; |
|
3860 | + if (isset($_COOKIE[$cookiename])) { |
|
3861 | + $_COOKIE[$cookiename] = ''; |
|
3862 | + } |
|
3710 | 3863 | |
3711 | 3864 | loadUserSettings(); |
3712 | 3865 | |
@@ -3739,11 +3892,13 @@ discard block |
||
3739 | 3892 | $groups[] = $curMember['id_group']; |
3740 | 3893 | |
3741 | 3894 | // Ensure the query doesn't croak! |
3742 | - if (empty($groups)) |
|
3743 | - $groups = array(0); |
|
3895 | + if (empty($groups)) { |
|
3896 | + $groups = array(0); |
|
3897 | + } |
|
3744 | 3898 | // Just to be sure... |
3745 | - foreach ($groups as $k => $v) |
|
3746 | - $groups[$k] = (int) $v; |
|
3899 | + foreach ($groups as $k => $v) { |
|
3900 | + $groups[$k] = (int) $v; |
|
3901 | + } |
|
3747 | 3902 | |
3748 | 3903 | // Get all the membergroups they can join. |
3749 | 3904 | $request = $smcFunc['db_query']('', ' |
@@ -3773,12 +3928,14 @@ discard block |
||
3773 | 3928 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
3774 | 3929 | { |
3775 | 3930 | // Can they edit their primary group? |
3776 | - if (($row['id_group'] == $context['primary_group'] && $row['group_type'] > 1) || ($row['hidden'] != 2 && $context['primary_group'] == 0 && in_array($row['id_group'], $groups))) |
|
3777 | - $context['can_edit_primary'] = true; |
|
3931 | + if (($row['id_group'] == $context['primary_group'] && $row['group_type'] > 1) || ($row['hidden'] != 2 && $context['primary_group'] == 0 && in_array($row['id_group'], $groups))) { |
|
3932 | + $context['can_edit_primary'] = true; |
|
3933 | + } |
|
3778 | 3934 | |
3779 | 3935 | // If they can't manage (protected) groups, and it's not publically joinable or already assigned, they can't see it. |
3780 | - if (((!$context['can_manage_protected'] && $row['group_type'] == 1) || (!$context['can_manage_membergroups'] && $row['group_type'] == 0)) && $row['id_group'] != $context['primary_group']) |
|
3781 | - continue; |
|
3936 | + if (((!$context['can_manage_protected'] && $row['group_type'] == 1) || (!$context['can_manage_membergroups'] && $row['group_type'] == 0)) && $row['id_group'] != $context['primary_group']) { |
|
3937 | + continue; |
|
3938 | + } |
|
3782 | 3939 | |
3783 | 3940 | $context['groups'][in_array($row['id_group'], $groups) ? 'member' : 'available'][$row['id_group']] = array( |
3784 | 3941 | 'id' => $row['id_group'], |
@@ -3807,13 +3964,15 @@ discard block |
||
3807 | 3964 | ); |
3808 | 3965 | |
3809 | 3966 | // No changing primary one unless you have enough groups! |
3810 | - if (count($context['groups']['member']) < 2) |
|
3811 | - $context['can_edit_primary'] = false; |
|
3967 | + if (count($context['groups']['member']) < 2) { |
|
3968 | + $context['can_edit_primary'] = false; |
|
3969 | + } |
|
3812 | 3970 | |
3813 | 3971 | // In the special case that someone is requesting membership of a group, setup some special context vars. |
3814 | - if (isset($_REQUEST['request']) && isset($context['groups']['available'][(int) $_REQUEST['request']]) && $context['groups']['available'][(int) $_REQUEST['request']]['type'] == 2) |
|
3815 | - $context['group_request'] = $context['groups']['available'][(int) $_REQUEST['request']]; |
|
3816 | -} |
|
3972 | + if (isset($_REQUEST['request']) && isset($context['groups']['available'][(int) $_REQUEST['request']]) && $context['groups']['available'][(int) $_REQUEST['request']]['type'] == 2) { |
|
3973 | + $context['group_request'] = $context['groups']['available'][(int) $_REQUEST['request']]; |
|
3974 | + } |
|
3975 | + } |
|
3817 | 3976 | |
3818 | 3977 | /** |
3819 | 3978 | * This function actually makes all the group changes |
@@ -3828,10 +3987,12 @@ discard block |
||
3828 | 3987 | global $user_info, $context, $user_profile, $modSettings, $smcFunc; |
3829 | 3988 | |
3830 | 3989 | // Let's be extra cautious... |
3831 | - if (!$context['user']['is_owner'] || empty($modSettings['show_group_membership'])) |
|
3832 | - isAllowedTo('manage_membergroups'); |
|
3833 | - if (!isset($_REQUEST['gid']) && !isset($_POST['primary'])) |
|
3834 | - fatal_lang_error('no_access', false); |
|
3990 | + if (!$context['user']['is_owner'] || empty($modSettings['show_group_membership'])) { |
|
3991 | + isAllowedTo('manage_membergroups'); |
|
3992 | + } |
|
3993 | + if (!isset($_REQUEST['gid']) && !isset($_POST['primary'])) { |
|
3994 | + fatal_lang_error('no_access', false); |
|
3995 | + } |
|
3835 | 3996 | |
3836 | 3997 | checkSession(isset($_GET['gid']) ? 'get' : 'post'); |
3837 | 3998 | |
@@ -3850,8 +4011,9 @@ discard block |
||
3850 | 4011 | $foundTarget = $changeType == 'primary' && $group_id == 0 ? true : false; |
3851 | 4012 | |
3852 | 4013 | // Sanity check!! |
3853 | - if ($group_id == 1) |
|
3854 | - isAllowedTo('admin_forum'); |
|
4014 | + if ($group_id == 1) { |
|
4015 | + isAllowedTo('admin_forum'); |
|
4016 | + } |
|
3855 | 4017 | // Protected groups too! |
3856 | 4018 | else |
3857 | 4019 | { |
@@ -3868,8 +4030,9 @@ discard block |
||
3868 | 4030 | list ($is_protected) = $smcFunc['db_fetch_row']($request); |
3869 | 4031 | $smcFunc['db_free_result']($request); |
3870 | 4032 | |
3871 | - if ($is_protected == 1) |
|
3872 | - isAllowedTo('admin_forum'); |
|
4033 | + if ($is_protected == 1) { |
|
4034 | + isAllowedTo('admin_forum'); |
|
4035 | + } |
|
3873 | 4036 | } |
3874 | 4037 | |
3875 | 4038 | // What ever we are doing, we need to determine if changing primary is possible! |
@@ -3891,36 +4054,43 @@ discard block |
||
3891 | 4054 | $group_name = $row['group_name']; |
3892 | 4055 | |
3893 | 4056 | // Does the group type match what we're doing - are we trying to request a non-requestable group? |
3894 | - if ($changeType == 'request' && $row['group_type'] != 2) |
|
3895 | - fatal_lang_error('no_access', false); |
|
4057 | + if ($changeType == 'request' && $row['group_type'] != 2) { |
|
4058 | + fatal_lang_error('no_access', false); |
|
4059 | + } |
|
3896 | 4060 | // What about leaving a requestable group we are not a member of? |
3897 | - elseif ($changeType == 'free' && $row['group_type'] == 2 && $old_profile['id_group'] != $row['id_group'] && !isset($addGroups[$row['id_group']])) |
|
3898 | - fatal_lang_error('no_access', false); |
|
3899 | - elseif ($changeType == 'free' && $row['group_type'] != 3 && $row['group_type'] != 2) |
|
3900 | - fatal_lang_error('no_access', false); |
|
4061 | + elseif ($changeType == 'free' && $row['group_type'] == 2 && $old_profile['id_group'] != $row['id_group'] && !isset($addGroups[$row['id_group']])) { |
|
4062 | + fatal_lang_error('no_access', false); |
|
4063 | + } elseif ($changeType == 'free' && $row['group_type'] != 3 && $row['group_type'] != 2) { |
|
4064 | + fatal_lang_error('no_access', false); |
|
4065 | + } |
|
3901 | 4066 | |
3902 | 4067 | // We can't change the primary group if this is hidden! |
3903 | - if ($row['hidden'] == 2) |
|
3904 | - $canChangePrimary = false; |
|
4068 | + if ($row['hidden'] == 2) { |
|
4069 | + $canChangePrimary = false; |
|
4070 | + } |
|
3905 | 4071 | } |
3906 | 4072 | |
3907 | 4073 | // If this is their old primary, can we change it? |
3908 | - if ($row['id_group'] == $old_profile['id_group'] && ($row['group_type'] > 1 || $context['can_manage_membergroups']) && $canChangePrimary !== false) |
|
3909 | - $canChangePrimary = 1; |
|
4074 | + if ($row['id_group'] == $old_profile['id_group'] && ($row['group_type'] > 1 || $context['can_manage_membergroups']) && $canChangePrimary !== false) { |
|
4075 | + $canChangePrimary = 1; |
|
4076 | + } |
|
3910 | 4077 | |
3911 | 4078 | // If we are not doing a force primary move, don't do it automatically if current primary is not 0. |
3912 | - if ($changeType != 'primary' && $old_profile['id_group'] != 0) |
|
3913 | - $canChangePrimary = false; |
|
4079 | + if ($changeType != 'primary' && $old_profile['id_group'] != 0) { |
|
4080 | + $canChangePrimary = false; |
|
4081 | + } |
|
3914 | 4082 | |
3915 | 4083 | // If this is the one we are acting on, can we even act? |
3916 | - if ((!$context['can_manage_protected'] && $row['group_type'] == 1) || (!$context['can_manage_membergroups'] && $row['group_type'] == 0)) |
|
3917 | - $canChangePrimary = false; |
|
4084 | + if ((!$context['can_manage_protected'] && $row['group_type'] == 1) || (!$context['can_manage_membergroups'] && $row['group_type'] == 0)) { |
|
4085 | + $canChangePrimary = false; |
|
4086 | + } |
|
3918 | 4087 | } |
3919 | 4088 | $smcFunc['db_free_result']($request); |
3920 | 4089 | |
3921 | 4090 | // Didn't find the target? |
3922 | - if (!$foundTarget) |
|
3923 | - fatal_lang_error('no_access', false); |
|
4091 | + if (!$foundTarget) { |
|
4092 | + fatal_lang_error('no_access', false); |
|
4093 | + } |
|
3924 | 4094 | |
3925 | 4095 | // Final security check, don't allow users to promote themselves to admin. |
3926 | 4096 | if ($context['can_manage_membergroups'] && !allowedTo('admin_forum')) |
@@ -3940,8 +4110,9 @@ discard block |
||
3940 | 4110 | list ($disallow) = $smcFunc['db_fetch_row']($request); |
3941 | 4111 | $smcFunc['db_free_result']($request); |
3942 | 4112 | |
3943 | - if ($disallow) |
|
3944 | - isAllowedTo('admin_forum'); |
|
4113 | + if ($disallow) { |
|
4114 | + isAllowedTo('admin_forum'); |
|
4115 | + } |
|
3945 | 4116 | } |
3946 | 4117 | |
3947 | 4118 | // If we're requesting, add the note then return. |
@@ -3959,8 +4130,9 @@ discard block |
||
3959 | 4130 | 'status_open' => 0, |
3960 | 4131 | ) |
3961 | 4132 | ); |
3962 | - if ($smcFunc['db_num_rows']($request) != 0) |
|
3963 | - fatal_lang_error('profile_error_already_requested_group'); |
|
4133 | + if ($smcFunc['db_num_rows']($request) != 0) { |
|
4134 | + fatal_lang_error('profile_error_already_requested_group'); |
|
4135 | + } |
|
3964 | 4136 | $smcFunc['db_free_result']($request); |
3965 | 4137 | |
3966 | 4138 | // Log the request. |
@@ -3994,10 +4166,11 @@ discard block |
||
3994 | 4166 | // Are we leaving? |
3995 | 4167 | if ($old_profile['id_group'] == $group_id || isset($addGroups[$group_id])) |
3996 | 4168 | { |
3997 | - if ($old_profile['id_group'] == $group_id) |
|
3998 | - $newPrimary = 0; |
|
3999 | - else |
|
4000 | - unset($addGroups[$group_id]); |
|
4169 | + if ($old_profile['id_group'] == $group_id) { |
|
4170 | + $newPrimary = 0; |
|
4171 | + } else { |
|
4172 | + unset($addGroups[$group_id]); |
|
4173 | + } |
|
4001 | 4174 | } |
4002 | 4175 | // ... if not, must be joining. |
4003 | 4176 | else |
@@ -4005,36 +4178,42 @@ discard block |
||
4005 | 4178 | // Can we change the primary, and do we want to? |
4006 | 4179 | if ($canChangePrimary) |
4007 | 4180 | { |
4008 | - if ($old_profile['id_group'] != 0) |
|
4009 | - $addGroups[$old_profile['id_group']] = -1; |
|
4181 | + if ($old_profile['id_group'] != 0) { |
|
4182 | + $addGroups[$old_profile['id_group']] = -1; |
|
4183 | + } |
|
4010 | 4184 | $newPrimary = $group_id; |
4011 | 4185 | } |
4012 | 4186 | // Otherwise it's an additional group... |
4013 | - else |
|
4014 | - $addGroups[$group_id] = -1; |
|
4187 | + else { |
|
4188 | + $addGroups[$group_id] = -1; |
|
4189 | + } |
|
4015 | 4190 | } |
4016 | 4191 | } |
4017 | 4192 | // Finally, we must be setting the primary. |
4018 | 4193 | elseif ($canChangePrimary) |
4019 | 4194 | { |
4020 | - if ($old_profile['id_group'] != 0) |
|
4021 | - $addGroups[$old_profile['id_group']] = -1; |
|
4022 | - if (isset($addGroups[$group_id])) |
|
4023 | - unset($addGroups[$group_id]); |
|
4195 | + if ($old_profile['id_group'] != 0) { |
|
4196 | + $addGroups[$old_profile['id_group']] = -1; |
|
4197 | + } |
|
4198 | + if (isset($addGroups[$group_id])) { |
|
4199 | + unset($addGroups[$group_id]); |
|
4200 | + } |
|
4024 | 4201 | $newPrimary = $group_id; |
4025 | 4202 | } |
4026 | 4203 | |
4027 | 4204 | // Finally, we can make the changes! |
4028 | - foreach ($addGroups as $id => $dummy) |
|
4029 | - if (empty($id)) |
|
4205 | + foreach ($addGroups as $id => $dummy) { |
|
4206 | + if (empty($id)) |
|
4030 | 4207 | unset($addGroups[$id]); |
4208 | + } |
|
4031 | 4209 | $addGroups = implode(',', array_flip($addGroups)); |
4032 | 4210 | |
4033 | 4211 | // Ensure that we don't cache permissions if the group is changing. |
4034 | - if ($context['user']['is_owner']) |
|
4035 | - $_SESSION['mc']['time'] = 0; |
|
4036 | - else |
|
4037 | - updateSettings(array('settings_updated' => time())); |
|
4212 | + if ($context['user']['is_owner']) { |
|
4213 | + $_SESSION['mc']['time'] = 0; |
|
4214 | + } else { |
|
4215 | + updateSettings(array('settings_updated' => time())); |
|
4216 | + } |
|
4038 | 4217 | |
4039 | 4218 | updateMemberData($memID, array('id_group' => $newPrimary, 'additional_groups' => $addGroups)); |
4040 | 4219 | |
@@ -4057,8 +4236,9 @@ discard block |
||
4057 | 4236 | if (empty($user_settings['tfa_secret']) && $context['user']['is_owner']) |
4058 | 4237 | { |
4059 | 4238 | // Check to ensure we're forcing SSL for authentication |
4060 | - if (!empty($modSettings['force_ssl']) && empty($maintenance) && !httpsOn()) |
|
4061 | - fatal_lang_error('login_ssl_required'); |
|
4239 | + if (!empty($modSettings['force_ssl']) && empty($maintenance) && !httpsOn()) { |
|
4240 | + fatal_lang_error('login_ssl_required'); |
|
4241 | + } |
|
4062 | 4242 | |
4063 | 4243 | // In some cases (forced 2FA or backup code) they would be forced to be redirected here, |
4064 | 4244 | // we do not want too much AJAX to confuse them. |
@@ -4095,8 +4275,7 @@ discard block |
||
4095 | 4275 | $context['sub_template'] = 'tfasetup_backup'; |
4096 | 4276 | |
4097 | 4277 | return; |
4098 | - } |
|
4099 | - else |
|
4278 | + } else |
|
4100 | 4279 | { |
4101 | 4280 | $context['tfa_secret'] = $_SESSION['tfa_secret']; |
4102 | 4281 | $context['tfa_error'] = !$valid_code; |
@@ -4104,8 +4283,7 @@ discard block |
||
4104 | 4283 | $context['tfa_pass_value'] = $_POST['passwd']; |
4105 | 4284 | $context['tfa_value'] = $_POST['tfa_code']; |
4106 | 4285 | } |
4107 | - } |
|
4108 | - else |
|
4286 | + } else |
|
4109 | 4287 | { |
4110 | 4288 | $totp = new \TOTP\Auth(); |
4111 | 4289 | $secret = $totp->generateCode(); |
@@ -4115,17 +4293,16 @@ discard block |
||
4115 | 4293 | } |
4116 | 4294 | |
4117 | 4295 | $context['tfa_qr_url'] = $totp->getQrCodeUrl($context['forum_name'] . ':' . $user_info['name'], $context['tfa_secret']); |
4118 | - } |
|
4119 | - elseif (isset($_REQUEST['disable'])) |
|
4296 | + } elseif (isset($_REQUEST['disable'])) |
|
4120 | 4297 | { |
4121 | 4298 | updateMemberData($memID, array( |
4122 | 4299 | 'tfa_secret' => '', |
4123 | 4300 | 'tfa_backup' => '', |
4124 | 4301 | )); |
4125 | 4302 | redirectexit('action=profile;area=account;u=' . $memID); |
4303 | + } else { |
|
4304 | + redirectexit('action=profile;area=account;u=' . $memID); |
|
4305 | + } |
|
4126 | 4306 | } |
4127 | - else |
|
4128 | - redirectexit('action=profile;area=account;u=' . $memID); |
|
4129 | -} |
|
4130 | 4307 | |
4131 | 4308 | ?> |
4132 | 4309 | \ No newline at end of file |
@@ -65,9 +65,10 @@ discard block |
||
65 | 65 | ', implode(', ', $context['administrators']); |
66 | 66 | |
67 | 67 | // If we have lots of admins... don't show them all. |
68 | - if (!empty($context['more_admins_link'])) |
|
69 | - echo ' |
|
68 | + if (!empty($context['more_admins_link'])) { |
|
69 | + echo ' |
|
70 | 70 | (', $context['more_admins_link'], ')'; |
71 | + } |
|
71 | 72 | |
72 | 73 | echo ' |
73 | 74 | </div><!-- #version_details --> |
@@ -84,17 +85,19 @@ discard block |
||
84 | 85 | foreach ($area['areas'] as $item_id => $item) |
85 | 86 | { |
86 | 87 | // No point showing the 'home' page here, we're already on it! |
87 | - if ($area_id == 'forum' && $item_id == 'index') |
|
88 | - continue; |
|
88 | + if ($area_id == 'forum' && $item_id == 'index') { |
|
89 | + continue; |
|
90 | + } |
|
89 | 91 | |
90 | 92 | $url = isset($item['url']) ? $item['url'] : $scripturl . '?action=admin;area=' . $item_id . (!empty($context[$context['admin_menu_name']]['extra_parameters']) ? $context[$context['admin_menu_name']]['extra_parameters'] : ''); |
91 | 93 | |
92 | - if (!empty($item['icon_file'])) |
|
93 | - echo ' |
|
94 | + if (!empty($item['icon_file'])) { |
|
95 | + echo ' |
|
94 | 96 | <a href="', $url, '" class="admin_group', !empty($item['inactive']) ? ' inactive' : '', '"><img class="large_admin_menu_icon_file" src="', $item['icon_file'], '" alt="">', $item['label'], '</a>'; |
95 | - else |
|
96 | - echo ' |
|
97 | + } else { |
|
98 | + echo ' |
|
97 | 99 | <a href="', $url, '"><span class="large_', $item['icon_class'], !empty($item['inactive']) ? ' inactive' : '', '"></span>', $item['label'], '</a>'; |
100 | + } |
|
98 | 101 | } |
99 | 102 | |
100 | 103 | echo ' |
@@ -105,10 +108,11 @@ discard block |
||
105 | 108 | </div><!-- #admincenter -->'; |
106 | 109 | |
107 | 110 | // The below functions include all the scripts needed from the simplemachines.org site. The language and format are passed for internationalization. |
108 | - if (empty($modSettings['disable_smf_js'])) |
|
109 | - echo ' |
|
111 | + if (empty($modSettings['disable_smf_js'])) { |
|
112 | + echo ' |
|
110 | 113 | <script src="', $scripturl, '?action=viewsmfile;filename=current-version.js"></script> |
111 | 114 | <script src="', $scripturl, '?action=viewsmfile;filename=latest-news.js"></script>'; |
115 | + } |
|
112 | 116 | |
113 | 117 | // This sets the announcements and current versions themselves ;). |
114 | 118 | echo ' |
@@ -186,9 +190,10 @@ discard block |
||
186 | 190 | <em>', $version['version'], '</em>'; |
187 | 191 | |
188 | 192 | // more details for this item, show them a link |
189 | - if ($context['can_admin'] && isset($version['more'])) |
|
190 | - echo |
|
193 | + if ($context['can_admin'] && isset($version['more'])) { |
|
194 | + echo |
|
191 | 195 | ' <a href="', $scripturl, $version['more'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['version_check_more'], '</a>'; |
196 | + } |
|
192 | 197 | echo ' |
193 | 198 | <br>'; |
194 | 199 | } |
@@ -219,21 +224,23 @@ discard block |
||
219 | 224 | |
220 | 225 | foreach ($context['credits'] as $section) |
221 | 226 | { |
222 | - if (isset($section['pretext'])) |
|
223 | - echo ' |
|
227 | + if (isset($section['pretext'])) { |
|
228 | + echo ' |
|
224 | 229 | <p>', $section['pretext'], '</p> |
225 | 230 | <hr>'; |
231 | + } |
|
226 | 232 | |
227 | 233 | echo ' |
228 | 234 | <dl>'; |
229 | 235 | |
230 | 236 | foreach ($section['groups'] as $group) |
231 | 237 | { |
232 | - if (isset($group['title'])) |
|
233 | - echo ' |
|
238 | + if (isset($group['title'])) { |
|
239 | + echo ' |
|
234 | 240 | <dt> |
235 | 241 | <strong>', $group['title'], ':</strong> |
236 | 242 | </dt>'; |
243 | + } |
|
237 | 244 | |
238 | 245 | echo ' |
239 | 246 | <dd>', implode(', ', $group['members']), '</dd>'; |
@@ -242,10 +249,11 @@ discard block |
||
242 | 249 | echo ' |
243 | 250 | </dl>'; |
244 | 251 | |
245 | - if (isset($section['posttext'])) |
|
246 | - echo ' |
|
252 | + if (isset($section['posttext'])) { |
|
253 | + echo ' |
|
247 | 254 | <hr> |
248 | 255 | <p>', $section['posttext'], '</p>'; |
256 | + } |
|
249 | 257 | } |
250 | 258 | |
251 | 259 | echo ' |
@@ -261,9 +269,10 @@ discard block |
||
261 | 269 | smfSupportVersions.forum = "', $context['forum_version'], '";'; |
262 | 270 | |
263 | 271 | // Don't worry, none of this is logged, it's just used to give information that might be of use. |
264 | - foreach ($context['current_versions'] as $variable => $version) |
|
265 | - echo ' |
|
272 | + foreach ($context['current_versions'] as $variable => $version) { |
|
273 | + echo ' |
|
266 | 274 | smfSupportVersions.', $variable, ' = "', $version['version'], '";'; |
275 | + } |
|
267 | 276 | |
268 | 277 | // Now we just have to include the script and wait ;). |
269 | 278 | echo ' |
@@ -360,8 +369,8 @@ discard block |
||
360 | 369 | <tbody>'; |
361 | 370 | |
362 | 371 | // Loop through every source file displaying its version - using javascript. |
363 | - foreach ($context['file_versions'] as $filename => $version) |
|
364 | - echo ' |
|
372 | + foreach ($context['file_versions'] as $filename => $version) { |
|
373 | + echo ' |
|
365 | 374 | <tr class="windowbg"> |
366 | 375 | <td class="half_table"> |
367 | 376 | ', $filename, ' |
@@ -373,6 +382,7 @@ discard block |
||
373 | 382 | <em id="currentSources', $filename, '">??</em> |
374 | 383 | </td> |
375 | 384 | </tr>'; |
385 | + } |
|
376 | 386 | |
377 | 387 | // Default template files. |
378 | 388 | echo ' |
@@ -398,8 +408,8 @@ discard block |
||
398 | 408 | <table id="Default" class="table_grid"> |
399 | 409 | <tbody>'; |
400 | 410 | |
401 | - foreach ($context['default_template_versions'] as $filename => $version) |
|
402 | - echo ' |
|
411 | + foreach ($context['default_template_versions'] as $filename => $version) { |
|
412 | + echo ' |
|
403 | 413 | <tr class="windowbg"> |
404 | 414 | <td class="half_table"> |
405 | 415 | ', $filename, ' |
@@ -411,6 +421,7 @@ discard block |
||
411 | 421 | <em id="currentDefault', $filename, '">??</em> |
412 | 422 | </td> |
413 | 423 | </tr>'; |
424 | + } |
|
414 | 425 | |
415 | 426 | // Now the language files... |
416 | 427 | echo ' |
@@ -438,8 +449,8 @@ discard block |
||
438 | 449 | |
439 | 450 | foreach ($context['default_language_versions'] as $language => $files) |
440 | 451 | { |
441 | - foreach ($files as $filename => $version) |
|
442 | - echo ' |
|
452 | + foreach ($files as $filename => $version) { |
|
453 | + echo ' |
|
443 | 454 | <tr class="windowbg"> |
444 | 455 | <td class="half_table"> |
445 | 456 | ', $filename, '.<em>', $language, '</em>.php |
@@ -451,6 +462,7 @@ discard block |
||
451 | 462 | <em id="current', $filename, '.', $language, '">??</em> |
452 | 463 | </td> |
453 | 464 | </tr>'; |
465 | + } |
|
454 | 466 | } |
455 | 467 | |
456 | 468 | echo ' |
@@ -480,8 +492,8 @@ discard block |
||
480 | 492 | <table id="Templates" class="table_grid"> |
481 | 493 | <tbody>'; |
482 | 494 | |
483 | - foreach ($context['template_versions'] as $filename => $version) |
|
484 | - echo ' |
|
495 | + foreach ($context['template_versions'] as $filename => $version) { |
|
496 | + echo ' |
|
485 | 497 | <tr class="windowbg"> |
486 | 498 | <td class="half_table"> |
487 | 499 | ', $filename, ' |
@@ -493,6 +505,7 @@ discard block |
||
493 | 505 | <em id="currentTemplates', $filename, '">??</em> |
494 | 506 | </td> |
495 | 507 | </tr>'; |
508 | + } |
|
496 | 509 | |
497 | 510 | echo ' |
498 | 511 | </tbody> |
@@ -522,8 +535,8 @@ discard block |
||
522 | 535 | <table id="Tasks" class="table_grid"> |
523 | 536 | <tbody>'; |
524 | 537 | |
525 | - foreach ($context['tasks_versions'] as $filename => $version) |
|
526 | - echo ' |
|
538 | + foreach ($context['tasks_versions'] as $filename => $version) { |
|
539 | + echo ' |
|
527 | 540 | <tr class="windowbg"> |
528 | 541 | <td class="half_table"> |
529 | 542 | ', $filename, ' |
@@ -535,6 +548,7 @@ discard block |
||
535 | 548 | <em id="currentTasks', $filename, '">??</em> |
536 | 549 | </td> |
537 | 550 | </tr>'; |
551 | + } |
|
538 | 552 | |
539 | 553 | echo ' |
540 | 554 | </tbody> |
@@ -576,9 +590,10 @@ discard block |
||
576 | 590 | { |
577 | 591 | global $context, $scripturl, $txt, $modSettings; |
578 | 592 | |
579 | - if (!empty($context['saved_successful'])) |
|
580 | - echo ' |
|
593 | + if (!empty($context['saved_successful'])) { |
|
594 | + echo ' |
|
581 | 595 | <div class="infobox">', $txt['settings_saved'], '</div>'; |
596 | + } |
|
582 | 597 | |
583 | 598 | // First section is for adding/removing words from the censored list. |
584 | 599 | echo ' |
@@ -593,11 +608,12 @@ discard block |
||
593 | 608 | <p>', $txt['admin_censored_where'], '</p>'; |
594 | 609 | |
595 | 610 | // Show text boxes for censoring [bad ] => [good ]. |
596 | - foreach ($context['censored_words'] as $vulgar => $proper) |
|
597 | - echo ' |
|
611 | + foreach ($context['censored_words'] as $vulgar => $proper) { |
|
612 | + echo ' |
|
598 | 613 | <div class="block"> |
599 | 614 | <input type="text" name="censor_vulgar[]" value="', $vulgar, '" size="30"> => <input type="text" name="censor_proper[]" value="', $proper, '" size="30"> |
600 | 615 | </div>'; |
616 | + } |
|
601 | 617 | |
602 | 618 | // Now provide a way to censor more words. |
603 | 619 | echo ' |
@@ -672,19 +688,21 @@ discard block |
||
672 | 688 | <div class="windowbg2 noup"> |
673 | 689 | ', $txt['not_done_reason']; |
674 | 690 | |
675 | - if (!empty($context['continue_percent'])) |
|
676 | - echo ' |
|
691 | + if (!empty($context['continue_percent'])) { |
|
692 | + echo ' |
|
677 | 693 | <div class="progress_bar"> |
678 | 694 | <span>', $context['continue_percent'], '%</span> |
679 | 695 | <div class="bar" style="width: ', $context['continue_percent'], '%;"></div> |
680 | 696 | </div>'; |
697 | + } |
|
681 | 698 | |
682 | - if (!empty($context['substep_enabled'])) |
|
683 | - echo ' |
|
699 | + if (!empty($context['substep_enabled'])) { |
|
700 | + echo ' |
|
684 | 701 | <div class="progress_bar progress_blue"> |
685 | 702 | <span>', $context['substep_title'], ' (', $context['substep_continue_percent'], '%)</span> |
686 | 703 | <div class="bar" style="width: ', $context['substep_continue_percent'], '%;"></div> |
687 | 704 | </div>'; |
705 | + } |
|
688 | 706 | |
689 | 707 | echo ' |
690 | 708 | <form action="', $scripturl, $context['continue_get_data'], '" method="post" accept-charset="', $context['character_set'], '" name="autoSubmit" id="autoSubmit"> |
@@ -719,35 +737,40 @@ discard block |
||
719 | 737 | { |
720 | 738 | global $context, $txt, $scripturl; |
721 | 739 | |
722 | - if (!empty($context['saved_successful'])) |
|
723 | - echo ' |
|
740 | + if (!empty($context['saved_successful'])) { |
|
741 | + echo ' |
|
724 | 742 | <div class="infobox">', $txt['settings_saved'], '</div>'; |
725 | - elseif (!empty($context['saved_failed'])) |
|
726 | - echo ' |
|
743 | + } elseif (!empty($context['saved_failed'])) { |
|
744 | + echo ' |
|
727 | 745 | <div class="errorbox">', sprintf($txt['settings_not_saved'], $context['saved_failed']), '</div>'; |
746 | + } |
|
728 | 747 | |
729 | - if (!empty($context['settings_pre_javascript'])) |
|
730 | - echo ' |
|
748 | + if (!empty($context['settings_pre_javascript'])) { |
|
749 | + echo ' |
|
731 | 750 | <script>', $context['settings_pre_javascript'], '</script>'; |
751 | + } |
|
732 | 752 | |
733 | - if (!empty($context['settings_insert_above'])) |
|
734 | - echo $context['settings_insert_above']; |
|
753 | + if (!empty($context['settings_insert_above'])) { |
|
754 | + echo $context['settings_insert_above']; |
|
755 | + } |
|
735 | 756 | |
736 | 757 | echo ' |
737 | 758 | <div id="admincenter"> |
738 | 759 | <form id="admin_form_wrapper" action="', $context['post_url'], '" method="post" accept-charset="', $context['character_set'], '"', !empty($context['force_form_onsubmit']) ? ' onsubmit="' . $context['force_form_onsubmit'] . '"' : '', '>'; |
739 | 760 | |
740 | 761 | // Is there a custom title? |
741 | - if (isset($context['settings_title'])) |
|
742 | - echo ' |
|
762 | + if (isset($context['settings_title'])) { |
|
763 | + echo ' |
|
743 | 764 | <div class="cat_bar"> |
744 | 765 | <h3 class="catbg">', $context['settings_title'], '</h3> |
745 | 766 | </div>'; |
767 | + } |
|
746 | 768 | |
747 | 769 | // Have we got a message to display? |
748 | - if (!empty($context['settings_message'])) |
|
749 | - echo ' |
|
770 | + if (!empty($context['settings_message'])) { |
|
771 | + echo ' |
|
750 | 772 | <div class="information">', $context['settings_message'], '</div>'; |
773 | + } |
|
751 | 774 | |
752 | 775 | // Now actually loop through all the variables. |
753 | 776 | $is_open = false; |
@@ -800,8 +823,9 @@ discard block |
||
800 | 823 | // Hang about? Are you pulling my leg - a callback?! |
801 | 824 | if (is_array($config_var) && $config_var['type'] == 'callback') |
802 | 825 | { |
803 | - if (function_exists('template_callback_' . $config_var['name'])) |
|
804 | - call_user_func('template_callback_' . $config_var['name']); |
|
826 | + if (function_exists('template_callback_' . $config_var['name'])) { |
|
827 | + call_user_func('template_callback_' . $config_var['name']); |
|
828 | + } |
|
805 | 829 | |
806 | 830 | continue; |
807 | 831 | } |
@@ -831,9 +855,10 @@ discard block |
||
831 | 855 | $text_types = array('color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'time'); |
832 | 856 | |
833 | 857 | // Show the [?] button. |
834 | - if ($config_var['help']) |
|
835 | - echo ' |
|
858 | + if ($config_var['help']) { |
|
859 | + echo ' |
|
836 | 860 | <a id="setting_', $config_var['name'], '_help" href="', $scripturl, '?action=helpadmin;help=', $config_var['help'], '" onclick="return reqOverlayDiv(this.href);"><span class="generic_icons help" title="', $txt['help'], '"></span></a> '; |
861 | + } |
|
837 | 862 | |
838 | 863 | echo ' |
839 | 864 | <a id="setting_', $config_var['name'], '"></a> <span', ($config_var['disabled'] ? ' style="color: #777777;"' : ($config_var['invalid'] ? ' class="error"' : '')), '><label for="', $config_var['name'], '">', $config_var['label'], '</label>', $subtext, ($config_var['type'] == 'password' ? '<br><em>' . $txt['admin_confirm_password'] . '</em>' : ''), '</span> |
@@ -842,23 +867,26 @@ discard block |
||
842 | 867 | $config_var['preinput']; |
843 | 868 | |
844 | 869 | // Show a check box. |
845 | - if ($config_var['type'] == 'check') |
|
846 | - echo ' |
|
870 | + if ($config_var['type'] == 'check') { |
|
871 | + echo ' |
|
847 | 872 | <input type="checkbox"', $javascript, $disabled, ' name="', $config_var['name'], '" id="', $config_var['name'], '"', ($config_var['value'] ? ' checked' : ''), ' value="1">'; |
873 | + } |
|
848 | 874 | // Escape (via htmlspecialchars.) the text box. |
849 | - elseif ($config_var['type'] == 'password') |
|
850 | - echo ' |
|
875 | + elseif ($config_var['type'] == 'password') { |
|
876 | + echo ' |
|
851 | 877 | <input type="password"', $disabled, $javascript, ' name="', $config_var['name'], '[0]"', ($config_var['size'] ? ' size="' . $config_var['size'] . '"' : ''), ' value="*#fakepass#*" onfocus="this.value = \'\'; this.form.', $config_var['name'], '.disabled = false;"><br> |
852 | 878 | <input type="password" disabled id="', $config_var['name'], '" name="', $config_var['name'], '[1]"', ($config_var['size'] ? ' size="' . $config_var['size'] . '"' : ''), '>'; |
879 | + } |
|
853 | 880 | // Show a selection box. |
854 | 881 | elseif ($config_var['type'] == 'select') |
855 | 882 | { |
856 | 883 | echo ' |
857 | 884 | <select name="', $config_var['name'], '" id="', $config_var['name'], '" ', $javascript, $disabled, (!empty($config_var['multiple']) ? ' multiple="multiple"' : ''), (!empty($config_var['multiple']) && !empty($config_var['size']) ? ' size="' . $config_var['size'] . '"' : ''), '>'; |
858 | 885 | |
859 | - foreach ($config_var['data'] as $option) |
|
860 | - echo ' |
|
886 | + foreach ($config_var['data'] as $option) { |
|
887 | + echo ' |
|
861 | 888 | <option value="', $option[0], '"', (!empty($config_var['value']) && ($option[0] == $config_var['value'] || (!empty($config_var['multiple']) && in_array($option[0], $config_var['value']))) ? ' selected' : ''), '>', $option[1], '</option>'; |
889 | + } |
|
862 | 890 | echo ' |
863 | 891 | </select>'; |
864 | 892 | } |
@@ -875,16 +903,18 @@ discard block |
||
875 | 903 | |
876 | 904 | foreach ($context['board_list'] as $id_cat => $cat) |
877 | 905 | { |
878 | - if (!$first) |
|
879 | - echo ' |
|
906 | + if (!$first) { |
|
907 | + echo ' |
|
880 | 908 | <hr>'; |
909 | + } |
|
881 | 910 | echo ' |
882 | 911 | <strong>', $cat['name'], '</strong> |
883 | 912 | <ul>'; |
884 | 913 | |
885 | - foreach ($cat['boards'] as $id_board => $brd) |
|
886 | - echo ' |
|
914 | + foreach ($cat['boards'] as $id_board => $brd) { |
|
915 | + echo ' |
|
887 | 916 | <li><label><input type="checkbox" name="', $config_var['name'], '[', $brd['id'], ']" value="1"', in_array($brd['id'], $config_var['value']) ? ' checked' : '', '> ', $brd['child_level'] > 0 ? str_repeat(' ', $brd['child_level']) : '', $brd['name'], '</label></li>'; |
917 | + } |
|
888 | 918 | |
889 | 919 | echo ' |
890 | 920 | </ul>'; |
@@ -894,12 +924,14 @@ discard block |
||
894 | 924 | </fieldset>'; |
895 | 925 | } |
896 | 926 | // Text area? |
897 | - elseif ($config_var['type'] == 'large_text') |
|
898 | - echo ' |
|
927 | + elseif ($config_var['type'] == 'large_text') { |
|
928 | + echo ' |
|
899 | 929 | <textarea rows="', (!empty($config_var['size']) ? $config_var['size'] : (!empty($config_var['rows']) ? $config_var['rows'] : 4)), '" cols="', (!empty($config_var['cols']) ? $config_var['cols'] : 30), '" ', $javascript, $disabled, ' name="', $config_var['name'], '" id="', $config_var['name'], '">', $config_var['value'], '</textarea>'; |
930 | + } |
|
900 | 931 | // Permission group? |
901 | - elseif ($config_var['type'] == 'permissions') |
|
902 | - theme_inline_permissions($config_var['name']); |
|
932 | + elseif ($config_var['type'] == 'permissions') { |
|
933 | + theme_inline_permissions($config_var['name']); |
|
934 | + } |
|
903 | 935 | |
904 | 936 | // BBC selection? |
905 | 937 | elseif ($config_var['type'] == 'bbc') |
@@ -911,22 +943,24 @@ discard block |
||
911 | 943 | |
912 | 944 | foreach ($context['bbc_columns'] as $bbcColumn) |
913 | 945 | { |
914 | - foreach ($bbcColumn as $bbcTag) |
|
915 | - echo ' |
|
946 | + foreach ($bbcColumn as $bbcTag) { |
|
947 | + echo ' |
|
916 | 948 | <li class="list_bbc floatleft"> |
917 | 949 | <input type="checkbox" name="', $config_var['name'], '_enabledTags[]" id="tag_', $config_var['name'], '_', $bbcTag['tag'], '" value="', $bbcTag['tag'], '"', !in_array($bbcTag['tag'], $context['bbc_sections'][$config_var['name']]['disabled']) ? ' checked' : '', '> <label for="tag_', $config_var['name'], '_', $bbcTag['tag'], '">', $bbcTag['tag'], '</label>', $bbcTag['show_help'] ? ' (<a href="' . $scripturl . '?action=helpadmin;help=tag_' . $bbcTag['tag'] . '" onclick="return reqOverlayDiv(this.href);">?</a>)' : '', ' |
918 | 950 | </li>'; |
951 | + } |
|
919 | 952 | } |
920 | 953 | echo ' </ul> |
921 | 954 | <input type="checkbox" id="bbc_', $config_var['name'], '_select_all" onclick="invertAll(this, this.form, \'', $config_var['name'], '_enabledTags\');"', $context['bbc_sections'][$config_var['name']]['all_selected'] ? ' checked' : '', '> <label for="bbc_', $config_var['name'], '_select_all"><em>', $txt['bbcTagsToUse_select_all'], '</em></label> |
922 | 955 | </fieldset>'; |
923 | 956 | } |
924 | 957 | // A simple message? |
925 | - elseif ($config_var['type'] == 'var_message') |
|
926 | - echo ' |
|
958 | + elseif ($config_var['type'] == 'var_message') { |
|
959 | + echo ' |
|
927 | 960 | <div', !empty($config_var['name']) ? ' id="' . $config_var['name'] . '"' : '', '> |
928 | 961 | ', $config_var['var_message'], ' |
929 | 962 | </div>'; |
963 | + } |
|
930 | 964 | // Assume it must be a text box |
931 | 965 | else |
932 | 966 | { |
@@ -951,62 +985,70 @@ discard block |
||
951 | 985 | ' . $config_var['postinput'] : '',' |
952 | 986 | </dd>'; |
953 | 987 | } |
954 | - } |
|
955 | - else |
|
988 | + } else |
|
956 | 989 | { |
957 | 990 | // Just show a separator. |
958 | - if ($config_var == '') |
|
959 | - echo ' |
|
991 | + if ($config_var == '') { |
|
992 | + echo ' |
|
960 | 993 | </dl> |
961 | 994 | <hr> |
962 | 995 | <dl class="settings">'; |
963 | - else |
|
964 | - echo ' |
|
996 | + } else { |
|
997 | + echo ' |
|
965 | 998 | <dd> |
966 | 999 | <strong>' . $config_var . '</strong> |
967 | 1000 | </dd>'; |
1001 | + } |
|
968 | 1002 | } |
969 | 1003 | } |
970 | 1004 | |
971 | - if ($is_open) |
|
972 | - echo ' |
|
1005 | + if ($is_open) { |
|
1006 | + echo ' |
|
973 | 1007 | </dl>'; |
1008 | + } |
|
974 | 1009 | |
975 | - if (empty($context['settings_save_dont_show'])) |
|
976 | - echo ' |
|
1010 | + if (empty($context['settings_save_dont_show'])) { |
|
1011 | + echo ' |
|
977 | 1012 | <input type="submit" value="', $txt['save'], '"', (!empty($context['save_disabled']) ? ' disabled' : ''), (!empty($context['settings_save_onclick']) ? ' onclick="' . $context['settings_save_onclick'] . '"' : ''), ' class="button">'; |
1013 | + } |
|
978 | 1014 | |
979 | - if ($is_open) |
|
980 | - echo ' |
|
1015 | + if ($is_open) { |
|
1016 | + echo ' |
|
981 | 1017 | </div><!-- .windowbg2 -->'; |
1018 | + } |
|
982 | 1019 | |
983 | 1020 | |
984 | 1021 | // At least one token has to be used! |
985 | - if (isset($context['admin-ssc_token'])) |
|
986 | - echo ' |
|
1022 | + if (isset($context['admin-ssc_token'])) { |
|
1023 | + echo ' |
|
987 | 1024 | <input type="hidden" name="', $context['admin-ssc_token_var'], '" value="', $context['admin-ssc_token'], '">'; |
1025 | + } |
|
988 | 1026 | |
989 | - if (isset($context['admin-dbsc_token'])) |
|
990 | - echo ' |
|
1027 | + if (isset($context['admin-dbsc_token'])) { |
|
1028 | + echo ' |
|
991 | 1029 | <input type="hidden" name="', $context['admin-dbsc_token_var'], '" value="', $context['admin-dbsc_token'], '">'; |
1030 | + } |
|
992 | 1031 | |
993 | - if (isset($context['admin-mp_token'])) |
|
994 | - echo ' |
|
1032 | + if (isset($context['admin-mp_token'])) { |
|
1033 | + echo ' |
|
995 | 1034 | <input type="hidden" name="', $context['admin-mp_token_var'], '" value="', $context['admin-mp_token'], '">'; |
1035 | + } |
|
996 | 1036 | |
997 | 1037 | echo ' |
998 | 1038 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
999 | 1039 | </form> |
1000 | 1040 | </div><!-- #admincenter -->'; |
1001 | 1041 | |
1002 | - if (!empty($context['settings_post_javascript'])) |
|
1003 | - echo ' |
|
1042 | + if (!empty($context['settings_post_javascript'])) { |
|
1043 | + echo ' |
|
1004 | 1044 | <script> |
1005 | 1045 | ', $context['settings_post_javascript'], ' |
1006 | 1046 | </script>'; |
1047 | + } |
|
1007 | 1048 | |
1008 | - if (!empty($context['settings_insert_below'])) |
|
1009 | - echo $context['settings_insert_below']; |
|
1049 | + if (!empty($context['settings_insert_below'])) { |
|
1050 | + echo $context['settings_insert_below']; |
|
1051 | + } |
|
1010 | 1052 | |
1011 | 1053 | // We may have added a board listing. If we did, we need to make it work. |
1012 | 1054 | addInlineJavascript(' |
@@ -1029,9 +1071,10 @@ discard block |
||
1029 | 1071 | { |
1030 | 1072 | global $context, $txt; |
1031 | 1073 | |
1032 | - if (!empty($context['saved_successful'])) |
|
1033 | - echo ' |
|
1074 | + if (!empty($context['saved_successful'])) { |
|
1075 | + echo ' |
|
1034 | 1076 | <div class="infobox">', $txt['settings_saved'], '</div>'; |
1077 | + } |
|
1035 | 1078 | |
1036 | 1079 | // Standard fields. |
1037 | 1080 | template_show_list('standard_profile_fields'); |
@@ -1065,11 +1108,12 @@ discard block |
||
1065 | 1108 | { |
1066 | 1109 | loadLanguage('Errors'); |
1067 | 1110 | |
1068 | - if (isset($txt['custom_option_' . $_GET['msg']])) |
|
1069 | - echo ' |
|
1111 | + if (isset($txt['custom_option_' . $_GET['msg']])) { |
|
1112 | + echo ' |
|
1070 | 1113 | <div class="errorbox">', |
1071 | 1114 | $txt['custom_option_' . $_GET['msg']], ' |
1072 | 1115 | </div>'; |
1116 | + } |
|
1073 | 1117 | } |
1074 | 1118 | |
1075 | 1119 | echo ' |
@@ -1136,9 +1180,10 @@ discard block |
||
1136 | 1180 | <dd> |
1137 | 1181 | <select name="placement" id="placement">'; |
1138 | 1182 | |
1139 | - foreach ($context['cust_profile_fields_placement'] as $order => $name) |
|
1140 | - echo ' |
|
1183 | + foreach ($context['cust_profile_fields_placement'] as $order => $name) { |
|
1184 | + echo ' |
|
1141 | 1185 | <option value="', $order, '"', $context['field']['placement'] == $order ? ' selected' : '', '>', $txt['custom_profile_placement_' . $name], '</option>'; |
1186 | + } |
|
1142 | 1187 | |
1143 | 1188 | echo ' |
1144 | 1189 | </select> |
@@ -1162,9 +1207,10 @@ discard block |
||
1162 | 1207 | <dd> |
1163 | 1208 | <select name="field_type" id="field_type" onchange="updateInputBoxes();">'; |
1164 | 1209 | |
1165 | - foreach (array('text', 'textarea', 'select', 'radio', 'check') as $field_type) |
|
1166 | - echo ' |
|
1210 | + foreach (array('text', 'textarea', 'select', 'radio', 'check') as $field_type) { |
|
1211 | + echo ' |
|
1167 | 1212 | <option value="', $field_type, '"', $context['field']['type'] == $field_type ? ' selected' : '', '>', $txt['custom_profile_type_' . $field_type], '</option>'; |
1213 | + } |
|
1168 | 1214 | |
1169 | 1215 | echo ' |
1170 | 1216 | </select> |
@@ -1196,9 +1242,10 @@ discard block |
||
1196 | 1242 | </dt> |
1197 | 1243 | <dd id="options_dd">'; |
1198 | 1244 | |
1199 | - foreach ($context['field']['options'] as $k => $option) |
|
1200 | - echo ' |
|
1245 | + foreach ($context['field']['options'] as $k => $option) { |
|
1246 | + echo ' |
|
1201 | 1247 | ', $k == 0 ? '' : '<br>', '<input type="radio" name="default_select" value="', $k, '"', $context['field']['default_select'] == $option ? ' checked' : '', '><input type="text" name="select_option[', $k, ']" value="', $option, '">'; |
1248 | + } |
|
1202 | 1249 | |
1203 | 1250 | echo ' |
1204 | 1251 | <span id="addopt"></span> |
@@ -1262,9 +1309,10 @@ discard block |
||
1262 | 1309 | </fieldset> |
1263 | 1310 | <input type="submit" name="save" value="', $txt['save'], '" class="button">'; |
1264 | 1311 | |
1265 | - if ($context['fid']) |
|
1266 | - echo ' |
|
1312 | + if ($context['fid']) { |
|
1313 | + echo ' |
|
1267 | 1314 | <input type="submit" name="delete" value="', $txt['delete'], '" data-confirm="', $txt['custom_edit_delete_sure'], '" class="button you_sure">'; |
1315 | + } |
|
1268 | 1316 | |
1269 | 1317 | echo ' |
1270 | 1318 | </div><!-- .windowbg2 --> |
@@ -1311,8 +1359,7 @@ discard block |
||
1311 | 1359 | <p class="centertext"> |
1312 | 1360 | <strong>', $txt['admin_search_results_none'], '</strong> |
1313 | 1361 | </p>'; |
1314 | - } |
|
1315 | - else |
|
1362 | + } else |
|
1316 | 1363 | { |
1317 | 1364 | echo ' |
1318 | 1365 | <ol class="search_results">'; |
@@ -1339,9 +1386,10 @@ discard block |
||
1339 | 1386 | <li> |
1340 | 1387 | <a href="', $result['url'], '"><strong>', $result['name'], '</strong></a> [', isset($txt['admin_search_section_' . $result['type']]) ? $txt['admin_search_section_' . $result['type']] : $result['type'], ']'; |
1341 | 1388 | |
1342 | - if ($result['help']) |
|
1343 | - echo ' |
|
1389 | + if ($result['help']) { |
|
1390 | + echo ' |
|
1344 | 1391 | <p class="double_height">', $result['help'], '</p>'; |
1392 | + } |
|
1345 | 1393 | |
1346 | 1394 | echo ' |
1347 | 1395 | </li>'; |
@@ -1381,10 +1429,11 @@ discard block |
||
1381 | 1429 | <strong>', $txt['setup_verification_answer'], '</strong> |
1382 | 1430 | </dd>'; |
1383 | 1431 | |
1384 | - if (!empty($context['qa_by_lang'][$lang_id])) |
|
1385 | - foreach ($context['qa_by_lang'][$lang_id] as $q_id) |
|
1432 | + if (!empty($context['qa_by_lang'][$lang_id])) { |
|
1433 | + foreach ($context['qa_by_lang'][$lang_id] as $q_id) |
|
1386 | 1434 | { |
1387 | 1435 | $question = $context['question_answers'][$q_id]; |
1436 | + } |
|
1388 | 1437 | |
1389 | 1438 | echo ' |
1390 | 1439 | <dt> |
@@ -1392,9 +1441,10 @@ discard block |
||
1392 | 1441 | </dt> |
1393 | 1442 | <dd>'; |
1394 | 1443 | |
1395 | - foreach ($question['answers'] as $answer) |
|
1396 | - echo ' |
|
1444 | + foreach ($question['answers'] as $answer) { |
|
1445 | + echo ' |
|
1397 | 1446 | <input type="text" name="answer[', $lang_id, '][', $q_id, '][]" value="', $answer, '" size="50" class="verification_answer">'; |
1447 | + } |
|
1398 | 1448 | |
1399 | 1449 | echo ' |
1400 | 1450 | <div class="qa_add_answer"><a href="javascript:void(0);" onclick="return addAnswer(this);">[ ', $txt['setup_verification_add_answer'], ' ]</a></div> |
@@ -1433,11 +1483,12 @@ discard block |
||
1433 | 1483 | ', $txt['errors_found'], ': |
1434 | 1484 | <ul>'; |
1435 | 1485 | |
1436 | - foreach ($context['repair_errors'] as $error) |
|
1437 | - echo ' |
|
1486 | + foreach ($context['repair_errors'] as $error) { |
|
1487 | + echo ' |
|
1438 | 1488 | <li> |
1439 | 1489 | ', $error, ' |
1440 | 1490 | </li>'; |
1491 | + } |
|
1441 | 1492 | |
1442 | 1493 | echo ' |
1443 | 1494 | </ul> |
@@ -1447,15 +1498,14 @@ discard block |
||
1447 | 1498 | <p class="padding"> |
1448 | 1499 | <strong><a href="', $scripturl, '?action=admin;area=repairboards;fixErrors;', $context['session_var'], '=', $context['session_id'], '">', $txt['yes'], '</a> - <a href="', $scripturl, '?action=admin;area=maintain">', $txt['no'], '</a></strong> |
1449 | 1500 | </p>'; |
1450 | - } |
|
1451 | - else |
|
1452 | - echo ' |
|
1501 | + } else { |
|
1502 | + echo ' |
|
1453 | 1503 | <p>', $txt['maintain_no_errors'], '</p> |
1454 | 1504 | <p class="padding"> |
1455 | 1505 | <a href="', $scripturl, '?action=admin;area=maintain;sa=routine">', $txt['maintain_return'], '</a> |
1456 | 1506 | </p>'; |
1457 | - } |
|
1458 | - else |
|
1507 | + } |
|
1508 | + } else |
|
1459 | 1509 | { |
1460 | 1510 | if (!empty($context['redirect_to_recount'])) |
1461 | 1511 | { |
@@ -1467,8 +1517,7 @@ discard block |
||
1467 | 1517 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
1468 | 1518 | <input type="submit" name="recount" id="recount_now" value="', $txt['errors_recount_now'], '"> |
1469 | 1519 | </form>'; |
1470 | - } |
|
1471 | - else |
|
1520 | + } else |
|
1472 | 1521 | { |
1473 | 1522 | echo ' |
1474 | 1523 | <p>', $txt['errors_fixed'], '</p> |
@@ -1559,9 +1608,10 @@ discard block |
||
1559 | 1608 | <tr class="windowbg"> |
1560 | 1609 | <td class="equal_table">', $key, '</td>'; |
1561 | 1610 | |
1562 | - foreach ($setting as $key_lm => $value) |
|
1563 | - echo ' |
|
1611 | + foreach ($setting as $key_lm => $value) { |
|
1612 | + echo ' |
|
1564 | 1613 | <td class="equal_table">', $value, '</td>'; |
1614 | + } |
|
1565 | 1615 | |
1566 | 1616 | echo ' |
1567 | 1617 | </tr>'; |
@@ -1621,8 +1671,8 @@ discard block |
||
1621 | 1671 | { |
1622 | 1672 | global $context, $txt; |
1623 | 1673 | |
1624 | - if ($context['user']['is_admin']) |
|
1625 | - echo ' |
|
1674 | + if ($context['user']['is_admin']) { |
|
1675 | + echo ' |
|
1626 | 1676 | <span class="floatright admin_search"> |
1627 | 1677 | <span class="generic_icons filter centericon"></span> |
1628 | 1678 | <input type="search" name="search_term" placeholder="', $txt['admin_search'], '"> |
@@ -1633,6 +1683,7 @@ discard block |
||
1633 | 1683 | </select> |
1634 | 1684 | <input type="submit" name="search_go" id="search_go" value="', $txt['admin_search_go'], '" class="button"> |
1635 | 1685 | </span>'; |
1636 | -} |
|
1686 | + } |
|
1687 | + } |
|
1637 | 1688 | |
1638 | 1689 | ?> |
1639 | 1690 | \ No newline at end of file |
@@ -23,15 +23,15 @@ discard block |
||
23 | 23 | { |
24 | 24 | global $context, $txt; |
25 | 25 | |
26 | - if (!empty($context['simple_action'])) |
|
27 | - echo ' |
|
26 | + if (!empty($context['simple_action'])) { |
|
27 | + echo ' |
|
28 | 28 | <strong> |
29 | 29 | ', $context['error_title'], ' |
30 | 30 | </strong><br> |
31 | 31 | <div ', $context['error_code'], 'class="padding"> |
32 | 32 | ', $context['error_message'], ' |
33 | 33 | </div>'; |
34 | - else |
|
34 | + } else |
|
35 | 35 | { |
36 | 36 | echo ' |
37 | 37 | <div id="fatal_error"> |
@@ -85,21 +85,23 @@ discard block |
||
85 | 85 | |
86 | 86 | $error_types = array(); |
87 | 87 | |
88 | - foreach ($context['error_types'] as $type => $details) |
|
89 | - $error_types[] = ($details['is_selected'] ? '<img src="' . $settings['images_url'] . '/selected.png" alt=""> ' : '') . '<a href="' . $details['url'] . '" ' . ($details['is_selected'] ? 'style="font-weight: bold;"' : '') . ' title="' . $details['description'] . '">' . $details['label'] . '</a>'; |
|
88 | + foreach ($context['error_types'] as $type => $details) { |
|
89 | + $error_types[] = ($details['is_selected'] ? '<img src="' . $settings['images_url'] . '/selected.png" alt=""> ' : '') . '<a href="' . $details['url'] . '" ' . ($details['is_selected'] ? 'style="font-weight: bold;"' : '') . ' title="' . $details['description'] . '">' . $details['label'] . '</a>'; |
|
90 | + } |
|
90 | 91 | |
91 | 92 | echo ' |
92 | 93 | ', implode(' | ', $error_types), ' |
93 | 94 | </td> |
94 | 95 | </tr>'; |
95 | 96 | |
96 | - if ($context['has_filter']) |
|
97 | - echo ' |
|
97 | + if ($context['has_filter']) { |
|
98 | + echo ' |
|
98 | 99 | <tr> |
99 | 100 | <td colspan="3" class="windowbg"> |
100 | 101 | <strong>', $txt['applying_filter'], ':</strong> ', $context['filter']['entity'], ' ', $context['filter']['value']['html'], ' [<a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', '">', $txt['clear_filter'], '</a>] |
101 | 102 | </td> |
102 | 103 | </tr>'; |
104 | + } |
|
103 | 105 | |
104 | 106 | echo ' |
105 | 107 | <tr> |
@@ -110,11 +112,12 @@ discard block |
||
110 | 112 | </tr>'; |
111 | 113 | |
112 | 114 | // No errors, then show a message |
113 | - if (count($context['errors']) == 0) |
|
114 | - echo ' |
|
115 | + if (count($context['errors']) == 0) { |
|
116 | + echo ' |
|
115 | 117 | <tr class="windowbg"> |
116 | 118 | <td class="centertext" colspan="2">', $txt['errlog_no_entries'], '</td> |
117 | 119 | </tr>'; |
120 | + } |
|
118 | 121 | |
119 | 122 | // We have some errors, must be some mods installed :P |
120 | 123 | foreach ($context['errors'] as $error) |
@@ -128,16 +131,18 @@ discard block |
||
128 | 131 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? '' : ';desc', $context['has_filter'] ? $context['filter']['href'] : '', '" title="', $txt['reverse_direction'], '"><span class="generic_icons sort_' . $context['sort_direction'] . '"></span></a> |
129 | 132 | ', $error['time'], '<br>'; |
130 | 133 | |
131 | - if (!empty($error['member']['ip'])) |
|
132 | - echo ' |
|
134 | + if (!empty($error['member']['ip'])) { |
|
135 | + echo ' |
|
133 | 136 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=ip;value=', $error['member']['ip'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_ip'], '"><span class="generic_icons filter centericon"></span></a> |
134 | 137 | <strong><a href="', $scripturl, '?action=trackip;searchip=', $error['member']['ip'], '">', $error['member']['ip'], '</a></strong>'; |
138 | + } |
|
135 | 139 | |
136 | - if ($error['member']['session'] != '') |
|
137 | - echo ' |
|
140 | + if ($error['member']['session'] != '') { |
|
141 | + echo ' |
|
138 | 142 | <br> |
139 | 143 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=session;value=', $error['member']['session'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_session'], '"><span class="generic_icons filter centericon"></span></a> |
140 | 144 | ', $error['member']['session'], '<br>'; |
145 | + } |
|
141 | 146 | |
142 | 147 | echo ' |
143 | 148 | </div> |
@@ -152,12 +157,13 @@ discard block |
||
152 | 157 | <a href="', $error['url']['html'], '">', $error['url']['html'], '</a> |
153 | 158 | '; |
154 | 159 | |
155 | - if (!empty($error['file'])) |
|
156 | - echo ' |
|
160 | + if (!empty($error['file'])) { |
|
161 | + echo ' |
|
157 | 162 | <div> |
158 | 163 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=file;value=', $error['file']['search'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_file'], '">' |
159 | 164 | . ' <span class="generic_icons filter"></span></a> ', $error['file']['link'], ' (', $txt['line'], ' ', $error['file']['line'], ') |
160 | 165 | </div>'; |
166 | + } |
|
161 | 167 | |
162 | 168 | echo ' |
163 | 169 | </div> |
@@ -186,9 +192,10 @@ discard block |
||
186 | 192 | </div> |
187 | 193 | </div>'; |
188 | 194 | |
189 | - if ($context['sort_direction'] == 'down') |
|
190 | - echo ' |
|
195 | + if ($context['sort_direction'] == 'down') { |
|
196 | + echo ' |
|
191 | 197 | <input type="hidden" name="desc" value="1">'; |
198 | + } |
|
192 | 199 | |
193 | 200 | echo ' |
194 | 201 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -249,9 +256,10 @@ discard block |
||
249 | 256 | $context['error_message'], ' |
250 | 257 | </div>'; |
251 | 258 | |
252 | - if (!empty($context['back_link'])) |
|
253 | - echo ' |
|
259 | + if (!empty($context['back_link'])) { |
|
260 | + echo ' |
|
254 | 261 | <a class="button" href="', $scripturl, $context['back_link'], '">', $txt['back'], '</a>'; |
262 | + } |
|
255 | 263 | |
256 | 264 | echo ' |
257 | 265 | <span style="float: right; margin:.5em;"></span> |
@@ -288,25 +296,30 @@ discard block |
||
288 | 296 | <div class="windowbg noup"> |
289 | 297 | <ul class="padding">'; |
290 | 298 | |
291 | - if (!empty($context['error_info']['error_type'])) |
|
292 | - echo ' |
|
299 | + if (!empty($context['error_info']['error_type'])) { |
|
300 | + echo ' |
|
293 | 301 | <li>', $txt['error_type'], ': ', ucfirst($context['error_info']['error_type']), '</li>'; |
302 | + } |
|
294 | 303 | |
295 | - if (!empty($context['error_info']['message'])) |
|
296 | - echo ' |
|
304 | + if (!empty($context['error_info']['message'])) { |
|
305 | + echo ' |
|
297 | 306 | <li>', $txt['error_message'], ': ', $context['error_info']['message'], '</li>'; |
307 | + } |
|
298 | 308 | |
299 | - if (!empty($context['error_info']['file'])) |
|
300 | - echo ' |
|
309 | + if (!empty($context['error_info']['file'])) { |
|
310 | + echo ' |
|
301 | 311 | <li>', $txt['error_file'], ': ', $context['error_info']['file'], '</li>'; |
312 | + } |
|
302 | 313 | |
303 | - if (!empty($context['error_info']['line'])) |
|
304 | - echo ' |
|
314 | + if (!empty($context['error_info']['line'])) { |
|
315 | + echo ' |
|
305 | 316 | <li>', $txt['error_line'], ': ', $context['error_info']['line'], '</li>'; |
317 | + } |
|
306 | 318 | |
307 | - if (!empty($context['error_info']['url'])) |
|
308 | - echo ' |
|
319 | + if (!empty($context['error_info']['url'])) { |
|
320 | + echo ' |
|
309 | 321 | <li>', $txt['error_url'], ': ', $context['error_info']['url'], '</li>'; |
322 | + } |
|
310 | 323 | |
311 | 324 | |
312 | 325 | echo ' |