Completed
Push — release-2.1 ( f19596...e9b0d9 )
by Mathias
17s
created
Sources/ManageSettings.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -1334,7 +1334,7 @@  discard block
 block discarded – undo
1334 1334
 					'class' => 'centercol',
1335 1335
 				),
1336 1336
 				'data' => array(
1337
-					'function' => function ($rowData)
1337
+					'function' => function($rowData)
1338 1338
 					{
1339 1339
 						$isChecked = $rowData['disabled'] ? '' : ' checked';
1340 1340
 						$onClickHandler = $rowData['can_show_register'] ? sprintf(' onclick="document.getElementById(\'reg_%1$s\').disabled = !this.checked;"', $rowData['id']) : '';
@@ -1350,7 +1350,7 @@  discard block
 block discarded – undo
1350 1350
 					'class' => 'centercol',
1351 1351
 				),
1352 1352
 				'data' => array(
1353
-					'function' => function ($rowData)
1353
+					'function' => function($rowData)
1354 1354
 					{
1355 1355
 						$isChecked = $rowData['on_register'] && !$rowData['disabled'] ? ' checked' : '';
1356 1356
 						$isDisabled = $rowData['can_show_register'] ? '' : ' disabled';
@@ -1397,15 +1397,15 @@  discard block
 block discarded – undo
1397 1397
 					'value' => $txt['custom_profile_fieldorder'],
1398 1398
 				),
1399 1399
 				'data' => array(
1400
-					'function' => function ($rowData) use ($context, $txt, $scripturl)
1400
+					'function' => function($rowData) use ($context, $txt, $scripturl)
1401 1401
 					{
1402
-						$return = '<p class="centertext bold_text">'. $rowData['field_order'] .'<br>';
1402
+						$return = '<p class="centertext bold_text">' . $rowData['field_order'] . '<br>';
1403 1403
 
1404 1404
 						if ($rowData['field_order'] > 1)
1405
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_up'] .'"></span></a>';
1405
+							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="' . $txt['custom_edit_order_move'] . ' ' . $txt['custom_edit_order_up'] . '"></span></a>';
1406 1406
 
1407 1407
 						if ($rowData['field_order'] < $context['custFieldsMaxOrder'])
1408
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_down'] .'"></span></a>';
1408
+							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="' . $txt['custom_edit_order_move'] . ' ' . $txt['custom_edit_order_down'] . '"></span></a>';
1409 1409
 
1410 1410
 						$return .= '</p>';
1411 1411
 
@@ -1423,7 +1423,7 @@  discard block
 block discarded – undo
1423 1423
 					'value' => $txt['custom_profile_fieldname'],
1424 1424
 				),
1425 1425
 				'data' => array(
1426
-					'function' => function ($rowData) use ($scripturl)
1426
+					'function' => function($rowData) use ($scripturl)
1427 1427
 					{
1428 1428
 						return sprintf('<a href="%1$s?action=admin;area=featuresettings;sa=profileedit;fid=%2$d">%3$s</a><div class="smalltext">%4$s</div>', $scripturl, $rowData['id_field'], $rowData['field_name'], $rowData['field_desc']);
1429 1429
 					},
@@ -1439,7 +1439,7 @@  discard block
 block discarded – undo
1439 1439
 					'value' => $txt['custom_profile_fieldtype'],
1440 1440
 				),
1441 1441
 				'data' => array(
1442
-					'function' => function ($rowData) use ($txt)
1442
+					'function' => function($rowData) use ($txt)
1443 1443
 					{
1444 1444
 						$textKey = sprintf('custom_profile_type_%1$s', $rowData['field_type']);
1445 1445
 						return isset($txt[$textKey]) ? $txt[$textKey] : $textKey;
@@ -1457,7 +1457,7 @@  discard block
 block discarded – undo
1457 1457
 					'value' => $txt['custom_profile_active'],
1458 1458
 				),
1459 1459
 				'data' => array(
1460
-					'function' => function ($rowData) use ($txt)
1460
+					'function' => function($rowData) use ($txt)
1461 1461
 					{
1462 1462
 						return $rowData['active'] ? $txt['yes'] : $txt['no'];
1463 1463
 					},
@@ -1474,7 +1474,7 @@  discard block
 block discarded – undo
1474 1474
 					'value' => $txt['custom_profile_placement'],
1475 1475
 				),
1476 1476
 				'data' => array(
1477
-					'function' => function ($rowData)
1477
+					'function' => function($rowData)
1478 1478
 					{
1479 1479
 						global $txt, $context;
1480 1480
 
@@ -1709,7 +1709,7 @@  discard block
 block discarded – undo
1709 1709
 			redirectexit('action=admin;area=featuresettings;sa=profile'); // @todo implement an error handler
1710 1710
 
1711 1711
 		// All good, proceed.
1712
-		$smcFunc['db_query']('','
1712
+		$smcFunc['db_query']('', '
1713 1713
 			UPDATE {db_prefix}custom_fields
1714 1714
 			SET field_order = {int:old_order}
1715 1715
 			WHERE field_order = {int:new_order}',
@@ -1718,7 +1718,7 @@  discard block
 block discarded – undo
1718 1718
 				'old_order' => $context['field']['order'],
1719 1719
 			)
1720 1720
 		);
1721
-		$smcFunc['db_query']('','
1721
+		$smcFunc['db_query']('', '
1722 1722
 			UPDATE {db_prefix}custom_fields
1723 1723
 			SET field_order = {int:new_order}
1724 1724
 			WHERE id_field = {int:id_field}',
@@ -1820,7 +1820,7 @@  discard block
 block discarded – undo
1820 1820
 			$smcFunc['db_free_result']($request);
1821 1821
 
1822 1822
 			$unique = false;
1823
-			for ($i = 0; !$unique && $i < 9; $i ++)
1823
+			for ($i = 0; !$unique && $i < 9; $i++)
1824 1824
 			{
1825 1825
 				if (!in_array($col_name, $current_fields))
1826 1826
 					$unique = true;
@@ -1993,7 +1993,7 @@  discard block
 block discarded – undo
1993 1993
 		);
1994 1994
 
1995 1995
 		// Re-arrange the order.
1996
-		$smcFunc['db_query']('','
1996
+		$smcFunc['db_query']('', '
1997 1997
 			UPDATE {db_prefix}custom_fields
1998 1998
 			SET field_order = field_order - 1
1999 1999
 			WHERE field_order > {int:current_order}',
@@ -2257,7 +2257,7 @@  discard block
 block discarded – undo
2257 2257
 	$context['token_check'] = 'noti-admin';
2258 2258
 
2259 2259
 	// Specify our action since we'll want to post back here instead of the profile
2260
-	$context['action'] = 'action=admin;area=featuresettings;sa=alerts;'. $context['session_var'] .'='. $context['session_id'];
2260
+	$context['action'] = 'action=admin;area=featuresettings;sa=alerts;' . $context['session_var'] . '=' . $context['session_id'];
2261 2261
 
2262 2262
 	loadTemplate('Profile');
2263 2263
 	loadLanguage('Profile');
Please login to merge, or discard this patch.
Braces   +273 added lines, -199 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * This function makes sure the requested subaction does exists, if it doesn't, it sets a default action or.
@@ -206,16 +207,18 @@  discard block
 block discarded – undo
206 207
 	{
207 208
 		$all_zones = timezone_identifiers_list();
208 209
 		// Make sure we set the value to the same as the printed value.
209
-		foreach ($all_zones as $zone)
210
-			$config_vars['default_timezone'][2][$zone] = $zone;
210
+		foreach ($all_zones as $zone) {
211
+					$config_vars['default_timezone'][2][$zone] = $zone;
212
+		}
213
+	} else {
214
+			unset($config_vars['default_timezone']);
211 215
 	}
212
-	else
213
-		unset($config_vars['default_timezone']);
214 216
 
215 217
 	call_integration_hook('integrate_modify_basic_settings', array(&$config_vars));
216 218
 
217
-	if ($return_config)
218
-		return $config_vars;
219
+	if ($return_config) {
220
+			return $config_vars;
221
+	}
219 222
 
220 223
 	// Saving?
221 224
 	if (isset($_GET['save']))
@@ -223,8 +226,9 @@  discard block
 block discarded – undo
223 226
 		checkSession();
224 227
 
225 228
 		// Prevent absurd boundaries here - make it a day tops.
226
-		if (isset($_POST['lastActive']))
227
-			$_POST['lastActive'] = min((int) $_POST['lastActive'], 1440);
229
+		if (isset($_POST['lastActive'])) {
230
+					$_POST['lastActive'] = min((int) $_POST['lastActive'], 1440);
231
+		}
228 232
 
229 233
 		call_integration_hook('integrate_save_basic_settings');
230 234
 
@@ -269,8 +273,9 @@  discard block
 block discarded – undo
269 273
 
270 274
 	call_integration_hook('integrate_modify_bbc_settings', array(&$config_vars));
271 275
 
272
-	if ($return_config)
273
-		return $config_vars;
276
+	if ($return_config) {
277
+			return $config_vars;
278
+	}
274 279
 
275 280
 	// Setup the template.
276 281
 	require_once($sourcedir . '/ManageServer.php');
@@ -287,13 +292,15 @@  discard block
 block discarded – undo
287 292
 
288 293
 		// Clean up the tags.
289 294
 		$bbcTags = array();
290
-		foreach (parse_bbc(false) as $tag)
291
-			$bbcTags[] = $tag['tag'];
295
+		foreach (parse_bbc(false) as $tag) {
296
+					$bbcTags[] = $tag['tag'];
297
+		}
292 298
 
293
-		if (!isset($_POST['disabledBBC_enabledTags']))
294
-			$_POST['disabledBBC_enabledTags'] = array();
295
-		elseif (!is_array($_POST['disabledBBC_enabledTags']))
296
-			$_POST['disabledBBC_enabledTags'] = array($_POST['disabledBBC_enabledTags']);
299
+		if (!isset($_POST['disabledBBC_enabledTags'])) {
300
+					$_POST['disabledBBC_enabledTags'] = array();
301
+		} elseif (!is_array($_POST['disabledBBC_enabledTags'])) {
302
+					$_POST['disabledBBC_enabledTags'] = array($_POST['disabledBBC_enabledTags']);
303
+		}
297 304
 		// Work out what is actually disabled!
298 305
 		$_POST['disabledBBC'] = implode(',', array_diff($bbcTags, $_POST['disabledBBC_enabledTags']));
299 306
 
@@ -337,8 +344,9 @@  discard block
 block discarded – undo
337 344
 
338 345
 	call_integration_hook('integrate_layout_settings', array(&$config_vars));
339 346
 
340
-	if ($return_config)
341
-		return $config_vars;
347
+	if ($return_config) {
348
+			return $config_vars;
349
+	}
342 350
 
343 351
 	// Saving?
344 352
 	if (isset($_GET['save']))
@@ -379,8 +387,9 @@  discard block
 block discarded – undo
379 387
 
380 388
 	call_integration_hook('integrate_likes_settings', array(&$config_vars));
381 389
 
382
-	if ($return_config)
383
-		return $config_vars;
390
+	if ($return_config) {
391
+			return $config_vars;
392
+	}
384 393
 
385 394
 	// Saving?
386 395
 	if (isset($_GET['save']))
@@ -418,8 +427,9 @@  discard block
 block discarded – undo
418 427
 
419 428
 	call_integration_hook('integrate_mentions_settings', array(&$config_vars));
420 429
 
421
-	if ($return_config)
422
-		return $config_vars;
430
+	if ($return_config) {
431
+			return $config_vars;
432
+	}
423 433
 
424 434
 	// Saving?
425 435
 	if (isset($_GET['save']))
@@ -463,8 +473,8 @@  discard block
 block discarded – undo
463 473
 			'enable' => array('check', 'warning_enable'),
464 474
 	);
465 475
 
466
-	if (!empty($modSettings['warning_settings']) && $currently_enabled)
467
-		$config_vars += array(
476
+	if (!empty($modSettings['warning_settings']) && $currently_enabled) {
477
+			$config_vars += array(
468 478
 			'',
469 479
 				array('int', 'warning_watch', 'subtext' => $txt['setting_warning_watch_note'] . ' ' . $txt['zero_to_disable']),
470 480
 				'moderate' => array('int', 'warning_moderate', 'subtext' => $txt['setting_warning_moderate_note'] . ' ' . $txt['zero_to_disable']),
@@ -473,15 +483,18 @@  discard block
 block discarded – undo
473 483
 				'rem2' => array('int', 'warning_decrement', 'subtext' => $txt['setting_warning_decrement_note'] . ' ' . $txt['zero_to_disable']),
474 484
 				array('permissions', 'view_warning'),
475 485
 		);
486
+	}
476 487
 
477 488
 	call_integration_hook('integrate_warning_settings', array(&$config_vars));
478 489
 
479
-	if ($return_config)
480
-		return $config_vars;
490
+	if ($return_config) {
491
+			return $config_vars;
492
+	}
481 493
 
482 494
 	// Cannot use moderation if post moderation is not enabled.
483
-	if (!$modSettings['postmod_active'])
484
-		unset($config_vars['moderate']);
495
+	if (!$modSettings['postmod_active']) {
496
+			unset($config_vars['moderate']);
497
+	}
485 498
 
486 499
 	// Will need the utility functions from here.
487 500
 	require_once($sourcedir . '/ManageServer.php');
@@ -506,16 +519,16 @@  discard block
 block discarded – undo
506 519
 				'warning_watch' => 10,
507 520
 				'warning_mute' => 60,
508 521
 			);
509
-			if ($modSettings['postmod_active'])
510
-				$vars['warning_moderate'] = 35;
522
+			if ($modSettings['postmod_active']) {
523
+							$vars['warning_moderate'] = 35;
524
+			}
511 525
 
512 526
 			foreach ($vars as $var => $value)
513 527
 			{
514 528
 				$config_vars[] = array('int', $var);
515 529
 				$_POST[$var] = $value;
516 530
 			}
517
-		}
518
-		else
531
+		} else
519 532
 		{
520 533
 			$_POST['warning_watch'] = min($_POST['warning_watch'], 100);
521 534
 			$_POST['warning_moderate'] = $modSettings['postmod_active'] ? min($_POST['warning_moderate'], 100) : 0;
@@ -603,8 +616,9 @@  discard block
 block discarded – undo
603 616
 
604 617
 	call_integration_hook('integrate_spam_settings', array(&$config_vars));
605 618
 
606
-	if ($return_config)
607
-		return $config_vars;
619
+	if ($return_config) {
620
+			return $config_vars;
621
+	}
608 622
 
609 623
 	// You need to be an admin to edit settings!
610 624
 	isAllowedTo('admin_forum');
@@ -638,8 +652,9 @@  discard block
 block discarded – undo
638 652
 
639 653
 	if (empty($context['qa_by_lang'][strtr($language, array('-utf8' => ''))]) && !empty($context['question_answers']))
640 654
 	{
641
-		if (empty($context['settings_insert_above']))
642
-			$context['settings_insert_above'] = '';
655
+		if (empty($context['settings_insert_above'])) {
656
+					$context['settings_insert_above'] = '';
657
+		}
643 658
 
644 659
 		$context['settings_insert_above'] .= '<div class="noticebox">' . sprintf($txt['question_not_defined'], $context['languages'][$language]['name']) . '</div>';
645 660
 	}
@@ -682,8 +697,9 @@  discard block
 block discarded – undo
682 697
 		$_POST['pm_spam_settings'] = (int) $_POST['max_pm_recipients'] . ',' . (int) $_POST['pm_posts_verification'] . ',' . (int) $_POST['pm_posts_per_hour'];
683 698
 
684 699
 		// Hack in guest requiring verification!
685
-		if (empty($_POST['posts_require_captcha']) && !empty($_POST['guests_require_captcha']))
686
-			$_POST['posts_require_captcha'] = -1;
700
+		if (empty($_POST['posts_require_captcha']) && !empty($_POST['guests_require_captcha'])) {
701
+					$_POST['posts_require_captcha'] = -1;
702
+		}
687 703
 
688 704
 		$save_vars = $config_vars;
689 705
 		unset($save_vars['pm1'], $save_vars['pm2'], $save_vars['pm3'], $save_vars['guest_verify']);
@@ -700,14 +716,16 @@  discard block
 block discarded – undo
700 716
 		foreach ($context['qa_languages'] as $lang_id => $dummy)
701 717
 		{
702 718
 			// If we had some questions for this language before, but don't now, delete everything from that language.
703
-			if ((!isset($_POST['question'][$lang_id]) || !is_array($_POST['question'][$lang_id])) && !empty($context['qa_by_lang'][$lang_id]))
704
-				$changes['delete'] = array_merge($questions['delete'], $context['qa_by_lang'][$lang_id]);
719
+			if ((!isset($_POST['question'][$lang_id]) || !is_array($_POST['question'][$lang_id])) && !empty($context['qa_by_lang'][$lang_id])) {
720
+							$changes['delete'] = array_merge($questions['delete'], $context['qa_by_lang'][$lang_id]);
721
+			}
705 722
 
706 723
 			// Now step through and see if any existing questions no longer exist.
707
-			if (!empty($context['qa_by_lang'][$lang_id]))
708
-				foreach ($context['qa_by_lang'][$lang_id] as $q_id)
724
+			if (!empty($context['qa_by_lang'][$lang_id])) {
725
+							foreach ($context['qa_by_lang'][$lang_id] as $q_id)
709 726
 					if (empty($_POST['question'][$lang_id][$q_id]))
710 727
 						$changes['delete'][] = $q_id;
728
+			}
711 729
 
712 730
 			// Now let's see if there are new questions or ones that need updating.
713 731
 			if (isset($_POST['question'][$lang_id]))
@@ -716,14 +734,16 @@  discard block
 block discarded – undo
716 734
 				{
717 735
 					// Ignore junky ids.
718 736
 					$q_id = (int) $q_id;
719
-					if ($q_id <= 0)
720
-						continue;
737
+					if ($q_id <= 0) {
738
+											continue;
739
+					}
721 740
 
722 741
 					// Check the question isn't empty (because they want to delete it?)
723 742
 					if (empty($question) || trim($question) == '')
724 743
 					{
725
-						if (isset($context['question_answers'][$q_id]))
726
-							$changes['delete'][] = $q_id;
744
+						if (isset($context['question_answers'][$q_id])) {
745
+													$changes['delete'][] = $q_id;
746
+						}
727 747
 						continue;
728 748
 					}
729 749
 					$question = $smcFunc['htmlspecialchars'](trim($question));
@@ -731,19 +751,22 @@  discard block
 block discarded – undo
731 751
 					// Get the answers. Firstly check there actually might be some.
732 752
 					if (!isset($_POST['answer'][$lang_id][$q_id]) || !is_array($_POST['answer'][$lang_id][$q_id]))
733 753
 					{
734
-						if (isset($context['question_answers'][$q_id]))
735
-							$changes['delete'][] = $q_id;
754
+						if (isset($context['question_answers'][$q_id])) {
755
+													$changes['delete'][] = $q_id;
756
+						}
736 757
 						continue;
737 758
 					}
738 759
 					// Now get them and check that they might be viable.
739 760
 					$answers = array();
740
-					foreach ($_POST['answer'][$lang_id][$q_id] as $answer)
741
-						if (!empty($answer) && trim($answer) !== '')
761
+					foreach ($_POST['answer'][$lang_id][$q_id] as $answer) {
762
+											if (!empty($answer) && trim($answer) !== '')
742 763
 							$answers[] = $smcFunc['htmlspecialchars'](trim($answer));
764
+					}
743 765
 					if (empty($answers))
744 766
 					{
745
-						if (isset($context['question_answers'][$q_id]))
746
-							$changes['delete'][] = $q_id;
767
+						if (isset($context['question_answers'][$q_id])) {
768
+													$changes['delete'][] = $q_id;
769
+						}
747 770
 						continue;
748 771
 					}
749 772
 					$answers = $smcFunc['json_encode']($answers);
@@ -753,16 +776,17 @@  discard block
 block discarded – undo
753 776
 					{
754 777
 						// New question. Now, we don't want to randomly consume ids, so we'll set those, rather than trusting the browser's supplied ids.
755 778
 						$changes['insert'][] = array($lang_id, $question, $answers);
756
-					}
757
-					else
779
+					} else
758 780
 					{
759 781
 						// It's an existing question. Let's see what's changed, if anything.
760
-						if ($lang_id != $context['question_answers'][$q_id]['lngfile'] || $question != $context['question_answers'][$q_id]['question'] || $answers != $context['question_answers'][$q_id]['answers'])
761
-							$changes['replace'][$q_id] = array('lngfile' => $lang_id, 'question' => $question, 'answers' => $answers);
782
+						if ($lang_id != $context['question_answers'][$q_id]['lngfile'] || $question != $context['question_answers'][$q_id]['question'] || $answers != $context['question_answers'][$q_id]['answers']) {
783
+													$changes['replace'][$q_id] = array('lngfile' => $lang_id, 'question' => $question, 'answers' => $answers);
784
+						}
762 785
 					}
763 786
 
764
-					if (!isset($qs_per_lang[$lang_id]))
765
-						$qs_per_lang[$lang_id] = 0;
787
+					if (!isset($qs_per_lang[$lang_id])) {
788
+											$qs_per_lang[$lang_id] = 0;
789
+					}
766 790
 					$qs_per_lang[$lang_id]++;
767 791
 				}
768 792
 			}
@@ -812,8 +836,9 @@  discard block
 block discarded – undo
812 836
 
813 837
 		// Lastly, the count of messages needs to be no more than the lowest number of questions for any one language.
814 838
 		$count_questions = empty($qs_per_lang) ? 0 : min($qs_per_lang);
815
-		if (empty($count_questions) || $_POST['qa_verification_number'] > $count_questions)
816
-			$_POST['qa_verification_number'] = $count_questions;
839
+		if (empty($count_questions) || $_POST['qa_verification_number'] > $count_questions) {
840
+					$_POST['qa_verification_number'] = $count_questions;
841
+		}
817 842
 
818 843
 		call_integration_hook('integrate_save_spam_settings', array(&$save_vars));
819 844
 
@@ -828,24 +853,27 @@  discard block
 block discarded – undo
828 853
 
829 854
 	$character_range = array_merge(range('A', 'H'), array('K', 'M', 'N', 'P', 'R'), range('T', 'Y'));
830 855
 	$_SESSION['visual_verification_code'] = '';
831
-	for ($i = 0; $i < 6; $i++)
832
-		$_SESSION['visual_verification_code'] .= $character_range[array_rand($character_range)];
856
+	for ($i = 0; $i < 6; $i++) {
857
+			$_SESSION['visual_verification_code'] .= $character_range[array_rand($character_range)];
858
+	}
833 859
 
834 860
 	// Some javascript for CAPTCHA.
835 861
 	$context['settings_post_javascript'] = '';
836
-	if ($context['use_graphic_library'])
837
-		$context['settings_post_javascript'] .= '
862
+	if ($context['use_graphic_library']) {
863
+			$context['settings_post_javascript'] .= '
838 864
 		function refreshImages()
839 865
 		{
840 866
 			var imageType = document.getElementById(\'visual_verification_type\').value;
841 867
 			document.getElementById(\'verification_image\').src = \'' . $context['verification_image_href'] . ';type=\' + imageType;
842 868
 		}';
869
+	}
843 870
 
844 871
 	// Show the image itself, or text saying we can't.
845
-	if ($context['use_graphic_library'])
846
-		$config_vars['vv']['postinput'] = '<br><img src="' . $context['verification_image_href'] . ';type=' . (empty($modSettings['visual_verification_type']) ? 0 : $modSettings['visual_verification_type']) . '" alt="' . $txt['setting_image_verification_sample'] . '" id="verification_image"><br>';
847
-	else
848
-		$config_vars['vv']['postinput'] = '<br><span class="smalltext">' . $txt['setting_image_verification_nogd'] . '</span>';
872
+	if ($context['use_graphic_library']) {
873
+			$config_vars['vv']['postinput'] = '<br><img src="' . $context['verification_image_href'] . ';type=' . (empty($modSettings['visual_verification_type']) ? 0 : $modSettings['visual_verification_type']) . '" alt="' . $txt['setting_image_verification_sample'] . '" id="verification_image"><br>';
874
+	} else {
875
+			$config_vars['vv']['postinput'] = '<br><span class="smalltext">' . $txt['setting_image_verification_nogd'] . '</span>';
876
+	}
849 877
 
850 878
 	// Hack for PM spam settings.
851 879
 	list ($modSettings['max_pm_recipients'], $modSettings['pm_posts_verification'], $modSettings['pm_posts_per_hour']) = explode(',', $modSettings['pm_spam_settings']);
@@ -855,9 +883,10 @@  discard block
 block discarded – undo
855 883
 	$modSettings['posts_require_captcha'] = !isset($modSettings['posts_require_captcha']) || $modSettings['posts_require_captcha'] == -1 ? 0 : $modSettings['posts_require_captcha'];
856 884
 
857 885
 	// Some minor javascript for the guest post setting.
858
-	if ($modSettings['posts_require_captcha'])
859
-		$context['settings_post_javascript'] .= '
886
+	if ($modSettings['posts_require_captcha']) {
887
+			$context['settings_post_javascript'] .= '
860 888
 		document.getElementById(\'guests_require_captcha\').disabled = true;';
889
+	}
861 890
 
862 891
 	// And everything else.
863 892
 	$context['post_url'] = $scripturl . '?action=admin;area=antispam;save';
@@ -904,8 +933,9 @@  discard block
 block discarded – undo
904 933
 
905 934
 	call_integration_hook('integrate_signature_settings', array(&$config_vars));
906 935
 
907
-	if ($return_config)
908
-		return $config_vars;
936
+	if ($return_config) {
937
+			return $config_vars;
938
+	}
909 939
 
910 940
 	// Setup the template.
911 941
 	$context['page_title'] = $txt['signature_settings'];
@@ -960,8 +990,9 @@  discard block
 block discarded – undo
960 990
 				$sig = strtr($row['signature'], array('<br>' => "\n"));
961 991
 
962 992
 				// Max characters...
963
-				if (!empty($sig_limits[1]))
964
-					$sig = $smcFunc['substr']($sig, 0, $sig_limits[1]);
993
+				if (!empty($sig_limits[1])) {
994
+									$sig = $smcFunc['substr']($sig, 0, $sig_limits[1]);
995
+				}
965 996
 				// Max lines...
966 997
 				if (!empty($sig_limits[2]))
967 998
 				{
@@ -971,8 +1002,9 @@  discard block
 block discarded – undo
971 1002
 						if ($sig[$i] == "\n")
972 1003
 						{
973 1004
 							$count++;
974
-							if ($count >= $sig_limits[2])
975
-								$sig = substr($sig, 0, $i) . strtr(substr($sig, $i), array("\n" => ' '));
1005
+							if ($count >= $sig_limits[2]) {
1006
+															$sig = substr($sig, 0, $i) . strtr(substr($sig, $i), array("\n" => ' '));
1007
+							}
976 1008
 						}
977 1009
 					}
978 1010
 				}
@@ -983,17 +1015,19 @@  discard block
 block discarded – undo
983 1015
 					{
984 1016
 						$limit_broke = 0;
985 1017
 						// Attempt to allow all sizes of abuse, so to speak.
986
-						if ($matches[2][$ind] == 'px' && $size > $sig_limits[7])
987
-							$limit_broke = $sig_limits[7] . 'px';
988
-						elseif ($matches[2][$ind] == 'pt' && $size > ($sig_limits[7] * 0.75))
989
-							$limit_broke = ((int) $sig_limits[7] * 0.75) . 'pt';
990
-						elseif ($matches[2][$ind] == 'em' && $size > ((float) $sig_limits[7] / 16))
991
-							$limit_broke = ((float) $sig_limits[7] / 16) . 'em';
992
-						elseif ($matches[2][$ind] != 'px' && $matches[2][$ind] != 'pt' && $matches[2][$ind] != 'em' && $sig_limits[7] < 18)
993
-							$limit_broke = 'large';
994
-
995
-						if ($limit_broke)
996
-							$sig = str_replace($matches[0][$ind], '[size=' . $sig_limits[7] . 'px', $sig);
1018
+						if ($matches[2][$ind] == 'px' && $size > $sig_limits[7]) {
1019
+													$limit_broke = $sig_limits[7] . 'px';
1020
+						} elseif ($matches[2][$ind] == 'pt' && $size > ($sig_limits[7] * 0.75)) {
1021
+													$limit_broke = ((int) $sig_limits[7] * 0.75) . 'pt';
1022
+						} elseif ($matches[2][$ind] == 'em' && $size > ((float) $sig_limits[7] / 16)) {
1023
+													$limit_broke = ((float) $sig_limits[7] / 16) . 'em';
1024
+						} elseif ($matches[2][$ind] != 'px' && $matches[2][$ind] != 'pt' && $matches[2][$ind] != 'em' && $sig_limits[7] < 18) {
1025
+													$limit_broke = 'large';
1026
+						}
1027
+
1028
+						if ($limit_broke) {
1029
+													$sig = str_replace($matches[0][$ind], '[size=' . $sig_limits[7] . 'px', $sig);
1030
+						}
997 1031
 					}
998 1032
 				}
999 1033
 
@@ -1049,32 +1083,34 @@  discard block
 block discarded – undo
1049 1083
 											$img_offset = false;
1050 1084
 										}
1051 1085
 									}
1086
+								} else {
1087
+																	$replaces[$image] = '';
1052 1088
 								}
1053
-								else
1054
-									$replaces[$image] = '';
1055 1089
 
1056 1090
 								continue;
1057 1091
 							}
1058 1092
 
1059 1093
 							// Does it have predefined restraints? Width first.
1060
-							if ($matches[6][$key])
1061
-								$matches[2][$key] = $matches[6][$key];
1094
+							if ($matches[6][$key]) {
1095
+															$matches[2][$key] = $matches[6][$key];
1096
+							}
1062 1097
 							if ($matches[2][$key] && $sig_limits[5] && $matches[2][$key] > $sig_limits[5])
1063 1098
 							{
1064 1099
 								$width = $sig_limits[5];
1065 1100
 								$matches[4][$key] = $matches[4][$key] * ($width / $matches[2][$key]);
1101
+							} elseif ($matches[2][$key]) {
1102
+															$width = $matches[2][$key];
1066 1103
 							}
1067
-							elseif ($matches[2][$key])
1068
-								$width = $matches[2][$key];
1069 1104
 							// ... and height.
1070 1105
 							if ($matches[4][$key] && $sig_limits[6] && $matches[4][$key] > $sig_limits[6])
1071 1106
 							{
1072 1107
 								$height = $sig_limits[6];
1073
-								if ($width != -1)
1074
-									$width = $width * ($height / $matches[4][$key]);
1108
+								if ($width != -1) {
1109
+																	$width = $width * ($height / $matches[4][$key]);
1110
+								}
1111
+							} elseif ($matches[4][$key]) {
1112
+															$height = $matches[4][$key];
1075 1113
 							}
1076
-							elseif ($matches[4][$key])
1077
-								$height = $matches[4][$key];
1078 1114
 
1079 1115
 							// If the dimensions are still not fixed - we need to check the actual image.
1080 1116
 							if (($width == -1 && $sig_limits[5]) || ($height == -1 && $sig_limits[6]))
@@ -1092,12 +1128,13 @@  discard block
 block discarded – undo
1092 1128
 									if ($sizes[1] > $sig_limits[6] && $sig_limits[6])
1093 1129
 									{
1094 1130
 										$height = $sig_limits[6];
1095
-										if ($width == -1)
1096
-											$width = $sizes[0];
1131
+										if ($width == -1) {
1132
+																					$width = $sizes[0];
1133
+										}
1097 1134
 										$width = $width * ($height / $sizes[1]);
1135
+									} elseif ($width != -1) {
1136
+																			$height = $sizes[1];
1098 1137
 									}
1099
-									elseif ($width != -1)
1100
-										$height = $sizes[1];
1101 1138
 								}
1102 1139
 							}
1103 1140
 
@@ -1110,8 +1147,9 @@  discard block
 block discarded – undo
1110 1147
 							// Record that we got one.
1111 1148
 							$image_count_holder[$image] = isset($image_count_holder[$image]) ? $image_count_holder[$image] + 1 : 1;
1112 1149
 						}
1113
-						if (!empty($replaces))
1114
-							$sig = str_replace(array_keys($replaces), array_values($replaces), $sig);
1150
+						if (!empty($replaces)) {
1151
+													$sig = str_replace(array_keys($replaces), array_values($replaces), $sig);
1152
+						}
1115 1153
 					}
1116 1154
 				}
1117 1155
 				// Try to fix disabled tags.
@@ -1123,18 +1161,20 @@  discard block
 block discarded – undo
1123 1161
 
1124 1162
 				$sig = strtr($sig, array("\n" => '<br>'));
1125 1163
 				call_integration_hook('integrate_apply_signature_settings', array(&$sig, $sig_limits, $disabledTags));
1126
-				if ($sig != $row['signature'])
1127
-					$changes[$row['id_member']] = $sig;
1164
+				if ($sig != $row['signature']) {
1165
+									$changes[$row['id_member']] = $sig;
1166
+				}
1167
+			}
1168
+			if ($smcFunc['db_num_rows']($request) == 0) {
1169
+							$done = true;
1128 1170
 			}
1129
-			if ($smcFunc['db_num_rows']($request) == 0)
1130
-				$done = true;
1131 1171
 			$smcFunc['db_free_result']($request);
1132 1172
 
1133 1173
 			// Do we need to delete what we have?
1134 1174
 			if (!empty($changes))
1135 1175
 			{
1136
-				foreach ($changes as $id => $sig)
1137
-					$smcFunc['db_query']('', '
1176
+				foreach ($changes as $id => $sig) {
1177
+									$smcFunc['db_query']('', '
1138 1178
 						UPDATE {db_prefix}members
1139 1179
 						SET signature = {string:signature}
1140 1180
 						WHERE id_member = {int:id_member}',
@@ -1143,11 +1183,13 @@  discard block
 block discarded – undo
1143 1183
 							'signature' => $sig,
1144 1184
 						)
1145 1185
 					);
1186
+				}
1146 1187
 			}
1147 1188
 
1148 1189
 			$_GET['step'] += 50;
1149
-			if (!$done)
1150
-				pauseSignatureApplySettings();
1190
+			if (!$done) {
1191
+							pauseSignatureApplySettings();
1192
+			}
1151 1193
 		}
1152 1194
 		$settings_applied = true;
1153 1195
 	}
@@ -1165,8 +1207,9 @@  discard block
 block discarded – undo
1165 1207
 	);
1166 1208
 
1167 1209
 	// Temporarily make each setting a modSetting!
1168
-	foreach ($context['signature_settings'] as $key => $value)
1169
-		$modSettings['signature_' . $key] = $value;
1210
+	foreach ($context['signature_settings'] as $key => $value) {
1211
+			$modSettings['signature_' . $key] = $value;
1212
+	}
1170 1213
 
1171 1214
 	// Make sure we check the right tags!
1172 1215
 	$modSettings['bbc_disabled_signature_bbc'] = $disabledTags;
@@ -1178,23 +1221,26 @@  discard block
 block discarded – undo
1178 1221
 
1179 1222
 		// Clean up the tag stuff!
1180 1223
 		$bbcTags = array();
1181
-		foreach (parse_bbc(false) as $tag)
1182
-			$bbcTags[] = $tag['tag'];
1224
+		foreach (parse_bbc(false) as $tag) {
1225
+					$bbcTags[] = $tag['tag'];
1226
+		}
1183 1227
 
1184
-		if (!isset($_POST['signature_bbc_enabledTags']))
1185
-			$_POST['signature_bbc_enabledTags'] = array();
1186
-		elseif (!is_array($_POST['signature_bbc_enabledTags']))
1187
-			$_POST['signature_bbc_enabledTags'] = array($_POST['signature_bbc_enabledTags']);
1228
+		if (!isset($_POST['signature_bbc_enabledTags'])) {
1229
+					$_POST['signature_bbc_enabledTags'] = array();
1230
+		} elseif (!is_array($_POST['signature_bbc_enabledTags'])) {
1231
+					$_POST['signature_bbc_enabledTags'] = array($_POST['signature_bbc_enabledTags']);
1232
+		}
1188 1233
 
1189 1234
 		$sig_limits = array();
1190 1235
 		foreach ($context['signature_settings'] as $key => $value)
1191 1236
 		{
1192
-			if ($key == 'allow_smileys')
1193
-				continue;
1194
-			elseif ($key == 'max_smileys' && empty($_POST['signature_allow_smileys']))
1195
-				$sig_limits[] = -1;
1196
-			else
1197
-				$sig_limits[] = !empty($_POST['signature_' . $key]) ? max(1, (int) $_POST['signature_' . $key]) : 0;
1237
+			if ($key == 'allow_smileys') {
1238
+							continue;
1239
+			} elseif ($key == 'max_smileys' && empty($_POST['signature_allow_smileys'])) {
1240
+							$sig_limits[] = -1;
1241
+			} else {
1242
+							$sig_limits[] = !empty($_POST['signature_' . $key]) ? max(1, (int) $_POST['signature_' . $key]) : 0;
1243
+			}
1198 1244
 		}
1199 1245
 
1200 1246
 		call_integration_hook('integrate_save_signature_settings', array(&$sig_limits, &$bbcTags));
@@ -1227,12 +1273,14 @@  discard block
 block discarded – undo
1227 1273
 
1228 1274
 	// Try get more time...
1229 1275
 	@set_time_limit(600);
1230
-	if (function_exists('apache_reset_timeout'))
1231
-		@apache_reset_timeout();
1276
+	if (function_exists('apache_reset_timeout')) {
1277
+			@apache_reset_timeout();
1278
+	}
1232 1279
 
1233 1280
 	// Have we exhausted all the time we allowed?
1234
-	if (time() - array_sum(explode(' ', $sig_start)) < 3)
1235
-		return;
1281
+	if (time() - array_sum(explode(' ', $sig_start)) < 3) {
1282
+			return;
1283
+	}
1236 1284
 
1237 1285
 	$context['continue_get_data'] = '?action=admin;area=featuresettings;sa=sig;apply;step=' . $_GET['step'] . ';' . $context['session_var'] . '=' . $context['session_id'];
1238 1286
 	$context['page_title'] = $txt['not_done_title'];
@@ -1278,9 +1326,10 @@  discard block
 block discarded – undo
1278 1326
 		$disable_fields = array_flip($standard_fields);
1279 1327
 		if (!empty($_POST['active']))
1280 1328
 		{
1281
-			foreach ($_POST['active'] as $value)
1282
-				if (isset($disable_fields[$value]))
1329
+			foreach ($_POST['active'] as $value) {
1330
+							if (isset($disable_fields[$value]))
1283 1331
 					unset($disable_fields[$value]);
1332
+			}
1284 1333
 		}
1285 1334
 		// What we have left!
1286 1335
 		$changes['disabled_profile_fields'] = empty($disable_fields) ? '' : implode(',', array_keys($disable_fields));
@@ -1289,16 +1338,18 @@  discard block
 block discarded – undo
1289 1338
 		$reg_fields = array();
1290 1339
 		if (!empty($_POST['reg']))
1291 1340
 		{
1292
-			foreach ($_POST['reg'] as $value)
1293
-				if (in_array($value, $standard_fields) && !isset($disable_fields[$value]))
1341
+			foreach ($_POST['reg'] as $value) {
1342
+							if (in_array($value, $standard_fields) && !isset($disable_fields[$value]))
1294 1343
 					$reg_fields[] = $value;
1344
+			}
1295 1345
 		}
1296 1346
 		// What we have left!
1297 1347
 		$changes['registration_fields'] = empty($reg_fields) ? '' : implode(',', $reg_fields);
1298 1348
 
1299 1349
 		$_SESSION['adm-save'] = true;
1300
-		if (!empty($changes))
1301
-			updateSettings($changes);
1350
+		if (!empty($changes)) {
1351
+					updateSettings($changes);
1352
+		}
1302 1353
 	}
1303 1354
 
1304 1355
 	createToken('admin-scp');
@@ -1401,11 +1452,13 @@  discard block
 block discarded – undo
1401 1452
 					{
1402 1453
 						$return = '<p class="centertext bold_text">'. $rowData['field_order'] .'<br>';
1403 1454
 
1404
-						if ($rowData['field_order'] > 1)
1405
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_up'] .'"></span></a>';
1455
+						if ($rowData['field_order'] > 1) {
1456
+													$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_up'] .'"></span></a>';
1457
+						}
1406 1458
 
1407
-						if ($rowData['field_order'] < $context['custFieldsMaxOrder'])
1408
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_down'] .'"></span></a>';
1459
+						if ($rowData['field_order'] < $context['custFieldsMaxOrder']) {
1460
+													$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_down'] .'"></span></a>';
1461
+						}
1409 1462
 
1410 1463
 						$return .= '</p>';
1411 1464
 
@@ -1543,16 +1596,16 @@  discard block
 block discarded – undo
1543 1596
 		$disabled_fields = isset($modSettings['disabled_profile_fields']) ? explode(',', $modSettings['disabled_profile_fields']) : array();
1544 1597
 		$registration_fields = isset($modSettings['registration_fields']) ? explode(',', $modSettings['registration_fields']) : array();
1545 1598
 
1546
-		foreach ($standard_fields as $field)
1547
-			$list[] = array(
1599
+		foreach ($standard_fields as $field) {
1600
+					$list[] = array(
1548 1601
 				'id' => $field,
1549 1602
 				'label' => isset($txt['standard_profile_field_' . $field]) ? $txt['standard_profile_field_' . $field] : (isset($txt[$field]) ? $txt[$field] : $field),
1550 1603
 				'disabled' => in_array($field, $disabled_fields),
1551 1604
 				'on_register' => in_array($field, $registration_fields) && !in_array($field, $fields_no_registration),
1552 1605
 				'can_show_register' => !in_array($field, $fields_no_registration),
1553 1606
 			);
1554
-	}
1555
-	else
1607
+		}
1608
+	} else
1556 1609
 	{
1557 1610
 		// Load all the fields.
1558 1611
 		$request = $smcFunc['db_query']('', '
@@ -1566,8 +1619,9 @@  discard block
 block discarded – undo
1566 1619
 				'items_per_page' => $items_per_page,
1567 1620
 			)
1568 1621
 		);
1569
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1570
-			$list[] = $row;
1622
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1623
+					$list[] = $row;
1624
+		}
1571 1625
 		$smcFunc['db_free_result']($request);
1572 1626
 	}
1573 1627
 
@@ -1633,9 +1687,9 @@  discard block
 block discarded – undo
1633 1687
 		$context['field'] = array();
1634 1688
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1635 1689
 		{
1636
-			if ($row['field_type'] == 'textarea')
1637
-				@list ($rows, $cols) = @explode(',', $row['default_value']);
1638
-			else
1690
+			if ($row['field_type'] == 'textarea') {
1691
+							@list ($rows, $cols) = @explode(',', $row['default_value']);
1692
+			} else
1639 1693
 			{
1640 1694
 				$rows = 3;
1641 1695
 				$cols = 30;
@@ -1671,8 +1725,8 @@  discard block
 block discarded – undo
1671 1725
 	}
1672 1726
 
1673 1727
 	// Setup the default values as needed.
1674
-	if (empty($context['field']))
1675
-		$context['field'] = array(
1728
+	if (empty($context['field'])) {
1729
+			$context['field'] = array(
1676 1730
 			'name' => '',
1677 1731
 			'col_name' => '???',
1678 1732
 			'desc' => '',
@@ -1697,6 +1751,7 @@  discard block
 block discarded – undo
1697 1751
 			'enclose' => '',
1698 1752
 			'placement' => 0,
1699 1753
 		);
1754
+	}
1700 1755
 
1701 1756
 	// Are we moving it?
1702 1757
 	if (isset($_GET['move']) && in_array($smcFunc['htmlspecialchars']($_GET['move']), $move_to))
@@ -1705,8 +1760,10 @@  discard block
 block discarded – undo
1705 1760
 		$new_order = ($_GET['move'] == 'up' ? ($context['field']['order'] - 1) : ($context['field']['order'] + 1));
1706 1761
 
1707 1762
 		// Is this a valid position?
1708
-		if ($new_order <= 0 || $new_order > $order_count)
1709
-			redirectexit('action=admin;area=featuresettings;sa=profile'); // @todo implement an error handler
1763
+		if ($new_order <= 0 || $new_order > $order_count) {
1764
+					redirectexit('action=admin;area=featuresettings;sa=profile');
1765
+		}
1766
+		// @todo implement an error handler
1710 1767
 
1711 1768
 		// All good, proceed.
1712 1769
 		$smcFunc['db_query']('','
@@ -1737,12 +1794,14 @@  discard block
 block discarded – undo
1737 1794
 		validateToken('admin-ecp');
1738 1795
 
1739 1796
 		// Everyone needs a name - even the (bracket) unknown...
1740
-		if (trim($_POST['field_name']) == '')
1741
-			redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=need_name');
1797
+		if (trim($_POST['field_name']) == '') {
1798
+					redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=need_name');
1799
+		}
1742 1800
 
1743 1801
 		// Regex you say?  Do a very basic test to see if the pattern is valid
1744
-		if (!empty($_POST['regex']) && @preg_match($_POST['regex'], 'dummy') === false)
1745
-			redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=regex_error');
1802
+		if (!empty($_POST['regex']) && @preg_match($_POST['regex'], 'dummy') === false) {
1803
+					redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=regex_error');
1804
+		}
1746 1805
 
1747 1806
 		$_POST['field_name'] = $smcFunc['htmlspecialchars']($_POST['field_name']);
1748 1807
 		$_POST['field_desc'] = $smcFunc['htmlspecialchars']($_POST['field_desc']);
@@ -1759,8 +1818,9 @@  discard block
 block discarded – undo
1759 1818
 
1760 1819
 		// Some masking stuff...
1761 1820
 		$mask = isset($_POST['mask']) ? $_POST['mask'] : '';
1762
-		if ($mask == 'regex' && isset($_POST['regex']))
1763
-			$mask .= $_POST['regex'];
1821
+		if ($mask == 'regex' && isset($_POST['regex'])) {
1822
+					$mask .= $_POST['regex'];
1823
+		}
1764 1824
 
1765 1825
 		$field_length = isset($_POST['max_length']) ? (int) $_POST['max_length'] : 255;
1766 1826
 		$enclose = isset($_POST['enclose']) ? $_POST['enclose'] : '';
@@ -1779,8 +1839,9 @@  discard block
 block discarded – undo
1779 1839
 				$v = strtr($v, array(',' => ''));
1780 1840
 
1781 1841
 				// Nada, zip, etc...
1782
-				if (trim($v) == '')
1783
-					continue;
1842
+				if (trim($v) == '') {
1843
+									continue;
1844
+				}
1784 1845
 
1785 1846
 				// Otherwise, save it boy.
1786 1847
 				$field_options .= $v . ',';
@@ -1788,15 +1849,17 @@  discard block
 block discarded – undo
1788 1849
 				$newOptions[$k] = $v;
1789 1850
 
1790 1851
 				// Is it default?
1791
-				if (isset($_POST['default_select']) && $_POST['default_select'] == $k)
1792
-					$default = $v;
1852
+				if (isset($_POST['default_select']) && $_POST['default_select'] == $k) {
1853
+									$default = $v;
1854
+				}
1793 1855
 			}
1794 1856
 			$field_options = substr($field_options, 0, -1);
1795 1857
 		}
1796 1858
 
1797 1859
 		// Text area has default has dimensions
1798
-		if ($_POST['field_type'] == 'textarea')
1799
-			$default = (int) $_POST['rows'] . ',' . (int) $_POST['cols'];
1860
+		if ($_POST['field_type'] == 'textarea') {
1861
+					$default = (int) $_POST['rows'] . ',' . (int) $_POST['cols'];
1862
+		}
1800 1863
 
1801 1864
 		// Come up with the unique name?
1802 1865
 		if (empty($context['fid']))
@@ -1805,32 +1868,36 @@  discard block
 block discarded – undo
1805 1868
 			preg_match('~([\w\d_-]+)~', $col_name, $matches);
1806 1869
 
1807 1870
 			// If there is nothing to the name, then let's start out own - for foreign languages etc.
1808
-			if (isset($matches[1]))
1809
-				$col_name = $initial_col_name = 'cust_' . strtolower($matches[1]);
1810
-			else
1811
-				$col_name = $initial_col_name = 'cust_' . mt_rand(1, 9999);
1871
+			if (isset($matches[1])) {
1872
+							$col_name = $initial_col_name = 'cust_' . strtolower($matches[1]);
1873
+			} else {
1874
+							$col_name = $initial_col_name = 'cust_' . mt_rand(1, 9999);
1875
+			}
1812 1876
 
1813 1877
 			// Make sure this is unique.
1814 1878
 			$current_fields = array();
1815 1879
 			$request = $smcFunc['db_query']('', '
1816 1880
 				SELECT id_field, col_name
1817 1881
 				FROM {db_prefix}custom_fields');
1818
-			while ($row = $smcFunc['db_fetch_assoc']($request))
1819
-				$current_fields[$row['id_field']] = $row['col_name'];
1882
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
1883
+							$current_fields[$row['id_field']] = $row['col_name'];
1884
+			}
1820 1885
 			$smcFunc['db_free_result']($request);
1821 1886
 
1822 1887
 			$unique = false;
1823 1888
 			for ($i = 0; !$unique && $i < 9; $i ++)
1824 1889
 			{
1825
-				if (!in_array($col_name, $current_fields))
1826
-					$unique = true;
1827
-				else
1828
-					$col_name = $initial_col_name . $i;
1890
+				if (!in_array($col_name, $current_fields)) {
1891
+									$unique = true;
1892
+				} else {
1893
+									$col_name = $initial_col_name . $i;
1894
+				}
1829 1895
 			}
1830 1896
 
1831 1897
 			// Still not a unique column name? Leave it up to the user, then.
1832
-			if (!$unique)
1833
-				fatal_lang_error('custom_option_not_unique');
1898
+			if (!$unique) {
1899
+							fatal_lang_error('custom_option_not_unique');
1900
+			}
1834 1901
 		}
1835 1902
 		// Work out what to do with the user data otherwise...
1836 1903
 		else
@@ -1858,8 +1925,9 @@  discard block
 block discarded – undo
1858 1925
 				// Work out what's changed!
1859 1926
 				foreach ($context['field']['options'] as $k => $option)
1860 1927
 				{
1861
-					if (trim($option) == '')
1862
-						continue;
1928
+					if (trim($option) == '') {
1929
+											continue;
1930
+					}
1863 1931
 
1864 1932
 					// Still exists?
1865 1933
 					if (in_array($option, $newOptions))
@@ -1873,8 +1941,8 @@  discard block
 block discarded – undo
1873 1941
 				foreach ($optionChanges as $k => $option)
1874 1942
 				{
1875 1943
 					// Just been renamed?
1876
-					if (!in_array($k, $takenKeys) && !empty($newOptions[$k]))
1877
-						$smcFunc['db_query']('', '
1944
+					if (!in_array($k, $takenKeys) && !empty($newOptions[$k])) {
1945
+											$smcFunc['db_query']('', '
1878 1946
 							UPDATE {db_prefix}themes
1879 1947
 							SET value = {string:new_value}
1880 1948
 							WHERE variable = {string:current_column}
@@ -1887,6 +1955,7 @@  discard block
 block discarded – undo
1887 1955
 								'old_value' => $option,
1888 1956
 							)
1889 1957
 						);
1958
+					}
1890 1959
 				}
1891 1960
 			}
1892 1961
 			// @todo Maybe we should adjust based on new text length limits?
@@ -1929,8 +1998,8 @@  discard block
 block discarded – undo
1929 1998
 			);
1930 1999
 
1931 2000
 			// Just clean up any old selects - these are a pain!
1932
-			if (($_POST['field_type'] == 'select' || $_POST['field_type'] == 'radio') && !empty($newOptions))
1933
-				$smcFunc['db_query']('', '
2001
+			if (($_POST['field_type'] == 'select' || $_POST['field_type'] == 'radio') && !empty($newOptions)) {
2002
+							$smcFunc['db_query']('', '
1934 2003
 					DELETE FROM {db_prefix}themes
1935 2004
 					WHERE variable = {string:current_column}
1936 2005
 						AND value NOT IN ({array_string:new_option_values})
@@ -1941,8 +2010,8 @@  discard block
 block discarded – undo
1941 2010
 						'current_column' => $context['field']['col_name'],
1942 2011
 					)
1943 2012
 				);
1944
-		}
1945
-		else
2013
+			}
2014
+		} else
1946 2015
 		{
1947 2016
 			// Gotta figure it out the order.
1948 2017
 			$new_order = $order_count > 1 ? ($order_count + 1) : 1;
@@ -2116,11 +2185,13 @@  discard block
 block discarded – undo
2116 2185
 	call_integration_hook('integrate_prune_settings', array(&$config_vars, &$prune_toggle, false));
2117 2186
 
2118 2187
 	$prune_toggle_dt = array();
2119
-	foreach ($prune_toggle as $item)
2120
-		$prune_toggle_dt[] = 'setting_' . $item;
2188
+	foreach ($prune_toggle as $item) {
2189
+			$prune_toggle_dt[] = 'setting_' . $item;
2190
+	}
2121 2191
 
2122
-	if ($return_config)
2123
-		return $config_vars;
2192
+	if ($return_config) {
2193
+			return $config_vars;
2194
+	}
2124 2195
 
2125 2196
 	addInlineJavaScript('
2126 2197
 	function togglePruned()
@@ -2158,15 +2229,16 @@  discard block
 block discarded – undo
2158 2229
 			$vals = array();
2159 2230
 			foreach ($config_vars as $index => $dummy)
2160 2231
 			{
2161
-				if (!is_array($dummy) || $index == 'pruningOptions' || !in_array($dummy[1], $prune_toggle))
2162
-					continue;
2232
+				if (!is_array($dummy) || $index == 'pruningOptions' || !in_array($dummy[1], $prune_toggle)) {
2233
+									continue;
2234
+				}
2163 2235
 
2164 2236
 				$vals[] = empty($_POST[$dummy[1]]) || $_POST[$dummy[1]] < 0 ? 0 : (int) $_POST[$dummy[1]];
2165 2237
 			}
2166 2238
 			$_POST['pruningOptions'] = implode(',', $vals);
2239
+		} else {
2240
+					$_POST['pruningOptions'] = '';
2167 2241
 		}
2168
-		else
2169
-			$_POST['pruningOptions'] = '';
2170 2242
 
2171 2243
 		saveDBSettings($savevar);
2172 2244
 		$_SESSION['adm-save'] = true;
@@ -2178,10 +2250,11 @@  discard block
 block discarded – undo
2178 2250
 	$context['sub_template'] = 'show_settings';
2179 2251
 
2180 2252
 	// Get the actual values
2181
-	if (!empty($modSettings['pruningOptions']))
2182
-		@list ($modSettings['pruneErrorLog'], $modSettings['pruneModLog'], $modSettings['pruneBanLog'], $modSettings['pruneReportLog'], $modSettings['pruneScheduledTaskLog'], $modSettings['pruneSpiderHitLog']) = explode(',', $modSettings['pruningOptions']);
2183
-	else
2184
-		$modSettings['pruneErrorLog'] = $modSettings['pruneModLog'] = $modSettings['pruneBanLog'] = $modSettings['pruneReportLog'] = $modSettings['pruneScheduledTaskLog'] = $modSettings['pruneSpiderHitLog'] = 0;
2253
+	if (!empty($modSettings['pruningOptions'])) {
2254
+			@list ($modSettings['pruneErrorLog'], $modSettings['pruneModLog'], $modSettings['pruneBanLog'], $modSettings['pruneReportLog'], $modSettings['pruneScheduledTaskLog'], $modSettings['pruneSpiderHitLog']) = explode(',', $modSettings['pruningOptions']);
2255
+	} else {
2256
+			$modSettings['pruneErrorLog'] = $modSettings['pruneModLog'] = $modSettings['pruneBanLog'] = $modSettings['pruneReportLog'] = $modSettings['pruneScheduledTaskLog'] = $modSettings['pruneSpiderHitLog'] = 0;
2257
+	}
2185 2258
 
2186 2259
 	prepareDBSettingContext($config_vars);
2187 2260
 }
@@ -2203,8 +2276,9 @@  discard block
 block discarded – undo
2203 2276
 	// Make it even easier to add new settings.
2204 2277
 	call_integration_hook('integrate_general_mod_settings', array(&$config_vars));
2205 2278
 
2206
-	if ($return_config)
2207
-		return $config_vars;
2279
+	if ($return_config) {
2280
+			return $config_vars;
2281
+	}
2208 2282
 
2209 2283
 	$context['post_url'] = $scripturl . '?action=admin;area=modsettings;save;sa=general';
2210 2284
 	$context['settings_title'] = $txt['mods_cat_modifications_misc'];
Please login to merge, or discard this patch.
Sources/CacheAPI-memcached.php 1 patch
Braces   +17 added lines, -12 removed lines patch added patch discarded remove patch
@@ -11,8 +11,9 @@  discard block
 block discarded – undo
11 11
  * @version 2.1 Beta 4
12 12
  */
13 13
 
14
-if (!defined('SMF'))
14
+if (!defined('SMF')) {
15 15
 	die('Hacking attempt...');
16
+}
16 17
 
17 18
 /**
18 19
  * Our Cache API class
@@ -34,8 +35,9 @@  discard block
 block discarded – undo
34 35
 
35 36
 		$supported = class_exists('memcached');
36 37
 
37
-		if ($test)
38
-			return $supported;
38
+		if ($test) {
39
+					return $supported;
40
+		}
39 41
 		return parent::isSupported() && $supported && !empty($cache_memcached);
40 42
 	}
41 43
 
@@ -53,9 +55,9 @@  discard block
 block discarded – undo
53 55
 		$currentServers = $this->memcached->getServerList();
54 56
 		foreach ($servers as $server)
55 57
 		{
56
-			if (strpos($server,'/') !== false)
57
-				$tempServer = array($server, 0);
58
-			else
58
+			if (strpos($server,'/') !== false) {
59
+							$tempServer = array($server, 0);
60
+			} else
59 61
 			{
60 62
 				$server = explode(':', $server);
61 63
 				$tempServer = array($server[0], isset($server[1]) ? $server[1] : 11211);
@@ -73,8 +75,9 @@  discard block
 block discarded – undo
73 75
 			}
74 76
 
75 77
 			// Found it?
76
-			if (empty($foundServer))
77
-				$this->memcached->addServer($tempServer[0], $tempServer[1]);
78
+			if (empty($foundServer)) {
79
+							$this->memcached->addServer($tempServer[0], $tempServer[1]);
80
+			}
78 81
 		}
79 82
 
80 83
 		// Best guess is this worked.
@@ -91,8 +94,9 @@  discard block
 block discarded – undo
91 94
 		$value = $this->memcached->get($key);
92 95
 
93 96
 		// $value should return either data or false (from failure, key not found or empty array).
94
-		if ($value === false)
95
-			return null;
97
+		if ($value === false) {
98
+					return null;
99
+		}
96 100
 		return $value;
97 101
 	}
98 102
 
@@ -135,8 +139,9 @@  discard block
 block discarded – undo
135 139
 		$config_vars[] = $txt['cache_memcache_settings'];
136 140
 		$config_vars[] = array('cache_memcached', $txt['cache_memcache_servers'], 'file', 'text', 0, 'cache_memcached', 'postinput' => '<br><div class="smalltext"><em>' . $txt['cache_memcache_servers_subtext'] . '</em></div>');
137 141
 
138
-		if (!isset($context['settings_post_javascript']))
139
-			$context['settings_post_javascript'] = '';
142
+		if (!isset($context['settings_post_javascript'])) {
143
+					$context['settings_post_javascript'] = '';
144
+		}
140 145
 
141 146
 		$context['settings_post_javascript'] .= '
142 147
 			$("#cache_accelerator").change(function (e) {
Please login to merge, or discard this patch.
Sources/CacheAPI-memcache.php 1 patch
Braces   +19 added lines, -14 removed lines patch added patch discarded remove patch
@@ -11,8 +11,9 @@  discard block
 block discarded – undo
11 11
  * @version 2.1 Beta 4
12 12
  */
13 13
 
14
-if (!defined('SMF'))
14
+if (!defined('SMF')) {
15 15
 	die('Hacking attempt...');
16
+}
16 17
 
17 18
 /**
18 19
  * Our Cache API class
@@ -34,8 +35,9 @@  discard block
 block discarded – undo
34 35
 
35 36
 		$supported = class_exists('memcache');
36 37
 
37
-		if ($test)
38
-			return $supported;
38
+		if ($test) {
39
+					return $supported;
40
+		}
39 41
 		return parent::isSupported() && $supported && !empty($cache_memcached);
40 42
 	}
41 43
 
@@ -61,9 +63,9 @@  discard block
 block discarded – undo
61 63
 			$server = trim($servers[array_rand($servers)]);
62 64
 
63 65
 			// Normal host names do not contain slashes, while e.g. unix sockets do. Assume alternative transport pipe with port 0.
64
-			if (strpos($server,'/') !== false)
65
-				$host = $server;
66
-			else
66
+			if (strpos($server,'/') !== false) {
67
+							$host = $server;
68
+			} else
67 69
 			{
68 70
 				$server = explode(':', $server);
69 71
 				$host = $server[0];
@@ -71,10 +73,11 @@  discard block
 block discarded – undo
71 73
 			}
72 74
 
73 75
 			// Don't wait too long: yes, we want the server, but we might be able to run the query faster!
74
-			if (empty($db_persist))
75
-				$connected = $this->memcache->connect($host, $port);
76
-			else
77
-				$connected = $this->memcache->pconnect($host, $port);
76
+			if (empty($db_persist)) {
77
+							$connected = $this->memcache->connect($host, $port);
78
+			} else {
79
+							$connected = $this->memcache->pconnect($host, $port);
80
+			}
78 81
 		}
79 82
 
80 83
 		return $connected;
@@ -90,8 +93,9 @@  discard block
 block discarded – undo
90 93
 		$value = $this->memcache->get($key);
91 94
 
92 95
 		// $value should return either data or false (from failure, key not found or empty array).
93
-		if ($value === false)
94
-			return null;
96
+		if ($value === false) {
97
+					return null;
98
+		}
95 99
 		return $value;
96 100
 	}
97 101
 
@@ -132,8 +136,9 @@  discard block
 block discarded – undo
132 136
 		$config_vars[] = $txt['cache_memcache_settings'];
133 137
 		$config_vars[] = array('cache_memcached', $txt['cache_memcache_servers'], 'file', 'text', 0, 'cache_memcached', 'postinput' => '<br><div class="smalltext"><em>' . $txt['cache_memcache_servers_subtext'] . '</em></div>');
134 138
 
135
-		if (!isset($context['settings_post_javascript']))
136
-			$context['settings_post_javascript'] = '';
139
+		if (!isset($context['settings_post_javascript'])) {
140
+					$context['settings_post_javascript'] = '';
141
+		}
137 142
 
138 143
 		$context['settings_post_javascript'] .= '
139 144
 			$("#cache_accelerator").change(function (e) {
Please login to merge, or discard this patch.
Themes/default/Themes.template.php 1 patch
Braces   +103 added lines, -80 removed lines patch added patch discarded remove patch
@@ -54,9 +54,10 @@  discard block
 block discarded – undo
54 54
 					<dd>
55 55
 						<div id="known_themes_list">';
56 56
 
57
-	foreach ($context['themes'] as $theme)
58
-		echo '
57
+	foreach ($context['themes'] as $theme) {
58
+			echo '
59 59
 							<label for="options-known_themes_', $theme['id'], '"><input type="checkbox" name="options[known_themes][]" id="options-known_themes_', $theme['id'], '" value="', $theme['id'], '"', $theme['known'] ? ' checked' : '', ' class="input_check"> ', $theme['name'], '</label><br>';
60
+	}
60 61
 
61 62
 		echo '
62 63
 						</div>
@@ -73,9 +74,10 @@  discard block
 block discarded – undo
73 74
 						<select name="options[theme_guests]" id="theme_guests">';
74 75
 
75 76
 	// Put an option for each theme in the select box.
76
-	foreach ($context['themes'] as $theme)
77
-		echo '
77
+	foreach ($context['themes'] as $theme) {
78
+			echo '
78 79
 							<option value="', $theme['id'], '"', $modSettings['theme_guests'] == $theme['id'] ? ' selected' : '', '>', $theme['name'], '</option>';
80
+	}
79 81
 
80 82
 	echo '
81 83
 						</select>
@@ -90,9 +92,10 @@  discard block
 block discarded – undo
90 92
 							<option value="0">', $txt['theme_forum_default'], '</option>';
91 93
 
92 94
 	// Same thing, this time for changing the theme of everyone.
93
-	foreach ($context['themes'] as $theme)
94
-		echo '
95
+	foreach ($context['themes'] as $theme) {
96
+			echo '
95 97
 							<option value="', $theme['id'], '">', $theme['name'], '</option>';
98
+	}
96 99
 
97 100
 	echo '
98 101
 						</select>
@@ -189,11 +192,12 @@  discard block
 block discarded – undo
189 192
 	global $context, $scripturl, $txt;
190 193
 
191 194
 	// Show a nice confirmation message.
192
-	if (isset($_GET['done']))
193
-		echo '
195
+	if (isset($_GET['done'])) {
196
+			echo '
194 197
 	<div class="infobox">
195 198
 		', $txt['theme_confirmed_' . $_GET['done']], '
196 199
 	</div>';
200
+	}
197 201
 
198 202
 	echo '
199 203
 	<div id="admincenter">';
@@ -357,11 +361,12 @@  discard block
 block discarded – undo
357 361
 		if (empty($setting) || !is_array($setting))
358 362
 		{
359 363
 			// Insert a separator (unless this is the first item in the list)
360
-			if ($i !== $first_option_key)
361
-				echo '
364
+			if ($i !== $first_option_key) {
365
+							echo '
362 366
 				</dl>
363 367
 				<hr>
364 368
 				<dl class="settings">';
369
+			}
365 370
 
366 371
 			// Should we give a name to this section?
367 372
 			if (is_string($setting) && !empty($setting))
@@ -369,9 +374,9 @@  discard block
 block discarded – undo
369 374
 				$titled_section = true;
370 375
 				echo '
371 376
 					<dt><strong>' . $setting . '</strong></dt><dd></dd>';
377
+			} else {
378
+							$titled_section = false;
372 379
 			}
373
-			else
374
-				$titled_section = false;
375 380
 
376 381
 			continue;
377 382
 		}
@@ -380,19 +385,21 @@  discard block
 block discarded – undo
380 385
 					<dt ', $context['theme_options_reset'] ? 'style="width:50%"' : '', '>';
381 386
 
382 387
 		// Show the change option box ?
383
-		if ($context['theme_options_reset'])
384
-			echo '
388
+		if ($context['theme_options_reset']) {
389
+					echo '
385 390
 						<span class="floatleft"><select name="', !empty($setting['default']) ? 'default_' : '', 'options_master[', $setting['id'], ']" onchange="this.form.options_', $setting['id'], '.disabled = this.selectedIndex != 1;">
386 391
 							<option value="0" selected>', $txt['themeadmin_reset_options_none'], '</option>
387 392
 							<option value="1">', $txt['themeadmin_reset_options_change'], '</option>
388 393
 							<option value="2">', $txt['themeadmin_reset_options_default'], '</option>
389 394
 						</select>&nbsp;</span>';
395
+		}
390 396
 
391 397
 		echo '
392 398
 						<label for="options_', $setting['id'], '">', !$titled_section ? '<strong>' : '', $setting['label'], !$titled_section ? '</strong>' : '', '</label>';
393
-		if (isset($setting['description']))
394
-			echo '
399
+		if (isset($setting['description'])) {
400
+					echo '
395 401
 						<br><span class="smalltext">', $setting['description'], '</span>';
402
+		}
396 403
 		echo '
397 404
 					</dt>';
398 405
 
@@ -434,13 +441,11 @@  discard block
 block discarded – undo
434 441
 
435 442
 				echo '
436 443
 						<input type="number"', $min . $max . $step;
437
-			}
438
-			else if (isset($setting['type']) && $setting['type'] == 'url')
444
+			} else if (isset($setting['type']) && $setting['type'] == 'url')
439 445
 			{
440 446
 				echo'
441 447
 						<input type="url"';
442
-			}
443
-			else
448
+			} else
444 449
 			{
445 450
 				echo '
446 451
 						<input type="text"';
@@ -484,8 +489,8 @@  discard block
 block discarded – undo
484 489
 			<br>';
485 490
 
486 491
 	// @todo Why can't I edit the default theme popup.
487
-	if ($context['theme_settings']['theme_id'] != 1)
488
-		echo '
492
+	if ($context['theme_settings']['theme_id'] != 1) {
493
+			echo '
489 494
 			<div class="cat_bar">
490 495
 				<h3 class="catbg config_hd">
491 496
 					', $txt['theme_edit'], '
@@ -501,6 +506,7 @@  discard block
 block discarded – undo
501 506
 					</li>
502 507
 				</ul>
503 508
 			</div>';
509
+	}
504 510
 
505 511
 	echo '
506 512
 			<div class="cat_bar">
@@ -554,9 +560,10 @@  discard block
 block discarded – undo
554 560
 					<dd>
555 561
 						<select id="variant" name="options[default_variant]" onchange="changeVariant(this.value)">';
556 562
 
557
-		foreach ($context['theme_variants'] as $key => $variant)
558
-			echo '
563
+		foreach ($context['theme_variants'] as $key => $variant) {
564
+					echo '
559 565
 							<option value="', $key, '"', $context['default_variant'] == $key ? ' selected' : '', '>', $variant['label'], '</option>';
566
+		}
560 567
 
561 568
 		echo '
562 569
 						</select>
@@ -592,11 +599,12 @@  discard block
 block discarded – undo
592 599
 		if (empty($setting) || !is_array($setting))
593 600
 		{
594 601
 			// We don't need a separator before the first list element
595
-			if ($i !== $first_setting_key)
596
-				echo '
602
+			if ($i !== $first_setting_key) {
603
+							echo '
597 604
 				</dl>
598 605
 				<hr>
599 606
 				<dl class="settings">';
607
+			}
600 608
 
601 609
 			// Add a fake heading?
602 610
 			if (is_string($setting) && !empty($setting))
@@ -604,9 +612,9 @@  discard block
 block discarded – undo
604 612
 				$titled_section = true;
605 613
 				echo '
606 614
 					<dt><strong>' . $setting . '</strong></dt><dd></dd>';
615
+			} else {
616
+							$titled_section = false;
607 617
 			}
608
-			else
609
-				$titled_section = false;
610 618
 
611 619
 			continue;
612 620
 		}
@@ -615,9 +623,10 @@  discard block
 block discarded – undo
615 623
 					<dt>
616 624
 						<label for="', $setting['id'], '">', !$titled_section ? '<strong>' : '', $setting['label'], !$titled_section ? '</strong>' : '', '</label>:';
617 625
 
618
-		if (isset($setting['description']))
619
-			echo '<br>
626
+		if (isset($setting['description'])) {
627
+					echo '<br>
620 628
 						<span class="smalltext">', $setting['description'], '</span>';
629
+		}
621 630
 
622 631
 		echo '
623 632
 					</dt>';
@@ -638,9 +647,10 @@  discard block
 block discarded – undo
638 647
 					<dd>
639 648
 						<select name="', !empty($setting['default']) ? 'default_' : '', 'options[', $setting['id'], ']" id="', $setting['id'], '">';
640 649
 
641
-			foreach ($setting['options'] as $value => $label)
642
-				echo '
650
+			foreach ($setting['options'] as $value => $label) {
651
+							echo '
643 652
 							<option value="', $value, '"', $value == $setting['value'] ? ' selected' : '', '>', $label, '</option>';
653
+			}
644 654
 
645 655
 			echo '
646 656
 						</select>
@@ -669,13 +679,11 @@  discard block
 block discarded – undo
669 679
 
670 680
 				echo '
671 681
 						<input type="number"', $min . $max . $step;
672
-			}
673
-			else if (isset($setting['type']) && $setting['type'] == 'url')
682
+			} else if (isset($setting['type']) && $setting['type'] == 'url')
674 683
 			{
675 684
 				echo'
676 685
 						<input type="url"';
677
-			}
678
-			else
686
+			} else
679 687
 			{
680 688
 				echo '
681 689
 						<input type="text"';
@@ -828,21 +836,23 @@  discard block
 block discarded – undo
828 836
 		<div class="windowbg">';
829 837
 
830 838
 	// Oops! there was an error :(
831
-	if (!empty($context['error_message']))
832
-		echo '
839
+	if (!empty($context['error_message'])) {
840
+			echo '
833 841
 			<p>
834 842
 				', $context['error_message'], '
835 843
 			</p>';
844
+	}
836 845
 
837 846
 	// Not much to show except a link back...
838
-	else
839
-		echo '
847
+	else {
848
+			echo '
840 849
 			<p>
841 850
 				<a href="', $scripturl, '?action=admin;area=theme;sa=list;th=', $context['installed_theme']['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $context['installed_theme']['name'], '</a> ', $txt['theme_' . (isset($context['installed_theme']['updated']) ? 'updated' : 'installed') . '_message'], '
842 851
 			</p>
843 852
 			<p>
844 853
 				<a href="', $scripturl, '?action=admin;area=theme;sa=admin;', $context['session_var'], '=', $context['session_id'], '">', $txt['back'], '</a>
845 854
 			</p>';
855
+	}
846 856
 
847 857
 	echo '
848 858
 		</div>
@@ -909,10 +919,11 @@  discard block
 block discarded – undo
909 919
 					<span class="floatleft">', $template['filename'], $template['already_exists'] ? ' <span class="error">(' . $txt['themeadmin_edit_exists'] . ')</span>' : '', '</span>
910 920
 					<span class="floatright">';
911 921
 
912
-		if ($template['can_copy'])
913
-			echo '<a href="', $scripturl, '?action=admin;area=theme;th=', $context['theme_id'], ';', $context['session_var'], '=', $context['session_id'], ';sa=copy;template=', $template['value'], '" data-confirm="', $template['already_exists'] ? $txt['themeadmin_edit_overwrite_confirm'] : $txt['themeadmin_edit_copy_confirm'], '" class="you_sure">', $txt['themeadmin_edit_do_copy'], '</a>';
914
-		else
915
-			echo $txt['themeadmin_edit_no_copy'];
922
+		if ($template['can_copy']) {
923
+					echo '<a href="', $scripturl, '?action=admin;area=theme;th=', $context['theme_id'], ';', $context['session_var'], '=', $context['session_id'], ';sa=copy;template=', $template['value'], '" data-confirm="', $template['already_exists'] ? $txt['themeadmin_edit_overwrite_confirm'] : $txt['themeadmin_edit_copy_confirm'], '" class="you_sure">', $txt['themeadmin_edit_do_copy'], '</a>';
924
+		} else {
925
+					echo $txt['themeadmin_edit_no_copy'];
926
+		}
916 927
 
917 928
 		echo '
918 929
 					</span>
@@ -935,11 +946,12 @@  discard block
 block discarded – undo
935 946
 	echo '
936 947
 	<div id="admincenter">';
937 948
 
938
-	if (!empty($context['browse_title']))
939
-		echo '
949
+	if (!empty($context['browse_title'])) {
950
+			echo '
940 951
 		<div class="cat_bar">
941 952
 			<h3 class="catbg">', $context['browse_title'], '</h3>
942 953
 		</div>';
954
+	}
943 955
 
944 956
 	echo '
945 957
 		<table class="table_grid tborder">
@@ -959,14 +971,13 @@  discard block
 block discarded – undo
959 971
 			<tr class="windowbg">
960 972
 				<td>';
961 973
 
962
-		if ($file['is_editable'])
963
-			echo '<a href="', $file['href'], '"', $file['is_template'] ? ' style="font-weight: bold;"' : '', '>', $file['filename'], '</a>';
964
-
965
-		elseif ($file['is_directory'])
966
-			echo '<a href="', $file['href'], '" class="is_directory"><span class="generic_icons folder"></span>', $file['filename'], '</a>';
967
-
968
-		else
969
-			echo $file['filename'];
974
+		if ($file['is_editable']) {
975
+					echo '<a href="', $file['href'], '"', $file['is_template'] ? ' style="font-weight: bold;"' : '', '>', $file['filename'], '</a>';
976
+		} elseif ($file['is_directory']) {
977
+					echo '<a href="', $file['href'], '" class="is_directory"><span class="generic_icons folder"></span>', $file['filename'], '</a>';
978
+		} else {
979
+					echo $file['filename'];
980
+		}
970 981
 
971 982
 		echo '
972 983
 				</td>
@@ -988,11 +999,12 @@  discard block
 block discarded – undo
988 999
 {
989 1000
 	global $context, $settings, $scripturl, $txt;
990 1001
 
991
-	if ($context['session_error'])
992
-		echo '
1002
+	if ($context['session_error']) {
1003
+			echo '
993 1004
 	<div class="errorbox">
994 1005
 		', $txt['error_session_timeout'], '
995 1006
 	</div>';
1007
+	}
996 1008
 
997 1009
 	// From now on no one can complain that editing css is difficult. If you disagree, go to www.w3schools.com.
998 1010
 	echo '
@@ -1055,17 +1067,18 @@  discard block
 block discarded – undo
1055 1067
 					try
1056 1068
 					{
1057 1069
 					';
1058
-	if (isBrowser('is_ie'))
1059
-		echo '
1070
+	if (isBrowser('is_ie')) {
1071
+			echo '
1060 1072
 						var sheets = frames["css_preview_box"].document.styleSheets;
1061 1073
 						for (var j = 0; j < sheets.length; j++)
1062 1074
 						{
1063 1075
 							if (sheets[j].id == "css_preview_box")
1064 1076
 								sheets[j].cssText = document.forms.stylesheetForm.entire_file.value;
1065 1077
 						}';
1066
-	else
1067
-		echo '
1078
+	} else {
1079
+			echo '
1068 1080
 						setInnerHTML(frames["css_preview_box"].document.getElementById("css_preview_sheet"), document.forms.stylesheetForm.entire_file.value);';
1081
+	}
1069 1082
 	echo '
1070 1083
 					}
1071 1084
 					catch (e)
@@ -1117,9 +1130,10 @@  discard block
 block discarded – undo
1117 1130
 			</div>
1118 1131
 			<div class="windowbg">';
1119 1132
 
1120
-	if (!$context['allow_save'])
1121
-		echo '
1133
+	if (!$context['allow_save']) {
1134
+			echo '
1122 1135
 				', $txt['theme_edit_no_save'], ': ', $context['allow_save_filename'], '<br>';
1136
+	}
1123 1137
 
1124 1138
 	echo '
1125 1139
 				<textarea name="entire_file" cols="80" rows="20" style="width: 96%; font-family: monospace; margin-top: 1ex; white-space: pre;" onkeyup="setPreviewTimeout();" onchange="refreshPreview(true);">', $context['entire_file'], '</textarea><br>
@@ -1132,9 +1146,10 @@  discard block
 block discarded – undo
1132 1146
 			<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">';
1133 1147
 
1134 1148
 	// Hopefully it exists.
1135
-	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token']))
1136
-		echo '
1149
+	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'])) {
1150
+			echo '
1137 1151
 			<input type="hidden" name="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token_var'], '" value="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'], '">';
1152
+	}
1138 1153
 
1139 1154
 	echo '
1140 1155
 		</form>
@@ -1148,18 +1163,20 @@  discard block
 block discarded – undo
1148 1163
 {
1149 1164
 	global $context, $scripturl, $txt;
1150 1165
 
1151
-	if ($context['session_error'])
1152
-		echo '
1166
+	if ($context['session_error']) {
1167
+			echo '
1153 1168
 	<div class="errorbox">
1154 1169
 		', $txt['error_session_timeout'], '
1155 1170
 	</div>';
1171
+	}
1156 1172
 
1157
-	if (isset($context['parse_error']))
1158
-		echo '
1173
+	if (isset($context['parse_error'])) {
1174
+			echo '
1159 1175
 	<div class="errorbox">
1160 1176
 		', $txt['themeadmin_edit_error'], '
1161 1177
 			<div><pre>', $context['parse_error'], '</pre></div>
1162 1178
 	</div>';
1179
+	}
1163 1180
 
1164 1181
 	// Just show a big box.... gray out the Save button if it's not saveable... (ie. not 777.)
1165 1182
 	echo '
@@ -1170,16 +1187,18 @@  discard block
 block discarded – undo
1170 1187
 			</div>
1171 1188
 			<div class="windowbg">';
1172 1189
 
1173
-	if (!$context['allow_save'])
1174
-		echo '
1190
+	if (!$context['allow_save']) {
1191
+			echo '
1175 1192
 				', $txt['theme_edit_no_save'], ': ', $context['allow_save_filename'], '<br>';
1193
+	}
1176 1194
 
1177
-	foreach ($context['file_parts'] as $part)
1178
-		echo '
1195
+	foreach ($context['file_parts'] as $part) {
1196
+			echo '
1179 1197
 				<label for="on_line', $part['line'], '">', $txt['themeadmin_edit_on_line'], ' ', $part['line'], '</label>:<br>
1180 1198
 				<div class="centertext">
1181 1199
 					<textarea id="on_line', $part['line'], '" name="entire_file[]" cols="80" rows="', $part['lines'] > 14 ? '14' : $part['lines'], '" class="edit_file">', $part['data'], '</textarea>
1182 1200
 				</div>';
1201
+	}
1183 1202
 
1184 1203
 	echo '
1185 1204
 				<div class="padding righttext">
@@ -1188,9 +1207,10 @@  discard block
 block discarded – undo
1188 1207
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">';
1189 1208
 
1190 1209
 	// Hopefully it exists.
1191
-	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token']))
1192
-		echo '
1210
+	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'])) {
1211
+			echo '
1193 1212
 					<input type="hidden" name="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token_var'], '" value="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'], '">';
1213
+	}
1194 1214
 
1195 1215
 	echo '
1196 1216
 				</div>
@@ -1206,18 +1226,20 @@  discard block
 block discarded – undo
1206 1226
 {
1207 1227
 	global $context, $scripturl, $txt;
1208 1228
 
1209
-	if ($context['session_error'])
1210
-		echo '
1229
+	if ($context['session_error']) {
1230
+			echo '
1211 1231
 	<div class="errorbox">
1212 1232
 		', $txt['error_session_timeout'], '
1213 1233
 	</div>';
1234
+	}
1214 1235
 
1215 1236
 	//Is this file writeable?
1216
-	if (!$context['allow_save'])
1217
-		echo '
1237
+	if (!$context['allow_save']) {
1238
+			echo '
1218 1239
 	<div class="errorbox">
1219 1240
 		', $txt['theme_edit_no_save'], ': ', $context['allow_save_filename'], '
1220 1241
 	</div>';
1242
+	}
1221 1243
 
1222 1244
 	// Just show a big box.... gray out the Save button if it's not saveable... (ie. not 777.)
1223 1245
 	echo '
@@ -1233,9 +1255,10 @@  discard block
 block discarded – undo
1233 1255
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">';
1234 1256
 
1235 1257
 	// Hopefully it exists.
1236
-	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token']))
1237
-		echo '
1258
+	if (isset($context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'])) {
1259
+			echo '
1238 1260
 				<input type="hidden" name="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token_var'], '" value="', $context['admin-te-' . md5($context['theme_id'] . '-' . $context['edit_filename']) . '_token'], '">';
1261
+	}
1239 1262
 
1240 1263
 	echo '
1241 1264
 			</div>
Please login to merge, or discard this patch.
Themes/default/Profile.template.php 1 patch
Braces   +461 added lines, -344 removed lines patch added patch discarded remove patch
@@ -18,23 +18,25 @@  discard block
 block discarded – undo
18 18
 	global $context;
19 19
 
20 20
 	// Prevent Chrome from auto completing fields when viewing/editing other members profiles
21
-	if (isBrowser('is_chrome') && !$context['user']['is_owner'])
22
-		echo '
21
+	if (isBrowser('is_chrome') && !$context['user']['is_owner']) {
22
+			echo '
23 23
 	<script>
24 24
 		disableAutoComplete();
25 25
 	</script>';
26
+	}
26 27
 
27 28
 	// If an error occurred while trying to save previously, give the user a clue!
28 29
 	echo '
29 30
 					', template_error_message();
30 31
 
31 32
 	// If the profile was update successfully, let the user know this.
32
-	if (!empty($context['profile_updated']))
33
-		echo '
33
+	if (!empty($context['profile_updated'])) {
34
+			echo '
34 35
 					<div class="infobox">
35 36
 						', $context['profile_updated'], '
36 37
 					</div>';
37
-}
38
+	}
39
+	}
38 40
 
39 41
 /**
40 42
  * Template for any HTML needed below the profile (closing off divs/tables, etc.)
@@ -102,8 +104,7 @@  discard block
 block discarded – undo
102 104
 	if (empty($context['unread_alerts']))
103 105
 	{
104 106
 		template_alerts_all_read();
105
-	}
106
-	else
107
+	} else
107 108
 	{
108 109
 		foreach ($context['unread_alerts'] as $id_alert => $details)
109 110
 		{
@@ -164,10 +165,11 @@  discard block
 block discarded – undo
164 165
 			<div class="custom_fields_above_name">
165 166
 				<ul >';
166 167
 
167
-		foreach ($context['print_custom_fields']['above_member'] as $field)
168
-			if (!empty($field['output_html']))
168
+		foreach ($context['print_custom_fields']['above_member'] as $field) {
169
+					if (!empty($field['output_html']))
169 170
 				echo '
170 171
 					<li>', $field['output_html'], '</li>';
172
+		}
171 173
 
172 174
 		echo '
173 175
 				</ul>
@@ -188,10 +190,11 @@  discard block
 block discarded – undo
188 190
 			<div class="custom_fields_below_avatar">
189 191
 				<ul >';
190 192
 
191
-		foreach ($context['print_custom_fields']['below_avatar'] as $field)
192
-			if (!empty($field['output_html']))
193
+		foreach ($context['print_custom_fields']['below_avatar'] as $field) {
194
+					if (!empty($field['output_html']))
193 195
 				echo '
194 196
 					<li>', $field['output_html'], '</li>';
197
+		}
195 198
 
196 199
 		echo '
197 200
 				</ul>
@@ -202,22 +205,25 @@  discard block
 block discarded – undo
202 205
 		echo '
203 206
 			<ul class="clear">';
204 207
 	// Email is only visible if it's your profile or you have the moderate_forum permission
205
-	if ($context['member']['show_email'])
206
-		echo '
208
+	if ($context['member']['show_email']) {
209
+			echo '
207 210
 				<li><a href="mailto:', $context['member']['email'], '" title="', $context['member']['email'], '" rel="nofollow"><span class="generic_icons mail" title="' . $txt['email'] . '"></span></a></li>';
211
+	}
208 212
 
209 213
 	// Don't show an icon if they haven't specified a website.
210
-	if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website']))
211
-		echo '
214
+	if ($context['member']['website']['url'] !== '' && !isset($context['disabled_fields']['website'])) {
215
+			echo '
212 216
 				<li><a href="', $context['member']['website']['url'], '" title="' . $context['member']['website']['title'] . '" target="_blank" class="new_win">', ($settings['use_image_buttons'] ? '<span class="generic_icons www" title="' . $context['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>';
217
+	}
213 218
 
214 219
 	// Are there any custom profile fields as icons?
215 220
 	if (!empty($context['print_custom_fields']['icons']))
216 221
 	{
217
-		foreach ($context['print_custom_fields']['icons'] as $field)
218
-			if (!empty($field['output_html']))
222
+		foreach ($context['print_custom_fields']['icons'] as $field) {
223
+					if (!empty($field['output_html']))
219 224
 				echo '
220 225
 					<li class="custom_field">', $field['output_html'], '</li>';
226
+		}
221 227
 	}
222 228
 
223 229
 	echo '
@@ -225,23 +231,26 @@  discard block
 block discarded – undo
225 231
 			<span id="userstatus">', $context['can_send_pm'] ? '<a href="' . $context['member']['online']['href'] . '" title="' . $context['member']['online']['text'] . '" rel="nofollow">' : '', $settings['use_image_buttons'] ? '<span class="' . ($context['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $context['member']['online']['text'] . '"></span>' : $context['member']['online']['label'], $context['can_send_pm'] ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $context['member']['online']['label'] . '</span>' : '';
226 232
 
227 233
 	// Can they add this member as a buddy?
228
-	if (!empty($context['can_have_buddy']) && !$context['user']['is_owner'])
229
-		echo '
234
+	if (!empty($context['can_have_buddy']) && !$context['user']['is_owner']) {
235
+			echo '
230 236
 				<br><a href="', $scripturl, '?action=buddy;u=', $context['id_member'], ';', $context['session_var'], '=', $context['session_id'], '">[', $txt['buddy_' . ($context['member']['is_buddy'] ? 'remove' : 'add')], ']</a>';
237
+	}
231 238
 
232 239
 	echo '
233 240
 			</span>';
234 241
 
235
-	if (!$context['user']['is_owner'] && $context['can_send_pm'])
236
-		echo '
242
+	if (!$context['user']['is_owner'] && $context['can_send_pm']) {
243
+			echo '
237 244
 			<a href="', $scripturl, '?action=pm;sa=send;u=', $context['id_member'], '" class="infolinks">', $txt['profile_sendpm_short'], '</a>';
245
+	}
238 246
 
239 247
 	echo '
240 248
 			<a href="', $scripturl, '?action=profile;area=showposts;u=', $context['id_member'], '" class="infolinks">', $txt['showPosts'], '</a>';
241 249
 
242
-	if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled']))
243
-		echo '
250
+	if ($context['user']['is_owner'] && !empty($modSettings['drafts_post_enabled'])) {
251
+			echo '
244 252
 			<a href="', $scripturl, '?action=profile;area=showdrafts;u=', $context['id_member'], '" class="infolinks">', $txt['drafts_show'], '</a>';
253
+	}
245 254
 
246 255
 	echo '
247 256
 			<a href="', $scripturl, '?action=profile;area=statistics;u=', $context['id_member'], '" class="infolinks">', $txt['statPanel'], '</a>';
@@ -253,10 +262,11 @@  discard block
 block discarded – undo
253 262
 			<div class="custom_fields_bottom">
254 263
 				<ul class="nolist">';
255 264
 
256
-		foreach ($context['print_custom_fields']['bottom_poster'] as $field)
257
-			if (!empty($field['output_html']))
265
+		foreach ($context['print_custom_fields']['bottom_poster'] as $field) {
266
+					if (!empty($field['output_html']))
258 267
 				echo '
259 268
 					<li>', $field['output_html'], '</li>';
269
+		}
260 270
 
261 271
 		echo '
262 272
 				</ul>
@@ -270,15 +280,17 @@  discard block
 block discarded – undo
270 280
 		<div id="detailedinfo">
271 281
 			<dl class="settings">';
272 282
 
273
-	if ($context['user']['is_owner'] || $context['user']['is_admin'])
274
-		echo '
283
+	if ($context['user']['is_owner'] || $context['user']['is_admin']) {
284
+			echo '
275 285
 				<dt>', $txt['username'], ': </dt>
276 286
 				<dd>', $context['member']['username'], '</dd>';
287
+	}
277 288
 
278
-	if (!isset($context['disabled_fields']['posts']))
279
-		echo '
289
+	if (!isset($context['disabled_fields']['posts'])) {
290
+			echo '
280 291
 				<dt>', $txt['profile_posts'], ': </dt>
281 292
 				<dd>', $context['member']['posts'], ' (', $context['member']['posts_per_day'], ' ', $txt['posts_per_day'], ')</dd>';
293
+	}
282 294
 
283 295
 	if ($context['member']['show_email'])
284 296
 	{
@@ -287,15 +299,17 @@  discard block
 block discarded – undo
287 299
 				<dd><a href="mailto:', $context['member']['email'], '">', $context['member']['email'], '</a></dd>';
288 300
 	}
289 301
 
290
-	if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title']))
291
-		echo '
302
+	if (!empty($modSettings['titlesEnable']) && !empty($context['member']['title'])) {
303
+			echo '
292 304
 				<dt>', $txt['custom_title'], ': </dt>
293 305
 				<dd>', $context['member']['title'], '</dd>';
306
+	}
294 307
 
295
-	if (!empty($context['member']['blurb']))
296
-		echo '
308
+	if (!empty($context['member']['blurb'])) {
309
+			echo '
297 310
 				<dt>', $txt['personal_text'], ': </dt>
298 311
 				<dd>', $context['member']['blurb'], '</dd>';
312
+	}
299 313
 
300 314
 	echo '
301 315
 				<dt>', $txt['age'], ':</dt>
@@ -310,11 +324,12 @@  discard block
 block discarded – undo
310 324
 		echo '
311 325
 				<dl class="settings">';
312 326
 
313
-		foreach ($context['print_custom_fields']['standard'] as $field)
314
-			if (!empty($field['output_html']))
327
+		foreach ($context['print_custom_fields']['standard'] as $field) {
328
+					if (!empty($field['output_html']))
315 329
 				echo '
316 330
 					<dt>', $field['name'], ':</dt>
317 331
 					<dd>', $field['output_html'], '</dd>';
332
+		}
318 333
 
319 334
 		echo '
320 335
 				</dl>';
@@ -332,9 +347,10 @@  discard block
 block discarded – undo
332 347
 						<a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=', ($context['can_issue_warning'] && !$context['user']['is_owner'] ? 'issuewarning' : 'viewwarning'), '">', $context['member']['warning'], '%</a>';
333 348
 
334 349
 		// Can we provide information on what this means?
335
-		if (!empty($context['warning_status']))
336
-			echo '
350
+		if (!empty($context['warning_status'])) {
351
+					echo '
337 352
 						<span class="smalltext">(', $context['warning_status'], ')</span>';
353
+		}
338 354
 
339 355
 		echo '
340 356
 					</dd>';
@@ -345,9 +361,10 @@  discard block
 block discarded – undo
345 361
 	{
346 362
 
347 363
 		// If the person looking at the summary has permission, and the account isn't activated, give the viewer the ability to do it themselves.
348
-		if (!empty($context['activate_message']))
349
-			echo '
364
+		if (!empty($context['activate_message'])) {
365
+					echo '
350 366
 					<dt class="clear"><span class="alert">', $context['activate_message'], '</span>&nbsp;(<a href="', $context['activate_link'], '"', ($context['activate_type'] == 4 ? ' class="you_sure" data-confirm="' . $txt['profileConfirm'] . '"' : ''), '>', $context['activate_link_text'], '</a>)</dt>';
367
+		}
351 368
 
352 369
 		// If the current member is banned, show a message and possibly a link to the ban.
353 370
 		if (!empty($context['member']['bans']))
@@ -357,9 +374,10 @@  discard block
 block discarded – undo
357 374
 					<dt class="clear" id="ban_info" style="display: none;">
358 375
 						<strong>', $txt['user_banned_by_following'], ':</strong>';
359 376
 
360
-			foreach ($context['member']['bans'] as $ban)
361
-				echo '
377
+			foreach ($context['member']['bans'] as $ban) {
378
+							echo '
362 379
 						<br><span class="smalltext">', $ban['explanation'], '</span>';
380
+			}
363 381
 
364 382
 			echo '
365 383
 					</dt>';
@@ -373,30 +391,34 @@  discard block
 block discarded – undo
373 391
 	// If the person looking is allowed, they can check the members IP address and hostname.
374 392
 	if ($context['can_see_ip'])
375 393
 	{
376
-		if (!empty($context['member']['ip']))
377
-		echo '
394
+		if (!empty($context['member']['ip'])) {
395
+				echo '
378 396
 					<dt>', $txt['ip'], ': </dt>
379 397
 					<dd><a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['member']['ip'], ';u=', $context['member']['id'], '">', $context['member']['ip'], '</a></dd>';
398
+		}
380 399
 
381
-		if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip']))
382
-			echo '
400
+		if (empty($modSettings['disableHostnameLookup']) && !empty($context['member']['ip'])) {
401
+					echo '
383 402
 					<dt>', $txt['hostname'], ': </dt>
384 403
 					<dd>', $context['member']['hostname'], '</dd>';
404
+		}
385 405
 	}
386 406
 
387 407
 	echo '
388 408
 					<dt>', $txt['local_time'], ':</dt>
389 409
 					<dd>', $context['member']['local_time'], '</dd>';
390 410
 
391
-	if (!empty($modSettings['userLanguage']) && !empty($context['member']['language']))
392
-		echo '
411
+	if (!empty($modSettings['userLanguage']) && !empty($context['member']['language'])) {
412
+			echo '
393 413
 					<dt>', $txt['language'], ':</dt>
394 414
 					<dd>', $context['member']['language'], '</dd>';
415
+	}
395 416
 
396
-	if ($context['member']['show_last_login'])
397
-		echo '
417
+	if ($context['member']['show_last_login']) {
418
+			echo '
398 419
 					<dt>', $txt['lastLoggedIn'], ': </dt>
399 420
 					<dd>', $context['member']['last_login'], (!empty($context['member']['is_hidden']) ? ' (' . $txt['hidden'] . ')' : ''), '</dd>';
421
+	}
400 422
 
401 423
 	echo '
402 424
 				</dl>';
@@ -408,10 +430,11 @@  discard block
 block discarded – undo
408 430
 				<div class="custom_fields_above_signature">
409 431
 					<ul class="nolist">';
410 432
 
411
-		foreach ($context['print_custom_fields']['above_signature'] as $field)
412
-			if (!empty($field['output_html']))
433
+		foreach ($context['print_custom_fields']['above_signature'] as $field) {
434
+					if (!empty($field['output_html']))
413 435
 				echo '
414 436
 						<li>', $field['output_html'], '</li>';
437
+		}
415 438
 
416 439
 		echo '
417 440
 					</ul>
@@ -419,12 +442,13 @@  discard block
 block discarded – undo
419 442
 	}
420 443
 
421 444
 	// Show the users signature.
422
-	if ($context['signature_enabled'] && !empty($context['member']['signature']))
423
-		echo '
445
+	if ($context['signature_enabled'] && !empty($context['member']['signature'])) {
446
+			echo '
424 447
 				<div class="signature">
425 448
 					<h5>', $txt['signature'], ':</h5>
426 449
 					', $context['member']['signature'], '
427 450
 				</div>';
451
+	}
428 452
 
429 453
 	// Are there any custom profile fields for below the signature?
430 454
 	if (!empty($context['print_custom_fields']['below_signature']))
@@ -433,10 +457,11 @@  discard block
 block discarded – undo
433 457
 				<div class="custom_fields_below_signature">
434 458
 					<ul class="nolist">';
435 459
 
436
-		foreach ($context['print_custom_fields']['below_signature'] as $field)
437
-			if (!empty($field['output_html']))
460
+		foreach ($context['print_custom_fields']['below_signature'] as $field) {
461
+					if (!empty($field['output_html']))
438 462
 				echo '
439 463
 						<li>', $field['output_html'], '</li>';
464
+		}
440 465
 
441 466
 		echo '
442 467
 					</ul>
@@ -481,62 +506,70 @@  discard block
 block discarded – undo
481 506
 				</div>
482 507
 				<div class="list_posts">';
483 508
 
484
-			if (!$post['approved'])
485
-				echo '
509
+			if (!$post['approved']) {
510
+							echo '
486 511
 					<div class="approve_post">
487 512
 						<em>', $txt['post_awaiting_approval'], '</em>
488 513
 					</div>';
514
+			}
489 515
 
490 516
 			echo '
491 517
 					', $post['body'], '
492 518
 				</div>';
493 519
 
494
-			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete'])
495
-				echo '
520
+			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) {
521
+							echo '
496 522
 				<div class="floatright">
497 523
 					<ul class="quickbuttons">';
524
+			}
498 525
 
499 526
 			// If they *can* reply?
500
-			if ($post['can_reply'])
501
-				echo '
527
+			if ($post['can_reply']) {
528
+							echo '
502 529
 						<li><a href="', $scripturl, '?action=post;topic=', $post['topic'], '.', $post['start'], '"><span class="generic_icons reply_button"></span>', $txt['reply'], '</a></li>';
530
+			}
503 531
 
504 532
 			// If they *can* quote?
505
-			if ($post['can_quote'])
506
-				echo '
533
+			if ($post['can_quote']) {
534
+							echo '
507 535
 						<li><a href="', $scripturl . '?action=post;topic=', $post['topic'], '.', $post['start'], ';quote=', $post['id'], '"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>';
536
+			}
508 537
 
509 538
 			// How about... even... remove it entirely?!
510
-			if ($post['can_delete'])
511
-				echo '
539
+			if ($post['can_delete']) {
540
+							echo '
512 541
 						<li><a href="', $scripturl, '?action=deletemsg;msg=', $post['id'], ';topic=', $post['topic'], ';profile;u=', $context['member']['id'], ';start=', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>';
542
+			}
513 543
 
514
-			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete'])
515
-				echo '
544
+			if ($post['can_reply'] || $post['can_quote'] || $post['can_delete']) {
545
+							echo '
516 546
 					</ul>
517 547
 				</div>';
548
+			}
518 549
 
519 550
 			echo '
520 551
 			</div>';
521 552
 		}
553
+	} else {
554
+			template_show_list('attachments');
522 555
 	}
523
-	else
524
-		template_show_list('attachments');
525 556
 
526 557
 	// No posts? Just end with a informative message.
527
-	if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts'])))
528
-		echo '
558
+	if ((isset($context['attachments']) && empty($context['attachments'])) || (!isset($context['attachments']) && empty($context['posts']))) {
559
+			echo '
529 560
 			<div class="windowbg2">
530 561
 				', isset($context['attachments']) ? $txt['show_attachments_none'] : ($context['is_topics'] ? $txt['show_topics_none'] : $txt['show_posts_none']), '
531 562
 			</div>';
563
+	}
532 564
 
533 565
 	// Show more page numbers.
534
-	if (!empty($context['page_index']))
535
-		echo '
566
+	if (!empty($context['page_index'])) {
567
+			echo '
536 568
 		<div class="pagesection">
537 569
 			<div class="pagelinks">', $context['page_index'], '</div>
538 570
 		</div>';
539
-}
571
+	}
572
+	}
540 573
 
541 574
 /**
542 575
  * Template for showing alerts within the alerts popup
@@ -546,11 +579,12 @@  discard block
 block discarded – undo
546 579
 	global $context, $txt, $scripturl;
547 580
 
548 581
 	// Do we have an update message?
549
-	if (!empty($context['update_message']))
550
-		echo '
582
+	if (!empty($context['update_message'])) {
583
+			echo '
551 584
 		<div class="infobox">
552 585
 			', $context['update_message'], '.
553 586
 		</div>';
587
+	}
554 588
 
555 589
 	echo '
556 590
 		<div class="cat_bar">
@@ -559,13 +593,12 @@  discard block
 block discarded – undo
559 593
 			</h3>
560 594
 		</div>';
561 595
 
562
-	if (empty($context['alerts']))
563
-		echo '
596
+	if (empty($context['alerts'])) {
597
+			echo '
564 598
 		<div class="information">
565 599
 			', $txt['alerts_none'], '
566 600
 		</div>';
567
-
568
-	else
601
+	} else
569 602
 	{
570 603
 		// Start the form.
571 604
 		echo '
@@ -627,12 +660,12 @@  discard block
 block discarded – undo
627 660
 		</div>' : '';
628 661
 
629 662
 	// No drafts? Just show an informative message.
630
-	if (empty($context['drafts']))
631
-		echo '
663
+	if (empty($context['drafts'])) {
664
+			echo '
632 665
 		<div class="windowbg2 centertext">
633 666
 			', $txt['draft_none'], '
634 667
 		</div>';
635
-	else
668
+	} else
636 669
 	{
637 670
 		// For every draft to be displayed, give it its own div, and show the important details of the draft.
638 671
 		foreach ($context['drafts'] as $draft)
@@ -643,11 +676,13 @@  discard block
 block discarded – undo
643 676
 					<div class="topic_details">
644 677
 						<h5><strong><a href="', $scripturl, '?board=', $draft['board']['id'], '.0">', $draft['board']['name'], '</a> / ', $draft['topic']['link'], '</strong> &nbsp; &nbsp;';
645 678
 
646
-			if (!empty($draft['sticky']))
647
-				echo '<span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>';
679
+			if (!empty($draft['sticky'])) {
680
+							echo '<span class="generic_icons sticky" title="', $txt['sticky_topic'], '"></span>';
681
+			}
648 682
 
649
-			if (!empty($draft['locked']))
650
-				echo '<span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>';
683
+			if (!empty($draft['locked'])) {
684
+							echo '<span class="generic_icons lock" title="', $txt['locked_topic'], '"></span>';
685
+			}
651 686
 
652 687
 			echo '
653 688
 						</h5>
@@ -680,12 +715,13 @@  discard block
 block discarded – undo
680 715
 {
681 716
 	global $context, $scripturl, $txt;
682 717
 
683
-	if (!empty($context['saved_successful']))
684
-		echo '
718
+	if (!empty($context['saved_successful'])) {
719
+			echo '
685 720
 					<div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>';
686
-	elseif (!empty($context['saved_failed']))
687
-		echo '
721
+	} elseif (!empty($context['saved_failed'])) {
722
+			echo '
688 723
 					<div class="errorbox">', $context['saved_failed'], '</div>';
724
+	}
689 725
 
690 726
 	echo '
691 727
 	<div id="edit_buddies">
@@ -699,24 +735,27 @@  discard block
 block discarded – undo
699 735
 				<th scope="col" class="quarter_table">', $txt['name'], '</th>
700 736
 				<th scope="col">', $txt['status'], '</th>';
701 737
 
702
-	if (allowedTo('moderate_forum'))
703
-		echo '
738
+	if (allowedTo('moderate_forum')) {
739
+			echo '
704 740
 				<th scope="col">', $txt['email'], '</th>';
741
+	}
705 742
 
706
-	if (!empty($context['custom_pf']))
707
-		foreach ($context['custom_pf'] as $column)
743
+	if (!empty($context['custom_pf'])) {
744
+			foreach ($context['custom_pf'] as $column)
708 745
 				echo '<th scope="col">', $column['label'], '</th>';
746
+	}
709 747
 
710 748
 	echo '
711 749
 				<th scope="col">', $txt['remove'], '</th>
712 750
 			</tr>';
713 751
 
714 752
 	// If they don't have any buddies don't list them!
715
-	if (empty($context['buddies']))
716
-		echo '
753
+	if (empty($context['buddies'])) {
754
+			echo '
717 755
 			<tr class="windowbg">
718 756
 				<td colspan="', allowedTo('moderate_forum') ? '10' : '9', '"><strong>', $txt['no_buddies'], '</strong></td>
719 757
 			</tr>';
758
+	}
720 759
 
721 760
 		// Now loop through each buddy showing info on each.
722 761
 	else
@@ -728,15 +767,17 @@  discard block
 block discarded – undo
728 767
 					<td>', $buddy['link'], '</td>
729 768
 					<td><a href="', $buddy['online']['href'], '"><span class="' . ($buddy['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $buddy['online']['text'] . '"></span></a></td>';
730 769
 
731
-			if ($buddy['show_email'])
732
-				echo '
770
+			if ($buddy['show_email']) {
771
+							echo '
733 772
 					<td><a href="mailto:' . $buddy['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $buddy['name'] . '"></span></a></td>';
773
+			}
734 774
 
735 775
 			// Show the custom profile fields for this user.
736
-			if (!empty($context['custom_pf']))
737
-				foreach ($context['custom_pf'] as $key => $column)
776
+			if (!empty($context['custom_pf'])) {
777
+							foreach ($context['custom_pf'] as $key => $column)
738 778
 					echo '
739 779
 						<td class="lefttext">', $buddy['options'][$key], '</td>';
780
+			}
740 781
 
741 782
 			echo '
742 783
 					<td><a href="', $scripturl, '?action=profile;area=lists;sa=buddies;u=', $context['id_member'], ';remove=', $buddy['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['buddy_remove'], '"></span></a></td>
@@ -766,9 +807,10 @@  discard block
 block discarded – undo
766 807
 			</dl>
767 808
 		</div>';
768 809
 
769
-	if (!empty($context['token_check']))
770
-		echo '
810
+	if (!empty($context['token_check'])) {
811
+			echo '
771 812
 			<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
813
+	}
772 814
 
773 815
 	echo '
774 816
 		<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -794,12 +836,13 @@  discard block
 block discarded – undo
794 836
 {
795 837
 	global $context, $scripturl, $txt;
796 838
 
797
-	if (!empty($context['saved_successful']))
798
-		echo '
839
+	if (!empty($context['saved_successful'])) {
840
+			echo '
799 841
 					<div class="infobox">', $context['user']['is_owner'] ? $txt['profile_updated_own'] : sprintf($txt['profile_updated_else'], $context['member']['name']), '</div>';
800
-	elseif (!empty($context['saved_failed']))
801
-		echo '
842
+	} elseif (!empty($context['saved_failed'])) {
843
+			echo '
802 844
 					<div class="errorbox">', $context['saved_failed'], '</div>';
845
+	}
803 846
 
804 847
 	echo '
805 848
 	<div id="edit_buddies">
@@ -813,20 +856,22 @@  discard block
 block discarded – undo
813 856
 				<th scope="col" class="quarter_table">', $txt['name'], '</th>
814 857
 				<th scope="col">', $txt['status'], '</th>';
815 858
 
816
-	if (allowedTo('moderate_forum'))
817
-		echo '
859
+	if (allowedTo('moderate_forum')) {
860
+			echo '
818 861
 				<th scope="col">', $txt['email'], '</th>';
862
+	}
819 863
 
820 864
 	echo '
821 865
 				<th scope="col">', $txt['ignore_remove'], '</th>
822 866
 			</tr>';
823 867
 
824 868
 	// If they don't have anyone on their ignore list, don't list it!
825
-	if (empty($context['ignore_list']))
826
-		echo '
869
+	if (empty($context['ignore_list'])) {
870
+			echo '
827 871
 			<tr class="windowbg">
828 872
 				<td colspan="', allowedTo('moderate_forum') ? '4' : '3', '"><strong>', $txt['no_ignore'], '</strong></td>
829 873
 			</tr>';
874
+	}
830 875
 
831 876
 	// Now loop through each buddy showing info on each.
832 877
 	foreach ($context['ignore_list'] as $member)
@@ -836,9 +881,10 @@  discard block
 block discarded – undo
836 881
 				<td>', $member['link'], '</td>
837 882
 				<td><a href="', $member['online']['href'], '"><span class="' . ($member['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $member['online']['text'] . '"></span></a></td>';
838 883
 
839
-		if ($member['show_email'])
840
-			echo '
884
+		if ($member['show_email']) {
885
+					echo '
841 886
 				<td><a href="mailto:' . $member['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $member['name'] . '"></span></a></td>';
887
+		}
842 888
 		echo '
843 889
 				<td><a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=lists;sa=ignore;remove=', $member['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons delete" title="', $txt['ignore_remove'], '"></span></a></td>
844 890
 			</tr>';
@@ -865,9 +911,10 @@  discard block
 block discarded – undo
865 911
 			</dl>
866 912
 		</div>';
867 913
 
868
-	if (!empty($context['token_check']))
869
-		echo '
914
+	if (!empty($context['token_check'])) {
915
+			echo '
870 916
 		<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
917
+	}
871 918
 
872 919
 	echo '
873 920
 		<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -912,9 +959,10 @@  discard block
 block discarded – undo
912 959
 					<a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip'], ';u=', $context['member']['id'], '">', $context['last_ip'], '</a>';
913 960
 
914 961
 	// Second address detected?
915
-	if (!empty($context['last_ip2']))
916
-		echo '
962
+	if (!empty($context['last_ip2'])) {
963
+			echo '
917 964
 					, <a href="', $scripturl, '?action=profile;area=tracking;sa=ip;searchip=', $context['last_ip2'], ';u=', $context['member']['id'], '">', $context['last_ip2'], '</a>';
965
+	}
918 966
 
919 967
 	echo '
920 968
 				</dd>';
@@ -979,9 +1027,10 @@  discard block
 block discarded – undo
979 1027
 				<h3 class="catbg">', $txt['whois_title'], ' ', $context['ip'], '</h3>
980 1028
 			</div>
981 1029
 			<div class="windowbg2 noup">';
982
-			foreach ($context['whois_servers'] as $server)
983
-			echo '
1030
+			foreach ($context['whois_servers'] as $server) {
1031
+						echo '
984 1032
 				<a href="', $server['url'], '" target="_blank" class="new_win"', isset($context['auto_whois_server']) && $context['auto_whois_server']['name'] == $server['name'] ? ' style="font-weight: bold;"' : '', '>', $server['name'], '</a><br>';
1033
+			}
985 1034
 			echo '
986 1035
 			</div>
987 1036
 			<br>';
@@ -992,10 +1041,10 @@  discard block
 block discarded – undo
992 1041
 		<div class="cat_bar">
993 1042
 			<h3 class="catbg">', $txt['members_from_ip'], ' ', $context['ip'], '</h3>
994 1043
 		</div>';
995
-	if (empty($context['ips']))
996
-		echo '
1044
+	if (empty($context['ips'])) {
1045
+			echo '
997 1046
 		<p class="windowbg2 description"><em>', $txt['no_members_from_ip'], '</em></p>';
998
-	else
1047
+	} else
999 1048
 	{
1000 1049
 		echo '
1001 1050
 		<table class="table_grid">
@@ -1008,12 +1057,13 @@  discard block
 block discarded – undo
1008 1057
 			<tbody>';
1009 1058
 
1010 1059
 		// Loop through each of the members and display them.
1011
-		foreach ($context['ips'] as $ip => $memberlist)
1012
-			echo '
1060
+		foreach ($context['ips'] as $ip => $memberlist) {
1061
+					echo '
1013 1062
 				<tr class="windowbg">
1014 1063
 					<td><a href="', $context['base_url'], ';searchip=', $ip, '">', $ip, '</a></td>
1015 1064
 					<td>', implode(', ', $memberlist), '</td>
1016 1065
 				</tr>';
1066
+		}
1017 1067
 
1018 1068
 		echo '
1019 1069
 			</tbody>
@@ -1059,8 +1109,7 @@  discard block
 block discarded – undo
1059 1109
 	{
1060 1110
 		echo '
1061 1111
 		<div class="information">', $txt['showPermissions_all'], '</div>';
1062
-	}
1063
-	else
1112
+	} else
1064 1113
 	{
1065 1114
 		echo '
1066 1115
 		<div class="information">',$txt['showPermissions_help'], '</div>
@@ -1074,9 +1123,10 @@  discard block
 block discarded – undo
1074 1123
 				</div>
1075 1124
 				<div class="windowbg smalltext">
1076 1125
 					', $txt['showPermissions_restricted_boards_desc'], ':<br>';
1077
-				foreach ($context['no_access_boards'] as $no_access_board)
1078
-					echo '
1126
+				foreach ($context['no_access_boards'] as $no_access_board) {
1127
+									echo '
1079 1128
 						<a href="', $scripturl, '?board=', $no_access_board['id'], '.0">', $no_access_board['name'], '</a>', $no_access_board['is_last'] ? '' : ', ';
1129
+				}
1080 1130
 				echo '
1081 1131
 				</div>';
1082 1132
 		}
@@ -1108,12 +1158,13 @@  discard block
 block discarded – undo
1108 1158
 								</td>
1109 1159
 								<td class="smalltext">';
1110 1160
 
1111
-				if ($permission['is_denied'])
1112
-					echo '
1161
+				if ($permission['is_denied']) {
1162
+									echo '
1113 1163
 									<span class="alert">', $txt['showPermissions_denied'], ':&nbsp;', implode(', ', $permission['groups']['denied']), '</span>';
1114
-				else
1115
-					echo '
1164
+				} else {
1165
+									echo '
1116 1166
 									', $txt['showPermissions_given'], ':&nbsp;', implode(', ', $permission['groups']['allowed']);
1167
+				}
1117 1168
 
1118 1169
 					echo '
1119 1170
 								</td>
@@ -1123,10 +1174,10 @@  discard block
 block discarded – undo
1123 1174
 						</tbody>
1124 1175
 					</table>
1125 1176
 				</div><br>';
1126
-		}
1127
-		else
1128
-			echo '
1177
+		} else {
1178
+					echo '
1129 1179
 			<p class="windowbg2">', $txt['showPermissions_none_general'], '</p>';
1180
+		}
1130 1181
 
1131 1182
 		// Board permission section.
1132 1183
 		echo '
@@ -1136,14 +1187,16 @@  discard block
 block discarded – undo
1136 1187
 						<a id="board_permissions"></a>', $txt['showPermissions_select'], ':
1137 1188
 						<select name="board" onchange="if (this.options[this.selectedIndex].value) this.form.submit();">
1138 1189
 							<option value="0"', $context['board'] == 0 ? ' selected' : '', '>', $txt['showPermissions_global'], '&nbsp;</option>';
1139
-				if (!empty($context['boards']))
1140
-					echo '
1190
+				if (!empty($context['boards'])) {
1191
+									echo '
1141 1192
 							<option value="" disabled>---------------------------</option>';
1193
+				}
1142 1194
 
1143 1195
 				// Fill the box with any local permission boards.
1144
-				foreach ($context['boards'] as $board)
1145
-					echo '
1196
+				foreach ($context['boards'] as $board) {
1197
+									echo '
1146 1198
 							<option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['name'], ' (', $board['profile_name'], ')</option>';
1199
+				}
1147 1200
 
1148 1201
 				echo '
1149 1202
 						</select>
@@ -1174,8 +1227,7 @@  discard block
 block discarded – undo
1174 1227
 				{
1175 1228
 					echo '
1176 1229
 							<span class="alert">', $txt['showPermissions_denied'], ':&nbsp;', implode(', ', $permission['groups']['denied']), '</span>';
1177
-				}
1178
-				else
1230
+				} else
1179 1231
 				{
1180 1232
 					echo '
1181 1233
 							', $txt['showPermissions_given'], ': &nbsp;', implode(', ', $permission['groups']['allowed']);
@@ -1187,10 +1239,10 @@  discard block
 block discarded – undo
1187 1239
 			echo '
1188 1240
 				</tbody>
1189 1241
 			</table>';
1190
-		}
1191
-		else
1192
-			echo '
1242
+		} else {
1243
+					echo '
1193 1244
 			<p class="windowbg2">', $txt['showPermissions_none_board'], '</p>';
1245
+		}
1194 1246
 	echo '
1195 1247
 			</div>
1196 1248
 		</div>';
@@ -1232,9 +1284,10 @@  discard block
 block discarded – undo
1232 1284
 			</div>';
1233 1285
 
1234 1286
 	// If they haven't post at all, don't draw the graph.
1235
-	if (empty($context['posts_by_time']))
1236
-		echo '
1287
+	if (empty($context['posts_by_time'])) {
1288
+			echo '
1237 1289
 			<p class="centertext padding">', $txt['statPanel_noPosts'], '</p>';
1290
+	}
1238 1291
 	// Otherwise do!
1239 1292
 	else
1240 1293
 	{
@@ -1273,11 +1326,10 @@  discard block
 block discarded – undo
1273 1326
 					</h3>
1274 1327
 				</div>';
1275 1328
 
1276
-	if (empty($context['popular_boards']))
1277
-		echo '
1329
+	if (empty($context['popular_boards'])) {
1330
+			echo '
1278 1331
 				<p class="centertext padding">', $txt['statPanel_noPosts'], '</p>';
1279
-
1280
-	else
1332
+	} else
1281 1333
 	{
1282 1334
 		echo '
1283 1335
 				<dl class="stats">';
@@ -1308,10 +1360,10 @@  discard block
 block discarded – undo
1308 1360
 					</h3>
1309 1361
 				</div>';
1310 1362
 
1311
-	if (empty($context['board_activity']))
1312
-		echo '
1363
+	if (empty($context['board_activity'])) {
1364
+			echo '
1313 1365
 				<p class="centertext padding">', $txt['statPanel_noPosts'], '</p>';
1314
-	else
1366
+	} else
1315 1367
 	{
1316 1368
 		echo '
1317 1369
 				<dl class="stats">';
@@ -1359,41 +1411,46 @@  discard block
 block discarded – undo
1359 1411
 				<h3 class="catbg profile_hd">';
1360 1412
 
1361 1413
 		// Don't say "Profile" if this isn't the profile...
1362
-		if (!empty($context['profile_header_text']))
1363
-			echo '
1414
+		if (!empty($context['profile_header_text'])) {
1415
+					echo '
1364 1416
 					', $context['profile_header_text'];
1365
-		else
1366
-			echo '
1417
+		} else {
1418
+					echo '
1367 1419
 					', $txt['profile'];
1420
+		}
1368 1421
 
1369 1422
 		echo '
1370 1423
 				</h3>
1371 1424
 			</div>';
1372 1425
 
1373 1426
 	// Have we some description?
1374
-	if ($context['page_desc'])
1375
-		echo '
1427
+	if ($context['page_desc']) {
1428
+			echo '
1376 1429
 			<p class="information">', $context['page_desc'], '</p>';
1430
+	}
1377 1431
 
1378 1432
 	echo '
1379 1433
 			<div class="roundframe">';
1380 1434
 
1381 1435
 	// Any bits at the start?
1382
-	if (!empty($context['profile_prehtml']))
1383
-		echo '
1436
+	if (!empty($context['profile_prehtml'])) {
1437
+			echo '
1384 1438
 				<div>', $context['profile_prehtml'], '</div>';
1439
+	}
1385 1440
 
1386
-	if (!empty($context['profile_fields']))
1387
-		echo '
1441
+	if (!empty($context['profile_fields'])) {
1442
+			echo '
1388 1443
 				<dl class="settings">';
1444
+	}
1389 1445
 
1390 1446
 	// Start the big old loop 'of love.
1391 1447
 	$lastItem = 'hr';
1392 1448
 	foreach ($context['profile_fields'] as $key => $field)
1393 1449
 	{
1394 1450
 		// We add a little hack to be sure we never get more than one hr in a row!
1395
-		if ($lastItem == 'hr' && $field['type'] == 'hr')
1396
-			continue;
1451
+		if ($lastItem == 'hr' && $field['type'] == 'hr') {
1452
+					continue;
1453
+		}
1397 1454
 
1398 1455
 		$lastItem = $field['type'];
1399 1456
 		if ($field['type'] == 'hr')
@@ -1402,48 +1459,50 @@  discard block
 block discarded – undo
1402 1459
 				</dl>
1403 1460
 				<hr>
1404 1461
 				<dl class="settings">';
1405
-		}
1406
-		elseif ($field['type'] == 'callback')
1462
+		} elseif ($field['type'] == 'callback')
1407 1463
 		{
1408 1464
 			if (isset($field['callback_func']) && function_exists('template_profile_' . $field['callback_func']))
1409 1465
 			{
1410 1466
 				$callback_func = 'template_profile_' . $field['callback_func'];
1411 1467
 				$callback_func();
1412 1468
 			}
1413
-		}
1414
-		else
1469
+		} else
1415 1470
 		{
1416 1471
 			echo '
1417 1472
 					<dt>
1418 1473
 						<strong', !empty($field['is_error']) ? ' class="error"' : '', '>', $field['type'] !== 'label' ? '<label for="' . $key . '">' : '', $field['label'], $field['type'] !== 'label' ? '</label>' : '', '</strong>';
1419 1474
 
1420 1475
 			// Does it have any subtext to show?
1421
-			if (!empty($field['subtext']))
1422
-				echo '
1476
+			if (!empty($field['subtext'])) {
1477
+							echo '
1423 1478
 						<br>
1424 1479
 						<span class="smalltext">', $field['subtext'], '</span>';
1480
+			}
1425 1481
 
1426 1482
 			echo '
1427 1483
 					</dt>
1428 1484
 					<dd>';
1429 1485
 
1430 1486
 			// Want to put something infront of the box?
1431
-			if (!empty($field['preinput']))
1432
-				echo '
1487
+			if (!empty($field['preinput'])) {
1488
+							echo '
1433 1489
 						', $field['preinput'];
1490
+			}
1434 1491
 
1435 1492
 			// What type of data are we showing?
1436
-			if ($field['type'] == 'label')
1437
-				echo '
1493
+			if ($field['type'] == 'label') {
1494
+							echo '
1438 1495
 						', $field['value'];
1496
+			}
1439 1497
 
1440 1498
 			// Maybe it's a text box - very likely!
1441 1499
 			elseif (in_array($field['type'], array('int', 'float', 'text', 'password', 'color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'number', 'time', 'url')))
1442 1500
 			{
1443
-				if ($field['type'] == 'int' || $field['type'] == 'float')
1444
-					$type = 'number';
1445
-				else
1446
-					$type = $field['type'];
1501
+				if ($field['type'] == 'int' || $field['type'] == 'float') {
1502
+									$type = 'number';
1503
+				} else {
1504
+									$type = $field['type'];
1505
+				}
1447 1506
 				$step = $field['type'] == 'float' ? ' step="0.1"' : '';
1448 1507
 
1449 1508
 
@@ -1451,9 +1510,10 @@  discard block
 block discarded – undo
1451 1510
 						<input type="', $type, '" name="', $key, '" id="', $key, '" size="', empty($field['size']) ? 30 : $field['size'], '" value="', $field['value'], '" ', $field['input_attr'], ' class="input_', $field['type'] == 'password' ? 'password' : 'text', '"', $step, '>';
1452 1511
 			}
1453 1512
 			// You "checking" me out? ;)
1454
-			elseif ($field['type'] == 'check')
1455
-				echo '
1513
+			elseif ($field['type'] == 'check') {
1514
+							echo '
1456 1515
 						<input type="hidden" name="', $key, '" value="0"><input type="checkbox" name="', $key, '" id="', $key, '"', !empty($field['value']) ? ' checked' : '', ' value="1" class="input_check" ', $field['input_attr'], '>';
1516
+			}
1457 1517
 
1458 1518
 			// Always fun - select boxes!
1459 1519
 			elseif ($field['type'] == 'select')
@@ -1464,13 +1524,15 @@  discard block
 block discarded – undo
1464 1524
 				if (isset($field['options']))
1465 1525
 				{
1466 1526
 					// Is this some code to generate the options?
1467
-					if (!is_array($field['options']))
1468
-						$field['options'] = $field['options']();
1527
+					if (!is_array($field['options'])) {
1528
+											$field['options'] = $field['options']();
1529
+					}
1469 1530
 					// Assuming we now have some!
1470
-					if (is_array($field['options']))
1471
-						foreach ($field['options'] as $value => $name)
1531
+					if (is_array($field['options'])) {
1532
+											foreach ($field['options'] as $value => $name)
1472 1533
 							echo '
1473 1534
 								<option value="', $value, '"', $value == $field['value'] ? ' selected' : '', '>', $name, '</option>';
1535
+					}
1474 1536
 				}
1475 1537
 
1476 1538
 				echo '
@@ -1478,25 +1540,28 @@  discard block
 block discarded – undo
1478 1540
 			}
1479 1541
 
1480 1542
 			// Something to end with?
1481
-			if (!empty($field['postinput']))
1482
-				echo '
1543
+			if (!empty($field['postinput'])) {
1544
+							echo '
1483 1545
 							', $field['postinput'];
1546
+			}
1484 1547
 
1485 1548
 			echo '
1486 1549
 					</dd>';
1487 1550
 		}
1488 1551
 	}
1489 1552
 
1490
-	if (!empty($context['profile_fields']))
1491
-		echo '
1553
+	if (!empty($context['profile_fields'])) {
1554
+			echo '
1492 1555
 				</dl>';
1556
+	}
1493 1557
 
1494 1558
 	// Are there any custom profile fields - if so print them!
1495 1559
 	if (!empty($context['custom_fields']))
1496 1560
 	{
1497
-		if ($lastItem != 'hr')
1498
-			echo '
1561
+		if ($lastItem != 'hr') {
1562
+					echo '
1499 1563
 				<hr>';
1564
+		}
1500 1565
 
1501 1566
 		echo '
1502 1567
 				<dl class="settings">';
@@ -1519,13 +1584,14 @@  discard block
 block discarded – undo
1519 1584
 	}
1520 1585
 
1521 1586
 	// Any closing HTML?
1522
-	if (!empty($context['profile_posthtml']))
1523
-		echo '
1587
+	if (!empty($context['profile_posthtml'])) {
1588
+			echo '
1524 1589
 				<div>', $context['profile_posthtml'], '</div>';
1590
+	}
1525 1591
 
1526 1592
 	// Only show the password box if it's actually needed.
1527
-	if ($context['require_password'])
1528
-		echo '
1593
+	if ($context['require_password']) {
1594
+			echo '
1529 1595
 				<dl class="settings">
1530 1596
 					<dt>
1531 1597
 						<strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '><label for="oldpasswrd">', $txt['current_password'], ': </label></strong><br>
@@ -1535,18 +1601,21 @@  discard block
 block discarded – undo
1535 1601
 						<input type="password" name="oldpasswrd" id="oldpasswrd" size="20" style="margin-right: 4ex;" class="input_password">
1536 1602
 					</dd>
1537 1603
 				</dl>';
1604
+	}
1538 1605
 
1539 1606
 	// The button shouldn't say "Change profile" unless we're changing the profile...
1540
-	if (!empty($context['submit_button_text']))
1541
-		echo '
1607
+	if (!empty($context['submit_button_text'])) {
1608
+			echo '
1542 1609
 				<input type="submit" name="save" value="', $context['submit_button_text'], '" class="button_submit">';
1543
-	else
1544
-		echo '
1610
+	} else {
1611
+			echo '
1545 1612
 				<input type="submit" name="save" value="', $txt['change_profile'], '" class="button_submit">';
1613
+	}
1546 1614
 
1547
-	if (!empty($context['token_check']))
1548
-		echo '
1615
+	if (!empty($context['token_check'])) {
1616
+			echo '
1549 1617
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
1618
+	}
1550 1619
 
1551 1620
 	echo '
1552 1621
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -1556,10 +1625,11 @@  discard block
 block discarded – undo
1556 1625
 		</form>';
1557 1626
 
1558 1627
 	// Any final spellchecking stuff?
1559
-	if (!empty($context['show_spellchecking']))
1560
-		echo '
1628
+	if (!empty($context['show_spellchecking'])) {
1629
+			echo '
1561 1630
 		<form name="spell_form" id="spell_form" method="post" accept-charset="', $context['character_set'], '" target="spellWindow" action="', $scripturl, '?action=spellcheck"><input type="hidden" name="spellstring" value=""></form>';
1562
-}
1631
+	}
1632
+	}
1563 1633
 
1564 1634
 /**
1565 1635
  * Personal Message settings.
@@ -1596,10 +1666,11 @@  discard block
 block discarded – undo
1596 1666
 										<select name="pm_receive_from" id="pm_receive_from">
1597 1667
 												<option value="0"', empty($context['receive_from']) || (empty($modSettings['enable_buddylist']) && $context['receive_from'] < 3) ? ' selected' : '', '>', $txt['pm_receive_from_everyone'], '</option>';
1598 1668
 
1599
-	if (!empty($modSettings['enable_buddylist']))
1600
-		echo '
1669
+	if (!empty($modSettings['enable_buddylist'])) {
1670
+			echo '
1601 1671
 												<option value="1"', !empty($context['receive_from']) && $context['receive_from'] == 1 ? ' selected' : '', '>', $txt['pm_receive_from_ignore'], '</option>
1602 1672
 												<option value="2"', !empty($context['receive_from']) && $context['receive_from'] == 2 ? ' selected' : '', '>', $txt['pm_receive_from_buddies'], '</option>';
1673
+	}
1603 1674
 
1604 1675
 	echo '
1605 1676
 												<option value="3"', !empty($context['receive_from']) && $context['receive_from'] > 2 ? ' selected' : '', '>', $txt['pm_receive_from_admins'], '</option>
@@ -1642,11 +1713,12 @@  discard block
 block discarded – undo
1642 1713
 		if (empty($setting) || !is_array($setting))
1643 1714
 		{
1644 1715
 			// Insert a separator (unless this is the first item in the list)
1645
-			if ($i !== $first_option_key)
1646
-				echo '
1716
+			if ($i !== $first_option_key) {
1717
+							echo '
1647 1718
 				</dl>
1648 1719
 				<hr>
1649 1720
 				<dl class="settings">';
1721
+			}
1650 1722
 
1651 1723
 			// Should we give a name to this section?
1652 1724
 			if (is_string($setting) && !empty($setting))
@@ -1654,48 +1726,52 @@  discard block
 block discarded – undo
1654 1726
 				$titled_section = true;
1655 1727
 				echo '
1656 1728
 					<dt><strong>' . $setting . '</strong></dt><dd></dd>';
1729
+			} else {
1730
+							$titled_section = false;
1657 1731
 			}
1658
-			else
1659
-				$titled_section = false;
1660 1732
 
1661 1733
 			continue;
1662 1734
 		}
1663 1735
 
1664 1736
 		// Is this disabled?
1665
-		if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled']))
1666
-			continue;
1667
-		elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage']))
1668
-			continue;
1669
-		elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored']))
1670
-			continue;
1671
-		elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist']))
1672
-			continue;
1673
-		elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg']))
1674
-			continue;
1675
-		elseif ($setting['id'] == 'topics_per_page' && !empty($modSettings['disableCustomPerPage']))
1676
-			continue;
1677
-		elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled']))))
1678
-			continue;
1679
-		elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled']))))
1680
-			continue;
1737
+		if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) {
1738
+					continue;
1739
+		} elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) {
1740
+					continue;
1741
+		} elseif ($setting['id'] == 'show_no_censored' && empty($modSettings['allow_no_censored'])) {
1742
+					continue;
1743
+		} elseif ($setting['id'] == 'posts_apply_ignore_list' && empty($modSettings['enable_buddylist'])) {
1744
+					continue;
1745
+		} elseif ($setting['id'] == 'wysiwyg_default' && !empty($modSettings['disable_wysiwyg'])) {
1746
+					continue;
1747
+		} elseif ($setting['id'] == 'topics_per_page' && !empty($modSettings['disableCustomPerPage'])) {
1748
+					continue;
1749
+		} elseif ($setting['id'] == 'drafts_autosave_enabled' && (empty($modSettings['drafts_autosave_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) {
1750
+					continue;
1751
+		} elseif ($setting['id'] == 'drafts_show_saved_enabled' && (empty($modSettings['drafts_show_saved_enabled']) || (empty($modSettings['drafts_post_enabled']) && empty($modSettings['drafts_pm_enabled'])))) {
1752
+					continue;
1753
+		}
1681 1754
 
1682
-		if (!isset($setting['type']) || $setting['type'] == 'bool')
1683
-			$setting['type'] = 'checkbox';
1684
-		elseif ($setting['type'] == 'int' || $setting['type'] == 'integer')
1685
-			$setting['type'] = 'number';
1686
-		elseif ($setting['type'] == 'string')
1687
-			$setting['type'] = 'text';
1755
+		if (!isset($setting['type']) || $setting['type'] == 'bool') {
1756
+					$setting['type'] = 'checkbox';
1757
+		} elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') {
1758
+					$setting['type'] = 'number';
1759
+		} elseif ($setting['type'] == 'string') {
1760
+					$setting['type'] = 'text';
1761
+		}
1688 1762
 
1689
-		if (isset($setting['options']))
1690
-			$setting['type'] = 'list';
1763
+		if (isset($setting['options'])) {
1764
+					$setting['type'] = 'list';
1765
+		}
1691 1766
 
1692 1767
 		echo '
1693 1768
 					<dt>
1694 1769
 						<label for="', $setting['id'], '">', !$titled_section ? '<strong>' : '', $setting['label'], !$titled_section ? '</strong>' : '', '</label>';
1695 1770
 
1696
-		if (isset($setting['description']))
1697
-			echo '
1771
+		if (isset($setting['description'])) {
1772
+					echo '
1698 1773
 						<br><span class="smalltext">', $setting['description'], '</span>';
1774
+		}
1699 1775
 		echo '
1700 1776
 					</dt>
1701 1777
 					<dd>';
@@ -1733,13 +1809,11 @@  discard block
 block discarded – undo
1733 1809
 
1734 1810
 				echo '
1735 1811
 						<input type="number"', $min . $max . $step;
1736
-			}
1737
-			else if (isset($setting['type']) && $setting['type'] == 'url')
1812
+			} else if (isset($setting['type']) && $setting['type'] == 'url')
1738 1813
 			{
1739 1814
 				echo'
1740 1815
 						<input type="url"';
1741
-			}
1742
-			else
1816
+			} else
1743 1817
 			{
1744 1818
 				echo '
1745 1819
 						<input type="text"';
@@ -1778,8 +1852,8 @@  discard block
 block discarded – undo
1778 1852
 				<dl class="settings">';
1779 1853
 
1780 1854
 	// Allow notification on announcements to be disabled?
1781
-	if (!empty($modSettings['allow_disableAnnounce']))
1782
-		echo '
1855
+	if (!empty($modSettings['allow_disableAnnounce'])) {
1856
+			echo '
1783 1857
 					<dt>
1784 1858
 						<label for="notify_announcements">', $txt['notify_important_email'], '</label>
1785 1859
 					</dt>
@@ -1787,9 +1861,10 @@  discard block
 block discarded – undo
1787 1861
 						<input type="hidden" name="notify_announcements" value="0">
1788 1862
 						<input type="checkbox" id="notify_announcements" name="notify_announcements" value="1"', !empty($context['member']['notify_announcements']) ? ' checked' : '', ' class="input_check">
1789 1863
 					</dd>';
1864
+	}
1790 1865
 
1791
-	if (!empty($modSettings['enable_ajax_alerts']))
1792
-		echo '
1866
+	if (!empty($modSettings['enable_ajax_alerts'])) {
1867
+			echo '
1793 1868
 					<dt>
1794 1869
 						<label for="notify_send_body">', $txt['notify_alert_timeout'], '</label>
1795 1870
 					</dt>
@@ -1797,6 +1872,7 @@  discard block
 block discarded – undo
1797 1872
 						<input type="number" size="4" id="notify_alert_timeout" name="opt_alert_timeout" min="0" value="', $context['member']['alert_timeout'], '" class="input_text">
1798 1873
 					</dd>
1799 1874
 		';
1875
+	}
1800 1876
 
1801 1877
 	echo '
1802 1878
 				</dl>
@@ -1826,9 +1902,10 @@  discard block
 block discarded – undo
1826 1902
 					<td colspan="3">';
1827 1903
 				$label = $txt['alert_opt_' . $opts[1]];
1828 1904
 				$label_pos = isset($opts['label']) ? $opts['label'] : '';
1829
-				if ($label_pos == 'before')
1830
-					echo '
1905
+				if ($label_pos == 'before') {
1906
+									echo '
1831 1907
 					<label for="opt_', $opts[1], '">', $label, '</label>';
1908
+				}
1832 1909
 
1833 1910
 				$this_value = isset($context['alert_prefs'][$opts[1]]) ? $context['alert_prefs'][$opts[1]] : 0;
1834 1911
 				switch ($opts[0])
@@ -1840,17 +1917,19 @@  discard block
 block discarded – undo
1840 1917
 					case 'select':
1841 1918
 						echo '
1842 1919
 						<select name="opt_', $opts[1], '" id="opt_', $opts[1], '">';
1843
-						foreach ($opts['opts'] as $k => $v)
1844
-							echo '
1920
+						foreach ($opts['opts'] as $k => $v) {
1921
+													echo '
1845 1922
 							<option value="', $k, '"', $this_value == $k ? ' selected' : '', '>', $v, '</option>';
1923
+						}
1846 1924
 						echo '
1847 1925
 						</select>';
1848 1926
 						break;
1849 1927
 				}
1850 1928
 
1851
-				if ($label_pos == 'after')
1852
-					echo '
1929
+				if ($label_pos == 'after') {
1930
+									echo '
1853 1931
 					<label for="opt_', $opts[1], '">', $label, '</label>';
1932
+				}
1854 1933
 
1855 1934
 				echo '
1856 1935
 					</td>
@@ -1964,11 +2043,12 @@  discard block
 block discarded – undo
1964 2043
 			<p class="information">', $txt['groupMembership_info'], '</p>';
1965 2044
 
1966 2045
 	// Do we have an update message?
1967
-	if (!empty($context['update_message']))
1968
-		echo '
2046
+	if (!empty($context['update_message'])) {
2047
+			echo '
1969 2048
 			<div class="infobox">
1970 2049
 				', $context['update_message'], '.
1971 2050
 			</div>';
2051
+	}
1972 2052
 
1973 2053
 	echo '
1974 2054
 		<div id="groups">';
@@ -1990,8 +2070,7 @@  discard block
 block discarded – undo
1990 2070
 					</div>
1991 2071
 				</div>
1992 2072
 			</div>';
1993
-	}
1994
-	else
2073
+	} else
1995 2074
 	{
1996 2075
 		echo '
1997 2076
 			<div class="title_bar">
@@ -2003,27 +2082,30 @@  discard block
 block discarded – undo
2003 2082
 			echo '
2004 2083
 					<div class="windowbg" id="primdiv_', $group['id'], '">';
2005 2084
 
2006
-				if ($context['can_edit_primary'])
2007
-					echo '
2085
+				if ($context['can_edit_primary']) {
2086
+									echo '
2008 2087
 						<input type="radio" name="primary" id="primary_', $group['id'], '" value="', $group['id'], '"', $group['is_primary'] ? ' checked' : '', ' onclick="highlightSelected(\'primdiv_' . $group['id'] . '\');"', $group['can_be_primary'] ? '' : ' disabled', ' class="input_radio">';
2088
+				}
2009 2089
 
2010 2090
 				echo '
2011 2091
 						<label for="primary_', $group['id'], '"><strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '</label>';
2012 2092
 
2013 2093
 				// Can they leave their group?
2014
-				if ($group['can_leave'])
2015
-					echo '
2094
+				if ($group['can_leave']) {
2095
+									echo '
2016 2096
 						<a href="' . $scripturl . '?action=profile;save;u=' . $context['id_member'] . ';area=groupmembership;' . $context['session_var'] . '=' . $context['session_id'] . ';gid=' . $group['id'] . ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '">' . $txt['leave_group'] . '</a>';
2097
+				}
2017 2098
 
2018 2099
 				echo '
2019 2100
 					</div>';
2020 2101
 		}
2021 2102
 
2022
-		if ($context['can_edit_primary'])
2023
-			echo '
2103
+		if ($context['can_edit_primary']) {
2104
+					echo '
2024 2105
 			<div class="padding righttext">
2025 2106
 				<input type="submit" value="', $txt['make_primary'], '" class="button_submit">
2026 2107
 			</div>';
2108
+		}
2027 2109
 
2028 2110
 		// Any groups they can join?
2029 2111
 		if (!empty($context['groups']['available']))
@@ -2039,15 +2121,16 @@  discard block
 block discarded – undo
2039 2121
 					<div class="windowbg">
2040 2122
 						<strong>', (empty($group['color']) ? $group['name'] : '<span style="color: ' . $group['color'] . '">' . $group['name'] . '</span>'), '</strong>', (!empty($group['desc']) ? '<br><span class="smalltext">' . $group['desc'] . '</span>' : ''), '';
2041 2123
 
2042
-				if ($group['type'] == 3)
2043
-					echo '
2124
+				if ($group['type'] == 3) {
2125
+									echo '
2044 2126
 						<a href="', $scripturl, '?action=profile;save;u=', $context['id_member'], ';area=groupmembership;', $context['session_var'], '=', $context['session_id'], ';gid=', $group['id'], ';', $context[$context['token_check'] . '_token_var'], '=', $context[$context['token_check'] . '_token'], '" class="button floatright">', $txt['join_group'], '</a>';
2045
-				elseif ($group['type'] == 2 && $group['pending'])
2046
-					echo '
2127
+				} elseif ($group['type'] == 2 && $group['pending']) {
2128
+									echo '
2047 2129
 						<span class="floatright">', $txt['approval_pending'], '</span>';
2048
-				elseif ($group['type'] == 2)
2049
-					echo '
2130
+				} elseif ($group['type'] == 2) {
2131
+									echo '
2050 2132
 						<a href="', $scripturl, '?action=profile;u=', $context['id_member'], ';area=groupmembership;request=', $group['id'], '" class="button floatright">', $txt['request_group'], '</a>';
2133
+				}
2051 2134
 
2052 2135
 				echo '
2053 2136
 					</div>';
@@ -2070,9 +2153,10 @@  discard block
 block discarded – undo
2070 2153
 
2071 2154
 			prevDiv.className = "windowbg";
2072 2155
 		}';
2073
-		if (isset($context['groups']['member'][$context['primary_group']]))
2074
-			echo '
2156
+		if (isset($context['groups']['member'][$context['primary_group']])) {
2157
+					echo '
2075 2158
 		highlightSelected("primdiv_' . $context['primary_group'] . '");';
2159
+		}
2076 2160
 		echo '
2077 2161
 	</script>';
2078 2162
 	}
@@ -2080,9 +2164,10 @@  discard block
 block discarded – undo
2080 2164
 	echo '
2081 2165
 		</div>';
2082 2166
 
2083
-	if (!empty($context['token_check']))
2084
-		echo '
2167
+	if (!empty($context['token_check'])) {
2168
+			echo '
2085 2169
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2170
+	}
2086 2171
 
2087 2172
 	echo '
2088 2173
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2129,14 +2214,15 @@  discard block
 block discarded – undo
2129 2214
 
2130 2215
 		foreach ($category['boards'] as $board)
2131 2216
 		{
2132
-			if ($i == $limit)
2133
-				echo '
2217
+			if ($i == $limit) {
2218
+							echo '
2134 2219
 						</ul>
2135 2220
 					</li>
2136 2221
 				</ul>
2137 2222
 				<ul class="ignoreboards floatright">
2138 2223
 					<li class="category">
2139 2224
 						<ul>';
2225
+			}
2140 2226
 
2141 2227
 			echo '
2142 2228
 							<li class="board" style="margin-', $context['right_to_left'] ? 'right' : 'left', ': ', $board['child_level'], 'em;">
@@ -2182,10 +2268,11 @@  discard block
 block discarded – undo
2182 2268
 
2183 2269
 	// Work out the starting color.
2184 2270
 	$context['current_color'] = $context['colors'][0];
2185
-	foreach ($context['colors'] as $limit => $color)
2186
-		if ($context['member']['warning'] >= $limit)
2271
+	foreach ($context['colors'] as $limit => $color) {
2272
+			if ($context['member']['warning'] >= $limit)
2187 2273
 			$context['current_color'] = $color;
2188
-}
2274
+	}
2275
+	}
2189 2276
 
2190 2277
 // Show all warnings of a user?
2191 2278
 function template_viewWarning()
@@ -2224,14 +2311,15 @@  discard block
 block discarded – undo
2224 2311
 				</dd>';
2225 2312
 
2226 2313
 		// There's some impact of this?
2227
-		if (!empty($context['level_effects'][$context['current_level']]))
2228
-			echo '
2314
+		if (!empty($context['level_effects'][$context['current_level']])) {
2315
+					echo '
2229 2316
 				<dt>
2230 2317
 					<strong>', $txt['profile_viewwarning_impact'], ':</strong>
2231 2318
 				</dt>
2232 2319
 				<dd>
2233 2320
 					', $context['level_effects'][$context['current_level']], '
2234 2321
 				</dd>';
2322
+		}
2235 2323
 
2236 2324
 		echo '
2237 2325
 			</dl>
@@ -2269,10 +2357,11 @@  discard block
 block discarded – undo
2269 2357
 
2270 2358
 			// Otherwise see what we can do...';
2271 2359
 
2272
-	foreach ($context['notification_templates'] as $k => $type)
2273
-		echo '
2360
+	foreach ($context['notification_templates'] as $k => $type) {
2361
+			echo '
2274 2362
 			if (index == ', $k, ')
2275 2363
 				document.getElementById(\'warn_body\').value = "', strtr($type['body'], array('"' => "'", "\n" => '\\n', "\r" => '')), '";';
2364
+	}
2276 2365
 
2277 2366
 	echo '
2278 2367
 		}
@@ -2282,10 +2371,11 @@  discard block
 block discarded – undo
2282 2371
 			// Also set the right effect.
2283 2372
 			effectText = "";';
2284 2373
 
2285
-	foreach ($context['level_effects'] as $limit => $text)
2286
-		echo '
2374
+	foreach ($context['level_effects'] as $limit => $text) {
2375
+			echo '
2287 2376
 			if (slideAmount >= ', $limit, ')
2288 2377
 				effectText = "', $text, '";';
2378
+	}
2289 2379
 
2290 2380
 	echo '
2291 2381
 			setInnerHTML(document.getElementById(\'cur_level_div\'), slideAmount + \'% (\' + effectText + \')\');
@@ -2300,31 +2390,34 @@  discard block
 block discarded – undo
2300 2390
 			</h3>
2301 2391
 		</div>';
2302 2392
 
2303
-	if (!$context['user']['is_owner'])
2304
-		echo '
2393
+	if (!$context['user']['is_owner']) {
2394
+			echo '
2305 2395
 		<p class="information">', $txt['profile_warning_desc'], '</p>';
2396
+	}
2306 2397
 
2307 2398
 	echo '
2308 2399
 		<div class="windowbg">
2309 2400
 			<dl class="settings">';
2310 2401
 
2311
-	if (!$context['user']['is_owner'])
2312
-		echo '
2402
+	if (!$context['user']['is_owner']) {
2403
+			echo '
2313 2404
 				<dt>
2314 2405
 					<strong>', $txt['profile_warning_name'], ':</strong>
2315 2406
 				</dt>
2316 2407
 				<dd>
2317 2408
 					<strong>', $context['member']['name'], '</strong>
2318 2409
 				</dd>';
2410
+	}
2319 2411
 
2320 2412
 	echo '
2321 2413
 				<dt>
2322 2414
 					<strong>', $txt['profile_warning_level'], ':</strong>';
2323 2415
 
2324 2416
 	// Is there only so much they can apply?
2325
-	if ($context['warning_limit'])
2326
-		echo '
2417
+	if ($context['warning_limit']) {
2418
+			echo '
2327 2419
 					<br><span class="smalltext">', sprintf($txt['profile_warning_limit_attribute'], $context['warning_limit']), '</span>';
2420
+	}
2328 2421
 
2329 2422
 	echo '
2330 2423
 				</dt>
@@ -2377,9 +2470,10 @@  discard block
 block discarded – undo
2377 2470
 						<option value="-1">', $txt['profile_warning_notify_template'], '</option>
2378 2471
 						<option value="-1" disabled>------------------------------</option>';
2379 2472
 
2380
-		foreach ($context['notification_templates'] as $id_template => $template)
2381
-			echo '
2473
+		foreach ($context['notification_templates'] as $id_template => $template) {
2474
+					echo '
2382 2475
 						<option value="', $id_template, '">', $template['title'], '</option>';
2476
+		}
2383 2477
 
2384 2478
 		echo '
2385 2479
 					</select>
@@ -2391,9 +2485,10 @@  discard block
 block discarded – undo
2391 2485
 			</dl>
2392 2486
 			<div class="righttext">';
2393 2487
 
2394
-	if (!empty($context['token_check']))
2395
-		echo '
2488
+	if (!empty($context['token_check'])) {
2489
+			echo '
2396 2490
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2491
+	}
2397 2492
 
2398 2493
 	echo '
2399 2494
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2409,8 +2504,8 @@  discard block
 block discarded – undo
2409 2504
 	echo '
2410 2505
 	<script>';
2411 2506
 
2412
-	if (!$context['user']['is_owner'])
2413
-		echo '
2507
+	if (!$context['user']['is_owner']) {
2508
+			echo '
2414 2509
 		modifyWarnNotify();
2415 2510
 		$(document).ready(function() {
2416 2511
 			$("#preview_button").click(function() {
@@ -2449,6 +2544,7 @@  discard block
 block discarded – undo
2449 2544
 			});
2450 2545
 			return false;
2451 2546
 		}';
2547
+	}
2452 2548
 
2453 2549
 	echo '
2454 2550
 	</script>';
@@ -2471,16 +2567,18 @@  discard block
 block discarded – undo
2471 2567
 			</div>';
2472 2568
 
2473 2569
 	// If deleting another account give them a lovely info box.
2474
-	if (!$context['user']['is_owner'])
2475
-		echo '
2570
+	if (!$context['user']['is_owner']) {
2571
+			echo '
2476 2572
 			<p class="information">', $txt['deleteAccount_desc'], '</p>';
2573
+	}
2477 2574
 	echo '
2478 2575
 			<div class="windowbg2">';
2479 2576
 
2480 2577
 	// If they are deleting their account AND the admin needs to approve it - give them another piece of info ;)
2481
-	if ($context['needs_approval'])
2482
-		echo '
2578
+	if ($context['needs_approval']) {
2579
+			echo '
2483 2580
 				<div class="errorbox">', $txt['deleteAccount_approval'], '</div>';
2581
+	}
2484 2582
 
2485 2583
 	// If the user is deleting their own account warn them first - and require a password!
2486 2584
 	if ($context['user']['is_owner'])
@@ -2492,9 +2590,10 @@  discard block
 block discarded – undo
2492 2590
 					<input type="password" name="oldpasswrd" size="20" class="input_password">&nbsp;&nbsp;&nbsp;&nbsp;
2493 2591
 					<input type="submit" value="', $txt['yes'], '" class="button_submit">';
2494 2592
 
2495
-		if (!empty($context['token_check']))
2496
-			echo '
2593
+		if (!empty($context['token_check'])) {
2594
+					echo '
2497 2595
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2596
+		}
2498 2597
 
2499 2598
 		echo '
2500 2599
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2520,9 +2619,10 @@  discard block
 block discarded – undo
2520 2619
 						<option value="topics">', $txt['deleteAccount_topics'], '</option>
2521 2620
 					</select>';
2522 2621
 
2523
-			if ($context['show_perma_delete'])
2524
-				echo '
2622
+			if ($context['show_perma_delete']) {
2623
+							echo '
2525 2624
 					<br><label for="perma_delete"><input type="checkbox" name="perma_delete" id="perma_delete" value="1" class="input_check">', $txt['deleteAccount_permanent'], ':</label>';
2625
+			}
2526 2626
 
2527 2627
 			echo '
2528 2628
 				</div>';
@@ -2535,9 +2635,10 @@  discard block
 block discarded – undo
2535 2635
 				<div>
2536 2636
 					<input type="submit" value="', $txt['delete'], '" class="button_submit">';
2537 2637
 
2538
-		if (!empty($context['token_check']))
2539
-			echo '
2638
+		if (!empty($context['token_check'])) {
2639
+					echo '
2540 2640
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2641
+		}
2541 2642
 
2542 2643
 		echo '
2543 2644
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -2563,8 +2664,8 @@  discard block
 block discarded – undo
2563 2664
 					<hr>';
2564 2665
 
2565 2666
 	// Only show the password box if it's actually needed.
2566
-	if ($context['require_password'])
2567
-		echo '
2667
+	if ($context['require_password']) {
2668
+			echo '
2568 2669
 					<dl class="settings">
2569 2670
 						<dt>
2570 2671
 							<strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '>', $txt['current_password'], ': </strong><br>
@@ -2574,13 +2675,15 @@  discard block
 block discarded – undo
2574 2675
 							<input type="password" name="oldpasswrd" size="20" style="margin-right: 4ex;" class="input_password">
2575 2676
 						</dd>
2576 2677
 					</dl>';
2678
+	}
2577 2679
 
2578 2680
 	echo '
2579 2681
 					<div class="righttext">';
2580 2682
 
2581
-		if (!empty($context['token_check']))
2582
-			echo '
2683
+		if (!empty($context['token_check'])) {
2684
+					echo '
2583 2685
 				<input type="hidden" name="', $context[$context['token_check'] . '_token_var'], '" value="', $context[$context['token_check'] . '_token'], '">';
2686
+		}
2584 2687
 
2585 2688
 	echo '
2586 2689
 						<input type="submit" value="', $txt['change_profile'], '" class="button_submit">
@@ -2607,9 +2710,10 @@  discard block
 block discarded – undo
2607 2710
 			<ul id="list_errors">';
2608 2711
 
2609 2712
 		// Cycle through each error and display an error message.
2610
-		foreach ($context['post_errors'] as $error)
2611
-			echo '
2713
+		foreach ($context['post_errors'] as $error) {
2714
+					echo '
2612 2715
 				<li>', isset($txt['profile_error_' . $error]) ? $txt['profile_error_' . $error] : $error, '</li>';
2716
+		}
2613 2717
 
2614 2718
 		echo '
2615 2719
 			</ul>';
@@ -2635,12 +2739,13 @@  discard block
 block discarded – undo
2635 2739
 								<select name="id_group" ', ($context['user']['is_owner'] && $context['member']['group_id'] == 1 ? 'onchange="if (this.value != 1 &amp;&amp; !confirm(\'' . $txt['deadmin_confirm'] . '\')) this.value = 1;"' : ''), '>';
2636 2740
 
2637 2741
 		// Fill the select box with all primary member groups that can be assigned to a member.
2638
-		foreach ($context['member_groups'] as $member_group)
2639
-			if (!empty($member_group['can_be_primary']))
2742
+		foreach ($context['member_groups'] as $member_group) {
2743
+					if (!empty($member_group['can_be_primary']))
2640 2744
 				echo '
2641 2745
 									<option value="', $member_group['id'], '"', $member_group['is_primary'] ? ' selected' : '', '>
2642 2746
 										', $member_group['name'], '
2643 2747
 									</option>';
2748
+		}
2644 2749
 		echo '
2645 2750
 								</select>
2646 2751
 							</dd>
@@ -2652,10 +2757,11 @@  discard block
 block discarded – undo
2652 2757
 									<input type="hidden" name="additional_groups[]" value="0">';
2653 2758
 
2654 2759
 		// For each membergroup show a checkbox so members can be assigned to more than one group.
2655
-		foreach ($context['member_groups'] as $member_group)
2656
-			if ($member_group['can_be_additional'])
2760
+		foreach ($context['member_groups'] as $member_group) {
2761
+					if ($member_group['can_be_additional'])
2657 2762
 				echo '
2658 2763
 									<label for="additional_groups-', $member_group['id'], '"><input type="checkbox" name="additional_groups[]" value="', $member_group['id'], '" id="additional_groups-', $member_group['id'], '"', $member_group['is_additional'] ? ' checked' : '', ' class="input_check"> ', $member_group['name'], '</label><br>';
2764
+		}
2659 2765
 		echo '
2660 2766
 								</span>
2661 2767
 								<a href="javascript:void(0);" onclick="document.getElementById(\'additional_groupsList\').style.display = \'block\'; document.getElementById(\'additional_groupsLink\').style.display = \'none\'; return false;" id="additional_groupsLink" style="display: none;" class="toggle_down">', $txt['additional_membergroups_show'], '</a>
@@ -2715,9 +2821,10 @@  discard block
 block discarded – undo
2715 2821
 								<span class="smalltext">', $txt['sig_info'], '</span><br>
2716 2822
 								<br>';
2717 2823
 
2718
-	if ($context['show_spellchecking'])
2719
-		echo '
2824
+	if ($context['show_spellchecking']) {
2825
+			echo '
2720 2826
 								<input type="button" value="', $txt['spell_check'], '" onclick="spellCheck(\'creator\', \'signature\');" class="button_submit">';
2827
+	}
2721 2828
 
2722 2829
 		echo '
2723 2830
 							</dt>
@@ -2725,17 +2832,20 @@  discard block
 block discarded – undo
2725 2832
 								<textarea class="editor" onkeyup="calcCharLeft();" id="signature" name="signature" rows="5" cols="50" style="min-width: 50%; max-width: 99%;">', $context['member']['signature'], '</textarea><br>';
2726 2833
 
2727 2834
 	// If there is a limit at all!
2728
-	if (!empty($context['signature_limits']['max_length']))
2729
-		echo '
2835
+	if (!empty($context['signature_limits']['max_length'])) {
2836
+			echo '
2730 2837
 								<span class="smalltext">', sprintf($txt['max_sig_characters'], $context['signature_limits']['max_length']), ' <span id="signatureLeft">', $context['signature_limits']['max_length'], '</span></span><br>';
2838
+	}
2731 2839
 
2732
-	if (!empty($context['show_preview_button']))
2733
-		echo '
2840
+	if (!empty($context['show_preview_button'])) {
2841
+			echo '
2734 2842
 								<input type="button" name="preview_signature" id="preview_button" value="', $txt['preview_signature'], '" class="button_submit">';
2843
+	}
2735 2844
 
2736
-	if ($context['signature_warning'])
2737
-		echo '
2845
+	if ($context['signature_warning']) {
2846
+			echo '
2738 2847
 								<span class="smalltext">', $context['signature_warning'], '</span>';
2848
+	}
2739 2849
 
2740 2850
 	// Some javascript used to count how many characters have been used so far in the signature.
2741 2851
 	echo '
@@ -2779,9 +2889,10 @@  discard block
 block discarded – undo
2779 2889
 									<div>
2780 2890
 										<select name="cat" id="cat" size="10" onchange="changeSel(\'\');" onfocus="selectRadioByName(document.forms.creator.avatar_choice, \'server_stored\');">';
2781 2891
 		// This lists all the file categories.
2782
-		foreach ($context['avatars'] as $avatar)
2783
-			echo '
2892
+		foreach ($context['avatars'] as $avatar) {
2893
+					echo '
2784 2894
 											<option value="', $avatar['filename'] . ($avatar['is_dir'] ? '/' : ''), '"', ($avatar['checked'] ? ' selected' : ''), '>', $avatar['name'], '</option>';
2895
+		}
2785 2896
 		echo '
2786 2897
 										</select>
2787 2898
 									</div>
@@ -2836,16 +2947,17 @@  discard block
 block discarded – undo
2836 2947
 								<div id="avatar_gravatar">
2837 2948
 									<img src="' . $context['member']['avatar']['href'] . '" alt="" />';
2838 2949
 
2839
-		if (empty($modSettings['gravatarAllowExtraEmail']))
2840
-			echo '
2950
+		if (empty($modSettings['gravatarAllowExtraEmail'])) {
2951
+					echo '
2841 2952
 									<div class="smalltext">', $txt['gravatar_noAlternateEmail'], '</div>';
2842
-		else
2953
+		} else
2843 2954
 		{
2844 2955
 			// Depending on other stuff, the stored value here might have some odd things in it from other areas.
2845
-			if ($context['member']['avatar']['external'] == $context['member']['email'])
2846
-				$textbox_value = '';
2847
-			else
2848
-				$textbox_value = $context['member']['avatar']['external'];
2956
+			if ($context['member']['avatar']['external'] == $context['member']['email']) {
2957
+							$textbox_value = '';
2958
+			} else {
2959
+							$textbox_value = $context['member']['avatar']['external'];
2960
+			}
2849 2961
 
2850 2962
 			echo '
2851 2963
 									<div class="smalltext">', $txt['gravatar_alternateEmail'], '</div>
@@ -2917,8 +3029,9 @@  discard block
 block discarded – undo
2917 3029
 	$h = !empty($modSettings['avatar_max_height_' . $type]) ? comma_format($modSettings['avatar_max_height_' . $type]) : 0;
2918 3030
 
2919 3031
 	$suffix = (!empty($w) ? 'w' : '') . (!empty($h) ? 'h' : '');
2920
-	if (empty($suffix))
2921
-		return;
3032
+	if (empty($suffix)) {
3033
+			return;
3034
+	}
2922 3035
 
2923 3036
 	echo '
2924 3037
 									<div class="smalltext">', sprintf($txt['avatar_max_size_' . $suffix], $w, $h), '</div>';
@@ -2940,9 +3053,10 @@  discard block
 block discarded – undo
2940 3053
 							<dd>
2941 3054
 								<select name="easyformat" id="easyformat" onchange="document.forms.creator.time_format.value = this.options[this.selectedIndex].value;" style="margin-bottom: 4px;">';
2942 3055
 	// Help the user by showing a list of common time formats.
2943
-	foreach ($context['easy_timeformats'] as $time_format)
2944
-		echo '
3056
+	foreach ($context['easy_timeformats'] as $time_format) {
3057
+			echo '
2945 3058
 									<option value="', $time_format['format'], '"', $time_format['format'] == $context['member']['time_format'] ? ' selected' : '', '>', $time_format['title'], '</option>';
3059
+	}
2946 3060
 	echo '
2947 3061
 								</select><br>
2948 3062
 								<input type="text" name="time_format" id="time_format" value="', $context['member']['time_format'], '" size="30" class="input_text">
@@ -2978,9 +3092,10 @@  discard block
 block discarded – undo
2978 3092
 							</dt>
2979 3093
 							<dd>
2980 3094
 								<select name="smiley_set" id="smiley_set" onchange="document.getElementById(\'smileypr\').src = this.selectedIndex == 0 ? \'', $settings['images_url'], '/blank.png\' : \'', $modSettings['smileys_url'], '/\' + (this.selectedIndex != 1 ? this.options[this.selectedIndex].value : \'', !empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'], '\') + \'/smiley.gif\';">';
2981
-	foreach ($context['smiley_sets'] as $set)
2982
-		echo '
3095
+	foreach ($context['smiley_sets'] as $set) {
3096
+			echo '
2983 3097
 									<option value="', $set['id'], '"', $set['selected'] ? ' selected' : '', '>', $set['name'], '</option>';
3098
+	}
2984 3099
 	echo '
2985 3100
 								</select> <img id="smileypr" class="centericon" src="', $context['member']['smiley_set']['id'] != 'none' ? $modSettings['smileys_url'] . '/' . ($context['member']['smiley_set']['id'] != '' ? $context['member']['smiley_set']['id'] : (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default'])) . '/smiley.gif' : $settings['images_url'] . '/blank.png', '" alt=":)"  style="padding-left: 20px;">
2986 3101
 							</dd>';
@@ -3031,10 +3146,11 @@  discard block
 block discarded – undo
3031 3146
 									</div>
3032 3147
 									<div class="clear"></div>';
3033 3148
 
3034
-	if (!empty($context['from_ajax']))
3035
-		echo '
3149
+	if (!empty($context['from_ajax'])) {
3150
+			echo '
3036 3151
 									<br>
3037 3152
 									<a href="javascript:self.close();"></a>';
3153
+	}
3038 3154
 
3039 3155
 	echo '
3040 3156
 								</div>
@@ -3073,15 +3189,16 @@  discard block
 block discarded – undo
3073 3189
 								<br><div class="smalltext">', $txt['tfa_profile_desc'], '</div>
3074 3190
 							</dt>
3075 3191
 							<dd>';
3076
-	if (!$context['tfa_enabled'] && $context['user']['is_owner'])
3077
-		echo '
3192
+	if (!$context['tfa_enabled'] && $context['user']['is_owner']) {
3193
+			echo '
3078 3194
 								<a href="', !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl, '?action=profile;area=tfasetup" id="enable_tfa">', $txt['tfa_profile_enable'], '</a>';
3079
-	elseif (!$context['tfa_enabled'])
3080
-		echo '
3195
+	} elseif (!$context['tfa_enabled']) {
3196
+			echo '
3081 3197
 								', $txt['tfa_profile_disabled'];
3082
-	else
3083
-		echo '
3198
+	} else {
3199
+			echo '
3084 3200
 							', sprintf($txt['tfa_profile_enabled'], $scripturl . '?action=profile;u=' . $context['id_member'] . ';area=tfasetup;disable');
3201
+	}
3085 3202
 	echo '
3086 3203
 							</dd>';
3087 3204
 }
Please login to merge, or discard this patch.
Themes/default/index.template.php 1 patch
Braces   +89 added lines, -61 removed lines patch added patch discarded remove patch
@@ -72,9 +72,10 @@  discard block
 block discarded – undo
72 72
 
73 73
 	// Allow css/js files to be disable for this specific theme.
74 74
 	// Add the identifier as an array key. IE array('smf_script'); Some external files might not add identifiers, on those cases SMF uses its filename as reference.
75
-	if (!isset($settings['disable_files']))
76
-		$settings['disable_files'] = array();
77
-}
75
+	if (!isset($settings['disable_files'])) {
76
+			$settings['disable_files'] = array();
77
+	}
78
+	}
78 79
 
79 80
 /**
80 81
  * The main sub template above the content.
@@ -111,8 +112,9 @@  discard block
 block discarded – undo
111 112
 		echo '
112 113
 	<meta';
113 114
 
114
-		foreach ($meta_tag as $meta_key => $meta_value)
115
-			echo ' ', $meta_key, '="', $meta_value, '"';
115
+		foreach ($meta_tag as $meta_key => $meta_value) {
116
+					echo ' ', $meta_key, '="', $meta_value, '"';
117
+		}
116 118
 
117 119
 		echo '>';
118 120
 	}
@@ -123,14 +125,16 @@  discard block
 block discarded – undo
123 125
 	<meta name="theme-color" content="#557EA0">';
124 126
 
125 127
 	// Please don't index these Mr Robot.
126
-	if (!empty($context['robot_no_index']))
127
-		echo '
128
+	if (!empty($context['robot_no_index'])) {
129
+			echo '
128 130
 	<meta name="robots" content="noindex">';
131
+	}
129 132
 
130 133
 	// Present a canonical url for search engines to prevent duplicate content in their indices.
131
-	if (!empty($context['canonical_url']))
132
-		echo '
134
+	if (!empty($context['canonical_url'])) {
135
+			echo '
133 136
 	<link rel="canonical" href="', $context['canonical_url'], '">';
137
+	}
134 138
 
135 139
 	// Show all the relative links, such as help, search, contents, and the like.
136 140
 	echo '
@@ -139,10 +143,11 @@  discard block
 block discarded – undo
139 143
 	<link rel="search" href="' . $scripturl . '?action=search">' : '');
140 144
 
141 145
 	// If RSS feeds are enabled, advertise the presence of one.
142
-	if (!empty($modSettings['xmlnews_enable']) && (!empty($modSettings['allow_guestAccess']) || $context['user']['is_logged']))
143
-		echo '
146
+	if (!empty($modSettings['xmlnews_enable']) && (!empty($modSettings['allow_guestAccess']) || $context['user']['is_logged'])) {
147
+			echo '
144 148
 	<link rel="alternate feed" type="application/rss+xml" title="', $context['forum_name_html_safe'], ' - ', $txt['rss'], '" href="', $scripturl, '?action=.xml;type=rss2', !empty($context['current_board']) ? ';board=' . $context['current_board'] : '', '">
145 149
 	<link rel="alternate feed" type="application/atom+xml" title="', $context['forum_name_html_safe'], ' - ', $txt['atom'], '" href="', $scripturl, '?action=.xml;type=atom', !empty($context['current_board']) ? ';board=' . $context['current_board'] : '', '">';
150
+	}
146 151
 
147 152
 	// If we're viewing a topic, these should be the previous and next topics, respectively.
148 153
 	if (!empty($context['links']['next']))
@@ -158,9 +163,10 @@  discard block
 block discarded – undo
158 163
 	}
159 164
 
160 165
 	// If we're in a board, or a topic for that matter, the index will be the board's index.
161
-	if (!empty($context['current_board']))
162
-		echo '
166
+	if (!empty($context['current_board'])) {
167
+			echo '
163 168
 	<link rel="index" href="', $scripturl, '?board=', $context['current_board'], '.0">';
169
+	}
164 170
 
165 171
 	// Output any remaining HTML headers. (from mods, maybe?)
166 172
 	echo $context['html_headers'];
@@ -191,8 +197,9 @@  discard block
 block discarded – undo
191 197
 		<ul class="floatleft" id="top_info">
192 198
 			<li>
193 199
 				<a href="', $scripturl, '?action=profile"', !empty($context['self_profile']) ? ' class="active"' : '', ' id="profile_menu_top" onclick="return false;">';
194
-					if (!empty($context['user']['avatar']))
195
-						echo $context['user']['avatar']['image'];
200
+					if (!empty($context['user']['avatar'])) {
201
+											echo $context['user']['avatar']['image'];
202
+					}
196 203
 					echo $context['user']['name'], '</a>
197 204
 				<div id="profile_menu" class="top_menu"></div>
198 205
 			</li>';
@@ -220,17 +227,18 @@  discard block
 block discarded – undo
220 227
 	}
221 228
 	// Otherwise they're a guest. Ask them to either register or login.
222 229
 	else
223
-		if (empty($maintenance))
224
-			echo '
230
+		if (empty($maintenance)) {
231
+					echo '
225 232
 			<ul class="floatleft welcome">
226 233
 				<li>', sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'), '</li>
227 234
 			</ul>';
228
-		else
229
-			//In maintenance mode, only login is allowed and don't show OverlayDiv
235
+		} else {
236
+					//In maintenance mode, only login is allowed and don't show OverlayDiv
230 237
 			echo '
231 238
 			<ul class="floatleft welcome">
232 239
 				<li>', sprintf($txt['welcome_guest'], $txt['guest_title'], '', $scripturl. '?action=login', 'return true;'), '</li>
233 240
 			</ul>';
241
+		}
234 242
 
235 243
 	if (!empty($modSettings['userLanguage']) && !empty($context['languages']) && count($context['languages']) > 1)
236 244
 	{
@@ -238,9 +246,10 @@  discard block
 block discarded – undo
238 246
 		<form id="languages_form" method="get" class="floatright">
239 247
 			<select id="language_select" name="language" onchange="this.form.submit()">';
240 248
 
241
-		foreach ($context['languages'] as $language)
242
-			echo '
249
+		foreach ($context['languages'] as $language) {
250
+					echo '
243 251
 				<option value="', $language['filename'], '"', isset($context['user']['language']) && $context['user']['language'] == $language['filename'] ? ' selected="selected"' : '', '>', str_replace('-utf8', '', $language['name']), '</option>';
252
+		}
244 253
 
245 254
 		echo '
246 255
 			</select>
@@ -264,31 +273,36 @@  discard block
 block discarded – undo
264 273
 				<option value="all"', ($selected == 'all' ? ' selected' : ''), '>', $txt['search_entireforum'], ' </option>';
265 274
 
266 275
 		// Can't limit it to a specific topic if we are not in one
267
-		if (!empty($context['current_topic']))
268
-			echo '
276
+		if (!empty($context['current_topic'])) {
277
+					echo '
269 278
 				<option value="topic"', ($selected == 'current_topic' ? ' selected' : ''), '>', $txt['search_thistopic'], '</option>';
279
+		}
270 280
 
271 281
 		// Can't limit it to a specific board if we are not in one
272
-		if (!empty($context['current_board']))
273
-			echo '
282
+		if (!empty($context['current_board'])) {
283
+					echo '
274 284
 				<option value="board"', ($selected == 'current_board' ? ' selected' : ''), '>', $txt['search_thisbrd'], '</option>';
285
+		}
275 286
 
276 287
 		// Can't search for members if we can't see the memberlist
277
-		if (!empty($context['allow_memberlist']))
278
-			echo '
288
+		if (!empty($context['allow_memberlist'])) {
289
+					echo '
279 290
 				<option value="members"', ($selected == 'members' ? ' selected' : ''), '>', $txt['search_members'], ' </option>';
291
+		}
280 292
 
281 293
 		echo '
282 294
 			</select>';
283 295
 
284 296
 		// Search within current topic?
285
-		if (!empty($context['current_topic']))
286
-			echo '
297
+		if (!empty($context['current_topic'])) {
298
+					echo '
287 299
 			<input type="hidden" name="sd_topic" value="', $context['current_topic'], '">';
300
+		}
288 301
 		// If we're on a certain board, limit it to this board ;).
289
-		elseif (!empty($context['current_board']))
290
-			echo '
302
+		elseif (!empty($context['current_board'])) {
303
+					echo '
291 304
 			<input type="hidden" name="sd_brd" value="', $context['current_board'], '">';
305
+		}
292 306
 
293 307
 		echo '
294 308
 			<input type="submit" name="search2" value="', $txt['search'], '" class="button_submit">
@@ -318,12 +332,13 @@  discard block
 block discarded – undo
318 332
 						', $context['current_time'], '
319 333
 					</div>';
320 334
 	// Show a random news item? (or you could pick one from news_lines...)
321
-	if (!empty($settings['enable_news']) && !empty($context['random_news_line']))
322
-		echo '
335
+	if (!empty($settings['enable_news']) && !empty($context['random_news_line'])) {
336
+			echo '
323 337
 					<div class="news">
324 338
 						<h2>', $txt['news'], ': </h2>
325 339
 						<p>', $context['random_news_line'], '</p>
326 340
 					</div>';
341
+	}
327 342
 
328 343
 	echo '
329 344
 					<hr class="clear">
@@ -386,9 +401,10 @@  discard block
 block discarded – undo
386 401
 		</ul>';
387 402
 
388 403
 	// Show the load time?
389
-	if ($context['show_load_time'])
390
-		echo '
404
+	if ($context['show_load_time']) {
405
+			echo '
391 406
 		<p>', sprintf($txt['page_created_full'], $context['load_time'], $context['load_queries']), '</p>';
407
+	}
392 408
 
393 409
 	echo '
394 410
 	</div>';
@@ -418,19 +434,21 @@  discard block
 block discarded – undo
418 434
 	global $context, $shown_linktree, $scripturl, $txt;
419 435
 
420 436
 	// If linktree is empty, just return - also allow an override.
421
-	if (empty($context['linktree']) || (!empty($context['dont_default_linktree']) && !$force_show))
422
-		return;
437
+	if (empty($context['linktree']) || (!empty($context['dont_default_linktree']) && !$force_show)) {
438
+			return;
439
+	}
423 440
 
424 441
 	echo '
425 442
 				<div class="navigate_section">
426 443
 					<ul>';
427 444
 
428
-	if ($context['user']['is_logged'])
429
-	echo '
445
+	if ($context['user']['is_logged']) {
446
+		echo '
430 447
 						<li class="unread_links">
431 448
 							<a href="', $scripturl, '?action=unread" title="', $txt['unread_since_visit'], '">', $txt['view_unread_category'], '</a>
432 449
 							<a href="', $scripturl, '?action=unreadreplies" title="', $txt['show_unread_replies'], '">', $txt['unread_replies'], '</a>
433 450
 						</li>';
451
+	}
434 452
 
435 453
 	// Each tree item has a URL and name. Some may have extra_before and extra_after.
436 454
 	foreach ($context['linktree'] as $link_num => $tree)
@@ -441,25 +459,29 @@  discard block
 block discarded – undo
441 459
 		// Don't show a separator for the first one.
442 460
 		// Better here. Always points to the next level when the linktree breaks to a second line.
443 461
 		// Picked a better looking HTML entity, and added support for RTL plus a span for styling.
444
-		if ($link_num != 0)
445
-			echo '
462
+		if ($link_num != 0) {
463
+					echo '
446 464
 							<span class="dividers">', $context['right_to_left'] ? ' &#9668; ' : ' &#9658; ', '</span>';
465
+		}
447 466
 
448 467
 		// Show something before the link?
449
-		if (isset($tree['extra_before']))
450
-			echo $tree['extra_before'], ' ';
468
+		if (isset($tree['extra_before'])) {
469
+					echo $tree['extra_before'], ' ';
470
+		}
451 471
 
452 472
 		// Show the link, including a URL if it should have one.
453
-		if (isset($tree['url']))
454
-			echo '
473
+		if (isset($tree['url'])) {
474
+					echo '
455 475
 					<a href="' . $tree['url'] . '"><span>' . $tree['name'] . '</span></a>';
456
-		else
457
-			echo '
476
+		} else {
477
+					echo '
458 478
 					<span>' . $tree['name'] . '</span>';
479
+		}
459 480
 
460 481
 		// Show something after the link...?
461
-		if (isset($tree['extra_after']))
462
-			echo ' ', $tree['extra_after'];
482
+		if (isset($tree['extra_after'])) {
483
+					echo ' ', $tree['extra_after'];
484
+		}
463 485
 
464 486
 		echo '
465 487
 						</li>';
@@ -509,13 +531,14 @@  discard block
 block discarded – undo
509 531
 					echo '
510 532
 									<ul>';
511 533
 
512
-					foreach ($childbutton['sub_buttons'] as $grandchildbutton)
513
-						echo '
534
+					foreach ($childbutton['sub_buttons'] as $grandchildbutton) {
535
+											echo '
514 536
 										<li>
515 537
 											<a href="', $grandchildbutton['href'], '"', isset($grandchildbutton['target']) ? ' target="' . $grandchildbutton['target'] . '"' : '', '>
516 538
 												', $grandchildbutton['title'], '
517 539
 											</a>
518 540
 										</li>';
541
+					}
519 542
 
520 543
 					echo '
521 544
 									</ul>';
@@ -546,8 +569,9 @@  discard block
 block discarded – undo
546 569
 {
547 570
 	global $context, $txt;
548 571
 
549
-	if (!is_array($strip_options))
550
-		$strip_options = array();
572
+	if (!is_array($strip_options)) {
573
+			$strip_options = array();
574
+	}
551 575
 
552 576
 	// Create the buttons...
553 577
 	$buttons = array();
@@ -556,8 +580,9 @@  discard block
 block discarded – undo
556 580
 		// As of 2.1, the 'test' for each button happens while the array is being generated. The extra 'test' check here is deprecated but kept for backward compatibility (update your mods, folks!)
557 581
 		if (!isset($value['test']) || !empty($context[$value['test']]))
558 582
 		{
559
-			if (!isset($value['id']))
560
-				$value['id'] = $key;
583
+			if (!isset($value['id'])) {
584
+							$value['id'] = $key;
585
+			}
561 586
 
562 587
 			$button = '
563 588
 				<a class="button button_strip_' . $key . (!empty($value['active']) ? ' active' : '') . (isset($value['class']) ? ' ' . $value['class'] : '') . '" ' . (!empty($value['url']) ? 'href="' . $value['url'] . '"' : '') . ' ' . (isset($value['custom']) ? ' ' . $value['custom'] : '') . '>' . $txt[$value['text']] . '</a>';
@@ -570,13 +595,15 @@  discard block
 block discarded – undo
570 595
 							<div class="overview">';
571 596
 				foreach ($value['sub_buttons'] as $element)
572 597
 				{
573
-					if (isset($element['test']) && empty($context[$element['test']]))
574
-						continue;
598
+					if (isset($element['test']) && empty($context[$element['test']])) {
599
+											continue;
600
+					}
575 601
 
576 602
 					$button .= '
577 603
 								<a href="' . $element['url'] . '"><strong>' . $txt[$element['text']] . '</strong>';
578
-					if (isset($txt[$element['text'] . '_desc']))
579
-						$button .= '<br><span>' . $txt[$element['text'] . '_desc'] . '</span>';
604
+					if (isset($txt[$element['text'] . '_desc'])) {
605
+											$button .= '<br><span>' . $txt[$element['text'] . '_desc'] . '</span>';
606
+					}
580 607
 					$button .= '</a>';
581 608
 				}
582 609
 				$button .= '
@@ -590,8 +617,9 @@  discard block
 block discarded – undo
590 617
 	}
591 618
 
592 619
 	// No buttons? No button strip either.
593
-	if (empty($buttons))
594
-		return;
620
+	if (empty($buttons)) {
621
+			return;
622
+	}
595 623
 
596 624
 	echo '
597 625
 		<div class="buttonlist', !empty($direction) ? ' float' . $direction : '', '"', (empty($buttons) ? ' style="display: none;"' : ''), (!empty($strip_options['id']) ? ' id="' . $strip_options['id'] . '"' : ''), '>
Please login to merge, or discard this patch.
Themes/default/Packages.template.php 1 patch
Braces   +144 added lines, -104 removed lines patch added patch discarded remove patch
@@ -31,12 +31,13 @@  discard block
 block discarded – undo
31 31
 		</div>
32 32
 		<div class="information">';
33 33
 
34
-	if ($context['is_installed'])
35
-		echo '
34
+	if ($context['is_installed']) {
35
+			echo '
36 36
 			<strong>', $txt['package_installed_warning1'], '</strong><br>
37 37
 			<br>
38 38
 			', $txt['package_installed_warning2'], '<br>
39 39
 			<br>';
40
+	}
40 41
 
41 42
 	echo $txt['package_installed_warning3'], '
42 43
 		</div><br>';
@@ -63,8 +64,9 @@  discard block
 block discarded – undo
63 64
 				', $context['package_readme'], '
64 65
 				<span class="floatright">', $txt['package_available_readme_language'], '
65 66
 					<select name="readme_language" id="readme_language" onchange="if (this.options[this.selectedIndex].value) window.location.href = smf_prepareScriptUrl(smf_scripturl + \'', '?action=admin;area=packages;sa=', $context['uninstalling'] ? 'uninstall' : 'install', ';package=', $context['filename'], ';readme=\' + this.options[this.selectedIndex].value + \';license=\' + get_selected(\'license_language\'));">';
66
-						foreach ($context['readmes'] as $a => $b)
67
-							echo '<option value="', $b, '"', $a === 'selected' ? ' selected' : '', '>', $b == 'default' ? $txt['package_readme_default'] : ucfirst($b), '</option>';
67
+						foreach ($context['readmes'] as $a => $b) {
68
+													echo '<option value="', $b, '"', $a === 'selected' ? ' selected' : '', '>', $b == 'default' ? $txt['package_readme_default'] : ucfirst($b), '</option>';
69
+						}
68 70
 			echo '
69 71
 					</select>
70 72
 				</span>
@@ -83,8 +85,9 @@  discard block
 block discarded – undo
83 85
 				', $context['package_license'], '
84 86
 				<span class="floatright">', $txt['package_available_license_language'], '
85 87
 					<select name="license_language" id="license_language" onchange="if (this.options[this.selectedIndex].value) window.location.href = smf_prepareScriptUrl(smf_scripturl + \'', '?action=admin;area=packages;sa=install', ';package=', $context['filename'], ';license=\' + this.options[this.selectedIndex].value + \';readme=\' + get_selected(\'readme_language\'));">';
86
-						foreach ($context['licenses'] as $a => $b)
87
-							echo '<option value="', $b, '"', $a === 'selected' ? ' selected' : '', '>', $b == 'default' ? $txt['package_license_default'] : ucfirst($b), '</option>';
88
+						foreach ($context['licenses'] as $a => $b) {
89
+													echo '<option value="', $b, '"', $a === 'selected' ? ' selected' : '', '>', $b == 'default' ? $txt['package_license_default'] : ucfirst($b), '</option>';
90
+						}
88 91
 			echo '
89 92
 					</select>
90 93
 				</span>
@@ -111,9 +114,10 @@  discard block
 block discarded – undo
111 114
 					', $txt['package_db_uninstall_actions'], ':
112 115
 					<ul>';
113 116
 
114
-		foreach ($context['database_changes'] as $change)
115
-			echo '
117
+		foreach ($context['database_changes'] as $change) {
118
+					echo '
116 119
 						<li>', $change, '</li>';
120
+		}
117 121
 		echo '
118 122
 					</ul>
119 123
 				</div>
@@ -123,14 +127,14 @@  discard block
 block discarded – undo
123 127
 	echo '
124 128
 			<div class="information">';
125 129
 
126
-	if (empty($context['actions']) && empty($context['database_changes']))
127
-		echo '
130
+	if (empty($context['actions']) && empty($context['database_changes'])) {
131
+			echo '
128 132
 				<br>
129 133
 				<div class="errorbox">
130 134
 					', $txt['corrupt_compatible'], '
131 135
 				</div>
132 136
 			</div>';
133
-	else
137
+	} else
134 138
 	{
135 139
 		echo '
136 140
 					', $txt['perform_actions'], '
@@ -230,9 +234,10 @@  discard block
 block discarded – undo
230 234
 					<tr class="title_bar">
231 235
 						<td></td>
232 236
 						<td>';
233
-				if (!empty($context['themes_locked']))
234
-					echo '
237
+				if (!empty($context['themes_locked'])) {
238
+									echo '
235 239
 							<input type="hidden" name="custom_theme[]" value="', $id, '">';
240
+				}
236 241
 				echo '
237 242
 							<input type="checkbox" name="custom_theme[]" id="custom_theme_', $id, '" value="', $id, '" class="input_check" onclick="', (!empty($theme['has_failure']) ? 'if (this.form.custom_theme_' . $id . '.checked && !confirm(\'' . $txt['package_theme_failure_warning'] . '\')) return false;' : ''), 'invertAll(this, this.form, \'dummy_theme_', $id, '\', true);"', !empty($context['themes_locked']) ? ' disabled checked' : '', '>
238 243
 						</td>
@@ -373,14 +378,15 @@  discard block
 block discarded – undo
373 378
 	</script>';
374 379
 
375 380
 	// And a bit more for database changes.
376
-	if (!empty($context['database_changes']))
377
-		echo '
381
+	if (!empty($context['database_changes'])) {
382
+			echo '
378 383
 	<script>
379 384
 		var database_changes_area = document.getElementById(\'db_changes_div\');
380 385
 		var db_vis = false;
381 386
 		database_changes_area.style.display = "none";
382 387
 	</script>';
383
-}
388
+	}
389
+	}
384 390
 
385 391
 /**
386 392
  * Extract package contents
@@ -412,12 +418,12 @@  discard block
 block discarded – undo
412 418
 				<h3 class="catbg">', $context['uninstalling'] ? $txt['uninstall'] : $txt['extracting'], '</h3>
413 419
 			</div>
414 420
 			<div class="information">', $txt['package_installed_extract'], '</div>';
415
-	}
416
-	else
417
-		echo '
421
+	} else {
422
+			echo '
418 423
 			<div class="cat_bar">
419 424
 				<h3 class="catbg">', $txt['package_installed_redirecting'], '</h3>
420 425
 			</div>';
426
+	}
421 427
 
422 428
 	echo '
423 429
 		<div class="windowbg">';
@@ -428,25 +434,25 @@  discard block
 block discarded – undo
428 434
 		echo '
429 435
 			', $context['redirect_text'], '<br><br>
430 436
 			<a href="', $context['redirect_url'], '">', $txt['package_installed_redirect_go_now'], '</a> | <a href="', $scripturl, '?action=admin;area=packages;sa=browse">', $txt['package_installed_redirect_cancel'], '</a>';
431
-	}
432
-	elseif ($context['uninstalling'])
433
-		echo '
437
+	} elseif ($context['uninstalling']) {
438
+			echo '
434 439
 			', $txt['package_uninstall_done'];
435
-	elseif ($context['install_finished'])
440
+	} elseif ($context['install_finished'])
436 441
 	{
437
-		if ($context['extract_type'] == 'avatar')
438
-			echo '
442
+		if ($context['extract_type'] == 'avatar') {
443
+					echo '
439 444
 				', $txt['avatars_extracted'];
440
-		elseif ($context['extract_type'] == 'language')
441
-			echo '
445
+		} elseif ($context['extract_type'] == 'language') {
446
+					echo '
442 447
 				', $txt['language_extracted'];
443
-		else
444
-			echo '
448
+		} else {
449
+					echo '
445 450
 				', $txt['package_installed_done'];
446
-	}
447
-	else
448
-		echo '
451
+		}
452
+	} else {
453
+			echo '
449 454
 			', $txt['corrupt_compatible'];
455
+	}
450 456
 
451 457
 	echo '
452 458
 		</div>';
@@ -480,9 +486,10 @@  discard block
 block discarded – undo
480 486
 		<div class="windowbg">
481 487
 			<ol>';
482 488
 
483
-	foreach ($context['files'] as $fileinfo)
484
-		echo '
489
+	foreach ($context['files'] as $fileinfo) {
490
+			echo '
485 491
 				<li><a href="', $scripturl, '?action=admin;area=packages;sa=examine;package=', $context['filename'], ';file=', $fileinfo['filename'], '" title="', $txt['view'], '">', $fileinfo['filename'], '</a> (', $fileinfo['size'], ' ', $txt['package_bytes'], ')</li>';
492
+	}
486 493
 
487 494
 	echo '
488 495
 			</ol>
@@ -546,9 +553,10 @@  discard block
 block discarded – undo
546 553
 			</script>
547 554
 			<div id="yourVersion" style="display:none">', $context['forum_version'], '</div>';
548 555
 
549
-	if (empty($modSettings['disable_smf_js']))
550
-		echo '
556
+	if (empty($modSettings['disable_smf_js'])) {
557
+			echo '
551 558
 			<script src="', $scripturl, '?action=viewsmfile;filename=latest-news.js"></script>';
559
+	}
552 560
 
553 561
 	// This sets the announcements and current versions themselves ;).
554 562
 	echo '
@@ -587,12 +595,13 @@  discard block
 block discarded – undo
587 595
 		}
588 596
 	}
589 597
 
590
-	if (!$mods_available)
591
-		echo '
598
+	if (!$mods_available) {
599
+			echo '
592 600
 		<div class="noticebox">', $txt['no_packages'], '</div>';
593
-	else
594
-		echo '
601
+	} else {
602
+			echo '
595 603
 		<br>';
604
+	}
596 605
 
597 606
 	// the advanced (emulation) box, collapsed by default
598 607
 	echo '
@@ -681,11 +690,12 @@  discard block
 block discarded – undo
681 690
 {
682 691
 	global $context, $txt, $scripturl;
683 692
 
684
-	if (!empty($context['package_ftp']['error']))
685
-			echo '
693
+	if (!empty($context['package_ftp']['error'])) {
694
+				echo '
686 695
 					<div class="errorbox">
687 696
 						<pre>', $context['package_ftp']['error'], '</pre>
688 697
 					</div>';
698
+	}
689 699
 
690 700
 	echo '
691 701
 	<div id="admin_form_wrapper">
@@ -766,13 +776,14 @@  discard block
 block discarded – undo
766 776
 				<fieldset>
767 777
 					<legend>' . $txt['package_servers'] . '</legend>
768 778
 					<ul class="package_servers">';
769
-	foreach ($context['servers'] as $server)
770
-		echo '
779
+	foreach ($context['servers'] as $server) {
780
+			echo '
771 781
 						<li class="flow_auto">
772 782
 							<span class="floatleft">' . $server['name'] . '</span>
773 783
 							<span class="package_server floatright"><a href="' . $scripturl . '?action=admin;area=packages;get;sa=remove;server=' . $server['id'] . ';', $context['session_var'], '=', $context['session_id'], '">[ ' . $txt['delete'] . ' ]</a></span>
774 784
 							<span class="package_server floatright"><a href="' . $scripturl . '?action=admin;area=packages;get;sa=browse;server=' . $server['id'] . '">[ ' . $txt['package_browse'] . ' ]</a></span>
775 785
 						</li>';
786
+	}
776 787
 	echo '
777 788
 					</ul>
778 789
 				</fieldset>
@@ -859,11 +870,12 @@  discard block
 block discarded – undo
859 870
 		<div class="windowbg2">';
860 871
 
861 872
 	// No packages, as yet.
862
-	if (empty($context['package_list']))
863
-		echo '
873
+	if (empty($context['package_list'])) {
874
+			echo '
864 875
 			<ul>
865 876
 				<li>', $txt['no_packages'], '</li>
866 877
 			</ul>';
878
+	}
867 879
 	// List out the packages...
868 880
 	else
869 881
 	{
@@ -875,11 +887,12 @@  discard block
 block discarded – undo
875 887
 				<li>
876 888
 					<strong><span id="ps_img_', $i, '" class="toggle_up" alt="*" style="display: none;"></span> ', $packageSection['title'], '</strong>';
877 889
 
878
-			if (!empty($packageSection['text']))
879
-				echo '
890
+			if (!empty($packageSection['text'])) {
891
+							echo '
880 892
 					<div class="sub_bar">
881 893
 						<h3 class="subbg">', $packageSection['text'], '</h3>
882 894
 					</div>';
895
+			}
883 896
 
884 897
 			echo '
885 898
 					<', $context['list_type'], ' id="package_section_', $i, '" class="packages">';
@@ -889,13 +902,15 @@  discard block
 block discarded – undo
889 902
 				echo '
890 903
 						<li>';
891 904
 				// Textual message. Could be empty just for a blank line...
892
-				if ($package['is_text'])
893
-					echo '
905
+				if ($package['is_text']) {
906
+									echo '
894 907
 							', empty($package['name']) ? '&nbsp;' : $package['name'];
908
+				}
895 909
 				// This is supposed to be a rule..
896
-				elseif ($package['is_line'])
897
-					echo '
910
+				elseif ($package['is_line']) {
911
+									echo '
898 912
 						<hr>';
913
+				}
899 914
 				// A remote link.
900 915
 				elseif ($package['is_remote'])
901 916
 				{
@@ -917,21 +932,25 @@  discard block
 block discarded – undo
917 932
 						<ul id="package_section_', $i, '_pkg_', $id, '" class="package_section">';
918 933
 
919 934
 					// Show the mod type?
920
-					if ($package['type'] != '')
921
-						echo '
935
+					if ($package['type'] != '') {
936
+											echo '
922 937
 							<li class="package_section">', $txt['package_type'], ':&nbsp; ', $smcFunc['ucwords']($smcFunc['strtolower']($package['type'])), '</li>';
938
+					}
923 939
 					// Show the version number?
924
-					if ($package['version'] != '')
925
-						echo '
940
+					if ($package['version'] != '') {
941
+											echo '
926 942
 							<li class="package_section">', $txt['mod_version'], ':&nbsp; ', $package['version'], '</li>';
943
+					}
927 944
 					// How 'bout the author?
928
-					if (!empty($package['author']) && $package['author']['name'] != '' && isset($package['author']['link']))
929
-						echo '
945
+					if (!empty($package['author']) && $package['author']['name'] != '' && isset($package['author']['link'])) {
946
+											echo '
930 947
 							<li class="package_section">', $txt['mod_author'], ':&nbsp; ', $package['author']['link'], '</li>';
948
+					}
931 949
 					// The homepage....
932
-					if ($package['author']['website']['link'] != '')
933
-						echo '
950
+					if ($package['author']['website']['link'] != '') {
951
+											echo '
934 952
 							<li class="package_section">', $txt['author_website'], ':&nbsp; ', $package['author']['website']['link'], '</li>';
953
+					}
935 954
 
936 955
 					// Desciption: bleh bleh!
937 956
 					// Location of file: http://someplace/.
@@ -984,8 +1003,8 @@  discard block
 block discarded – undo
984 1003
 
985 1004
 				foreach ($ps['items'] as $id => $package)
986 1005
 				{
987
-					if (!$package['is_text'] && !$package['is_line'] && !$package['is_remote'])
988
-						echo '
1006
+					if (!$package['is_text'] && !$package['is_line'] && !$package['is_remote']) {
1007
+											echo '
989 1008
 				var oPackageToggle_', $section, '_pkg_', $id, ' = new smc_Toggle({
990 1009
 					bToggleEnabled: true,
991 1010
 					bCurrentlyCollapsed: true,
@@ -1000,6 +1019,7 @@  discard block
 block discarded – undo
1000 1019
 						}
1001 1020
 					]
1002 1021
 				});';
1022
+					}
1003 1023
 				}
1004 1024
 			}
1005 1025
 			echo '
@@ -1040,9 +1060,10 @@  discard block
 block discarded – undo
1040 1060
 {
1041 1061
 	global $context, $txt, $scripturl;
1042 1062
 
1043
-	if (!empty($context['saved_successful']))
1044
-		echo '
1063
+	if (!empty($context['saved_successful'])) {
1064
+			echo '
1045 1065
 	<div class="infobox">', $txt['settings_saved'], '</div>';
1066
+	}
1046 1067
 
1047 1068
 	echo '
1048 1069
 	<div id="admincenter">
@@ -1104,8 +1125,9 @@  discard block
 block discarded – undo
1104 1125
 	global $context, $txt;
1105 1126
 
1106 1127
 	// Nothing to do? Brilliant!
1107
-	if (empty($context['package_ftp']))
1108
-		return false;
1128
+	if (empty($context['package_ftp'])) {
1129
+			return false;
1130
+	}
1109 1131
 
1110 1132
 	if (empty($context['package_ftp']['form_elements_only']))
1111 1133
 	{
@@ -1114,19 +1136,21 @@  discard block
 block discarded – undo
1114 1136
 				<div id="need_writable_list" class="smalltext">
1115 1137
 					', $txt['package_ftp_why_file_list'], '
1116 1138
 					<ul style="display: inline;">';
1117
-		if (!empty($context['notwritable_files']))
1118
-			foreach ($context['notwritable_files'] as $file)
1139
+		if (!empty($context['notwritable_files'])) {
1140
+					foreach ($context['notwritable_files'] as $file)
1119 1141
 				echo '
1120 1142
 						<li>', $file, '</li>';
1143
+		}
1121 1144
 
1122 1145
 		echo '
1123 1146
 					</ul>';
1124 1147
 
1125
-		if (!$context['server']['is_windows'])
1126
-			echo '
1148
+		if (!$context['server']['is_windows']) {
1149
+					echo '
1127 1150
 				<hr>
1128 1151
 				', $txt['package_chmod_linux'], '<br>
1129 1152
 				<tt># chmod a+w ', implode(' ', $context['notwritable_files']), '</tt>';
1153
+		}
1130 1154
 
1131 1155
 		echo '
1132 1156
 				</div>';
@@ -1137,9 +1161,10 @@  discard block
 block discarded – undo
1137 1161
 					<tt id="ftp_error_message">', !empty($context['package_ftp']['error']) ? $context['package_ftp']['error'] : '', '</tt>
1138 1162
 				</div></div>';
1139 1163
 
1140
-	if (!empty($context['package_ftp']['destination']))
1141
-		echo '
1164
+	if (!empty($context['package_ftp']['destination'])) {
1165
+			echo '
1142 1166
 				<form action="', $context['package_ftp']['destination'], '" method="post" accept-charset="', $context['character_set'], '" style="margin: 0;">';
1167
+	}
1143 1168
 
1144 1169
 	echo '
1145 1170
 					<fieldset>
@@ -1172,25 +1197,28 @@  discard block
 block discarded – undo
1172 1197
 					</dl>
1173 1198
 					</fieldset>';
1174 1199
 
1175
-	if (empty($context['package_ftp']['form_elements_only']))
1176
-		echo '
1200
+	if (empty($context['package_ftp']['form_elements_only'])) {
1201
+			echo '
1177 1202
 
1178 1203
 					<div class="righttext" style="margin: 1ex;">
1179 1204
 						<span id="test_ftp_placeholder_full"></span>
1180 1205
 						<input type="submit" value="', $txt['package_proceed'], '" class="button_submit">
1181 1206
 					</div>';
1207
+	}
1182 1208
 
1183
-	if (!empty($context['package_ftp']['destination']))
1184
-		echo '
1209
+	if (!empty($context['package_ftp']['destination'])) {
1210
+			echo '
1185 1211
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
1186 1212
 				</form>';
1213
+	}
1187 1214
 
1188 1215
 	// Hide the details of the list.
1189
-	if (empty($context['package_ftp']['form_elements_only']))
1190
-		echo '
1216
+	if (empty($context['package_ftp']['form_elements_only'])) {
1217
+			echo '
1191 1218
 		<script>
1192 1219
 			document.getElementById(\'need_writable_list\').style.display = \'none\';
1193 1220
 		</script>';
1221
+	}
1194 1222
 
1195 1223
 	// Quick generate the test button.
1196 1224
 	echo '
@@ -1546,9 +1574,10 @@  discard block
 block discarded – undo
1546 1574
 				<tr class="windowbg">
1547 1575
 					<td width="30%"><strong>';
1548 1576
 
1549
-				if (!empty($dir['type']) && ($dir['type'] == 'dir' || $dir['type'] == 'dir_recursive'))
1550
-					echo '
1577
+				if (!empty($dir['type']) && ($dir['type'] == 'dir' || $dir['type'] == 'dir_recursive')) {
1578
+									echo '
1551 1579
 						<span class="generic_icons folder"></span>';
1580
+				}
1552 1581
 
1553 1582
 				echo '
1554 1583
 						', $name, '
@@ -1565,8 +1594,9 @@  discard block
 block discarded – undo
1565 1594
 				</tr>
1566 1595
 			';
1567 1596
 
1568
-		if (!empty($dir['contents']))
1569
-			template_permission_show_contents($name, $dir['contents'], 1);
1597
+		if (!empty($dir['contents'])) {
1598
+					template_permission_show_contents($name, $dir['contents'], 1);
1599
+		}
1570 1600
 	}
1571 1601
 
1572 1602
 	echo '
@@ -1602,13 +1632,14 @@  discard block
 block discarded – undo
1602 1632
 			</fieldset>';
1603 1633
 
1604 1634
 	// Likely to need FTP?
1605
-	if (empty($context['ftp_connected']))
1606
-		echo '
1635
+	if (empty($context['ftp_connected'])) {
1636
+			echo '
1607 1637
 			<p>
1608 1638
 				', $txt['package_file_perms_ftp_details'], ':
1609 1639
 			</p>
1610 1640
 			', template_control_chmod(), '
1611 1641
 			<div class="noticebox">', $txt['package_file_perms_ftp_retain'], '</div>';
1642
+	}
1612 1643
 
1613 1644
 	echo '
1614 1645
 			<span id="test_ftp_placeholder_full"></span>
@@ -1617,9 +1648,10 @@  discard block
 block discarded – undo
1617 1648
 		</div>';
1618 1649
 
1619 1650
 	// Any looks fors we've already done?
1620
-	foreach ($context['look_for'] as $path)
1621
-		echo '
1651
+	foreach ($context['look_for'] as $path) {
1652
+			echo '
1622 1653
 			<input type="hidden" name="back_look[]" value="', $path, '">';
1654
+	}
1623 1655
 	echo '
1624 1656
 	</form><br>';
1625 1657
 }
@@ -1658,9 +1690,10 @@  discard block
 block discarded – undo
1658 1690
 				<td class="smalltext" width="30%">' . str_repeat('&nbsp;', $level * 5), '
1659 1691
 					', (!empty($dir['type']) && $dir['type'] == 'dir_recursive') || !empty($dir['list_contents']) ? '<a id="link_' . $cur_ident . '" href="' . $scripturl . '?action=admin;area=packages;sa=perms;find=' . base64_encode($ident . '/' . $name) . ';back_look=' . $context['back_look_data'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '#fol_' . $cur_ident . '" onclick="return expandFolder(\'' . $cur_ident . '\', \'' . addcslashes($ident . '/' . $name, "'\\") . '\');">' : '';
1660 1692
 
1661
-			if (!empty($dir['type']) && ($dir['type'] == 'dir' || $dir['type'] == 'dir_recursive'))
1662
-				echo '
1693
+			if (!empty($dir['type']) && ($dir['type'] == 'dir' || $dir['type'] == 'dir_recursive')) {
1694
+							echo '
1663 1695
 						<span class="generic_icons folder"></span>';
1696
+			}
1664 1697
 
1665 1698
 			echo '
1666 1699
 					', $name, '
@@ -1686,14 +1719,15 @@  discard block
 block discarded – undo
1686 1719
 	}
1687 1720
 
1688 1721
 	// We have more files to show?
1689
-	if ($has_more)
1690
-		echo '
1722
+	if ($has_more) {
1723
+			echo '
1691 1724
 	<tr class="windowbg" id="content_', $js_ident, '_more">
1692 1725
 		<td class="smalltext" width="40%">' . str_repeat('&nbsp;', $level * 5), '
1693 1726
 			&#171; <a href="' . $scripturl . '?action=admin;area=packages;sa=perms;find=' . base64_encode($ident) . ';fileoffset=', ($context['file_offset'] + $context['file_limit']), ';' . $context['session_var'] . '=' . $context['session_id'] . '#fol_' . preg_replace('~[^A-Za-z0-9_\-=:]~', ':-:', $ident) . '">', $txt['package_file_perms_more_files'], '</a> &#187;
1694 1727
 		</td>
1695 1728
 		<td colspan="6"></td>
1696 1729
 	</tr>';
1730
+	}
1697 1731
 
1698 1732
 	if ($drawn_div)
1699 1733
 	{
@@ -1701,15 +1735,17 @@  discard block
 block discarded – undo
1701 1735
 		$isFound = false;
1702 1736
 		foreach ($context['look_for'] as $tree)
1703 1737
 		{
1704
-			if (substr($tree, 0, strlen($ident)) == $ident)
1705
-				$isFound = true;
1738
+			if (substr($tree, 0, strlen($ident)) == $ident) {
1739
+							$isFound = true;
1740
+			}
1706 1741
 		}
1707 1742
 
1708
-		if ($level > 1 && !$isFound)
1709
-			echo '
1743
+		if ($level > 1 && !$isFound) {
1744
+					echo '
1710 1745
 		<script>
1711 1746
 			expandFolder(\'', $js_ident, '\', \'\');
1712 1747
 		</script>';
1748
+		}
1713 1749
 	}
1714 1750
 }
1715 1751
 
@@ -1729,11 +1765,12 @@  discard block
 block discarded – undo
1729 1765
 				<h3 class="catbg">', $txt['package_file_perms_applying'], '</h3>
1730 1766
 			</div>';
1731 1767
 
1732
-	if (!empty($context['skip_ftp']))
1733
-		echo '
1768
+	if (!empty($context['skip_ftp'])) {
1769
+			echo '
1734 1770
 			<div class="errorbox">
1735 1771
 				', $txt['package_file_perms_skipping_ftp'], '
1736 1772
 			</div>';
1773
+	}
1737 1774
 
1738 1775
 	// How many have we done?
1739 1776
 	$remaining_items = count($context['method'] == 'individual' ? $context['to_process'] : $context['directory_list']);
@@ -1771,28 +1808,31 @@  discard block
 block discarded – undo
1771 1808
 				<br>';
1772 1809
 
1773 1810
 	// Put out the right hidden data.
1774
-	if ($context['method'] == 'individual')
1775
-		echo '
1811
+	if ($context['method'] == 'individual') {
1812
+			echo '
1776 1813
 				<input type="hidden" name="custom_value" value="', $context['custom_value'], '">
1777 1814
 				<input type="hidden" name="totalItems" value="', $context['total_items'], '">
1778 1815
 				<input type="hidden" name="toProcess" value="', $context['to_process_encode'], '">';
1779
-	else
1780
-		echo '
1816
+	} else {
1817
+			echo '
1781 1818
 				<input type="hidden" name="predefined" value="', $context['predefined_type'], '">
1782 1819
 				<input type="hidden" name="fileOffset" value="', $context['file_offset'], '">
1783 1820
 				<input type="hidden" name="totalItems" value="', $context['total_items'], '">
1784 1821
 				<input type="hidden" name="dirList" value="', $context['directory_list_encode'], '">
1785 1822
 				<input type="hidden" name="specialFiles" value="', $context['special_files_encode'], '">';
1823
+	}
1786 1824
 
1787 1825
 	// Are we not using FTP for whatever reason.
1788
-	if (!empty($context['skip_ftp']))
1789
-		echo '
1826
+	if (!empty($context['skip_ftp'])) {
1827
+			echo '
1790 1828
 				<input type="hidden" name="skip_ftp" value="1">';
1829
+	}
1791 1830
 
1792 1831
 	// Retain state.
1793
-	foreach ($context['back_look_data'] as $path)
1794
-		echo '
1832
+	foreach ($context['back_look_data'] as $path) {
1833
+			echo '
1795 1834
 				<input type="hidden" name="back_look[]" value="', $path, '">';
1835
+	}
1796 1836
 
1797 1837
 	echo '
1798 1838
 				<input type="hidden" name="method" value="', $context['method'], '">
Please login to merge, or discard this patch.