Passed
Push — release-2.1 ( 12d126...77eee1 )
by Mathias
07:47 queued 16s
created
Sources/Profile-Modify.php 1 patch
Braces   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -156,7 +156,6 @@  discard block
 block discarded – undo
156 156
 					$diff = $cur_profile['date_registered'] - strtotime(smf_strftime('%Y-%m-%d', $cur_profile['date_registered']));
157 157
 					$value = $value + $diff;
158 158
 				}
159
-
160 159
 				else
161 160
 					$value = $cur_profile['date_registered'];
162 161
 
@@ -507,7 +506,7 @@  discard block
 block discarded – undo
507 506
 						log_error(sprintf($txt['smiley_set_dir_not_found'], $set_names[array_search($set, $context['smiley_sets'])]));
508 507
 
509 508
 						$context['smiley_sets'] = array_filter($context['smiley_sets'], function($v) use ($set)
510
-							{
509
+						{
511 510
 								return $v != $set;
512 511
 							});
513 512
 					}
@@ -3518,7 +3517,6 @@  discard block
 block discarded – undo
3518 3517
 			}
3519 3518
 		}
3520 3519
 	}
3521
-
3522 3520
 	elseif (($value == 'upload' && allowedTo('profile_upload_avatar')) || $downloadedExternalAvatar)
3523 3521
 	{
3524 3522
 		if ((isset($_FILES['attachment']['name']) && $_FILES['attachment']['name'] != '') || $downloadedExternalAvatar)
Please login to merge, or discard this patch.
Sources/Subs.php 1 patch
Spacing   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
 			{
380 380
 				$val = 'CASE ';
381 381
 				foreach ($members as $k => $v)
382
-					$val .= 'WHEN id_member = ' . $v . ' THEN '. alert_count($v, true) . ' ';
382
+					$val .= 'WHEN id_member = ' . $v . ' THEN ' . alert_count($v, true) . ' ';
383 383
 
384 384
 				$val = $val . ' END';
385 385
 				$type = 'raw';
@@ -871,11 +871,11 @@  discard block
 block discarded – undo
871 871
 			// Anything that isn't a specification, punctuation mark, or whitespace.
872 872
 			'~(?<!%)\p{L}|[^\p{L}\p{P}\s]~u',
873 873
 			// A series of punctuation marks (except %), possibly separated by whitespace.
874
-			'~([^%\P{P}])(\s*)(?'.'>(\1|[^%\P{Po}])\s*(?!$))*~u',
874
+			'~([^%\P{P}])(\s*)(?' . '>(\1|[^%\P{Po}])\s*(?!$))*~u',
875 875
 			// Unwanted trailing punctuation and whitespace.
876
-			'~(?'.'>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
876
+			'~(?' . '>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
877 877
 			// Unwanted opening punctuation and whitespace.
878
-			'~^\s*(?'.'>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
878
+			'~^\s*(?' . '>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
879 879
 		),
880 880
 		array(
881 881
 			'',
@@ -1178,7 +1178,7 @@  discard block
 block discarded – undo
1178 1178
 	{
1179 1179
 		$dates[$tzid . '_' . $timestamp]['results'][$format] = preg_replace_callback(
1180 1180
 			'/\xEE\x84\xA0([\d_]+)(\xEE\x84(?:[\xA1-\xAF]))/',
1181
-			function ($matches)
1181
+			function($matches)
1182 1182
 			{
1183 1183
 				switch ($matches[2])
1184 1184
 				{
@@ -1312,7 +1312,7 @@  discard block
 block discarded – undo
1312 1312
 	elseif (!empty($context['character_set']) && is_callable('mb_decode_numericentity'))
1313 1313
 	{
1314 1314
 		// Get whatever the default replacement character is for this encoding.
1315
-		$substitute = mb_decode_numericentity('&#xFFFD;', array(0xFFFD,0xFFFD,0,0xFFFF), $context['character_set']);
1315
+		$substitute = mb_decode_numericentity('&#xFFFD;', array(0xFFFD, 0xFFFD, 0, 0xFFFF), $context['character_set']);
1316 1316
 	}
1317 1317
 	else
1318 1318
 		$substitute = '?';
@@ -1787,7 +1787,7 @@  discard block
 block discarded – undo
1787 1787
 								$returnContext .= '<img src="' . $currentAttachment['href'] . '"' . $alt . $title . ' class="bbc_img">';
1788 1788
 							else
1789 1789
 							{
1790
-								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"': '';
1790
+								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"' : '';
1791 1791
 								$height = !empty($params['{height}']) ? 'height="' . $params['{height}'] . '"' : '';
1792 1792
 								$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img resized"/>';
1793 1793
 							}
@@ -1798,7 +1798,7 @@  discard block
 block discarded – undo
1798 1798
 							$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"' : '';
1799 1799
 							$height = !empty($params['{height}']) ? ' height="' . $params['{height}'] . '"' : '';
1800 1800
 
1801
-							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="'. $currentAttachment['href'] . '" playsinline' . $width . $height . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
1801
+							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="' . $currentAttachment['href'] . '" playsinline' . $width . $height . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
1802 1802
 						}
1803 1803
 						// Audio.
1804 1804
 						elseif (strpos($currentAttachment['mime_type'], 'audio/') === 0)
@@ -1806,7 +1806,7 @@  discard block
 block discarded – undo
1806 1806
 							$width = 'max-width:100%; width: ' . (!empty($params['{width}']) ? $params['{width}'] : '400') . 'px;';
1807 1807
 							$height = !empty($params['{height}']) ? 'height: ' . $params['{height}'] . 'px;' : '';
1808 1808
 
1809
-							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="'. $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . $height . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
1809
+							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="' . $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . $height . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
1810 1810
 						}
1811 1811
 						// Anything else.
1812 1812
 						else
@@ -1975,7 +1975,7 @@  discard block
 block discarded – undo
1975 1975
 				'type' => 'unparsed_commas_content',
1976 1976
 				'test' => '\d+,\d+\]',
1977 1977
 				'content' => '<a href="$1" target="_blank" rel="noopener">$1</a>',
1978
-				'validate' => function (&$tag, &$data, $disabled)
1978
+				'validate' => function(&$tag, &$data, $disabled)
1979 1979
 				{
1980 1980
 					$data[0] = normalize_iri($data[0]);
1981 1981
 
@@ -2101,8 +2101,8 @@  discard block
 block discarded – undo
2101 2101
 					else
2102 2102
 						$url = get_proxied_url($url);
2103 2103
 
2104
-					$alt = !empty($params['{alt}']) ? ' alt="' . $params['{alt}']. '"' : ' alt=""';
2105
-					$title = !empty($params['{title}']) ? ' title="' . $params['{title}']. '"' : '';
2104
+					$alt = !empty($params['{alt}']) ? ' alt="' . $params['{alt}'] . '"' : ' alt=""';
2105
+					$title = !empty($params['{title}']) ? ' title="' . $params['{title}'] . '"' : '';
2106 2106
 
2107 2107
 					$data = isset($disabled[$tag['tag']]) ? $url : '<img src="' . $url . '"' . $alt . $title . $params['{width}'] . $params['{height}'] . ' class="bbc_img' . (!empty($params['{width}']) || !empty($params['{height}']) ? ' resized' : '') . '" loading="lazy">';
2108 2108
 				},
@@ -2533,12 +2533,12 @@  discard block
 block discarded – undo
2533 2533
 		$codes[] = array(
2534 2534
 			'tag' => 'cowsay',
2535 2535
 			'parameters' => array(
2536
-				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function ($eyes) use ($smcFunc)
2536
+				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function($eyes) use ($smcFunc)
2537 2537
 					{
2538 2538
 						return $smcFunc['substr']($eyes . 'oo', 0, 2);
2539 2539
 					},
2540 2540
 				),
2541
-				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function ($tongue) use ($smcFunc)
2541
+				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function($tongue) use ($smcFunc)
2542 2542
 					{
2543 2543
 						return $smcFunc['substr']($tongue . '  ', 0, 2);
2544 2544
 					},
@@ -4243,7 +4243,7 @@  discard block
 block discarded – undo
4243 4243
 		if ($fp != false)
4244 4244
 		{
4245 4245
 			// Send the HEAD request (since we don't have to worry about chunked, HTTP/1.1 is fine here.)
4246
-			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: '. SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
4246
+			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: ' . SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
4247 4247
 
4248 4248
 			// Read in the HTTP/1.1 or whatever.
4249 4249
 			$test = substr(fgets($fp, 11), -1);
@@ -4839,7 +4839,7 @@  discard block
 block discarded – undo
4839 4839
 
4840 4840
 	uasort(
4841 4841
 		$context['css_files'],
4842
-		function ($a, $b)
4842
+		function($a, $b)
4843 4843
 		{
4844 4844
 			return $a['options']['order_pos'] < $b['options']['order_pos'] ? -1 : ($a['options']['order_pos'] > $b['options']['order_pos'] ? 1 : 0);
4845 4845
 		}
@@ -6136,7 +6136,7 @@  discard block
 block discarded – undo
6136 6136
 			{
6137 6137
 				fwrite($fp, 'GET ' . ($match[6] !== '/' ? str_replace(' ', '%20', $match[6]) : '') . ' HTTP/1.0' . "\r\n");
6138 6138
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
6139
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
6139
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
6140 6140
 				if ($keep_alive)
6141 6141
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n\r\n");
6142 6142
 				else
@@ -6146,7 +6146,7 @@  discard block
 block discarded – undo
6146 6146
 			{
6147 6147
 				fwrite($fp, 'POST ' . ($match[6] !== '/' ? $match[6] : '') . ' HTTP/1.0' . "\r\n");
6148 6148
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
6149
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
6149
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
6150 6150
 				if ($keep_alive)
6151 6151
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n");
6152 6152
 				else
@@ -6395,13 +6395,13 @@  discard block
 block discarded – undo
6395 6395
 
6396 6396
 	// UTF-8 occurences of MS special characters
6397 6397
 	$findchars_utf8 = array(
6398
-		"\xe2\x80\x9a",	// single low-9 quotation mark
6399
-		"\xe2\x80\x9e",	// double low-9 quotation mark
6400
-		"\xe2\x80\xa6",	// horizontal ellipsis
6401
-		"\xe2\x80\x98",	// left single curly quote
6402
-		"\xe2\x80\x99",	// right single curly quote
6403
-		"\xe2\x80\x9c",	// left double curly quote
6404
-		"\xe2\x80\x9d",	// right double curly quote
6398
+		"\xe2\x80\x9a", // single low-9 quotation mark
6399
+		"\xe2\x80\x9e", // double low-9 quotation mark
6400
+		"\xe2\x80\xa6", // horizontal ellipsis
6401
+		"\xe2\x80\x98", // left single curly quote
6402
+		"\xe2\x80\x99", // right single curly quote
6403
+		"\xe2\x80\x9c", // left double curly quote
6404
+		"\xe2\x80\x9d", // right double curly quote
6405 6405
 	);
6406 6406
 
6407 6407
 	// windows 1252 / iso equivalents
@@ -6417,13 +6417,13 @@  discard block
 block discarded – undo
6417 6417
 
6418 6418
 	// safe replacements
6419 6419
 	$replacechars = array(
6420
-		',',	// &sbquo;
6421
-		',,',	// &bdquo;
6422
-		'...',	// &hellip;
6423
-		"'",	// &lsquo;
6424
-		"'",	// &rsquo;
6425
-		'"',	// &ldquo;
6426
-		'"',	// &rdquo;
6420
+		',', // &sbquo;
6421
+		',,', // &bdquo;
6422
+		'...', // &hellip;
6423
+		"'", // &lsquo;
6424
+		"'", // &rsquo;
6425
+		'"', // &ldquo;
6426
+		'"', // &rdquo;
6427 6427
 	);
6428 6428
 
6429 6429
 	if ($context['utf8'])
@@ -6786,7 +6786,7 @@  discard block
 block discarded – undo
6786 6786
 		// We don't want abbreviations like '+03' or '-11'.
6787 6787
 		$abbrs = array_filter(
6788 6788
 			$tzvalue['abbrs'],
6789
-			function ($abbr)
6789
+			function($abbr)
6790 6790
 			{
6791 6791
 				return !strspn($abbr, '+-');
6792 6792
 			}
@@ -7776,7 +7776,7 @@  discard block
 block discarded – undo
7776 7776
 			EXISTS (
7777 7777
 				SELECT bpv.id_board
7778 7778
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
7779
-				WHERE bpv.id_group IN ('. implode(',', $groups) .')
7779
+				WHERE bpv.id_group IN ('. implode(',', $groups) . ')
7780 7780
 					AND bpv.deny = 0
7781 7781
 					AND bpv.id_board = b.id_board
7782 7782
 			)';
@@ -7786,7 +7786,7 @@  discard block
 block discarded – undo
7786 7786
 			AND NOT EXISTS (
7787 7787
 				SELECT bpv.id_board
7788 7788
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
7789
-				WHERE bpv.id_group IN ( '. implode(',', $groups) .')
7789
+				WHERE bpv.id_group IN ( '. implode(',', $groups) . ')
7790 7790
 					AND bpv.deny = 1
7791 7791
 					AND bpv.id_board = b.id_board
7792 7792
 			)';
@@ -8193,8 +8193,8 @@  discard block
 block discarded – undo
8193 8193
 	$i = 0;
8194 8194
 	while (empty($done))
8195 8195
 	{
8196
-		if (strpos($format, '{'. --$i . '}') !== false)
8197
-			$replacements['{'. $i . '}'] = array_pop($list);
8196
+		if (strpos($format, '{' . --$i . '}') !== false)
8197
+			$replacements['{' . $i . '}'] = array_pop($list);
8198 8198
 		else
8199 8199
 			$done = true;
8200 8200
 	}
@@ -8204,8 +8204,8 @@  discard block
 block discarded – undo
8204 8204
 	$i = 0;
8205 8205
 	while (empty($done))
8206 8206
 	{
8207
-		if (strpos($format, '{'. ++$i . '}') !== false)
8208
-			$replacements['{'. $i . '}'] = array_shift($list);
8207
+		if (strpos($format, '{' . ++$i . '}') !== false)
8208
+			$replacements['{' . $i . '}'] = array_shift($list);
8209 8209
 		else
8210 8210
 			$done = true;
8211 8211
 	}
@@ -8383,7 +8383,7 @@  discard block
 block discarded – undo
8383 8383
 	if (empty($stringSubject))
8384 8384
 		return '';
8385 8385
 
8386
-	$translatable_tokens = preg_match_all('/{(.*?)}/' , $stringSubject, $matches);
8386
+	$translatable_tokens = preg_match_all('/{(.*?)}/', $stringSubject, $matches);
8387 8387
 	$toFind = array();
8388 8388
 	$replaceWith = array();
8389 8389
 
Please login to merge, or discard this patch.
Sources/Load.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 	// Set a list of common functions.
108 108
 	$ent_list = '&(?:#' . (empty($modSettings['disableEntityCheck']) ? '\d{1,7}' : '021') . '|quot|amp|lt|gt|nbsp);';
109 109
 	$ent_check = empty($modSettings['disableEntityCheck']) ? function($string)
110
-		{
110
+	{
111 111
 			$string = preg_replace_callback('~(&#(\d{1,7}|x[0-9a-fA-F]{1,6});)~', 'entity_fix__callback', $string);
112 112
 			return $string;
113 113
 		} : function($string)
@@ -2422,7 +2422,6 @@  discard block
 block discarded – undo
2422 2422
 		loadLanguage('index+Modifications');
2423 2423
 		$context['template_layers'] = array();
2424 2424
 	}
2425
-
2426 2425
 	else
2427 2426
 	{
2428 2427
 		// Custom templates to load, or just default?
Please login to merge, or discard this patch.