akeneo-labs / CustomEntityBundle

Action/AbstractAction.php

Doc Comments +2 added lines, -3 removed lines

@@ -142,7 +142,6 @@ 
     /**
      * Set the default options
      *
-     * @param ConfigurationInterface   $configuration
      * @param OptionsResolverInterface $resolver
      */
     protected function setDefaultOptions(OptionsResolverInterface $resolver)
@@ -203,8 +202,8 @@ 
      * Adds a flash message
      *
      * @param Request $request
-     * @param type    $type
-     * @param type    $message
+     * @param string    $type
+     * @param type    string
      * @param array   $messageParameters
      */
     protected function addFlash(Request $request, $type, $message, array $messageParameters = [])

Action/AbstractFormAction.php

Doc Comments +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
      *
      * @param object $object
      *
-     * @return Response
+     * @return RedirectResponse
      */
     protected function getRedirectResponse($object)
     {

Indentation +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
      */
     protected function saveForm(Request $request, FormInterface $form)
     {
-       $this->getManager()->save($form->getData(), $this->options['save_options']);
+        $this->getManager()->save($form->getData(), $this->options['save_options']);
     }
 
     /**

Datasource/CustomEntityDatasource.php

Doc Comments -2 removed lines

@@ -34,8 +34,6 @@
     /**
      * Constructor
      *
-     * @param EntityManager $em
-     * @param AclHelper     $aclHelper
      * @param LocaleHelper  $localeHelper
      */
     public function __construct(

Entity/Repository/TranslatableCustomOptionRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -64,9 +64,9 @@
     /**
      * Creates a query builder for options
      *
-     * @param type  $dataLocale
+     * @param string  $dataLocale
      * @param type  $collectionId
-     * @param type  $search
+     * @param string  $search
      * @param array $options
      *
      * @return \Doctrine\ORM\QueryBuilder

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 
         return array(
             'results' => array_map(
-                function ($option) {
+                function($option) {
                     if (!$option['text']) {
                         $option['text'] = $option['code'];
                     }

Event/PreRenderActionEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      * Constructor
      *
      * @param ActionInterface $action
-     * @param type            $template
+     * @param string            $template
      * @param array           $templateVars
      */
     public function __construct(ActionInterface $action, $template, array $templateVars)

EventListener/DataGrid/ConfigureCustomEntityGridListener.php

Doc Comments -1 removed lines

@@ -80,7 +80,6 @@
      * Sets the configuration for row actions
      *
      * @param DatagridConfiguration  $datagridConfig
-     * @param ConfigurationInterface $customEntityConfig
      */
     protected function setRowActions(DatagridConfiguration $datagridConfig, ActionInterface $indexAction)
     {

Spacing +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
     {
         $customEntityConfig = $indexAction->getConfiguration();
         $options = $indexAction->getOptions();
-        $sourceOptions = ($datagridConfig->offsetGetByPath('[source]')?:[]) + [
+        $sourceOptions = ($datagridConfig->offsetGetByPath('[source]') ?: []) + [
                 'entity' => $customEntityConfig->getEntityClass(),
                 'type'   => 'pim_custom_entity'
         ];
@@ -89,8 +89,8 @@ 
         $actions = [];
 
         foreach ($indexAction->getRowActions() as $rowActionType) {
-            $link = $rowActionType . '_link';
-            $rowAction  = $this->actionFactory->getAction($name, $rowActionType);
+            $link = $rowActionType.'_link';
+            $rowAction = $this->actionFactory->getAction($name, $rowActionType);
             $actions[$rowActionType] = $rowAction->getGridActionOptions() + ['link' => $link];
             $properties[$link] = [
                 'type'   => 'custom_entity_url',

MassAction/DataGridQueryGenerator.php

Doc Comments +1 added lines

@@ -92,6 +92,7 @@
     }
 
     /**
+     * @param string $datagridName
      * @return array
      */
     public function getIds(Request $request, $datagridName)

Action/QuickExportAction.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
         }
 
         $response = new StreamedResponse(
-            function () use ($request) {
+            function() use ($request) {
                 $this->export($request);
             }
         );

EventListener/Action/SecurityListener.php

Spacing +4 added lines, -4 removed lines

@@ -88,9 +88,9 @@ 
         $resolver->setOptional(['acl_suffix']);
         $resolver->setNormalizers(
             [
-                'acl' => function ($actionOptions, $acl) use ($options) {
+                'acl' => function($actionOptions, $acl) use ($options) {
                     if (null === $acl && isset($options['acl_prefix']) && isset($actionOptions['acl_suffix'])) {
-                        return $options['acl_prefix'] . $options['acl_separator'] .
+                        return $options['acl_prefix'].$options['acl_separator'].
                             $actionOptions['acl_suffix'];
                     }
 
@@ -99,10 +99,10 @@ 
             ]
         );
         $customEntityName = $event->getAction()->getConfiguration()->getName();
-        $normalizeActions = function ($options, $actionTypes) use ($customEntityName) {
+        $normalizeActions = function($options, $actionTypes) use ($customEntityName) {
             return array_filter(
                 $actionTypes,
-                function ($actionType) use ($customEntityName) {
+                function($actionType) use ($customEntityName) {
                     $action = $this->actionFactory->getAction($customEntityName, $actionType);
                     $options = $action->getOptions();