Code Quality Summary - ajoaoff/mef_eline - Measure and Improve Code Quality continuously with Scrutinizer

2022-04-11 20:09 UTC

Inspected fix: Change client vlan on fir...

	Good job, 3 issues were fixed.
	1 added class/operation
		A	build.utils.notify_link_available_tags() added
A	↘	B	build.tests.unit.models.test_evc_deploy.TestEVC.test_prepare_push_flow... got worse
C	↘	D	build.models.evc.EVCDeploy.deploy_to_path() got worse
A	↘	B	build.models.evc.EVCDeploy._prepare_push_flow() got worse

2022-01-12 15:43 UTC

Inspected Merge pull request #129 from k...

	Good job, 2 issues were fixed.
	22 added classes/operations
		C	build.main.Main.execute_consistency() added
		B	build.tests.unit.test_main.TestMain.test_create_schedule_invalid_reque... added
		B	build.utils.validate() added
		A	build.tests.helpers.MockResponse.__str__() added
		A	build.main.Main.on_link_up() added
		A	build.main.Main.on_link_down() added
		A	build.utils.load_spec() added
		A	build.tests.unit.test_storehouse.TestStoreHouse.test_create_box_callba... added
		A	build.tests.unit.test_storehouse.TestStoreHouse.test_get_or_create_box... added
		A	build.tests.unit.test_storehouse.TestStoreHouse.test_get_box_callback(... added
C	↗	A	build.main.Main.execute() improved
C	↘	D	build.tests.unit.test_main got worse
A	↘	B	build.tests.unit.models.test_evc_deploy.TestEVC.test_install_nni_flows... got worse
A	↘	B	build.models.evc.EVCDeploy._install_uni_flows() got worse
A	↘	B	build.tests.unit.test_main.TestMain.test_verify_api_urls() got worse
A	↘	B	build.tests.unit.models.test_link_protection.TestLinkProtection.test_h... got worse
A	↘	B	build.tests.unit.models.test_link_protection.TestLinkProtection.test_h... got worse
F	↗	D	build.main.Main.create_circuit() improved
view all

2021-12-02 22:39 UTC

Inspected Try gh (#96)

	74 added classes/operations
		F	build.models.evc added
		C	build.models.evc.LinkProtection.handle_link_up() added
		C	build.models.path.Path.is_valid() added
		C	build.models.evc.EVCDeploy.deploy_to_path() added
		C	build.models.evc.EVCBase.update() added
		B	build.models.path.Path.status() added
		B	build.tests.unit.test_main.TestMain.test_update_circuit_invalid_path() added
		B	build.models.evc.EVCDeploy._install_direct_uni_flows() added
		B	build.models.evc.EVCBase._validate() added
		B	build.models.evc.EVCBase.__init__() added
F	↗	A	build.models improved
A	↘	C	build.main.Main.execute() got worse
C	↘	F	build.main.Main.create_circuit() got worse
B	↘	C	build.tests.unit.test_main got worse
view all

2021-10-19 19:21 UTC

Inspected Merge pull request #67 from rm...

	Good job, 3 issues were fixed.
	7 added classes/operations
		A	build.tests.unit.models.test_evc_base.TestEVC.test_update_read_only() added
		A	build.tests.unit.test_main.TestMain.test_create_circuit_case_5() added
		A	build.tests.unit.test_main.TestMain.test_redeploy_evc_deleted() added
		A	build.tests.unit.test_main.TestMain.test_redeploy_evc_disabled() added
		A	build.tests.unit.test_main.TestMain.test_redeploy_evc() added
		A	build.main.Main._json_from_request() added
		A	build.main.Main.redeploy() added
C	↗	B	build.models.EVCBase.update() improved
B	↘	C	build.main.Main.create_circuit() got worse

2021-08-04 00:35 UTC

Inspected Merge pull request #30 from aj...

	2 issues (2 informational) were introduced.
	5 added classes/operations
		B	build.tests.unit.models.test_evc_deploy.TestEVC.test_deploy_error() added
		A	build.utils.emit_event() added
		A	build.main.Main.load_all_evcs() added
		A	build.main.Main._load_evc() added
		A	build.utils added
C	↘	D	build.main.Main.update() got worse

2021-05-13 19:59 UTC

Inspected Merge pull request #242 from c...

	4 issues (4 informational) were introduced.
	17 added classes/operations
		B	build.tests.unit.test_main.TestMain.test_update_evc_no_json_mime() added
		A	build.tests.unit.models.test_evc_base.TestEVC.test_update_disable() added
		A	build.tests.unit.test_storehouse.TestStoreHouse.test_get_data() added
		A	build.main.Main.handle_flow_mod_error() added
		A	build.tests.unit.test_storehouse.TestStoreHouse.setUp() added
		A	build.tests.unit.test_storehouse.TestStoreHouse.test_save_evc_callback... added
		A	build.tests.unit.test_storehouse.TestStoreHouse.test_get_stored_box() added
		A	build.tests.unit.test_storehouse.TestStoreHouse.test_save_evc_callback... added
		A	build.tests.unit.models.test_path.TestPath.test_is_affected_by_link_1(... added
		A	build.tests.unit.test_storehouse.TestStoreHouse.test_create_box() added
B	↗	A	build.tests.unit.models.test_evc_deploy.TestEVC.test_prepare_push_flow... improved
B	↗	A	build.models.EVCDeploy._prepare_push_flow() improved
view all

2021-03-31 13:58 UTC

Inspected Merge pull request #222 from h...

C

↗

B

build.main.Main.load_evcs() improved

2021-03-25 18:32 UTC

Inspected Generate log message when an E...

	1 issue (minor) was introduced.
	1 added class/operation
		A	build.tests.unit.models.test_evc_deploy.TestEVC.test_deploy_to_backup_... added
A	↘	B	build.models.EVCDeploy.deploy_to_backup_path() got worse
B	↘	C	build.models.EVCDeploy.deploy_to_path() got worse

2021-01-13 13:03 UTC

Inspected Merge pull request #200 from a...

	Good job, 3 issues were fixed.
	11 added classes/operations
		F	build.models added
		B	build.models.EVCDeploy._install_direct_uni_flows() added
		A	build.models.EVCDeploy.discover_new_paths() added
		A	build.models.DynamicPathManager.get_best_paths() added
		A	build.tests.unit.models.test_path.TestPath._mocked_requests_get_status... added
		A	build.tests.unit.models.test_path.TestPath._mocked_requests_get_status... added
		A	build.tests.unit.models.test_path.TestPath.test_status_case_6() added
		A	build.tests.unit.models.test_path.TestPath.test_status_case_5() added
		A	build.main.Main.json_from_request() added
		A	build.tests added
A	↘	B	build.models.EVCDeploy.deploy_to_path() got worse
B	↘	C	build.models.EVCBase.update() got worse
A	↘	B	build.models.EVCDeploy._prepare_push_flow() got worse
B	↗	A	build.main.Main.update_schedule() improved
D	↗	C	build.main.Main.update() improved
C	↗	B	build.main.Main.create_schedule() improved
A	↘	B	build.tests.unit.models.test_evc_deploy.TestEVC.test_prepare_push_flow... got worse
view all

2019-11-27 11:50 UTC

Inspected Update now instantiates the ri...

	Test Coverage has increased to 67% (+2%).
	3 added classes/operations
		C	build.main.Main._evc_dict_with_instances() added
		B	build.tests.test_main.TestMain.test_update_circuit() added
		B	build.tests.test_main.TestMain.test_update_circuit_invalid_json() added
C	↗	A	build.main.Main._evc_from_dict() improved
B	↘	C	build.main.Main.load_evcs() got worse

2019-11-21 12:34 UTC

Inspected By default, list EVCs now retu...

2 issues (2 informational) were introduced.
2 added classes/operations
	A	build.tests.test_main.TestMain.test_list_with_archived_circuits_stored... added
	A	build.tests.test_main.TestMain.test_list_with_archived_circuits_stored... added

2019-10-18 14:01 UTC

Inspected Merge pull request #161 from r...

A

↘

B

build.main.Main.list_schedules() got worse

2019-09-03 18:09 UTC

Inspected Merge pull request #156 from a...

	Test Coverage has decreased to 63% (-1%).
	4 added classes/operations
		B	build.main.Main.load_evcs() added
		B	build.tests.test_main.TestMain.test_load_circuits_by_interface() added
		A	build.main.Main.load_circuits_by_interface() added
		A	build.main.Main.add_to_dict_of_sets() added
B	↘	F	build.main got worse

2019-06-13 17:16 UTC

Inspected Merge pull request #137 from a...

3 issues (3 informational) were introduced. 1 issue was fixed.
3 added classes/operations
	B	build.tests.test_main.TestMain.test_create_circuit_already_enabled() added
	A	build.models.EVCBase.archive() added
	A	build.scheduler.Scheduler.remove() added

2019-04-11 12:43 UTC

The first inspection on "master" completed

	Your code was rated 7.48 (good). Learn more about the code rating.
	There were 7 issues found.

Image URL
Markdown
Textile
RDOC
AsciiDoc

Badges

Latest Alerts

ajoaoff / mef_eline

Badges

Latest Alerts