Inspection of "Support databases other than MySQL" - aimeos/aimeos-typo3 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d4d3fd...3c1709 )

by Aimeos

created 2023-03-10 15:35 UTC

Status

Indentation +63 added lines, -63 removed lines patch added patch discarded remove patch

@@ -4,67 +4,67 @@
 block discarded – undo
 $defaultConnection = $GLOBALS['TYPO3_CONF_VARS']['DB']['Connections']['Default'];
 
 return [
-	'db' => [
-		'adapter' => ($defaultConnection['driver'] ?? 'mysql') !== 'mysqli' ?: 'mysql',
-		'host' => $defaultConnection['host'] ?? null,
-		'port' => $defaultConnection['port'] ?? null,
-		'socket' => $defaultConnection['socket'] ?? null,
-		'database' => $defaultConnection['dbname'] ?? null,
-		'username' => $defaultConnection['user'] ?? null,
-		'password' => $defaultConnection['password'] ?? null,
-		'stmt' => ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"],
-		'defaultTableOptions' => [
-			'charset' => $defaultConnection['tableoptions']['charset'] ?? 'utf8',
-			'collate' => $defaultConnection['tableoptions']['collate'] ?? 'utf8_unicode_ci',
-		],
-		'limit' => 3,
-	],
-	'fs' => [
-		'adapter' => 'Standard',
-		'baseurl' => '/uploads/tx_aimeos',
-		'basedir' => $publicPath . '/uploads/tx_aimeos',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-media' => [
-		'adapter' => 'Standard',
-		'baseurl' => '/uploads/tx_aimeos',
-		'basedir' => $publicPath . '/uploads/tx_aimeos',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-mimeicon' => [
-		'adapter' => 'Standard',
-		'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
-		'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-theme' => [
-		'adapter' => 'Standard',
-		'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Themes',
-		'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Themes',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-admin' => [
-		'adapter' => 'Standard',
-		'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/admin',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-export' => [
-		'adapter' => 'Standard',
-		'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/export',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-import' => [
-		'adapter' => 'Standard',
-		'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/import',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-secure' => [
-		'adapter' => 'Standard',
-		'basedir' => $publicPath . '/uploads/tx_aimeos/.secure',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'mq' => [
-		'adapter' => 'Standard',
-		'db' => 'db',
-	],
+    'db' => [
+        'adapter' => ($defaultConnection['driver'] ?? 'mysql') !== 'mysqli' ?: 'mysql',
+        'host' => $defaultConnection['host'] ?? null,
+        'port' => $defaultConnection['port'] ?? null,
+        'socket' => $defaultConnection['socket'] ?? null,
+        'database' => $defaultConnection['dbname'] ?? null,
+        'username' => $defaultConnection['user'] ?? null,
+        'password' => $defaultConnection['password'] ?? null,
+        'stmt' => ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"],
+        'defaultTableOptions' => [
+            'charset' => $defaultConnection['tableoptions']['charset'] ?? 'utf8',
+            'collate' => $defaultConnection['tableoptions']['collate'] ?? 'utf8_unicode_ci',
+        ],
+        'limit' => 3,
+    ],
+    'fs' => [
+        'adapter' => 'Standard',
+        'baseurl' => '/uploads/tx_aimeos',
+        'basedir' => $publicPath . '/uploads/tx_aimeos',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-media' => [
+        'adapter' => 'Standard',
+        'baseurl' => '/uploads/tx_aimeos',
+        'basedir' => $publicPath . '/uploads/tx_aimeos',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-mimeicon' => [
+        'adapter' => 'Standard',
+        'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
+        'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-theme' => [
+        'adapter' => 'Standard',
+        'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Themes',
+        'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Themes',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-admin' => [
+        'adapter' => 'Standard',
+        'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/admin',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-export' => [
+        'adapter' => 'Standard',
+        'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/export',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-import' => [
+        'adapter' => 'Standard',
+        'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/import',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-secure' => [
+        'adapter' => 'Standard',
+        'basedir' => $publicPath . '/uploads/tx_aimeos/.secure',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'mq' => [
+        'adapter' => 'Standard',
+        'db' => 'db',
+    ],
 ];

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -5,7 +5,7 @@
 block discarded – undo
 
 return [
 	'db' => [
-		'adapter' => ($defaultConnection['driver'] ?? 'mysql') !== 'mysqli' ?: 'mysql',
+		'adapter' => ( $defaultConnection['driver'] ?? 'mysql' ) !== 'mysqli' ?: 'mysql',
 		'host' => $defaultConnection['host'] ?? null,
 		'port' => $defaultConnection['port'] ?? null,
 		'socket' => $defaultConnection['socket'] ?? null,

Please login to merge, or discard this patch.

		@@ -4,67 +4,67 @@
		block discarded – undo
4	4	$defaultConnection = $GLOBALS['TYPO3_CONF_VARS']['DB']['Connections']['Default'];
5	5
6	6	return [
7		- 'db' => [
8		- 'adapter' => ($defaultConnection['driver'] ?? 'mysql') !== 'mysqli' ?: 'mysql',
9		- 'host' => $defaultConnection['host'] ?? null,
10		- 'port' => $defaultConnection['port'] ?? null,
11		- 'socket' => $defaultConnection['socket'] ?? null,
12		- 'database' => $defaultConnection['dbname'] ?? null,
13		- 'username' => $defaultConnection['user'] ?? null,
14		- 'password' => $defaultConnection['password'] ?? null,
15		- 'stmt' => ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"],
16		- 'defaultTableOptions' => [
17		- 'charset' => $defaultConnection['tableoptions']['charset'] ?? 'utf8',
18		- 'collate' => $defaultConnection['tableoptions']['collate'] ?? 'utf8_unicode_ci',
19		- ],
20		- 'limit' => 3,
21		- ],
22		- 'fs' => [
23		- 'adapter' => 'Standard',
24		- 'baseurl' => '/uploads/tx_aimeos',
25		- 'basedir' => $publicPath . '/uploads/tx_aimeos',
26		- 'tempdir' => $publicPath . '/typo3temp',
27		- ],
28		- 'fs-media' => [
29		- 'adapter' => 'Standard',
30		- 'baseurl' => '/uploads/tx_aimeos',
31		- 'basedir' => $publicPath . '/uploads/tx_aimeos',
32		- 'tempdir' => $publicPath . '/typo3temp',
33		- ],
34		- 'fs-mimeicon' => [
35		- 'adapter' => 'Standard',
36		- 'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
37		- 'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
38		- 'tempdir' => $publicPath . '/typo3temp',
39		- ],
40		- 'fs-theme' => [
41		- 'adapter' => 'Standard',
42		- 'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Themes',
43		- 'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Themes',
44		- 'tempdir' => $publicPath . '/typo3temp',
45		- ],
46		- 'fs-admin' => [
47		- 'adapter' => 'Standard',
48		- 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/admin',
49		- 'tempdir' => $publicPath . '/typo3temp',
50		- ],
51		- 'fs-export' => [
52		- 'adapter' => 'Standard',
53		- 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/export',
54		- 'tempdir' => $publicPath . '/typo3temp',
55		- ],
56		- 'fs-import' => [
57		- 'adapter' => 'Standard',
58		- 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/import',
59		- 'tempdir' => $publicPath . '/typo3temp',
60		- ],
61		- 'fs-secure' => [
62		- 'adapter' => 'Standard',
63		- 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure',
64		- 'tempdir' => $publicPath . '/typo3temp',
65		- ],
66		- 'mq' => [
67		- 'adapter' => 'Standard',
68		- 'db' => 'db',
69		- ],
	7	+ 'db' => [
	8	+ 'adapter' => ($defaultConnection['driver'] ?? 'mysql') !== 'mysqli' ?: 'mysql',
	9	+ 'host' => $defaultConnection['host'] ?? null,
	10	+ 'port' => $defaultConnection['port'] ?? null,
	11	+ 'socket' => $defaultConnection['socket'] ?? null,
	12	+ 'database' => $defaultConnection['dbname'] ?? null,
	13	+ 'username' => $defaultConnection['user'] ?? null,
	14	+ 'password' => $defaultConnection['password'] ?? null,
	15	+ 'stmt' => ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"],
	16	+ 'defaultTableOptions' => [
	17	+ 'charset' => $defaultConnection['tableoptions']['charset'] ?? 'utf8',
	18	+ 'collate' => $defaultConnection['tableoptions']['collate'] ?? 'utf8_unicode_ci',
	19	+ ],
	20	+ 'limit' => 3,
	21	+ ],
	22	+ 'fs' => [
	23	+ 'adapter' => 'Standard',
	24	+ 'baseurl' => '/uploads/tx_aimeos',
	25	+ 'basedir' => $publicPath . '/uploads/tx_aimeos',
	26	+ 'tempdir' => $publicPath . '/typo3temp',
	27	+ ],
	28	+ 'fs-media' => [
	29	+ 'adapter' => 'Standard',
	30	+ 'baseurl' => '/uploads/tx_aimeos',
	31	+ 'basedir' => $publicPath . '/uploads/tx_aimeos',
	32	+ 'tempdir' => $publicPath . '/typo3temp',
	33	+ ],
	34	+ 'fs-mimeicon' => [
	35	+ 'adapter' => 'Standard',
	36	+ 'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
	37	+ 'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
	38	+ 'tempdir' => $publicPath . '/typo3temp',
	39	+ ],
	40	+ 'fs-theme' => [
	41	+ 'adapter' => 'Standard',
	42	+ 'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Themes',
	43	+ 'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Themes',
	44	+ 'tempdir' => $publicPath . '/typo3temp',
	45	+ ],
	46	+ 'fs-admin' => [
	47	+ 'adapter' => 'Standard',
	48	+ 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/admin',
	49	+ 'tempdir' => $publicPath . '/typo3temp',
	50	+ ],
	51	+ 'fs-export' => [
	52	+ 'adapter' => 'Standard',
	53	+ 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/export',
	54	+ 'tempdir' => $publicPath . '/typo3temp',
	55	+ ],
	56	+ 'fs-import' => [
	57	+ 'adapter' => 'Standard',
	58	+ 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/import',
	59	+ 'tempdir' => $publicPath . '/typo3temp',
	60	+ ],
	61	+ 'fs-secure' => [
	62	+ 'adapter' => 'Standard',
	63	+ 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure',
	64	+ 'tempdir' => $publicPath . '/typo3temp',
	65	+ ],
	66	+ 'mq' => [
	67	+ 'adapter' => 'Standard',
	68	+ 'db' => 'db',
	69	+ ],
70	70	];

		@@ -5,7 +5,7 @@
		block discarded – undo
5	5
6	6	return [
7	7	'db' => [
8		- 'adapter' => ($defaultConnection['driver'] ?? 'mysql') !== 'mysqli' ?: 'mysql',
	8	+ 'adapter' => ( $defaultConnection['driver'] ?? 'mysql' ) !== 'mysqli' ?: 'mysql',
9	9	'host' => $defaultConnection['host'] ?? null,
10	10	'port' => $defaultConnection['port'] ?? null,
11	11	'socket' => $defaultConnection['socket'] ?? null,

aimeos / aimeos-typo3

Push — master ( d4d3fd...3c1709 )

Status

Category

Indentation +63 added lines, -63 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch