Inspection of "Improved error handling" - aimeos/aimeos-typo3 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6cc8e0...ee48d8 )

by Aimeos

created 2023-03-22 11:31 UTC

Status

Indentation +72 added lines, -72 removed lines patch added patch discarded remove patch

@@ -5,82 +5,82 @@
 block discarded – undo
 $driver = $defaultConnection['driver'] ?? null;
 
 switch($driver) {
-	case 'mysqli':
-	case 'pdo_mysql': $adapter = 'mysql'; break;
-	case 'pdo_oci': $adapter = 'oracle'; break;
-	case 'pdo_pgsql': $adapter = 'pgsql'; break;
-	case 'pdo_sqlite': $adapter = 'sqlite'; break;
-	case 'pdo_sqlsrv': $adapter = 'sqlsrv'; break;
-	default: $adapter = $driver;
+    case 'mysqli':
+    case 'pdo_mysql': $adapter = 'mysql'; break;
+    case 'pdo_oci': $adapter = 'oracle'; break;
+    case 'pdo_pgsql': $adapter = 'pgsql'; break;
+    case 'pdo_sqlite': $adapter = 'sqlite'; break;
+    case 'pdo_sqlsrv': $adapter = 'sqlsrv'; break;
+    default: $adapter = $driver;
 }
 
 switch($adapter) {
-	case 'mysql': $stmt = ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"]; break;
-	default: $stmt = [];
+    case 'mysql': $stmt = ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"]; break;
+    default: $stmt = [];
 }
 
 return [
-	'db' => [
-		'adapter' => $adapter,
-		'host' => $defaultConnection['host'] ?? null,
-		'port' => $defaultConnection['port'] ?? null,
-		'socket' => $defaultConnection['socket'] ?? null,
-		'database' => $defaultConnection['dbname'] ?? null,
-		'username' => $defaultConnection['user'] ?? null,
-		'password' => $defaultConnection['password'] ?? null,
-		'stmt' => $stmt,
-		'defaultTableOptions' => [
-			'charset' => $defaultConnection['tableoptions']['charset'] ?? 'utf8',
-			'collate' => $defaultConnection['tableoptions']['collate'] ?? 'utf8_unicode_ci',
-		],
-		'limit' => 3,
-	],
-	'fs' => [
-		'adapter' => 'Standard',
-		'baseurl' => '/uploads/tx_aimeos',
-		'basedir' => $publicPath . '/uploads/tx_aimeos',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-media' => [
-		'adapter' => 'Standard',
-		'baseurl' => '/uploads/tx_aimeos',
-		'basedir' => $publicPath . '/uploads/tx_aimeos',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-mimeicon' => [
-		'adapter' => 'Standard',
-		'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
-		'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-theme' => [
-		'adapter' => 'Standard',
-		'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Themes',
-		'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Themes',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-admin' => [
-		'adapter' => 'Standard',
-		'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/admin',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-export' => [
-		'adapter' => 'Standard',
-		'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/export',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-import' => [
-		'adapter' => 'Standard',
-		'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/import',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'fs-secure' => [
-		'adapter' => 'Standard',
-		'basedir' => $publicPath . '/uploads/tx_aimeos/.secure',
-		'tempdir' => $publicPath . '/typo3temp',
-	],
-	'mq' => [
-		'adapter' => 'Standard',
-		'db' => 'db',
-	],
+    'db' => [
+        'adapter' => $adapter,
+        'host' => $defaultConnection['host'] ?? null,
+        'port' => $defaultConnection['port'] ?? null,
+        'socket' => $defaultConnection['socket'] ?? null,
+        'database' => $defaultConnection['dbname'] ?? null,
+        'username' => $defaultConnection['user'] ?? null,
+        'password' => $defaultConnection['password'] ?? null,
+        'stmt' => $stmt,
+        'defaultTableOptions' => [
+            'charset' => $defaultConnection['tableoptions']['charset'] ?? 'utf8',
+            'collate' => $defaultConnection['tableoptions']['collate'] ?? 'utf8_unicode_ci',
+        ],
+        'limit' => 3,
+    ],
+    'fs' => [
+        'adapter' => 'Standard',
+        'baseurl' => '/uploads/tx_aimeos',
+        'basedir' => $publicPath . '/uploads/tx_aimeos',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-media' => [
+        'adapter' => 'Standard',
+        'baseurl' => '/uploads/tx_aimeos',
+        'basedir' => $publicPath . '/uploads/tx_aimeos',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-mimeicon' => [
+        'adapter' => 'Standard',
+        'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
+        'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-theme' => [
+        'adapter' => 'Standard',
+        'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Themes',
+        'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Themes',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-admin' => [
+        'adapter' => 'Standard',
+        'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/admin',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-export' => [
+        'adapter' => 'Standard',
+        'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/export',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-import' => [
+        'adapter' => 'Standard',
+        'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/import',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'fs-secure' => [
+        'adapter' => 'Standard',
+        'basedir' => $publicPath . '/uploads/tx_aimeos/.secure',
+        'tempdir' => $publicPath . '/typo3temp',
+    ],
+    'mq' => [
+        'adapter' => 'Standard',
+        'db' => 'db',
+    ],
 ];

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -4,7 +4,7 @@  discard block
 block discarded – undo
 $defaultConnection = $GLOBALS['TYPO3_CONF_VARS']['DB']['Connections']['Default'] ?? [];
 $driver = $defaultConnection['driver'] ?? null;
 
-switch($driver) {
+switch( $driver ) {
 	case 'mysqli':
 	case 'pdo_mysql': $adapter = 'mysql'; break;
 	case 'pdo_oci': $adapter = 'oracle'; break;
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
 	default: $adapter = $driver;
 }
 
-switch($adapter) {
+switch( $adapter ) {
 	case 'mysql': $stmt = ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"]; break;
 	default: $stmt = [];
 }

Please login to merge, or discard this patch.

Braces +4 added lines, -2 removed lines patch added patch discarded remove patch

@@ -4,7 +4,8 @@  discard block
 block discarded – undo
 $defaultConnection = $GLOBALS['TYPO3_CONF_VARS']['DB']['Connections']['Default'] ?? [];
 $driver = $defaultConnection['driver'] ?? null;
 
-switch($driver) {
+switch($driver)
+{
 	case 'mysqli':
 	case 'pdo_mysql': $adapter = 'mysql'; break;
 	case 'pdo_oci': $adapter = 'oracle'; break;
@@ -14,7 +15,8 @@  discard block
 block discarded – undo
 	default: $adapter = $driver;
 }
 
-switch($adapter) {
+switch($adapter)
+{
 	case 'mysql': $stmt = ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"]; break;
 	default: $stmt = [];
 }

Please login to merge, or discard this patch.

		@@ -5,82 +5,82 @@
		block discarded – undo
5	5	$driver = $defaultConnection['driver'] ?? null;
6	6
7	7	switch($driver) {
8		- case 'mysqli':
9		- case 'pdo_mysql': $adapter = 'mysql'; break;
10		- case 'pdo_oci': $adapter = 'oracle'; break;
11		- case 'pdo_pgsql': $adapter = 'pgsql'; break;
12		- case 'pdo_sqlite': $adapter = 'sqlite'; break;
13		- case 'pdo_sqlsrv': $adapter = 'sqlsrv'; break;
14		- default: $adapter = $driver;
	8	+ case 'mysqli':
	9	+ case 'pdo_mysql': $adapter = 'mysql'; break;
	10	+ case 'pdo_oci': $adapter = 'oracle'; break;
	11	+ case 'pdo_pgsql': $adapter = 'pgsql'; break;
	12	+ case 'pdo_sqlite': $adapter = 'sqlite'; break;
	13	+ case 'pdo_sqlsrv': $adapter = 'sqlsrv'; break;
	14	+ default: $adapter = $driver;
15	15	}
16	16
17	17	switch($adapter) {
18		- case 'mysql': $stmt = ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"]; break;
19		- default: $stmt = [];
	18	+ case 'mysql': $stmt = ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"]; break;
	19	+ default: $stmt = [];
20	20	}
21	21
22	22	return [
23		- 'db' => [
24		- 'adapter' => $adapter,
25		- 'host' => $defaultConnection['host'] ?? null,
26		- 'port' => $defaultConnection['port'] ?? null,
27		- 'socket' => $defaultConnection['socket'] ?? null,
28		- 'database' => $defaultConnection['dbname'] ?? null,
29		- 'username' => $defaultConnection['user'] ?? null,
30		- 'password' => $defaultConnection['password'] ?? null,
31		- 'stmt' => $stmt,
32		- 'defaultTableOptions' => [
33		- 'charset' => $defaultConnection['tableoptions']['charset'] ?? 'utf8',
34		- 'collate' => $defaultConnection['tableoptions']['collate'] ?? 'utf8_unicode_ci',
35		- ],
36		- 'limit' => 3,
37		- ],
38		- 'fs' => [
39		- 'adapter' => 'Standard',
40		- 'baseurl' => '/uploads/tx_aimeos',
41		- 'basedir' => $publicPath . '/uploads/tx_aimeos',
42		- 'tempdir' => $publicPath . '/typo3temp',
43		- ],
44		- 'fs-media' => [
45		- 'adapter' => 'Standard',
46		- 'baseurl' => '/uploads/tx_aimeos',
47		- 'basedir' => $publicPath . '/uploads/tx_aimeos',
48		- 'tempdir' => $publicPath . '/typo3temp',
49		- ],
50		- 'fs-mimeicon' => [
51		- 'adapter' => 'Standard',
52		- 'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
53		- 'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
54		- 'tempdir' => $publicPath . '/typo3temp',
55		- ],
56		- 'fs-theme' => [
57		- 'adapter' => 'Standard',
58		- 'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Themes',
59		- 'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Themes',
60		- 'tempdir' => $publicPath . '/typo3temp',
61		- ],
62		- 'fs-admin' => [
63		- 'adapter' => 'Standard',
64		- 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/admin',
65		- 'tempdir' => $publicPath . '/typo3temp',
66		- ],
67		- 'fs-export' => [
68		- 'adapter' => 'Standard',
69		- 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/export',
70		- 'tempdir' => $publicPath . '/typo3temp',
71		- ],
72		- 'fs-import' => [
73		- 'adapter' => 'Standard',
74		- 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/import',
75		- 'tempdir' => $publicPath . '/typo3temp',
76		- ],
77		- 'fs-secure' => [
78		- 'adapter' => 'Standard',
79		- 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure',
80		- 'tempdir' => $publicPath . '/typo3temp',
81		- ],
82		- 'mq' => [
83		- 'adapter' => 'Standard',
84		- 'db' => 'db',
85		- ],
	23	+ 'db' => [
	24	+ 'adapter' => $adapter,
	25	+ 'host' => $defaultConnection['host'] ?? null,
	26	+ 'port' => $defaultConnection['port'] ?? null,
	27	+ 'socket' => $defaultConnection['socket'] ?? null,
	28	+ 'database' => $defaultConnection['dbname'] ?? null,
	29	+ 'username' => $defaultConnection['user'] ?? null,
	30	+ 'password' => $defaultConnection['password'] ?? null,
	31	+ 'stmt' => $stmt,
	32	+ 'defaultTableOptions' => [
	33	+ 'charset' => $defaultConnection['tableoptions']['charset'] ?? 'utf8',
	34	+ 'collate' => $defaultConnection['tableoptions']['collate'] ?? 'utf8_unicode_ci',
	35	+ ],
	36	+ 'limit' => 3,
	37	+ ],
	38	+ 'fs' => [
	39	+ 'adapter' => 'Standard',
	40	+ 'baseurl' => '/uploads/tx_aimeos',
	41	+ 'basedir' => $publicPath . '/uploads/tx_aimeos',
	42	+ 'tempdir' => $publicPath . '/typo3temp',
	43	+ ],
	44	+ 'fs-media' => [
	45	+ 'adapter' => 'Standard',
	46	+ 'baseurl' => '/uploads/tx_aimeos',
	47	+ 'basedir' => $publicPath . '/uploads/tx_aimeos',
	48	+ 'tempdir' => $publicPath . '/typo3temp',
	49	+ ],
	50	+ 'fs-mimeicon' => [
	51	+ 'adapter' => 'Standard',
	52	+ 'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
	53	+ 'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Images/Mimeicons',
	54	+ 'tempdir' => $publicPath . '/typo3temp',
	55	+ ],
	56	+ 'fs-theme' => [
	57	+ 'adapter' => 'Standard',
	58	+ 'baseurl' => '/typo3conf/ext/aimeos/Resources/Public/Themes',
	59	+ 'basedir' => $publicPath . '/typo3conf/ext/aimeos/Resources/Public/Themes',
	60	+ 'tempdir' => $publicPath . '/typo3temp',
	61	+ ],
	62	+ 'fs-admin' => [
	63	+ 'adapter' => 'Standard',
	64	+ 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/admin',
	65	+ 'tempdir' => $publicPath . '/typo3temp',
	66	+ ],
	67	+ 'fs-export' => [
	68	+ 'adapter' => 'Standard',
	69	+ 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/export',
	70	+ 'tempdir' => $publicPath . '/typo3temp',
	71	+ ],
	72	+ 'fs-import' => [
	73	+ 'adapter' => 'Standard',
	74	+ 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure/import',
	75	+ 'tempdir' => $publicPath . '/typo3temp',
	76	+ ],
	77	+ 'fs-secure' => [
	78	+ 'adapter' => 'Standard',
	79	+ 'basedir' => $publicPath . '/uploads/tx_aimeos/.secure',
	80	+ 'tempdir' => $publicPath . '/typo3temp',
	81	+ ],
	82	+ 'mq' => [
	83	+ 'adapter' => 'Standard',
	84	+ 'db' => 'db',
	85	+ ],
86	86	];

		@@ -4,7 +4,7 @@ discard block
		block discarded – undo
4	4	$defaultConnection = $GLOBALS['TYPO3_CONF_VARS']['DB']['Connections']['Default'] ?? [];
5	5	$driver = $defaultConnection['driver'] ?? null;
6	6
7		-switch($driver) {
	7	+switch( $driver ) {
8	8	case 'mysqli':
9	9	case 'pdo_mysql': $adapter = 'mysql'; break;
10	10	case 'pdo_oci': $adapter = 'oracle'; break;
		@@ -14,7 +14,7 @@ discard block
		block discarded – undo
14	14	default: $adapter = $driver;
15	15	}
16	16
17		-switch($adapter) {
	17	+switch( $adapter ) {
18	18	case 'mysql': $stmt = ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"]; break;
19	19	default: $stmt = [];
20	20	}

		@@ -4,7 +4,8 @@ discard block
		block discarded – undo
4	4	$defaultConnection = $GLOBALS['TYPO3_CONF_VARS']['DB']['Connections']['Default'] ?? [];
5	5	$driver = $defaultConnection['driver'] ?? null;
6	6
7		-switch($driver) {
	7	+switch($driver)
	8	+{
8	9	case 'mysqli':
9	10	case 'pdo_mysql': $adapter = 'mysql'; break;
10	11	case 'pdo_oci': $adapter = 'oracle'; break;
		@@ -14,7 +15,8 @@ discard block
		block discarded – undo
14	15	default: $adapter = $driver;
15	16	}
16	17
17		-switch($adapter) {
	18	+switch($adapter)
	19	+{
18	20	case 'mysql': $stmt = ["SET SESSION sort_buffer_size=2097144; SET NAMES 'utf8'; SET SESSION sql_mode='ANSI'; SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED"]; break;
19	21	default: $stmt = [];
20	22	}

aimeos / aimeos-typo3

Push — master ( 6cc8e0...ee48d8 )

Status

Category

Indentation +72 added lines, -72 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +4 added lines, -2 removed lines patch added patch discarded remove patch