Passed
Push — master ( 484f92...9dd3d0 )
by Aimeos
04:56
created
lib/mshoplib/setup/unitperf/CatalogAddPerfData.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -76,8 +76,8 @@  discard block
 block discarded – undo
76 76
 
77 77
 			if( $level > 0 )
78 78
 			{
79
-				for( $i = 0; $i < $numCatPerLevel; $i++ ){
80
-					$treeFcn( $parents, $catItem->getId(), $numCatPerLevel, $level - 1, $catLabel . '-' . ($i+1), $i );
79
+				for( $i = 0; $i < $numCatPerLevel; $i++ ) {
80
+					$treeFcn( $parents, $catItem->getId(), $numCatPerLevel, $level - 1, $catLabel . '-' . ( $i + 1 ), $i );
81 81
 				}
82 82
 			}
83 83
 			else
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 		}
118 118
 
119 119
 		for( $i = $begin; $i < $end; $i++ ) {
120
-			$treeFcn( [$catRootItem], $catRootItem->getId(), $numCatPerLevel, $this->numCatLevels - 1, $i+1, $i );
120
+			$treeFcn( [$catRootItem], $catRootItem->getId(), $numCatPerLevel, $this->numCatLevels - 1, $i + 1, $i );
121 121
 		}
122 122
 
123 123
 		$this->additional->getProcess()->wait();
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 			{
164 164
 				if( $item->pos % $fraction === 0 )
165 165
 				{
166
-					$litem = (clone $defListItem)->setRefId( $item->getId() )->setPosition( $start + round( $item->pos / $fraction ) );
166
+					$litem = ( clone $defListItem )->setRefId( $item->getId() )->setPosition( $start + round( $item->pos / $fraction ) );
167 167
 					$catItem->addListItem( 'product', $litem );
168 168
 				}
169 169
 			}
@@ -199,13 +199,13 @@  discard block
 block discarded – undo
199 199
 		$listItem = $productListManager->createItem()->setType( 'default' );
200 200
 
201 201
 		foreach( $attrIds as $attrId ) {
202
-			$prodItem->addListItem( 'attribute', (clone $listItem)->setRefId( $attrId ) );
202
+			$prodItem->addListItem( 'attribute', ( clone $listItem )->setRefId( $attrId ) );
203 203
 		}
204 204
 
205 205
 		$listItem = $productListManager->createItem()->setType( 'config' );
206 206
 
207 207
 		foreach( $this->attributes['sticker'] as $attrId => $label ) {
208
-			$prodItem->addListItem( 'attribute', (clone $listItem)->setRefId( $attrId ) );
208
+			$prodItem->addListItem( 'attribute', ( clone $listItem )->setRefId( $attrId ) );
209 209
 		}
210 210
 
211 211
 		return $prodItem;
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
 		{
245 245
 			$text = current( $color ) . ' ' . current( $property ) . ' ' . current( $material ) . ' ' . current( $articles );
246 246
 
247
-			$item = (clone $newItem)
247
+			$item = ( clone $newItem )
248 248
 				->setLabel( $text . ' (' . $catLabel . ')' )
249 249
 				->setCode( 'p-' . $i . ':' . $catLabel )
250 250
 				->setStatus( 1 );
@@ -308,18 +308,18 @@  discard block
 block discarded – undo
308 308
 
309 309
 		foreach( array_values( $this->shuffle( range( 0, 3 ) ) ) as $pos => $i )
310 310
 		{
311
-			$num = (($idx + $i) % 4) + 1;
312
-			$mediaItem = (clone $newItem)
313
-				->setLabel( ($pos+1) . '. picture for ' . $prodItem->getLabel() )
311
+			$num = ( ( $idx + $i ) % 4 ) + 1;
312
+			$mediaItem = ( clone $newItem )
313
+				->setLabel( ( $pos + 1 ) . '. picture for ' . $prodItem->getLabel() )
314 314
 				->setPreviews( [1 => $prefix . 'unitperf/' . $num . '.jpg'] )
315 315
 				->setUrl( $prefix . 'unitperf/' . $num . '-big.jpg' )
316 316
 				->setMimeType( 'image/jpeg' )
317 317
 				->setStatus( 1 );
318 318
 
319
-			$prodItem->addListItem( 'media', (clone $litem)->setPosition( $pos ), $mediaItem );
319
+			$prodItem->addListItem( 'media', ( clone $litem )->setPosition( $pos ), $mediaItem );
320 320
 		}
321 321
 
322
-		$mediaItem = (clone $newItem)
322
+		$mediaItem = ( clone $newItem )
323 323
 			->setPreviews( [1 => $prefix . 'unitperf/download-preview.jpg'] )
324 324
 			->setUrl( $prefix . 'unitperf/download.pdf' )
325 325
 			->setMimeType( 'application/pdf' )
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 
329 329
 		$litem = $productListManager->createItem()->setType( 'download' );
330 330
 
331
-		return $prodItem->addListItem( 'media', (clone $litem), $mediaItem );
331
+		return $prodItem->addListItem( 'media', ( clone $litem ), $mediaItem );
332 332
 	}
333 333
 
334 334
 
@@ -343,15 +343,15 @@  discard block
 block discarded – undo
343 343
 
344 344
 		for( $i = 0; $i < 3; $i++ )
345 345
 		{
346
-			$priceItem = (clone $newItem)
346
+			$priceItem = ( clone $newItem )
347 347
 				->setLabel( $prodItem->getLabel() . ': from ' . ( 1 + $i * 5 ) )
348
-				->setValue( 100 + (( $base + $idx ) % 900) - $i * 10 )
348
+				->setValue( 100 + ( ( $base + $idx ) % 900 ) - $i * 10 )
349 349
 				->setQuantity( 1 + $i * 10 )
350 350
 				->setCurrencyId( 'EUR' )
351 351
 				->setRebate( $i * 10 )
352 352
 				->setStatus( 1 );
353 353
 
354
-			$prodItem->addListItem( 'price', (clone $litem)->setPosition( $i ), $priceItem );
354
+			$prodItem->addListItem( 'price', ( clone $litem )->setPosition( $i ), $priceItem );
355 355
 		}
356 356
 
357 357
 		return $prodItem;
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
 			{
373 373
 				if( !in_array( $litem->getRefId(), $ids ) )
374 374
 				{
375
-					$prodItem->addListItem( 'product', (clone $listItem)->setRefId( $litem->getRefId() ) );
375
+					$prodItem->addListItem( 'product', ( clone $listItem )->setRefId( $litem->getRefId() ) );
376 376
 					$ids[] = $litem->getRefId();
377 377
 					$num--;
378 378
 				}
@@ -397,7 +397,7 @@  discard block
 block discarded – undo
397 397
 			->setType( 'url' )
398 398
 			->setStatus( 1 );
399 399
 
400
-		$prodItem->addListItem( 'text', (clone $listItem), $textItem );
400
+		$prodItem->addListItem( 'text', ( clone $listItem ), $textItem );
401 401
 
402 402
 		$textItem = $textManager->createItem()
403 403
 			->setLanguageId( 'en' )
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 			->setType( 'name' )
407 407
 			->setStatus( 1 );
408 408
 
409
-		$prodItem->addListItem( 'text', (clone $listItem)->setPosition( 0 ), $textItem );
409
+		$prodItem->addListItem( 'text', ( clone $listItem )->setPosition( 0 ), $textItem );
410 410
 
411 411
 		$textItem = $textManager->createItem()
412 412
 			->setContent( 'Short description for ' . $label )
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 			->setType( 'short' )
416 416
 			->setStatus( 1 );
417 417
 
418
-		$prodItem->addListItem( 'text', (clone $listItem)->setPosition( 1 ), $textItem );
418
+		$prodItem->addListItem( 'text', ( clone $listItem )->setPosition( 1 ), $textItem );
419 419
 
420 420
 		$textItem = $textManager->createItem()
421 421
 			->setContent( 'Long description for ' . $label . '. This may include some "lorem ipsum" text' )
@@ -424,7 +424,7 @@  discard block
 block discarded – undo
424 424
 			->setType( 'long' )
425 425
 			->setStatus( 1 );
426 426
 
427
-		$prodItem->addListItem( 'text', (clone $listItem)->setPosition( 2 ), $textItem );
427
+		$prodItem->addListItem( 'text', ( clone $listItem )->setPosition( 2 ), $textItem );
428 428
 
429 429
 		return $prodItem;
430 430
 	}
@@ -447,14 +447,14 @@  discard block
 block discarded – undo
447 447
 		{
448 448
 			$text = current( $length ) . ', ' . current( $width ) . ', ' . $prodItem->getLabel() . ' (' . current( $size ) . ')';
449 449
 
450
-			$item = (clone $newItem)
450
+			$item = ( clone $newItem )
451 451
 				->setCode( 'v-' . $idx . '/' . $i . ':' . $prodItem->getCode() )
452 452
 				->setLabel( $text )
453 453
 				->setStatus( 1 );
454 454
 
455
-			$item->addListItem( 'attribute', (clone $varListItem)->setRefId( key( $length ) ) );
456
-			$item->addListItem( 'attribute', (clone $varListItem)->setRefId( key( $width ) ) );
457
-			$item->addListItem( 'attribute', (clone $varListItem)->setRefId( key( $size ) ) );
455
+			$item->addListItem( 'attribute', ( clone $varListItem )->setRefId( key( $length ) ) );
456
+			$item->addListItem( 'attribute', ( clone $varListItem )->setRefId( key( $width ) ) );
457
+			$item->addListItem( 'attribute', ( clone $varListItem )->setRefId( key( $size ) ) );
458 458
 
459 459
 			$prodItem->addListItem( 'product', clone $defListItem, $item );
460 460
 
Please login to merge, or discard this patch.
controller/common/src/Controller/Common/Media/Standard.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
 					$fs->rm( $preview );
148 148
 				}
149 149
 			}
150
-			catch( \Exception $e ) { ; } // Can be a mime icon with relative path
150
+			catch( \Exception $e ) {; } // Can be a mime icon with relative path
151 151
 		}
152 152
 
153 153
 		return $item->setUrl( '' )->setPreviews( [] )->deletePropertyItems( $item->getPropertyItems() );
Please login to merge, or discard this patch.
Braces   +10 added lines, -5 removed lines patch added patch discarded remove patch
@@ -53,8 +53,7 @@  discard block
 block discarded – undo
53 53
 		if( $media instanceof \Aimeos\MW\Media\Image\Iface )
54 54
 		{
55 55
 			$item = $this->addImages( $item, $media, md5( $file->getClientFilename() ), $fsname );
56
-		}
57
-		else
56
+		} else
58 57
 		{
59 58
 			$mimetype = $media->getMimeType();
60 59
 			$filepath = $this->getFilePath( $file->getClientFilename(), 'files', $mimetype );
@@ -106,7 +105,9 @@  discard block
 block discarded – undo
106 105
 					$fs->copy( $preview, $newPath );
107 106
 					$previews[$size] = $newPath;
108 107
 				}
109
-				catch( \Aimeos\MW\Filesystem\Exception $e ) {} // mime icons can't be copied
108
+				catch( \Aimeos\MW\Filesystem\Exception $e )
109
+				{
110
+} // mime icons can't be copied
110 111
 			}
111 112
 		}
112 113
 
@@ -147,7 +148,9 @@  discard block
 block discarded – undo
147 148
 					$fs->rm( $preview );
148 149
 				}
149 150
 			}
150
-			catch( \Exception $e ) { ; } // Can be a mime icon with relative path
151
+			catch( \Exception $e )
152
+			{
153
+; } // Can be a mime icon with relative path
151 154
 		}
152 155
 
153 156
 		return $item->setUrl( '' )->setPreviews( [] )->deletePropertyItems( $item->getPropertyItems() );
@@ -665,7 +668,9 @@  discard block
 block discarded – undo
665 668
 				$fs->rm( $oldpath );
666 669
 			}
667 670
 		}
668
-		catch( \Aimeos\MW\Filesystem\Exception $e ) {} // continue if removing file fails
671
+		catch( \Aimeos\MW\Filesystem\Exception $e )
672
+		{
673
+} // continue if removing file fails
669 674
 
670 675
 		$fs->write( $filepath, $content );
671 676
 	}
Please login to merge, or discard this patch.