aimeos / aimeos-core

lib/mshoplib/src/MShop/Customer/Manager/Property/Type/Standard.php

Spacing +1 added lines, -1 removed lines

@@ -285,7 +285,7 @@
 		 * @see mshop/customer/manager/property/type/decorators/global
 		 */
 
-		return $this->getSubManagerBase( 'customer', 'property/type/' . $manager, $name );
+		return $this->getSubManagerBase( 'customer', 'property/type/'.$manager, $name );
 	}
 
 

lib/mshoplib/src/MShop/Customer/Manager/Property/Standard.php

Spacing +1 added lines, -1 removed lines

@@ -288,7 +288,7 @@
 		 * @see mshop/customer/manager/property/decorators/global
 		 */
 
-		return $this->getSubManagerBase( 'customer', 'property/' . $manager, $name );
+		return $this->getSubManagerBase( 'customer', 'property/'.$manager, $name );
 	}
 
 

lib/mshoplib/tests/MShop/Customer/Manager/Property/StandardTest.php

Spacing +13 added lines, -13 removed lines

@@ -54,11 +54,11 @@ 
 		$search->setConditions( $search->compare( '==', 'customer.property.editor', $this->editor ) );
 		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No property item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setLanguageId( 'en' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -109,13 +109,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$conditions = array(
-			$search->compare( '~=', 'customer.property.value', '1'),
+			$search->compare( '~=', 'customer.property.value', '1' ),
 			$search->compare( '==', 'customer.property.editor', $this->editor )
 		);
 		$search->setConditions( $search->combine( '&&', $conditions ) );
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results)) === false ) {
+		if( ( $expected = reset( $results ) ) === false ) {
 			throw new \RuntimeException( sprintf( 'No customer property item found for value "%1$s".', '1' ) );
 		}
 
@@ -166,7 +166,7 @@ 
 		$expr[] = $search->compare( '>=', 'customer.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'customer.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
@@ -177,13 +177,13 @@ 
 			$search->compare( '==', 'customer.property.editor', $this->editor )
 		);
 		$search->setConditions( $search->combine( '&&', $conditions ) );
-		$search->setSlice(0, 1);
+		$search->setSlice( 0, 1 );
 		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 1, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -191,17 +191,17 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type') );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type', 'Standard') );
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type' ) );
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type', 'Standard' ) );
 
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 
 
 	public function testGetSubManagerInvalidName()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('type', 'unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'type', 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Customer/Manager/Property/Type/StandardTest.php

Spacing +14 added lines, -14 removed lines

@@ -19,13 +19,13 @@ 
 	{
 		$this->editor = \TestHelperMShop::getContext()->getEditor();
 		$manager = \Aimeos\MShop\Customer\Manager\Factory::createManager( \TestHelperMShop::getContext() );
-		$this->object = $manager->getSubManager( 'property' )->getSubManager('type');
+		$this->object = $manager->getSubManager( 'property' )->getSubManager( 'type' );
 	}
 
 
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
@@ -68,7 +68,7 @@ 
 
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results) ) === false )
+		if( ( $expected = reset( $results ) ) === false )
 		{
 			throw new \RuntimeException( 'No property type item found.' );
 		}
@@ -90,13 +90,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$search->setConditions( $search->compare( '==', 'customer.property.type.editor', $this->editor ) );
-		$results = $this->object->searchItems($search);
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -156,24 +156,24 @@ 
 		$expr[] = $search->compare( '>=', 'customer.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'customer.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
 
 		$search = $this->object->createSearch();
 		$conditions = array(
-			$search->compare( '=~', 'customer.property.type.code', 'newsletter'),
+			$search->compare( '=~', 'customer.property.type.code', 'newsletter' ),
 			$search->compare( '==', 'customer.property.type.editor', $this->editor )
 		);
-		$search->setConditions( $search->combine('&&', $conditions ) );
-		$search->setSlice(0, 1);
-		$items = $this->object->searchItems( $search, [], $total);
+		$search->setConditions( $search->combine( '&&', $conditions ) );
+		$search->setSlice( 0, 1 );
+		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 1, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -181,7 +181,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }

lib/mshoplib/setup/unittest/data/customer-property.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
  * @copyright Aimeos (aimeos.org), 2018
  */
 
-return array (
+return array(
 	'customer/property/type' => array(
 		'customer/property/type/newsletter' => array( 'domain' => 'customer', 'code' => 'newsletter', 'label' => 'Newsletter', 'status' => 1 ),
 	),

lib/mshoplib/setup/unittest/CustomerAddPropertyTestData.php

Spacing +6 added lines, -6 removed lines

@@ -51,7 +51,7 @@ 
 		$this->additional->setEditor( 'core:unittest' );
 
 		$ds = DIRECTORY_SEPARATOR;
-		$path = __DIR__ . $ds . 'data' . $ds . 'customer-property.php';
+		$path = __DIR__.$ds.'data'.$ds.'customer-property.php';
 
 		if( ( $testdata = include( $path ) ) == false ) {
 			throw new \Aimeos\MShop\Exception( sprintf( 'No file "%1$s" found for customer domain', $path ) );
@@ -89,19 +89,19 @@ 
 			$type->setStatus( $dataset['status'] );
 
 			$customerPropertyTypeManager->saveItem( $type );
-			$typeIds[ $key ] = $type->getId();
+			$typeIds[$key] = $type->getId();
 		}
 
 		$custProperty = $customerPropertyManager->createItem();
 		foreach( $testdata['customer/property'] as $key => $dataset )
 		{
-			if( !isset( $typeIds[ $dataset['typeid'] ] ) ) {
+			if( !isset( $typeIds[$dataset['typeid']] ) ) {
 				throw new \Aimeos\MW\Setup\Exception( sprintf( 'No customer property type ID found for "%1$s"', $dataset['typeid'] ) );
 			}
 
 			$custProperty->setId( null );
-			$custProperty->setParentId( $custIds[ $dataset['parentid'] ] );
-			$custProperty->setTypeId( $typeIds[ $dataset['typeid'] ] );
+			$custProperty->setParentId( $custIds[$dataset['parentid']] );
+			$custProperty->setTypeId( $typeIds[$dataset['typeid']] );
 			$custProperty->setLanguageId( $dataset['langid'] );
 			$custProperty->setValue( $dataset['value'] );
 
@@ -124,7 +124,7 @@ 
 		$search = $customerManager->createSearch();
 
 		foreach( $customerManager->searchItems( $search ) as $id => $item ) {
-			$entry[ 'customer/' . $item->getCode() ] = $id;
+			$entry['customer/'.$item->getCode()] = $id;
 		}
 
 		return $entry;

lib/mshoplib/setup/default/schema/customer.php

Spacing +9 added lines, -9 removed lines

@@ -8,7 +8,7 @@ 
 
 return array(
 	'table' => array(
-		'mshop_customer' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_customer' );
 
@@ -42,7 +42,7 @@ 
 			$table->addColumn( 'status', 'smallint', [] );
 			$table->addColumn( 'mtime', 'datetime', [] );
 			$table->addColumn( 'ctime', 'datetime', [] );
-			$table->addColumn( 'editor', 'string', array('length' => 255 ) );
+			$table->addColumn( 'editor', 'string', array( 'length' => 255 ) );
 
 			$table->setPrimaryKey( array( 'id' ), 'pk_mscus_id' );
 			$table->addUniqueIndex( array( 'siteid', 'code' ), 'unq_mscus_sid_code' );
@@ -56,7 +56,7 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_address' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_address' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_customer_address' );
 
@@ -87,7 +87,7 @@ 
 			$table->addColumn( 'pos', 'smallint', [] );
 			$table->addColumn( 'mtime', 'datetime', [] );
 			$table->addColumn( 'ctime', 'datetime', [] );
-			$table->addColumn( 'editor', 'string', array('length' => 255 ) );
+			$table->addColumn( 'editor', 'string', array( 'length' => 255 ) );
 
 			$table->setPrimaryKey( array( 'id' ), 'pk_mscusad_id' );
 			$table->addIndex( array( 'parentid' ), 'fk_mscusad_pid' );
@@ -104,7 +104,7 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_list_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_list_type' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_customer_list_type' );
 
@@ -127,7 +127,7 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_list' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_list' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_customer_list' );
 
@@ -165,7 +165,7 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_group' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_group' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_customer_group' );
 
@@ -184,7 +184,7 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_property_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_property_type' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_customer_property_type' );
 
@@ -207,7 +207,7 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_property' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_property' => function( \Doctrine\DBAL\Schema\Schema $schema ) {
 
 			$table = $schema->createTable( 'mshop_customer_property' );
 

Braces +14 added lines, -7 removed lines

@@ -8,7 +8,8 @@ 
 
 return array(
 	'table' => array(
-		'mshop_customer' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_customer' );
 
@@ -56,7 +57,8 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_address' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_address' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_customer_address' );
 
@@ -104,7 +106,8 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_list_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_list_type' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_customer_list_type' );
 
@@ -127,7 +130,8 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_list' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_list' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_customer_list' );
 
@@ -165,7 +169,8 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_group' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_group' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_customer_group' );
 
@@ -184,7 +189,8 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_property_type' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_property_type' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_customer_property_type' );
 
@@ -207,7 +213,8 @@ 
 			return $schema;
 		},
 
-		'mshop_customer_property' => function ( \Doctrine\DBAL\Schema\Schema $schema ) {
+		'mshop_customer_property' => function ( \Doctrine\DBAL\Schema\Schema $schema )
+		{
 
 			$table = $schema->createTable( 'mshop_customer_property' );