aimeos / aimeos-core

lib/mshoplib/src/MShop/Common/Item/ListRef/Base.php

Doc Comments +4 added lines, -4 removed lines

@@ -50,7 +50,7 @@ 
 	 * @param string $domain Name of the domain (e.g. media, text, etc.)
 	 * @param \Aimeos\MShop\Common\Item\Lists\Iface $listItem List item referencing the new domain item
 	 * @param \Aimeos\MShop\Common\Item\Iface|null $refItem New item added to the given domain or null if no item should be referenced
-	 * @return \Aimeos\MShop\Common\Item\ListRef\Iface Self object for method chaining
+	 * @return Base Self object for method chaining
 	 */
 	public function addRefItem( $domain, \Aimeos\MShop\Common\Item\Lists\Iface $listItem, \Aimeos\MShop\Common\Item\Iface $refItem = null )
 	{
@@ -75,7 +75,7 @@ 
 	 * @param string $domain Name of the domain (e.g. media, text, etc.)
 	 * @param \Aimeos\MShop\Common\Item\Lists\Iface $listItem List item referencing the domain item
 	 * @param \Aimeos\MShop\Common\Item\Iface|null $refItem Existing item removed from the given domain or null if item shouldn't be removed
-	 * @return \Aimeos\MShop\Common\Item\ListRef\Iface Self object for method chaining
+	 * @return Base Self object for method chaining
 	 * @throws \Aimeos\MShop\Exception If given list item isn't found
 	 */
 	public function deleteRefItem( $domain, \Aimeos\MShop\Common\Item\Lists\Iface $listItem, \Aimeos\MShop\Common\Item\Iface $refItem = null )
@@ -192,9 +192,9 @@ 
 	 * to the requested domain to get the items. Otherwise, no items will be
 	 * returned by this method.
 	 *
-	 * @param array|string|null $domain Name/Names of the domain (e.g. product, text, etc.) or null for all
+	 * @param string $domain Name/Names of the domain (e.g. product, text, etc.) or null for all
 	 * @param array|string|null $type Name/Names of the item type or null for all
-	 * @param array|string|null $listtype Name/Names of the list item type or null for all
+	 * @param string $listtype Name/Names of the list item type or null for all
 	 * @param boolean $active True to return only active items, false to return all
 	 * @return array List of items implementing \Aimeos\MShop\Common\Item\Iface
 	 */

lib/mshoplib/tests/MShop/Supplier/Manager/Lists/Type/StandardTest.php

Spacing +12 added lines, -12 removed lines

@@ -53,10 +53,10 @@ 
 	public function testGetItem()
 	{
 		$search = $this->object->createSearch();
-		$search->setConditions( $search->compare( '==', 'supplier.lists.type.editor', $this->editor) );
-		$results = $this->object->searchItems($search);
+		$search->setConditions( $search->compare( '==', 'supplier.lists.type.editor', $this->editor ) );
+		$results = $this->object->searchItems( $search );
 
-		if( ( $expected = reset($results) ) === false ) {
+		if( ( $expected = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No attribute list type item found' );
 		}
 
@@ -74,14 +74,14 @@ 
 	public function testSaveUpdateDeleteItem()
 	{
 		$search = $this->object->createSearch();
-		$search->setConditions( $search->compare( '==', 'supplier.lists.type.editor', $this->editor) );
-		$results = $this->object->searchItems($search);
+		$search->setConditions( $search->compare( '==', 'supplier.lists.type.editor', $this->editor ) );
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -141,14 +141,14 @@ 
 		$expr[] = $search->compare( '>=', 'supplier.lists.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'supplier.lists.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$search->setSortations( [$search->sort( '-', 'supplier.lists.type.position' )] );
-		$search->setSlice(0, 1);
+		$search->setSlice( 0, 1 );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 		$this->assertEquals( 1, $total );
 
-		foreach($results as $itemId => $item) {
+		foreach( $results as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -156,7 +156,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Product/Manager/Property/Type/StandardTest.php

Spacing +14 added lines, -14 removed lines

@@ -19,13 +19,13 @@ 
 	{
 		$this->editor = \TestHelperMShop::getContext()->getEditor();
 		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperMShop::getContext() );
-		$this->object = $manager->getSubManager( 'property' )->getSubManager('type');
+		$this->object = $manager->getSubManager( 'property' )->getSubManager( 'type' );
 	}
 
 
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
@@ -68,7 +68,7 @@ 
 
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results) ) === false )
+		if( ( $expected = reset( $results ) ) === false )
 		{
 			throw new \RuntimeException( 'No property type item found.' );
 		}
@@ -90,13 +90,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$search->setConditions( $search->compare( '==', 'product.property.type.editor', $this->editor ) );
-		$results = $this->object->searchItems($search);
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -157,25 +157,25 @@ 
 		$expr[] = $search->compare( '>=', 'product.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'product.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
 
 		$search = $this->object->createSearch();
 		$conditions = array(
-			$search->compare( '=~', 'product.property.type.code', 'package-'),
+			$search->compare( '=~', 'product.property.type.code', 'package-' ),
 			$search->compare( '==', 'product.property.type.editor', $this->editor )
 		);
-		$search->setConditions( $search->combine('&&', $conditions ) );
+		$search->setConditions( $search->combine( '&&', $conditions ) );
 		$search->setSortations( [$search->sort( '-', 'product.property.type.position' )] );
-		$search->setSlice(0, 1);
-		$items = $this->object->searchItems( $search, [], $total);
+		$search->setSlice( 0, 1 );
+		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 4, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -183,7 +183,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Customer/Manager/Property/Type/StandardTest.php

Spacing +14 added lines, -14 removed lines

@@ -19,13 +19,13 @@ 
 	{
 		$this->editor = \TestHelperMShop::getContext()->getEditor();
 		$manager = \Aimeos\MShop\Customer\Manager\Factory::createManager( \TestHelperMShop::getContext() );
-		$this->object = $manager->getSubManager( 'property' )->getSubManager('type');
+		$this->object = $manager->getSubManager( 'property' )->getSubManager( 'type' );
 	}
 
 
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
@@ -68,7 +68,7 @@ 
 
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results) ) === false )
+		if( ( $expected = reset( $results ) ) === false )
 		{
 			throw new \RuntimeException( 'No property type item found.' );
 		}
@@ -90,13 +90,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$search->setConditions( $search->compare( '==', 'customer.property.type.editor', $this->editor ) );
-		$results = $this->object->searchItems($search);
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -157,25 +157,25 @@ 
 		$expr[] = $search->compare( '>=', 'customer.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'customer.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
 
 		$search = $this->object->createSearch();
 		$conditions = array(
-			$search->compare( '=~', 'customer.property.type.code', 'newsletter'),
+			$search->compare( '=~', 'customer.property.type.code', 'newsletter' ),
 			$search->compare( '==', 'customer.property.type.editor', $this->editor )
 		);
-		$search->setConditions( $search->combine('&&', $conditions ) );
+		$search->setConditions( $search->combine( '&&', $conditions ) );
 		$search->setSortations( [$search->sort( '-', 'customer.property.type.position' )] );
-		$search->setSlice(0, 1);
-		$items = $this->object->searchItems( $search, [], $total);
+		$search->setSlice( 0, 1 );
+		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 1, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -183,7 +183,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Attribute/Manager/Property/Type/StandardTest.php

Spacing +9 added lines, -9 removed lines

@@ -19,13 +19,13 @@ 
 	{
 		$this->editor = \TestHelperMShop::getContext()->getEditor();
 		$manager = \Aimeos\MShop\Attribute\Manager\Factory::createManager( \TestHelperMShop::getContext() );
-		$this->object = $manager->getSubManager( 'property' )->getSubManager('type');
+		$this->object = $manager->getSubManager( 'property' )->getSubManager( 'type' );
 	}
 
 
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
@@ -68,7 +68,7 @@ 
 
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results) ) === false )
+		if( ( $expected = reset( $results ) ) === false )
 		{
 			throw new \RuntimeException( 'No property type item found.' );
 		}
@@ -90,13 +90,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$search->setConditions( $search->compare( '==', 'attribute.property.type.editor', $this->editor ) );
-		$results = $this->object->searchItems($search);
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -173,7 +173,7 @@ 
 		$search->setConditions( $search->combine( '&&', $conditions ) );
 		$search->setSortations( [$search->sort( '-', 'attribute.property.type.position' )] );
 		$search->setSlice( 0, 2 );
-		$items = $this->object->searchItems( $search, [], $total);
+		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 2, count( $items ) );
 		$this->assertEquals( 3, $total );
@@ -189,7 +189,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Media/Manager/Property/Type/StandardTest.php

Spacing +13 added lines, -13 removed lines

@@ -19,13 +19,13 @@ 
 	{
 		$this->editor = \TestHelperMShop::getContext()->getEditor();
 		$manager = \Aimeos\MShop\Media\Manager\Factory::createManager( \TestHelperMShop::getContext() );
-		$this->object = $manager->getSubManager( 'property' )->getSubManager('type');
+		$this->object = $manager->getSubManager( 'property' )->getSubManager( 'type' );
 	}
 
 
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
@@ -68,7 +68,7 @@ 
 
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results) ) === false )
+		if( ( $expected = reset( $results ) ) === false )
 		{
 			throw new \RuntimeException( 'No property type item found.' );
 		}
@@ -90,13 +90,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$search->setConditions( $search->compare( '==', 'media.property.type.editor', $this->editor ) );
-		$results = $this->object->searchItems($search);
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -157,7 +157,7 @@ 
 		$expr[] = $search->compare( '>=', 'media.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'media.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
@@ -167,15 +167,15 @@ 
 			$search->compare( '=~', 'media.property.type.code', '' ),
 			$search->compare( '==', 'media.property.type.editor', $this->editor )
 		);
-		$search->setConditions( $search->combine('&&', $conditions ) );
+		$search->setConditions( $search->combine( '&&', $conditions ) );
 		$search->setSortations( [$search->sort( '-', 'media.property.type.position' )] );
-		$search->setSlice(0, 1);
-		$items = $this->object->searchItems( $search, [], $total);
+		$search->setSlice( 0, 1 );
+		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 3, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -183,7 +183,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }

lib/mshoplib/setup/unittest/data/attribute-property.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
  * @copyright Aimeos (aimeos.org), 2017
  */
 
-return array (
+return array(
 	'attribute/property/type' => array(
 		'attribute/property/type/size' => array( 'domain' => 'attribute', 'code' => 'size', 'label' => 'Size', 'position' => 0, 'status' => 1 ),
 		'attribute/property/type/mtime' => array( 'domain' => 'attribute', 'code' => 'mtime', 'label' => 'Modification time', 'position' => 1, 'status' => 1 ),

lib/mshoplib/src/MShop/Common/Item/Type/Standard.php

Spacing +29 added lines, -29 removed lines

@@ -48,8 +48,8 @@ 
 	 */
 	public function getCode()
 	{
-		if( isset( $this->values[$this->prefix . 'code'] ) ) {
-			return (string) $this->values[$this->prefix . 'code'];
+		if( isset( $this->values[$this->prefix.'code'] ) ) {
+			return (string) $this->values[$this->prefix.'code'];
 		}
 
 		return '';
@@ -66,7 +66,7 @@ 
 	{
 		if( (string) $code !== $this->getCode() )
 		{
-			$this->values[$this->prefix . 'code'] = $this->checkCode( $code );
+			$this->values[$this->prefix.'code'] = $this->checkCode( $code );
 			$this->setModified();
 		}
 
@@ -81,8 +81,8 @@ 
 	 */
 	public function getDomain()
 	{
-		if( isset( $this->values[$this->prefix . 'domain'] ) ) {
-			return (string) $this->values[$this->prefix . 'domain'];
+		if( isset( $this->values[$this->prefix.'domain'] ) ) {
+			return (string) $this->values[$this->prefix.'domain'];
 		}
 
 		return '';
@@ -99,7 +99,7 @@ 
 	{
 		if( (string) $domain !== $this->getDomain() )
 		{
-			$this->values[$this->prefix . 'domain'] = (string) $domain;
+			$this->values[$this->prefix.'domain'] = (string) $domain;
 			$this->setModified();
 		}
 
@@ -114,8 +114,8 @@ 
 	 */
 	public function getName()
 	{
-		if( isset( $this->values[$this->prefix . 'name'] ) ) {
-			return (string) $this->values[$this->prefix . 'name'];
+		if( isset( $this->values[$this->prefix.'name'] ) ) {
+			return (string) $this->values[$this->prefix.'name'];
 		}
 
 		return $this->getLabel();
@@ -129,8 +129,8 @@ 
 	 */
 	public function getLabel()
 	{
-		if( isset( $this->values[$this->prefix . 'label'] ) ) {
-			return (string) $this->values[$this->prefix . 'label'];
+		if( isset( $this->values[$this->prefix.'label'] ) ) {
+			return (string) $this->values[$this->prefix.'label'];
 		}
 
 		return '';
@@ -147,7 +147,7 @@ 
 	{
 		if( (string) $label !== $this->getLabel() )
 		{
-			$this->values[$this->prefix . 'label'] = (string) $label;
+			$this->values[$this->prefix.'label'] = (string) $label;
 			$this->setModified();
 		}
 
@@ -161,8 +161,8 @@ 
 	 */
 	public function getPosition()
 	{
-		if( isset( $this->values[$this->prefix . 'position'] ) ) {
-			return (int) $this->values[$this->prefix . 'position'];
+		if( isset( $this->values[$this->prefix.'position'] ) ) {
+			return (int) $this->values[$this->prefix.'position'];
 		}
 
 		return 0;
@@ -179,7 +179,7 @@ 
 	{
 		if( (int) $pos !== $this->getPosition() )
 		{
-			$this->values[$this->prefix . 'position'] = (int) $pos;
+			$this->values[$this->prefix.'position'] = (int) $pos;
 			$this->setModified();
 		}
 
@@ -194,8 +194,8 @@ 
 	 */
 	public function getStatus()
 	{
-		if( isset( $this->values[$this->prefix . 'status'] ) ) {
-			return (int) $this->values[$this->prefix . 'status'];
+		if( isset( $this->values[$this->prefix.'status'] ) ) {
+			return (int) $this->values[$this->prefix.'status'];
 		}
 
 		return 0;
@@ -212,7 +212,7 @@ 
 	{
 		if( (int) $status !== $this->getStatus() )
 		{
-			$this->values[$this->prefix . 'status'] = (int) $status;
+			$this->values[$this->prefix.'status'] = (int) $status;
 			$this->setModified();
 		}
 
@@ -252,17 +252,17 @@ 
 	{
 		$unknown = [];
 		$list = parent::fromArray( $list );
-		unset( $list[$this->prefix . 'name'] );
+		unset( $list[$this->prefix.'name'] );
 
 		foreach( $list as $key => $value )
 		{
 			switch( $key )
 			{
-				case $this->prefix . 'code': $this->setCode( $value ); break;
-				case $this->prefix . 'domain': $this->setDomain( $value ); break;
-				case $this->prefix . 'label': $this->setLabel( $value ); break;
-				case $this->prefix . 'position': $this->setPosition( $value ); break;
-				case $this->prefix . 'status': $this->setStatus( $value ); break;
+				case $this->prefix.'code': $this->setCode( $value ); break;
+				case $this->prefix.'domain': $this->setDomain( $value ); break;
+				case $this->prefix.'label': $this->setLabel( $value ); break;
+				case $this->prefix.'position': $this->setPosition( $value ); break;
+				case $this->prefix.'status': $this->setStatus( $value ); break;
 				default: $unknown[$key] = $value;
 			}
 		}
@@ -281,12 +281,12 @@ 
 	{
 		$list = parent::toArray( $private );
 
-		$list[$this->prefix . 'code'] = $this->getCode();
-		$list[$this->prefix . 'domain'] = $this->getDomain();
-		$list[$this->prefix . 'name'] = $this->getName();
-		$list[$this->prefix . 'label'] = $this->getLabel();
-		$list[$this->prefix . 'position'] = $this->getPosition();
-		$list[$this->prefix . 'status'] = $this->getStatus();
+		$list[$this->prefix.'code'] = $this->getCode();
+		$list[$this->prefix.'domain'] = $this->getDomain();
+		$list[$this->prefix.'name'] = $this->getName();
+		$list[$this->prefix.'label'] = $this->getLabel();
+		$list[$this->prefix.'position'] = $this->getPosition();
+		$list[$this->prefix.'status'] = $this->getStatus();
 
 		return $list;
 	}