Completed
Push — master ( ac9830...86bd1d )
by Aimeos
01:48
created
lib/custom/src/MW/Cache/Flow.php 2 patches
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	 *
57 57
 	 * @inheritDoc
58 58
 	 *
59
-	 * @param \Traversable|array $keys List of key strings that identify the cache entries
59
+	 * @param string[] $keys List of key strings that identify the cache entries
60 60
 	 * 	that should be removed
61 61
 	 */
62 62
 	public function deleteMultiple( $keys )
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	 *
123 123
 	 * @inheritDoc
124 124
 	 *
125
-	 * @param \Traversable|array $keys List of key strings for the requested cache entries
125
+	 * @param string[] $keys List of key strings for the requested cache entries
126 126
 	 * @param mixed $default Default value to return for keys that do not exist
127 127
 	 * @return array Associative list of key/value pairs for the requested cache
128 128
 	 * 	entries. If a cache entry doesn't exist, neither its key nor a value
@@ -183,7 +183,6 @@  discard block
 block discarded – undo
183 183
 	 *
184 184
 	 * @inheritDoc
185 185
 	 *
186
-	 * @param string $name Key string for the given value like product/id/123
187 186
 	 * @param mixed $value Value string that should be stored for the given key
188 187
 	 * @param int|string|null $expires Date/time string in "YYYY-MM-DD HH:mm:ss"
189 188
 	 * 	format when the cache entry expires
Please login to merge, or discard this patch.
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -31,9 +31,9 @@  discard block
 block discarded – undo
31 31
 	 * @param array $config List of configuration values
32 32
 	 * @param \TYPO3\Flow\Cache\Frontend\FrontendInterface $cache TYPO3 cache object
33 33
 	 */
34
-	public function __construct( array $config, \TYPO3\Flow\Cache\Frontend\FrontendInterface $cache )
34
+	public function __construct(array $config, \TYPO3\Flow\Cache\Frontend\FrontendInterface $cache)
35 35
 	{
36
-		$this->prefix = ( isset( $config['siteid'] ) ? $config['siteid'] . '-' : '' );
36
+		$this->prefix = (isset($config['siteid']) ? $config['siteid'].'-' : '');
37 37
 		$this->object = $cache;
38 38
 	}
39 39
 
@@ -45,9 +45,9 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @param string $key Key string that identifies the single cache entry
47 47
 	 */
48
-	public function delete( $key )
48
+	public function delete($key)
49 49
 	{
50
-		$this->object->remove( $this->prefix . $key );
50
+		$this->object->remove($this->prefix.$key);
51 51
 	}
52 52
 
53 53
 
@@ -59,10 +59,10 @@  discard block
 block discarded – undo
59 59
 	 * @param \Traversable|array $keys List of key strings that identify the cache entries
60 60
 	 * 	that should be removed
61 61
 	 */
62
-	public function deleteMultiple( $keys )
62
+	public function deleteMultiple($keys)
63 63
 	{
64
-		foreach( $keys as $key ) {
65
-			$this->object->remove( $this->prefix . $key );
64
+		foreach ($keys as $key) {
65
+			$this->object->remove($this->prefix.$key);
66 66
 		}
67 67
 	}
68 68
 
@@ -75,10 +75,10 @@  discard block
 block discarded – undo
75 75
 	 * @param string[] $tags List of tag strings that are associated to one or more
76 76
 	 * 	cache entries that should be removed
77 77
 	 */
78
-	public function deleteByTags( array $tags )
78
+	public function deleteByTags(array $tags)
79 79
 	{
80
-		foreach( $tags as $tag ) {
81
-			$this->object->flushByTag( $this->prefix . $tag );
80
+		foreach ($tags as $tag) {
81
+			$this->object->flushByTag($this->prefix.$tag);
82 82
 		}
83 83
 	}
84 84
 
@@ -90,8 +90,8 @@  discard block
 block discarded – undo
90 90
 	 */
91 91
 	public function clear()
92 92
 	{
93
-		if( $this->prefix ) {
94
-			$this->object->flushByTag( $this->prefix . 'siteid' );
93
+		if ($this->prefix) {
94
+			$this->object->flushByTag($this->prefix.'siteid');
95 95
 		} else {
96 96
 			$this->object->flush();
97 97
 		}
@@ -107,9 +107,9 @@  discard block
 block discarded – undo
107 107
 	 * @param string $default Value returned if requested key isn't found
108 108
 	 * @return mixed Value associated to the requested key
109 109
 	 */
110
-	public function get( $name, $default = null )
110
+	public function get($name, $default = null)
111 111
 	{
112
-		if( ( $entry = $this->object->get( $this->prefix . $name ) ) !== false ) {
112
+		if (($entry = $this->object->get($this->prefix.$name)) !== false) {
113 113
 			return $entry;
114 114
 		}
115 115
 
@@ -129,13 +129,13 @@  discard block
 block discarded – undo
129 129
 	 * 	will be in the result list
130 130
 	 * @throws \Aimeos\MW\Cache\Exception If the cache server doesn't respond
131 131
 	 */
132
-	public function getMultiple( $keys, $default = null )
132
+	public function getMultiple($keys, $default = null)
133 133
 	{
134 134
 		$result = array();
135 135
 
136
-		foreach( $keys as $key )
136
+		foreach ($keys as $key)
137 137
 		{
138
-			if( ( $entry = $this->object->get( $this->prefix . $key ) ) !== false ) {
138
+			if (($entry = $this->object->get($this->prefix.$key)) !== false) {
139 139
 				$result[$key] = $entry;
140 140
 			} else {
141 141
 				$result[$key] = $default;
@@ -156,17 +156,17 @@  discard block
 block discarded – undo
156 156
 	 * 	entries. If a tag isn't associated to any cache entry, nothing is returned
157 157
 	 * 	for that tag
158 158
 	 */
159
-	public function getMultipleByTags( array $tags )
159
+	public function getMultipleByTags(array $tags)
160 160
 	{
161 161
 		$result = array();
162
-		$len = strlen( $this->prefix );
162
+		$len = strlen($this->prefix);
163 163
 
164
-		foreach( $tags as $tag )
164
+		foreach ($tags as $tag)
165 165
 		{
166
-			foreach( $this->object->getByTag( $this->prefix . $tag ) as $key => $value )
166
+			foreach ($this->object->getByTag($this->prefix.$tag) as $key => $value)
167 167
 			{
168
-				if( strncmp( $key, $this->prefix, $len ) === 0 ) {
169
-					$result[ substr( $key, $len ) ] = $value;
168
+				if (strncmp($key, $this->prefix, $len) === 0) {
169
+					$result[substr($key, $len)] = $value;
170 170
 				} else {
171 171
 					$result[$key] = $value;
172 172
 				}
@@ -190,19 +190,19 @@  discard block
 block discarded – undo
190 190
 	 * @param array $tags List of tag strings that should be assoicated to the
191 191
 	 * 	given value in the cache
192 192
 	 */
193
-	public function set( $key, $value, $expires = null, array $tags = array() )
193
+	public function set($key, $value, $expires = null, array $tags = array())
194 194
 	{
195
-		if( is_string( $expires ) ) {
196
-			$expires = date_create( $expires )->getTimestamp() - time();
195
+		if (is_string($expires)) {
196
+			$expires = date_create($expires)->getTimestamp() - time();
197 197
 		}
198 198
 
199
-		$tagList = ( $this->prefix ? array( $this->prefix . 'siteid' ) : array() );
199
+		$tagList = ($this->prefix ? array($this->prefix.'siteid') : array());
200 200
 
201
-		foreach( $tags as $tag ) {
202
-			$tagList[] = $this->prefix . $tag;
201
+		foreach ($tags as $tag) {
202
+			$tagList[] = $this->prefix.$tag;
203 203
 		}
204 204
 
205
-		$this->object->set( $this->prefix . $key, $value, $tagList, $expires );
205
+		$this->object->set($this->prefix.$key, $value, $tagList, $expires);
206 206
 	}
207 207
 
208 208
 
@@ -222,14 +222,14 @@  discard block
 block discarded – undo
222 222
 	 * @return null
223 223
 	 * @throws \Aimeos\MW\Cache\Exception If the cache server doesn't respond
224 224
 	 */
225
-	public function setMultiple( $pairs, $expires = null, array $tags = array() )
225
+	public function setMultiple($pairs, $expires = null, array $tags = array())
226 226
 	{
227
-		foreach( $pairs as $key => $value )
227
+		foreach ($pairs as $key => $value)
228 228
 		{
229
-			$tagList = ( isset( $tags[$key] ) ? (array) $tags[$key] : array() );
230
-			$keyExpire = ( isset( $expires[$key] ) ? $expires[$key] : $expires );
229
+			$tagList = (isset($tags[$key]) ? (array) $tags[$key] : array());
230
+			$keyExpire = (isset($expires[$key]) ? $expires[$key] : $expires);
231 231
 
232
-			$this->set( $key, $value, $keyExpire, $tagList );
232
+			$this->set($key, $value, $keyExpire, $tagList);
233 233
 		}
234 234
 	}
235 235
 }
Please login to merge, or discard this patch.
lib/custom/tests/MW/Cache/FlowTest.php 1 patch
Spacing   +65 added lines, -65 removed lines patch added patch discarded remove patch
@@ -17,201 +17,201 @@
 block discarded – undo
17 17
 
18 18
 	protected function setUp()
19 19
 	{
20
-		if( interface_exists( 'TYPO3\Flow\Cache\Frontend\FrontendInterface' ) === false ) {
21
-			$this->markTestSkipped( 'Class \\TYPO3\\Flow\\Cache\\Frontend\\FrontendInterface not found' );
20
+		if (interface_exists('TYPO3\Flow\Cache\Frontend\FrontendInterface') === false) {
21
+			$this->markTestSkipped('Class \\TYPO3\\Flow\\Cache\\Frontend\\FrontendInterface not found');
22 22
 		}
23 23
 
24
-		$this->mock = $this->getMockBuilder( 'TYPO3\Flow\Cache\Frontend\FrontendInterface' )->getMock();
25
-		$this->object = new \Aimeos\MW\Cache\Flow( array(), $this->mock );
24
+		$this->mock = $this->getMockBuilder('TYPO3\Flow\Cache\Frontend\FrontendInterface')->getMock();
25
+		$this->object = new \Aimeos\MW\Cache\Flow(array(), $this->mock);
26 26
 	}
27 27
 
28 28
 
29 29
 	protected function tearDown()
30 30
 	{
31
-		unset( $this->mock, $this->object );
31
+		unset($this->mock, $this->object);
32 32
 	}
33 33
 
34 34
 
35 35
 	public function testDelete()
36 36
 	{
37
-		$this->mock->expects( $this->once() )->method( 'remove' )->with( $this->equalTo( 'key' ) );
38
-		$this->object->delete( 'key' );
37
+		$this->mock->expects($this->once())->method('remove')->with($this->equalTo('key'));
38
+		$this->object->delete('key');
39 39
 	}
40 40
 
41 41
 
42 42
 	public function testDeleteWithSiteId()
43 43
 	{
44
-		$object = new \Aimeos\MW\Cache\Flow( array( 'siteid' => 1 ), $this->mock );
44
+		$object = new \Aimeos\MW\Cache\Flow(array('siteid' => 1), $this->mock);
45 45
 
46
-		$this->mock->expects( $this->once() )->method( 'remove' )->with( $this->equalTo( '1-key' ) );
47
-		$object->delete( 'key' );
46
+		$this->mock->expects($this->once())->method('remove')->with($this->equalTo('1-key'));
47
+		$object->delete('key');
48 48
 	}
49 49
 
50 50
 
51 51
 	public function testDeleteMultiple()
52 52
 	{
53
-		$this->mock->expects( $this->exactly( 2 ) )->method( 'remove' )->with( $this->equalTo( 'key' ) );
54
-		$this->object->deleteMultiple( array( 'key', 'key' ) );
53
+		$this->mock->expects($this->exactly(2))->method('remove')->with($this->equalTo('key'));
54
+		$this->object->deleteMultiple(array('key', 'key'));
55 55
 	}
56 56
 
57 57
 
58 58
 	public function testDeleteMultipleWithSiteId()
59 59
 	{
60
-		$object = new \Aimeos\MW\Cache\Flow( array( 'siteid' => 1 ), $this->mock );
60
+		$object = new \Aimeos\MW\Cache\Flow(array('siteid' => 1), $this->mock);
61 61
 
62
-		$this->mock->expects( $this->once() )->method( 'remove' )->with( $this->equalTo( '1-key' ) );
63
-		$object->deleteMultiple( array( 'key' ) );
62
+		$this->mock->expects($this->once())->method('remove')->with($this->equalTo('1-key'));
63
+		$object->deleteMultiple(array('key'));
64 64
 	}
65 65
 
66 66
 
67 67
 	public function testDeleteByTags()
68 68
 	{
69
-		$this->mock->expects( $this->exactly( 2 ) )->method( 'flushByTag' )->with( $this->equalTo( 'tag' ) );
70
-		$this->object->deleteByTags( array( 'tag', 'tag' ) );
69
+		$this->mock->expects($this->exactly(2))->method('flushByTag')->with($this->equalTo('tag'));
70
+		$this->object->deleteByTags(array('tag', 'tag'));
71 71
 	}
72 72
 
73 73
 
74 74
 	public function testDeleteByTagsWithSiteId()
75 75
 	{
76
-		$object = new \Aimeos\MW\Cache\Flow( array( 'siteid' => 1 ), $this->mock );
76
+		$object = new \Aimeos\MW\Cache\Flow(array('siteid' => 1), $this->mock);
77 77
 
78
-		$this->mock->expects( $this->once() )->method( 'flushByTag' )->with( $this->equalTo( '1-tag' ) );
79
-		$object->deleteByTags( array( 'tag' ) );
78
+		$this->mock->expects($this->once())->method('flushByTag')->with($this->equalTo('1-tag'));
79
+		$object->deleteByTags(array('tag'));
80 80
 	}
81 81
 
82 82
 
83 83
 	public function testClear()
84 84
 	{
85
-		$this->mock->expects( $this->once() )->method( 'flush' );
85
+		$this->mock->expects($this->once())->method('flush');
86 86
 		$this->object->clear();
87 87
 	}
88 88
 
89 89
 
90 90
 	public function testClearWithSiteId()
91 91
 	{
92
-		$object = new \Aimeos\MW\Cache\Flow( array( 'siteid' => 1 ), $this->mock );
92
+		$object = new \Aimeos\MW\Cache\Flow(array('siteid' => 1), $this->mock);
93 93
 
94
-		$this->mock->expects( $this->once() )->method( 'flushByTag' )->with( $this->equalTo( '1-siteid' ) );
94
+		$this->mock->expects($this->once())->method('flushByTag')->with($this->equalTo('1-siteid'));
95 95
 		$object->clear();
96 96
 	}
97 97
 
98 98
 
99 99
 	public function testGet()
100 100
 	{
101
-		$this->mock->expects( $this->once() )->method( 'get' )
102
-			->with( $this->equalTo( 'key' ) )->will( $this->returnValue( 'value' ) );
101
+		$this->mock->expects($this->once())->method('get')
102
+			->with($this->equalTo('key'))->will($this->returnValue('value'));
103 103
 
104
-		$this->assertEquals( 'value', $this->object->get( 'key', 'default' ) );
104
+		$this->assertEquals('value', $this->object->get('key', 'default'));
105 105
 	}
106 106
 
107 107
 
108 108
 	public function testGetDefault()
109 109
 	{
110
-		$this->mock->expects( $this->once() )->method( 'get' )
111
-		->with( $this->equalTo( 'key' ) )->will( $this->returnValue( false ) );
110
+		$this->mock->expects($this->once())->method('get')
111
+		->with($this->equalTo('key'))->will($this->returnValue(false));
112 112
 
113
-		$this->assertEquals( 'default', $this->object->get( 'key', 'default' ) );
113
+		$this->assertEquals('default', $this->object->get('key', 'default'));
114 114
 	}
115 115
 
116 116
 
117 117
 	public function testGetWithSiteId()
118 118
 	{
119
-		$object = new \Aimeos\MW\Cache\Flow( array( 'siteid' => 1 ), $this->mock );
119
+		$object = new \Aimeos\MW\Cache\Flow(array('siteid' => 1), $this->mock);
120 120
 
121
-		$this->mock->expects( $this->once() )->method( 'get' )->with( $this->equalTo( '1-key' ) );
122
-		$object->get( 'key', 'default' );
121
+		$this->mock->expects($this->once())->method('get')->with($this->equalTo('1-key'));
122
+		$object->get('key', 'default');
123 123
 	}
124 124
 
125 125
 
126 126
 	public function testGetMultiple()
127 127
 	{
128
-		$this->mock->expects( $this->exactly( 2 ) )->method( 'get' )
129
-			->will( $this->returnValue( 'value' ) );
128
+		$this->mock->expects($this->exactly(2))->method('get')
129
+			->will($this->returnValue('value'));
130 130
 
131
-		$expected = array( 'key1' => 'value', 'key2' => 'value' );
132
-		$this->assertEquals( $expected, $this->object->getMultiple( array( 'key1', 'key2' ) ) );
131
+		$expected = array('key1' => 'value', 'key2' => 'value');
132
+		$this->assertEquals($expected, $this->object->getMultiple(array('key1', 'key2')));
133 133
 	}
134 134
 
135 135
 
136 136
 	public function testGetMultipleWithSiteId()
137 137
 	{
138
-		$object = new \Aimeos\MW\Cache\Flow( array( 'siteid' => 1 ), $this->mock );
138
+		$object = new \Aimeos\MW\Cache\Flow(array('siteid' => 1), $this->mock);
139 139
 
140
-		$this->mock->expects( $this->once() )->method( 'get' )->with( $this->equalTo( '1-key' ) );
141
-		$object->getMultiple( array( 'key' ) );
140
+		$this->mock->expects($this->once())->method('get')->with($this->equalTo('1-key'));
141
+		$object->getMultiple(array('key'));
142 142
 	}
143 143
 
144 144
 
145 145
 	public function testGetMultipleByTags()
146 146
 	{
147
-		$this->mock->expects( $this->exactly( 2 ) )->method( 'getByTag' )
148
-			->with( $this->equalTo( 'key' ) )->will( $this->returnValue( array( 'key' => 'value' ) ) );
147
+		$this->mock->expects($this->exactly(2))->method('getByTag')
148
+			->with($this->equalTo('key'))->will($this->returnValue(array('key' => 'value')));
149 149
 
150
-		$this->assertEquals( array( 'key' => 'value' ), $this->object->getMultipleByTags( array( 'key', 'key' ) ) );
150
+		$this->assertEquals(array('key' => 'value'), $this->object->getMultipleByTags(array('key', 'key')));
151 151
 	}
152 152
 
153 153
 
154 154
 	public function testGetMultipleByTagsWithSiteId()
155 155
 	{
156
-		$object = new \Aimeos\MW\Cache\Flow( array( 'siteid' => 1 ), $this->mock );
156
+		$object = new \Aimeos\MW\Cache\Flow(array('siteid' => 1), $this->mock);
157 157
 
158
-		$this->mock->expects( $this->once() )->method( 'getByTag' )
159
-			->with( $this->equalTo( '1-key' ) )->will( $this->returnValue( array( '1-key' => 'value' ) ) );
158
+		$this->mock->expects($this->once())->method('getByTag')
159
+			->with($this->equalTo('1-key'))->will($this->returnValue(array('1-key' => 'value')));
160 160
 
161
-		$this->assertEquals( array( 'key' => 'value' ), $object->getMultipleByTags( array( 'key' ) ) );
161
+		$this->assertEquals(array('key' => 'value'), $object->getMultipleByTags(array('key')));
162 162
 	}
163 163
 
164 164
 
165 165
 	public function testSet()
166 166
 	{
167
-		$this->mock->expects( $this->once() )->method( 'set' )
167
+		$this->mock->expects($this->once())->method('set')
168 168
 			->with(
169
-				$this->equalTo( 'key' ), $this->equalTo( 'value' ),
170
-				$this->equalTo( array( 'tag' ) ), $this->greaterThan( 0 )
169
+				$this->equalTo('key'), $this->equalTo('value'),
170
+				$this->equalTo(array('tag')), $this->greaterThan(0)
171 171
 			);
172 172
 
173
-		$this->object->set( 'key', 'value', '2100-01-01 00:00:00', array( 'tag' ) );
173
+		$this->object->set('key', 'value', '2100-01-01 00:00:00', array('tag'));
174 174
 	}
175 175
 
176 176
 
177 177
 	public function testSetWithSiteId()
178 178
 	{
179
-		$object = new \Aimeos\MW\Cache\Flow( array( 'siteid' => 1 ), $this->mock );
179
+		$object = new \Aimeos\MW\Cache\Flow(array('siteid' => 1), $this->mock);
180 180
 
181
-		$this->mock->expects( $this->once() )->method( 'set' )
181
+		$this->mock->expects($this->once())->method('set')
182 182
 			->with(
183
-				$this->equalTo( '1-key' ), $this->equalTo( 'value' ),
184
-				$this->equalTo( array( '1-siteid', '1-tag' ) ), $this->equalTo( null )
183
+				$this->equalTo('1-key'), $this->equalTo('value'),
184
+				$this->equalTo(array('1-siteid', '1-tag')), $this->equalTo(null)
185 185
 			);
186 186
 
187
-		$object->set( 'key', 'value', null, array( 'tag' ) );
187
+		$object->set('key', 'value', null, array('tag'));
188 188
 	}
189 189
 
190 190
 
191 191
 	public function testSetMultiple()
192 192
 	{
193
-		$this->mock->expects( $this->once() )->method( 'set' )
193
+		$this->mock->expects($this->once())->method('set')
194 194
 			->with(
195
-				$this->equalTo( 'key' ), $this->equalTo( 'value' ),
196
-				$this->equalTo( array( 'tag' ) ), $this->greaterThan( 0 )
195
+				$this->equalTo('key'), $this->equalTo('value'),
196
+				$this->equalTo(array('tag')), $this->greaterThan(0)
197 197
 			);
198 198
 
199
-		$expires = array( 'key' => '2100-01-01 00:00:00' );
200
-		$this->object->setMultiple( array( 'key' => 'value' ), $expires, array( 'key' => array( 'tag' ) ) );
199
+		$expires = array('key' => '2100-01-01 00:00:00');
200
+		$this->object->setMultiple(array('key' => 'value'), $expires, array('key' => array('tag')));
201 201
 	}
202 202
 
203 203
 
204 204
 	public function testSetMultipleWithSiteId()
205 205
 	{
206
-		$object = new \Aimeos\MW\Cache\Flow( array( 'siteid' => 1 ), $this->mock );
206
+		$object = new \Aimeos\MW\Cache\Flow(array('siteid' => 1), $this->mock);
207 207
 
208
-		$this->mock->expects( $this->once() )->method( 'set' )
208
+		$this->mock->expects($this->once())->method('set')
209 209
 			->with(
210
-				$this->equalTo( '1-key' ), $this->equalTo( 'value' ),
211
-				$this->equalTo( array( '1-siteid', '1-tag' ) ), $this->equalTo( null )
210
+				$this->equalTo('1-key'), $this->equalTo('value'),
211
+				$this->equalTo(array('1-siteid', '1-tag')), $this->equalTo(null)
212 212
 			);
213 213
 
214
-		$object->setMultiple( array( 'key' => 'value' ), null, array( 'key' => array( 'tag' ) ) );
214
+		$object->setMultiple(array('key' => 'value'), null, array('key' => array('tag')));
215 215
 	}
216 216
 
217 217
 }
Please login to merge, or discard this patch.