aimeos / ai-controller-jobs

controller/jobs/src/Controller/Jobs/Subscription/Process/Renew/Standard.php

Doc Comments -3 removed lines

@@ -128,7 +128,6 @@ 
 	 * Adds the given addresses to the basket
 	 *
 	 * @param \Aimeos\MShop\Context\Item\Iface Context object
-	 * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Basket object to add the addresses to
 	 * @param array $addresses Associative list of type as key and address object implementing \Aimeos\MShop\Order\Item\Base\Address\Iface as value
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface Order with addresses added
 	 */
@@ -205,7 +204,6 @@ 
 	 * Adds the given products to the basket
 	 *
 	 * @param \Aimeos\MShop\Context\Item\Iface Context object
-	 * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Basket object to add the products to
 	 * @param \Aimeos\MShop\Order\Item\Base\Product\Iface[] $orderProducts List of product items
 	 * @param string $orderProductId Unique ID of the ordered subscription product
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface Order with products added
@@ -232,7 +230,6 @@ 
 	 * Adds a matching delivery and payment service to the basket
 	 *
 	 * @param \Aimeos\MShop\Context\Item\Iface Context object
-	 * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Basket object to add the services to
 	 * @param array $services Associative list of type as key and list of service objects implementing \Aimeos\MShop\Order\Item\Base\Service\Iface as values
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface Order with delivery and payment service added
 	 */

Spacing +108 added lines, -108 removed lines

@@ -28,7 +28,7 @@ 
 	 */
 	public function getName()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Subscription process renew' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Subscription process renew');
 	}
 
 
@@ -39,7 +39,7 @@ 
 	 */
 	public function getDescription()
 	{
-		return $this->getContext()->getI18n()->dt( 'controller/jobs', 'Renews subscriptions at next date' );
+		return $this->getContext()->getI18n()->dt('controller/jobs', 'Renews subscriptions at next date');
 	}
 
 
@@ -54,73 +54,73 @@ 
 		$config = $context->getConfig();
 		$logger = $context->getLogger();
 
-		$names = (array) $config->get( 'controller/common/subscription/process/processors', [] );
+		$names = (array) $config->get('controller/common/subscription/process/processors', []);
 
-		$date = date( 'Y-m-d' );
-		$processors = $this->getProcessors( $names );
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'subscription' );
+		$date = date('Y-m-d');
+		$processors = $this->getProcessors($names);
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'subscription');
 
-		$search = $manager->createSearch( true );
+		$search = $manager->createSearch(true);
 		$expr = [
-			$search->compare( '<=', 'subscription.datenext', $date ),
-			$search->combine( '||', [
-				$search->compare( '==', 'subscription.dateend', null ),
-				$search->compare( '>', 'subscription.dateend', $date ),
-			] ),
+			$search->compare('<=', 'subscription.datenext', $date),
+			$search->combine('||', [
+				$search->compare('==', 'subscription.dateend', null),
+				$search->compare('>', 'subscription.dateend', $date),
+			]),
 			$search->getConditions(),
 		];
-		$search->setConditions( $search->combine( '&&', $expr ) );
-		$search->setSortations( [$search->sort( '+', 'subscription.id' )] );
+		$search->setConditions($search->combine('&&', $expr));
+		$search->setSortations([$search->sort('+', 'subscription.id')]);
 
 		$start = 0;
 
 		do
 		{
-			$search->setSlice( $start, 100 );
-			$items = $manager->searchItems( $search );
+			$search->setSlice($start, 100);
+			$items = $manager->searchItems($search);
 
-			foreach( $items as $item )
+			foreach ($items as $item)
 			{
 				try
 				{
-					$context = $this->createContext( $item->getOrderBaseId() );
-					$newOrder = $this->createOrderBase( $context, $item );
-					$newInvoice = $this->createOrderInvoice( $context, $newOrder );
+					$context = $this->createContext($item->getOrderBaseId());
+					$newOrder = $this->createOrderBase($context, $item);
+					$newInvoice = $this->createOrderInvoice($context, $newOrder);
 
 					try
 					{
-						$this->createPayment( $context, $newOrder, $newInvoice );
+						$this->createPayment($context, $newOrder, $newInvoice);
 
-						$interval = new \DateInterval( $item->getInterval() );
-						$item->setDateNext( date_create()->add( $interval )->format( 'Y-m-d' ) );
+						$interval = new \DateInterval($item->getInterval());
+						$item->setDateNext(date_create()->add($interval)->format('Y-m-d'));
 					}
-					catch( \Exception $e )
+					catch (\Exception $e)
 					{
-						$item->setReason( \Aimeos\MShop\Subscription\Item\Iface::REASON_PAYMENT );
-						$item->setDateEnd( date_create()->format( 'Y-m-d' ) );
-						$manager->saveItem( $item );
+						$item->setReason(\Aimeos\MShop\Subscription\Item\Iface::REASON_PAYMENT);
+						$item->setDateEnd(date_create()->format('Y-m-d'));
+						$manager->saveItem($item);
 
 						throw $e;
 					}
 
-					$manager->saveItem( $item );
+					$manager->saveItem($item);
 
-					foreach( $processors as $processor ) {
-						$processor->renew( $item, $newInvoice );
+					foreach ($processors as $processor) {
+						$processor->renew($item, $newInvoice);
 					}
 				}
-				catch( \Exception $e )
+				catch (\Exception $e)
 				{
 					$msg = 'Unable to process subscription with ID "%1$s": %2$s';
-					$logger->log( sprintf( $msg, $item->getId(), $e->getMessage() ) );
-					$logger->log( $e->getTraceAsString() );
+					$logger->log(sprintf($msg, $item->getId(), $e->getMessage()));
+					$logger->log($e->getTraceAsString());
 				}
 			}
 
-			$count = count( $items );
+			$count = count($items);
 			$start += $count;
 		}
-		while( $count === $search->getSliceSize() );
+		while ($count === $search->getSliceSize());
 	}
 
 
@@ -132,11 +132,11 @@ 
 	 * @param array $addresses Associative list of type as key and address object implementing \Aimeos\MShop\Order\Item\Base\Address\Iface as value
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface Order with addresses added
 	 */
-	protected function addBasketAddresses( \Aimeos\MShop\Context\Item\Iface $context,
-		\Aimeos\MShop\Order\Item\Base\Iface $newBasket, array $addresses )
+	protected function addBasketAddresses(\Aimeos\MShop\Context\Item\Iface $context,
+		\Aimeos\MShop\Order\Item\Base\Iface $newBasket, array $addresses)
 	{
-		foreach( $addresses as $type => $orderAddress ) {
-			$newBasket->setAddress( $orderAddress, $type );
+		foreach ($addresses as $type => $orderAddress) {
+			$newBasket->setAddress($orderAddress, $type);
 		}
 
 		return $newBasket;
@@ -151,8 +151,8 @@ 
 	 * @param array $codes List of coupon codes that should be added to the given basket
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface Basket, maybe with coupons added
 	 */
-	protected function addBasketCoupons( \Aimeos\MShop\Context\Item\Iface $context,
-		\Aimeos\MShop\Order\Item\Base\Iface $basket, array $codes )
+	protected function addBasketCoupons(\Aimeos\MShop\Context\Item\Iface $context,
+		\Aimeos\MShop\Order\Item\Base\Iface $basket, array $codes)
 	{
 		/** controller/jobs/subcription/process/renew/standard/use-coupons
 		 *
@@ -166,34 +166,34 @@ 
 		 * @category User
 		 * @since 2018.10
 		 */
-		if( $context->getConfig()->get( 'controller/jobs/subcription/process/renew/standard/use-coupons', false ) )
+		if ($context->getConfig()->get('controller/jobs/subcription/process/renew/standard/use-coupons', false))
 		{
-			$manager = \Aimeos\MShop\Factory::createManager( $context, 'coupon' );
-			$codeManager = \Aimeos\MShop\Factory::createManager( $context, 'coupon/code' );
+			$manager = \Aimeos\MShop\Factory::createManager($context, 'coupon');
+			$codeManager = \Aimeos\MShop\Factory::createManager($context, 'coupon/code');
 
-			foreach( $codes as $code )
+			foreach ($codes as $code)
 			{
-				$search = $manager->createSearch( true )->setSlice( 0, 1 );
+				$search = $manager->createSearch(true)->setSlice(0, 1);
 				$expr = [
-					$search->compare( '==', 'coupon.code.code', $code ),
-					$codeManager->createSearch( true )->getConditions(),
+					$search->compare('==', 'coupon.code.code', $code),
+					$codeManager->createSearch(true)->getConditions(),
 					$search->getConditions(),
 				];
-				$search->setConditions( $search->combine( '&&', $expr ) );
+				$search->setConditions($search->combine('&&', $expr));
 
-				$result = $manager->searchItems( $search );
+				$result = $manager->searchItems($search);
 
-				if( ( $item = reset( $result ) ) === false ) {
+				if (($item = reset($result)) === false) {
 					continue;
 				}
 
-				$provider = $manager->getProvider( $item, $code );
+				$provider = $manager->getProvider($item, $code);
 
-				if( $provider->isAvailable( $basket ) !== true ) {
+				if ($provider->isAvailable($basket) !== true) {
 					continue;
 				}
 
-				$provider->addCoupon( $basket );
+				$provider->addCoupon($basket);
 			}
 		}
 
@@ -210,17 +210,17 @@ 
 	 * @param string $orderProductId Unique ID of the ordered subscription product
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface Order with products added
 	 */
-	protected function addBasketProducts( \Aimeos\MShop\Context\Item\Iface $context,
-		\Aimeos\MShop\Order\Item\Base\Iface $newBasket, array $orderProducts, $orderProductId )
+	protected function addBasketProducts(\Aimeos\MShop\Context\Item\Iface $context,
+		\Aimeos\MShop\Order\Item\Base\Iface $newBasket, array $orderProducts, $orderProductId)
 	{
-		foreach( $orderProducts as $orderProduct )
+		foreach ($orderProducts as $orderProduct)
 		{
-			if( $orderProduct->getId() == $orderProductId )
+			if ($orderProduct->getId() == $orderProductId)
 			{
-				foreach( $orderProduct->getAttributeItems() as $attrItem ) {
-					$attrItem->setId( null );
+				foreach ($orderProduct->getAttributeItems() as $attrItem) {
+					$attrItem->setId(null);
 				}
-				$newBasket->addProduct( $orderProduct->setId( null ) );
+				$newBasket->addProduct($orderProduct->setId(null));
 			}
 		}
 
@@ -236,35 +236,35 @@ 
 	 * @param array $services Associative list of type as key and list of service objects implementing \Aimeos\MShop\Order\Item\Base\Service\Iface as values
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface Order with delivery and payment service added
 	 */
-	protected function addBasketServices( \Aimeos\MShop\Context\Item\Iface $context,
-		\Aimeos\MShop\Order\Item\Base\Iface $newBasket, array $services )
+	protected function addBasketServices(\Aimeos\MShop\Context\Item\Iface $context,
+		\Aimeos\MShop\Order\Item\Base\Iface $newBasket, array $services)
 	{
 		$type = \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_PAYMENT;
 
-		if( isset( $services[$type] ) )
+		if (isset($services[$type]))
 		{
-			foreach( $services[$type] as $orderService ) {
-				$newBasket->addService( $orderService, $type );
+			foreach ($services[$type] as $orderService) {
+				$newBasket->addService($orderService, $type);
 			}
 		}
 
 		$type = \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY;
 
-		$serviceManager = \Aimeos\MShop\Factory::createManager( $context, 'service' );
-		$orderServiceManager = \Aimeos\MShop\Factory::createManager( $context, 'order/base/service' );
+		$serviceManager = \Aimeos\MShop\Factory::createManager($context, 'service');
+		$orderServiceManager = \Aimeos\MShop\Factory::createManager($context, 'order/base/service');
 
-		$search = $serviceManager->createSearch( true );
-		$search->setSortations( [$search->sort( '+', 'service.position' )] );
-		$search->setConditions( $search->compare( '==', 'service.type.code', $type ) );
+		$search = $serviceManager->createSearch(true);
+		$search->setSortations([$search->sort('+', 'service.position')]);
+		$search->setConditions($search->compare('==', 'service.type.code', $type));
 
-		foreach( $serviceManager->searchItems( $search, ['media', 'price', 'text'] ) as $item )
+		foreach ($serviceManager->searchItems($search, ['media', 'price', 'text']) as $item)
 		{
-			$provider = $serviceManager->getProvider( $item, $item->getType() );
+			$provider = $serviceManager->getProvider($item, $item->getType());
 
-			if( $provider->isAvailable( $newBasket ) === true )
+			if ($provider->isAvailable($newBasket) === true)
 			{
-				$orderServiceItem = $orderServiceManager->createItem()->copyFrom( $item );
-				return $newBasket->addService( $orderServiceItem, $type );
+				$orderServiceItem = $orderServiceManager->createItem()->copyFrom($item);
+				return $newBasket->addService($orderServiceItem, $type);
 			}
 		}
 
@@ -278,30 +278,30 @@ 
 	 * @param string $baseId Unique order base ID
 	 * @return \Aimeos\MShop\Context\Item\Iface New context object
 	 */
-	protected function createContext( $baseId )
+	protected function createContext($baseId)
 	{
 		$context = clone $this->getContext();
 
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'order/base' );
-		$baseItem = $manager->getItem( $baseId );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'order/base');
+		$baseItem = $manager->getItem($baseId);
 
 		$locale = $baseItem->getLocale();
 		$level = \Aimeos\MShop\Locale\Manager\Base::SITE_ALL;
 
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'locale' );
-		$locale = $manager->bootstrap( $baseItem->getSiteCode(), $locale->getLanguageId(), $locale->getCurrencyId(), false, $level );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'locale');
+		$locale = $manager->bootstrap($baseItem->getSiteCode(), $locale->getLanguageId(), $locale->getCurrencyId(), false, $level);
 
-		$context->setLocale( $locale );
+		$context->setLocale($locale);
 
 		try
 		{
-			$manager = \Aimeos\MShop\Factory::createManager( $context, 'customer' );
-			$customerItem = $manager->getItem( $baseItem->getCustomerId(), ['customer/group'] );
+			$manager = \Aimeos\MShop\Factory::createManager($context, 'customer');
+			$customerItem = $manager->getItem($baseItem->getCustomerId(), ['customer/group']);
 
-			$context->setUserId( $baseItem->getCustomerId() );
-			$context->setGroupIds( $customerItem->getGroups() );
+			$context->setUserId($baseItem->getCustomerId());
+			$context->setGroupIds($customerItem->getGroups());
 		}
-		catch( \Exception $e ) {} // Subscription without account
+		catch (\Exception $e) {} // Subscription without account
 
 		return $context;
 	}
@@ -314,19 +314,19 @@ 
 	 * @param \Aimeos\MShop\Subscription\Item\Iface $subscription Subscription item with order base ID and order product ID
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface Complete order with product, addresses and services saved to the storage
 	 */
-	protected function createOrderBase( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MShop\Subscription\Item\Iface $subscription )
+	protected function createOrderBase(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MShop\Subscription\Item\Iface $subscription)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'order/base' );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'order/base');
 
-		$basket = $manager->load( $subscription->getOrderBaseId() );
-		$newBasket = $manager->createItem()->setCustomerId( $basket->getCustomerId() );
+		$basket = $manager->load($subscription->getOrderBaseId());
+		$newBasket = $manager->createItem()->setCustomerId($basket->getCustomerId());
 
-		$newBasket = $this->addBasketProducts( $context, $newBasket, $basket->getProducts(), $subscription->getOrderProductId() );
-		$newBasket = $this->addBasketAddresses( $context, $newBasket, $basket->getAddresses() );
-		$newBasket = $this->addBasketServices( $context, $newBasket, $basket->getServices() );
-		$newBasket = $this->addBasketCoupons( $context, $newBasket, array_keys( $basket->getCoupons() ) );
+		$newBasket = $this->addBasketProducts($context, $newBasket, $basket->getProducts(), $subscription->getOrderProductId());
+		$newBasket = $this->addBasketAddresses($context, $newBasket, $basket->getAddresses());
+		$newBasket = $this->addBasketServices($context, $newBasket, $basket->getServices());
+		$newBasket = $this->addBasketCoupons($context, $newBasket, array_keys($basket->getCoupons()));
 
-		return $manager->store( $newBasket );
+		return $manager->store($newBasket);
 	}
 
 
@@ -337,15 +337,15 @@ 
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Complete order with product, addresses and services saved to the storage
 	 * @return \Aimeos\MShop\Order\Item\Iface New invoice item associated to the order saved to the storage
 	 */
-	protected function createOrderInvoice( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MShop\Order\Item\Base\Iface $basket )
+	protected function createOrderInvoice(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MShop\Order\Item\Base\Iface $basket)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'order' );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'order');
 
 		$item = $manager->createItem();
-		$item->setBaseId( $basket->getId() );
-		$item->setType( 'subscription' );
+		$item->setBaseId($basket->getId());
+		$item->setType('subscription');
 
-		return $manager->saveItem( $item );
+		return $manager->saveItem($item);
 	}
 
 
@@ -356,17 +356,17 @@ 
 	 * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Complete order with product, addresses and services
 	 * @param \Aimeos\MShop\Order\Item\Iface New invoice item associated to the order
 	 */
-	protected function createPayment( \Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MShop\Order\Item\Base\Iface $basket,
-		\Aimeos\MShop\Order\Item\Iface $invoice )
+	protected function createPayment(\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MShop\Order\Item\Base\Iface $basket,
+		\Aimeos\MShop\Order\Item\Iface $invoice)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'service' );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'service');
 
-		foreach( $basket->getService( \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_PAYMENT ) as $service )
+		foreach ($basket->getService(\Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_PAYMENT) as $service)
 		{
-			$item = $manager->getItem( $service->getServiceId() );
-			$provider = $manager->getProvider( $item, 'payment' );
+			$item = $manager->getItem($service->getServiceId());
+			$provider = $manager->getProvider($item, 'payment');
 
-			$provider->repay( $invoice );
+			$provider->repay($invoice);
 		}
 	}
 }

controller/jobs/tests/Controller/Jobs/Subscription/Process/Renew/StandardTest.php

Doc Comments +3 added lines

@@ -263,6 +263,9 @@
 	}
 
 
+	/**
+	 * @param string $name
+	 */
 	protected function access( $name )
 	{
 		$class = new \ReflectionClass( \Aimeos\Controller\Jobs\Subscription\Process\Renew\Standard::class );

Spacing +100 added lines, -100 removed lines

@@ -21,62 +21,62 @@ 
 		$this->aimeos = \TestHelperJobs::getAimeos();
 		$this->context = \TestHelperJobs::getContext();
 
-		$this->object = new \Aimeos\Controller\Jobs\Subscription\Process\Renew\Standard( $this->context, $this->aimeos );
+		$this->object = new \Aimeos\Controller\Jobs\Subscription\Process\Renew\Standard($this->context, $this->aimeos);
 
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
+		\Aimeos\MShop\Factory::setCache(false);
 		\Aimeos\MShop\Factory::clear();
 
-		unset( $this->object, $this->context, $this->aimeos );
+		unset($this->object, $this->context, $this->aimeos);
 	}
 
 
 	public function testGetName()
 	{
-		$this->assertEquals( 'Subscription process renew', $this->object->getName() );
+		$this->assertEquals('Subscription process renew', $this->object->getName());
 	}
 
 
 	public function testGetDescription()
 	{
-		$this->assertEquals( 'Renews subscriptions at next date', $this->object->getDescription() );
+		$this->assertEquals('Renews subscriptions at next date', $this->object->getDescription());
 	}
 
 
 	public function testRun()
 	{
-		$this->context->getConfig()->set( 'controller/common/subscription/process/processors', ['cgroup'] );
+		$this->context->getConfig()->set('controller/common/subscription/process/processors', ['cgroup']);
 		$item = $this->getSubscription();
 
-		$object = $this->getMockBuilder( '\\Aimeos\\Controller\\Jobs\\Subscription\\Process\\Renew\\Standard' )
-			->setConstructorArgs( [$this->context, $this->aimeos] )
-			->setMethods( ['createOrderBase', 'createOrderInvoice', 'createPayment'] )
+		$object = $this->getMockBuilder('\\Aimeos\\Controller\\Jobs\\Subscription\\Process\\Renew\\Standard')
+			->setConstructorArgs([$this->context, $this->aimeos])
+			->setMethods(['createOrderBase', 'createOrderInvoice', 'createPayment'])
 			->getMock();
 
-		$managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Subscription\\Manager\\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['searchItems', 'saveItem'] )
+		$managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Subscription\\Manager\\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['searchItems', 'saveItem'])
 			->getMock();
 
-		\Aimeos\MShop\Factory::injectManager( $this->context, 'subscription', $managerStub );
+		\Aimeos\MShop\Factory::injectManager($this->context, 'subscription', $managerStub);
 
-		$object->expects( $this->once() )->method( 'createOrderBase' )
-			->will( $this->returnValue( $this->getOrderBaseItem( $item->getOrderBaseId() ) ) );
+		$object->expects($this->once())->method('createOrderBase')
+			->will($this->returnValue($this->getOrderBaseItem($item->getOrderBaseId())));
 
-		$object->expects( $this->once() )->method( 'createOrderInvoice' )
-			->will( $this->returnValue( $this->getOrderItem() ) );
+		$object->expects($this->once())->method('createOrderInvoice')
+			->will($this->returnValue($this->getOrderItem()));
 
-		$object->expects( $this->once() )->method( 'createPayment' );
+		$object->expects($this->once())->method('createPayment');
 
-		$managerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( [$item] ) );
+		$managerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue([$item]));
 
-		$managerStub->expects( $this->once() )->method( 'saveItem' );
+		$managerStub->expects($this->once())->method('saveItem');
 
 		$object->run();
 	}
@@ -84,19 +84,19 @@ 
 
 	public function testRunException()
 	{
-		$this->context->getConfig()->set( 'controller/common/subscription/process/processors', ['cgroup'] );
+		$this->context->getConfig()->set('controller/common/subscription/process/processors', ['cgroup']);
 
-		$managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Subscription\\Manager\\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['searchItems', 'saveItem'] )
+		$managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Subscription\\Manager\\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['searchItems', 'saveItem'])
 			->getMock();
 
-		\Aimeos\MShop\Factory::injectManager( $this->context, 'subscription', $managerStub );
+		\Aimeos\MShop\Factory::injectManager($this->context, 'subscription', $managerStub);
 
-		$managerStub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( [$managerStub->createItem()] ) );
+		$managerStub->expects($this->once())->method('searchItems')
+			->will($this->returnValue([$managerStub->createItem()]));
 
-		$managerStub->expects( $this->never() )->method( 'saveItem' );
+		$managerStub->expects($this->never())->method('saveItem');
 
 		$this->object->run();
 	}
@@ -104,79 +104,79 @@ 
 
 	public function testAddBasketAddresses()
 	{
-		$basket = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base' )->createItem();
-		$address = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base/address' )->createItem();
+		$basket = \Aimeos\MShop\Factory::createManager($this->context, 'order/base')->createItem();
+		$address = \Aimeos\MShop\Factory::createManager($this->context, 'order/base/address')->createItem();
 
 		$addresses = ['payment' => $address];
-		$basket = $this->access( 'addBasketAddresses' )->invokeArgs( $this->object, [$this->context, $basket, $addresses] );
+		$basket = $this->access('addBasketAddresses')->invokeArgs($this->object, [$this->context, $basket, $addresses]);
 
-		$this->assertEquals( 1, count( $basket->getAddresses() ) );
-		$this->assertInstanceOf( \Aimeos\MShop\Order\Item\Base\Address\Iface::class, $basket->getAddress( 'payment' ) );
+		$this->assertEquals(1, count($basket->getAddresses()));
+		$this->assertInstanceOf(\Aimeos\MShop\Order\Item\Base\Address\Iface::class, $basket->getAddress('payment'));
 	}
 
 
 	public function testAddBasketCoupons()
 	{
-		$this->context->getConfig()->set( 'controller/jobs/subcription/process/renew/standard/use-coupons', true );
+		$this->context->getConfig()->set('controller/jobs/subcription/process/renew/standard/use-coupons', true);
 
-		$basket = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base' )->createItem();
-		$product = \Aimeos\MShop\Factory::createManager( $this->context, 'product' )->findItem( 'CNC', ['price'] );
-		$orderProduct = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base/product' )->createItem();
+		$basket = \Aimeos\MShop\Factory::createManager($this->context, 'order/base')->createItem();
+		$product = \Aimeos\MShop\Factory::createManager($this->context, 'product')->findItem('CNC', ['price']);
+		$orderProduct = \Aimeos\MShop\Factory::createManager($this->context, 'order/base/product')->createItem();
 
-		$price = $product->getRefItems( 'price', 'default', 'default' );
-		$basket->addProduct( $orderProduct->copyFrom( $product )->setPrice( reset( $price ) ) );
+		$price = $product->getRefItems('price', 'default', 'default');
+		$basket->addProduct($orderProduct->copyFrom($product)->setPrice(reset($price)));
 
-		$this->assertEquals( '600.00', $basket->getPrice()->getValue() );
-		$this->assertEquals( '30.00', $basket->getPrice()->getCosts() );
-		$this->assertEquals( '0.00', $basket->getPrice()->getRebate() );
+		$this->assertEquals('600.00', $basket->getPrice()->getValue());
+		$this->assertEquals('30.00', $basket->getPrice()->getCosts());
+		$this->assertEquals('0.00', $basket->getPrice()->getRebate());
 
-		$basket = $this->access( 'addBasketCoupons' )->invokeArgs( $this->object, [$this->context, $basket, ['90AB']] );
+		$basket = $this->access('addBasketCoupons')->invokeArgs($this->object, [$this->context, $basket, ['90AB']]);
 
-		$this->assertEquals( 1, count( $basket->getCoupons() ) );
-		$this->assertEquals( 2, count( $basket->getProducts() ) );
-		$this->assertEquals( '537.00', $basket->getPrice()->getValue() );
-		$this->assertEquals( '30.00', $basket->getPrice()->getCosts() );
-		$this->assertEquals( '63.00', $basket->getPrice()->getRebate() );
+		$this->assertEquals(1, count($basket->getCoupons()));
+		$this->assertEquals(2, count($basket->getProducts()));
+		$this->assertEquals('537.00', $basket->getPrice()->getValue());
+		$this->assertEquals('30.00', $basket->getPrice()->getCosts());
+		$this->assertEquals('63.00', $basket->getPrice()->getRebate());
 	}
 
 
 	public function testAddBasketProducts()
 	{
-		$basket = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base' )->createItem();
-		$product = \Aimeos\MShop\Factory::createManager( $this->context, 'product' )->findItem( 'CNC' );
-		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base/product' );
+		$basket = \Aimeos\MShop\Factory::createManager($this->context, 'order/base')->createItem();
+		$product = \Aimeos\MShop\Factory::createManager($this->context, 'product')->findItem('CNC');
+		$manager = \Aimeos\MShop\Factory::createManager($this->context, 'order/base/product');
 
 		$orderProducts = [
-			$manager->createItem()->copyFrom( $product )->setId( 1 ),
-			$manager->createItem()->copyFrom( $product )->setId( 2 ),
+			$manager->createItem()->copyFrom($product)->setId(1),
+			$manager->createItem()->copyFrom($product)->setId(2),
 		];
 
-		$basket = $this->access( 'addBasketProducts' )->invokeArgs( $this->object, [$this->context, $basket, $orderProducts, 1] );
+		$basket = $this->access('addBasketProducts')->invokeArgs($this->object, [$this->context, $basket, $orderProducts, 1]);
 
-		$this->assertEquals( 1, count( $basket->getProducts() ) );
-		$this->assertNull( $basket->getProduct( 0 )->getId() );
+		$this->assertEquals(1, count($basket->getProducts()));
+		$this->assertNull($basket->getProduct(0)->getId());
 	}
 
 
 	public function testAddBasketServices()
 	{
-		$basket = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base' )->createItem();
-		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base/service' );
+		$basket = \Aimeos\MShop\Factory::createManager($this->context, 'order/base')->createItem();
+		$manager = \Aimeos\MShop\Factory::createManager($this->context, 'order/base/service');
 
 		$orderServices = [
-			'delivery' => [$manager->createItem()->setCode( 'shiptest' )],
-			'payment' => [$manager->createItem()->setCode( 'paytest' )],
+			'delivery' => [$manager->createItem()->setCode('shiptest')],
+			'payment' => [$manager->createItem()->setCode('paytest')],
 		];
 
-		$basket = $this->access( 'addBasketServices' )->invokeArgs( $this->object, [$this->context, $basket, $orderServices] );
+		$basket = $this->access('addBasketServices')->invokeArgs($this->object, [$this->context, $basket, $orderServices]);
 
 		$class = \Aimeos\MShop\Order\Item\Base\Service\Iface::class;
 
-		$this->assertEquals( 2, count( $basket->getServices() ) );
-		$this->assertEquals( 1, count( $basket->getService( 'delivery' ) ) );
-		$this->assertInstanceOf( $class, $basket->getService( 'delivery', 'unitcode' ) );
-		$this->assertEquals( 1, count( $basket->getService( 'payment' ) ) );
-		$this->assertInstanceOf( $class, $basket->getService( 'payment', 'paytest' ) );
+		$this->assertEquals(2, count($basket->getServices()));
+		$this->assertEquals(1, count($basket->getService('delivery')));
+		$this->assertInstanceOf($class, $basket->getService('delivery', 'unitcode'));
+		$this->assertEquals(1, count($basket->getService('payment')));
+		$this->assertInstanceOf($class, $basket->getService('payment', 'paytest'));
 	}
 
 
@@ -184,34 +184,34 @@ 
 	{
 		$item = $this->getSubscription();
 
-		$managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['store'] )
+		$managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Base\\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['store'])
 			->getMock();
 
-		\Aimeos\MShop\Factory::injectManager( $this->context, 'order/base', $managerStub );
+		\Aimeos\MShop\Factory::injectManager($this->context, 'order/base', $managerStub);
 
-		$managerStub->expects( $this->once() )->method( 'store' );
+		$managerStub->expects($this->once())->method('store');
 
-		$this->access( 'createOrderBase' )->invokeArgs( $this->object, [$this->context, $item] );
+		$this->access('createOrderBase')->invokeArgs($this->object, [$this->context, $item]);
 	}
 
 
 	public function testCreateOrderInvoice()
 	{
 		$item = $this->getSubscription();
-		$baseItem = $this->getOrderBaseItem( $item->getOrderBaseId() );
+		$baseItem = $this->getOrderBaseItem($item->getOrderBaseId());
 
-		$managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['saveItem'] )
+		$managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['saveItem'])
 			->getMock();
 
-		\Aimeos\MShop\Factory::injectManager( $this->context, 'order', $managerStub );
+		\Aimeos\MShop\Factory::injectManager($this->context, 'order', $managerStub);
 
-		$managerStub->expects( $this->once() )->method( 'saveItem' );
+		$managerStub->expects($this->once())->method('saveItem');
 
-		$this->access( 'createOrderInvoice' )->invokeArgs( $this->object, [$this->context, $baseItem] );
+		$this->access('createOrderInvoice')->invokeArgs($this->object, [$this->context, $baseItem]);
 	}
 
 
@@ -219,55 +219,55 @@ 
 	{
 		$item = $this->getSubscription();
 		$invoice = $this->getOrderItem();
-		$baseItem = $this->getOrderBaseItem( $item->getOrderBaseId() );
+		$baseItem = $this->getOrderBaseItem($item->getOrderBaseId());
 
-		$managerStub = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['saveItem'] )
+		$managerStub = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['saveItem'])
 			->getMock();
 
-		\Aimeos\MShop\Factory::injectManager( $this->context, 'order', $managerStub );
+		\Aimeos\MShop\Factory::injectManager($this->context, 'order', $managerStub);
 
-		$managerStub->expects( $this->once() )->method( 'saveItem' );
+		$managerStub->expects($this->once())->method('saveItem');
 
-		$this->access( 'createPayment' )->invokeArgs( $this->object, [$this->context, $baseItem, $invoice] );
+		$this->access('createPayment')->invokeArgs($this->object, [$this->context, $baseItem, $invoice]);
 	}
 
 
 	protected function getOrderItem()
 	{
-		return \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
+		return \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
 	}
 
 
-	protected function getOrderBaseItem( $baseId )
+	protected function getOrderBaseItem($baseId)
 	{
-		return \Aimeos\MShop\Factory::createManager( $this->context, 'order/base' )->getItem( $baseId, ['order/base/service'] );
+		return \Aimeos\MShop\Factory::createManager($this->context, 'order/base')->getItem($baseId, ['order/base/service']);
 	}
 
 
 	protected function getSubscription()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'subscription' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->context, 'subscription');
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'subscription.dateend', '2010-01-01' ) );
+		$search->setConditions($search->compare('==', 'subscription.dateend', '2010-01-01'));
 
-		$items = $manager->searchItems( $search );
+		$items = $manager->searchItems($search);
 
-		if( ( $item = reset( $items ) ) !== false ) {
+		if (($item = reset($items)) !== false) {
 			return $item;
 		}
 
-		throw new \Exception( 'No subscription item found' );
+		throw new \Exception('No subscription item found');
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( \Aimeos\Controller\Jobs\Subscription\Process\Renew\Standard::class );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass(\Aimeos\Controller\Jobs\Subscription\Process\Renew\Standard::class);
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}