Inspection of "Fixed wrong variable" - aimeos/ai-controller-jobs - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 475f2c...96cc40 )

by Aimeos

created 2019-02-13 11:04 UTC

Status

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -87,8 +87,7 @@
 block discarded – undo
 			foreach( $manager->searchItems( $search ) as $item ) {
 				$this->listTypes[$item->getCode()] = $item->getCode();
 			}
-		}
-		else
+		} else
 		{
 			$this->listTypes = array_flip( $this->listTypes );
 		}

Please login to merge, or discard this patch.

src/Controller/Common/Product/Import/Csv/Processor/Property/Standard.php 2 patches

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -91,8 +91,7 @@
 block discarded – undo
 			{
 				$item = $propMap[$value][$type];
 				unset( $items[ $item->getId() ] );
-			}
-			else
+			} else
 			{
 				$item = $manager->createItem()->setType( $type );
 			}

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 		$map = $this->getMappedChunk( $data, $this->getMapping() );
 
 		foreach( $items as $item ) {
-			$propMap[ $item->getValue() ][ $item->getType() ] = $item;
+			$propMap[$item->getValue()][$item->getType()] = $item;
 		}
 
 		foreach( $map as $list )
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
 			if( isset( $propMap[$value][$type] ) )
 			{
 				$item = $propMap[$value][$type];
-				unset( $items[ $item->getId() ] );
+				unset( $items[$item->getId()] );
 			}
 			else
 			{

Please login to merge, or discard this patch.

src/Controller/Common/Product/Import/Csv/Processor/Media/Standard.php 2 patches

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -81,8 +81,7 @@  discard block
 block discarded – undo
 			foreach( $manager->searchItems( $search ) as $item ) {
 				$this->listTypes[$item->getCode()] = $item->getCode();
 			}
-		}
-		else
+		} else
 		{
 			$this->listTypes = array_flip( $this->listTypes );
 		}
@@ -143,8 +142,7 @@  discard block
 block discarded – undo
 					$listItem = $listMap[$url][$type][$listtype];
 					$refItem = $listItem->getRefItem();
 					unset( $listItems[ $listItem->getId() ] );
-				}
-				else
+				} else
 				{
 					$listItem = $listManager->createItem()->setType( $listtype );
 					$refItem = $manager->createItem()->setType( $type );

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -120,7 +120,7 @@  discard block
 block discarded – undo
 		foreach( $listItems as $listItem )
 		{
 			if( ( $refItem = $listItem->getRefItem() ) !== null ) {
-				$listMap[ $refItem->getUrl() ][ $refItem->getType() ][ $listItem->getType() ] = $listItem;
+				$listMap[$refItem->getUrl()][$refItem->getType()][$listItem->getType()] = $listItem;
 			}
 		}
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
 				{
 					$listItem = $listMap[$url][$type][$listtype];
 					$refItem = $listItem->getRefItem();
-					unset( $listItems[ $listItem->getId() ] );
+					unset( $listItems[$listItem->getId()] );
 				}
 				else
 				{

Please login to merge, or discard this patch.

src/Controller/Common/Product/Import/Csv/Processor/Price/Standard.php 2 patches

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -81,8 +81,7 @@  discard block
 block discarded – undo
 			foreach( $manager->searchItems( $search ) as $item ) {
 				$this->listTypes[$item->getCode()] = $item->getCode();
 			}
-		}
-		else
+		} else
 		{
 			$this->listTypes = array_flip( $this->listTypes );
 		}
@@ -137,8 +136,7 @@  discard block
 block discarded – undo
 				$listItem = $listMap[$value][$type][$listtype];
 				$refItem = $listItem->getRefItem();
 				unset( $listItems[ $listItem->getId() ] );
-			}
-			else
+			} else
 			{
 				$listItem = $listManager->createItem()->setType( $listtype );
 				$refItem = $manager->createItem()->setType( $type );

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -118,7 +118,7 @@  discard block
 block discarded – undo
 		foreach( $listItems as $listItem )
 		{
 			if( ( $refItem = $listItem->getRefItem() ) !== null ) {
-				$listMap[ $refItem->getValue() ][ $refItem->getType() ][ $listItem->getType() ] = $listItem;
+				$listMap[$refItem->getValue()][$refItem->getType()][$listItem->getType()] = $listItem;
 			}
 		}
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
 			{
 				$listItem = $listMap[$value][$type][$listtype];
 				$refItem = $listItem->getRefItem();
-				unset( $listItems[ $listItem->getId() ] );
+				unset( $listItems[$listItem->getId()] );
 			}
 			else
 			{

Please login to merge, or discard this patch.

common/src/Controller/Common/Product/Import/Csv/Processor/Text/Standard.php 2 patches

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -81,8 +81,7 @@  discard block
 block discarded – undo
 			foreach( $manager->searchItems( $search ) as $item ) {
 				$this->listTypes[$item->getCode()] = $item->getCode();
 			}
-		}
-		else
+		} else
 		{
 			$this->listTypes = array_flip( $this->listTypes );
 		}
@@ -137,8 +136,7 @@  discard block
 block discarded – undo
 				$listItem = $listMap[$content][$type][$listtype];
 				$refItem = $listItem->getRefItem();
 				unset( $listItems[ $listItem->getId() ] );
-			}
-			else
+			} else
 			{
 				$listItem = $listManager->createItem()->setType( $listtype );
 				$refItem = $manager->createItem()->setType( $type );

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -118,7 +118,7 @@  discard block
 block discarded – undo
 		foreach( $listItems as $listItem )
 		{
 			if( ( $refItem = $listItem->getRefItem() ) !== null ) {
-				$listMap[ $refItem->getContent() ][ $refItem->getType() ][ $listItem->getType() ] = $listItem;
+				$listMap[$refItem->getContent()][$refItem->getType()][$listItem->getType()] = $listItem;
 			}
 		}
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
 			{
 				$listItem = $listMap[$content][$type][$listtype];
 				$refItem = $listItem->getRefItem();
-				unset( $listItems[ $listItem->getId() ] );
+				unset( $listItems[$listItem->getId()] );
 			}
 			else
 			{

Please login to merge, or discard this patch.

src/Controller/Common/Product/Import/Csv/Processor/Attribute/Standard.php 2 patches

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -82,8 +82,7 @@  discard block
 block discarded – undo
 			foreach( $manager->searchItems( $search ) as $item ) {
 				$this->listTypes[$item->getCode()] = $item->getCode();
 			}
-		}
-		else
+		} else
 		{
 			$this->listTypes = array_flip( $this->listTypes );
 		}
@@ -144,8 +143,7 @@  discard block
 block discarded – undo
 				{
 					$listItem = $listMap[$code][$listtype];
 					unset( $listItems[ $listItem->getId() ] );
-				}
-				else
+				} else
 				{
 					$listItem = $listManager->createItem()->setType( $listtype );
 				}

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -123,7 +123,7 @@  discard block
 block discarded – undo
 		foreach( $listItems as $listItem )
 		{
 			if( ( $refItem = $listItem->getRefItem() ) !== null ) {
-				$listMap[ $refItem->getCode() ][ $listItem->getType() ] = $listItem;
+				$listMap[$refItem->getCode()][$listItem->getType()] = $listItem;
 			}
 		}
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
 				if( isset( $listMap[$code][$listtype] ) )
 				{
 					$listItem = $listMap[$code][$listtype];
-					unset( $listItems[ $listItem->getId() ] );
+					unset( $listItems[$listItem->getId()] );
 				}
 				else
 				{

Please login to merge, or discard this patch.

src/Controller/Common/Catalog/Import/Csv/Processor/Media/Standard.php 2 patches

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -81,8 +81,7 @@  discard block
 block discarded – undo
 			foreach( $manager->searchItems( $search ) as $item ) {
 				$this->listTypes[$item->getCode()] = $item->getCode();
 			}
-		}
-		else
+		} else
 		{
 			$this->listTypes = array_flip( $this->listTypes );
 		}
@@ -143,8 +142,7 @@  discard block
 block discarded – undo
 					$listItem = $listMap[$url][$type][$listtype];
 					$refItem = $listItem->getRefItem();
 					unset( $listItems[ $listItem->getId() ] );
-				}
-				else
+				} else
 				{
 					$listItem = $listManager->createItem()->setType( $listtype );
 					$refItem = $manager->createItem()->setType( $type );

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -120,7 +120,7 @@  discard block
 block discarded – undo
 		foreach( $listItems as $listItem )
 		{
 			if( ( $refItem = $listItem->getRefItem() ) !== null ) {
-				$listMap[ $refItem->getUrl() ][ $refItem->getType() ][ $listItem->getType() ] = $listItem;
+				$listMap[$refItem->getUrl()][$refItem->getType()][$listItem->getType()] = $listItem;
 			}
 		}
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
 				{
 					$listItem = $listMap[$url][$type][$listtype];
 					$refItem = $listItem->getRefItem();
-					unset( $listItems[ $listItem->getId() ] );
+					unset( $listItems[$listItem->getId()] );
 				}
 				else
 				{

Please login to merge, or discard this patch.

common/src/Controller/Common/Catalog/Import/Csv/Processor/Text/Standard.php 2 patches

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -81,8 +81,7 @@  discard block
 block discarded – undo
 			foreach( $manager->searchItems( $search ) as $item ) {
 				$this->listTypes[$item->getCode()] = $item->getCode();
 			}
-		}
-		else
+		} else
 		{
 			$this->listTypes = array_flip( $this->listTypes );
 		}
@@ -137,8 +136,7 @@  discard block
 block discarded – undo
 				$listItem = $listMap[$content][$type][$listtype];
 				$refItem = $listItem->getRefItem();
 				unset( $listItems[ $listItem->getId() ] );
-			}
-			else
+			} else
 			{
 				$listItem = $listManager->createItem()->setType( $listtype );
 				$refItem = $manager->createItem()->setType( $type );

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -118,7 +118,7 @@  discard block
 block discarded – undo
 		foreach( $listItems as $listItem )
 		{
 			if( ( $refItem = $listItem->getRefItem() ) !== null ) {
-				$listMap[ $refItem->getContent() ][ $refItem->getType() ][ $listItem->getType() ] = $listItem;
+				$listMap[$refItem->getContent()][$refItem->getType()][$listItem->getType()] = $listItem;
 			}
 		}
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
 			{
 				$listItem = $listMap[$content][$type][$listtype];
 				$refItem = $listItem->getRefItem();
-				unset( $listItems[ $listItem->getId() ] );
+				unset( $listItems[$listItem->getId()] );
 			}
 			else
 			{

Please login to merge, or discard this patch.

jobs/tests/Controller/Jobs/Coupon/Import/Csv/Code/FactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@
 block discarded – undo
 		$aimeos = \TestHelperJobs::getAimeos();
 
 		$obj = \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj);
+		$this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
 	}
 
 

Please login to merge, or discard this patch.

		@@ -123,7 +123,7 @@ discard block
		block discarded – undo
123	123	foreach( $listItems as $listItem )
124	124	{
125	125	if( ( $refItem = $listItem->getRefItem() ) !== null ) {
126		- $listMap[ $refItem->getCode() ][ $listItem->getType() ] = $listItem;
	126	+ $listMap[$refItem->getCode()][$listItem->getType()] = $listItem;
127	127	}
128	128	}
129	129
		@@ -143,7 +143,7 @@ discard block
		block discarded – undo
143	143	if( isset( $listMap[$code][$listtype] ) )
144	144	{
145	145	$listItem = $listMap[$code][$listtype];
146		- unset( $listItems[ $listItem->getId() ] );
	146	+ unset( $listItems[$listItem->getId()] );
147	147	}
148	148	else
149	149	{

		@@ -87,8 +87,7 @@
		block discarded – undo
87	87	foreach( $manager->searchItems( $search ) as $item ) {
88	88	$this->listTypes[$item->getCode()] = $item->getCode();
89	89	}
90		- }
91		- else
	90	+ } else
92	91	{
93	92	$this->listTypes = array_flip( $this->listTypes );
94	93	}

		@@ -91,8 +91,7 @@
		block discarded – undo
91	91	{
92	92	$item = $propMap[$value][$type];
93	93	unset( $items[ $item->getId() ] );
94		- }
95		- else
	94	+ } else
96	95	{
97	96	$item = $manager->createItem()->setType( $type );
98	97	}

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	$map = $this->getMappedChunk( $data, $this->getMapping() );
73	73
74	74	foreach( $items as $item ) {
75		- $propMap[ $item->getValue() ][ $item->getType() ] = $item;
	75	+ $propMap[$item->getValue()][$item->getType()] = $item;
76	76	}
77	77
78	78	foreach( $map as $list )
		@@ -90,7 +90,7 @@ discard block
		block discarded – undo
90	90	if( isset( $propMap[$value][$type] ) )
91	91	{
92	92	$item = $propMap[$value][$type];
93		- unset( $items[ $item->getId() ] );
	93	+ unset( $items[$item->getId()] );
94	94	}
95	95	else
96	96	{

		@@ -81,8 +81,7 @@ discard block
		block discarded – undo
81	81	foreach( $manager->searchItems( $search ) as $item ) {
82	82	$this->listTypes[$item->getCode()] = $item->getCode();
83	83	}
84		- }
85		- else
	84	+ } else
86	85	{
87	86	$this->listTypes = array_flip( $this->listTypes );
88	87	}
		@@ -143,8 +142,7 @@ discard block
		block discarded – undo
143	142	$listItem = $listMap[$url][$type][$listtype];
144	143	$refItem = $listItem->getRefItem();
145	144	unset( $listItems[ $listItem->getId() ] );
146		- }
147		- else
	145	+ } else
148	146	{
149	147	$listItem = $listManager->createItem()->setType( $listtype );
150	148	$refItem = $manager->createItem()->setType( $type );

		@@ -120,7 +120,7 @@ discard block
		block discarded – undo
120	120	foreach( $listItems as $listItem )
121	121	{
122	122	if( ( $refItem = $listItem->getRefItem() ) !== null ) {
123		- $listMap[ $refItem->getUrl() ][ $refItem->getType() ][ $listItem->getType() ] = $listItem;
	123	+ $listMap[$refItem->getUrl()][$refItem->getType()][$listItem->getType()] = $listItem;
124	124	}
125	125	}
126	126
		@@ -140,7 +140,7 @@ discard block
		block discarded – undo
140	140	{
141	141	$listItem = $listMap[$url][$type][$listtype];
142	142	$refItem = $listItem->getRefItem();
143		- unset( $listItems[ $listItem->getId() ] );
	143	+ unset( $listItems[$listItem->getId()] );
144	144	}
145	145	else
146	146	{

		@@ -118,7 +118,7 @@ discard block
		block discarded – undo
118	118	foreach( $listItems as $listItem )
119	119	{
120	120	if( ( $refItem = $listItem->getRefItem() ) !== null ) {
121		- $listMap[ $refItem->getValue() ][ $refItem->getType() ][ $listItem->getType() ] = $listItem;
	121	+ $listMap[$refItem->getValue()][$refItem->getType()][$listItem->getType()] = $listItem;
122	122	}
123	123	}
124	124
		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136	{
137	137	$listItem = $listMap[$value][$type][$listtype];
138	138	$refItem = $listItem->getRefItem();
139		- unset( $listItems[ $listItem->getId() ] );
	139	+ unset( $listItems[$listItem->getId()] );
140	140	}
141	141	else
142	142	{

		@@ -82,8 +82,7 @@ discard block
		block discarded – undo
82	82	foreach( $manager->searchItems( $search ) as $item ) {
83	83	$this->listTypes[$item->getCode()] = $item->getCode();
84	84	}
85		- }
86		- else
	85	+ } else
87	86	{
88	87	$this->listTypes = array_flip( $this->listTypes );
89	88	}
		@@ -144,8 +143,7 @@ discard block
		block discarded – undo
144	143	{
145	144	$listItem = $listMap[$code][$listtype];
146	145	unset( $listItems[ $listItem->getId() ] );
147		- }
148		- else
	146	+ } else
149	147	{
150	148	$listItem = $listManager->createItem()->setType( $listtype );
151	149	}

		@@ -17,7 +17,7 @@
		block discarded – undo
17	17	$aimeos = \TestHelperJobs::getAimeos();
18	18
19	19	$obj = \Aimeos\Controller\Jobs\Coupon\Import\Csv\Code\Factory::create( $context, $aimeos );
20		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj);
	20	+ $this->assertInstanceOf( '\\Aimeos\\Controller\\Jobs\\Iface', $obj );
21	21	}
22	22
23	23

aimeos / ai-controller-jobs

Push — master ( 475f2c...96cc40 )

Status

Category

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch