Inspection of "Don't throw invalid user exception just because ID..." - aimeos/ai-controller-frontend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f32c43...c49afe )

by Aimeos

created 2017-04-06 22:25 UTC

Status

Spacing +57 added lines, -57 removed lines patch added patch discarded remove patch

@@ -28,13 +28,13 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
 	 * @since 2017.04
 	 */
-	public function addItem( array $values )
+	public function addItem(array $values)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
 
 		$item = $manager->createItem();
-		$item->fromArray( $values );
-		$manager->saveItem( $item );
+		$item->fromArray($values);
+		$manager->saveItem($item);
 
 		return $item;
 	}
@@ -45,13 +45,13 @@  discard block
 block discarded – undo
 	 *
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
 	 */
-	public function createItem( array $values = [] )
+	public function createItem(array $values = [])
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
 
 		$item = $manager->createItem();
-		$item->fromArray( $values );
-		$item->setStatus( 1 );
+		$item->fromArray($values);
+		$item->setStatus(1);
 
 		return $item;
 	}
@@ -63,12 +63,12 @@  discard block
 block discarded – undo
 	 * @param string $id Unique customer ID
 	 * @since 2017.04
 	 */
-	public function deleteItem( $id )
+	public function deleteItem($id)
 	{
-		$this->checkUser( $id );
+		$this->checkUser($id);
 
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
-		$manager->deleteItem( $id );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
+		$manager->deleteItem($id);
 	}
 
 
@@ -80,15 +80,15 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
 	 * @since 2017.04
 	 */
-	public function editItem( $id, array $values )
+	public function editItem($id, array $values)
 	{
-		$this->checkUser( $id );
+		$this->checkUser($id);
 
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
 
-		$item = $manager->getItem( $id, [], true );
-		$item->fromArray( $values );
-		$manager->saveItem( $item );
+		$item = $manager->getItem($id, [], true);
+		$item->fromArray($values);
+		$manager->saveItem($item);
 
 		return $item;
 	}
@@ -102,17 +102,17 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
 	 * @since 2017.04
 	 */
-	public function getItem( $id = null, array $domains = [] )
+	public function getItem($id = null, array $domains = [])
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
 
-		if( $id == null ) {
-			return $manager->getItem( $this->getContext()->getUserId(), $domains, true );
+		if ($id == null) {
+			return $manager->getItem($this->getContext()->getUserId(), $domains, true);
 		}
 
-		$this->checkUser( $id );
+		$this->checkUser($id);
 
-		return $manager->getItem( $id, $domains, true );
+		return $manager->getItem($id, $domains, true);
 	}
 
 
@@ -126,9 +126,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
 	 * @since 2017.04
 	 */
-	public function findItem( $code, array $domains = [] )
+	public function findItem($code, array $domains = [])
 	{
-		return \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' )->findItem( $code, $domains );
+		return \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer')->findItem($code, $domains);
 	}
 
 
@@ -137,9 +137,9 @@  discard block
 block discarded – undo
 	 *
 	 * @param \Aimeos\MShop\Customer\Item\Iface Customer item
 	 */
-	public function saveItem( \Aimeos\MShop\Customer\Item\Iface $item )
+	public function saveItem(\Aimeos\MShop\Customer\Item\Iface $item)
 	{
-		\Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' )->saveItem( $item );
+		\Aimeos\MShop\Factory::createManager($this->getContext(), 'customer')->saveItem($item);
 	}
 
 
@@ -150,15 +150,15 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
 	 * @since 2017.04
 	 */
-	public function addAddressItem( array $values )
+	public function addAddressItem(array $values)
 	{
 		$context = $this->getContext();
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'customer/address' );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'customer/address');
 
 		$item = $manager->createItem();
-		$item->fromArray( $values );
-		$item->setParentId( $context->getUserId() );
-		$manager->saveItem( $item );
+		$item->fromArray($values);
+		$item->setParentId($context->getUserId());
+		$manager->saveItem($item);
 
 		return $item;
 	}
@@ -169,14 +169,14 @@  discard block
 block discarded – undo
 	 *
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
 	 */
-	public function createAddressItem( array $values = [] )
+	public function createAddressItem(array $values = [])
 	{
 		$context = $this->getContext();
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'customer/address' );
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'customer/address');
 
 		$item = $manager->createItem();
-		$item->fromArray( $values );
-		$item->setParentId( $context->getUserId() );
+		$item->fromArray($values);
+		$item->setParentId($context->getUserId());
 
 		return $item;
 	}
@@ -188,13 +188,13 @@  discard block
 block discarded – undo
 	 * @param string $id Unique customer address ID
 	 * @since 2017.04
 	 */
-	public function deleteAddressItem( $id )
+	public function deleteAddressItem($id)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer/address' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer/address');
 
-		$this->checkUser( $manager->getItem( $id, [], true )->getParentId() );
+		$this->checkUser($manager->getItem($id, [], true)->getParentId());
 
-		$manager->deleteItem( $id );
+		$manager->deleteItem($id);
 	}
 
 
@@ -206,15 +206,15 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
 	 * @since 2017.04
 	 */
-	public function editAddressItem( $id, array $values )
+	public function editAddressItem($id, array $values)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer/address' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer/address');
 
-		$item = $manager->getItem( $id, [], true );
-		$this->checkUser( $item->getParentId() );
+		$item = $manager->getItem($id, [], true);
+		$this->checkUser($item->getParentId());
 
-		$item->fromArray( $values );
-		$manager->saveItem( $item );
+		$item->fromArray($values);
+		$manager->saveItem($item);
 
 		return $item;
 	}
@@ -227,12 +227,12 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
 	 * @since 2017.04
 	 */
-	public function getAddressItem( $id )
+	public function getAddressItem($id)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer/address' );
-		$item = $manager->getItem( $id );
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer/address');
+		$item = $manager->getItem($id);
 
-		$this->checkUser( $item->getParentId() );
+		$this->checkUser($item->getParentId());
 
 		return $item;
 	}
@@ -243,9 +243,9 @@  discard block
 block discarded – undo
 	 *
 	 * @param \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
 	 */
-	public function saveAddressItem( \Aimeos\MShop\Customer\Item\Address\Iface $item )
+	public function saveAddressItem(\Aimeos\MShop\Customer\Item\Address\Iface $item)
 	{
-		\Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer/address' )->saveItem( $item );
+		\Aimeos\MShop\Factory::createManager($this->getContext(), 'customer/address')->saveItem($item);
 	}
 
 
@@ -255,12 +255,12 @@  discard block
 block discarded – undo
 	 * @param string $id Unique customer ID
 	 * @throws \Aimeos\Controller\Frontend\Customer\Exception If access isn't allowed
 	 */
-	protected function checkUser( $id )
+	protected function checkUser($id)
 	{
-		if( $id != $this->getContext()->getUserId() )
+		if ($id != $this->getContext()->getUserId())
 		{
-			$msg = sprintf( 'Not allowed to access customer data for ID "%1$s"', $id );
-			throw new \Aimeos\Controller\Frontend\Customer\Exception( $msg );
+			$msg = sprintf('Not allowed to access customer data for ID "%1$s"', $id);
+			throw new \Aimeos\Controller\Frontend\Customer\Exception($msg);
 		}
 	}
 }

Please login to merge, or discard this patch.

		@@ -28,13 +28,13 @@ discard block
		block discarded – undo
28	28	* @return \Aimeos\MShop\Customer\Item\Iface Customer item
29	29	* @since 2017.04
30	30	*/
31		- public function addItem( array $values )
	31	+ public function addItem(array $values)
32	32	{
33		- $manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
	33	+ $manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
34	34
35	35	$item = $manager->createItem();
36		- $item->fromArray( $values );
37		- $manager->saveItem( $item );
	36	+ $item->fromArray($values);
	37	+ $manager->saveItem($item);
38	38
39	39	return $item;
40	40	}
		@@ -45,13 +45,13 @@ discard block
		block discarded – undo
45	45	*
46	46	* @return \Aimeos\MShop\Customer\Item\Iface Customer item
47	47	*/
48		- public function createItem( array $values = [] )
	48	+ public function createItem(array $values = [])
49	49	{
50		- $manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
	50	+ $manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
51	51
52	52	$item = $manager->createItem();
53		- $item->fromArray( $values );
54		- $item->setStatus( 1 );
	53	+ $item->fromArray($values);
	54	+ $item->setStatus(1);
55	55
56	56	return $item;
57	57	}
		@@ -63,12 +63,12 @@ discard block
		block discarded – undo
63	63	* @param string $id Unique customer ID
64	64	* @since 2017.04
65	65	*/
66		- public function deleteItem( $id )
	66	+ public function deleteItem($id)
67	67	{
68		- $this->checkUser( $id );
	68	+ $this->checkUser($id);
69	69
70		- $manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
71		- $manager->deleteItem( $id );
	70	+ $manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
	71	+ $manager->deleteItem($id);
72	72	}
73	73
74	74
		@@ -80,15 +80,15 @@ discard block
		block discarded – undo
80	80	* @return \Aimeos\MShop\Customer\Item\Iface Customer item
81	81	* @since 2017.04
82	82	*/
83		- public function editItem( $id, array $values )
	83	+ public function editItem($id, array $values)
84	84	{
85		- $this->checkUser( $id );
	85	+ $this->checkUser($id);
86	86
87		- $manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
	87	+ $manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
88	88
89		- $item = $manager->getItem( $id, [], true );
90		- $item->fromArray( $values );
91		- $manager->saveItem( $item );
	89	+ $item = $manager->getItem($id, [], true);
	90	+ $item->fromArray($values);
	91	+ $manager->saveItem($item);
92	92
93	93	return $item;
94	94	}
		@@ -102,17 +102,17 @@ discard block
		block discarded – undo
102	102	* @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
103	103	* @since 2017.04
104	104	*/
105		- public function getItem( $id = null, array $domains = [] )
	105	+ public function getItem($id = null, array $domains = [])
106	106	{
107		- $manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' );
	107	+ $manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer');
108	108
109		- if( $id == null ) {
110		- return $manager->getItem( $this->getContext()->getUserId(), $domains, true );
	109	+ if ($id == null) {
	110	+ return $manager->getItem($this->getContext()->getUserId(), $domains, true);
111	111	}
112	112
113		- $this->checkUser( $id );
	113	+ $this->checkUser($id);
114	114
115		- return $manager->getItem( $id, $domains, true );
	115	+ return $manager->getItem($id, $domains, true);
116	116	}
117	117
118	118
		@@ -126,9 +126,9 @@ discard block
		block discarded – undo
126	126	* @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
127	127	* @since 2017.04
128	128	*/
129		- public function findItem( $code, array $domains = [] )
	129	+ public function findItem($code, array $domains = [])
130	130	{
131		- return \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' )->findItem( $code, $domains );
	131	+ return \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer')->findItem($code, $domains);
132	132	}
133	133
134	134
		@@ -137,9 +137,9 @@ discard block
		block discarded – undo
137	137	*
138	138	* @param \Aimeos\MShop\Customer\Item\Iface Customer item
139	139	*/
140		- public function saveItem( \Aimeos\MShop\Customer\Item\Iface $item )
	140	+ public function saveItem(\Aimeos\MShop\Customer\Item\Iface $item)
141	141	{
142		- \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer' )->saveItem( $item );
	142	+ \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer')->saveItem($item);
143	143	}
144	144
145	145
		@@ -150,15 +150,15 @@ discard block
		block discarded – undo
150	150	* @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
151	151	* @since 2017.04
152	152	*/
153		- public function addAddressItem( array $values )
	153	+ public function addAddressItem(array $values)
154	154	{
155	155	$context = $this->getContext();
156		- $manager = \Aimeos\MShop\Factory::createManager( $context, 'customer/address' );
	156	+ $manager = \Aimeos\MShop\Factory::createManager($context, 'customer/address');
157	157
158	158	$item = $manager->createItem();
159		- $item->fromArray( $values );
160		- $item->setParentId( $context->getUserId() );
161		- $manager->saveItem( $item );
	159	+ $item->fromArray($values);
	160	+ $item->setParentId($context->getUserId());
	161	+ $manager->saveItem($item);
162	162
163	163	return $item;
164	164	}
		@@ -169,14 +169,14 @@ discard block
		block discarded – undo
169	169	*
170	170	* @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
171	171	*/
172		- public function createAddressItem( array $values = [] )
	172	+ public function createAddressItem(array $values = [])
173	173	{
174	174	$context = $this->getContext();
175		- $manager = \Aimeos\MShop\Factory::createManager( $context, 'customer/address' );
	175	+ $manager = \Aimeos\MShop\Factory::createManager($context, 'customer/address');
176	176
177	177	$item = $manager->createItem();
178		- $item->fromArray( $values );
179		- $item->setParentId( $context->getUserId() );
	178	+ $item->fromArray($values);
	179	+ $item->setParentId($context->getUserId());
180	180
181	181	return $item;
182	182	}
		@@ -188,13 +188,13 @@ discard block
		block discarded – undo
188	188	* @param string $id Unique customer address ID
189	189	* @since 2017.04
190	190	*/
191		- public function deleteAddressItem( $id )
	191	+ public function deleteAddressItem($id)
192	192	{
193		- $manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer/address' );
	193	+ $manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer/address');
194	194
195		- $this->checkUser( $manager->getItem( $id, [], true )->getParentId() );
	195	+ $this->checkUser($manager->getItem($id, [], true)->getParentId());
196	196
197		- $manager->deleteItem( $id );
	197	+ $manager->deleteItem($id);
198	198	}
199	199
200	200
		@@ -206,15 +206,15 @@ discard block
		block discarded – undo
206	206	* @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
207	207	* @since 2017.04
208	208	*/
209		- public function editAddressItem( $id, array $values )
	209	+ public function editAddressItem($id, array $values)
210	210	{
211		- $manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer/address' );
	211	+ $manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer/address');
212	212
213		- $item = $manager->getItem( $id, [], true );
214		- $this->checkUser( $item->getParentId() );
	213	+ $item = $manager->getItem($id, [], true);
	214	+ $this->checkUser($item->getParentId());
215	215
216		- $item->fromArray( $values );
217		- $manager->saveItem( $item );
	216	+ $item->fromArray($values);
	217	+ $manager->saveItem($item);
218	218
219	219	return $item;
220	220	}
		@@ -227,12 +227,12 @@ discard block
		block discarded – undo
227	227	* @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
228	228	* @since 2017.04
229	229	*/
230		- public function getAddressItem( $id )
	230	+ public function getAddressItem($id)
231	231	{
232		- $manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer/address' );
233		- $item = $manager->getItem( $id );
	232	+ $manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer/address');
	233	+ $item = $manager->getItem($id);
234	234
235		- $this->checkUser( $item->getParentId() );
	235	+ $this->checkUser($item->getParentId());
236	236
237	237	return $item;
238	238	}
		@@ -243,9 +243,9 @@ discard block
		block discarded – undo
243	243	*
244	244	* @param \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
245	245	*/
246		- public function saveAddressItem( \Aimeos\MShop\Customer\Item\Address\Iface $item )
	246	+ public function saveAddressItem(\Aimeos\MShop\Customer\Item\Address\Iface $item)
247	247	{
248		- \Aimeos\MShop\Factory::createManager( $this->getContext(), 'customer/address' )->saveItem( $item );
	248	+ \Aimeos\MShop\Factory::createManager($this->getContext(), 'customer/address')->saveItem($item);
249	249	}
250	250
251	251
		@@ -255,12 +255,12 @@ discard block
		block discarded – undo
255	255	* @param string $id Unique customer ID
256	256	* @throws \Aimeos\Controller\Frontend\Customer\Exception If access isn't allowed
257	257	*/
258		- protected function checkUser( $id )
	258	+ protected function checkUser($id)
259	259	{
260		- if( $id != $this->getContext()->getUserId() )
	260	+ if ($id != $this->getContext()->getUserId())
261	261	{
262		- $msg = sprintf( 'Not allowed to access customer data for ID "%1$s"', $id );
263		- throw new \Aimeos\Controller\Frontend\Customer\Exception( $msg );
	262	+ $msg = sprintf('Not allowed to access customer data for ID "%1$s"', $id);
	263	+ throw new \Aimeos\Controller\Frontend\Customer\Exception($msg);
264	264	}
265	265	}
266	266	}

aimeos / ai-controller-frontend

Push — master ( f32c43...c49afe )

Status

Category

Spacing +57 added lines, -57 removed lines patch added patch discarded remove patch