Inspection of "Implemented managing coupons in basket" - aimeos/ai-client-jsonapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8c9c9d...8ff506 )

by Aimeos

created 2017-03-21 16:02 UTC

Status

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -199,6 +199,9 @@
 block discarded – undo
 	}
 
 
+	/**
+	 * @param string $code
+	 */
 	protected function addProduct( $code )
 	{
 		$prodId = \Aimeos\MShop\Factory::createManager( $this->context, 'product' )->findItem( $code )->getId();

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Basket/Coupon/Standard.php 1 patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

@@ -78,8 +78,7 @@  discard block
 block discarded – undo
 
 					$this->controller->deleteCoupon( $entry->id );
 				}
-			}
-			else
+			} else
 			{
 				$this->controller->deleteCoupon( $relId );
 			}
@@ -89,16 +88,14 @@  discard block
 block discarded – undo
 			$view->total = 1;
 
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(
@@ -149,16 +146,14 @@  discard block
 block discarded – undo
 			$view->total = 1;
 
 			$status = 201;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Basket/Product/Standard.php 1 patch

Braces +10 added lines, -20 removed lines patch added patch discarded remove patch

@@ -78,8 +78,7 @@  discard block
 block discarded – undo
 
 					$this->controller->deleteProduct( $entry->id );
 				}
-			}
-			else
+			} else
 			{
 				$this->controller->deleteProduct( $relId );
 			}
@@ -89,16 +88,14 @@  discard block
 block discarded – undo
 			$view->total = 1;
 
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(
@@ -142,8 +139,7 @@  discard block
 block discarded – undo
 						}
 					}
 				}
-			}
-			catch( \Aimeos\MShop\Exception $e )
+			} catch( \Aimeos\MShop\Exception $e )
 			{
 				$basket = $this->controller->setType( $id )->get();
 				$methods = 'DELETE,GET,PATCH,POST';
@@ -159,16 +155,14 @@  discard block
 block discarded – undo
 
 			$view->total = count( $view->items );
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(
@@ -253,16 +247,14 @@  discard block
 block discarded – undo
 			$view->total = 1;
 
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(
@@ -321,16 +313,14 @@  discard block
 block discarded – undo
 			$view->total = 1;
 
 			$status = 201;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

		@@ -78,8 +78,7 @@ discard block
		block discarded – undo
78	78
79	79	$this->controller->deleteCoupon( $entry->id );
80	80	}
81		- }
82		- else
	81	+ } else
83	82	{
84	83	$this->controller->deleteCoupon( $relId );
85	84	}
		@@ -89,16 +88,14 @@ discard block
		block discarded – undo
89	88	$view->total = 1;
90	89
91	90	$status = 200;
92		- }
93		- catch( \Aimeos\MShop\Exception $e )
	91	+ } catch( \Aimeos\MShop\Exception $e )
94	92	{
95	93	$status = 404;
96	94	$view->errors = array( array(
97	95	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
98	96	'detail' => $e->getTraceAsString(),
99	97	) );
100		- }
101		- catch( \Exception $e )
	98	+ } catch( \Exception $e )
102	99	{
103	100	$status = 500;
104	101	$view->errors = array( array(
		@@ -149,16 +146,14 @@ discard block
		block discarded – undo
149	146	$view->total = 1;
150	147
151	148	$status = 201;
152		- }
153		- catch( \Aimeos\MShop\Exception $e )
	149	+ } catch( \Aimeos\MShop\Exception $e )
154	150	{
155	151	$status = 404;
156	152	$view->errors = array( array(
157	153	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
158	154	'detail' => $e->getTraceAsString(),
159	155	) );
160		- }
161		- catch( \Exception $e )
	156	+ } catch( \Exception $e )
162	157	{
163	158	$status = 500;
164	159	$view->errors = array( array(

		@@ -78,8 +78,7 @@ discard block
		block discarded – undo
78	78
79	79	$this->controller->deleteProduct( $entry->id );
80	80	}
81		- }
82		- else
	81	+ } else
83	82	{
84	83	$this->controller->deleteProduct( $relId );
85	84	}
		@@ -89,16 +88,14 @@ discard block
		block discarded – undo
89	88	$view->total = 1;
90	89
91	90	$status = 200;
92		- }
93		- catch( \Aimeos\MShop\Exception $e )
	91	+ } catch( \Aimeos\MShop\Exception $e )
94	92	{
95	93	$status = 404;
96	94	$view->errors = array( array(
97	95	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
98	96	'detail' => $e->getTraceAsString(),
99	97	) );
100		- }
101		- catch( \Exception $e )
	98	+ } catch( \Exception $e )
102	99	{
103	100	$status = 500;
104	101	$view->errors = array( array(
		@@ -142,8 +139,7 @@ discard block
		block discarded – undo
142	139	}
143	140	}
144	141	}
145		- }
146		- catch( \Aimeos\MShop\Exception $e )
	142	+ } catch( \Aimeos\MShop\Exception $e )
147	143	{
148	144	$basket = $this->controller->setType( $id )->get();
149	145	$methods = 'DELETE,GET,PATCH,POST';
		@@ -159,16 +155,14 @@ discard block
		block discarded – undo
159	155
160	156	$view->total = count( $view->items );
161	157	$status = 200;
162		- }
163		- catch( \Aimeos\MShop\Exception $e )
	158	+ } catch( \Aimeos\MShop\Exception $e )
164	159	{
165	160	$status = 404;
166	161	$view->errors = array( array(
167	162	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
168	163	'detail' => $e->getTraceAsString(),
169	164	) );
170		- }
171		- catch( \Exception $e )
	165	+ } catch( \Exception $e )
172	166	{
173	167	$status = 500;
174	168	$view->errors = array( array(
		@@ -253,16 +247,14 @@ discard block
		block discarded – undo
253	247	$view->total = 1;
254	248
255	249	$status = 200;
256		- }
257		- catch( \Aimeos\MShop\Exception $e )
	250	+ } catch( \Aimeos\MShop\Exception $e )
258	251	{
259	252	$status = 404;
260	253	$view->errors = array( array(
261	254	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
262	255	'detail' => $e->getTraceAsString(),
263	256	) );
264		- }
265		- catch( \Exception $e )
	257	+ } catch( \Exception $e )
266	258	{
267	259	$status = 500;
268	260	$view->errors = array( array(
		@@ -321,16 +313,14 @@ discard block
		block discarded – undo
321	313	$view->total = 1;
322	314
323	315	$status = 201;
324		- }
325		- catch( \Aimeos\MShop\Exception $e )
	316	+ } catch( \Aimeos\MShop\Exception $e )
326	317	{
327	318	$status = 404;
328	319	$view->errors = array( array(
329	320	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
330	321	'detail' => $e->getTraceAsString(),
331	322	) );
332		- }
333		- catch( \Exception $e )
	323	+ } catch( \Exception $e )
334	324	{
335	325	$status = 500;
336	326	$view->errors = array( array(

		@@ -199,6 +199,9 @@
		block discarded – undo
199	199	}
200	200
201	201
	202	+ /**
	203	+ * @param string $code
	204	+ */
202	205	protected function addProduct( $code )
203	206	{
204	207	$prodId = \Aimeos\MShop\Factory::createManager( $this->context, 'product' )->findItem( $code )->getId();

aimeos / ai-client-jsonapi

Push — master ( 8c9c9d...8ff506 )

Status

Category

Doc Comments +3 added lines patch added patch discarded remove patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

Braces +10 added lines, -20 removed lines patch added patch discarded remove patch