Inspection of "Improved code for moving address, media, price and..." - aimeos/ai-admin-jqadm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fd425f...7bbaf8 )

by Aimeos

created 2019-09-11 13:55 UTC

Status

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					v-bind:aria-controls="'item-media-group-data-' + idx" aria-expanded="false">
 					<div class="card-tools-left">
 						<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
 						</div>
 					</div>
 					<span class="item-label header-label" v-html="getLabel(idx)"></span>
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 						</div>
 						<div v-if="!checkSite('attribute.lists.siteid', idx)"
 							class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 							v-on:click.stop="removeItem(idx)">
 						</div>
 					</div>
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 								v-bind:name="'<?= $enc->attr( $this->formparam( array( 'media', 'idx', 'media.url' ) ) ); ?>'.replace( 'idx', idx )"
 								v-model="items[idx]['media.url']" />
 							<img v-if="items[idx]['media.preview']" class="item-preview"
-								v-bind:src="getUrl('<?= $this->content('') ?>', items[idx]['media.preview'])"
+								v-bind:src="getUrl('<?= $this->content( '' ) ?>', items[idx]['media.preview'])"
 								v-bind:alt="items[idx]['media.label']" />
 							<p v-else class="item-preview">
 								{{ items[idx]['media.label'] || '<?= $enc->html( $this->translate( 'admin', 'Select file' ) ) ?>' }}
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
 					<div v-on:click="toggle(idx)" class="col-xl-12 advanced" v-bind:class="{ 'collapsed': !advanced[idx] }">
 						<div class="card-tools-left">
 							<div class="btn act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-								title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data') ); ?>">
+								title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data' ) ); ?>">
 							</div>
 						</div>
 						<span class="header-label"><?= $enc->html( $this->translate( 'admin', 'Advanced' ) ); ?></span>
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
 									</th>
 									<th class="actions">
 										<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-											title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+											title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 											v-bind:readonly="checkSite('attribute.lists.siteid', idx)"
 											v-on:click="addConfig(idx)" >
 										</div>
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
 									<td class="actions">
 										<div v-if="!checkSite('attribute.lists.siteid', idx)" v-on:click="removeConfig(idx, pos)"
 											class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-											title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
+											title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
 										</div>
 									</td>
 								</tr>
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
 
 		<div class="card-tools-more">
 			<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-				title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+				title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 				v-on:click="addItem('attribute.lists.')" >
 			</div>
 		</div>

Please login to merge, or discard this patch.

admin/jqadm/templates/service/item-text-standard.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					v-bind:aria-controls="'item-text-group-data-' + idx" aria-expanded="false">
 					<div class="card-tools-left">
 						<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
 						</div>
 					</div>
 					<span class="item-label header-label" v-html="getLabel(idx)"></span>
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 						</div>
 						<div v-if="!checkSite('service.lists.siteid', idx)"
 							class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 							v-on:click.stop="removeItem(idx)">
 						</div>
 					</div>
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
 					<div v-on:click="toggle(idx)" class="col-xl-12 advanced" v-bind:class="{ 'collapsed': !advanced[idx] }">
 						<div class="card-tools-left">
 							<div class="btn act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-								title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data') ); ?>">
+								title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data' ) ); ?>">
 							</div>
 						</div>
 						<span class="header-label"><?= $enc->html( $this->translate( 'admin', 'Advanced' ) ); ?></span>
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
 									</th>
 									<th class="actions">
 										<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-											title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+											title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 											v-bind:readonly="checkSite('service.lists.siteid', idx)"
 											v-on:click="addConfig(idx)" >
 										</div>
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
 									<td class="actions">
 										<div v-if="!checkSite('service.lists.siteid', idx)" v-on:click="removeConfig(idx, pos)"
 											class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-											title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
+											title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
 										</div>
 									</td>
 								</tr>
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
 
 		<div class="card-tools-more">
 			<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-				title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+				title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 				v-on:click="addItem('service.lists.')" >
 			</div>
 		</div>

Please login to merge, or discard this patch.

admin/jqadm/templates/customer/item-address-standard.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -32,14 +32,14 @@  discard block
 block discarded – undo
 					v-bind:aria-controls="'item-address-group-data-' + idx" aria-expanded="false">
 					<div class="card-tools-left">
 						<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
 						</div>
 					</div>
 					<span class="item-label header-label">{{ getLabel(idx, 'customer.address.') }}</span>
 					&nbsp;
 					<div class="card-tools-right">
 						<div class="btn btn-card-header act-copy fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Duplicate entry (Ctrl+D)') ); ?>"
+							title="<?= $enc->attr( $this->translate( 'admin', 'Duplicate entry (Ctrl+D)' ) ); ?>"
 							v-on:click.stop="duplicateItem(idx)">
 						</div>
 						<div v-if="!checkSite('customer.address.siteid', idx)"
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
 						</div>
 						<div v-if="!checkSite('customer.address.siteid', idx)"
 							class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 							v-on:click="removeItem(idx)">
 						</div>
 					</div>
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
 
 		<div class="card-tools-more">
 				<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-					title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+					title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 					v-on:click="addItem('customer.address.')" >
 				</div>
 			</div>

Please login to merge, or discard this patch.

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	v-bind:aria-controls="'item-media-group-data-' + idx" aria-expanded="false">
31	31	<div class="card-tools-left">
32	32	<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
33		- title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
	33	+ title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
34	34	</div>
35	35	</div>
36	36	<span class="item-label header-label" v-html="getLabel(idx)"></span>
		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41	</div>
42	42	<div v-if="!checkSite('attribute.lists.siteid', idx)"
43	43	class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
44		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	44	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
45	45	v-on:click.stop="removeItem(idx)">
46	46	</div>
47	47	</div>
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	v-bind:name="'<?= $enc->attr( $this->formparam( array( 'media', 'idx', 'media.url' ) ) ); ?>'.replace( 'idx', idx )"
64	64	v-model="items[idx]['media.url']" />
65	65	<img v-if="items[idx]['media.preview']" class="item-preview"
66		- v-bind:src="getUrl('<?= $this->content('') ?>', items[idx]['media.preview'])"
	66	+ v-bind:src="getUrl('<?= $this->content( '' ) ?>', items[idx]['media.preview'])"
67	67	v-bind:alt="items[idx]['media.label']" />
68	68	<p v-else class="item-preview">
69	69	{{ items[idx]['media.label'] \|\| '<?= $enc->html( $this->translate( 'admin', 'Select file' ) ) ?>' }}
		@@ -172,7 +172,7 @@ discard block
		block discarded – undo
172	172	<div v-on:click="toggle(idx)" class="col-xl-12 advanced" v-bind:class="{ 'collapsed': !advanced[idx] }">
173	173	<div class="card-tools-left">
174	174	<div class="btn act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
175		- title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data') ); ?>">
	175	+ title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data' ) ); ?>">
176	176	</div>
177	177	</div>
178	178	<span class="header-label"><?= $enc->html( $this->translate( 'admin', 'Advanced' ) ); ?></span>
		@@ -251,7 +251,7 @@ discard block
		block discarded – undo
251	251	</th>
252	252	<th class="actions">
253	253	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
254		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	254	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
255	255	v-bind:readonly="checkSite('attribute.lists.siteid', idx)"
256	256	v-on:click="addConfig(idx)" >
257	257	</div>
		@@ -278,7 +278,7 @@ discard block
		block discarded – undo
278	278	<td class="actions">
279	279	<div v-if="!checkSite('attribute.lists.siteid', idx)" v-on:click="removeConfig(idx, pos)"
280	280	class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
281		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
	281	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
282	282	</div>
283	283	</td>
284	284	</tr>
		@@ -295,7 +295,7 @@ discard block
		block discarded – undo
295	295
296	296	<div class="card-tools-more">
297	297	<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
298		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	298	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
299	299	v-on:click="addItem('attribute.lists.')" >
300	300	</div>
301	301	</div>

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	v-bind:aria-controls="'item-text-group-data-' + idx" aria-expanded="false">
31	31	<div class="card-tools-left">
32	32	<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
33		- title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
	33	+ title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
34	34	</div>
35	35	</div>
36	36	<span class="item-label header-label" v-html="getLabel(idx)"></span>
		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41	</div>
42	42	<div v-if="!checkSite('service.lists.siteid', idx)"
43	43	class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
44		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	44	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
45	45	v-on:click.stop="removeItem(idx)">
46	46	</div>
47	47	</div>
		@@ -179,7 +179,7 @@ discard block
		block discarded – undo
179	179	<div v-on:click="toggle(idx)" class="col-xl-12 advanced" v-bind:class="{ 'collapsed': !advanced[idx] }">
180	180	<div class="card-tools-left">
181	181	<div class="btn act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
182		- title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data') ); ?>">
	182	+ title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data' ) ); ?>">
183	183	</div>
184	184	</div>
185	185	<span class="header-label"><?= $enc->html( $this->translate( 'admin', 'Advanced' ) ); ?></span>
		@@ -261,7 +261,7 @@ discard block
		block discarded – undo
261	261	</th>
262	262	<th class="actions">
263	263	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
264		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	264	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
265	265	v-bind:readonly="checkSite('service.lists.siteid', idx)"
266	266	v-on:click="addConfig(idx)" >
267	267	</div>
		@@ -288,7 +288,7 @@ discard block
		block discarded – undo
288	288	<td class="actions">
289	289	<div v-if="!checkSite('service.lists.siteid', idx)" v-on:click="removeConfig(idx, pos)"
290	290	class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
291		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
	291	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
292	292	</div>
293	293	</td>
294	294	</tr>
		@@ -305,7 +305,7 @@ discard block
		block discarded – undo
305	305
306	306	<div class="card-tools-more">
307	307	<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
308		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	308	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
309	309	v-on:click="addItem('service.lists.')" >
310	310	</div>
311	311	</div>

		@@ -32,14 +32,14 @@ discard block
		block discarded – undo
32	32	v-bind:aria-controls="'item-address-group-data-' + idx" aria-expanded="false">
33	33	<div class="card-tools-left">
34	34	<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
35		- title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
	35	+ title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
36	36	</div>
37	37	</div>
38	38	<span class="item-label header-label">{{ getLabel(idx, 'customer.address.') }}</span>
39	39
40	40	<div class="card-tools-right">
41	41	<div class="btn btn-card-header act-copy fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
42		- title="<?= $enc->attr( $this->translate( 'admin', 'Duplicate entry (Ctrl+D)') ); ?>"
	42	+ title="<?= $enc->attr( $this->translate( 'admin', 'Duplicate entry (Ctrl+D)' ) ); ?>"
43	43	v-on:click.stop="duplicateItem(idx)">
44	44	</div>
45	45	<div v-if="!checkSite('customer.address.siteid', idx)"
		@@ -48,7 +48,7 @@ discard block
		block discarded – undo
48	48	</div>
49	49	<div v-if="!checkSite('customer.address.siteid', idx)"
50	50	class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
51		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	51	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
52	52	v-on:click="removeItem(idx)">
53	53	</div>
54	54	</div>
		@@ -343,7 +343,7 @@ discard block
		block discarded – undo
343	343
344	344	<div class="card-tools-more">
345	345	<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
346		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	346	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
347	347	v-on:click="addItem('customer.address.')" >
348	348	</div>
349	349	</div>

aimeos / ai-admin-jqadm

Push — master ( fd425f...7bbaf8 )

Status

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch