agoalofalife / bpm-online

src/Actions/Create.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use agoalofalife\bpm\Assistants\QueryBuilder;
 use agoalofalife\bpm\Contracts\Action;
 use agoalofalife\bpm\Contracts\ActionSet;
-use agoalofalife\bpm\Contracts\Authentication;
 use agoalofalife\bpm\KernelBpm;
 
 

Indentation +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 
         $this->headers()->getCookie()->body()->httpErrorsFalse()->get();
         $response   =  $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
-                       $this->headers()->getCookie()->body()->httpErrorsFalse()->get()
+                        $this->headers()->getCookie()->body()->httpErrorsFalse()->get()
         );
         $body       = $response->getBody();
         $this->kernel->getHandler()->parse($body->getContents());

Spacing +3 added lines, -3 removed lines

@@ -55,11 +55,11 @@
     {
         $parameters = str_replace(' ', '%20', $this->url);
 
-        $url        = $this->kernel->getCollection() . $parameters;
-        $urlHome    = config($this->kernel->getPrefixConfig() . '.UrlHome');
+        $url        = $this->kernel->getCollection().$parameters;
+        $urlHome    = config($this->kernel->getPrefixConfig().'.UrlHome');
 
         $this->headers()->getCookie()->body()->httpErrorsFalse()->get();
-        $response   =  $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
+        $response   = $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome.$url,
                        $this->headers()->getCookie()->body()->httpErrorsFalse()->get()
         );
         $body       = $response->getBody();

src/Actions/Delete.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
     }
 
     /**
-     * @return \agoalofalife\bpm\Contracts\Handler
+     * @return \Illuminate\Container\Container
      */
     public function processData()
     {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use agoalofalife\bpm\Assistants\QueryBuilder;
 use agoalofalife\bpm\Contracts\Action;
 use agoalofalife\bpm\Contracts\ActionGet;
-use agoalofalife\bpm\Contracts\Authentication;
 use agoalofalife\bpm\KernelBpm;
 
 /**

Indentation +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 
 
         $response =  $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
-                     $this->headers()->getCookie()->httpErrorsFalse()->get()
+                        $this->headers()->getCookie()->httpErrorsFalse()->get()
         );
 
         $body = $response->getBody();

Spacing +4 added lines, -4 removed lines

@@ -63,18 +63,18 @@
     {
         $parameters = str_replace(' ', '%20', $this->url);
 
-        $url        = $this->kernel->getCollection() . $parameters;
-        $urlHome    = config($this->kernel->getPrefixConfig() . '.UrlHome');
+        $url        = $this->kernel->getCollection().$parameters;
+        $urlHome    = config($this->kernel->getPrefixConfig().'.UrlHome');
 
 
-        $response =  $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
+        $response = $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome.$url,
                      $this->headers()->getCookie()->httpErrorsFalse()->get()
         );
 
         $body = $response->getBody();
         $this->kernel->getHandler()->parse($body->getContents());
 
-        if ( $response->getStatusCode() == 401 && $response->getReasonPhrase() == 'Unauthorized' )
+        if ($response->getStatusCode() == 401 && $response->getReasonPhrase() == 'Unauthorized')
         {
             $this->kernel->authentication();
             $this->query();

src/Actions/Read.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     }
 
     /**
-     * @return array url -> string , http_type -> string
+     * @return \Illuminate\Container\Container url -> string , http_type -> string
      */
     public function processData()
     {

Indentation +2 added lines, -2 removed lines

@@ -101,7 +101,7 @@ 
             }
             $ParameterQuery.=  " ".$param;
         }
-         $this->concatenationUrlCurl($ParameterQuery);
+            $this->concatenationUrlCurl($ParameterQuery);
 
         return $this;
     }
@@ -147,7 +147,7 @@ 
         $urlHome      = config($this->kernel->getPrefixConfig() . '.UrlHome');
 
         $response     = $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
-                         $this->debug()->headers()->getCookie()->httpErrorsFalse()->get()
+                            $this->debug()->headers()->getCookie()->httpErrorsFalse()->get()
         );
         $body         = $response->getBody();
 

Spacing +10 added lines, -10 removed lines

@@ -75,8 +75,8 @@ 
      */
     public function filterConstructor($strRequest)
     {
-        $ParameterQuery =  '$filter=';
-        $ParameterQuery.=  $strRequest;
+        $ParameterQuery = '$filter=';
+        $ParameterQuery .= $strRequest;
         $this->concatenationUrlCurl($ParameterQuery);
         return $this;
     }
@@ -93,13 +93,13 @@ 
     public function orderBy($whatSort, $param = 'asc')
     {
         $ParameterQuery = '$orderby=';
-        $ParameterQuery.=  ucfirst($whatSort);
+        $ParameterQuery .= ucfirst($whatSort);
 
-        if ( empty($param) === false ) {
+        if (empty($param) === false) {
             if ($param != 'desc' && $param != 'asc') {
                 throw new \Exception('no valid orderby parameters');
             }
-            $ParameterQuery.=  " ".$param;
+            $ParameterQuery .= " ".$param;
         }
          $this->concatenationUrlCurl($ParameterQuery);
 
@@ -130,7 +130,7 @@ 
      */
     public function amount($amountMax = null)
     {
-        Assert::that($amountMax,'You must specify a numeric parameter for the amount of the method')->integer();
+        Assert::that($amountMax, 'You must specify a numeric parameter for the amount of the method')->integer();
         $ParameterQuery = '$top='.$amountMax;
         $this->concatenationUrlCurl($ParameterQuery);
         return $this;
@@ -143,17 +143,17 @@ 
     private function query()
     {
         $parameters   = str_replace(' ', '%20', $this->url);
-        $url          = $this->kernel->getCollection() . $parameters;
-        $urlHome      = config($this->kernel->getPrefixConfig() . '.UrlHome');
+        $url          = $this->kernel->getCollection().$parameters;
+        $urlHome      = config($this->kernel->getPrefixConfig().'.UrlHome');
 
-        $response     = $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
+        $response     = $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome.$url,
                          $this->debug()->headers()->getCookie()->httpErrorsFalse()->get()
         );
         $body         = $response->getBody();
 
         $this->kernel->getHandler()->parse($body->getContents());
 
-        if ( $response->getStatusCode() == 401 && $response->getReasonPhrase() == 'Unauthorized' )
+        if ($response->getStatusCode() == 401 && $response->getReasonPhrase() == 'Unauthorized')
         {
             $this->kernel->authentication();
             $this->query();

src/Actions/Update.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     }
 
     /**
-     * @return \agoalofalife\bpm\Contracts\Handler
+     * @return \Illuminate\Container\Container
      */
     public function processData()
     {

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use agoalofalife\bpm\Contracts\Action;
 use agoalofalife\bpm\Contracts\ActionGet;
 use agoalofalife\bpm\Contracts\ActionSet;
-use agoalofalife\bpm\Contracts\Authentication;
 use agoalofalife\bpm\KernelBpm;
 
 /**

Indentation +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
         $urlHome    = config($this->kernel->getPrefixConfig() . '.UrlHome');
 
         $response   =  $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
-                       $this->headers()->getCookie()->body()->httpErrorsFalse()->get()
+                        $this->headers()->getCookie()->body()->httpErrorsFalse()->get()
         );
         $body       = $response->getBody();
 

Spacing +4 added lines, -4 removed lines

@@ -80,17 +80,17 @@
     private function query()
     {
         $parameters = str_replace(' ', '%20', $this->url);
-        $url        = $this->kernel->getCollection() . $parameters;
-        $urlHome    = config($this->kernel->getPrefixConfig() . '.UrlHome');
+        $url        = $this->kernel->getCollection().$parameters;
+        $urlHome    = config($this->kernel->getPrefixConfig().'.UrlHome');
 
-        $response   =  $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
+        $response   = $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome.$url,
                        $this->headers()->getCookie()->body()->httpErrorsFalse()->get()
         );
         $body       = $response->getBody();
 
         $this->kernel->getHandler()->parse($body->getContents());
 
-        if ( $response->getStatusCode() == 401 && $response->getReasonPhrase() == 'Unauthorized' )
+        if ($response->getStatusCode() == 401 && $response->getReasonPhrase() == 'Unauthorized')
         {
             $this->kernel->authentication();
             $this->query();

src/KernelBpm.php

Doc Comments +5 added lines, -5 removed lines

@@ -124,7 +124,7 @@ 
     }
 
     /**
-     * @return Handler
+     * @return \Illuminate\Container\Container
      */
     public function getHandler()
     {
@@ -134,7 +134,7 @@ 
     /**
      * Set the response handler
      * @param string $typeHandler default xml
-     * @return Action
+     * @return \Illuminate\Container\Container
      */
     public function setHandler($typeHandler = 'xml')
     {
@@ -152,7 +152,7 @@ 
     }
 
     /**
-     * @param $typeAction string
+     * @param string $typeAction string
      * @return Action
      */
     public function setAction($typeAction)
@@ -198,7 +198,7 @@ 
     /**
      * Set collection for correct query
      * @param string $collection
-     * @return mixed
+     * @return string
      * @throws \Exception
      */
     public function setCollection($collection)
@@ -228,7 +228,7 @@ 
         return app()->make(ClientInterface::class);
     }
     /**
-     * @param $action
+     * @param string $action
      * @return array
      */
     private function splitAction($action)

Spacing +8 added lines, -8 removed lines

@@ -36,7 +36,7 @@ 
  */
 class KernelBpm
 {
-    const PATH_LOG = __DIR__ . '/resource/logs/bpm.log';
+    const PATH_LOG = __DIR__.'/resource/logs/bpm.log';
 
     protected $action = [
         'create' =>  Create::class,
@@ -109,7 +109,7 @@ 
      */
     public function loadConfiguration(SourceConfiguration $configuration)
     {
-        config()->set(  $this->prefixConfiguration = $configuration->getName(), $configuration->get());
+        config()->set($this->prefixConfiguration = $configuration->getName(), $configuration->get());
     }
 
     /**
@@ -159,7 +159,7 @@ 
     {
         Assertion::keyIsset($this->action, $typeAction);
 
-        $this->currentAction  =  app()->make( $this->action[$typeAction] );
+        $this->currentAction = app()->make($this->action[$typeAction]);
 
         return $this->currentAction;
     }
@@ -175,7 +175,7 @@ 
 
          extract($this->splitAction($action));
 
-         $action  = $this->setAction($action);
+         $action = $this->setAction($action);
          $this->setHandler($handler);
 
         $action->injectionKernel($this);
@@ -205,8 +205,8 @@ 
     {
         try {
             Assertion::regex($collection, '/[A-z]+Collection$/');
-        } catch(AssertionFailedException $e) {
-           throw new \Exception("Expected word 'Collection' in parameter method setCollection received : " .  $e->getValue());
+        } catch (AssertionFailedException $e) {
+           throw new \Exception("Expected word 'Collection' in parameter method setCollection received : ".$e->getValue());
         }
 
         return $this->collection = $collection;
@@ -237,8 +237,8 @@ 
 
         // verification values
         Assertion::between(count($split), 2, 2);
-        Assertion::keyExists( $this->action, $split[0]);
-        Assertion::keyExists( $this->handlers, $split[1]);
+        Assertion::keyExists($this->action, $split[0]);
+        Assertion::keyExists($this->handlers, $split[1]);
 
         return ['action' => $split[0], 'handler' => $split[1]];
     }

helpers/helpers.php

Spacing +2 added lines, -2 removed lines

@@ -2,7 +2,7 @@ 
 
 use Illuminate\Container\Container;
 
-if (! function_exists('config')) {
+if (!function_exists('config')) {
     /**
      * Get / set the specified configuration value.
      *
@@ -26,7 +26,7 @@ 
     }
 }
 
-if (! function_exists('app')) {
+if (!function_exists('app')) {
     /**
      * Get the available container instance.
      *

src/ServiceProviders/LoggerServiceProvider.php

Indentation +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
     {
         app()->bind(Logger::class, function(){
             $log = new Logger(KernelBpm::class);
-           return  $log->pushHandler(new StreamHandler(KernelBpm::PATH_LOG, Logger::DEBUG));
+            return  $log->pushHandler(new StreamHandler(KernelBpm::PATH_LOG, Logger::DEBUG));
         });
     }
 }
\ No newline at end of file

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 
     public function register()
     {
-        app()->bind(Logger::class, function(){
+        app()->bind(Logger::class, function() {
             $log = new Logger(KernelBpm::class);
            return  $log->pushHandler(new StreamHandler(KernelBpm::PATH_LOG, Logger::DEBUG));
         });

src/Assistants/QueryBuilder.php

Indentation +2 added lines, -2 removed lines

@@ -66,8 +66,8 @@
         $body = [
             'body' => $this->kernel->getHandler()->create($this->data)
         ];
-         $this->merge($body);
-         return $this;
+            $this->merge($body);
+            return $this;
     }
 
     private function merge(array $newParameters)

Spacing +2 added lines, -2 removed lines

@@ -11,7 +11,7 @@ 
 
     public function getCookie()
     {
-        $curl = ['curl' => [ CURLOPT_COOKIEFILE => app(Authentication::class)->getPathCookieFile()]];
+        $curl = ['curl' => [CURLOPT_COOKIEFILE => app(Authentication::class)->getPathCookieFile()]];
         $this->merge($curl);
         return $this;
     }
@@ -39,7 +39,7 @@ 
 
     public function debug()
     {
-        $debug  = ['on_stats' => function (TransferStats $stats) {
+        $debug = ['on_stats' => function(TransferStats $stats) {
             app(Logger::class)->debug('api',
                 [
                     'time'    =>  $stats->getTransferTime(),