Sluggable::createSlug() - Code Metrics - Inspection of "Merge branch 'hotfix-1.0.41'" - afrittella/back-project - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5119fb...242f35 )

by Andrea

created 2017-05-12 17:18 UTC

Sluggable::createSlug() B

↳ Parent: Sluggable

Complexity

Conditions	4
Paths	4

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	13
c	1
b	0
f	0
nc	4
nop	2
dl	0
loc	23
rs	8.7972

<?php
namespace Afrittella\BackProject\Traits;

trait Sluggable
{
    /**
     * Create a unique slug
     * @param $value
     * @param $id
     * @return string
     */
    public function createSlug($value, $id = 0)
    {
        $slug = str_slug($value);

        $relatedSlugs = $this->getRelatedSlugs($slug, $id);

        if (!$relatedSlugs->contains('slug', $slug)) {
            return $slug;
        }

        $completed = false;
        $i = 1;

        while ($completed == false) {

            $newSlug = $slug .'-'.$i;
            if (!$relatedSlugs->contains('slug', $newSlug)) {
                return $newSlug;
            }
            $i++;
        }

        return $slug;
    }

    /**
     * Get similar slugs
     * @param $slug
     * @param $id
     * @return mixed
     */
    protected function getRelatedSlugs($slug, $id = 0)
    {
        return $this->select('slug')->where('slug', 'like', $slug.'%')->where('id', '<>', $id)->get();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}

1			<?php
2			namespace Afrittella\BackProject\Traits;
3
4			trait Sluggable
5			{
6			/**
7			* Create a unique slug
8			* @param $value
9			* @param $id
10			* @return string
11			*/
12			public function createSlug($value, $id = 0)
13			{
14			$slug = str_slug($value);
15
16			$relatedSlugs = $this->getRelatedSlugs($slug, $id);
17
18			if (!$relatedSlugs->contains('slug', $slug)) {
19			return $slug;
20			}
21
22			$completed = false;
23			$i = 1;
24
25			while ($completed == false) {
			0 ignored issues – show Coding Style Best Practice introduced 2017-05-12 17:21 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
26			$newSlug = $slug .'-'.$i;
27			if (!$relatedSlugs->contains('slug', $newSlug)) {
28			return $newSlug;
29			}
30			$i++;
31			}
32
33			return $slug;
34			}
35
36			/**
37			* Get similar slugs
38			* @param $slug
39			* @param $id
40			* @return mixed
41			*/
42			protected function getRelatedSlugs($slug, $id = 0)
43			{
44			return $this->select('slug')->where('slug', 'like', $slug.'%')->where('id', '<>', $id)->get();
			0 ignored issues – show Bug introduced 2017-05-12 17:21 UTC by Report Bug Copy Issue Report It seems like `select()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45			}
46			}

afrittella / back-project

GitHub Access Token became invalid

Push — master ( 5119fb...242f35 )

Sluggable::createSlug() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like