Afrittella\BackProject\Traits\Sluggable

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	createSlug()	0	23	4
A	getRelatedSlugs()	0	4	1

<?php
namespace Afrittella\BackProject\Traits;

trait Sluggable
{
    /**
     * Create a unique slug
     * @param $value
     * @param $id
     * @return string
     */
    public function createSlug($value, $id = 0)
    {
        $slug = str_slug($value);

        $relatedSlugs = $this->getRelatedSlugs($slug, $id);

        if (!$relatedSlugs->contains('slug', $slug)) {
            return $slug;
        }

        $completed = false;
        $i = 1;

        while ($completed == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $newSlug = $slug .'-'.$i;
            if (!$relatedSlugs->contains('slug', $newSlug)) {
                return $newSlug;
            }
            $i++;
        }

        return $slug;
    }

    /**
     * Get similar slugs
     * @param $slug
     * @param $id
     * @return mixed
     */
    protected function getRelatedSlugs($slug, $id = 0)
    {
        return $this->select('slug')->where('slug', 'like', $slug.'%')->where('id', '<>', $id)->get();

It seems like select() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}