BindingManager::getBindingRequest() - Code Metrics - aerialship/SamlSPBundle - Measure and Improve Code Quality continuously with Scrutinizer

BindingManager::getBindingRequest() A
last analyzed 2016-01-11 06:31 UTC

↳ Parent: BindingManager

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	10
rs	9.4286
cc	1
eloc	7
nc	1
nop	1

<?php

namespace AerialShip\SamlSPBundle\Bridge;

use AerialShip\LightSaml\Binding\BindingDetector;
use Symfony\Component\HttpFoundation\Request;

class BindingManager extends BindingDetector
{

    /**
     * @param Request $request
     * @return null|string
     */
    public function getBindingType(Request $request)
    {
        $bindingRequest = $this->getBindingRequest($request);
        $bindingType = $this->getBinding($bindingRequest);
        return $bindingType;
    }

    /**
     * @param Request $request
     * @param $bindingType
     * @return \AerialShip\LightSaml\Model\Protocol\Message|null
     */
    public function receive(Request $request, &$bindingType = null)
    {
        $result = null;
        $bindingRequest = $this->getBindingRequest($request);
        $bindingType = $this->getBinding($bindingRequest);
        if ($bindingType) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $binding = $this->instantiate($bindingType);
            $result = $binding->receive($bindingRequest);
        }
        return $result;
    }


    /**
     * @param Request $request
     * @return \AerialShip\LightSaml\Binding\Request
     */
    public function getBindingRequest(Request $request)
    {
        $result = new \AerialShip\LightSaml\Binding\Request();
        // must be taken unmodified from server since getQueryString() capitalized urlenocoded escape chars, ie. %2f becomes %2F
        $result->setQueryString($request->server->get('QUERY_STRING'));
        $result->setGet($request->query->all());
        $result->setPost($request->request->all());
        $result->setRequestMethod($request->getMethod());
        return $result;
    }
} 


1			<?php
2
3			namespace AerialShip\SamlSPBundle\Bridge;
4
5			use AerialShip\LightSaml\Binding\BindingDetector;
6			use Symfony\Component\HttpFoundation\Request;
7
8			class BindingManager extends BindingDetector
9			{
10
11			/**
12			* @param Request $request
13			* @return null\|string
14			*/
15			public function getBindingType(Request $request)
16			{
17			$bindingRequest = $this->getBindingRequest($request);
18			$bindingType = $this->getBinding($bindingRequest);
19			return $bindingType;
20			}
21
22			/**
23			* @param Request $request
24			* @param $bindingType
25			* @return \AerialShip\LightSaml\Model\Protocol\Message\|null
26			*/
27			public function receive(Request $request, &$bindingType = null)
28			{
29			$result = null;
30			$bindingRequest = $this->getBindingRequest($request);
31			$bindingType = $this->getBinding($bindingRequest);
32			if ($bindingType) {
			0 ignored issues – show Bug Best Practice introduced 2016-01-03 07:59 UTC by Report Bug Copy Issue Report The expression `$bindingType` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
33			$binding = $this->instantiate($bindingType);
34			$result = $binding->receive($bindingRequest);
35			}
36			return $result;
37			}
38
39
40			/**
41			* @param Request $request
42			* @return \AerialShip\LightSaml\Binding\Request
43			*/
44			public function getBindingRequest(Request $request)
45			{
46			$result = new \AerialShip\LightSaml\Binding\Request();
47			// must be taken unmodified from server since getQueryString() capitalized urlenocoded escape chars, ie. %2f becomes %2F
48			$result->setQueryString($request->server->get('QUERY_STRING'));
49			$result->setGet($request->query->all());
50			$result->setPost($request->request->all());
51			$result->setRequestMethod($request->getMethod());
52			return $result;
53			}
54			}
55

aerialship / SamlSPBundle

BindingManager::getBindingRequest() A last analyzed 2016-01-11 06:31 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BindingManager::getBindingRequest() A
last analyzed 2016-01-11 06:31 UTC