AerialShip\SamlSPBundle\Bridge\BindingManager

Complexity

Total Complexity

4

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getBindingType()	0	6	1
A	receive()	0	11	2
A	getBindingRequest()	0	10	1

<?php

namespace AerialShip\SamlSPBundle\Bridge;

use AerialShip\LightSaml\Binding\BindingDetector;
use Symfony\Component\HttpFoundation\Request;

class BindingManager extends BindingDetector
{

    /**
     * @param Request $request
     * @return null|string
     */
    public function getBindingType(Request $request)
    {
        $bindingRequest = $this->getBindingRequest($request);
        $bindingType = $this->getBinding($bindingRequest);
        return $bindingType;
    }

    /**
     * @param Request $request
     * @param $bindingType
     * @return \AerialShip\LightSaml\Model\Protocol\Message|null
     */
    public function receive(Request $request, &$bindingType = null)
    {
        $result = null;
        $bindingRequest = $this->getBindingRequest($request);
        $bindingType = $this->getBinding($bindingRequest);
        if ($bindingType) {

The expression $bindingType of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $binding = $this->instantiate($bindingType);
            $result = $binding->receive($bindingRequest);
        }
        return $result;
    }


    /**
     * @param Request $request
     * @return \AerialShip\LightSaml\Binding\Request
     */
    public function getBindingRequest(Request $request)
    {
        $result = new \AerialShip\LightSaml\Binding\Request();
        // must be taken unmodified from server since getQueryString() capitalized urlenocoded escape chars, ie. %2f becomes %2F
        $result->setQueryString($request->server->get('QUERY_STRING'));
        $result->setGet($request->query->all());
        $result->setPost($request->request->all());
        $result->setRequestMethod($request->getMethod());
        return $result;
    }
}