Inspection of "Adição de método para obter resposta da requisição" - adrianolaselva/controlpay-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b3a506...dc1ac5 )

by Adriano

created 2016-10-27 12:42 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -31,8 +31,8 @@  discard block
 block discarded – undo
      */
     public function getByFiltros(Contracts\IntencaoVenda\GetByFiltrosRequest $getByFiltrosRequest)
     {
-        try{
-            $response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $response = $this->_httpClient->post(__FUNCTION__, [
                 'body' => json_encode($getByFiltrosRequest),
             ]);
 
@@ -42,8 +42,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
      */
     public function getById($intencaoVendaId)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'query' => $this->addQueryAdditionalParameters([
                     'intencaoVendaId' => $intencaoVendaId
                 ])
@@ -68,8 +68,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/API/PagamentoExternoApi.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -30,8 +30,8 @@  discard block
 block discarded – undo
      */
     public function getByFiltros(Contracts\PagamentoExterno\GetByFiltrosRequest $getByFiltrosRequest)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'body' => json_encode($getByFiltrosRequest),
             ]);
 
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/API/LoginApi.php 1 patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -31,8 +31,8 @@  discard block
 block discarded – undo
      */
     public function login(Contracts\Login\LoginRequest $loginRequest)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'body' => json_encode($loginRequest)
             ]);
 
@@ -42,8 +42,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }
@@ -54,14 +54,14 @@  discard block
 block discarded – undo
      */
     public function logOut()
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[]);
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [ ]);
 
             return true;
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }
@@ -73,8 +73,8 @@  discard block
 block discarded – undo
      */
     public function consultaLogin(Contracts\Login\ConsultaLoginRequest $consultaLoginRequest)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'body' => json_encode($consultaLoginRequest)
             ]);
 
@@ -84,8 +84,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/API/TerminalApi.php 1 patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -30,8 +30,8 @@  discard block
 block discarded – undo
      */
     public function getByPessoaId($pessoaId)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'query' => $this->addQueryAdditionalParameters([
                     'pessoaId' => $pessoaId
                 ])
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }
@@ -56,8 +56,8 @@  discard block
 block discarded – undo
      */
     public function getById($terminalId)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'query' => $this->addQueryAdditionalParameters([
                     'terminalId' => $terminalId
                 ])
@@ -69,8 +69,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
      */
     public function insert(Contracts\Terminal\InsertRequest $insertRequest)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'body' => json_encode($insertRequest)
             ]);
 
@@ -93,8 +93,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/API/VendaApi.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -36,8 +36,8 @@  discard block
 block discarded – undo
      */
     public function vender(Contracts\Venda\VenderRequest $venderRequest)
     {
-        try{
-            $this->response = $this->_httpClient->post(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->post(__FUNCTION__, [
                 'body' => json_encode($venderRequest),
             ]);
 
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }

Please login to merge, or discard this patch.

src/Integracao/ControlPay/API/ProdutoApi.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -30,8 +30,8 @@  discard block
 block discarded – undo
      */
     public function getByAtivosByPessoaId($pessoaId)
     {
-        try{
-            $this->response = $this->_httpClient->get(__FUNCTION__,[
+        try {
+            $this->response = $this->_httpClient->get(__FUNCTION__, [
                 'query' => $this->addQueryAdditionalParameters([
                     'pessoaId' => $pessoaId
                 ])
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
             );
         }catch (RequestException $ex) {
             $responseBody = $ex->getResponse()->json();
-            throw new \Exception($responseBody['message']);
-        }catch (\Exception $ex){
+            throw new \Exception($responseBody[ 'message' ]);
+        }catch (\Exception $ex) {
             throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
         }
     }

Please login to merge, or discard this patch.

		@@ -31,8 +31,8 @@ discard block
		block discarded – undo
31	31	*/
32	32	public function getByFiltros(Contracts\IntencaoVenda\GetByFiltrosRequest $getByFiltrosRequest)
33	33	{
34		- try{
35		- $response = $this->_httpClient->post(__FUNCTION__,[
	34	+ try {
	35	+ $response = $this->_httpClient->post(__FUNCTION__, [
36	36	'body' => json_encode($getByFiltrosRequest),
37	37	]);
38	38
		@@ -42,8 +42,8 @@ discard block
		block discarded – undo
42	42	);
43	43	}catch (RequestException $ex) {
44	44	$responseBody = $ex->getResponse()->json();
45		- throw new \Exception($responseBody['message']);
46		- }catch (\Exception $ex){
	45	+ throw new \Exception($responseBody[ 'message' ]);
	46	+ }catch (\Exception $ex) {
47	47	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
48	48	}
49	49	}
		@@ -55,8 +55,8 @@ discard block
		block discarded – undo
55	55	*/
56	56	public function getById($intencaoVendaId)
57	57	{
58		- try{
59		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	58	+ try {
	59	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
60	60	'query' => $this->addQueryAdditionalParameters([
61	61	'intencaoVendaId' => $intencaoVendaId
62	62	])
		@@ -68,8 +68,8 @@ discard block
		block discarded – undo
68	68	);
69	69	}catch (RequestException $ex) {
70	70	$responseBody = $ex->getResponse()->json();
71		- throw new \Exception($responseBody['message']);
72		- }catch (\Exception $ex){
	71	+ throw new \Exception($responseBody[ 'message' ]);
	72	+ }catch (\Exception $ex) {
73	73	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
74	74	}
75	75	}

		@@ -30,8 +30,8 @@ discard block
		block discarded – undo
30	30	*/
31	31	public function getByFiltros(Contracts\PagamentoExterno\GetByFiltrosRequest $getByFiltrosRequest)
32	32	{
33		- try{
34		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	33	+ try {
	34	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
35	35	'body' => json_encode($getByFiltrosRequest),
36	36	]);
37	37
		@@ -41,8 +41,8 @@ discard block
		block discarded – undo
41	41	);
42	42	}catch (RequestException $ex) {
43	43	$responseBody = $ex->getResponse()->json();
44		- throw new \Exception($responseBody['message']);
45		- }catch (\Exception $ex){
	44	+ throw new \Exception($responseBody[ 'message' ]);
	45	+ }catch (\Exception $ex) {
46	46	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
47	47	}
48	48	}

		@@ -31,8 +31,8 @@ discard block
		block discarded – undo
31	31	*/
32	32	public function login(Contracts\Login\LoginRequest $loginRequest)
33	33	{
34		- try{
35		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	34	+ try {
	35	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
36	36	'body' => json_encode($loginRequest)
37	37	]);
38	38
		@@ -42,8 +42,8 @@ discard block
		block discarded – undo
42	42	);
43	43	}catch (RequestException $ex) {
44	44	$responseBody = $ex->getResponse()->json();
45		- throw new \Exception($responseBody['message']);
46		- }catch (\Exception $ex){
	45	+ throw new \Exception($responseBody[ 'message' ]);
	46	+ }catch (\Exception $ex) {
47	47	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
48	48	}
49	49	}
		@@ -54,14 +54,14 @@ discard block
		block discarded – undo
54	54	*/
55	55	public function logOut()
56	56	{
57		- try{
58		- $this->response = $this->_httpClient->post(__FUNCTION__,[]);
	57	+ try {
	58	+ $this->response = $this->_httpClient->post(__FUNCTION__, [ ]);
59	59
60	60	return true;
61	61	}catch (RequestException $ex) {
62	62	$responseBody = $ex->getResponse()->json();
63		- throw new \Exception($responseBody['message']);
64		- }catch (\Exception $ex){
	63	+ throw new \Exception($responseBody[ 'message' ]);
	64	+ }catch (\Exception $ex) {
65	65	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
66	66	}
67	67	}
		@@ -73,8 +73,8 @@ discard block
		block discarded – undo
73	73	*/
74	74	public function consultaLogin(Contracts\Login\ConsultaLoginRequest $consultaLoginRequest)
75	75	{
76		- try{
77		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	76	+ try {
	77	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
78	78	'body' => json_encode($consultaLoginRequest)
79	79	]);
80	80
		@@ -84,8 +84,8 @@ discard block
		block discarded – undo
84	84	);
85	85	}catch (RequestException $ex) {
86	86	$responseBody = $ex->getResponse()->json();
87		- throw new \Exception($responseBody['message']);
88		- }catch (\Exception $ex){
	87	+ throw new \Exception($responseBody[ 'message' ]);
	88	+ }catch (\Exception $ex) {
89	89	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
90	90	}
91	91	}

		@@ -30,8 +30,8 @@ discard block
		block discarded – undo
30	30	*/
31	31	public function getByPessoaId($pessoaId)
32	32	{
33		- try{
34		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	33	+ try {
	34	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
35	35	'query' => $this->addQueryAdditionalParameters([
36	36	'pessoaId' => $pessoaId
37	37	])
		@@ -43,8 +43,8 @@ discard block
		block discarded – undo
43	43	);
44	44	}catch (RequestException $ex) {
45	45	$responseBody = $ex->getResponse()->json();
46		- throw new \Exception($responseBody['message']);
47		- }catch (\Exception $ex){
	46	+ throw new \Exception($responseBody[ 'message' ]);
	47	+ }catch (\Exception $ex) {
48	48	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
49	49	}
50	50	}
		@@ -56,8 +56,8 @@ discard block
		block discarded – undo
56	56	*/
57	57	public function getById($terminalId)
58	58	{
59		- try{
60		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	59	+ try {
	60	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
61	61	'query' => $this->addQueryAdditionalParameters([
62	62	'terminalId' => $terminalId
63	63	])
		@@ -69,8 +69,8 @@ discard block
		block discarded – undo
69	69	);
70	70	}catch (RequestException $ex) {
71	71	$responseBody = $ex->getResponse()->json();
72		- throw new \Exception($responseBody['message']);
73		- }catch (\Exception $ex){
	72	+ throw new \Exception($responseBody[ 'message' ]);
	73	+ }catch (\Exception $ex) {
74	74	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
75	75	}
76	76	}
		@@ -82,8 +82,8 @@ discard block
		block discarded – undo
82	82	*/
83	83	public function insert(Contracts\Terminal\InsertRequest $insertRequest)
84	84	{
85		- try{
86		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	85	+ try {
	86	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
87	87	'body' => json_encode($insertRequest)
88	88	]);
89	89
		@@ -93,8 +93,8 @@ discard block
		block discarded – undo
93	93	);
94	94	}catch (RequestException $ex) {
95	95	$responseBody = $ex->getResponse()->json();
96		- throw new \Exception($responseBody['message']);
97		- }catch (\Exception $ex){
	96	+ throw new \Exception($responseBody[ 'message' ]);
	97	+ }catch (\Exception $ex) {
98	98	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
99	99	}
100	100	}

		@@ -36,8 +36,8 @@ discard block
		block discarded – undo
36	36	*/
37	37	public function vender(Contracts\Venda\VenderRequest $venderRequest)
38	38	{
39		- try{
40		- $this->response = $this->_httpClient->post(__FUNCTION__,[
	39	+ try {
	40	+ $this->response = $this->_httpClient->post(__FUNCTION__, [
41	41	'body' => json_encode($venderRequest),
42	42	]);
43	43
		@@ -47,8 +47,8 @@ discard block
		block discarded – undo
47	47	);
48	48	}catch (RequestException $ex) {
49	49	$responseBody = $ex->getResponse()->json();
50		- throw new \Exception($responseBody['message']);
51		- }catch (\Exception $ex){
	50	+ throw new \Exception($responseBody[ 'message' ]);
	51	+ }catch (\Exception $ex) {
52	52	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
53	53	}
54	54	}

		@@ -30,8 +30,8 @@ discard block
		block discarded – undo
30	30	*/
31	31	public function getByAtivosByPessoaId($pessoaId)
32	32	{
33		- try{
34		- $this->response = $this->_httpClient->get(__FUNCTION__,[
	33	+ try {
	34	+ $this->response = $this->_httpClient->get(__FUNCTION__, [
35	35	'query' => $this->addQueryAdditionalParameters([
36	36	'pessoaId' => $pessoaId
37	37	])
		@@ -43,8 +43,8 @@ discard block
		block discarded – undo
43	43	);
44	44	}catch (RequestException $ex) {
45	45	$responseBody = $ex->getResponse()->json();
46		- throw new \Exception($responseBody['message']);
47		- }catch (\Exception $ex){
	46	+ throw new \Exception($responseBody[ 'message' ]);
	47	+ }catch (\Exception $ex) {
48	48	throw new \Exception($ex->getMessage(), $ex->getCode(), $ex);
49	49	}
50	50	}

adrianolaselva / controlpay-sdk

Push — master ( b3a506...dc1ac5 )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch